[GitHub] nifi issue #3174: NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11

2018-12-12 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3174 Rebased this against current master, but some additional updates need to be made along with some more local testing. Setting this back to WIP while I make these changes... ---

[GitHub] nifi issue #3174: [WIP] NIFI-5820 NiFi built on Java 1.8 can run on Java 9/1...

2018-11-16 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3174 Thanks for taking a look at the PR, @joewitt. That warning is due to accessing, via reflection, the `pid` method on the Process API, which was added in Java 9. The code that does this was added

[GitHub] nifi pull request #3174: [WIP] NIFI-5820 NiFi built on Java 1.8 can run on J...

2018-11-15 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/3174 [WIP] NIFI-5820 NiFi built on Java 1.8 can run on Java 9/10/11 Updated RunNiFi.java to add libs need to run on Java 11 when it is the detected runtime java version and grant access to the necessary

[GitHub] nifi issue #3129: NIFI-5748 Fixed proxy header support to use X-Forwarded-Ho...

2018-11-12 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3129 @mcgilman @kevdoran @alopresto @thenatog The PR is ready for review. https://github.com/jtstorck/proxy-nifi-docker can be used to test the PR, and there are instructions for starting it up

[GitHub] nifi issue #3129: [WIP] NIFI-5748 Fixed proxy header support to use X-Forwar...

2018-11-06 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3129 https://github.com/jtstorck/proxy-nifi-docker can be used to test this PR. There's an issue in NiFi with the handling of X-Forwarded-Host when Knox is proxying NiFi, which doesn't currently

[GitHub] nifi issue #3129: [WIP] NIFI-5748 Fixed proxy header support to use X-Forwar...

2018-11-05 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3129 I'll be adding some docker-compose content for testing this PR. ---

[GitHub] nifi pull request #3129: [WIP] NIFI-5748 Fixed proxy header support to use X...

2018-11-05 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/3129 [WIP] NIFI-5748 Fixed proxy header support to use X-Forwarded-Host instead … …of X-ForwardedServer Added support for the context path header used by Traefik when proxying a service (X

[GitHub] nifi-site pull request #32: NIFI-5773 Added some steps and details to the re...

2018-10-31 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi-site/pull/32 NIFI-5773 Added some steps and details to the release process Fixed several formatting problems with lists and bullet points Removed some extraneous mentions of "NIFI-"

[GitHub] nifi issue #3102: NIFI-5737: Removing need client auth property as cluster c...

2018-10-22 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3102 Based on @markap14 giving a +1 on the JIRA (https://issues.apache.org/jira/browse/NIFI-5737) and @thenatog's testing, I'll merge this so that it will be part of NiFi 1.8.0 RC3. ---

[GitHub] nifi issue #3092: NIFI-5525 - CSVRecordReader fails with StringIndexOutOfBou...

2018-10-22 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3092 @patricker I'm hoping to get this PR merged in for NiFi 1.8.0 RC3 today. Could you please check the newest changes and merge if you are a +1? ---

[GitHub] nifi issue #3097: Revert "NIFI-4558 - Set JKS as the default keystore type a...

2018-10-20 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3097 +1, merged to master. I verified that the changes have been reverted, and that the full build with tests and contrib-check is successful. ---

[GitHub] nifi issue #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper port t...

2018-10-17 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3089 +1 LGTM. Merging! Thanks for this documentation, @andrewmlim! ---

[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...

2018-10-17 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226051004 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories

[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...

2018-10-17 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226048817 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories

[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...

2018-10-17 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226036575 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories

[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...

2018-10-17 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226037655 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories

[GitHub] nifi pull request #3089: NIFI-5653 Added default NiFi and Embedded Zookeeper...

2018-10-17 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3089#discussion_r226037414 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -73,9 +73,38 @@ When NiFi first starts up, the following files and directories

[GitHub] nifi pull request #3080: NIFI-5701 Add documentation for Load Balancing conn...

2018-10-16 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3080#discussion_r225686661 --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc --- @@ -986,13 +991,11 @@ automatically be 'cloned', and a copy will be sent to each of those

[GitHub] nifi pull request #3080: NIFI-5701 Add documentation for Load Balancing conn...

2018-10-16 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3080#discussion_r225654613 --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc --- @@ -636,21 +637,24 @@ For example: For additional information and examples, see

[GitHub] nifi pull request #3080: NIFI-5701 Add documentation for Load Balancing conn...

2018-10-16 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3080#discussion_r225673660 --- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc --- @@ -986,13 +991,11 @@ automatically be 'cloned', and a copy will be sent to each of those

[GitHub] nifi pull request #3071: NIFI-5696 Update references to default value for ni...

2018-10-12 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/3071 NIFI-5696 Update references to default value for nifi.cluster.node.lo… …ad.load.balance.port Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi pull request #3056: NIFI-5659 Add documentation for Offloading Nodes fu...

2018-10-10 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3056#discussion_r224164285 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -2393,19 +2395,53 @@ When the DFM makes changes to the dataflow, the node

[GitHub] nifi pull request #3056: NIFI-5659 Add documentation for Offloading Nodes fu...

2018-10-10 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3056#discussion_r224160990 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -2393,19 +2395,53 @@ When the DFM makes changes to the dataflow, the node

[GitHub] nifi pull request #3056: NIFI-5659 Add documentation for Offloading Nodes fu...

2018-10-10 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3056#discussion_r224150506 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -2393,19 +2395,53 @@ When the DFM makes changes to the dataflow, the node

[GitHub] nifi pull request #3056: NIFI-5659 Add documentation for Offloading Nodes fu...

2018-10-09 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3056#discussion_r223919361 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -3939,8 +3976,7 @@ to the cluster. It provides an additional layer of security

[GitHub] nifi pull request #3056: NIFI-5659 Add documentation for Offloading Nodes fu...

2018-10-09 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3056#discussion_r223919080 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -2393,19 +2395,53 @@ When the DFM makes changes to the dataflow, the node

[GitHub] nifi issue #2884: NIFI-3993 Updated the ZooKeeper version to 3.4.10

2018-10-09 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2884 @HorizonNet No objections. Feel free to close the PR. ---

[GitHub] nifi pull request #3056: NIFI-5659 Add documentation for Offloading Nodes fu...

2018-10-09 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3056#discussion_r223914705 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -3939,8 +3976,7 @@ to the cluster. It provides an additional layer of security

[GitHub] nifi pull request #3056: NIFI-5659 Add documentation for Offloading Nodes fu...

2018-10-09 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3056#discussion_r223912939 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -2393,19 +2395,53 @@ When the DFM makes changes to the dataflow, the node

[GitHub] nifi issue #3055: NIFI-5600: Fixing columns in queue listing and component s...

2018-10-09 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3055 Just tested this PR after cherry-picking the commit into a branch off of the offloading PR (PR 3010), and it looks good on the queue listing and in provenance; the node on which the files are queued

[GitHub] nifi pull request #3056: NIFI-5659 Add documentation for Offloading Nodes fu...

2018-10-09 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3056#discussion_r223855961 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -2393,19 +2395,53 @@ When the DFM makes changes to the dataflow, the node

[GitHub] nifi issue #3055: NIFI-5600: Fixing columns in queue listing and component s...

2018-10-09 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3055 Reviewing... ---

[GitHub] nifi issue #2947: NIFI-5516: Implement Load-Balanced Connections

2018-10-04 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2947 @markap14 Based on @ijokarumawak's +1, and my testing of this PR along with the changes in my PR for node offloading, I'm a +1 as well. Will merge this ASAP! Thanks for this awesome

[GitHub] nifi issue #2971: NIFI-5557: handling expired ticket by rollback and penaliz...

2018-09-27 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2971 +1, merged to master. Had to resolve some conflicts in my commit for PutHDFSTest after rebasing to master. Thanks for your contribution, @ekovacs! ---

[GitHub] nifi pull request #2971: NIFI-5557: handling expired ticket by rollback and ...

2018-09-25 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2971#discussion_r220204503 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java --- @@ -389,16 +380,24

[GitHub] nifi pull request #2971: NIFI-5557: handling expired ticket by rollback and ...

2018-09-25 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2971#discussion_r220206853 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java --- @@ -389,16 +380,24

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-24 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r220008088 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/partition

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-24 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r22790 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/partition

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-24 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r22647 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-24 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r22525 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-21 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r219612683 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowService.java

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-21 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r219607209 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/replication

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-21 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r219602056 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-21 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r219601868 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/node

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-21 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r219599828 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/node

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-21 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r219599522 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/node

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-21 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r219599484 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/node

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-21 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r219599165 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/node

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-21 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/3010#discussion_r219598024 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/coordination

[GitHub] nifi pull request #2971: NIFI-5557: handling expired ticket by rollback and ...

2018-09-20 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2971#discussion_r219380028 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java --- @@ -266,6 +271,16

[GitHub] nifi pull request #2971: NIFI-5557: handling expired ticket by rollback and ...

2018-09-20 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2971#discussion_r219377632 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java --- @@ -266,6 +271,16

[GitHub] nifi issue #3010: [WIP] NIFI-5585

2018-09-20 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3010 While testing the reconnecting of a decommissioned node to the cluster, the issue detailed in [NIFI-5619](https://issues.apache.org/jira/browse/NIFI-5619) was encountered. ---

[GitHub] nifi issue #3010: [WIP] NIFI-5585

2018-09-20 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/3010 While testing the reconnection of a decommissioned node, with ~24,000 files split between the two nodes, an error occurred after reconnecting the decomissioned node and attempting to drop all

[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...

2018-09-19 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2988 @nalewis Can you run the specific NiFiGroovyTest via maven successfully? ---

[GitHub] nifi pull request #3010: [WIP] NIFI-5585

2018-09-18 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/3010 [WIP] NIFI-5585 Please refer to https://issues.apache.org/jira/browse/NIFI-5585 for a description of use-cases for decommissioning nodes. This PR is based off of work that is being done via https

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-18 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r218443074 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/partition

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-17 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r218223624 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/partition

[GitHub] nifi issue #2947: [WIP] NIFI-5516: Implement Load-Balanced Connections

2018-09-15 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2947 @markap14 I created [PR 5600](https://issues.apache.org/jira/browse/NIFI-5600) to add node information to the flowfile queue display. ---

[GitHub] nifi issue #2947: [WIP] NIFI-5516: Implement Load-Balanced Connections

2018-09-14 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2947 @markap14 When listing a queue that is load balanced between two nodes in a cluster, I'm seeing duplicate "Position" IDs. I gather they are unique per node and being represented

[GitHub] nifi pull request #2971: NIFI-5557: handling expired ticket by rollback and ...

2018-09-07 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2971#discussion_r216031690 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java --- @@ -269,13 +272,15

[GitHub] nifi pull request #2971: NIFI-5557: handling expired ticket by rollback and ...

2018-09-07 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2971#discussion_r216037639 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java --- @@ -269,13 +272,15

[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...

2018-09-05 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2988 @nalewis We'd have to investigate if the cause for the TestMinimalLockingWriteAheadLog.testRecoverFileThatHasTrailingNULBytesAndTruncation test failing is the same as what's documented in [NIFI

[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...

2018-09-05 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2988 Regarding this PR, on my Windows 7 desktop, the NiFiGroovyTest in nifi-runtime passes: ``` [INFO] --- [INFO] T E S T S [INFO

[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...

2018-09-04 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2988 I created a Windows 10 VM via VirtualBox on my mac. With a fresh install of: - java ``` java version "1.8.0_181" Java(TM) SE Runtime Environment (build 1.8.0_181-b13

[GitHub] nifi issue #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PAT...

2018-09-04 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2988 I'll be testing this on my Windows machine tonight, but wanted to get the PR up ASAP for those that want to test this. ---

[GitHub] nifi pull request #2988: NIFI-5574 Removed usage of Paths.get() due to TEST_...

2018-09-04 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/2988 NIFI-5574 Removed usage of Paths.get() due to TEST_RES_PATH being res… …olved to a string from a URI, which results in platform-specific path information (C:\) when tests are run on Windows

[GitHub] nifi pull request #2971: NIFI-5557: handling expired ticket by rollback and ...

2018-08-30 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2971#discussion_r214136451 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java --- @@ -266,6 +268,13

[GitHub] nifi issue #2971: NIFI-5557: handling expired ticket by rollback and penaliz...

2018-08-29 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2971 Reviewing... ---

[GitHub] nifi issue #2947: [WIP] NIFI-5516: Implement Load-Balanced Connections

2018-08-14 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2947 Reviewing this WIP PR to help get it ready to merge to master when NiFi Registry is released. ---

[GitHub] nifi issue #2937: NIFI-4434 Fixed recursive listing with a custom regex filt...

2018-08-07 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2937 @ottobackwards @zenfenan I added additional details to give some examples on how to use the filters. Please let me know if you think more detail is needed. I appreciate the review! ---

[GitHub] nifi issue #2937: NIFI-4434 Fixed recursive listing with a custom regex filt...

2018-08-07 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2937 @ottobackwards @zenfenan I'll break out my rusty HTML skills and try to write up some extra documentation with examples/usecases. Hopefully in an hour or two I'll have an update for the PR. Thanks

[GitHub] nifi issue #2937: NIFI-4434 Fixed recursive listing with a custom regex filt...

2018-08-06 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2937 @ottobackwards Regarding documentation for the filter modes, descriptions have been created for the allowable values. Do these descriptions not seem adequate for the functionality of each mode? ---

[GitHub] nifi pull request #2937: NIFI-4434 Fixed recursive listing with a custom reg...

2018-08-06 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2937#discussion_r208072541 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/ListHDFS.java --- @@ -462,11 +523,15

[GitHub] nifi issue #2937: NIFI-4434 Fixed recursive listing with a custom regex filt...

2018-08-06 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2937 [PR 2930](https://github.com/apache/nifi/pull/2930) was closed due to the branch in my fork being removed before adding the new filter-mode-based changes. @bbende @ottobackwards, this PR implements

[GitHub] nifi pull request #2937: NIFI-4434 Fixed recursive listing with a custom reg...

2018-08-06 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/2937 NIFI-4434 Fixed recursive listing with a custom regex filter. Filter modes are now supported to perform listings based on directory and file names, file-names only, and full path. Thank

[GitHub] nifi issue #2930: NIFI-4434 Fixed recursive listing with a custom regex filt...

2018-08-06 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2930 Accidently deleted my remote branch while updating this PR. It doesn't look like I can reopen this PR. I'll create another PR with the updated code. ---

[GitHub] nifi pull request #2930: NIFI-4434 Fixed recursive listing with a custom reg...

2018-08-06 Thread jtstorck
Github user jtstorck closed the pull request at: https://github.com/apache/nifi/pull/2930 ---

[GitHub] nifi issue #2930: NIFI-4434 Fixed recursive listing with a custom regex filt...

2018-08-02 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2930 I'll update the PR so that the three modes are available, and make sure the default mode keeps the current behavior. I'll add tests for the two new modes. Thanks for the input, @bbende

[GitHub] nifi issue #2930: NIFI-4434 Fixed recursive listing with a custom regex filt...

2018-08-02 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2930 @ottobackwards That's a good combination of solutions! We need to decide if we want to put the full weight of complex regex on the user, or if it's more simple all-around by toggling between file

[GitHub] nifi issue #2930: NIFI-4434 Fixed recursive listing with a custom regex filt...

2018-08-02 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2930 @bbende @joewitt This PR changes the default behavior of how the filter is applied during a listing, which might require manual migration efforts for some users. We could add

[GitHub] nifi pull request #2930: NIFI-4434 Fixed recursive listing with a custom reg...

2018-08-01 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/2930 NIFI-4434 Fixed recursive listing with a custom regex filter. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #2884: NIFI-3993 Updated the ZooKeeper version to 3.4.10

2018-07-24 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2884 @HorizonNet I'm not familiar with the issue described in NIFI-3993, or what scenarios cause it to happen. I did read [the referenced JIRA](https://issues.apache.org/jira/browse/ZOOKEEPER-2044

[GitHub] nifi issue #2884: NIFI-3993 Updated the ZooKeeper version to 3.4.10

2018-07-13 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2884 @joewitt I brought up the upgrade a while ago, but many of the services/components we integrate with are using Zookeeper 3.4.6. Originally I wanted to use a newer version that did not explicitly

[GitHub] nifi issue #2821: NIFI-5341 Enabled groovy tests in nifi-runtime

2018-06-27 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2821 @joewitt @alopresto This PR modifies code that was worked on by the two of you. I think there will be some discussion of the fixes, but I wanted to get a PR up ASAP to start the review process

[GitHub] nifi pull request #2821: NIFI-5341 Enabled groovy tests in nifi-runtime

2018-06-27 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/2821 NIFI-5341 Enabled groovy tests in nifi-runtime Fixed tests in NiFiGroovyTest in the nifi-runtime module Updated NiFi.createBootstrapClassLoader to log a warning if lib/bootstrap does not exist

[GitHub] nifi pull request #2747: NIFI-5249 Dockerfile enhancements

2018-06-13 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2747#discussion_r195304620 --- Diff: nifi-docker/dockermaven/Dockerfile --- @@ -26,23 +26,33 @@ ARG NIFI_BINARY ENV NIFI_BASE_DIR /opt/nifi ENV NIFI_HOME $NIFI_BASE_DIR

[GitHub] nifi pull request #2747: NIFI-5249 Dockerfile enhancements

2018-06-13 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2747#discussion_r195240352 --- Diff: nifi-docker/dockermaven/integration-test.sh --- @@ -0,0 +1,35 @@ +#!/bin/bash --- End diff -- This script is missing the license

[GitHub] nifi pull request #2747: NIFI-5249 Dockerfile enhancements

2018-06-13 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2747#discussion_r195262129 --- Diff: nifi-docker/dockermaven/Dockerfile --- @@ -26,23 +26,33 @@ ARG NIFI_BINARY ENV NIFI_BASE_DIR /opt/nifi ENV NIFI_HOME $NIFI_BASE_DIR

[GitHub] nifi pull request #2747: NIFI-5249 Dockerfile enhancements

2018-06-04 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2747#discussion_r192208160 --- Diff: nifi-docker/dockerhub/Dockerfile --- @@ -25,28 +25,37 @@ ARG GID=1000 ARG NIFI_VERSION=1.7.0 ARG MIRROR=https://archive.apache.org/dist

[GitHub] nifi issue #2746: NIFI-5247 NiFi toolkit signal handling changes, Dockerfile...

2018-06-01 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2746 Contrib build passes, and was able to reproduce your example usages of invoking the toolkit and observing the exit codes. +1, merging to master. Thanks for your contribution, @pepov! ---

[GitHub] nifi pull request #2746: NIFI-5247 NiFi toolkit signal handling changes, Doc...

2018-05-31 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2746#discussion_r192240524 --- Diff: nifi-toolkit/nifi-toolkit-assembly/docker/tests/exit-codes.sh --- @@ -0,0 +1,35 @@ +#!/bin/bash --- End diff -- This file needs

[GitHub] nifi pull request #2746: NIFI-5247 NiFi toolkit signal handling changes, Doc...

2018-05-31 Thread jtstorck
Github user jtstorck commented on a diff in the pull request: https://github.com/apache/nifi/pull/2746#discussion_r192240688 --- Diff: nifi-toolkit/nifi-toolkit-assembly/docker/tests/tls-toolkit.sh --- @@ -0,0 +1,17 @@ +#!/bin/bash --- End diff -- This file needs

[GitHub] nifi pull request #2708: NIFI-5175 Updated NiFi compiled on Java 1.8 to run ...

2018-05-16 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/2708 NIFI-5175 Updated NiFi compiled on Java 1.8 to run on Java 9 The bootstrap process (RunNiFi) detects Java 9 and adds "--add-modules=java.xml.bind" to the command to start NiFi Updat

[GitHub] nifi issue #2667: NIFI-5134 Explicitly requesting UGI to relogin before atte...

2018-04-30 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2667 @mattyb149, @markap14, would you please review this PR? ---

[GitHub] nifi pull request #2667: NIFI-5134 Explicitly requesting UGI to relogin befo...

2018-04-30 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/2667 NIFI-5134 Explicitly requesting UGI to relogin before attempting to g… …et a DB connection in HiveConnectionPool Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #2582: NIFI-4923 Updated nifi-hadoop-libraries-nar, nifi-hdfs-pro...

2018-04-10 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2582 @MikeThomsen I did run against HDP 2.6. Using client configs downloaded from a secure HDP 2.6 cluster, I was able to test Put/List/Fetch/DeleteHDFS, including TDE directories. ---

[GitHub] nifi pull request #2582: NIFI-4923 Updated nifi-hadoop-libraries-nar, nifi-h...

2018-03-24 Thread jtstorck
GitHub user jtstorck opened a pull request: https://github.com/apache/nifi/pull/2582 NIFI-4923 Updated nifi-hadoop-libraries-nar, nifi-hdfs-processors, an… …d nifi-hadoop-utils dependency on hadoop-client from 2.7.3 to 3.0.0 Thank you for submitting a contribution

[GitHub] nifi issue #2512: NIFI-4936 pushed down version declarations to lowest appro...

2018-03-07 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2512 +1 regarding the HDFS component POM changes. After building with this PR, I tested Put/List/DeleteHDFS processors with TDE paths successfully. ---

[GitHub] nifi issue #2475: NIFI-4872 Added annotation for specifying scenarios in whi...

2018-03-01 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2475 @markap14 I will add descriptions to the annotations for the processors you mentioned. Thanks for the extra info! We can do additional PRs to add more descriptions as needed, but I think

[GitHub] nifi issue #2482: NIFI-4894: Ensuring that any proxy paths are retained when...

2018-02-21 Thread jtstorck
Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/2482 @mcgilman @scottyaslan I was able to reproduce the bug in master while proxying with Knox by creating a HandleHttpRequest processor with a StandardHttpContextMap controller service. Attempting

  1   2   3   >