Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2678
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/115
Thanks @scottyaslan! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/115
Will review...
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2673
NIFI-5135: User identities and group name transforms
NIFI-5135:
- Adding support for applying transforms to user identities and group names.
You can merge this pull request into a Git
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2509
@zenfenan Yeah I think we're on the same page here. Sorry for the different
suggestions earlier but I think we're ultimately getting it right here...
- `All nodes` should be disabled
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2669
Thanks @markap14! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2669
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2662
@alopresto I don't see the commit for this PR in master (unless I'm missing
it). Can you please double check that it was pushed? Thanks!
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2509
Hey @zenfenan... So I just checked out the updated PR. Things seem to be
running as suggested, however, I'm wondering if it makes sense to improve it a
little and in the process reduce
Github user mcgilman closed the pull request at:
https://github.com/apache/nifi/pull/2662
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2662
Thanks @alopresto!
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2662
NIFI-5124: Upgrading commons-fileupload
NIFI-5124:
- Upgrading to the latest version of commons-fileupload.
You can merge this pull request into a Git repository by running:
$ git pull
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2509#discussion_r184162346
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2646
Thanks @markap14! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2646
@markap14 I see. It appears then that the underlying issue is that either
(1) the stateChange method is not being invoked or (2) the leader thread
interruption is not happening/working. We could
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2646
@markap14 Looks like our `LeaderSelectionListener` does implement
`ConnectionStateListener`. Do we need to update code on our side to explicitly
give up leadership in the SUSPENDED or LOST scenarios?
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2646
@markap14 These changes look like they will reduce the time when there are
multiple primaries (leaders) in the event the existing primary isn't notified
of the change. That's definitely
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2633
@andrewmlim When no components are selected both enable/disable and
start/stop should be allowed as the request will be applied to all eligible
components in the current process group.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2633
NIFI-5066: Allow global enable/disable component requests
NIFI-5066:
- Allowing the enable/disable buttons to be active under the same
conditions as the start/stop buttons.
You can merge
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2509#discussion_r181149446
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2509#discussion_r18094
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2626
NIFI-4997: Fixing process group audit advice
NIFI-4997:
- Fixing process group audit advice.
- Setting spring security user in background threads.
- Removing unnecessary overloaded
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2607
@moranr @scottyaslan @markap14 I've addressed the PR feedback above. Please
have a look at my most recent commit. A couple notes:
- I also found and addressed an issue when replicating
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2607#discussion_r179770521
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2608
Thanks @mattyb149. This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2608
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2497
@mosermw Looks great! Thanks, this has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2607
NIFI-1295: Adding UI controls for terminating threads
NIFI-1295:
- Adding UI controls for terminating hung threads.
- Showing current number of terminated threads.
You can merge this pull
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2510
Thanks @ijokarumawak! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2602
The minor issue is addressed.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2602
Minor issue with the proposed solution. Will update soon.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2602
NIFI-5034: Ensuring descriptors and properties of referencing components
are populated like Processors, Reporting Tasks, etc.
NIFI-5034:
- Ensuring descriptors and properties of referencing
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2598
NIFI-5033: Ensuring appropriate response in checkAuthorization when user is
null
NIFI-5033:
- Ensuring appropriate response in checkAuthorization when user is null.
- Ensuring the user
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2510
@ijokarumawak Just wanted to add that I have verified this capability
running standalone and clustered and everything seems to be working nicely.
Just a couple more minor error handling cases
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2510#discussion_r178175082
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/PeerDescriptionModifier.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2510#discussion_r178174688
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/PeerDescriptionModifier.java
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2596
NIFI-5032: Overriding version ranges of transitive dependencies
NIFI-5032:
- Overriding version ranges of transitive dependencies through
oauth2-oidc-sdk.
You can merge this pull request
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2571
Thanks @scottyaslan! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2555
Thanks @markap14! This has been merged to master.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2510#discussion_r177538563
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/PeerDescriptionModifier.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2510#discussion_r177538075
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/PeerDescriptionModifier.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2510#discussion_r177541745
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -3058,6 +3062,258 @@ responses from the remote system for `30 secs`.
This allows NiFi
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2510#discussion_r177536829
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/PeerDescriptionModifier.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2510#discussion_r177542298
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -3058,6 +3062,258 @@ responses from the remote system for `30 secs`.
This allows NiFi
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2510#discussion_r177539731
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/PeerDescriptionModifier.java
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2583
[NIFI-5009] [NIFI-5008]: Addressing restricted component annotations
NIFI-5009:
- Fixing required permission for PutParquet.
NIFI-5008:
- Ensuring all restricted components
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2571
@patricker Thanks for the verification!
@scottyaslan Want to update the other frontend-maven-plugin usage before we
merge this in?
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2573
NIFI-4885: Updating versioning endpoints to account for granular access
restrictions
NIFI-4885:
- Updating the versioning endpoints to account for the granular access
restrictions.
You can
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2510
Will review...
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2555#discussion_r175461456
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractPort.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2555#discussion_r175436468
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessorResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2555#discussion_r175436246
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessorResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2555#discussion_r175455733
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/scheduling
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2497#discussion_r175201659
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-connection-configuration.js
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2497#discussion_r175195219
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ConfigDTO.java
---
@@ -0,0 +1,53
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2497#discussion_r175198349
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-connection-configuration.js
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2497#discussion_r175197796
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowFileQueue.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2497#discussion_r175200879
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ConfigDTO.java
---
@@ -0,0 +1,53
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2497
@mosermw Didn't really have a great option... so the suggestion was
ultimately a compromise. The idea was that About returns information about this
instance of NiFi. This could include some
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2555
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2468
Thanks @markap14! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2551
NIFI-4973: Fix RPG port merging
NIFI-4973:
- Fixing RPG port merging.
- Adding unit tests.
- Removing unecessary sorting that wasn't maintained while clustered.
You can merge this pull
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2539
Thanks @bbende! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2539
Will review...
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2468#discussion_r174137522
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2468#discussion_r174141958
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/diagnostics/RepositoryUsageDTO.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2468#discussion_r174141284
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/entity/ProcessorDiagnosticsEntity.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2468#discussion_r174139485
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/StatusMerger.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2468#discussion_r174137385
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2497
@mosermw @markap14 It's kind of a gray area. I suggested an endpoint like
the /nifi-api/flow/about because that seemed like the best fit currently and
was obviously trying to avoid requiring another
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2519
Thanks @mattyb149! This has been merged to master.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2515#discussion_r173869295
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2532
NIFI-4936: Fix ranger version definition
NIFI-4936:
- Moving definition of ranger version into root pom.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2519
@moonkev I think there a couple different scenario's here. This is
admittedly pretty complicated, but my understanding is as follows:
- In a case like PutHDFS, snappy compression
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2512
Thanks @joewitt! I've merged this to master. I've verified various
framework behavior including standalone vs cluster, ldap authentication, custom
ui's and data viewers. All looks good.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2512
Will review from a framework perspective...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2469
Thanks @alopresto! This has been merged to master.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2468#discussion_r173508849
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/EntityFactory.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2468#discussion_r173512958
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2468#discussion_r173511759
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2468#discussion_r173511910
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2468#discussion_r173513519
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2519
@mattyb149 Previously the loading of Snappy happened during onTrigger. This
could lead to the race condition described in the JIRA/PR. Moving this to a
static initializer should alleviate the issue
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2469
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2479
Thanks @kevdoran! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2524
NIFI-4945: Upgrading spring security version
NIFI-4945:
- Upgrading spring security version.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2479
@kevdoran Sorry, did not notice the mention. Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2515
Thanks for the feedback @andrewmlim! I've pushed another commit addressing
the issue.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2503
Thanks @tasanuma! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2503
Will review...
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2515
NIFI-4885: Granular component restrictions
NIFI-4885:
- Introducing more granular restricted component access policies.
- Current restricted components have been updated to use new granular
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2511
NIFI-4925: Ranger Authorizer Memory Leak
NIFI-4925:
- Addressing memory leak from lingering authorization results that did not
represent actual access attempts.
You can merge this pull request
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2495
NIFI-3502: Ensuring D3 is available on the summary and users page.
NIFI-3502:
- Ensuring D3 is available on the summary and users page.
You can merge this pull request into a Git repository
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2364
Thanks @yuri1969! This has been merged to master.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2471#discussion_r169394276
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-canvas.js
---
@@ -996,34 +1030,42
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2482
NIFI-4894: Ensuring that any proxy paths are retained when querying for
bulletins
NIFI-4894:
- Ensuring that any proxy paths are retained when querying for bulletins.
You can merge this pull
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2472
Thanks @bbende! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2472
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2471
Just pushed a new commit that addresses @andrewmlim findings.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2471
NIFI-3502: Upgrading D3 version
NIFI-3502:
- Upgrading to D3 version 4.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI
201 - 300 of 1112 matches
Mail list logo
