Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2800#discussion_r195934550
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2800#discussion_r195934504
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java
---
@@ -320,6
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2800
This looks good, just two comments.
1. If we are going to add support for non-ascii, the test should test
non-ascii, can we add that?
2. We now have a pattern of use in two places
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2787
The changes to the encoding looks good.
Thanks for the contribution!
+1
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2777
@markap14 that certainly makes sense, thanks for taking the time to respond
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2777
It may be overkill, that is true. But if you have to keep adding new
functions to account for different scenarios that isn't great either and may
suggest something like that would be go
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2787#discussion_r194700389
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java
---
@@ -319,6
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2777
Maybe there should be a `Context` interface, and there can be support for
implementations that support more than one map or type of backing. I think the
limitation here is using a literal Map
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
Thanks everybody!
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@joewitt requested changes are in
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
Thanks @joewitt for clearing that up. I'll get right to it.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
Do I need to add ratcheck exceptions if I remove the headers?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@joewitt
I added the headers because the code was already apache lic. in the
project, I thought that would be the proper thing to do. I ( possibly or
probably wrongly ) thought that if
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2588#discussion_r194380548
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/wag/client
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2588#discussion_r194368856
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/wag/client/Validate.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2778#discussion_r194239526
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoRecord.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2767
Thanks for the info @mosermw
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2767
Can you point out the recursive code you are referencing?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2768
Is there a test that should be created or updated for this change?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2767
mvn package -P contrib-check passes,
code looks good.
The question that comes to my mind is if this is following some
'recommended' way of handling these exceptions, and s
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2748
thanks for the review @mosermw
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2748#discussion_r193422077
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2748#discussion_r193428577
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2748#discussion_r193423188
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2748#discussion_r193371373
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2748#discussion_r193368464
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2760#discussion_r193189510
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2760#discussion_r193183815
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2760
+1 (non-binding), contrib-check build looks good, tests updated.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
I can provide the reviewers with access to my PETSTORE endpoint for testing
and we can work out how not to overload it, if that helps get this going
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2760#discussion_r193133140
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2760#discussion_r193133584
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2760#discussion_r193132253
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2760#discussion_r193132823
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2723#discussion_r192722395
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2747
+1 fwiw|lgtm.
Ran the above steps to build and test the image from the maven snapshots (
not built locally ).
Everything ran fine.
Your integration test is awesome. I'm to
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2747
So to test this?
- mvn package
- mvn package -P docker from nifi-docker
- ???
- docker run --rm -ti --entrypoint /bin/bash apache/nifi -c "env | grep
NIFI" ? from nifi-
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2747
Thanks, I'd like to try this and help with the review
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2747
Can you add explicit steps to test and verify, for those of use who don't
work with docker as much?
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2748
NIFI-4272 support multiple captures when el is present
From the Jira Statement:
```
I am using the ReplaceText processor to take a string input (example:ââ
{"name&qu
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2742
+1 looks good to me
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2742
So the issue was passing the optional instead of the value and never
finding the schema?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2737#discussion_r190990605
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2737#discussion_r190990529
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2737#discussion_r190723484
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2737#discussion_r190721904
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2737#discussion_r190714515
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2737
That makes sense, just thinking it through, and obviously I don't
understand everything as well ;)
I guess I never thought of provenance as including perf and stats stuff, so
it seems
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2737
prob the reader and write would have to get some context passed where they
can track states or increment stats, then be configured with a 'reporting' task
to send the stats from a giv
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2737
@MikeThomsen this is cool.
The only thing it makes me wonder is if this kind of data can't be
automatically generated and sent to a repository, almost like a new ( or a
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2711#discussion_r190291470
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2734#discussion_r190284675
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2711#discussion_r190273915
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2711#discussion_r190271982
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2734#discussion_r190267071
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2734#discussion_r190263349
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
bump, any takers?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
https://github.com/apache/nifi/pull/2727
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2727
@MikeThomsen @ijokarumawak
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2727
NIFI-5220 add aws abstract processor validation for proxy host and
password, and tests
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
https://issues.apache.org/jira/browse/NIFI-5220
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
Once I prove out my fix and update my pr, I'll guess I'll do a PR against
master with that fix?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
I found a bug in this in the aws implementation, I am not sure how you
would see it in the other processors, I found it when bringing this code into
my Gateway Api PR.
The issue is
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2723
@MikeThomsen I agree. I haven't seen any conversation on it, but it seems
more and more obvious, given the way things are going right?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2723
I almost wonder if there should be an http rest connection service
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2723
@MikeThomsen
Here are the properties exposed for configuration of InvokeHttp:
```java
public static final List PROPERTIES =
Collections.unmodifiableList(Arrays.asList
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2723#discussion_r189554397
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2723#discussion_r189554878
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2723
Don't I know it. If you want to do this as a 'series' of prs, I think you
should document that in jira with tasks representing each PR and note it
clearly in the pr.
Th
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2723
This is cool, I will definitely make an aws web api version of this after
it and my pr lands.
I think that any rest service needs to support the options that InvokeHttp
supports. Proxies
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
Should the tests for InvokeHTTP be updated to test with the changes?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@mattyb149 no word on that pr. @jvwing any chance you may be able to
review?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
@ijokarumawak I'm talking about passing around an HttpClientBuilder when
not everyone uses that.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2705
LGTM, +1 FWIW
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2698
Thanks for the review guys
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188355650
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188355616
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188354997
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2705#discussion_r188281072
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractJsonPathProcessor.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
How will this work with the AWS components? They have proxy as well (
although there is a PR for full support ), but a different builder I think
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/1955
@MikeThomsen This change is not related to my pr's. It is concerned with
Nifi behavior when the grok's do not match not with grok behavior itself. It
is still required in as much
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2699#discussion_r188064016
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateXml.java
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2698
NIFI-5077 ExtractGrok support for `keep empty captures`
Support for the new option to keep empty captures. I did not add to the
GrokReader because I am not sure of the effect on
the
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2672
I think making this consistent for testing is a good idea. The fact that
the Mock classes in nifi can replicate the runtime behavior is very important
to implementors.
I think that
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2691
Thanks for the review @MikeThomsen
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2691#discussion_r187774759
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/resources/default-grok-patterns.txt
---
@@ -0,0 +1,115
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2691#discussion_r187774740
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2691#discussion_r187774270
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2675#discussion_r187591727
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2691
NIFI-5170 Upgrad Grok to version 0.1.9
Upgrade to the new java-grok release and update for changes in the library.
This includes:
- Changes to the namespace from io.thekraken to
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
https://github.com/rpgreen/apigateway-generic-java-sdk/pull/8
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
It would be better if we would just use RPGreen's maven dep instead off
bringing in the classes. I have a pr against his repo to upgrade to the same
aws package we use. When that is take
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2668
Is there a test case with the original ML user's issue that can have a test
done? What would also be nice if these things that you changed had a 'report'
method, kind of lik
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2668#discussion_r185277171
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2668#discussion_r185276958
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@zenfenan any chance for a review?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2016
@trixpan can you de-conflict?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2601
Thanks for the review time!
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r183491100
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r183461688
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
201 - 300 of 347 matches
Mail list logo
