[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2018-01-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2016 @pvillard31 will rebase and resubmit... ---

[GitHub] nifi issue #2017: NIFI-4197 - Expose some proxy settings to GCS Processors

2017-12-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2017 @jvwing Apologies for the delay I believe the feedback has been addressed. ---

[GitHub] nifi issue #2348: NIFI-4706 - Bump ParCEFone version

2017-12-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2348 @joewitt my bad. I forked from an old repo. 1.2.6 should be online. ---

[GitHub] nifi pull request #2348: NIFI-4706 - Bump ParCEFone version

2017-12-18 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/2348 NIFI-4706 - Bump ParCEFone version Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps

[GitHub] nifi issue #1968: NIFI-3931 - Added EL to properties in SFTP transfer

2017-07-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1968 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #2022: NIFI-4200 - Initial commit for a ControlNiFi processor

2017-07-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2022 @pvillard31 - I assume the processor should be able to control nifi components only. Should we rename it to make this explicit? --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2017-07-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2016 hopefully fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #2018: NIFI-4175 - Add HTTP proxy support to *SFTP process...

2017-07-18 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2018#discussion_r128152991 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java

[GitHub] nifi issue #1696: NIFI-1655 - Add .gitattributes to specifically define

2017-07-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @jfrazee I resolved conflict with master (unrelated to the change). I would agree that the "text" qualifier was indeed missing. Fixed. --- If your project is set up for it, you

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-07-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1644 @mcgilman - Sorry for the delay. rebased and hopefully addressed the jUnit issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #2018: NIFI-4175 - Add HTTP proxy support to *SFTP process...

2017-07-18 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/2018 NIFI-4175 - Add HTTP proxy support to *SFTP processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi pull request #2017: NIFI-4197 - Expose some proxy settings to GCS Proce...

2017-07-18 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/2017 NIFI-4197 - Expose some proxy settings to GCS Processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2017-07-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2016 Please note the displayName settings were not added as most of the AWS related processors lack these --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #2016: NIFI-4196 - Expose AWS proxy authentication setting...

2017-07-18 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/2016 NIFI-4196 - Expose AWS proxy authentication settings Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi pull request #2013: NIFI-4098 - Adjust ParseCEF to re-use bean validato...

2017-07-16 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/2013 NIFI-4098 - Adjust ParseCEF to re-use bean validator in order to impr… …ove performance Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #1921: NIFI-4081 - Added raw message option in GrokReader

2017-07-15 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1921 @pvillard31 I accept it is a bit of bit picking but is there any chance we call it _raw? IIRC this is the name we used on ParseCEF. Naming conventions make user experience smoother 😀 --- If your

[GitHub] nifi issue #1696: NIFI-1655 - Add .gitattributes to specifically define

2017-07-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @jfrazee? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1950: NIFI-4126 - Add SupportBatching, SideEffectFree and...

2017-06-26 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1950 NIFI-4126 - Add SupportBatching, SideEffectFree and EventDriven annot… …ations to ExtractGrok Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-06-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1644 @mcgilman indeed. Hopefully the last commit should address the remaining ones. Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-06-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1644 @mcgilman Hopefully I managed to address your feedback in this last iteration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-06-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1794 @apiri @jfrazee - should I go ahead and merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1623: NIFI-55 - Log IP of clients generating expired holds and o...

2017-06-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1623 @joewitt any chance of having a look on this PR? Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1541: NIFI-329 - Introduce IRC Client Services and ConsumeIRC pr...

2017-06-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1541 @joewitt feedback should be addressed. @trkurc - special thanks for the review and PR. I have been having been able to commit enough resources to the project lately and your PR certainly

[GitHub] nifi pull request #1541: NIFI-329 - Introduce IRC Client Services and Consum...

2017-06-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1541#discussion_r119568598 --- Diff: nifi-nar-bundles/nifi-irc-bundle/nifi-irc-client-service/src/main/java/org/apache/nifi/irc/StandardIRCClientService.java --- @@ -0,0 +1,233

[GitHub] nifi pull request #1541: NIFI-329 - Introduce IRC Client Services and Consum...

2017-06-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1541#discussion_r119568494 --- Diff: nifi-nar-bundles/nifi-irc-bundle/nifi-irc-processors-nar/pom.xml --- @@ -0,0 +1,41 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1541: NIFI-329 - Introduce IRC Client Services and Consum...

2017-06-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1541#discussion_r119568348 --- Diff: nifi-assembly/NOTICE --- @@ -1364,6 +1364,8 @@ The following binary components are provided under the MIT License. See project (MIT

[GitHub] nifi pull request #1875: NIFI-4001 - Bump ParCEFone version

2017-06-01 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1875 NIFI-4001 - Bump ParCEFone version Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps

[GitHub] nifi issue #1696: NIFI-1655 - Add .gitattributes to specifically define

2017-05-31 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @jfrazee this seems to be passing tests now. Let me know what you think --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #1541: NIFI-329 - Introduce IRC Client Services and Consum...

2017-05-30 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1541#discussion_r119273679 --- Diff: nifi-nar-bundles/nifi-irc-bundle/nifi-irc-processors/src/main/java/org/apache/nifi/processors/irc/PublishIRC.java --- @@ -0,0 +1,139

[GitHub] nifi issue #1696: NIFI-1655 - Add .gitattributes to specifically define

2017-05-26 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @jfrazee now that HL7 is out of the way, giving it another try... Will let you know when I am happy with code. Cheers --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1845: NIFI-3960 - ExtractGrok - Include exception message when c...

2017-05-26 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1845 thanks for the contribution LGTM. merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-05-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1794 @jfrazee I intentionally used ID as I noticed ID_LIKE seemed like a mix bag... https://gist.github.com/djcp/6132025 --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-05-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1794 @jfrazee sorry. I misread your comment. It works on leap?! Great. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-05-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1794 @jfrazee thanks. I haven't tested on leap. as not working you mean the file is not being linked or the service isn't being started? Cheers --- If your project is set up

[GitHub] nifi issue #1799: NIFI-3896 - Makes DeprecationNotice more intuitive

2017-05-15 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1799 @mcgilman here it goes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi pull request #1799: NIFI-3896 - Makes DeprecationNotice more intuitive

2017-05-15 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1799 NIFI-3896 - Makes DeprecationNotice more intuitive Update developers guide on how to deprecate a component Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #1541: NIFI-329 - Introduce IRC Client Services and ConsumeIRC pr...

2017-05-15 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1541 Good news! work has been "completed" and PR squashed and rebased to master. Things to notice: 1. At this stage, test units are marked as ignore as they expect the av

[GitHub] nifi issue #1741: NIFI-3536 Adding GetSOAP processor which supports generica...

2017-05-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1741 @apsaltis Is it my impression or the new dependencies weren't added to the nifi-assembly `NOTICE` ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1583: NIFI-1131 renamed relationships

2017-05-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1583 @josephxsxn in light of Joe's comments, would you like to close this PR? Cheers! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #1794: NIFI-1709 - Introduce logic to probe Linux version using /...

2017-05-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1794 @apiri may I ask you to have a look on this? Idea here is to use `/etc/os-release` to identify the Linux distribution and use that to flag some particular distro specific issues such as use

[GitHub] nifi pull request #1794: NIFI-1709 - Introduce logic to probe Linux version ...

2017-05-14 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1794 NIFI-1709 - Introduce logic to probe Linux version using /etc/os-rele… …ase to nifi.sh Add explicit paths to support SLES 11 SP4 / OpenSUSE init.d layout Thank you

[GitHub] nifi pull request #1718: NIFI-391 - Introduce the ability to deprecate a com...

2017-05-13 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1718#discussion_r116357827 --- Diff: nifi-api/src/main/java/org/apache/nifi/annotation/documentation/DeprecationNotice.java --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request #1718: NIFI-391 - Introduce the ability to deprecate a com...

2017-05-13 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1718#discussion_r116357266 --- Diff: nifi-api/src/main/java/org/apache/nifi/annotation/documentation/DeprecationNotice.java --- @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache

[GitHub] nifi issue #1767: NIFI-3802 Adding ASF HipChat information to README

2017-05-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1767 merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1718 @mcgilman I suspect when you wrote `DocumentTypeDTO` you meant `DocumentedTypeDTO`? If that is the case, hopefully this address the comment --- If your project is set up for it, you can reply

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-09 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1718 @mcgilman - will adjust --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-08 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1718 @mcgilman Thank you for looking at this. Yes, I would say as long this part is ok we could merge. I also would prefer having the UI work done separately. Cheers --- If your project is set

[GitHub] nifi issue #1718: NIFI-391 - Introduce the ability to deprecate a component

2017-05-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1718 @mcgilman based on the following screenshot( this is a snipped of data related to a locally deprecated `ListenLumberjack`) I suspect this should be a good starting point for the UX work

[GitHub] nifi issue #1746: NIFI-3794 - Expose the control of ListenRELP's CLIENT_AUTH...

2017-05-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1746 adjusted the commit to refer to to the correct JIRA ticket (NIFI-3794) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #1746: NIFI-3726 - Expose the control of ListenRELP's CLIE...

2017-05-03 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1746 NIFI-3726 - Expose the control of ListenRELP's CLIENT_AUTH property t… …o DFM Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #1738: NIFI-3718: Fixed timezone issue in TestAvroReaderWithEmbed...

2017-05-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1738 Oops. GMT+10. Forgot my daylight savings is over. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1738: NIFI-3718: Fixed timezone issue in TestAvroReaderWithEmbed...

2017-05-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1738 The people from the future salute you, oh fellow space traveler! LGTM. And works on GMT+11. Suggest waiting for travis to complete to ensure it runs on other Time zones (I assume you

[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-05-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 @mattyb149 just to register: TLSH requires more than 512 characters to work so your hello message triggers a safety mechanism that routes the flow to error. I should have used error but I

[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-05-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 pom has also been fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-05-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 @alopresto @mattyb149 last two commits should address the two residual issues you identified. One was a simple reference to HashContent.class instead of the fully qualified class path

[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-05-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 Andy, easy to solve --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1696: NIFI-1655 - Add .gitattributes to specifically define

2017-05-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @jfrazee while we are doing HL7 is there any chance you can look at the EncryptContent tests as well? Due to the nature of PGP ASCII Armor files they use a mix of DOS and Unix line format

[GitHub] nifi pull request #1729: NIFI-3769 - Document detail value of 'nifi.provenan...

2017-05-02 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/1729 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1729: NIFI-3769 - Document detail value of 'nifi.provenance.repo...

2017-05-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1729 closing PR as it seems @markap14 has merged it to master but forgot to refer to PR when siging off the commit --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1339: NIFI-1231: cloned files not getting new entryDate

2017-05-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1339 @lexvanderstoep Given @joewitt 's JIRA comments, would you mind closing this PR and update the JIRA as Not a bug? Kind regards --- If your project is set up for it, you can reply

[GitHub] nifi issue #399: NIFI-1833 - Adding Azure Storage processors

2017-05-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/399 @simonellistonball - Seems like your PR has been adopted by @jtstorck and @aperepel so closing this PR as we currently have 3 PRs for the same JIRA. --- If your project is set up for it, you can

[GitHub] nifi pull request #1729: NIFI-3769 - Document detail value of 'nifi.provenan...

2017-05-02 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1729 NIFI-3769 - Document detail value of 'nifi.provenance.repository.warm… ….cache.frequency' Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #1721: NIFI-3651 - Add logo to README.md

2017-05-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1721 @apiri - I used the embedded HTML markdown notation as this seems to be a more universal approach to image resizing. There's are other options http://stackoverflow.com/questions/14675913/how

[GitHub] nifi pull request #1721: NIFI-3651 - Add logo to README.md

2017-05-01 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1721 NIFI-3651 - Add logo to README.md Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps

[GitHub] nifi issue #1720: NIFI-3670 - Expose the control of ListenSyslog's CLIENT_AU...

2017-05-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1720 @bbende - hopefully this will address the intent behind the JIRA ticket. Please note that I also: - added displayName to all properties - re-indented some of the code (as it had double

[GitHub] nifi pull request #1720: NIFI-3670 - Expose the control of ListenSyslog's CL...

2017-05-01 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1720 NIFI-3670 - Expose the control of ListenSyslog's CLIENT_AUTH property… … to DFM Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #1142: NIFI-2624 JdbcCommon treats BigDecimals now as Avro Logica...

2017-05-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1142 Adding @ToivoAdams comment here as his last comment on JIRA did use github's @ mentions instead of JIRAs [~ ] mentions: > @ijokarumawak > > Sorry I didn't have time to

[GitHub] nifi issue #1102: NIFI-2867 The ColumnSize of datetime type is 19 length in ...

2017-05-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1102 @combineads - thanks for the PR. Apologies for lacking the background but I was wondering what the issue effectively is? From what you say the issue is that PutSQL requires -MM

[GitHub] nifi issue #1696: NIFI-1655 - Add .gitattributes to specifically define

2017-05-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @joewitt as suspected HL7 does inded use CR as a segment separator so I renamed the files to hl7 and treated hl7 as binary. Tests passed locally and I am now checking what travis has to say

[GitHub] nifi issue #1015: NIFI-2767 Periodically reload properties from file-based v...

2017-05-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1015 @jfrazee any chance of rebasing this? Keen to revisit this PR and get the review going, otherwise happy for you to close it as well. Cheers --- If your project is set up

[GitHub] nifi issue #584: closing InputStream after execution completes

2017-05-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/584 @vcharmcaster - there has been a while since you opened this PR and @olegz question still an answered. Is this PR still needed? Otherwise, would you mind closing it? Kind regards

[GitHub] nifi issue #1608: NIFI-3607 Allow multi files mode with fixed names

2017-04-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1608 @pvillard31 thanks for the rebase. LGTM. Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1718: NIFI-391 - Introduce the ability to deprecate a com...

2017-04-29 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1718 NIFI-391 - Introduce the ability to deprecate a component Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #1639: NIFI-1939 - Correct issue where ParseSyslog was una...

2017-04-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1639#discussion_r114039631 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseSyslog.java --- @@ -57,13

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113932077 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/FuzzyHashContent.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113917927 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113918024 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor

2017-04-28 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1716 Speed and overall project roadmap. The approach introduced there brings significant advantages to the use of PutHDFS. https://github.com/apache/nifi/pull/1712 --- If your

[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor

2017-04-28 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1716 @jonashartwig thank you for your contribution. I was looking at your code and was wondering if have you had a chance to see the put / fetch parquet @bbende submitted a few hours ago

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113587423 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/FuzzyHashContent.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113586627 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113586323 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113585955 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113585822 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 @alopresto - I put together the interface based approach and indeed it seems a much cleaner code so thank you for pointing me into this direction. The code has not been optimised and still

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113463146 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113462407 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113462423 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113462459 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi issue #1696: NIFI-1655 - Add .gitattributes to specifically define

2017-04-26 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @joewitt - When doing this change I noticed some changes to HL7 files and looking online it seems like HL7 uses CR as a "segment separator". Would you mind if I renamed the rele

[GitHub] nifi pull request #1696: NIFI-1655 - Add .gitattributes to specifically defi...

2017-04-26 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1696 NIFI-1655 - Add .gitattributes to specifically define the line ending format of particular file type (i.e. .java = LF, .bat=CRLF) Thank you for submitting a contribution

[GitHub] nifi pull request #1650: NIFI-2661 - Abstract the GeoEnrichIP processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1650#discussion_r113431000 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/TestISPEnrichIP.java --- @@ -0,0 +1,310

[GitHub] nifi pull request #1650: NIFI-2661 - Abstract the GeoEnrichIP processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1650#discussion_r113428044 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/ISPEnrichIP.java --- @@ -0,0 +1,132

[GitHub] nifi pull request #1650: NIFI-2661 - Abstract the GeoEnrichIP processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1650#discussion_r113411154 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java --- @@ -70,6 +55,7

[GitHub] nifi pull request #1650: NIFI-2661 - Abstract the GeoEnrichIP processor

2017-04-25 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1650#discussion_r113340946 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java --- @@ -208,6 +120,8

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-25 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113340505 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi issue #1693: NIFI-3737 - Ran optipng on all png files

2017-04-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1693 @andrewmlim :+1: :+1: :+1: :+1: for catching this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-04-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1644 @mcgilman makes total sense. Will adjust --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1642: NIFI-1336 - Ensure that flowfiles are penalized upon excep...

2017-04-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1642 @markap14 no worries. Thanks for the clarification I will try to give it another go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1395: NIFI-3280 PostHTTP Option to write response to attribute o...

2017-04-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1395 @nickcarenza thanks for the PR, much appreciated. I was going through it and got myself wondering: Is there any reason why we are doing this when InvokeHTTP processor cater

  1   2   3   4   5   6   7   >