[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-28 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385810699 ## File path: extensions/http-curl/tests/HTTPIntegrationBase.h ## @@ -91,4 +87,74 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-27 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385301812 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -80,7 +80,7 @@

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-27 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385301325 ## File path: extensions/http-curl/tests/HTTPHandlers.h ## @@ -343,4 +345,104 @@ class

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-27 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385301665 ## File path: extensions/http-curl/tests/C2JstackTest.cpp ## @@ -45,123 +45,114 @@

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-27 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385301458 ## File path: libminifi/include/core/state/nodes/MetricsBase.h ## @@ -228,6 +228,20 @@

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-27 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385301018 ## File path: extensions/http-curl/tests/C2JstackTest.cpp ## @@ -45,123 +45,114 @@

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-27 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385300910 ## File path: extensions/coap/tests/CoapIntegrationBase.h ## @@ -41,13 +41,13 @@ class

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-27 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385300629 ## File path: conf/minifi.properties ## @@ -51,7 +51,7 @@

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-20 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r382158762 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -315,16 +317,35 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-20 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r382143961 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-14 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r379564619 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -315,16 +317,35 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-13 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r379166388 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -539,9 +563,9 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-13 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r379159050 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -539,9 +563,9 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-13 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r379150417 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -506,13 +527,16 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-13 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r379042436 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -521,9 +545,9 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-13 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378996918 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -315,16 +317,35 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378537631 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378537631 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378529132 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -643,16 +704,7

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378462225 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378462016 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -315,16 +317,35 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378458847 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -623,18 +632,70

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378443443 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -553,6 +577,20 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378441353 ## File path: libminifi/include/core/state/nodes/AgentInformation.h ## @@ -623,18 +632,70