msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r379150417
##########
File path: libminifi/src/c2/C2Agent.cpp
##########
@@ -506,13 +527,16 @@ void C2Agent::handle_describe(const C2ContentResponse
&resp) {
}
std::vector<std::shared_ptr<state::response::ResponseNode>> metrics_vec;
-
- reporter->getResponseNodes(metrics_vec, metric_class_id);
C2Payload response(Operation::ACKNOWLEDGE, resp.ident, false, true);
response.setLabel("metrics");
+
+ C2Payload metrics(Operation::ACKNOWLEDGE, resp.ident, false, true);
Review comment:
That is because of the way C2Payload and C2ContentResponse classes are
structured and the way we serializeJson payload. This needs some cleanup and
might require some larger effort. Will take a note and open a Jira ticket to
simplify this design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
