[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-04-22 Thread GitBox
msharee9 commented on a change in pull request #743: URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r413242502 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -89,44 +93,68 @@ C2Agent::C2Agent(const std::shared_ptr heart_beat_period_ ) { -

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-04-22 Thread GitBox
msharee9 commented on a change in pull request #743: URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r413240661 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -89,44 +93,68 @@ C2Agent::C2Agent(const std::shared_ptr heart_beat_period_ ) { -

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-04-22 Thread GitBox
msharee9 commented on a change in pull request #743: URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r413228089 ## File path: libminifi/include/c2/C2Agent.h ## @@ -52,39 +55,28 @@ namespace c2 { * 0 HeartBeat -- RESERVED * 1-255 Defined by the

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-04-14 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r408289302 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -89,44 +93,68 @@

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-04-10 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r406886579 ## File path: libminifi/include/utils/BackTrace.h ## @@ -81,13 +83,32 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-04-01 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r401721628 ## File path: libminifi/src/utils/BackTrace.cpp ## @@ -80,25 +80,21 @@

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-04-01 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r401721628 ## File path: libminifi/src/utils/BackTrace.cpp ## @@ -80,25 +80,21 @@

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-25 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r398046871 ## File path: nanofi/include/cxx/C2CallbackAgent.h ## @@ -70,6 +69,7 @@ class

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-24 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r397589151 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -32,24 +32,34 @@ #include

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-24 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r397588367 ## File path: extensions/http-curl/tests/C2JstackTest.cpp ## @@ -16,152 +16,63

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-20 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r395838661 ## File path: extensions/http-curl/tests/C2JstackTest.cpp ## @@ -16,152 +16,63

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-17 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r393707126 ## File path: extensions/http-curl/tests/C2JstackTest.cpp ## @@ -16,152 +16,63

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-13 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r392347808 ## File path: libminifi/src/FlowController.cpp ## @@ -907,29 +908,44 @@ int16_t

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-13 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r392346281 ## File path: libminifi/src/FlowController.cpp ## @@ -172,6 +173,9 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-12 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r391746461 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -342,6 +342,31 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-12 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r391745333 ## File path: libminifi/src/FlowController.cpp ## @@ -173,9 +173,9 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-12 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r391670955 ## File path: nanofi/include/cxx/C2CallbackAgent.h ## @@ -47,7 +47,10 @@ class

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-10 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r390669052 ## File path: extensions/http-curl/tests/HTTPHandlers.h ## @@ -343,4 +345,104

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-10 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r390614132 ## File path: libminifi/include/FlowController.h ## @@ -304,23 +305,23 @@ class

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-10 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r390665167 ## File path: extensions/http-curl/tests/HTTPHandlers.h ## @@ -343,4 +345,104

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-10 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r390664802 ## File path: extensions/http-curl/tests/HTTPHandlers.h ## @@ -343,4 +345,104

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-10 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r390615024 ## File path: libminifi/include/FlowController.h ## @@ -406,22 +409,27 @@ class

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-10 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r390614132 ## File path: libminifi/include/FlowController.h ## @@ -304,23 +305,23 @@ class

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-06 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r389004654 ## File path: libminifi/src/FlowController.cpp ## @@ -449,13 +451,9 @@ void

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-06 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r389004074 ## File path: libminifi/include/utils/ThreadPool.h ## @@ -412,6 +414,22 @@

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-03 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r387232949 ## File path: conf/minifi.properties ## @@ -52,6 +52,8 @@

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting

2020-03-03 Thread GitBox
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r387232703 ## File path: C2.md ## @@ -49,6 +49,11 @@ Release 0.6.0: Please note that all