msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify
C2 metrics collection and reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r389004654
##########
File path: libminifi/src/FlowController.cpp
##########
@@ -449,13 +451,9 @@ void FlowController::initializeC2() {
if (!c2_initialized_) {
configuration_->setAgentIdentifier(identifier_str);
- state::StateManager::initialize();
- std::shared_ptr<c2::C2Agent> agent =
std::make_shared<c2::C2Agent>(std::dynamic_pointer_cast<FlowController>(shared_from_this()),
std::dynamic_pointer_cast<FlowController>(shared_from_this()),
+ c2_agent_ =
std::make_shared<c2::C2Agent>(std::dynamic_pointer_cast<FlowController>(shared_from_this()),
std::dynamic_pointer_cast<FlowController>(shared_from_this()),
Review comment:
As discussed, we will take this in another PR as it requires some major
changes that might break interfaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
