exceptionfactory closed pull request #8152: NIFI-12236 Improving fault
tolerancy of the QuestDB backed metrics repository
URL: https://github.com/apache/nifi/pull/8152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1482432782
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/test/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManagerTest.java:
##
@@ -0,0 +1,397 @@
+/*
+
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1481596508
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/test/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManagerTest.java:
##
@@ -0,0 +1,397 @@
+/*
+ *
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1481594813
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/test/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManagerTest.java:
##
@@ -0,0 +1,397 @@
+/*
+ *
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1479952728
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/test/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManagerTest.java:
##
@@ -0,0 +1,397 @@
+/*
+
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1479945239
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/test/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManagerTest.java:
##
@@ -0,0 +1,397 @@
+/*
+
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1479876942
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/main/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ *
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1479260621
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/main/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1479237840
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/test/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManagerTest.java:
##
@@ -0,0 +1,397 @@
+/*
+ *
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1478675324
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/test/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManagerTest.java:
##
@@ -0,0 +1,397 @@
+/*
+
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1476061099
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb-status-history/src/main/java/org/apache/nifi/controller/status/history/questdb/BufferedStatusHistoryStorage.java:
simonbence commented on PR #8152:
URL: https://github.com/apache/nifi/pull/8152#issuecomment-1908952704
Notable changes:
- CapturedAt database fields were renamed to captured
- I found the reason of the remaining test files and fixed it
- I adjusted the NAR structure, now it is
exceptionfactory commented on PR #8152:
URL: https://github.com/apache/nifi/pull/8152#issuecomment-1907356923
> > Thanks for making the updates @simonbence.
> > On closer review of the test changes, there is still a problem with
manager tests not cleaning up temporary files on
simonbence commented on PR #8152:
URL: https://github.com/apache/nifi/pull/8152#issuecomment-1906081709
> Thanks for making the updates @simonbence.
>
> On closer review of the test changes, there is still a problem with
manager tests not cleaning up temporary files on completion.
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1463269610
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/pom.xml:
##
@@ -0,0 +1,66 @@
+
+
+http://maven.apache.org/POM/4.0.0;
simonbence commented on PR #8152:
URL: https://github.com/apache/nifi/pull/8152#issuecomment-1904912180
The failed checks look to be in connection with Python processors and minify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
simonbence commented on PR #8152:
URL: https://github.com/apache/nifi/pull/8152#issuecomment-1900596724
> > > Thanks for making the adjustments, this looks cleaner with the move to
`spring-retry`.
> > > I noted a few minor things, but also there appears to be a
file-locking problem
exceptionfactory commented on PR #8152:
URL: https://github.com/apache/nifi/pull/8152#issuecomment-1900590396
> > Thanks for making the adjustments, this looks cleaner with the move to
`spring-retry`.
> > I noted a few minor things, but also there appears to be a file-locking
problem
simonbence commented on PR #8152:
URL: https://github.com/apache/nifi/pull/8152#issuecomment-1900554189
> Thanks for making the adjustments, this looks cleaner with the move to
`spring-retry`.
>
> I noted a few minor things, but also there appears to be a file-locking
problem
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1458987461
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/pom.xml:
##
@@ -0,0 +1,67 @@
+
+
+http://maven.apache.org/POM/4.0.0;
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1458758879
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/main/java/org/apache/nifi/questdb/rollover/DeleteOldRolloverStrategy.java:
##
@@ -0,0 +1,95 @@
+/*
+ *
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1458179457
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/pom.xml:
##
@@ -0,0 +1,67 @@
+
+
+http://maven.apache.org/POM/4.0.0;
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1447199207
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/main/java/org/apache/nifi/questdb/embedded/LockedClient.java:
##
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1447192926
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/main/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManagerContext.java:
##
@@ -0,0 +1,39 @@
+/*
+ *
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1447192609
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/main/java/org/apache/nifi/questdb/embedded/EmbeddedDatabaseManager.java:
##
@@ -0,0 +1,297 @@
+/*
+ * Licensed
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1447186671
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/main/java/org/apache/nifi/questdb/embedded/EmbeddedClient.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1447185052
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb/src/main/java/org/apache/nifi/questdb/DatabaseManager.java:
##
@@ -14,25 +14,25 @@
* See the License for the
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1447182808
##
nifi-commons/nifi-utils/src/test/java/org/apache/nifi/retry/ExceptionExcludingRetryConditionTest.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1447178610
##
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/retry/NoReturnCallable.java:
##
@@ -14,25 +14,16 @@
* See the License for the specific language governing
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1435330854
##
nifi-commons/nifi-utils/src/test/java/org/apache/nifi/retry/ExceptionExcludingRetryConditionTest.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1435328555
##
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1435326266
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb-status-history/src/main/java/org/apache/nifi/controller/status/history/questdb/CapturedStatus.java:
##
@@
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1435323896
##
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/retry/NoReturnCallable.java:
##
@@ -14,25 +14,16 @@
* See the License for the specific language
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424892774
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb-status-history/src/main/java/org/apache/nifi/controller/status/history/questdb/StatusHistoryStorage.java:
##
@@
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424889502
##
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424884706
##
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424882496
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb-status-history/src/main/java/org/apache/nifi/controller/status/history/questdb/CapturedStatus.java:
##
@@ -0,0
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424878344
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-status-history-shared/pom.xml:
##
@@ -30,5 +30,9 @@
org.apache.nifi
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424876658
##
nifi-docs/src/main/asciidoc/administration-guide.adoc:
##
@@ -3538,15 +3538,19 @@ of 576.
Persistent repository
-If the value of the property
simonbence commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424874235
##
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/retry/NoReturnCallable.java:
##
@@ -14,25 +14,16 @@
* See the License for the specific language governing
simonbence commented on PR #8152:
URL: https://github.com/apache/nifi/pull/8152#issuecomment-1853298122
> Thanks for creating the new pull request and making the adjustments
@simonbence. I have yet not review the entire implementation, but I noted a few
recommendations.
>
> Having
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1424815114
##
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/retry/NoReturnCallable.java:
##
@@ -14,25 +14,16 @@
* See the License for the specific language
simonbence opened a new pull request, #8152:
URL: https://github.com/apache/nifi/pull/8152
This is a refined PR for NIFI-12236 after feedback and discussion on [PR
8123](https://github.com/apache/nifi/pull/8123). The general approach and
purpose remained the same: the PR aims to refine
simonbence closed pull request #8123: NIFI-12236 Improving fault tolerancy of
the QuestDB backed metrics repository
URL: https://github.com/apache/nifi/pull/8123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
simonbence commented on PR #8123:
URL: https://github.com/apache/nifi/pull/8123#issuecomment-1851737367
As the changes discussed on the ticket and were resulted by NIFI-12492 would
make this PR hard to follow, I close it and will open a new one
--
This is an automated message from the
exceptionfactory commented on code in PR #8123:
URL: https://github.com/apache/nifi/pull/8123#discussion_r1419100364
##
nifi-api/src/main/java/org/apache/nifi/controller/status/ConnectionStatus.java:
##
@@ -22,6 +22,7 @@
/**
*/
public class ConnectionStatus implements
simonbence commented on code in PR #8123:
URL: https://github.com/apache/nifi/pull/8123#discussion_r1419082031
##
nifi-api/src/main/java/org/apache/nifi/controller/status/ConnectionStatus.java:
##
@@ -22,6 +22,7 @@
/**
*/
public class ConnectionStatus implements Cloneable {
exceptionfactory commented on code in PR #8123:
URL: https://github.com/apache/nifi/pull/8123#discussion_r1417672045
##
nifi-api/src/main/java/org/apache/nifi/controller/status/NodeStatus.java:
##
@@ -35,7 +35,6 @@ public class NodeStatus implements Cloneable {
private
simonbence commented on PR #8123:
URL: https://github.com/apache/nifi/pull/8123#issuecomment-1842633320
Thansk @joewitt ! I answered on the JIRA as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
simonbence commented on code in PR #8123:
URL: https://github.com/apache/nifi/pull/8123#discussion_r1417093557
##
nifi-api/src/main/java/org/apache/nifi/controller/status/ConnectionStatus.java:
##
@@ -22,6 +22,7 @@
/**
*/
public class ConnectionStatus implements Cloneable {
simonbence commented on PR #8123:
URL: https://github.com/apache/nifi/pull/8123#issuecomment-1842625796
Hi @exceptionfactory !
Thanks for taking care! The separation of the default setting sounds a great
idea, I will apply it with other requested changes.
As for the API
joewitt commented on PR #8123:
URL: https://github.com/apache/nifi/pull/8123#issuecomment-1841517110
I have questions about the direction in general so I will take those over to
the JIRA. This PR obviously was a ton of work and my questions/thoughts aren't
about that right now so I think
exceptionfactory commented on code in PR #8123:
URL: https://github.com/apache/nifi/pull/8123#discussion_r1416185237
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/pom.xml:
##
@@ -108,7 +108,7 @@
10
-
simonbence opened a new pull request, #8123:
URL: https://github.com/apache/nifi/pull/8123
# Summary
This is a reworking of the original `QuestDB` based status history based on
community feedback. The main intention is to improve the maturity of the
feature in order to be a possible
54 matches
Mail list logo
