Re: [PR] NIFI-12900 Avoid unnecessary directory listing in PutSFTP [nifi]

2024-03-27 Thread via GitHub
exceptionfactory closed pull request #8503: NIFI-12900 Avoid unnecessary directory listing in PutSFTP URL: https://github.com/apache/nifi/pull/8503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] NIFI-12900 Avoid unnecessary directory listing in PutSFTP [nifi]

2024-03-26 Thread via GitHub
EndzeitBegins commented on PR #8503: URL: https://github.com/apache/nifi/pull/8503#issuecomment-2020975403 Perfect.  I applied your changes regarding the comment removal as is. As always, thank you for your review @exceptionfactory.  -- This is an automated message from the Apache

Re: [PR] NIFI-12900 Avoid unnecessary directory listing in PutSFTP [nifi]

2024-03-26 Thread via GitHub
exceptionfactory commented on code in PR #8503: URL: https://github.com/apache/nifi/pull/8503#discussion_r1539559603 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java: ## @@ -694,20 +708,12

Re: [PR] NIFI-12900 Avoid unnecessary directory listing in PutSFTP [nifi]

2024-03-26 Thread via GitHub
exceptionfactory commented on code in PR #8503: URL: https://github.com/apache/nifi/pull/8503#discussion_r1539537745 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java: ## @@ -340,7 +356,7

Re: [PR] NIFI-12900 Avoid unnecessary directory listing in PutSFTP [nifi]

2024-03-26 Thread via GitHub
EndzeitBegins commented on PR #8503: URL: https://github.com/apache/nifi/pull/8503#issuecomment-2020788649 I haven't encountered issues regarding symbolic links in the (arguably limited) manual testing I've done. However, I do not quite understand what you're addressing. The PR

Re: [PR] NIFI-12900 Avoid unnecessary directory listing in PutSFTP [nifi]

2024-03-26 Thread via GitHub
EndzeitBegins commented on code in PR #8503: URL: https://github.com/apache/nifi/pull/8503#discussion_r1539482164 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java: ## @@ -340,7 +356,7 @@

Re: [PR] NIFI-12900 Avoid unnecessary directory listing in PutSFTP [nifi]

2024-03-25 Thread via GitHub
exceptionfactory commented on code in PR #8503: URL: https://github.com/apache/nifi/pull/8503#discussion_r1538557100 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java: ## @@ -340,7 +356,7