[jira] [Commented] (NIFI-5476) Enable TLS Toolkit (standalone) to sign certificates with external CA certificate

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567990#comment-16567990 ] ASF GitHub Bot commented on NIFI-5476: -- Github user pepov commented on the issue:

[GitHub] nifi issue #2935: NIFI-5476 Allow TLS toolkit to use externally-signed CA in...

2018-08-03 Thread pepov
Github user pepov commented on the issue: https://github.com/apache/nifi/pull/2935 I've tested it manually and ran the unit tests as well. I wanted to ask whether we could make the error message more user friendly but then found myself trying to find out whether we can make life

[jira] [Commented] (NIFI-5484) PutHive3Streaming ignores the Hive Metastore URI property value

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568189#comment-16568189 ] ASF GitHub Bot commented on NIFI-5484: -- Github user mcgilman commented on the issue:

[jira] [Commented] (NIFI-3126) A large JSON file consisting of an array of many json elements can cause an out of memory error if passed to SplitJSON

2018-08-03 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568114#comment-16568114 ] Otto Fowler commented on NIFI-3126: --- It looks like 

[jira] [Assigned] (NIFI-3126) A large JSON file consisting of an array of many json elements can cause an out of memory error if passed to SplitJSON

2018-08-03 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otto Fowler reassigned NIFI-3126: - Assignee: Otto Fowler > A large JSON file consisting of an array of many json elements can cause

[GitHub] nifi issue #2934: NIFI-5484: Fixed PutHive3Streaming to use the Hive Metasto...

2018-08-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2934 Will review... ---

[jira] [Created] (NIFI-5486) NiFi docker image secure setup missing user creation for node identity

2018-08-03 Thread Peter Wilcsinszky (JIRA)
Peter Wilcsinszky created NIFI-5486: --- Summary: NiFi docker image secure setup missing user creation for node identity Key: NIFI-5486 URL: https://issues.apache.org/jira/browse/NIFI-5486 Project:

[jira] [Commented] (NIFI-5473) Add documentation for using intermediate CA with TLS toolkit

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568162#comment-16568162 ] ASF GitHub Bot commented on NIFI-5473: -- Github user pepov commented on a diff in the pull request:

[GitHub] nifi pull request #2927: NIFI-5473 Added section on using external signed CA...

2018-08-03 Thread pepov
Github user pepov commented on a diff in the pull request: https://github.com/apache/nifi/pull/2927#discussion_r207532732 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -281,6 +281,272 @@ After running the client you will have the CA’s certificate, a

[GitHub] nifi pull request #2934: NIFI-5484: Fixed PutHive3Streaming to use the Hive ...

2018-08-03 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2934#discussion_r207559164 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java --- @@ -390,6 +391,19 @@ public ValidationResult

[jira] [Commented] (NIFI-5484) PutHive3Streaming ignores the Hive Metastore URI property value

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568250#comment-16568250 ] ASF GitHub Bot commented on NIFI-5484: -- Github user mcgilman commented on a diff in the pull request:

[GitHub] nifi pull request #2934: NIFI-5484: Fixed PutHive3Streaming to use the Hive ...

2018-08-03 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2934#discussion_r207560439 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java --- @@ -390,6 +391,19 @@ public ValidationResult

[jira] [Updated] (NIFI-5484) PutHive3Streaming ignores the Hive Metastore URI property value

2018-08-03 Thread Matt Gilman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-5484: -- Resolution: Fixed Fix Version/s: 1.8.0 Status: Resolved (was: Patch Available) >

[GitHub] nifi pull request #2934: NIFI-5484: Fixed PutHive3Streaming to use the Hive ...

2018-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2934 ---

[jira] [Commented] (NIFI-5484) PutHive3Streaming ignores the Hive Metastore URI property value

2018-08-03 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568266#comment-16568266 ] ASF subversion and git services commented on NIFI-5484: --- Commit

[jira] [Commented] (NIFI-5484) PutHive3Streaming ignores the Hive Metastore URI property value

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568268#comment-16568268 ] ASF GitHub Bot commented on NIFI-5484: -- Github user mcgilman commented on the issue:

[jira] [Commented] (NIFI-5484) PutHive3Streaming ignores the Hive Metastore URI property value

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568274#comment-16568274 ] ASF GitHub Bot commented on NIFI-5484: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-5473) Add documentation for using intermediate CA with TLS toolkit

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568273#comment-16568273 ] ASF GitHub Bot commented on NIFI-5473: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-5484) PutHive3Streaming ignores the Hive Metastore URI property value

2018-08-03 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568265#comment-16568265 ] ASF subversion and git services commented on NIFI-5484: --- Commit

[GitHub] nifi issue #2934: NIFI-5484: Fixed PutHive3Streaming to use the Hive Metasto...

2018-08-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2934 Thanks @mattyb149! This has been merged to master. ---

[GitHub] nifi pull request #2927: NIFI-5473 Added section on using external signed CA...

2018-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2927 ---

[jira] [Commented] (NIFI-5484) PutHive3Streaming ignores the Hive Metastore URI property value

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568253#comment-16568253 ] ASF GitHub Bot commented on NIFI-5484: -- Github user mattyb149 commented on a diff in the pull

[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568494#comment-16568494 ] ASF GitHub Bot commented on NIFI-4914: -- Github user joewitt commented on a diff in the pull request:

[GitHub] nifi pull request #2882: NIFI-4914

2018-08-03 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2882#discussion_r207611364 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java --- @@ -0,0

[jira] [Created] (MINIFICPP-589) CapturePacket processor should allow selection of interfaces

2018-08-03 Thread Mr TheSegfault (JIRA)
Mr TheSegfault created MINIFICPP-589: Summary: CapturePacket processor should allow selection of interfaces Key: MINIFICPP-589 URL: https://issues.apache.org/jira/browse/MINIFICPP-589 Project:

[jira] [Commented] (MINIFICPP-583) Cannot disable curl properly

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568445#comment-16568445 ] ASF GitHub Bot commented on MINIFICPP-583: -- GitHub user phrocker opened a pull request:

[GitHub] nifi-minifi-cpp pull request #387: MINIFICPP-583: Allow Expression language ...

2018-08-03 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/387 MINIFICPP-583: Allow Expression language to compile if CURL is disabl… …ed while also honoring the request to disable CURL functionality Thank you for submitting a

[jira] [Updated] (MINIFICPP-583) Cannot disable curl properly

2018-08-03 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-583: - Status: Patch Available (was: Open) > Cannot disable curl properly >

[GitHub] nifi pull request #2882: NIFI-4914

2018-08-03 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/2882#discussion_r207611496 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java --- @@ -0,0

[jira] [Created] (NIFI-5487) Version agnostic paths in the docker container

2018-08-03 Thread Peter Wilcsinszky (JIRA)
Peter Wilcsinszky created NIFI-5487: --- Summary: Version agnostic paths in the docker container Key: NIFI-5487 URL: https://issues.apache.org/jira/browse/NIFI-5487 Project: Apache NiFi Issue

[jira] [Comment Edited] (MINIFICPP-588) Expression language build failure on U18

2018-08-03 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568450#comment-16568450 ] Mr TheSegfault edited comment on MINIFICPP-588 at 8/3/18 4:34 PM: --

[jira] [Resolved] (MINIFICPP-588) Expression language build failure on U18

2018-08-03 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault resolved MINIFICPP-588. -- Resolution: Fixed seems to be resolved with 583 > Expression language build

[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568496#comment-16568496 ] ASF GitHub Bot commented on NIFI-4914: -- Github user joewitt commented on a diff in the pull request:

[jira] [Created] (MINIFICPP-590) Investigage batching feature failures

2018-08-03 Thread Mr TheSegfault (JIRA)
Mr TheSegfault created MINIFICPP-590: Summary: Investigage batching feature failures Key: MINIFICPP-590 URL: https://issues.apache.org/jira/browse/MINIFICPP-590 Project: NiFi MiNiFi C++

[jira] [Commented] (MINIFICPP-590) Investigage batching feature failures

2018-08-03 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568539#comment-16568539 ] Mr TheSegfault commented on MINIFICPP-590: -- The screenshot included is a flow file that

[jira] [Assigned] (MINIFICPP-590) Investigage batching feature failures

2018-08-03 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-590: Assignee: Mr TheSegfault > Investigage batching feature failures >

[jira] [Updated] (MINIFICPP-590) Investigage batching feature failures

2018-08-03 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-590: - Description: Batching feature in PCAP appears to break at some points. Investigate

[jira] [Updated] (MINIFICPP-590) Investigage batching feature failures

2018-08-03 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-590: - Attachment: Screen Shot 2018-08-03 at 1.56.42 PM.png > Investigage batching feature

[GitHub] nifi-minifi-cpp pull request #383: MINIFICPP-582: Add constraints for gcc in...

2018-08-03 Thread apiri
Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/383#discussion_r207655014 --- Diff: linux.sh --- @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] nifi-minifi-cpp issue #387: MINIFICPP-583: Allow Expression language to comp...

2018-08-03 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/387 code changes look good. was able to verify the issue before PR and then its resolution with the patch applied. will get this merged. thanks! ---

[jira] [Commented] (MINIFICPP-583) Cannot disable curl properly

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568755#comment-16568755 ] ASF GitHub Bot commented on MINIFICPP-583: -- Github user apiri commented on the issue:

[GitHub] nifi-minifi-cpp issue #387: MINIFICPP-583: Allow Expression language to comp...

2018-08-03 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/387 reviewing ---

[jira] [Commented] (NIFI-5476) Enable TLS Toolkit (standalone) to sign certificates with external CA certificate

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568770#comment-16568770 ] ASF GitHub Bot commented on NIFI-5476: -- Github user alopresto commented on the issue:

[GitHub] nifi issue #2935: NIFI-5476 Allow TLS toolkit to use externally-signed CA in...

2018-08-03 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2935 @pepov I've incorporated your PKCS #8 to PKCS #1 code and made some refactorings. Thank you. ---

[jira] [Created] (NIFIREG-189) Improved Identity Provider Configurability

2018-08-03 Thread Kevin Doran (JIRA)
Kevin Doran created NIFIREG-189: --- Summary: Improved Identity Provider Configurability Key: NIFIREG-189 URL: https://issues.apache.org/jira/browse/NIFIREG-189 Project: NiFi Registry Issue Type:

[jira] [Commented] (MINIFICPP-582) Readme constraints not defined in bootstrap

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568704#comment-16568704 ] ASF GitHub Bot commented on MINIFICPP-582: -- Github user apiri commented on a diff in the pull

[jira] [Commented] (MINIFICPP-583) Cannot disable curl properly

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568807#comment-16568807 ] ASF GitHub Bot commented on MINIFICPP-583: -- Github user asfgit closed the pull request at:

[GitHub] nifi-minifi-cpp pull request #387: MINIFICPP-583: Allow Expression language ...

2018-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/387 ---

[jira] [Commented] (MINIFICPP-574) FileUtils.h:83:35: error: ‘strcmp’ was not declared in this scope

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568808#comment-16568808 ] ASF GitHub Bot commented on MINIFICPP-574: -- Github user asfgit closed the pull request at:

[jira] [Commented] (MINIFICPP-583) Cannot disable curl properly

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568804#comment-16568804 ] ASF GitHub Bot commented on MINIFICPP-583: -- Github user apiri commented on the issue:

[GitHub] nifi-minifi-cpp pull request #380: MINIFICPP-574 Include required cstring li...

2018-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/380 ---

[jira] [Resolved] (MINIFICPP-582) Readme constraints not defined in bootstrap

2018-08-03 Thread Aldrin Piri (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri resolved MINIFICPP-582. --- Resolution: Fixed > Readme constraints not defined in bootstrap >

[jira] [Commented] (MINIFICPP-582) Readme constraints not defined in bootstrap

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568710#comment-16568710 ] ASF GitHub Bot commented on MINIFICPP-582: -- Github user asfgit closed the pull request at:

[GitHub] nifi-minifi-cpp pull request #383: MINIFICPP-582: Add constraints for gcc in...

2018-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/383 ---

[jira] [Updated] (MINIFICPP-583) Cannot disable curl properly

2018-08-03 Thread Aldrin Piri (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri updated MINIFICPP-583: -- Resolution: Fixed Assignee: Mr TheSegfault Status: Resolved (was: Patch

[jira] [Commented] (NIFI-5473) Add documentation for using intermediate CA with TLS toolkit

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568592#comment-16568592 ] ASF GitHub Bot commented on NIFI-5473: -- Github user alopresto commented on a diff in the pull

[GitHub] nifi pull request #2927: NIFI-5473 Added section on using external signed CA...

2018-08-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2927#discussion_r207631101 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -281,6 +281,272 @@ After running the client you will have the CA’s certificate, a

[jira] [Commented] (NIFI-3126) A large JSON file consisting of an array of many json elements can cause an out of memory error if passed to SplitJSON

2018-08-03 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568635#comment-16568635 ] Otto Fowler commented on NIFI-3126: --- [~OlavJ] The [ForkRecord |

[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568646#comment-16568646 ] ASF GitHub Bot commented on NIFI-4914: -- Github user david-streamlio commented on a diff in the pull

[GitHub] nifi pull request #2882: NIFI-4914

2018-08-03 Thread david-streamlio
Github user david-streamlio commented on a diff in the pull request: https://github.com/apache/nifi/pull/2882#discussion_r207643777 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java ---

[GitHub] nifi pull request #2882: NIFI-4914

2018-08-03 Thread david-streamlio
Github user david-streamlio commented on a diff in the pull request: https://github.com/apache/nifi/pull/2882#discussion_r207644839 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java ---

[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568649#comment-16568649 ] ASF GitHub Bot commented on NIFI-4914: -- Github user david-streamlio commented on a diff in the pull