[jira] [Commented] (NIFI-5812) Make database processors as 'PrimaryNodeOnly'

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695111#comment-16695111 ] ASF GitHub Bot commented on NIFI-5812: -- Github user zenfenan commented on the issue:

[jira] [Commented] (NIFI-3303) escapeJson in ReplaceText

2018-11-21 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695296#comment-16695296 ] Otto Fowler commented on NIFI-3303: --- Any chance you can test this in 1.8.0? > escapeJson in ReplaceText

[GitHub] nifi issue #3167: NIFI-5812: Marked Database processors as 'PrimaryNodeOnly'

2018-11-21 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3167 @mattyb149 Fixed the checkstyle violation and rebased. ---

[jira] [Commented] (NIFI-5834) Restore default PutHiveQL error handling behavior

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694358#comment-16694358 ] ASF GitHub Bot commented on NIFI-5834: -- Github user ijokarumawak commented on a diff in the pull

[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...

2018-11-21 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/3179#discussion_r235277747 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3QL.java --- @@ -148,7 +148,23

[GitHub] nifi pull request #3180: NIFI-5833 Treat GetTwitter API properties as sensit...

2018-11-21 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/3180#discussion_r235285563 --- Diff: nifi-nar-bundles/nifi-social-media-bundle/nifi-twitter-processors/src/main/java/org/apache/nifi/processors/twitter/GetTwitter.java --- @@

[GitHub] nifi pull request #3180: NIFI-5833 Treat GetTwitter API properties as sensit...

2018-11-21 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/3180#discussion_r235285755 --- Diff:

[GitHub] nifi pull request #3180: NIFI-5833 Treat GetTwitter API properties as sensit...

2018-11-21 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/3180#discussion_r235285625 --- Diff:

[jira] [Commented] (NIFI-5833) Treat Twitter tokens as sensitive values in GetTwitter

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694365#comment-16694365 ] ASF GitHub Bot commented on NIFI-5833: -- Github user ijokarumawak commented on a diff in the pull

[jira] [Resolved] (NIFI-5832) PutHiveQL - Flowfile isn't transferred to failure rel on actual failure

2018-11-21 Thread Koji Kawamura (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura resolved NIFI-5832. - Resolution: Duplicate [~bdesert] I believe this is a duplicate with NIFI-5834. I tested the

[jira] [Commented] (NIFI-5834) Restore default PutHiveQL error handling behavior

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694359#comment-16694359 ] ASF GitHub Bot commented on NIFI-5834: -- Github user ijokarumawak commented on a diff in the pull

[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...

2018-11-21 Thread ijokarumawak
Github user ijokarumawak commented on a diff in the pull request: https://github.com/apache/nifi/pull/3179#discussion_r235274647 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3QL.java --- @@ -148,7 +148,23

[jira] [Commented] (NIFI-5833) Treat Twitter tokens as sensitive values in GetTwitter

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694362#comment-16694362 ] ASF GitHub Bot commented on NIFI-5833: -- Github user ijokarumawak commented on a diff in the pull

[jira] [Commented] (NIFI-5833) Treat Twitter tokens as sensitive values in GetTwitter

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694364#comment-16694364 ] ASF GitHub Bot commented on NIFI-5833: -- Github user ijokarumawak commented on a diff in the pull

[jira] [Updated] (MINIFICPP-632) Testing CAPI

2018-11-21 Thread Arpad Boda (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-632: - Labels: CAPI nanofi (was: ) > Testing CAPI > > > Key:

[jira] [Updated] (MINIFICPP-629) Investigate removing exceptions in CAPI and improving response code handling

2018-11-21 Thread Arpad Boda (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-629: - Labels: CAPI nanofi (was: nanofi) > Investigate removing exceptions in CAPI and improving

[jira] [Updated] (NIFI-5833) Treat Twitter tokens as sensitive values in GetTwitter

2018-11-21 Thread Joseph Witt (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-5833: -- Resolution: Fixed Fix Version/s: 1.9.0 Status: Resolved (was: Patch Available) >

[jira] [Commented] (NIFI-5833) Treat Twitter tokens as sensitive values in GetTwitter

2018-11-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694816#comment-16694816 ] ASF subversion and git services commented on NIFI-5833: --- Commit

[GitHub] nifi issue #3126: NIFI-5753 Add SSL support to HortonworksSchemaRegistry ser...

2018-11-21 Thread grzegorz8
Github user grzegorz8 commented on the issue: https://github.com/apache/nifi/pull/3126 @joewitt It's already running on my DEV nifi cluster. No problems so far. ---

[jira] [Commented] (NIFI-5753) Add SSL support to HortonworksSchemaRegistry service

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694850#comment-16694850 ] ASF GitHub Bot commented on NIFI-5753: -- Github user grzegorz8 commented on the issue:

[jira] [Commented] (NIFI-4731) BigQuery processors

2018-11-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694861#comment-16694861 ] ASF subversion and git services commented on NIFI-4731: --- Commit

[jira] [Commented] (NIFI-4731) BigQuery processors

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694865#comment-16694865 ] ASF GitHub Bot commented on NIFI-4731: -- Github user asfgit closed the pull request at:

[GitHub] nifi pull request #3019: [NIFI-4731][NIFI-4933] Big Query processor

2018-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3019 ---

[GitHub] nifi pull request #2682: NIFI-4731: BQ Processors and GCP library update.

2018-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2682 ---

[GitHub] nifi pull request #2420: NIFI-4731

2018-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2420 ---

[jira] [Commented] (NIFI-4731) BigQuery processors

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694866#comment-16694866 ] ASF GitHub Bot commented on NIFI-4731: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-4731) BigQuery processors

2018-11-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694860#comment-16694860 ] ASF subversion and git services commented on NIFI-4731: --- Commit

[jira] [Commented] (NIFI-4731) BigQuery processors

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694864#comment-16694864 ] ASF GitHub Bot commented on NIFI-4731: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-4933) GCS Google Cloud Storage Processor requires Project ID even if it is not necessary

2018-11-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694863#comment-16694863 ] ASF subversion and git services commented on NIFI-4933: --- Commit

[jira] [Commented] (NIFI-4260) ExecuteFlumeSink not working with Sink Type "avro".

2018-11-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694867#comment-16694867 ] ASF subversion and git services commented on NIFI-4260: --- Commit

[jira] [Commented] (NIFI-4260) ExecuteFlumeSink not working with Sink Type "avro".

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694868#comment-16694868 ] ASF GitHub Bot commented on NIFI-4260: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-5560) Sub directory(symbolic link to directory) files are not getting listed in ListSFTP(ListSFTP does not Follow symbolic links)

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694871#comment-16694871 ] ASF GitHub Bot commented on NIFI-5560: -- Github user joewitt commented on the issue:

[jira] [Resolved] (NIFI-4260) ExecuteFlumeSink not working with Sink Type "avro".

2018-11-21 Thread Joseph Witt (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt resolved NIFI-4260. --- Resolution: Fixed Fix Version/s: 1.9.0 > ExecuteFlumeSink not working with Sink Type "avro". >

[GitHub] nifi issue #3000: NIFI-5560 Added Follow SYMLINK support for ListFTP & ListS...

2018-11-21 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3000 reviewing now ---

[jira] [Commented] (NIFI-5833) Treat Twitter tokens as sensitive values in GetTwitter

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694820#comment-16694820 ] ASF GitHub Bot commented on NIFI-5833: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-5833) Treat Twitter tokens as sensitive values in GetTwitter

2018-11-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694818#comment-16694818 ] ASF subversion and git services commented on NIFI-5833: --- Commit

[GitHub] nifi issue #3126: NIFI-5753 Add SSL support to HortonworksSchemaRegistry ser...

2018-11-21 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3126 thanks for the contrib. i've not tested it on a live/secured instance. Have you done so? ---

[jira] [Commented] (NIFI-5753) Add SSL support to HortonworksSchemaRegistry service

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694836#comment-16694836 ] ASF GitHub Bot commented on NIFI-5753: -- Github user joewitt commented on the issue:

[jira] [Resolved] (NIFI-4731) BigQuery processors

2018-11-21 Thread Joseph Witt (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt resolved NIFI-4731. --- Resolution: Fixed Fix Version/s: 1.9.0 > BigQuery processors > --- > >

[jira] [Resolved] (NIFI-4933) GCS Google Cloud Storage Processor requires Project ID even if it is not necessary

2018-11-21 Thread Joseph Witt (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt resolved NIFI-4933. --- Resolution: Fixed Fix Version/s: 1.9.0 > GCS Google Cloud Storage Processor requires Project

[GitHub] nifi pull request #3166: NIFI-4260 Add avro-ipc dependency to make ExecuteFl...

2018-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3166 ---

[GitHub] nifi issue #3135: [NIFI-5795] RedisDistributedMapCacheClientService put miss...

2018-11-21 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/3135 @pvillard31 I wasn't able to. What do you suggest? We'll close this one and cover the objective with #3176 ? or we would merge this in once we verify the changes and ask @javajefe to rebase #3176?

[GitHub] nifi issue #2866: NIFI-4710 Kerberos support for user auth in Docker instanc...

2018-11-21 Thread pepov
Github user pepov commented on the issue: https://github.com/apache/nifi/pull/2866 sorry, I was busy lately, but will try to get to this as soon as I can ---

[GitHub] nifi pull request #3180: NIFI-5833 Treat GetTwitter API properties as sensit...

2018-11-21 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/3180#discussion_r235417790 --- Diff: nifi-nar-bundles/nifi-social-media-bundle/nifi-twitter-processors/src/main/java/org/apache/nifi/processors/twitter/GetTwitter.java --- @@ -56,24

[GitHub] nifi issue #3180: NIFI-5833 Treat GetTwitter API properties as sensitive

2018-11-21 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/3180 actually looks like the todo may be legit to hang around in general and isn't specific to this twitter scenario so will leave that alone. given kojis review and comments and mine am +1 will merge

[jira] [Commented] (NIFI-5833) Treat Twitter tokens as sensitive values in GetTwitter

2018-11-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694817#comment-16694817 ] ASF subversion and git services commented on NIFI-5833: --- Commit

[jira] [Commented] (NIFI-5833) Treat Twitter tokens as sensitive values in GetTwitter

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694808#comment-16694808 ] ASF GitHub Bot commented on NIFI-5833: -- Github user joewitt commented on the issue:

[jira] [Commented] (NIFI-5833) Treat Twitter tokens as sensitive values in GetTwitter

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694806#comment-16694806 ] ASF GitHub Bot commented on NIFI-5833: -- Github user joewitt commented on a diff in the pull request:

[GitHub] nifi pull request #3180: NIFI-5833 Treat GetTwitter API properties as sensit...

2018-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3180 ---

[jira] [Commented] (NIFI-3126) A large JSON file consisting of an array of many json elements can cause an out of memory error if passed to SplitJSON

2018-11-21 Thread Otto Fowler (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694774#comment-16694774 ] Otto Fowler commented on NIFI-3126: --- [~markap14] what should happen with this jira?  Should it be closed

[jira] [Commented] (NIFI-4710) Kerberos

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694656#comment-16694656 ] ASF GitHub Bot commented on NIFI-4710: -- Github user pepov commented on the issue:

[jira] [Updated] (NIFI-5836) TestHandleHttpRequest is making the travis builds very brittle

2018-11-21 Thread Joseph Witt (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt updated NIFI-5836: -- Priority: Critical (was: Major) > TestHandleHttpRequest is making the travis builds very brittle >

[jira] [Commented] (MINIFICPP-681) Add content hash processor

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694986#comment-16694986 ] ASF GitHub Bot commented on MINIFICPP-681: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #445: MINIFICPP-681 - Add content hash processo...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235461700 --- Diff: libminifi/src/processors/ContentHash.cpp --- @@ -0,0 +1,100 @@ +/** + * @file ContentHash.cpp + * ContentHash class

[jira] [Commented] (MINIFICPP-681) Add content hash processor

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694987#comment-16694987 ] ASF GitHub Bot commented on MINIFICPP-681: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #445: MINIFICPP-681 - Add content hash processo...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235477945 --- Diff: libminifi/include/processors/ContentHash.h --- @@ -0,0 +1,186 @@ +/** + * @file ContentHash.h + * ContentHash class

[jira] [Commented] (MINIFICPP-681) Add content hash processor

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694982#comment-16694982 ] ASF GitHub Bot commented on MINIFICPP-681: -- Github user phrocker commented on a diff in the

[jira] [Commented] (MINIFICPP-681) Add content hash processor

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694984#comment-16694984 ] ASF GitHub Bot commented on MINIFICPP-681: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #445: MINIFICPP-681 - Add content hash processo...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235459513 --- Diff: libminifi/include/processors/ContentHash.h --- @@ -0,0 +1,186 @@ +/** + * @file ContentHash.h + * ContentHash class

[GitHub] nifi-minifi-cpp pull request #445: MINIFICPP-681 - Add content hash processo...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235474428 --- Diff: libminifi/include/processors/ContentHash.h --- @@ -0,0 +1,186 @@ +/** + * @file ContentHash.h + * ContentHash class

[GitHub] nifi-minifi-cpp pull request #445: MINIFICPP-681 - Add content hash processo...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235461430 --- Diff: libminifi/src/processors/ContentHash.cpp --- @@ -0,0 +1,100 @@ +/** + * @file ContentHash.cpp + * ContentHash class

[GitHub] nifi-minifi-cpp pull request #445: MINIFICPP-681 - Add content hash processo...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235472601 --- Diff: libminifi/src/processors/ContentHash.cpp --- @@ -0,0 +1,100 @@ +/** + * @file ContentHash.cpp + * ContentHash class

[GitHub] nifi-minifi-cpp pull request #445: MINIFICPP-681 - Add content hash processo...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235461991 --- Diff: libminifi/include/processors/ContentHash.h --- @@ -0,0 +1,186 @@ +/** + * @file ContentHash.h + * ContentHash class

[GitHub] nifi-minifi-cpp pull request #445: MINIFICPP-681 - Add content hash processo...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235476969 --- Diff: libminifi/src/processors/ContentHash.cpp --- @@ -0,0 +1,100 @@ +/** + * @file ContentHash.cpp + * ContentHash class

[GitHub] nifi-minifi-cpp pull request #445: MINIFICPP-681 - Add content hash processo...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235471397 --- Diff: libminifi/src/processors/ContentHash.cpp --- @@ -0,0 +1,100 @@ +/** + * @file ContentHash.cpp + * ContentHash class

[jira] [Commented] (MINIFICPP-681) Add content hash processor

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694983#comment-16694983 ] ASF GitHub Bot commented on MINIFICPP-681: -- Github user phrocker commented on a diff in the

[jira] [Commented] (MINIFICPP-681) Add content hash processor

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694985#comment-16694985 ] ASF GitHub Bot commented on MINIFICPP-681: -- Github user phrocker commented on a diff in the

[jira] [Commented] (MINIFICPP-681) Add content hash processor

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694980#comment-16694980 ] ASF GitHub Bot commented on MINIFICPP-681: -- Github user phrocker commented on a diff in the

[jira] [Commented] (MINIFICPP-681) Add content hash processor

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694989#comment-16694989 ] ASF GitHub Bot commented on MINIFICPP-681: -- Github user phrocker commented on a diff in the

[jira] [Commented] (MINIFICPP-681) Add content hash processor

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694981#comment-16694981 ] ASF GitHub Bot commented on MINIFICPP-681: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #445: MINIFICPP-681 - Add content hash processo...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235458978 --- Diff: PROCESSORS.md --- @@ -130,6 +131,31 @@ default values, and whether a property supports the NiFi Expression Language. | success |

[GitHub] nifi pull request #3181: NIFI-5836 changed the brittle timing based tests to...

2018-11-21 Thread joewitt
GitHub user joewitt opened a pull request: https://github.com/apache/nifi/pull/3181 NIFI-5836 changed the brittle timing based tests to integration tests Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[jira] [Commented] (NIFI-5836) TestHandleHttpRequest is making the travis builds very brittle

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694993#comment-16694993 ] ASF GitHub Bot commented on NIFI-5836: -- GitHub user joewitt opened a pull request:

[GitHub] nifi-minifi-cpp issue #447: MINIFICPP-558: initial provisioning for CoAP sti...

2018-11-21 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/447 Since this is pretty large I'm doing a self review of this now. ---

[GitHub] nifi-minifi-cpp pull request #447: MINIFICPP-558: initial provisioning for C...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/447#discussion_r235480882 --- Diff: extensions/coap/COAPLoader.h --- @@ -0,0 +1,81 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (MINIFICPP-558) Move PayloadSerializer in preparation for Coap

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695006#comment-16695006 ] ASF GitHub Bot commented on MINIFICPP-558: -- Github user phrocker commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #447: MINIFICPP-558: initial provisioning for C...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/447#discussion_r235480740 --- Diff: extensions/coap/CMakeLists.txt --- @@ -0,0 +1,93 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[jira] [Commented] (MINIFICPP-558) Move PayloadSerializer in preparation for Coap

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695005#comment-16695005 ] ASF GitHub Bot commented on MINIFICPP-558: -- Github user phrocker commented on the issue:

[jira] [Commented] (MINIFICPP-558) Move PayloadSerializer in preparation for Coap

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695007#comment-16695007 ] ASF GitHub Bot commented on MINIFICPP-558: -- Github user phrocker commented on a diff in the

[jira] [Commented] (MINIFICPP-681) Add content hash processor

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694988#comment-16694988 ] ASF GitHub Bot commented on MINIFICPP-681: -- Github user phrocker commented on a diff in the

[GitHub] nifi issue #3181: NIFI-5836 changed the brittle timing based tests to integr...

2018-11-21 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/3181 It LGTM, it the Travis build is OK, I'm a +1 ---

[jira] [Commented] (NIFI-5836) TestHandleHttpRequest is making the travis builds very brittle

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695021#comment-16695021 ] ASF GitHub Bot commented on NIFI-5836: -- Github user pvillard31 commented on the issue:

[GitHub] nifi issue #3135: [NIFI-5795] RedisDistributedMapCacheClientService put miss...

2018-11-21 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/3135 Agree, I'd prefer to merge this one first, and then take care of the other one. ---

[jira] [Commented] (NIFI-5795) RedisDistributedMapCacheClientService put missing option

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695029#comment-16695029 ] ASF GitHub Bot commented on NIFI-5795: -- Github user pvillard31 commented on the issue:

[GitHub] nifi-minifi-cpp pull request #447: MINIFICPP-558: initial provisioning for C...

2018-11-21 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/447#discussion_r235487951 --- Diff: extensions/coap/controllerservice/CoapConnector.cpp --- @@ -0,0 +1,97 @@ +/** + * + * Licensed to the Apache Software

[jira] [Commented] (MINIFICPP-558) Move PayloadSerializer in preparation for Coap

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695036#comment-16695036 ] ASF GitHub Bot commented on MINIFICPP-558: -- Github user phrocker commented on a diff in the

[jira] [Created] (NIFI-5837) Add ability to edit the content and order of queues

2018-11-21 Thread Scott Wilburn (JIRA)
Scott Wilburn created NIFI-5837: --- Summary: Add ability to edit the content and order of queues Key: NIFI-5837 URL: https://issues.apache.org/jira/browse/NIFI-5837 Project: Apache NiFi Issue

[jira] [Commented] (NIFI-3126) A large JSON file consisting of an array of many json elements can cause an out of memory error if passed to SplitJSON

2018-11-21 Thread Koji Kawamura (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695447#comment-16695447 ] Koji Kawamura commented on NIFI-3126: - [~ottobackwards] [~markap14] How about adding a

[jira] [Commented] (NIFI-5812) Make database processors as 'PrimaryNodeOnly'

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695045#comment-16695045 ] ASF GitHub Bot commented on NIFI-5812: -- Github user mattyb149 commented on the issue:

[GitHub] nifi issue #3167: NIFI-5812: Marked Database processors as 'PrimaryNodeOnly'

2018-11-21 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3167 Removing the PrimaryNodeOnly annotation from GTF causes a Checkstyle violation due to the unused import. Can you remove the import statement as well? Wouldn't hurt to rebase (not merge) as well.

[jira] [Commented] (NIFI-5836) TestHandleHttpRequest is making the travis builds very brittle

2018-11-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695048#comment-16695048 ] ASF subversion and git services commented on NIFI-5836: --- Commit

[GitHub] nifi pull request #3181: NIFI-5836 changed the brittle timing based tests to...

2018-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3181 ---

[jira] [Commented] (NIFI-5836) TestHandleHttpRequest is making the travis builds very brittle

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695050#comment-16695050 ] ASF GitHub Bot commented on NIFI-5836: -- Github user asfgit closed the pull request at:

[jira] [Resolved] (NIFI-5836) TestHandleHttpRequest is making the travis builds very brittle

2018-11-21 Thread Joseph Witt (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Witt resolved NIFI-5836. --- Resolution: Fixed Fix Version/s: 1.9.0 > TestHandleHttpRequest is making the travis builds

[jira] [Commented] (MINIFICPP-558) Move PayloadSerializer in preparation for Coap

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694899#comment-16694899 ] ASF GitHub Bot commented on MINIFICPP-558: -- Github user phrocker closed the pull request at:

[GitHub] nifi-minifi-cpp pull request #447: MINIFICPP-558: initial provisioning for C...

2018-11-21 Thread phrocker
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/447 MINIFICPP-558: initial provisioning for CoAP still a wip test framework still under dev MINIFICPP-683: Remove extraneous std::move MINIFICPP-558: Add some test

[GitHub] nifi-minifi-cpp issue #446: MINIFICPP-684 - ExtractText processor doesn't ha...

2018-11-21 Thread arpadboda
Github user arpadboda commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/446 > @arpadboda I'll update the commit on merge to what was intended if you don't have a chance to in the next few minutes. Done. ---

[jira] [Commented] (MINIFICPP-684) ExtractText processor doesn't handle "Size limit" property

2018-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694906#comment-16694906 ] ASF GitHub Bot commented on MINIFICPP-684: -- Github user arpadboda commented on the issue:

[GitHub] nifi-minifi-cpp issue #446: MINIFICPP-684 - ExtractText processor doesn't ha...

2018-11-21 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/446 @arpadboda I'll update the commit on merge to what was intended if you don't have a chance to in the next few minutes. ---

[GitHub] nifi-minifi-cpp issue #445: MINIFICPP-681 - Add content hash processor

2018-11-21 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/445 taking a look. ---

  1   2   >