[jira] [Comment Edited] (MINIFICPP-710) Fix errors in Property StringToInt conversion

2019-01-10 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739911#comment-16739911 ] Mr TheSegfault edited comment on MINIFICPP-710 at 1/11/19 1:04 AM: ---

[GitHub] erichanson5 commented on issue #3248: NIFI-3611: Added ability to set Transaction Isolation Level on Database connections for QueryDatabaseTable processor

2019-01-10 Thread GitBox
erichanson5 commented on issue #3248: NIFI-3611: Added ability to set Transaction Isolation Level on Database connections for QueryDatabaseTable processor URL: https://github.com/apache/nifi/pull/3248#issuecomment-453261465 Thanks @patricker, I'll create another Jira ticket for that and

[GitHub] bdesert commented on issue #3261: NIFI-5869 Support Reconnection for JMS

2019-01-10 Thread GitBox
bdesert commented on issue #3261: NIFI-5869 Support Reconnection for JMS URL: https://github.com/apache/nifi/pull/3261#issuecomment-453304679 @mosermw , thanks, good catch. I've tested with ConsumeJMS. I'm going to change this now to fix it.

[GitHub] phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r246921467 ## File path: libminifi/include/sitetosite/RawSocketProtocol.h ## @@ -143,21 +140,21

[GitHub] phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r246921592 ## File path: libminifi/src/sitetosite/RawSocketProtocol.cpp ## @@ -394,98 +394,12 @@

[jira] [Commented] (NIFI-5948) Cannot list users when a ldap user that belongs to a group is deleted

2019-01-10 Thread Juan Pablo Converso (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739859#comment-16739859 ] Juan Pablo Converso commented on NIFI-5948: --- Hi! I checked out nifi-app.log but the action

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969601 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969407 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969481 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971930 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971930 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246973810 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[jira] [Commented] (MINIFICPP-710) Fix errors in Property StringToInt conversion

2019-01-10 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739911#comment-16739911 ] Mr TheSegfault commented on MINIFICPP-710: -- I've made some comments on the PR. Some parts of

[jira] [Updated] (NIFI-5951) PutHiveQL can miss logging error message if rollback-on-failure is enabled

2019-01-10 Thread Koji Kawamura (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura updated NIFI-5951: Status: Patch Available (was: In Progress) > PutHiveQL can miss logging error message if

[jira] [Commented] (NIFI-5948) Cannot list users when a ldap user that belongs to a group is deleted

2019-01-10 Thread Matt Gilman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739847#comment-16739847 ] Matt Gilman commented on NIFI-5948: --- Would you be able to check your logs for a stacktrace? I believe it

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969665 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246976098 ## File path: libminifi/include/core/TypedValues.h ## @@ -141,6 +141,47 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246976098 ## File path: libminifi/include/core/TypedValues.h ## @@ -141,6 +141,47 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969665 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246974404 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

[GitHub] phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion

2019-01-10 Thread GitBox
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors in Property StringToInt conversion URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246858533 ## File path: libminifi/test/unit/PropertyTests.cpp ## @@ -107,3 +107,28 @@

<    1   2