[GitHub] aeaversa commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
aeaversa commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor… URL: https://github.com/apache/nifi/pull/3281#issuecomment-459524435 @mcgilman - Thanks again for all the great feedback. I'll sit tight for input from the others and next week I'll work to refactor to the consensus. I have a working branch right now that does have the polling logic within the terminate dialog under a "WAIT" button (in lieu of the "NO" button) and provides feedback to the user on the modal as to how many threads remain active. I would say that being able to stop and terminate immediately is highly desired by some of the users I've discussed the feature with, but if you think that has deleterious effects elsewhere in the application, I can take the terminate logic out entirely if needed. My thanks again for all your help with this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cdavid15 opened a new pull request #3284: NIFI-5992 Added ability to configure JVM Memory settings via Docker ENV variables
cdavid15 opened a new pull request #3284: NIFI-5992 Added ability to configure JVM Memory settings via Docker ENV variables URL: https://github.com/apache/nifi/pull/3284 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-5992) Add ability to set JVM Heap sizes via ENV vars when using Docker
Craig Davidson created NIFI-5992: Summary: Add ability to set JVM Heap sizes via ENV vars when using Docker Key: NIFI-5992 URL: https://issues.apache.org/jira/browse/NIFI-5992 Project: Apache NiFi Issue Type: Improvement Components: Docker Affects Versions: 1.8.0 Reporter: Craig Davidson When running using the docker image the JVM heap settings are 512MB and requires a change to the bootstrap.conf file. There are a number of ENV vars used as present to update properties in the nifi.properties and nifi-cli.nifi.properties. Requesting a minor amendment to allow the java.arg.2 and java.arg.3 to be configurable in a similar fashion using the ENV vars NIFI_JVM_HEAP_INIT and NIFI_JVM_HEAP_MAX. I have a PR ready to submit for consideration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5991) ConsumeMQTT doesn't support MQTT over websockets
[ https://issues.apache.org/jira/browse/NIFI-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sujesh Menon updated NIFI-5991: --- Summary: ConsumeMQTT doesn't support MQTT over websockets (was: ConsumeMQTT doensn't support MQTT over websockets) > ConsumeMQTT doesn't support MQTT over websockets > > > Key: NIFI-5991 > URL: https://issues.apache.org/jira/browse/NIFI-5991 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.8.0 >Reporter: Sujesh Menon >Priority: Major > Labels: easyfix, features > > The Broker URI property of ConsumeMQTT processor only supports 'tcp' and > 'ssl' scheme, Though the org.eclipse.paho.client.mqttv3.MqttClient allows > MQTT over WebSockets i.e with the "ws" or "wss" scheme in the broker URI. > This could be fixed by adding these schemes to the BROKER_VALIDATOR in > AbstractMQTTProcessor class, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop &
Configure" button functionality to Processor…
URL: https://github.com/apache/nifi/pull/3281#discussion_r252844963
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
##
@@ -274,6 +280,82 @@
}
}];
+// determine if we should show the Stop & Configure button
+if (top === window &&
+nfCommon.isDefinedAndNotNull(processor.state) &&
+nfCommon.isDefinedAndNotNull(processorResponse.uri) &&
+nfCommon.isDefinedAndNotNull(nfProcessor) &&
+nfCommon.isDefinedAndNotNull(nfProcessorConfiguration)
) {
+
+//Add in the Stop & Configure button
+buttons.splice(1,0,{
+ buttonText: ' Stop & Configure',
+ clazz: 'fa fa-stop button-icon auto-width',
+ color: {
+ base: '#E3E8EB',
+ hover: '#C7D2D7',
+ text: '#813131'
+ },
+ disabled : function(){
+ return !( processor.state == "RUNNING" &&
+ (processorResponse.permissions.canWrite ||
+
processorResponse.operatePermissions.canWrite) );
+ },
+ handler: {
+ click: function () {
+
+
$(this).find('.fa-stop').addClass('disabled-button'); //disable the Stop &
Configure button
+
+var showConfig = function(data) {
+
nfProcessorConfiguration.showConfiguration({
+datum : function(){return data},
+classed : function(t){return
(t=='processor')}
+});
+
setTimeout(function(){$('#processor-details').modal('hide');},100);
+}
+
+$.ajax({
+ type: 'PUT',
+ url: processorResponse.uri + '/run-status',
+ data: JSON.stringify({
+ 'revision':
processorResponse.revision,
+ 'state': 'STOPPED'
+ }),
+ dataType: 'json',
+ contentType: 'application/json'
+}).done(function (data) {
+
+nfProcessor.set(data);
+
if(data.status.aggregateSnapshot.activeThreadCount > 0) {
+nfDialog.showYesNoDialog({
+headerText: 'Terminate active
threads?',
+dialogContent: 'There are
currently active threads '+
+'present for this processor,
do you wish to terminate them?',
+noHandler: function () {
+//close the dialog
+},
+yesHandler: function () {
+
+//send the terminate call
+$.ajax({
+ type: 'DELETE',
+ url: data.uri +
'/threads',
+ dataType: 'json',
+ contentType:
'application/json'
+ }).done(function (data) {
+showConfig(data);
+
}).fail(nfErrorHandler.handleAjaxError);
Review comment:
I don't think we should jump to terminate threads so quickly. Based on the
commentary here already, I think you guys are on the same page. We should
promote graceful stopping of the processors. The thread termination is in place
for situations where a Processor is not relinquishing a thread which is
preventing subsequent modifications. The solution here should unschedule the
processor and then wait for the executing threads to complete. I could get
behind something that would offer the terminate option only when the threads
are not completing on their own.
[GitHub] mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop &
Configure" button functionality to Processor…
URL: https://github.com/apache/nifi/pull/3281#discussion_r252841292
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
##
@@ -37,17 +39,21 @@
require('nf.Dialog'),
require('nf.ErrorHandler'),
require('nf.CustomUi'),
-require('nf.ClusterSummary')));
+require('nf.ClusterSummary'),
+require('nf.Processor'),
+require('nf.ProcessorConfiguration')));
} else {
nf.ProcessorDetails = factory(root.$,
root.nf.Common,
root.nf.UniversalCapture,
root.nf.Dialog,
root.nf.ErrorHandler,
root.nf.CustomUi,
-root.nf.ClusterSummary);
+root.nf.ClusterSummary,
+root.nf.Processor,
+root.nf.ProcessorConfiguration);
}
-}(this, function ($, nfCommon, nfUniversalCapture, nfDialog, nfErrorHandler,
nfCustomUi, nfClusterSummary) {
+}(this, function ($, nfCommon, nfUniversalCapture, nfDialog, nfErrorHandler,
nfCustomUi, nfClusterSummary,nfProcessor,nfProcessorConfiguration) {
Review comment:
I'm not sure we can establish dependencies on `nfProcessor` and
`nfProcessorConfiguration` here. These dependencies are not available in all
usages of `nf-processor-details.js`. This may work successfully as-is, but that
is a consequence of not employing a module loader yet. We do in other codebases
(like nifi-registry) and plan to introduce here. Utilizing a module loader, I
believe this would fail.
Because we utilize the processor details in many contexts, we've tried to
keep the dependencies as few as possible. We can still introduce these changes,
but I think we may need to relocate the logic a bit. See my comments below for
a possible option, but I'm open to other suggestions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop &
Configure" button functionality to Processor…
URL: https://github.com/apache/nifi/pull/3281#discussion_r252841685
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
##
@@ -274,6 +280,82 @@
}
}];
+// determine if we should show the Stop & Configure button
+if (top === window &&
+nfCommon.isDefinedAndNotNull(processor.state) &&
+nfCommon.isDefinedAndNotNull(processorResponse.uri) &&
+nfCommon.isDefinedAndNotNull(nfProcessor) &&
+nfCommon.isDefinedAndNotNull(nfProcessorConfiguration)
) {
+
+//Add in the Stop & Configure button
+buttons.splice(1,0,{
+ buttonText: ' Stop & Configure',
+ clazz: 'fa fa-stop button-icon auto-width',
+ color: {
+ base: '#E3E8EB',
+ hover: '#C7D2D7',
+ text: '#813131'
+ },
+ disabled : function(){
+ return !( processor.state == "RUNNING" &&
+ (processorResponse.permissions.canWrite ||
+
processorResponse.operatePermissions.canWrite) );
Review comment:
If the current user does not have permissions to modify, I don't think the
button should be presented at all. Since permissions to modify are required,
checking permissions to operate should be unnecessary.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop &
Configure" button functionality to Processor…
URL: https://github.com/apache/nifi/pull/3281#discussion_r252843357
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
##
@@ -274,6 +280,82 @@
}
}];
+// determine if we should show the Stop & Configure button
+if (top === window &&
+nfCommon.isDefinedAndNotNull(processor.state) &&
+nfCommon.isDefinedAndNotNull(processorResponse.uri) &&
+nfCommon.isDefinedAndNotNull(nfProcessor) &&
+nfCommon.isDefinedAndNotNull(nfProcessorConfiguration)
) {
+
+//Add in the Stop & Configure button
+buttons.splice(1,0,{
+ buttonText: ' Stop & Configure',
+ clazz: 'fa fa-stop button-icon auto-width',
+ color: {
+ base: '#E3E8EB',
+ hover: '#C7D2D7',
+ text: '#813131'
+ },
+ disabled : function(){
+ return !( processor.state == "RUNNING" &&
+ (processorResponse.permissions.canWrite ||
+
processorResponse.operatePermissions.canWrite) );
+ },
+ handler: {
+ click: function () {
Review comment:
Rather than having the logic included within `nf-processor-details` which
requires `nfProcessor` and `nfProcessorConfiguration`, what do you think about
possibly passing in some configuration object into
`nfProcessorDetails.init(...)` which could contain a callback to hold this
logic?
In doing so, I _think_ we'd be able to move this logic to `nfActions` or
something and reference it when initializing `nfProcessorDetails` in the
canvas. When initializing `nfProcessorDetails` in summary we could omit this
configuration object the presence of which could be the condition under which
we show this button.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop &
Configure" button functionality to Processor…
URL: https://github.com/apache/nifi/pull/3281#discussion_r252844963
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
##
@@ -274,6 +280,82 @@
}
}];
+// determine if we should show the Stop & Configure button
+if (top === window &&
+nfCommon.isDefinedAndNotNull(processor.state) &&
+nfCommon.isDefinedAndNotNull(processorResponse.uri) &&
+nfCommon.isDefinedAndNotNull(nfProcessor) &&
+nfCommon.isDefinedAndNotNull(nfProcessorConfiguration)
) {
+
+//Add in the Stop & Configure button
+buttons.splice(1,0,{
+ buttonText: ' Stop & Configure',
+ clazz: 'fa fa-stop button-icon auto-width',
+ color: {
+ base: '#E3E8EB',
+ hover: '#C7D2D7',
+ text: '#813131'
+ },
+ disabled : function(){
+ return !( processor.state == "RUNNING" &&
+ (processorResponse.permissions.canWrite ||
+
processorResponse.operatePermissions.canWrite) );
+ },
+ handler: {
+ click: function () {
+
+
$(this).find('.fa-stop').addClass('disabled-button'); //disable the Stop &
Configure button
+
+var showConfig = function(data) {
+
nfProcessorConfiguration.showConfiguration({
+datum : function(){return data},
+classed : function(t){return
(t=='processor')}
+});
+
setTimeout(function(){$('#processor-details').modal('hide');},100);
+}
+
+$.ajax({
+ type: 'PUT',
+ url: processorResponse.uri + '/run-status',
+ data: JSON.stringify({
+ 'revision':
processorResponse.revision,
+ 'state': 'STOPPED'
+ }),
+ dataType: 'json',
+ contentType: 'application/json'
+}).done(function (data) {
+
+nfProcessor.set(data);
+
if(data.status.aggregateSnapshot.activeThreadCount > 0) {
+nfDialog.showYesNoDialog({
+headerText: 'Terminate active
threads?',
+dialogContent: 'There are
currently active threads '+
+'present for this processor,
do you wish to terminate them?',
+noHandler: function () {
+//close the dialog
+},
+yesHandler: function () {
+
+//send the terminate call
+$.ajax({
+ type: 'DELETE',
+ url: data.uri +
'/threads',
+ dataType: 'json',
+ contentType:
'application/json'
+ }).done(function (data) {
+showConfig(data);
+
}).fail(nfErrorHandler.handleAjaxError);
Review comment:
I don't think we should jump to terminate threads so quickly. Based on the
commentary here already, I think you guys are on the same page. We should
promote graceful stopping of the processors. The thread termination is in place
for situations where a Processor is not relinquishing a thread which is
preventing subsequent modifications. The solution here should unschedule the
processor and then wait for the executing threads to complete. I could get
behind something that would offer the terminate option only when the threads
are not completely on their own.
[GitHub] mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop &
Configure" button functionality to Processor…
URL: https://github.com/apache/nifi/pull/3281#discussion_r252844640
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
##
@@ -274,6 +280,82 @@
}
}];
+// determine if we should show the Stop & Configure button
+if (top === window &&
+nfCommon.isDefinedAndNotNull(processor.state) &&
+nfCommon.isDefinedAndNotNull(processorResponse.uri) &&
+nfCommon.isDefinedAndNotNull(nfProcessor) &&
+nfCommon.isDefinedAndNotNull(nfProcessorConfiguration)
) {
+
+//Add in the Stop & Configure button
+buttons.splice(1,0,{
+ buttonText: ' Stop & Configure',
+ clazz: 'fa fa-stop button-icon auto-width',
+ color: {
+ base: '#E3E8EB',
+ hover: '#C7D2D7',
+ text: '#813131'
+ },
+ disabled : function(){
+ return !( processor.state == "RUNNING" &&
+ (processorResponse.permissions.canWrite ||
+
processorResponse.operatePermissions.canWrite) );
+ },
+ handler: {
+ click: function () {
+
+
$(this).find('.fa-stop').addClass('disabled-button'); //disable the Stop &
Configure button
+
+var showConfig = function(data) {
+
nfProcessorConfiguration.showConfiguration({
+datum : function(){return data},
+classed : function(t){return
(t=='processor')}
+});
+
setTimeout(function(){$('#processor-details').modal('hide');},100);
+}
+
+$.ajax({
+ type: 'PUT',
+ url: processorResponse.uri + '/run-status',
+ data: JSON.stringify({
+ 'revision':
processorResponse.revision,
Review comment:
The revision should be the revision for this client. Should be able to use
`nfClient.getRevision(d)`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
mcgilman commented on a change in pull request #3281: NIFI-5986 Adding "Stop &
Configure" button functionality to Processor…
URL: https://github.com/apache/nifi/pull/3281#discussion_r252844040
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
##
@@ -274,6 +280,82 @@
}
}];
+// determine if we should show the Stop & Configure button
+if (top === window &&
+nfCommon.isDefinedAndNotNull(processor.state) &&
+nfCommon.isDefinedAndNotNull(processorResponse.uri) &&
+nfCommon.isDefinedAndNotNull(nfProcessor) &&
+nfCommon.isDefinedAndNotNull(nfProcessorConfiguration)
) {
+
+//Add in the Stop & Configure button
+buttons.splice(1,0,{
+ buttonText: ' Stop & Configure',
+ clazz: 'fa fa-stop button-icon auto-width',
+ color: {
+ base: '#E3E8EB',
+ hover: '#C7D2D7',
+ text: '#813131'
+ },
+ disabled : function(){
+ return !( processor.state == "RUNNING" &&
+ (processorResponse.permissions.canWrite ||
+
processorResponse.operatePermissions.canWrite) );
+ },
+ handler: {
+ click: function () {
+
+
$(this).find('.fa-stop').addClass('disabled-button'); //disable the Stop &
Configure button
+
+var showConfig = function(data) {
+
nfProcessorConfiguration.showConfiguration({
+datum : function(){return data},
+classed : function(t){return
(t=='processor')}
+});
Review comment:
We should not be faking a D3 selection.
`nfProcessorConfiguration.showConfiguration(...)` currently expects a
selection. Future changes could be made there without realizing this would
break. Relocating this logic within the canvas, we would be able to select this
component directly with D3.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] alopresto commented on issue #3283: NIFI-5990 Moving Developer docs section above Processors
alopresto commented on issue #3283: NIFI-5990 Moving Developer docs section above Processors URL: https://github.com/apache/nifi/pull/3283#issuecomment-459510920 Reviewing... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-5991) ConsumeMQTT doensn't support MQTT over websockets
[ https://issues.apache.org/jira/browse/NIFI-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sujesh Menon updated NIFI-5991: --- Remaining Estimate: (was: 24h) Original Estimate: (was: 24h) > ConsumeMQTT doensn't support MQTT over websockets > - > > Key: NIFI-5991 > URL: https://issues.apache.org/jira/browse/NIFI-5991 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.8.0 >Reporter: Sujesh Menon >Priority: Major > Labels: easyfix, features > > The Broker URI property of ConsumeMQTT processor only supports 'tcp' and > 'ssl' scheme, Though the org.eclipse.paho.client.mqttv3.MqttClient allows > MQTT over WebSockets i.e with the "ws" or "wss" scheme in the broker URI. > This could be fixed by adding these schemes to the BROKER_VALIDATOR in > AbstractMQTTProcessor class, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-5991) ConsumeMQTT doensn't support MQTT over websockets
Sujesh Menon created NIFI-5991: -- Summary: ConsumeMQTT doensn't support MQTT over websockets Key: NIFI-5991 URL: https://issues.apache.org/jira/browse/NIFI-5991 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.8.0 Reporter: Sujesh Menon The Broker URI property of ConsumeMQTT processor only supports 'tcp' and 'ssl' scheme, Though the org.eclipse.paho.client.mqttv3.MqttClient allows MQTT over WebSockets i.e with the "ws" or "wss" scheme in the broker URI. This could be fixed by adding these schemes to the BROKER_VALIDATOR in AbstractMQTTProcessor class, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] mcgilman commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
mcgilman commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor… URL: https://github.com/apache/nifi/pull/3281#issuecomment-459503963 @aeaversa @mosermw Thanks for the comments. This definitely helps. I was just trying to be sure that we were focusing on the right problem. The request makes sense. Your PR does actually address some of the concerns I had which I admittedly overlooked when reading the changeset on my phone. I can also get behind the proposed solution but I'm CCing a couple community members who have assisted with UX issues in the past to get their input on the matter as well. I do still have a few concerns with the proposed code changes. I'll add them in the review and can discuss them more there. Thanks again! CC @moranr @andrewmlim This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (NIFI-5172) PutElasticSearchRecord does to fail individual recods
[ https://issues.apache.org/jira/browse/NIFI-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Percivall reassigned NIFI-5172: -- Assignee: Joseph Percivall > PutElasticSearchRecord does to fail individual recods > - > > Key: NIFI-5172 > URL: https://issues.apache.org/jira/browse/NIFI-5172 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.6.0 >Reporter: Juan C. Sequeiros >Assignee: Joseph Percivall >Priority: Minor > > My observation and not sure if working as expected but when I send my output > from MergeRecord ( set to 1 ) max number of records and one of those > records has an invalid timestamp "bogusdata" value ES rejects it, rightly so > since on ES we have a schema template more granular and is expecting > timestamp as type "date". > > From USER forums Matt Burgess: > Yes the current behavior is to move the entire input flowfile to > failure if any errors occur. Some other record-aware processors create > separate flow files for failed and successful records, but > PutElasticsearchHttpRecord does not (yet) do that. Please feel free to > write a Jira for this improvement. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] mattyb149 commented on a change in pull request #3282: NIFI-5983: handling parse problems in recordReader implementations
mattyb149 commented on a change in pull request #3282: NIFI-5983: handling parse problems in recordReader implementations URL: https://github.com/apache/nifi/pull/3282#discussion_r252821873 ## File path: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/avro/AvroRecordReader.java ## @@ -24,6 +24,8 @@ import org.apache.nifi.serialization.record.Record; import org.apache.nifi.serialization.record.RecordSchema; +import avro.shaded.com.google.common.base.Throwables; Review comment: The fully-qualified class name looks shady (pardon the pun). Is that a stable, usable, and (most importantly) necessary class? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mattyb149 commented on a change in pull request #3282: NIFI-5983: handling parse problems in recordReader implementations
mattyb149 commented on a change in pull request #3282: NIFI-5983: handling
parse problems in recordReader implementations
URL: https://github.com/apache/nifi/pull/3282#discussion_r252822065
##
File path:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/avro/AvroRecordReader.java
##
@@ -33,14 +35,18 @@
@Override
public Record nextRecord(final boolean coerceTypes, final boolean
dropUnknownFields) throws IOException, MalformedRecordException {
-GenericRecord record = nextAvroRecord();
-if (record == null) {
-return null;
+try {
+GenericRecord record = nextAvroRecord();
+if (record == null) {
+return null;
+}
+
+final RecordSchema schema = getSchema();
+final Map values =
AvroTypeUtil.convertAvroRecordToMap(record, schema);
+return new MapRecord(schema, values);
+} catch (RuntimeException e) {
Review comment:
Should we catch and rethrow the exceptions from the signature, then catch
Throwable, to cover all our bases?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mattyb149 commented on issue #3282: NIFI-5983: handling parse problems in recordReader implementations
mattyb149 commented on issue #3282: NIFI-5983: handling parse problems in recordReader implementations URL: https://github.com/apache/nifi/pull/3282#issuecomment-459485560 Reviewing... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alopresto commented on issue #3204: NIFI-1364 - Removed custom OCSP certificate revocation checking code and replaced with just using Java native implementation.
alopresto commented on issue #3204: NIFI-1364 - Removed custom OCSP certificate revocation checking code and replaced with just using Java native implementation. URL: https://github.com/apache/nifi/pull/3204#issuecomment-459462322 I won't be able to get to it right away but will definitely take a look soon. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (NIFI-5986) Add Stop & Configure button to Processor Details dialog
[ https://issues.apache.org/jira/browse/NIFI-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Aversa reassigned NIFI-5986: - Assignee: Alex Aversa > Add Stop & Configure button to Processor Details dialog > --- > > Key: NIFI-5986 > URL: https://issues.apache.org/jira/browse/NIFI-5986 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.8.0 >Reporter: Alex Aversa >Assignee: Alex Aversa >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > Add a new button called "Stop & Configure" to the Processor Details modal > that functionally stops the current processor should it be running and > automatically presents the Configure Processor modal window to the end user, > allowing them to efficiently edit the properties of the selected processor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5988) GetMongo fails to transfer to failure relationship with invalid database or collection name
[ https://issues.apache.org/jira/browse/NIFI-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757587#comment-16757587 ] Mike Thomsen commented on NIFI-5988: [~sivaprasanna] invalid names like @#RQ#%$@ or such. Mongo will automatically create databases and collections on the fly as you need them, so I know that's not an issue. > GetMongo fails to transfer to failure relationship with invalid database or > collection name > --- > > Key: NIFI-5988 > URL: https://issues.apache.org/jira/browse/NIFI-5988 > Project: Apache NiFi > Issue Type: Bug >Reporter: Mike Thomsen >Priority: Major > > Invalid Database/Collection names: If GetMongo is configured with invalid > DatabaseName/CollectionName, it doesn't log any ERROR as bulletin or in log > file and also doesn't route to failure relation. It should route to failure > with some Error message. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5988) GetMongo fails to transfer to failure relationship with invalid database or collection name
[ https://issues.apache.org/jira/browse/NIFI-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757552#comment-16757552 ] Sivaprasanna Sethuraman commented on NIFI-5988: --- [~mike.thomsen] Here invalid db/collection name means, non-existing db/collection or names with special characters or both? > GetMongo fails to transfer to failure relationship with invalid database or > collection name > --- > > Key: NIFI-5988 > URL: https://issues.apache.org/jira/browse/NIFI-5988 > Project: Apache NiFi > Issue Type: Bug >Reporter: Mike Thomsen >Priority: Major > > Invalid Database/Collection names: If GetMongo is configured with invalid > DatabaseName/CollectionName, it doesn't log any ERROR as bulletin or in log > file and also doesn't route to failure relation. It should route to failure > with some Error message. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-632) Testing CAPI
[ https://issues.apache.org/jira/browse/MINIFICPP-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-632: Assignee: Arpad Boda > Testing CAPI > > > Key: MINIFICPP-632 > URL: https://issues.apache.org/jira/browse/MINIFICPP-632 > Project: NiFi MiNiFi C++ > Issue Type: Epic >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Major > Labels: CAPI, nanofi > > > Ideas for Testing: > > Testing Tailing Log File > > 1) Use TestController to create temp files and directories ( see > PutFileTests as an example) > 2) Test that you add appropriate attributes and that content exists > 3) Test negative cases for removing log files > 4) Negative test cases for invalid/null arguments -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-622) Transmit binary information for CAPI implementations in heartbeat
[ https://issues.apache.org/jira/browse/MINIFICPP-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-622: Assignee: Arpad Boda > Transmit binary information for CAPI implementations in heartbeat > - > > Key: MINIFICPP-622 > URL: https://issues.apache.org/jira/browse/MINIFICPP-622 > Project: NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Major > Labels: CAPI, nanofi > > Heartbeats transmit a great deal of information as per our defined spec: > [https://cwiki.apache.org/confluence/display/MINIFI/C2+Design+Proposal] > This ticket will be responsible for figuring out what can and cannot be sent > via these binaries created using the CAPI > > For CAPI : probably need the AgentBuild information, but also potentially > information from a consumer's program – is there a way to capture information > about THEIR binary information > > May include information like python version, GCC version, etc that's NOT > about our library ( and not captured in AgentBuild) – but rather about > theirs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MINIFICPP-659) Move CAPI code out of libminifi
[ https://issues.apache.org/jira/browse/MINIFICPP-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-659: - Labels: nanofi (was: ) > Move CAPI code out of libminifi > --- > > Key: MINIFICPP-659 > URL: https://issues.apache.org/jira/browse/MINIFICPP-659 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Labels: nanofi > Fix For: 0.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (MINIFICPP-718) Docker container stats should be streamed if decoded into a dictionary
[ https://issues.apache.org/jira/browse/MINIFICPP-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri resolved MINIFICPP-718. --- Resolution: Fixed Fix Version/s: 0.6.0 > Docker container stats should be streamed if decoded into a dictionary > -- > > Key: MINIFICPP-718 > URL: https://issues.apache.org/jira/browse/MINIFICPP-718 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Docker container stats should be streamed if decoded into a dictionary -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-639) Improve error handling of CAPI return failures
[ https://issues.apache.org/jira/browse/MINIFICPP-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-639: Assignee: Arpad Boda > Improve error handling of CAPI return failures > -- > > Key: MINIFICPP-639 > URL: https://issues.apache.org/jira/browse/MINIFICPP-639 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Critical > Labels: nanofi > > Errors like not returning a class name as expected should return a meaningful > error throughout the API -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-669) Begin moving flow file record struct record away from using an opaque pointer
[ https://issues.apache.org/jira/browse/MINIFICPP-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-669: Assignee: Arpad Boda > Begin moving flow file record struct record away from using an opaque pointer > - > > Key: MINIFICPP-669 > URL: https://issues.apache.org/jira/browse/MINIFICPP-669 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Major > Labels: nanofi > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-621) Create log aggregator/collector ECU for CAPI
[ https://issues.apache.org/jira/browse/MINIFICPP-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-621: Assignee: Mr TheSegfault > Create log aggregator/collector ECU for CAPI > - > > Key: MINIFICPP-621 > URL: https://issues.apache.org/jira/browse/MINIFICPP-621 > Project: NiFi MiNiFi C++ > Issue Type: Sub-task >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Labels: CAPI, ECU, nanofi > > Create examples that can tail log files ( perhaps using TailFile ) that works > in windows and *nix -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-629) Investigate removing exceptions in CAPI and improving response code handling
[ https://issues.apache.org/jira/browse/MINIFICPP-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-629: Assignee: Arpad Boda > Investigate removing exceptions in CAPI and improving response code handling > > > Key: MINIFICPP-629 > URL: https://issues.apache.org/jira/browse/MINIFICPP-629 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Major > Labels: CAPI, nanofi > > Investigate removing exceptions in CAPI and improving response code handling > – maybe start by calling set_terminate to set a termination handler function > and move to the eventual goal of returning meaningful response codes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-671) Create determinate call chain to current set of C++ processors as we transition away from Instance
[ https://issues.apache.org/jira/browse/MINIFICPP-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-671: Assignee: Mr TheSegfault > Create determinate call chain to current set of C++ processors as we > transition away from Instance > -- > > Key: MINIFICPP-671 > URL: https://issues.apache.org/jira/browse/MINIFICPP-671 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Labels: nanofi > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-646) Re-evaluate passing attributes. Potentially deprecate attribute usage functions
[ https://issues.apache.org/jira/browse/MINIFICPP-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-646: Assignee: Arpad Boda > Re-evaluate passing attributes. Potentially deprecate attribute usage > functions > --- > > Key: MINIFICPP-646 > URL: https://issues.apache.org/jira/browse/MINIFICPP-646 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Blocker > Labels: nanofi > Fix For: 0.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-633) Create docker tests for site to site in capi
[ https://issues.apache.org/jira/browse/MINIFICPP-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-633: Assignee: Arpad Boda > Create docker tests for site to site in capi > > > Key: MINIFICPP-633 > URL: https://issues.apache.org/jira/browse/MINIFICPP-633 > Project: NiFi MiNiFi C++ > Issue Type: Sub-task >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Major > Labels: nanofi, test > > +Create python integration tests.+ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-667) Create Structural definitions for moving away from C++ classes
[ https://issues.apache.org/jira/browse/MINIFICPP-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-667: Assignee: Arpad Boda (was: Mr TheSegfault) > Create Structural definitions for moving away from C++ classes > -- > > Key: MINIFICPP-667 > URL: https://issues.apache.org/jira/browse/MINIFICPP-667 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Affects Versions: nanofi >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Major > Fix For: 0.6.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Create Structural definitions for moving away from C++ classes -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-670) Move away from Processor linkages in favor of UT hash linked list
[ https://issues.apache.org/jira/browse/MINIFICPP-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-670: Assignee: Arpad Boda > Move away from Processor linkages in favor of UT hash linked list > - > > Key: MINIFICPP-670 > URL: https://issues.apache.org/jira/browse/MINIFICPP-670 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Major > Labels: nanofi > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-621) Create log aggregator/collector ECU for CAPI
[ https://issues.apache.org/jira/browse/MINIFICPP-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-621: Assignee: Arpad Boda (was: Mr TheSegfault) > Create log aggregator/collector ECU for CAPI > - > > Key: MINIFICPP-621 > URL: https://issues.apache.org/jira/browse/MINIFICPP-621 > Project: NiFi MiNiFi C++ > Issue Type: Sub-task >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Major > Labels: CAPI, ECU, nanofi > > Create examples that can tail log files ( perhaps using TailFile ) that works > in windows and *nix -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-673) Define ECU (Edge Collector Unit )
[ https://issues.apache.org/jira/browse/MINIFICPP-673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-673: Assignee: Arpad Boda > Define ECU (Edge Collector Unit ) > - > > Key: MINIFICPP-673 > URL: https://issues.apache.org/jira/browse/MINIFICPP-673 > Project: NiFi MiNiFi C++ > Issue Type: Epic >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Major > Labels: ECU, nanofi > > Edge Collector Units ( ECU ) will be minimized agents whose sole focus is > collection and retrieval of data. Defined as feature facing constructs, ECUs > will define functionality that is agnostic of system. We'll build the > portability behind the library. > > [~aboda] This ticket encompasses building software from individual units of > functionality. So take the log aggregation example in MINIFICPP-621 . There > we have an instance of "tail file" linked to site to site. To do this will > require the ability to link these units ( we've called them building blocks, > but that's more documentation ), stream data between them, and then define > success and failure conditions ( or relationships ). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MINIFICPP-666) NanoFi should be c file not Cpp file
[ https://issues.apache.org/jira/browse/MINIFICPP-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault reassigned MINIFICPP-666: Assignee: Arpad Boda > NanoFi should be c file not Cpp file > > > Key: MINIFICPP-666 > URL: https://issues.apache.org/jira/browse/MINIFICPP-666 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Arpad Boda >Priority: Major > > This should be the eventual goal of moving the cpp file to C as we move from > C to C++ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5990) Move Developer docs section above Processors
[ https://issues.apache.org/jira/browse/NIFI-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-5990: -- Status: Patch Available (was: Open) > Move Developer docs section above Processors > > > Key: NIFI-5990 > URL: https://issues.apache.org/jira/browse/NIFI-5990 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Fix For: 1.9.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The Developer section of the docs is hidden below Processors, we should move > it up to make it easier to find. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] bbende opened a new pull request #3283: NIFI-5990 Moving Developer docs section above Processors
bbende opened a new pull request #3283: NIFI-5990 Moving Developer docs section above Processors URL: https://github.com/apache/nifi/pull/3283 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (NIFI-5983) recordReader parse problems in PutDatabaseRecord: flowfiles not transferred to failure relationship
[ https://issues.apache.org/jira/browse/NIFI-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757491#comment-16757491 ] Endre Kovacs edited comment on NIFI-5983 at 1/31/19 4:50 PM: - two PRs are sent: solving the problem at the processor side: [https://github.com/apache/nifi/pull/3280] solving the problem at the recordReaders side: [https://github.com/apache/nifi/pull/3282] they are mutually exclusive: if one of them is accepted, the other one should be thrown away. was (Author: andrewsmith87): two PRs are sent: solving the problem at the processor side: https://github.com/apache/nifi/pull/3280 solving the problem at the recordReaders side: https://github.com/apache/nifi/pull/3282 > recordReader parse problems in PutDatabaseRecord: flowfiles not transferred > to failure relationship > --- > > Key: NIFI-5983 > URL: https://issues.apache.org/jira/browse/NIFI-5983 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.7.0 >Reporter: Endre Kovacs >Assignee: Endre Kovacs >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > When using PutDatabaseRecord, parse problems in record reader (Avro, CSV, but > possibly others too) should cause the flowfiles to transfer to failure > relationship, however, they are instead session rollbacked. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (NIFI-5983) recordReader parse problems in PutDatabaseRecord: flowfiles not transferred to failure relationship
[ https://issues.apache.org/jira/browse/NIFI-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endre Kovacs updated NIFI-5983: --- Status: Patch Available (was: Open) two PRs are sent: solving the problem at the processor side: https://github.com/apache/nifi/pull/3280 solving the problem at the recordReaders side: https://github.com/apache/nifi/pull/3282 > recordReader parse problems in PutDatabaseRecord: flowfiles not transferred > to failure relationship > --- > > Key: NIFI-5983 > URL: https://issues.apache.org/jira/browse/NIFI-5983 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.7.0 >Reporter: Endre Kovacs >Assignee: Endre Kovacs >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > When using PutDatabaseRecord, parse problems in record reader (Avro, CSV, but > possibly others too) should cause the flowfiles to transfer to failure > relationship, however, they are instead session rollbacked. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ekovacs opened a new pull request #3282: NIFI-5983: handling parse problems in recordReader implementations
ekovacs opened a new pull request #3282: NIFI-5983: handling parse problems in recordReader implementations URL: https://github.com/apache/nifi/pull/3282 A different take on solving NIFI-5983: This approach catches the parse (RuntimeException) exceptions early at the recordReader implementations, and re-throwing them as MalformedRecordException, which is handled well (transfers to failure relationship instead of session rollback) in PutDatabaseRecord processor (instead of handling it only & directly in the PutDatabaseRecord processor itself, implemented https://github.com/apache/nifi/pull/3280) only one of the pr (this or the other: https://github.com/apache/nifi/pull/3280) should be accepted the other thrown away. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] thenatog commented on issue #3204: NIFI-1364 - Removed custom OCSP certificate revocation checking code and replaced with just using Java native implementation.
thenatog commented on issue #3204: NIFI-1364 - Removed custom OCSP certificate revocation checking code and replaced with just using Java native implementation. URL: https://github.com/apache/nifi/pull/3204#issuecomment-459408171 @alopresto Would you be able to take a look into this PR as well? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aeaversa commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
aeaversa commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor… URL: https://github.com/apache/nifi/pull/3281#issuecomment-459405633 @mosermw - Thanks Mike! Yeah, I totally agree that there should be another option outside of "Terminate" that allows a processor to naturally stop on its own. I propose to add a "WAIT" button on the Terminate dialog versus "NO" and when clicked, simply poll the processor state until the processor has chewed through its active threads and fully stopped before ultimately presenting the Configure Processor modal. Let me know if this sounds like an optimal solution in your opinion to this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-5990) Move Developer docs section above Processors
Bryan Bende created NIFI-5990: - Summary: Move Developer docs section above Processors Key: NIFI-5990 URL: https://issues.apache.org/jira/browse/NIFI-5990 Project: Apache NiFi Issue Type: Improvement Reporter: Bryan Bende Assignee: Bryan Bende Fix For: 1.9.0 The Developer section of the docs is hidden below Processors, we should move it up to make it easier to find. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …
thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r252705728 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java ## @@ -586,7 +586,14 @@ private WebAppContext loadWar(final File warFile, final String contextPath, fina // configure the max form size (3x the default) webappContext.setMaxFormContentSize(60); -addHTTPHeaders(webappContext); +ArrayList> filters = new ArrayList<>(); Review comment: Updated This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mosermw edited a comment on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
mosermw edited a comment on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor… URL: https://github.com/apache/nifi/pull/3281#issuecomment-459378372 For what it's worth, I'm super in favor of user experience improvements like this. When using NiFi regularly and sometimes all day, extra clicks get annoying for something you are doing constantly. I've heard the same feedback from users myself, that this feature would be useful. My only concern is getting this right for processors that do not stop instantly. I get super annoyed when I stop a long running processor that's currently using threads and I have to Refresh the canvas waiting for it to stop. It would be great for this feature to Stop the processor, wait for it to fully stop, then Configure. There might need to be a timeout in there if the processor doesn't stop in 10 seconds or so. Of course I didn't read the code before commenting ... it might already handle the long running processor case? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mosermw commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
mosermw commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor… URL: https://github.com/apache/nifi/pull/3281#issuecomment-459378372 For what it's worth, I'm super in favor of user experience improvements like this. When using NiFi regularly and sometimes all day, extra clicks get annoying for something you are doing constantly. I've heard the same feedback from users myself, that this feature would be useful. My only concern is getting this right for processors that do not stop instantly. I get super annoyed when I stop a long running processor that's currently using threads and I have to Refresh the canvas waiting for it to stop. It would be great for this feature to Stop the processor, wait for it to fully stop, then Configure. There might need to be a timeout in there if the processor doesn't stop in 10 seconds or so. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication
phrocker commented on a change in pull request #470: MINIFICPP-706 -
RawSiteToSite: remove code duplication
URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r252668613
##
File path: libminifi/src/sitetosite/RawSocketProtocol.cpp
##
@@ -395,97 +395,37 @@ bool
RawSiteToSiteClient::getPeerList(std::vector ) {
}
}
-int RawSiteToSiteClient::writeRequestType(RequestType type) {
- if (type >= MAX_REQUEST_TYPE)
-return -1;
-
- return peer_->writeUTF(SiteToSiteRequest::RequestTypeStr[type]);
-}
-
-int RawSiteToSiteClient::readRequestType(RequestType ) {
- std::string requestTypeStr;
-
- int ret = peer_->readUTF(requestTypeStr);
-
- if (ret <= 0)
-return ret;
+ int RawSiteToSiteClient::writeRequestType(RequestType type) {
+if (type >= MAX_REQUEST_TYPE)
+ return -1;
- for (int i = NEGOTIATE_FLOWFILE_CODEC; i <= SHUTDOWN; i++) {
-if (SiteToSiteRequest::RequestTypeStr[i] == requestTypeStr) {
- type = (RequestType) i;
- return ret;
-}
+return peer_->writeUTF(SiteToSiteRequest::RequestTypeStr[type]);
}
- return -1;
-}
-
-int RawSiteToSiteClient::readRespond(const std::shared_ptr
, RespondCode , std::string ) {
- uint8_t firstByte;
Review comment:
Yep, I usually do full scope when anything touches core code, no matter how
trivial the changes appear: docker tests, site to site secure, unsecure,
transfers -- in this case I'll do raw and http just to be safe ( in minifi note
C agent )...maybe more if I think it's prudent -- once all that is done I'll
take another look at the PR and approve for merge in 0.7.0. Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication
phrocker commented on a change in pull request #470: MINIFICPP-706 -
RawSiteToSite: remove code duplication
URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r252668613
##
File path: libminifi/src/sitetosite/RawSocketProtocol.cpp
##
@@ -395,97 +395,37 @@ bool
RawSiteToSiteClient::getPeerList(std::vector ) {
}
}
-int RawSiteToSiteClient::writeRequestType(RequestType type) {
- if (type >= MAX_REQUEST_TYPE)
-return -1;
-
- return peer_->writeUTF(SiteToSiteRequest::RequestTypeStr[type]);
-}
-
-int RawSiteToSiteClient::readRequestType(RequestType ) {
- std::string requestTypeStr;
-
- int ret = peer_->readUTF(requestTypeStr);
-
- if (ret <= 0)
-return ret;
+ int RawSiteToSiteClient::writeRequestType(RequestType type) {
+if (type >= MAX_REQUEST_TYPE)
+ return -1;
- for (int i = NEGOTIATE_FLOWFILE_CODEC; i <= SHUTDOWN; i++) {
-if (SiteToSiteRequest::RequestTypeStr[i] == requestTypeStr) {
- type = (RequestType) i;
- return ret;
-}
+return peer_->writeUTF(SiteToSiteRequest::RequestTypeStr[type]);
}
- return -1;
-}
-
-int RawSiteToSiteClient::readRespond(const std::shared_ptr
, RespondCode , std::string ) {
- uint8_t firstByte;
Review comment:
Yep, I usually do full scope: docker tests, site to site secure, unsecure,
transfers -- in this case I'll do raw and http just to be safe ( in minifi note
C agent ). -- once all that is done I'll take another look at the PR and
approve for merge in 0.7.0. Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] arpadboda commented on a change in pull request #436: MINIFICPP-667: Add structural definitions to work out plan for C migr…
arpadboda commented on a change in pull request #436: MINIFICPP-667: Add
structural definitions to work out plan for C migr…
URL: https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r252668567
##
File path: nanofi/include/core/cstructs.h
##
@@ -92,6 +102,17 @@ typedef struct {
*
*/
typedef struct {
+ // structural definitions for moving way from C++
+ unsigned modified:1;
Review comment:
No, didn't touch C structures yet, I think I won't need to do either as
there is C API to get attributes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] arpadboda commented on a change in pull request #436: MINIFICPP-667: Add structural definitions to work out plan for C migr…
arpadboda commented on a change in pull request #436: MINIFICPP-667: Add
structural definitions to work out plan for C migr…
URL: https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r252667970
##
File path: nanofi/src/cxx/nanofi_cpp_layer.cpp
##
@@ -0,0 +1,65 @@
+#include
+#include
+#include
+#include
+#include
+
+#include "api/nanofi.h"
+#include "core/Core.h"
+#include "core/expect.h"
+#include "cxx/Instance.h"
+#include "cxx/Plan.h"
+#include "ResourceClaim.h"
+#include "processors/GetFile.h"
+#include "core/logging/LoggerConfiguration.h"
+#include "utils/StringUtils.h"
+
+#include "cxx/nanofi_cpp_layer.h"
+
+class API_INITIALIZER {
+ public:
+ static int initialized;
+};
+
+int API_INITIALIZER::initialized = initialize_api();
+
Review comment:
You mean NOT going to merge?
Totally agree, my current site2site work introduces UT collections anyway to
help working in C.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication
arpadboda commented on a change in pull request #470: MINIFICPP-706 -
RawSiteToSite: remove code duplication
URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r252667506
##
File path: libminifi/src/sitetosite/RawSocketProtocol.cpp
##
@@ -395,97 +395,37 @@ bool
RawSiteToSiteClient::getPeerList(std::vector ) {
}
}
-int RawSiteToSiteClient::writeRequestType(RequestType type) {
- if (type >= MAX_REQUEST_TYPE)
-return -1;
-
- return peer_->writeUTF(SiteToSiteRequest::RequestTypeStr[type]);
-}
-
-int RawSiteToSiteClient::readRequestType(RequestType ) {
- std::string requestTypeStr;
-
- int ret = peer_->readUTF(requestTypeStr);
-
- if (ret <= 0)
-return ret;
+ int RawSiteToSiteClient::writeRequestType(RequestType type) {
+if (type >= MAX_REQUEST_TYPE)
+ return -1;
- for (int i = NEGOTIATE_FLOWFILE_CODEC; i <= SHUTDOWN; i++) {
-if (SiteToSiteRequest::RequestTypeStr[i] == requestTypeStr) {
- type = (RequestType) i;
- return ret;
-}
+return peer_->writeUTF(SiteToSiteRequest::RequestTypeStr[type]);
}
- return -1;
-}
-
-int RawSiteToSiteClient::readRespond(const std::shared_ptr
, RespondCode , std::string ) {
- uint8_t firstByte;
Review comment:
Two things I did:
-Executed site2site related unit tests
-Verified transfers from MiNiFi to NiFi using the C examples (which still
rely on C++ S2S implementation atm)
Any further verification is welcome and thanks in advance for that!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication
arpadboda commented on a change in pull request #470: MINIFICPP-706 -
RawSiteToSite: remove code duplication
URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r252667506
##
File path: libminifi/src/sitetosite/RawSocketProtocol.cpp
##
@@ -395,97 +395,37 @@ bool
RawSiteToSiteClient::getPeerList(std::vector ) {
}
}
-int RawSiteToSiteClient::writeRequestType(RequestType type) {
- if (type >= MAX_REQUEST_TYPE)
-return -1;
-
- return peer_->writeUTF(SiteToSiteRequest::RequestTypeStr[type]);
-}
-
-int RawSiteToSiteClient::readRequestType(RequestType ) {
- std::string requestTypeStr;
-
- int ret = peer_->readUTF(requestTypeStr);
-
- if (ret <= 0)
-return ret;
+ int RawSiteToSiteClient::writeRequestType(RequestType type) {
+if (type >= MAX_REQUEST_TYPE)
+ return -1;
- for (int i = NEGOTIATE_FLOWFILE_CODEC; i <= SHUTDOWN; i++) {
-if (SiteToSiteRequest::RequestTypeStr[i] == requestTypeStr) {
- type = (RequestType) i;
- return ret;
-}
+return peer_->writeUTF(SiteToSiteRequest::RequestTypeStr[type]);
}
- return -1;
-}
-
-int RawSiteToSiteClient::readRespond(const std::shared_ptr
, RespondCode , std::string ) {
- uint8_t firstByte;
Review comment:
Two things I did:
-Execute site2site related unit tests
-Verified transfers from MiNiFi to NiFi using the C examples (which still
rely on C++ S2S implementation atm)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] aeaversa commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor…
aeaversa commented on issue #3281: NIFI-5986 Adding "Stop & Configure" button functionality to Processor… URL: https://github.com/apache/nifi/pull/3281#issuecomment-459339774 @mcgilman - Thanks Matt! So glad you got a chance to take a look. So, the motivation behind the change was purely to improve navigational efficiency and response time for end users in quickly being able to identify and correct a started processor that somehow had an incorrect configuration; limiting the amount of flow files that can traverse through the misconfigured processor. In working with both novice and advanced users of NiFi for the last year, I've had consistent requests that there be a simple button that allows a user to directly stop a processor and automatically allow editing of the processor's properties. The current navigational route from viewing a started processor's details (read only) to editing its properties in the configure processor modal was always reported as a bit cumbersome: (ie - user clicks to open the processor details modal of a started processor and notices a properties change is necessary > user clicks to close the processor details modal > user right/left clicks to stop the processor > user clicks to open what looks like the same processor details modal dialog, but now allows them to edit the desired properties). I tried to keep the changes as simple as possible when I sent the PR. In this change, the processor details modal should only present the "Stop & Configure" button when its launched directly from the canvas interface to limit any conflicts with where it is used on other interfaces (ie: Summary, etc etc). ... as well it will disable the button if the processor is in any state other then RUNNING or the user demonstrates insufficient permissions. If there are other concerns you have, please let me know what those are and I can work to get those addressed. My thanks again for taking a look! Take care, --alex This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (MINIFICPP-719) Fix bootstrap issues
[ https://issues.apache.org/jira/browse/MINIFICPP-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault resolved MINIFICPP-719. -- Resolution: Fixed > Fix bootstrap issues > > > Key: MINIFICPP-719 > URL: https://issues.apache.org/jira/browse/MINIFICPP-719 > Project: NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > 1) Allow tests to be disabled. > 2) Correctly identify that kafka can or cannot be built on versions of gcc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] phrocker commented on a change in pull request #436: MINIFICPP-667: Add structural definitions to work out plan for C migr…
phrocker commented on a change in pull request #436: MINIFICPP-667: Add
structural definitions to work out plan for C migr…
URL: https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r252644180
##
File path: nanofi/include/core/cstructs.h
##
@@ -92,6 +102,17 @@ typedef struct {
*
*/
typedef struct {
+ // structural definitions for moving way from C++
+ unsigned modified:1;
Review comment:
@arpadboda changes in cstructs were the only thing of merit here, where we
have attributes...are you incorporating something like this into your site to
site work?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] phrocker commented on issue #436: MINIFICPP-667: Add structural definitions to work out plan for C migr…
phrocker commented on issue #436: MINIFICPP-667: Add structural definitions to work out plan for C migr… URL: https://github.com/apache/nifi-minifi-cpp/pull/436#issuecomment-459322849 Was simply proof of concept to work out plan and visually see ideas in a diff. never intended to merge, so closing as it's OBE. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] phrocker closed pull request #436: MINIFICPP-667: Add structural definitions to work out plan for C migr…
phrocker closed pull request #436: MINIFICPP-667: Add structural definitions to work out plan for C migr… URL: https://github.com/apache/nifi-minifi-cpp/pull/436 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] phrocker commented on a change in pull request #436: MINIFICPP-667: Add structural definitions to work out plan for C migr…
phrocker commented on a change in pull request #436: MINIFICPP-667: Add
structural definitions to work out plan for C migr…
URL: https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r252643664
##
File path: nanofi/src/cxx/nanofi_cpp_layer.cpp
##
@@ -0,0 +1,65 @@
+#include
+#include
+#include
+#include
+#include
+
+#include "api/nanofi.h"
+#include "core/Core.h"
+#include "core/expect.h"
+#include "cxx/Instance.h"
+#include "cxx/Plan.h"
+#include "ResourceClaim.h"
+#include "processors/GetFile.h"
+#include "core/logging/LoggerConfiguration.h"
+#include "utils/StringUtils.h"
+
+#include "cxx/nanofi_cpp_layer.h"
+
+class API_INITIALIZER {
+ public:
+ static int initialized;
+};
+
+int API_INITIALIZER::initialized = initialize_api();
+
Review comment:
@arpadboda I'm going to merge this PR since some of this has made it's way
elsewhere and this was just a proof of concept; however, it may make sense to
begin isolating the cpp layer a little more like this for the eventuality that
we remote it entirely.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication
phrocker commented on a change in pull request #470: MINIFICPP-706 -
RawSiteToSite: remove code duplication
URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r252643034
##
File path: libminifi/src/sitetosite/RawSocketProtocol.cpp
##
@@ -395,97 +395,37 @@ bool
RawSiteToSiteClient::getPeerList(std::vector ) {
}
}
-int RawSiteToSiteClient::writeRequestType(RequestType type) {
- if (type >= MAX_REQUEST_TYPE)
-return -1;
-
- return peer_->writeUTF(SiteToSiteRequest::RequestTypeStr[type]);
-}
-
-int RawSiteToSiteClient::readRequestType(RequestType ) {
- std::string requestTypeStr;
-
- int ret = peer_->readUTF(requestTypeStr);
-
- if (ret <= 0)
-return ret;
+ int RawSiteToSiteClient::writeRequestType(RequestType type) {
+if (type >= MAX_REQUEST_TYPE)
+ return -1;
- for (int i = NEGOTIATE_FLOWFILE_CODEC; i <= SHUTDOWN; i++) {
-if (SiteToSiteRequest::RequestTypeStr[i] == requestTypeStr) {
- type = (RequestType) i;
- return ret;
-}
+return peer_->writeUTF(SiteToSiteRequest::RequestTypeStr[type]);
}
- return -1;
-}
-
-int RawSiteToSiteClient::readRespond(const std::shared_ptr
, RespondCode , std::string ) {
- uint8_t firstByte;
Review comment:
I didn't see a response for this. I have some time in the next few days to
run tests. What have you been able to run? Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Resolved] (MINIFICPP-702) Bootstrap incorrectly prohibits kafka and pcap from being built on centos 7
[ https://issues.apache.org/jira/browse/MINIFICPP-702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault resolved MINIFICPP-702. -- Resolution: Fixed > Bootstrap incorrectly prohibits kafka and pcap from being built on centos 7 > --- > > Key: MINIFICPP-702 > URL: https://issues.apache.org/jira/browse/MINIFICPP-702 > Project: NiFi MiNiFi C++ > Issue Type: Sub-task >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > > Am able to build both kafka and pcap manually by specifying the options at > the command line. The bootstrap limits them on Centos 7, which is not valid. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] asfgit closed pull request #479: MINIFICPP-719: Fix bootstrap issues for sqllite and testing
asfgit closed pull request #479: MINIFICPP-719: Fix bootstrap issues for sqllite and testing URL: https://github.com/apache/nifi-minifi-cpp/pull/479 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-5989) Improve PutKudu BatchSize handling
[ https://issues.apache.org/jira/browse/NIFI-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Goos updated NIFI-5989: Attachment: 0001-NIFI-5989-PutKudu-Additional-FF-Queue-length-setting.patch > Improve PutKudu BatchSize handling > -- > > Key: NIFI-5989 > URL: https://issues.apache.org/jira/browse/NIFI-5989 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.8.0 >Reporter: Alex Goos >Priority: Major > Labels: kudu, nifi > Fix For: 1.9.0 > > Attachments: > 0001-NIFI-5989-PutKudu-Additional-FF-Queue-length-setting.patch > > > Current "Batch size" property of PutKudu affects both: the number of > Flowfiles pulled per OnTrigger and the size of the Kudu client modification > buffer. > If the Flowfiles contain a considerable amount of records, then a > disproportionate amount of data is pulled in and deserialized into memory, > when in AUTO_FLUSH_BACKGROUND mode. > We propose introducing a separate setting for the batch size of FlowFiles. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (NIFI-5989) Improve PutKudu BatchSize handling
Alex Goos created NIFI-5989: --- Summary: Improve PutKudu BatchSize handling Key: NIFI-5989 URL: https://issues.apache.org/jira/browse/NIFI-5989 Project: Apache NiFi Issue Type: Improvement Components: Extensions Affects Versions: 1.8.0 Reporter: Alex Goos Fix For: 1.9.0 Current "Batch size" property of PutKudu affects both: the number of Flowfiles pulled per OnTrigger and the size of the Kudu client modification buffer. If the Flowfiles contain a considerable amount of records, then a disproportionate amount of data is pulled in and deserialized into memory, when in AUTO_FLUSH_BACKGROUND mode. We propose introducing a separate setting for the batch size of FlowFiles. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
