[jira] [Updated] (NIFI-2298) Add missing futures for ConsumeKafka

2016-07-17 Thread sumanth chinthagunta (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sumanth chinthagunta updated NIFI-2298: --- Description: The new ConsumeKafka processor is missing some capabilities that were

[jira] [Created] (NIFI-2299) Add standard services API dependency to Scripting Processors

2016-07-17 Thread sumanth chinthagunta (JIRA)
sumanth chinthagunta created NIFI-2299: -- Summary: Add standard services API dependency to Scripting Processors Key: NIFI-2299 URL: https://issues.apache.org/jira/browse/NIFI-2299 Project:

[jira] [Created] (NIFI-2298) Add missing futures for ConsumeKafka

2016-07-17 Thread sumanth chinthagunta (JIRA)
sumanth chinthagunta created NIFI-2298: -- Summary: Add missing futures for ConsumeKafka Key: NIFI-2298 URL: https://issues.apache.org/jira/browse/NIFI-2298 Project: Apache NiFi Issue

[jira] [Created] (NIFI-2297) Describe differences for QueryDatabaseTable between 0.x and 1.0

2016-07-17 Thread Matt Burgess (JIRA)
Matt Burgess created NIFI-2297: -- Summary: Describe differences for QueryDatabaseTable between 0.x and 1.0 Key: NIFI-2297 URL: https://issues.apache.org/jira/browse/NIFI-2297 Project: Apache NiFi

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-17 Thread mans2singh
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/502 Hi @JPercivall - I've updated the code based on your comments. Please let me know if you have any other comments. Thanks. --- If your project is set up for it, you can reply to this email and

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-17 Thread mans2singh
Github user mans2singh commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r71093727 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,26 @@ +nifi-ignite-nar +Copyright

[jira] [Commented] (NIFI-2156) Add ListDatabaseTables processor

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381598#comment-15381598 ] ASF GitHub Bot commented on NIFI-2156: -- Github user mattyb149 commented on a diff in the pull request:

[GitHub] nifi pull request #642: NIFI-2156: Add ListDatabaseTables processor

2016-07-17 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/642#discussion_r71093459 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java --- @@

[jira] [Commented] (NIFI-2156) Add ListDatabaseTables processor

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381570#comment-15381570 ] ASF GitHub Bot commented on NIFI-2156: -- Github user mattyb149 commented on a diff in the pull request:

[GitHub] nifi pull request #642: NIFI-2156: Add ListDatabaseTables processor

2016-07-17 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/642#discussion_r71091826 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java --- @@

[jira] [Commented] (NIFI-2156) Add ListDatabaseTables processor

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381560#comment-15381560 ] ASF GitHub Bot commented on NIFI-2156: -- Github user JPercivall commented on a diff in the pull

[GitHub] nifi pull request #642: NIFI-2156: Add ListDatabaseTables processor

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/642#discussion_r71091358 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java --- @@

[jira] [Commented] (NIFI-2156) Add ListDatabaseTables processor

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381559#comment-15381559 ] ASF GitHub Bot commented on NIFI-2156: -- Github user JPercivall commented on a diff in the pull

[GitHub] nifi pull request #642: NIFI-2156: Add ListDatabaseTables processor

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/642#discussion_r71091290 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java --- @@

[jira] [Commented] (NIFI-2157) Add GenerateTableFetch processor

2016-07-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381547#comment-15381547 ] ASF subversion and git services commented on NIFI-2157: --- Commit

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/645 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (NIFI-2157) Add GenerateTableFetch processor

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381548#comment-15381548 ] ASF GitHub Bot commented on NIFI-2157: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-2157) Add GenerateTableFetch processor

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381543#comment-15381543 ] ASF GitHub Bot commented on NIFI-2157: -- Github user JPercivall commented on the issue:

[GitHub] nifi issue #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-17 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/645 +1 Went through code and any comments were addressed. ran a contrib check build and verified against a MySQL DB. Thanks @mattyb149, I will merge it in. --- If your project is set up for

[jira] [Updated] (NIFI-2296) The hover text for the Search icon in the Upload Template window is confusing

2016-07-17 Thread Andrew Lim (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lim updated NIFI-2296: - Attachment: NIFI-2296_xmlChosen.png NIFI-2296_noFileChosen.png > The hover text for the

[jira] [Created] (NIFI-2296) The hover text for the Search icon in the Upload Template window is confusing

2016-07-17 Thread Andrew Lim (JIRA)
Andrew Lim created NIFI-2296: Summary: The hover text for the Search icon in the Upload Template window is confusing Key: NIFI-2296 URL: https://issues.apache.org/jira/browse/NIFI-2296 Project: Apache

[jira] [Created] (NIFI-2295) Replay Permissions bug in unsecure standalone instance

2016-07-17 Thread Joseph Percivall (JIRA)
Joseph Percivall created NIFI-2295: -- Summary: Replay Permissions bug in unsecure standalone instance Key: NIFI-2295 URL: https://issues.apache.org/jira/browse/NIFI-2295 Project: Apache NiFi

[jira] [Commented] (NIFI-1942) Create a processor to validate CSV against a user-supplied schema

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381508#comment-15381508 ] ASF GitHub Bot commented on NIFI-1942: -- Github user JPercivall commented on the issue:

[GitHub] nifi issue #476: NIFI-1942 Processor to validate CSV against user-supplied s...

2016-07-17 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/476 I'm trying to use a couple of the processors listed in the accompanying doc you link to[1] but there seem to be some processors that aren't available (notably "IsIncludedIn"). I was trying to make

[jira] [Commented] (NIFI-1942) Create a processor to validate CSV against a user-supplied schema

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381503#comment-15381503 ] ASF GitHub Bot commented on NIFI-1942: -- Github user JPercivall commented on a diff in the pull

[GitHub] nifi pull request #476: NIFI-1942 Processor to validate CSV against user-sup...

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/476#discussion_r71088596 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java --- @@ -0,0

[GitHub] nifi pull request #476: NIFI-1942 Processor to validate CSV against user-sup...

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/476#discussion_r71088438 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java --- @@ -0,0

[jira] [Commented] (NIFI-1942) Create a processor to validate CSV against a user-supplied schema

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381482#comment-15381482 ] ASF GitHub Bot commented on NIFI-1942: -- Github user JPercivall commented on a diff in the pull

[GitHub] nifi pull request #476: NIFI-1942 Processor to validate CSV against user-sup...

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/476#discussion_r71088067 --- Diff: nifi-assembly/NOTICE --- @@ -193,6 +193,8 @@ The following binary components are provided under the Apache Software License v (ASLv2)

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71087720 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java --- @@

[jira] [Commented] (NIFI-2157) Add GenerateTableFetch processor

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381471#comment-15381471 ] ASF GitHub Bot commented on NIFI-2157: -- Github user mattyb149 commented on a diff in the pull request:

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-17 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71087671 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java --- @@

[jira] [Updated] (NIFI-1942) Create a processor to validate CSV against a user-supplied schema

2016-07-17 Thread Pierre Villard (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-1942: - Attachment: ValidateCSV.xml Template to validate the processor. > Create a processor to validate

[jira] [Commented] (NIFI-2157) Add GenerateTableFetch processor

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381466#comment-15381466 ] ASF GitHub Bot commented on NIFI-2157: -- Github user JPercivall commented on a diff in the pull

[GitHub] nifi pull request #645: NIFI-2157: Add GenerateTableFetch processor

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/645#discussion_r71087628 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java --- @@

[GitHub] nifi issue #476: NIFI-1942 Processor to validate CSV against user-supplied s...

2016-07-17 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/476 Hey @JPercivall, thanks for the review! I believe I addressed all of your comments. I also added the new dependency in NOTICE files (let me know if it is OK). To validate the processor I used a

[GitHub] nifi pull request #664: NIFI-2280 marked methods as deprecated which will be...

2016-07-17 Thread joewitt
Github user joewitt closed the pull request at: https://github.com/apache/nifi/pull/664 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (NIFI-2280) Annotate methods as deprecated on 0.x which aren't needed on 1.x

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381451#comment-15381451 ] ASF GitHub Bot commented on NIFI-2280: -- Github user joewitt closed the pull request at:

[jira] [Updated] (NIFI-2294) Scroll bar exists in the Settings tab of the Configure Connection window

2016-07-17 Thread Andrew Lim (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lim updated NIFI-2294: - Attachment: NIFI-2294_scrollBar.png > Scroll bar exists in the Settings tab of the Configure Connection

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r71086795 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,26 @@ +nifi-ignite-nar --- End diff

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r71086770 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,26 @@ +nifi-ignite-nar +Copyright

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r71086749 --- Diff: pom.xml --- @@ -227,6 +227,29 @@ language governing permissions and limitations under the License. --> 1.5.3-M1

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r71086694 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,26 @@ +nifi-ignite-nar +Copyright

[jira] [Resolved] (NIFI-2280) Annotate methods as deprecated on 0.x which aren't needed on 1.x

2016-07-17 Thread Joseph Percivall (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Percivall resolved NIFI-2280. Resolution: Fixed > Annotate methods as deprecated on 0.x which aren't needed on 1.x >

[jira] [Commented] (NIFI-2280) Annotate methods as deprecated on 0.x which aren't needed on 1.x

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381442#comment-15381442 ] ASF GitHub Bot commented on NIFI-2280: -- Github user JPercivall commented on the issue:

[GitHub] nifi issue #664: NIFI-2280 marked methods as deprecated which will be remove...

2016-07-17 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/664 @joewitt just pushed out the change but since it's only on the 0.x branch you'll need to close this PR manually. https://git1-us-west.apache.org/repos/asf?p=nifi.git;a=commit;h=537b3d0d

[jira] [Commented] (NIFI-1157) Remove deprecated classes and methods

2016-07-17 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381441#comment-15381441 ] ASF subversion and git services commented on NIFI-1157: --- Commit

[jira] [Commented] (NIFI-2280) Annotate methods as deprecated on 0.x which aren't needed on 1.x

2016-07-17 Thread Joseph Witt (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381439#comment-15381439 ] Joseph Witt commented on NIFI-2280: --- ah nice catch and thanks for taking care of it! > Annotate methods

[jira] [Commented] (NIFI-2280) Annotate methods as deprecated on 0.x which aren't needed on 1.x

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381430#comment-15381430 ] ASF GitHub Bot commented on NIFI-2280: -- Github user JPercivall commented on the issue:

[GitHub] nifi issue #664: NIFI-2280 marked methods as deprecated which will be remove...

2016-07-17 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/664 Looks good overall, a couple of the deprecated markings are missing a corresponding "@deprecated use other getCipher requiring a salt" javadoc. I'll just add them for you because everything else

[jira] [Commented] (NIFI-2110) Queue Position doesn't show up in List Queue Details dialog

2016-07-17 Thread Matt Gilman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381401#comment-15381401 ] Matt Gilman commented on NIFI-2110: --- [~markap14] Queue listing isn't showing up because this dialog

[jira] [Comment Edited] (NIFI-2110) Queue Position doesn't show up in List Queue Details dialog

2016-07-17 Thread Matt Gilman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381401#comment-15381401 ] Matt Gilman edited comment on NIFI-2110 at 7/17/16 3:54 PM: [~markap14] Queue

[jira] [Assigned] (NIFI-2096) Can't upload template using Firefox

2016-07-17 Thread Matt Gilman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-2096: - Assignee: Matt Gilman > Can't upload template using Firefox > ---

[jira] [Commented] (NIFI-2282) Purge history not working

2016-07-17 Thread Matt Gilman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381386#comment-15381386 ] Matt Gilman commented on NIFI-2282: --- [~rmoran] Can you please try this again? I was unable to replicate.

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-17 Thread mans2singh
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/502 @pvillard31 - The build is passing locally for me, so I am not sure what could the issue with the travis build. --- If your project is set up for it, you can reply to this email and have your

[jira] [Updated] (NIFI-2293) Add controls for accessing each Node's History

2016-07-17 Thread Matt Gilman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-2293: -- Issue Type: Improvement (was: Bug) > Add controls for accessing each Node's History >

[jira] [Updated] (NIFI-2263) Update History to work in a Cluster

2016-07-17 Thread Matt Gilman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-2263: -- Description: Each node in a cluster records it's own independent history of configuration actions. Based

[jira] [Updated] (NIFI-2263) Update History to work in a Cluster

2016-07-17 Thread Matt Gilman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-2263: -- Description: Each node in a cluster records it's own independent history of configuration actions. Based

[jira] [Commented] (NIFI-2026) nifi-hadoop-libraries-nar should use profiles to point to different hadoop distro artifacts

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381353#comment-15381353 ] ASF GitHub Bot commented on NIFI-2026: -- Github user trixpan commented on the issue:

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-17 Thread mans2singh
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/502 @pvillard31 - I am checking into the build failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have