szaszm commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498584923
##
File path: encrypt-config/ConfigFile.cpp
##
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * cont
alopresto commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498583289
##
File path: encrypt-config/ConfigFile.cpp
##
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
levilentz commented on pull request #4204:
URL: https://github.com/apache/nifi/pull/4204#issuecomment-702476413
> @levilentz can you take a look at this and get back to me on what
improvements you made need to be incorporated?
@MikeThomsen, the main changes that I have are the follow
[
https://issues.apache.org/jira/browse/NIFI-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Thomsen updated NIFI-7844:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> substring should return empty ins
[
https://issues.apache.org/jira/browse/NIFI-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205885#comment-17205885
]
ASF subversion and git services commented on NIFI-7844:
---
Commit f324
asfgit closed pull request #4553:
URL: https://github.com/apache/nifi/pull/4553
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/NIFI-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205871#comment-17205871
]
Nathan Gough commented on NIFI-7870:
Sounds like this may be more complicated than fir
[
https://issues.apache.org/jira/browse/NIFI-7685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205840#comment-17205840
]
ASF subversion and git services commented on NIFI-7685:
---
Commit 6990
[
https://issues.apache.org/jira/browse/NIFI-7685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-7685:
---
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> A
mattyb149 closed pull request #4446:
URL: https://github.com/apache/nifi/pull/4446
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mattyb149 commented on pull request #4446:
URL: https://github.com/apache/nifi/pull/4446#issuecomment-702411269
+1 LGTM, ran contrib-check and verified expected behavior on FTP servers
with and without UTF8 support. Thanks for the improvement! Merging to main
-
jfrazee commented on pull request #4460:
URL: https://github.com/apache/nifi/pull/4460#issuecomment-702386711
@MikeThomsen I'm going to nit on something. This being called `JAVA_VERSION`
would make me think it'd be something like 11 or 1.8 or one of the many openjdk
tags and not the base i
[
https://issues.apache.org/jira/browse/NIFI-6738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205804#comment-17205804
]
Scott Nicholas commented on NIFI-6738:
--
I'm seeing this too. Surprised more don't.
turcsanyip commented on a change in pull request #4510:
URL: https://github.com/apache/nifi/pull/4510#discussion_r498473697
##
File path:
nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services/src/main/resources/org.apache.nifi.hazelcast.services.cacheclient.HazelcastMapCacheC
Andrew M. Lim created NIFI-7871:
---
Summary: Correct errors in documentation for UUID3, UUID5 and hash
in Expression Language Guide
Key: NIFI-7871
URL: https://issues.apache.org/jira/browse/NIFI-7871
Proj
[
https://issues.apache.org/jira/browse/NIFI-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew M. Lim reassigned NIFI-7871:
---
Assignee: Andrew M. Lim
> Correct errors in documentation for UUID3, UUID5 and hash in Expres
szaszm edited a comment on pull request #910:
URL: https://github.com/apache/nifi-minifi-cpp/pull/910#issuecomment-702308647
Reopened because we can keep the MSI generation in our repo and make it
package non-free DLLs, but we cannot redistribute the DLLs or the generated
installer, so at
szaszm commented on pull request #910:
URL: https://github.com/apache/nifi-minifi-cpp/pull/910#issuecomment-702308647
Reopened because we can keep the script in our repo. We will need to create
a license prompt in the MSI for the visual c++ redist and ucrt redist dlls in a
followup issue.
szaszm edited a comment on pull request #910:
URL: https://github.com/apache/nifi-minifi-cpp/pull/910#issuecomment-702308647
Reopened because we can keep the script in our repo. We will need to create
a license prompt in the MSI for the visual c++ redist and ucrt redist dlls in a
followup
[
https://issues.apache.org/jira/browse/NIFI-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wiktor Kubicki updated NIFI-7835:
-
Summary: SFTP processors (maybe other too) proxy doesn't use credentials
(was: SFTP processors (m
szaszm commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498366948
##
File path: cmake/BundledLibSodium.cmake
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor l
taftster commented on pull request #4221:
URL: https://github.com/apache/nifi/pull/4221#issuecomment-702239736
OK @anaylor - I'll follow your lead. If you come up with a better design,
then I can grab your commits and add them here. Or you can grab my commits and
we'll merge your branch.
fgerlits commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498356767
##
File path: encrypt-config/CMakeLists.txt
##
@@ -0,0 +1,25 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contrib
fgerlits commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498356448
##
File path: encrypt-config/EncryptConfig.cpp
##
@@ -0,0 +1,150 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
anaylor commented on pull request #4221:
URL: https://github.com/apache/nifi/pull/4221#issuecomment-702209932
Hey @taftster I was planning on pulling in your changes to my existing
branch but it would probably make more sense just to smash my changes onto here
instead of opening a new PR.
[
https://issues.apache.org/jira/browse/NIFI-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-7870:
Component/s: Core UI
> X-Content-Type missing for advanced UI resources
> --
[
https://issues.apache.org/jira/browse/NIFI-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-7870:
Priority: Critical (was: Major)
> X-Content-Type missing for advanced UI resources
> --
[
https://issues.apache.org/jira/browse/NIFI-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-7870:
Affects Version/s: 1.12.1
> X-Content-Type missing for advanced UI resources
> -
Nathan Gough created NIFI-7870:
--
Summary: X-Content-Type missing for advanced UI resources
Key: NIFI-7870
URL: https://issues.apache.org/jira/browse/NIFI-7870
Project: Apache NiFi
Issue Type: Bu
fgerlits commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498309792
##
File path: CMakeLists.txt
##
@@ -245,6 +245,12 @@ if (NOT OPENSSL_OFF)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DOPENSSL_SUPPORT")
endif()
[
https://issues.apache.org/jira/browse/NIFI-4890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Gilman reassigned NIFI-4890:
-
Assignee: Raz Dobkies
> OIDC Token Refresh is not done correctly
> --
fgerlits commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498308693
##
File path: cmake/BundledLibSodium.cmake
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
turcsanyip commented on a change in pull request #4510:
URL: https://github.com/apache/nifi/pull/4510#discussion_r498305509
##
File path:
nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services/pom.xml
##
@@ -0,0 +1,74 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:
lordgamez commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498300651
##
File path: encrypt-config/ConfigFileEncryptor.cpp
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
lordgamez commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498302716
##
File path: encrypt-config/EncryptConfig.cpp
##
@@ -0,0 +1,150 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
lordgamez commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498300651
##
File path: encrypt-config/ConfigFileEncryptor.cpp
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
lordgamez commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498296412
##
File path: encrypt-config/ConfigFile.cpp
##
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
pvillard31 opened a new pull request #305:
URL: https://github.com/apache/nifi-registry/pull/305
Thank you for submitting a contribution to Apache NiFi Registry.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug
Pierre Villard created NIFIREG-421:
--
Summary: Add GCS support for Ranger plugin
Key: NIFIREG-421
URL: https://issues.apache.org/jira/browse/NIFIREG-421
Project: NiFi Registry
Issue Type: Imp
fgerlits commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498290578
##
File path: encrypt-config/ConfigFileEncryptor.cpp
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
turcsanyip commented on pull request #4510:
URL: https://github.com/apache/nifi/pull/4510#issuecomment-702176664
Licensing info is missing from the nar modules. `LICENSE` / `NOTICE` files
need to be added with entries to the referenced libraries (eg. `hazelcast`).
fgerlits commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498290976
##
File path: encrypt-config/EncryptConfig.cpp
##
@@ -0,0 +1,150 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
fgerlits commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498290405
##
File path: encrypt-config/ConfigFile.cpp
##
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * co
pvillard31 opened a new pull request #304:
URL: https://github.com/apache/nifi-registry/pull/304
Thank you for submitting a contribution to Apache NiFi Registry.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug
szaszm opened a new pull request #918:
URL: https://github.com/apache/nifi-minifi-cpp/pull/918
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
Pierre Villard created NIFIREG-420:
--
Summary: Add Ozone support for Ranger plugin
Key: NIFIREG-420
URL: https://issues.apache.org/jira/browse/NIFIREG-420
Project: NiFi Registry
Issue Type: I
szaszm commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r497392257
##
File path: CMakeLists.txt
##
@@ -245,6 +245,12 @@ if (NOT OPENSSL_OFF)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DOPENSSL_SUPPORT")
endif()
Pierre Villard created NIFI-7869:
Summary: Add GCS for HDFS support in NiFi
Key: NIFI-7869
URL: https://issues.apache.org/jira/browse/NIFI-7869
Project: Apache NiFi
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/NIFI-7856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205531#comment-17205531
]
Mengze Li commented on NIFI-7856:
-
Thanks for the reply.
Do you mind trying ReplaceText 1.
[
https://issues.apache.org/jira/browse/NIFI-7856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mengze Li updated NIFI-7856:
Attachment: screenshot-3.png
> Provenance failed to be compressed after nifi upgrade to 1.12
> -
naddym commented on pull request #4560:
URL: https://github.com/apache/nifi/pull/4560#issuecomment-702137249
Thanks @mattyb149
This is an automated message from the Apache Git Service.
To respond to the message, please log o
turcsanyip commented on a change in pull request #4540:
URL: https://github.com/apache/nifi/pull/4540#discussion_r498244907
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/bootstrap.conf
##
@@ -66,6 +66,15 @@ java.arg.
[
https://issues.apache.org/jira/browse/NIFI-7856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205508#comment-17205508
]
Mark Payne commented on NIFI-7856:
--
I've tried replicating the issue but so far haven't b
[
https://issues.apache.org/jira/browse/MINIFICPP-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Szasz reopened MINIFICPP-1375:
-
> Ship Universal C Runtime DLLs
> -
>
> Key:
[
https://issues.apache.org/jira/browse/NIFI-7856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205501#comment-17205501
]
Mengze Li commented on NIFI-7856:
-
[~markap14] any chance that you have looked at this iss
[
https://issues.apache.org/jira/browse/NIFI-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205496#comment-17205496
]
ASF subversion and git services commented on NIFI-7859:
---
Commit e2cc
mattyb149 closed pull request #4560:
URL: https://github.com/apache/nifi/pull/4560
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/NIFI-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-7859:
---
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> W
mattyb149 commented on pull request #4560:
URL: https://github.com/apache/nifi/pull/4560#issuecomment-702121443
+1 LGTM, ran tests and verified results were as expected. Thanks for the
improvement! Merging to main
This is an
[
https://issues.apache.org/jira/browse/NIFI-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205463#comment-17205463
]
Si Sun commented on NIFI-7863:
--
hmm, yes this case wasn't considered ...
according to [smbj
lordgamez commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498117414
##
File path: encrypt-config/ConfigFileEncryptor.cpp
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
adamdebreceni commented on a change in pull request #917:
URL: https://github.com/apache/nifi-minifi-cpp/pull/917#discussion_r498163298
##
File path: extensions/libarchive/CompressContent.cpp
##
@@ -171,7 +183,7 @@ void CompressContent::onTrigger(const
std::shared_ptr &con
adamdebreceni commented on a change in pull request #917:
URL: https://github.com/apache/nifi-minifi-cpp/pull/917#discussion_r498162379
##
File path: extensions/libarchive/CompressContent.cpp
##
@@ -81,86 +101,78 @@ void CompressContent::initialize() {
}
void CompressConten
adamdebreceni commented on a change in pull request #917:
URL: https://github.com/apache/nifi-minifi-cpp/pull/917#discussion_r498162629
##
File path: extensions/libarchive/CompressContent.cpp
##
@@ -81,86 +101,78 @@ void CompressContent::initialize() {
}
void CompressConten
adamdebreceni commented on a change in pull request #917:
URL: https://github.com/apache/nifi-minifi-cpp/pull/917#discussion_r498160741
##
File path: extensions/libarchive/CompressContent.cpp
##
@@ -42,14 +42,14 @@ core::Property CompressContent::CompressMode(
core::Proper
adamdebreceni opened a new pull request #917:
URL: https://github.com/apache/nifi-minifi-cpp/pull/917
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
Adam Debreceni created MINIFICPP-1384:
-
Summary: Fix intdiv_ceil
Key: MINIFICPP-1384
URL: https://issues.apache.org/jira/browse/MINIFICPP-1384
Project: Apache NiFi MiNiFi C++
Issue Type:
Marton Szasz created MINIFICPP-1383:
---
Summary: intdiv_ceil gives incorrect results on negative input
Key: MINIFICPP-1383
URL: https://issues.apache.org/jira/browse/MINIFICPP-1383
Project: Apache NiFi
arpadboda closed pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
adamdebreceni commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r498148335
##
File path: libminifi/include/utils/GeneralUtils.h
##
@@ -43,6 +43,7 @@ using std::make_unique;
template::value>::type>
T intdiv_ceil(T
fgerlits commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498101379
##
File path: main/MiNiFiMain.cpp
##
@@ -208,6 +238,10 @@ int main(int argc, char **argv) {
configure->setHome(minifiHome);
configure->loadCo
adamdebreceni commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r498139911
##
File path: libminifi/include/DiskSpaceWatchdog.h
##
@@ -0,0 +1,60 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under on
lordgamez commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r498129867
##
File path: libminifi/src/utils/file/PathUtils.cpp
##
@@ -84,13 +86,58 @@ std::string PathUtils::getFullPath(const std::string& path)
{
#endif
lordgamez commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r498129745
##
File path: libminifi/include/DiskSpaceWatchdog.h
##
@@ -0,0 +1,60 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or
szaszm commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r498122682
##
File path: libminifi/src/utils/file/PathUtils.cpp
##
@@ -84,13 +86,58 @@ std::string PathUtils::getFullPath(const std::string& path)
{
#endif
}
szaszm commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r498119240
##
File path: libminifi/include/DiskSpaceWatchdog.h
##
@@ -0,0 +1,60 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
arpadboda commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r498111891
##
File path: libminifi/include/properties/Properties.h
##
@@ -82,6 +84,16 @@ class Properties {
*/
int getInt(const std::string &key, int
fgerlits commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498101379
##
File path: main/MiNiFiMain.cpp
##
@@ -208,6 +238,10 @@ int main(int argc, char **argv) {
configure->setHome(minifiHome);
configure->loadCo
adamdebreceni commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498090718
##
File path: main/MiNiFiMain.cpp
##
@@ -208,6 +238,10 @@ int main(int argc, char **argv) {
configure->setHome(minifiHome);
configure->l
adamdebreceni commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498090718
##
File path: main/MiNiFiMain.cpp
##
@@ -208,6 +238,10 @@ int main(int argc, char **argv) {
configure->setHome(minifiHome);
configure->l
lordgamez commented on a change in pull request #875:
URL: https://github.com/apache/nifi-minifi-cpp/pull/875#discussion_r498035883
##
File path: libminifi/include/DiskSpaceWatchdog.h
##
@@ -0,0 +1,60 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or
adamdebreceni commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r498055943
##
File path: libminifi/include/properties/Properties.h
##
@@ -65,6 +67,13 @@ class Properties {
*/
bool get(const std::string &key, st
82 matches
Mail list logo