adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r509027132
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
b
adamdebreceni commented on a change in pull request #928:
URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r509023703
##
File path: extensions/windows-event-log/wel/WindowsEventLog.cpp
##
@@ -43,10 +45,10 @@ void WindowsEventLogMetadataImpl::renderMetadata() {
adamdebreceni commented on a change in pull request #928:
URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r509021609
##
File path: extensions/windows-event-log/wel/WindowsEventLog.cpp
##
@@ -129,34 +133,30 @@ std::string
WindowsEventLogMetadataImpl::getEvent
adamdebreceni commented on a change in pull request #928:
URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r509021203
##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##
@@ -514,30 +515,33 @@ void
ConsumeWindowsEventLog::substituteXMLPerc
markobean commented on pull request #4563:
URL: https://github.com/apache/nifi/pull/4563#issuecomment-713266553
Global Menu > Data Provenance results in a listing of provenance events
which can be filtered as expected, including the "NOT" feature.
However, choosing "View data provenance"
thenatog commented on pull request #4613:
URL: https://github.com/apache/nifi/pull/4613#issuecomment-713261888
This PR now allows the user to configure the TLS properties for ZooKeeper
state provider using the nifi.properties file instead of the
state-management.xml as in the previous PR.
thenatog closed pull request #4592:
URL: https://github.com/apache/nifi/pull/4592
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
thenatog commented on pull request #4592:
URL: https://github.com/apache/nifi/pull/4592#issuecomment-713260476
Sorry, I've opened a fresh PR here: https://github.com/apache/nifi/pull/4613
rebased on Joey's changes. I've incorporated the changes requested above. Let
me know if there's any o
thenatog opened a new pull request #4613:
URL: https://github.com/apache/nifi/pull/4613
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
[
https://issues.apache.org/jira/browse/NIFI-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-7637:
---
Affects Version/s: (was: 1.11.4)
Status: Patch Available (was: In Progress)
> Vali
mattyb149 opened a new pull request #4612:
URL: https://github.com/apache/nifi/pull/4612
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
In isArrayTypeCompatible() we just check to see if t
thenatog commented on a change in pull request #4592:
URL: https://github.com/apache/nifi/pull/4592#discussion_r508875708
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/state/providers/zookeeper/ZooKeepe
[
https://issues.apache.org/jira/browse/NIFI-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217978#comment-17217978
]
Matt Burgess commented on NIFI-7637:
As a note, this may only affect the JsonRecordSet
[
https://issues.apache.org/jira/browse/NIFI-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-7637:
---
Summary: ValidateRecord does not validate primitive datatypes in an array
(was: ValidateRecord does n
[
https://issues.apache.org/jira/browse/NIFI-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-7637:
---
Summary: ValidateRecord does not validate datatypes in an array (was:
ValidateRecord does not validat
[
https://issues.apache.org/jira/browse/NIFI-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217970#comment-17217970
]
Matt Burgess commented on NIFI-7637:
DataTypeUtils.isArrayTypeCompatible() should chec
[
https://issues.apache.org/jira/browse/NIFI-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess reassigned NIFI-7637:
--
Assignee: Matt Burgess
> ValidateRecord does not validate primative datatypes in an array
> ---
adenes opened a new pull request #4611:
URL: https://github.com/apache/nifi/pull/4611
Fix the issue that ValidateRecord marks an avro record invalid if it
contains an array with null element or a map with null value even if the schema
would allow it.
In order to streamline the r
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508708537
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool ope
arpadboda commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508700255
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool
szaszm commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508697986
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool ope
arpadboda commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508692793
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool
arpadboda commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508692793
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
bool
szaszm commented on a change in pull request #928:
URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r508687901
##
File path: extensions/windows-event-log/wel/WindowsEventLog.cpp
##
@@ -129,34 +133,30 @@ std::string
WindowsEventLogMetadataImpl::getEventData(EV
szaszm commented on a change in pull request #928:
URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r508369819
##
File path: extensions/windows-event-log/wel/WindowsEventLog.cpp
##
@@ -129,34 +133,30 @@ std::string
WindowsEventLogMetadataImpl::getEventData(EV
arpadboda closed pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
adenes opened a new pull request #4610:
URL: https://github.com/apache/nifi/pull/4610
…in the CLI
- added the connectionTimeout and readTimeout parameters to
AbstractCommand#createBaseOptions
- added new tests to test if the proper timeout values are passed to the
JAX-RS client i
thenatog commented on pull request #4592:
URL: https://github.com/apache/nifi/pull/4592#issuecomment-712984880
Resolving some conflicts and will update this PR. It will no longer require
extra TLS configuration in the state-management.xml. If
nifi.zookeeper.client.secure=true, it will use
[
https://issues.apache.org/jira/browse/NIFI-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Gough resolved NIFI-7401.
Resolution: Fixed
This part of the work is complete. Some extra work remains in NIFI-7819/PR-4592.
thenatog closed pull request #4250:
URL: https://github.com/apache/nifi/pull/4250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
simonbence commented on a change in pull request #4510:
URL: https://github.com/apache/nifi/pull/4510#discussion_r508661743
##
File path:
nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services/src/main/java/org/apache/nifi/hazelcast/services/cache/IMapBasedHazelcastCache.java
simonbence commented on a change in pull request #4510:
URL: https://github.com/apache/nifi/pull/4510#discussion_r508649677
##
File path:
nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services/src/main/java/org/apache/nifi/hazelcast/services/cachemanager/StandaloneHazelcastCac
[
https://issues.apache.org/jira/browse/NIFI-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217702#comment-17217702
]
ASF subversion and git services commented on NIFI-7401:
---
Commit 55cb
[
https://issues.apache.org/jira/browse/NIFI-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217703#comment-17217703
]
ASF subversion and git services commented on NIFI-7401:
---
Commit 55cb
[
https://issues.apache.org/jira/browse/NIFI-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217705#comment-17217705
]
ASF subversion and git services commented on NIFI-7401:
---
Commit 55cb
[
https://issues.apache.org/jira/browse/NIFI-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217706#comment-17217706
]
ASF subversion and git services commented on NIFI-7401:
---
Commit 55cb
[
https://issues.apache.org/jira/browse/NIFI-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217704#comment-17217704
]
ASF subversion and git services commented on NIFI-7401:
---
Commit 55cb
[
https://issues.apache.org/jira/browse/NIFI-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217701#comment-17217701
]
ASF subversion and git services commented on NIFI-7401:
---
Commit 55cb
thenatog closed pull request #4592:
URL: https://github.com/apache/nifi/pull/4592
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
simonbence commented on a change in pull request #4510:
URL: https://github.com/apache/nifi/pull/4510#discussion_r508617371
##
File path:
nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services/src/main/resources/docs/org.apache.nifi.hazelcast.services.cachemanager.EmbeddedHaze
simonbence commented on a change in pull request #4510:
URL: https://github.com/apache/nifi/pull/4510#discussion_r508595309
##
File path:
nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services/src/main/java/org/apache/nifi/hazelcast/services/util/LongUtil.java
##
@@ -0
mattyb149 commented on pull request #4588:
URL: https://github.com/apache/nifi/pull/4588#issuecomment-712879544
Can you share a use case where this happens? I'm guessing if you have a
validation query that does "too much work" and the DB goes down or something,
maybe the query would timeou
adamdebreceni commented on a change in pull request #920:
URL: https://github.com/apache/nifi-minifi-cpp/pull/920#discussion_r508484578
##
File path: extensions/standard-processors/tests/unit/TailFileTests.cpp
##
@@ -1129,8 +1129,11 @@ TEST_CASE("TailFile finds and finishes the
adamdebreceni commented on a change in pull request #920:
URL: https://github.com/apache/nifi-minifi-cpp/pull/920#discussion_r508473323
##
File path: extensions/standard-processors/processors/TailFile.cpp
##
@@ -497,11 +497,8 @@ bool TailFile::recoverState(const
std::shared_pt
adamdebreceni commented on a change in pull request #920:
URL: https://github.com/apache/nifi-minifi-cpp/pull/920#discussion_r508460189
##
File path: libminifi/include/utils/ThreadPool.h
##
@@ -227,11 +227,10 @@ class ThreadPool {
* Returns true if a task is running.
*/
turcsanyip commented on a change in pull request #4510:
URL: https://github.com/apache/nifi/pull/4510#discussion_r508028622
##
File path:
nifi-nar-bundles/nifi-hazelcast-bundle/nifi-hazelcast-services/src/main/resources/docs/org.apache.nifi.hazelcast.services.cachemanager.EmbeddedHaze
szaszm commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r508418996
##
File path: libminifi/include/properties/Properties.h
##
@@ -65,7 +65,7 @@ class Properties {
* @param value value in which to place the map's
adamdebreceni commented on pull request #928:
URL: https://github.com/apache/nifi-minifi-cpp/pull/928#issuecomment-712732711
with the following setup: CWEL -> LogAttribute, CWEL: {batch commit size:
1000, output format both, 1 sec timer driven}, LogAttribute: {1000 batch size,
event driven
fgerlits commented on a change in pull request #928:
URL: https://github.com/apache/nifi-minifi-cpp/pull/928#discussion_r508332309
##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##
@@ -514,30 +515,33 @@ void
ConsumeWindowsEventLog::substituteXMLPercentag
adamdebreceni opened a new pull request #928:
URL: https://github.com/apache/nifi-minifi-cpp/pull/928
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
adamdebreceni commented on a change in pull request #914:
URL: https://github.com/apache/nifi-minifi-cpp/pull/914#discussion_r508332045
##
File path: encrypt-config/ConfigFileEncryptor.cpp
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one o
Gabor Gyimesi created MINIFICPP-1396:
Summary: Create FetchS3Object processor
Key: MINIFICPP-1396
URL: https://issues.apache.org/jira/browse/MINIFICPP-1396
Project: Apache NiFi MiNiFi C++
[
https://issues.apache.org/jira/browse/MINIFICPP-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Debreceni resolved MINIFICPP-1392.
---
Resolution: Fixed
> Some streams error when writing no data with zero length
> --
adamdebreceni commented on a change in pull request #926:
URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508274717
##
File path: libminifi/include/utils/Id.h
##
@@ -65,10 +67,11 @@ class Identifier {
bool operator!=(const Identifier& other) const;
b
54 matches
Mail list logo