[jira] [Resolved] (NIFI-12514) NiFi on Windows fails to start with Python Extensions Enabled
[ https://issues.apache.org/jira/browse/NIFI-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12514. - Fix Version/s: 2.0.0 Assignee: Bob Paulin Resolution: Fixed > NiFi on Windows fails to start with Python Extensions Enabled > - > > Key: NIFI-12514 > URL: https://issues.apache.org/jira/browse/NIFI-12514 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 2.0.0-M2 > Environment: Hp Zbook 17 G4 i7 1Tb SSD 40GB RAM > Windows 11 > Adoptium jdk-21.0.1+12 > Python(Microsoft) 3.11.7 >Reporter: oyeyemi >Assignee: Bob Paulin >Priority: Major > Fix For: 2.0.0 > > Attachments: nifi-app.log, nifi-bootstrap.log > > Time Spent: 3h 20m > Remaining Estimate: 0h > > I enabled Python Extension for Nifi in nifi.properties file: > *nifi.python.command=python3* > Nifi started and shutdown due to several errors relation to Python. So after > checking the nifi-app.log file i noticed nifi was pointing to this > "controller" path which does not exist: > *Caused by: java.io.IOException: Cannot run program > "C:\nifi_1\nifi-2.0.0-M1-bin\nifi-2.0.0-M1\.\work\python\controller\bin\python": > CreateProcess error=2, The system cannot find the file specified* > The path that exists on Windows has "Scripts" not "bin" > C:\nifi_1\nifi-2.0.0-M1-bin\nifi-2.0.0-M1\.\work\python\controller\Scripts\python" > so when i changed "Scripts" to "bin" i got different error: > java.lang.RuntimeException: Failed to start Python Bridge > Thank you. > Note: Attached are my nifi-app & bootstrap log files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12514) NiFi on Windows fails to start with Python Extensions Enabled
[ https://issues.apache.org/jira/browse/NIFI-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12514: Summary: NiFi on Windows fails to start with Python Extensions Enabled (was: Nifi 2.0.0M1 cannot start after enabling Python Extension) > NiFi on Windows fails to start with Python Extensions Enabled > - > > Key: NIFI-12514 > URL: https://issues.apache.org/jira/browse/NIFI-12514 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 2.0.0-M2 > Environment: Hp Zbook 17 G4 i7 1Tb SSD 40GB RAM > Windows 11 > Adoptium jdk-21.0.1+12 > Python(Microsoft) 3.11.7 >Reporter: oyeyemi >Priority: Major > Attachments: nifi-app.log, nifi-bootstrap.log > > Time Spent: 3h 20m > Remaining Estimate: 0h > > I enabled Python Extension for Nifi in nifi.properties file: > *nifi.python.command=python3* > Nifi started and shutdown due to several errors relation to Python. So after > checking the nifi-app.log file i noticed nifi was pointing to this > "controller" path which does not exist: > *Caused by: java.io.IOException: Cannot run program > "C:\nifi_1\nifi-2.0.0-M1-bin\nifi-2.0.0-M1\.\work\python\controller\bin\python": > CreateProcess error=2, The system cannot find the file specified* > The path that exists on Windows has "Scripts" not "bin" > C:\nifi_1\nifi-2.0.0-M1-bin\nifi-2.0.0-M1\.\work\python\controller\Scripts\python" > so when i changed "Scripts" to "bin" i got different error: > java.lang.RuntimeException: Failed to start Python Bridge > Thank you. > Note: Attached are my nifi-app & bootstrap log files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12514) Nifi 2.0.0M1 cannot start after enabling Python Extension
[ https://issues.apache.org/jira/browse/NIFI-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827639#comment-17827639 ] ASF subversion and git services commented on NIFI-12514: Commit 495a7dd7f5b8cb2e365c25dcf4fbb37884ecdac3 in nifi's branch refs/heads/main from Bob Paulin [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=495a7dd7f5 ] NIFI-12514 Added Windows support for Python venv This closes #8510 Signed-off-by: David Handermann > Nifi 2.0.0M1 cannot start after enabling Python Extension > - > > Key: NIFI-12514 > URL: https://issues.apache.org/jira/browse/NIFI-12514 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 2.0.0-M2 > Environment: Hp Zbook 17 G4 i7 1Tb SSD 40GB RAM > Windows 11 > Adoptium jdk-21.0.1+12 > Python(Microsoft) 3.11.7 >Reporter: oyeyemi >Priority: Major > Attachments: nifi-app.log, nifi-bootstrap.log > > Time Spent: 3h 20m > Remaining Estimate: 0h > > I enabled Python Extension for Nifi in nifi.properties file: > *nifi.python.command=python3* > Nifi started and shutdown due to several errors relation to Python. So after > checking the nifi-app.log file i noticed nifi was pointing to this > "controller" path which does not exist: > *Caused by: java.io.IOException: Cannot run program > "C:\nifi_1\nifi-2.0.0-M1-bin\nifi-2.0.0-M1\.\work\python\controller\bin\python": > CreateProcess error=2, The system cannot find the file specified* > The path that exists on Windows has "Scripts" not "bin" > C:\nifi_1\nifi-2.0.0-M1-bin\nifi-2.0.0-M1\.\work\python\controller\Scripts\python" > so when i changed "Scripts" to "bin" i got different error: > java.lang.RuntimeException: Failed to start Python Bridge > Thank you. > Note: Attached are my nifi-app & bootstrap log files. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
exceptionfactory closed pull request #8510: NIFI-12514: Add windows support for python venv URL: https://github.com/apache/nifi/pull/8510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12912) BUG - snackbar theming
[ https://issues.apache.org/jira/browse/NIFI-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Elliott reassigned NIFI-12912: Assignee: James Elliott > BUG - snackbar theming > -- > > Key: NIFI-12912 > URL: https://issues.apache.org/jira/browse/NIFI-12912 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: James Elliott >Priority: Major > > The snackbar theme seems to have some regressions since the update to using > semantic colors. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12911) Upgrade Jagged to 0.3.2
[ https://issues.apache.org/jira/browse/NIFI-12911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12911: Fix Version/s: 2.0.0 1.26.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Jagged to 0.3.2 > --- > > Key: NIFI-12911 > URL: https://issues.apache.org/jira/browse/NIFI-12911 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Fix For: 2.0.0, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Jagged [0.3.2|https://github.com/exceptionfactory/jagged/releases/tag/0.3.2] > for the EncryptContentAge and DecryptContentAge Processors includes minor bug > fixes related to stream closure handling. > This upgrade should be applied to both the main and support branches. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12911) Upgrade Jagged to 0.3.2
[ https://issues.apache.org/jira/browse/NIFI-12911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827609#comment-17827609 ] ASF subversion and git services commented on NIFI-12911: Commit 06e452742b82364def9be816efde7cc026bf7f41 in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=06e452742b ] NIFI-12911 Upgraded Jagged from 0.3.0 to 0.3.2 > Upgrade Jagged to 0.3.2 > --- > > Key: NIFI-12911 > URL: https://issues.apache.org/jira/browse/NIFI-12911 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 20m > Remaining Estimate: 0h > > Jagged [0.3.2|https://github.com/exceptionfactory/jagged/releases/tag/0.3.2] > for the EncryptContentAge and DecryptContentAge Processors includes minor bug > fixes related to stream closure handling. > This upgrade should be applied to both the main and support branches. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12911) Upgrade Jagged to 0.3.2
[ https://issues.apache.org/jira/browse/NIFI-12911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827608#comment-17827608 ] ASF subversion and git services commented on NIFI-12911: Commit d62c8054d016bbbd96b949e804fa471c6b24d274 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d62c8054d0 ] NIFI-12911 Upgraded Jagged from 0.3.0 to 0.3.2 This closes #8522. Signed-off-by: Joseph Witt > Upgrade Jagged to 0.3.2 > --- > > Key: NIFI-12911 > URL: https://issues.apache.org/jira/browse/NIFI-12911 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > Jagged [0.3.2|https://github.com/exceptionfactory/jagged/releases/tag/0.3.2] > for the EncryptContentAge and DecryptContentAge Processors includes minor bug > fixes related to stream closure handling. > This upgrade should be applied to both the main and support branches. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12911 Upgrade Jagged from 0.3.0 to 0.3.2 [nifi]
asfgit closed pull request #8522: NIFI-12911 Upgrade Jagged from 0.3.0 to 0.3.2 URL: https://github.com/apache/nifi/pull/8522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12912) BUG - snackbar theming
Scott Aslan created NIFI-12912: -- Summary: BUG - snackbar theming Key: NIFI-12912 URL: https://issues.apache.org/jira/browse/NIFI-12912 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan The snackbar theme seems to have some regressions since the update to using semantic colors. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12910) Upgrade Spring Framework to 6.0.18
[ https://issues.apache.org/jira/browse/NIFI-12910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-12910: Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Spring Framework to 6.0.18 > -- > > Key: NIFI-12910 > URL: https://issues.apache.org/jira/browse/NIFI-12910 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 2.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Spring Framework dependencies should be upgraded to > [6.0.18|https://github.com/spring-projects/spring-framework/releases/tag/v6.0.18] > for NiFi. > Spring Framework dependencies for NiFi Registry should be upgraded to > [6.1.5.|https://github.com/spring-projects/spring-framework/releases/tag/v6.1.5] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12910) Upgrade Spring Framework to 6.0.18
[ https://issues.apache.org/jira/browse/NIFI-12910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827605#comment-17827605 ] ASF subversion and git services commented on NIFI-12910: Commit 82ea7a284c164ab1de4fecdc41209018a3c208c7 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=82ea7a284c ] NIFI-12910 Upgraded Spring Framework from 6.0.17 to 6.0.18 This closes #8520. - Upgraded Spring Boot from 3.2.2 to 3.2.3 for Registry - Upgraded Spring Framework from 6.1.4 to 6.1.5 for Registry Signed-off-by: Joseph Witt > Upgrade Spring Framework to 6.0.18 > -- > > Key: NIFI-12910 > URL: https://issues.apache.org/jira/browse/NIFI-12910 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Spring Framework dependencies should be upgraded to > [6.0.18|https://github.com/spring-projects/spring-framework/releases/tag/v6.0.18] > for NiFi. > Spring Framework dependencies for NiFi Registry should be upgraded to > [6.1.5.|https://github.com/spring-projects/spring-framework/releases/tag/v6.1.5] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12910 Upgrade Spring Framework from 6.0.17 to 6.0.18 [nifi]
asfgit closed pull request #8520: NIFI-12910 Upgrade Spring Framework from 6.0.17 to 6.0.18 URL: https://github.com/apache/nifi/pull/8520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12911) Upgrade Jagged to 0.3.2
[ https://issues.apache.org/jira/browse/NIFI-12911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12911: Status: Patch Available (was: Open) > Upgrade Jagged to 0.3.2 > --- > > Key: NIFI-12911 > URL: https://issues.apache.org/jira/browse/NIFI-12911 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > Jagged [0.3.2|https://github.com/exceptionfactory/jagged/releases/tag/0.3.2] > for the EncryptContentAge and DecryptContentAge Processors includes minor bug > fixes related to stream closure handling. > This upgrade should be applied to both the main and support branches. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12911 Upgrade Jagged from 0.3.0 to 0.3.2 [nifi]
exceptionfactory opened a new pull request, #8522: URL: https://github.com/apache/nifi/pull/8522 # Summary [NIFI-12911](https://issues.apache.org/jira/browse/NIFI-12911) Upgrades Jagged dependencies for `EncryptContentAge` and `DecryptContentAge` from 0.3.0 to [0.3.2](https://github.com/exceptionfactory/jagged/releases/tag/0.3.2) to resolve issues with stream closure handling. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12902: Updating packaging to account for new build output [nifi]
mcgilman opened a new pull request, #8521: URL: https://github.com/apache/nifi/pull/8521 NIFI-12902: - Updating packaging to account for new build output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12910) Upgrade Spring Framework to 6.0.18
[ https://issues.apache.org/jira/browse/NIFI-12910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12910: Status: Patch Available (was: Open) > Upgrade Spring Framework to 6.0.18 > -- > > Key: NIFI-12910 > URL: https://issues.apache.org/jira/browse/NIFI-12910 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Spring Framework dependencies should be upgraded to > [6.0.18|https://github.com/spring-projects/spring-framework/releases/tag/v6.0.18] > for NiFi. > Spring Framework dependencies for NiFi Registry should be upgraded to > [6.1.5.|https://github.com/spring-projects/spring-framework/releases/tag/v6.1.5] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12911) Upgrade Jagged to 0.3.2
David Handermann created NIFI-12911: --- Summary: Upgrade Jagged to 0.3.2 Key: NIFI-12911 URL: https://issues.apache.org/jira/browse/NIFI-12911 Project: Apache NiFi Issue Type: Improvement Reporter: David Handermann Assignee: David Handermann Jagged [0.3.2|https://github.com/exceptionfactory/jagged/releases/tag/0.3.2] for the EncryptContentAge and DecryptContentAge Processors includes minor bug fixes related to stream closure handling. This upgrade should be applied to both the main and support branches. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12910 Upgrade Spring Framework from 6.0.17 to 6.0.18 [nifi]
joewitt commented on PR #8520: URL: https://github.com/apache/nifi/pull/8520#issuecomment-2000431077 i'll build locallly and verify and if clean will +1 and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12910 Upgrade Spring Framework from 6.0.17 to 6.0.18 [nifi]
exceptionfactory opened a new pull request, #8520: URL: https://github.com/apache/nifi/pull/8520 # Summary [NIFI-12910](https://issues.apache.org/jira/browse/NIFI-12910) Upgrades Spring Framework dependencies from 6.0.17 to [6.0.18](https://github.com/spring-projects/spring-framework/releases/tag/v6.0.18) and also upgrade Spring Boot for Registry from 3.2.2 to [3.2.3](https://github.com/spring-projects/spring-boot/releases/tag/v3.2.3). # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12910) Upgrade Spring Framework to 6.0.18
David Handermann created NIFI-12910: --- Summary: Upgrade Spring Framework to 6.0.18 Key: NIFI-12910 URL: https://issues.apache.org/jira/browse/NIFI-12910 Project: Apache NiFi Issue Type: Improvement Components: Core Framework, NiFi Registry Reporter: David Handermann Assignee: David Handermann Spring Framework dependencies should be upgraded to [6.0.18|https://github.com/spring-projects/spring-framework/releases/tag/v6.0.18] for NiFi. Spring Framework dependencies for NiFi Registry should be upgraded to [6.1.5.|https://github.com/spring-projects/spring-framework/releases/tag/v6.1.5] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12909) Upgrade Nimbus JOSE+JWT to 9.37.3
[ https://issues.apache.org/jira/browse/NIFI-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12909: Fix Version/s: 2.0.0 1.26.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Nimbus JOSE+JWT to 9.37.3 > - > > Key: NIFI-12909 > URL: https://issues.apache.org/jira/browse/NIFI-12909 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > Fix For: 2.0.0, 1.26.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Upgrade Nimbus JOSE+JWT to 9.37.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12909) Upgrade Nimbus JOSE+JWT to 9.37.3
[ https://issues.apache.org/jira/browse/NIFI-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12909: Summary: Upgrade Nimbus JOSE+JWT to 9.37.3 (was: Upgrade Nimbus JOSE+JWT) > Upgrade Nimbus JOSE+JWT to 9.37.3 > - > > Key: NIFI-12909 > URL: https://issues.apache.org/jira/browse/NIFI-12909 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > Time Spent: 1h > Remaining Estimate: 0h > > Upgrade Nimbus JOSE+JWT to 9.37.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12909 - Upgrade Nimbus JOSE+JWT to 9.37.3 - support/1.x [nifi]
exceptionfactory commented on PR #8519: URL: https://github.com/apache/nifi/pull/8519#issuecomment-2000418141 Merged in https://github.com/apache/nifi/commit/e48a8b5d4e8bfcedb3450f663160a1f5183a1a3d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12909 - Upgrade Nimbus JOSE+JWT to 9.37.3 - support/1.x [nifi]
exceptionfactory closed pull request #8519: NIFI-12909 - Upgrade Nimbus JOSE+JWT to 9.37.3 - support/1.x URL: https://github.com/apache/nifi/pull/8519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12909) Upgrade Nimbus JOSE+JWT
[ https://issues.apache.org/jira/browse/NIFI-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827602#comment-17827602 ] ASF subversion and git services commented on NIFI-12909: Commit e48a8b5d4e8bfcedb3450f663160a1f5183a1a3d in nifi's branch refs/heads/support/nifi-1.x from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e48a8b5d4e ] NIFI-12909 Upgraded Nimbus JOSE+JWT from 9.33.0 to 9.37.3 This closes #8519 Signed-off-by: David Handermann > Upgrade Nimbus JOSE+JWT > --- > > Key: NIFI-12909 > URL: https://issues.apache.org/jira/browse/NIFI-12909 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > Time Spent: 40m > Remaining Estimate: 0h > > Upgrade Nimbus JOSE+JWT to 9.37.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12909) Upgrade Nimbus JOSE+JWT
[ https://issues.apache.org/jira/browse/NIFI-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827600#comment-17827600 ] ASF subversion and git services commented on NIFI-12909: Commit 82e11df8352f94c6450d19d37858d005f22269db in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=82e11df835 ] NIFI-12909 Upgraded Nimbus JOSE+JWT from 9.33.0 to 9.37.3 This closes #8518 Signed-off-by: David Handermann > Upgrade Nimbus JOSE+JWT > --- > > Key: NIFI-12909 > URL: https://issues.apache.org/jira/browse/NIFI-12909 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > Time Spent: 40m > Remaining Estimate: 0h > > Upgrade Nimbus JOSE+JWT to 9.37.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12909 - Upgrade Nimbus JOSE+JWT to 9.37.3 [nifi]
exceptionfactory closed pull request #8518: NIFI-12909 - Upgrade Nimbus JOSE+JWT to 9.37.3 URL: https://github.com/apache/nifi/pull/8518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12900 Avoid unnecessary file listing in PutSFTP [nifi]
EndzeitBegins commented on code in PR #8503:
URL: https://github.com/apache/nifi/pull/8503#discussion_r1526790739
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -110,6 +110,16 @@ private static String
convertFactorySetToString(Set factorySetNames) {
.collect(Collectors.joining(", "));
}
+private static String buildFullPath(String path, String filename) {
+if (path == null) return filename;
+if (path.endsWith("/")) return path + filename;
+return path + "/" + filename;
Review Comment:
Yeah, I guess that's a matter of preference.
Personally I feel leaving the brackets out is less verbose and more readable.
But I'm working with `Kotlin` mostly, so I'm used to a more consice syntax I
guess.
I'm fine with both either way, so I applied your suggestion.
Thanks once more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12900 Avoid unnecessary file listing in PutSFTP [nifi]
EndzeitBegins commented on code in PR #8503:
URL: https://github.com/apache/nifi/pull/8503#discussion_r1526790739
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -110,6 +110,16 @@ private static String
convertFactorySetToString(Set factorySetNames) {
.collect(Collectors.joining(", "));
}
+private static String buildFullPath(String path, String filename) {
+if (path == null) return filename;
+if (path.endsWith("/")) return path + filename;
+return path + "/" + filename;
Review Comment:
Yeah, I guess that's a matter of preference.
Personally I feel leaving the brackets out is less verbose and more readable.
But I'm working with `Kotlin` mostly, so I'm used to a more consice syntax I
guess.
I'm fine with both either way, so I applied your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12900 Avoid unnecessary file listing in PutSFTP [nifi]
EndzeitBegins commented on code in PR #8503:
URL: https://github.com/apache/nifi/pull/8503#discussion_r1526790739
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -110,6 +110,16 @@ private static String
convertFactorySetToString(Set factorySetNames) {
.collect(Collectors.joining(", "));
}
+private static String buildFullPath(String path, String filename) {
+if (path == null) return filename;
+if (path.endsWith("/")) return path + filename;
+return path + "/" + filename;
Review Comment:
Yeah, I guess that's a matter of preference.
Personally I feel eaving the brackets out is less verbose and more readable.
But I'm working with `Kotlin` mostly, so I'm used to a more consice syntax I
guess.
I'm fine with both either way, so I applied your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12902) Migrate to @angular-devkit/build-angular:application
[ https://issues.apache.org/jira/browse/NIFI-12902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827597#comment-17827597 ] ASF subversion and git services commented on NIFI-12902: Commit d97c7946967ea57602b48b96d7e6312834bacf2e in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d97c794696 ] NIFI-12902: Migrating to @angular-devkit/build-angular:application (#8507) * NIFI-12902: - Migrating to @angular-devkit/build-angular:application to avoid and avoid sporadic webpack build issues. - Updating roboto dependencies. * NIFI-12902: - Clean up. This closes #8507 > Migrate to @angular-devkit/build-angular:application > > > Key: NIFI-12902 > URL: https://issues.apache.org/jira/browse/NIFI-12902 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Migrate to the latest builder to try avoid sporadic webpack build issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12902: Migrating to @angular-devkit/build-angular:application [nifi]
rfellows merged PR #8507: URL: https://github.com/apache/nifi/pull/8507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]
mcgilman commented on code in PR #8273:
URL: https://github.com/apache/nifi/pull/8273#discussion_r1526743150
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js:
##
@@ -400,6 +407,602 @@
}
}
+/**
+ * The flow analysis controller.
+ */
+
+this.flowAnalysis = {
+
+/**
+ * Create the list of rule violations
+ */
+buildRuleViolationsList: function(rules, violationsAndRecs) {
+var ruleViolationCountEl = $('#rule-violation-count');
+var ruleViolationListEl = $('#rule-violations-list');
+var ruleWarningCountEl = $('#rule-warning-count');
+var ruleWarningListEl = $('#rule-warnings-list');
+var violations = violationsAndRecs.filter(function
(violation) {
+return violation.enforcementPolicy === 'ENFORCE'
+});
+var warnings = violationsAndRecs.filter(function
(violation) {
+return violation.enforcementPolicy === 'WARN'
+});
+ruleViolationCountEl.empty().text('(' + violations.length
+ ')');
+ruleWarningCountEl.empty().text('(' + warnings.length +
')');
+ruleViolationListEl.empty();
+ruleWarningListEl.empty();
+violations.forEach(function(violation) {
+var rule = rules.find(function(rule) {
+return rule.id === violation.ruleId;
+});
+// create DOM elements
+var violationListItemEl = $('');
+var violationEl = $('');
+var violationListItemWrapperEl = $('');
+var violationRuleEl = $('');
+var violationListItemNameEl = $('');
+var violationListItemIdEl = $('');
+var violationInfoButtonEl = $('');
+
+// add text content and button data
+$(violationRuleEl).text(rule.name);
+violation.subjectPermissionDto.canRead ?
$(violationListItemNameEl).text(violation.subjectDisplayName) :
$(violationListItemNameEl).text('Unauthorized').addClass('unauthorized');
+$(violationListItemIdEl).text(violation.subjectId);
+
$(violationListItemEl).append(violationRuleEl).append(violationListItemWrapperEl);
+$(violationInfoButtonEl).data('violationInfo',
violation);
+
+// build list DOM structure
+
violationListItemWrapperEl.append(violationListItemNameEl).append(violationListItemIdEl);
+
violationEl.append(violationListItemWrapperEl).append(violationInfoButtonEl);
+
violationListItemEl.append(violationRuleEl).append(violationEl)
+ruleViolationListEl.append(violationListItemEl);
+});
+
+warnings.forEach(function(warning) {
+var rule = rules.find(function(rule) {
+return rule.id === warning.ruleId;
+});
+// create DOM elements
+var warningListItemEl = $('');
+var warningEl = $('');
+var warningListItemWrapperEl = $('');
+var warningRuleEl = $('');
+var warningListItemNameEl = $('');
+var warningListItemIdEl = $('');
+var warningInfoButtonEl = $('');
+
+// add text content and button data
+$(warningRuleEl).text(rule.name);
+warning.subjectPermissionDto.canRead ?
$(warningListItemNameEl).text(warning.subjectDisplayName) :
$(warningListItemNameEl).text('Unauthorized').addClass('unauthorized');
+$(warningListItemIdEl).text(warning.subjectId);
+
$(warningListItemEl).append(warningRuleEl).append(warningListItemWrapperEl);
+$(warningInfoButtonEl).data('violationInfo', warning);
+
+// build list DOM structure
+
warningListItemWrapperEl.append(warningListItemNameEl).append(warningListItemIdEl);
+
warningEl.append(warningListItemWrapperEl).append(warningInfoButtonEl);
+
warningListItemEl.append(warningRuleEl).append(warningEl)
+ruleWarningListEl.append(warningListItemEl);
+});
+
Re: [PR] NIFI-12900 Avoid unnecessary file listing in PutSFTP [nifi]
dan-s1 commented on code in PR #8503:
URL: https://github.com/apache/nifi/pull/8503#discussion_r1526778589
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -110,6 +110,16 @@ private static String
convertFactorySetToString(Set factorySetNames) {
.collect(Collectors.joining(", "));
}
+private static String buildFullPath(String path, String filename) {
+if (path == null) return filename;
+if (path.endsWith("/")) return path + filename;
+return path + "/" + filename;
Review Comment:
While this code is valid I have noticed in the NIFI code the importance for
readability, I would suggest expanding to the code below or what I originally
suggested using `else if` and `else`
```suggestion
if (path == null) {
return filename;
}
if (path.endsWith("/")) {
return path + filename;
}
return path + "/" + filename;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12889: Retry Kerberos login on auth failure in HDFS processors [nifi]
mattyb149 commented on code in PR #8495:
URL: https://github.com/apache/nifi/pull/8495#discussion_r1526776640
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java:
##
@@ -372,54 +370,56 @@ public Object run() {
// Write FlowFile to temp file on HDFS
final StopWatch stopWatch = new StopWatch(true);
-session.read(putFlowFile, new InputStreamCallback() {
-
-@Override
-public void process(InputStream in) throws IOException
{
-OutputStream fos = null;
-Path createdFile = null;
-try {
-if (conflictResponse.equals(APPEND_RESOLUTION)
&& destinationExists) {
-fos = hdfs.append(copyFile, bufferSize);
-} else {
-final EnumSet cflags =
EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE);
-
-if (shouldIgnoreLocality(context,
session)) {
-
cflags.add(CreateFlag.IGNORE_CLIENT_LOCALITY);
-}
+session.read(putFlowFile, in -> {
+OutputStream fos = null;
+Path createdFile = null;
+try {
+if (conflictResponse.equals(APPEND_RESOLUTION) &&
destinationExists) {
+fos = hdfs.append(copyFile, bufferSize);
+} else {
+final EnumSet cflags =
EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE);
-fos = hdfs.create(actualCopyFile,
FsCreateModes.applyUMask(FsPermission.getFileDefault(),
-
FsPermission.getUMask(hdfs.getConf())), cflags, bufferSize, replication,
blockSize,
-null, null);
+if (shouldIgnoreLocality(context, session)) {
+
cflags.add(CreateFlag.IGNORE_CLIENT_LOCALITY);
}
-if (codec != null) {
-fos = codec.createOutputStream(fos);
+fos = hdfs.create(actualCopyFile,
FsCreateModes.applyUMask(FsPermission.getFileDefault(),
+
FsPermission.getUMask(hdfs.getConf())), cflags, bufferSize, replication,
blockSize,
+null, null);
+}
+
+if (codec != null) {
+fos = codec.createOutputStream(fos);
+}
+createdFile = actualCopyFile;
+BufferedInputStream bis = new
BufferedInputStream(in);
+StreamUtils.copy(bis, fos);
+bis = null;
+fos.flush();
+} catch (IOException e) {
+// Catch GSSExceptions and reset the resources
+Optional causeOptional =
findCause(e, GSSException.class, gsse -> GSSException.NO_CRED ==
gsse.getMajor());
+if (causeOptional.isPresent()) {
+getLogger().warn("Error authenticating when
performing file operation, resetting HDFS resources: {} ",
e.getCause().getMessage());
Review Comment:
Yeah same thing as above, I can add the exception regardless (I think) and
change the logging level to error if the user needs to be alerted immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12889: Retry Kerberos login on auth failure in HDFS processors [nifi]
mattyb149 commented on code in PR #8495:
URL: https://github.com/apache/nifi/pull/8495#discussion_r1526776640
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java:
##
@@ -372,54 +370,56 @@ public Object run() {
// Write FlowFile to temp file on HDFS
final StopWatch stopWatch = new StopWatch(true);
-session.read(putFlowFile, new InputStreamCallback() {
-
-@Override
-public void process(InputStream in) throws IOException
{
-OutputStream fos = null;
-Path createdFile = null;
-try {
-if (conflictResponse.equals(APPEND_RESOLUTION)
&& destinationExists) {
-fos = hdfs.append(copyFile, bufferSize);
-} else {
-final EnumSet cflags =
EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE);
-
-if (shouldIgnoreLocality(context,
session)) {
-
cflags.add(CreateFlag.IGNORE_CLIENT_LOCALITY);
-}
+session.read(putFlowFile, in -> {
+OutputStream fos = null;
+Path createdFile = null;
+try {
+if (conflictResponse.equals(APPEND_RESOLUTION) &&
destinationExists) {
+fos = hdfs.append(copyFile, bufferSize);
+} else {
+final EnumSet cflags =
EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE);
-fos = hdfs.create(actualCopyFile,
FsCreateModes.applyUMask(FsPermission.getFileDefault(),
-
FsPermission.getUMask(hdfs.getConf())), cflags, bufferSize, replication,
blockSize,
-null, null);
+if (shouldIgnoreLocality(context, session)) {
+
cflags.add(CreateFlag.IGNORE_CLIENT_LOCALITY);
}
-if (codec != null) {
-fos = codec.createOutputStream(fos);
+fos = hdfs.create(actualCopyFile,
FsCreateModes.applyUMask(FsPermission.getFileDefault(),
+
FsPermission.getUMask(hdfs.getConf())), cflags, bufferSize, replication,
blockSize,
+null, null);
+}
+
+if (codec != null) {
+fos = codec.createOutputStream(fos);
+}
+createdFile = actualCopyFile;
+BufferedInputStream bis = new
BufferedInputStream(in);
+StreamUtils.copy(bis, fos);
+bis = null;
+fos.flush();
+} catch (IOException e) {
+// Catch GSSExceptions and reset the resources
+Optional causeOptional =
findCause(e, GSSException.class, gsse -> GSSException.NO_CRED ==
gsse.getMajor());
+if (causeOptional.isPresent()) {
+getLogger().warn("Error authenticating when
performing file operation, resetting HDFS resources: {} ",
e.getCause().getMessage());
Review Comment:
Yeah same thing as above, I can add the error regardless (I think) and
change it to error if the user needs to be alerted immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12889: Retry Kerberos login on auth failure in HDFS processors [nifi]
mattyb149 commented on code in PR #8495:
URL: https://github.com/apache/nifi/pull/8495#discussion_r1526775762
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java:
##
@@ -372,54 +370,56 @@ public Object run() {
// Write FlowFile to temp file on HDFS
final StopWatch stopWatch = new StopWatch(true);
-session.read(putFlowFile, new InputStreamCallback() {
-
-@Override
-public void process(InputStream in) throws IOException
{
-OutputStream fos = null;
-Path createdFile = null;
-try {
-if (conflictResponse.equals(APPEND_RESOLUTION)
&& destinationExists) {
-fos = hdfs.append(copyFile, bufferSize);
-} else {
-final EnumSet cflags =
EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE);
-
-if (shouldIgnoreLocality(context,
session)) {
-
cflags.add(CreateFlag.IGNORE_CLIENT_LOCALITY);
-}
+session.read(putFlowFile, in -> {
+OutputStream fos = null;
+Path createdFile = null;
+try {
+if (conflictResponse.equals(APPEND_RESOLUTION) &&
destinationExists) {
+fos = hdfs.append(copyFile, bufferSize);
+} else {
+final EnumSet cflags =
EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE);
-fos = hdfs.create(actualCopyFile,
FsCreateModes.applyUMask(FsPermission.getFileDefault(),
-
FsPermission.getUMask(hdfs.getConf())), cflags, bufferSize, replication,
blockSize,
-null, null);
+if (shouldIgnoreLocality(context, session)) {
+
cflags.add(CreateFlag.IGNORE_CLIENT_LOCALITY);
}
-if (codec != null) {
-fos = codec.createOutputStream(fos);
+fos = hdfs.create(actualCopyFile,
FsCreateModes.applyUMask(FsPermission.getFileDefault(),
+
FsPermission.getUMask(hdfs.getConf())), cflags, bufferSize, replication,
blockSize,
+null, null);
+}
+
+if (codec != null) {
+fos = codec.createOutputStream(fos);
+}
+createdFile = actualCopyFile;
+BufferedInputStream bis = new
BufferedInputStream(in);
+StreamUtils.copy(bis, fos);
+bis = null;
+fos.flush();
+} catch (IOException e) {
+// Catch GSSExceptions and reset the resources
+Optional causeOptional =
findCause(e, GSSException.class, gsse -> GSSException.NO_CRED ==
gsse.getMajor());
+if (causeOptional.isPresent()) {
+getLogger().warn("Error authenticating when
performing file operation, resetting HDFS resources: {} ",
e.getCause().getMessage());
Review Comment:
The intent with WARN was not to generate a bulletin by default but I'm fine
either way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12855: Add more information to provenance events to facilitate full graph traversal [nifi]
mattyb149 commented on PR #8498: URL: https://github.com/apache/nifi/pull/8498#issuecomment-2000353866 The graph client stuff has been removed, I'll do a separate PR but not yet in case the reviews here affect the clients. Once this is in it will facilitate more clients such as perhaps an RDF/SPARQL client. Thanks for the inputs! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12900 Avoid unnecessary file listing in PutSFTP [nifi]
EndzeitBegins commented on PR #8503: URL: https://github.com/apache/nifi/pull/8503#issuecomment-2000341357 Thank you for your review @dan-s1. I've pushed another commit based on your suggestions. I'd appreciate if you'd take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12900 Avoid unnecessary file listing in PutSFTP [nifi]
EndzeitBegins commented on code in PR #8503:
URL: https://github.com/apache/nifi/pull/8503#discussion_r1526759912
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -110,6 +110,14 @@ private static String
convertFactorySetToString(Set factorySetNames) {
.collect(Collectors.joining(", "));
}
+private static String buildFullPath(String path, String filename) {
+return (path == null) ? filename : (path.endsWith("/")) ? path +
filename : path + "/" + filename;
+}
Review Comment:
Thank you for the review.
Yes, I thought about that myself, but figured I keep the changes to a
minimum.
However, I think you're right that this should be refactored. I replaced it
with an if statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]
mcgilman commented on code in PR #8273:
URL: https://github.com/apache/nifi/pull/8273#discussion_r1526709847
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js:
##
@@ -400,6 +406,556 @@
}
}
+/**
+ * The flow analysis controller.
+ */
+
+this.flowAnalysis = {
+
+/**
+ * Create the list of rule violations
+ */
+buildRuleViolationsList: function(rules, violationsAndRecs) {
+var ruleViolationCountEl = $('#rule-violation-count');
+var ruleViolationListEl = $('#rule-violations-list');
+var ruleWarningCountEl = $('#rule-warning-count');
+var ruleWarningListEl = $('#rule-warnings-list');
+var violations = violationsAndRecs.filter(function
(violation) {
+return violation.enforcementPolicy === 'ENFORCE'
+});
+var warnings = violationsAndRecs.filter(function
(violation) {
+return violation.enforcementPolicy === 'WARN'
+});
+ruleViolationCountEl.empty().text('(' + violations.length
+ ')');
+ruleWarningCountEl.empty().text('(' + warnings.length +
')');
+ruleViolationListEl.empty();
+violations.forEach(function(violation) {
+var rule = rules.find(function(rule) {
+return rule.id === violation.ruleId;
+});
+// create DOM elements
+var violationListItemEl = $('');
+var violationEl = $('');
+var violationListItemWrapperEl = $('');
+var violationRuleEl = $('');
+var violationListItemNameEl = $('');
+var violationListItemIdEl = $('');
+var violationInfoButtonEl = $('');
+
+// add text content and button data
+$(violationRuleEl).text(rule.name);
+
$(violationListItemNameEl).text(violation.subjectDisplayName);
Review Comment:
@tpalfy Typically we would just report it as unauthorized and clear out
component details. Please see the Controller Service references, Parameter
references, Parameter Provider references, etc for examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12889: Retry Kerberos login on auth failure in HDFS processors [nifi]
mattyb149 commented on code in PR #8495:
URL: https://github.com/apache/nifi/pull/8495#discussion_r1526688710
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java:
##
@@ -372,54 +370,56 @@ public Object run() {
// Write FlowFile to temp file on HDFS
final StopWatch stopWatch = new StopWatch(true);
-session.read(putFlowFile, new InputStreamCallback() {
-
-@Override
-public void process(InputStream in) throws IOException
{
-OutputStream fos = null;
-Path createdFile = null;
-try {
-if (conflictResponse.equals(APPEND_RESOLUTION)
&& destinationExists) {
-fos = hdfs.append(copyFile, bufferSize);
-} else {
-final EnumSet cflags =
EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE);
-
-if (shouldIgnoreLocality(context,
session)) {
-
cflags.add(CreateFlag.IGNORE_CLIENT_LOCALITY);
-}
+session.read(putFlowFile, in -> {
+OutputStream fos = null;
+Path createdFile = null;
+try {
+if (conflictResponse.equals(APPEND_RESOLUTION) &&
destinationExists) {
+fos = hdfs.append(copyFile, bufferSize);
+} else {
+final EnumSet cflags =
EnumSet.of(CreateFlag.CREATE, CreateFlag.OVERWRITE);
-fos = hdfs.create(actualCopyFile,
FsCreateModes.applyUMask(FsPermission.getFileDefault(),
-
FsPermission.getUMask(hdfs.getConf())), cflags, bufferSize, replication,
blockSize,
-null, null);
+if (shouldIgnoreLocality(context, session)) {
+
cflags.add(CreateFlag.IGNORE_CLIENT_LOCALITY);
}
-if (codec != null) {
-fos = codec.createOutputStream(fos);
+fos = hdfs.create(actualCopyFile,
FsCreateModes.applyUMask(FsPermission.getFileDefault(),
+
FsPermission.getUMask(hdfs.getConf())), cflags, bufferSize, replication,
blockSize,
+null, null);
+}
+
+if (codec != null) {
+fos = codec.createOutputStream(fos);
+}
+createdFile = actualCopyFile;
+BufferedInputStream bis = new
BufferedInputStream(in);
+StreamUtils.copy(bis, fos);
+bis = null;
+fos.flush();
+} catch (IOException e) {
Review Comment:
Works for me, the key was to not have it blow up for a "simple" relogin
error. I thought I'd found that depending on the config the first create()
could cause the login error. If anything but a "Kerberos relogin error" occurs,
I think we should rightfully propagate the exception, I can throw it as a
ProcessException inside the read(). What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12885 Add convenience method to `Record` to parse DateTime objects [nifi]
exceptionfactory commented on PR #8502: URL: https://github.com/apache/nifi/pull/8502#issuecomment-290444 > > It may be helpful to scope down the number of timestamps in the provideTimestamps method to focus on differences. > > @exceptionfactory Okay. I scoped it down to 2 formats: `ISO_LOCAL_DATE_TIME` and `ISO_OFFSET_DATE_TIME` and I limited the offset to `+00:00`. Because there were parsing failures previously, I think it's indicative of some race conditions we're not covering, which is out of scope for this change. Given that best practice is ISO format and UTC+0 for most db's anyway, I think we should be fine. Thanks for making the updates, unfortunately the tests are still failing: ``` Error: org.apache.nifi.serialization.record.TestMapRecord.testGettingLocalDateAndOffsetDateTime(Object, String, long, long)[1] -- Time elapsed: 0.031 s <<< FAILURE! org.opentest4j.AssertionFailedError: expected: <1641040496789> but was: <1641072896789> ``` The problem is not a race condition, but the fact of the different GitHub Runners have different local time zones. Converting between UTC and local time changes the expected epoch values, so the expectations need to be written such that they work across all time zones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12885 Add convenience method to `Record` to parse DateTime objects [nifi]
knguyen1 commented on PR #8502: URL: https://github.com/apache/nifi/pull/8502#issuecomment-255062 > It may be helpful to scope down the number of timestamps in the provideTimestamps method to focus on differences. @exceptionfactory Okay. I scoped it down to 2 formats: `ISO_LOCAL_DATE_TIME` and `ISO_OFFSET_DATE_TIME` and I limited the offset to `+00:00`. Because there were parsing failures previously, I think it's indicative of some race conditions we're not covering, which is out of scope for this change. Given that best practice is ISO format and UTC+0 for most db's anyway, I think we should be fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12908 provide powershell versions of the nifi-env.cmd and nifi.cmd [nifi]
phreed commented on PR #8509: URL: https://github.com/apache/nifi/pull/8509#issuecomment-238845 > Can you provide some additional background on the reason for introducing a PowerShell alternative to the `nifi.cmd` script for Windows? It would be ideal to maintain a unified approach for Windows, as opposed to maintaining two separate scripts for the same OS. I am just starting out with NiFi, so I will have to speak in generalities. Making changes to *.cmd/*.bat files is fraught. Every time I think I am going to make a small change to one it ends up being a time sink. I am planning on extensively using NiFi for a project I am working on. A lot of the work will involve dynamic deployment of NiFi components on a dynamic cluster. I anticipate building tooling to support this work. I would much prefer to use powershell over CMD/BAT. I plan on contributing this tooling back to Apache. It may be that the tooling would be better written in one of the JVM scripting languages (i.e. Groovy, Kotlin, Clojure). That said I expect that some of the tooling would still best be written as powershell modules on Windows. Obviously, the `nifi.ps1` is not (yet) a powershell module, I am getting a feel for how the NiFi project operates. I would like to see the `nifi.cmd` deprecated in favor of powershell modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-11259) Redesign Kafka Component Integration
[ https://issues.apache.org/jira/browse/NIFI-11259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-11259: --- Assignee: Paul Grey (was: David Handermann) > Redesign Kafka Component Integration > > > Key: NIFI-11259 > URL: https://issues.apache.org/jira/browse/NIFI-11259 > Project: Apache NiFi > Issue Type: Epic > Components: Extensions >Reporter: David Handermann >Assignee: Paul Grey >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > NiFi has supported integration with Kafka across a number of major release > versions. As Kafka has continued to release new major versions, NiFi > integration has followed a general pattern of duplicating existing code, > updating Kafka libraries, and making small modifications. Although this > approach has allowed NiFi to support a range of Kafka versions, it has made > Kafka components difficult to maintain. > A new approach should be designed and implemented that abstracts access to > Kafka library components. This approach should provide more maintainable > Kafka Processors, and also define a better path to support new major Kafka > releases. > The general approach should consist of a NiFi Controller Service and > supporting classes that abstract Kafka operations for publishing and > consuming messages. The Controller Service interface should not have any > dependencies on Kafka libraries, making it independent of Kafka versions. The > interface should define a contract for accessing Kafka Brokers so that > Controller Service implementations will be responsible for connection and > authentication settings. Controller Service implementations should be aligned > to major Kafka versions, allowing minor dependency version updates without > changing Controller Service implementations. > New Kafka Processors should be designed and implemented to use the Controller > Service interface, without requiring knowledge of Kafka connection details. > New Processors should support the same basic production and consumption > capabilities, with configurable strategies for Kafka Record handling. These > Processors should support the same capabilities as current Processors, > including treating entire FlowFiles as Kafka Records, as well as processing > FlowFiles using a configurable delimiter or using NiFi Record services. > New Kafka components should build on the pattern of the nifi-kafka-shared > module to promote code reuse across major Kafka versions. > The new decoupled Kafka Processors and Controller Services should enable > better unit testing. The Testcontainers library should considered for > integration testing with different Kafka runtime versions. > Documentation should be written to describe common migration scenarios from > existing Kafka Processors to new components. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
exceptionfactory commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1526461916
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/README.md:
##
@@ -0,0 +1,14 @@
+
+
+### Kafka3ProducerService
+- As the `send()` API maps cleanly to the context of a single `FlowFile`,
additional APIs are useful to handle the ability to publish multiple FlowFiles
in the context of a single publish to Kafka.
Review Comment:
Is there a reason for this separate readme as opposed to including these
comments in the class itself?
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-integration/src/test/java/org/apache/nifi/kafka/processors/publish/additional/readme.txt:
##
@@ -0,0 +1,2 @@
+Integration tests derived from examples provided in:
+https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/main/resources/docs/org.apache.nifi.processors.kafka.pubsub.PublishKafkaRecord_2_6/additionalDetails.html
Review Comment:
Is this file necessary? Recommend changing to Markdown for consistency if
you prefer to keep it.
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-integration/src/test/java/org/apache/nifi/kafka/processors/PublishKafkaWrapperRecordIT.java:
##
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.kafka.processors;
+
+import com.fasterxml.jackson.databind.node.ObjectNode;
+import org.apache.commons.io.IOUtils;
+import org.apache.kafka.clients.consumer.ConsumerRecord;
+import org.apache.kafka.clients.consumer.ConsumerRecords;
+import org.apache.kafka.clients.consumer.KafkaConsumer;
+import org.apache.kafka.common.header.Header;
+import org.apache.nifi.kafka.shared.property.PublishStrategy;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
+
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+@TestMethodOrder(MethodOrderer.MethodName.class)
+public class PublishKafkaWrapperRecordIT extends AbstractPublishKafkaIT {
+private static final String TEST_RESOURCE =
"org/apache/nifi/kafka/processors/publish/ffwrapper.json";
+
+private static final String KEY_ATTRIBUTE_KEY = "keyAttribute";
+private static final String KEY_ATTRIBUTE_VALUE = "keyAttributeValue";
+
+private static final int TEST_RECORD_COUNT = 3;
+
+@Test
+public void test_1_KafkaTestContainerProduceOneFlowFile() throws
InitializationException, IOException {
+final TestRunner runner =
TestRunners.newTestRunner(PublishKafka.class);
+runner.setValidateExpressionUsage(false);
+runner.setProperty(PublishKafka.CONNECTION_SERVICE,
addKafkaConnectionService(runner));
+addRecordReaderService(runner);
+addRecordWriterService(runner);
+addRecordKeyWriterService(runner);
+
+runner.setProperty(PublishKafka.TOPIC_NAME, getClass().getName());
+runner.setProperty(PublishKafka.KEY, KEY_ATTRIBUTE_KEY);
+runner.setProperty(PublishKafka.MESSAGE_KEY_FIELD, "address");
+runner.setProperty(PublishKafka.ATTRIBUTE_NAME_REGEX, "a.*");
+runner.setProperty(PublishKafka.PUBLISH_STRATEGY,
PublishStrategy.USE_WRAPPER.name());
+
+final Map attributes = new HashMap<>();
+attributes.put(KEY_ATTRIBUTE_KEY, KEY_ATTRIBUTE_VALUE);
+attributes.put("a1", "valueA1");
+attributes.put("b1", "valueB1");
+final byte[] bytesFlowFile =
IOUtils.toByteArray(Objects.requireNonNull(
+getClass().getClassLoader().getResource(TEST_RESOURCE)));
+
[jira] [Updated] (NIFI-12700) PutKudu memory optimization for unbatched flush mode (AUTO_FLUSH_SYNC)
[ https://issues.apache.org/jira/browse/NIFI-12700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-12700: Fix Version/s: 2.0.0 1.26.0 Resolution: Fixed Status: Resolved (was: Patch Available) > PutKudu memory optimization for unbatched flush mode (AUTO_FLUSH_SYNC) > -- > > Key: NIFI-12700 > URL: https://issues.apache.org/jira/browse/NIFI-12700 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Emilio Setiadarma >Assignee: Emilio Setiadarma >Priority: Major > Fix For: 2.0.0, 1.26.0 > > Time Spent: 2h > Remaining Estimate: 0h > > The PutKudu processor's existing implementation uses a Map of KuduOperation > -> FlowFile to keep track of which FlowFile was processing when the > KuduOperation was created. This is mapping is eventually used to associate > FlowFiles with the RowError (if any occurs), a mapping that is necessary for > transferring FlowFiles to success/failure relationships or logging failures > among other things. > For very large inputs, Kudu Operation objects can grow very large. There is > no memory leak, but still could cause OutOfMemory issues in very large input > data. There is a possibility to not require the use of a KuduOperation -> > FlowFile map for unbatched flush modes (e.g. when using the AUTO_FLUSH_SYNC > flush mode, where the KuduSession.apply() would have already flushed the > buffer before returning, > [https://kudu.apache.org/apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html)|https://kudu.apache.org/apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html] > This Jira attempts to capture the efforts for refactoring PutKudu processor > to make it more memory optimized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12700) PutKudu memory optimization for unbatched flush mode (AUTO_FLUSH_SYNC)
[ https://issues.apache.org/jira/browse/NIFI-12700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827538#comment-17827538 ] ASF subversion and git services commented on NIFI-12700: Commit 3719fddf84ffcf18ed29d87ee931aa1acc1699d3 in nifi's branch refs/heads/main from emiliosetiadarma [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3719fddf84 ] NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_FLUSH_SYNC flush mode (unbatched flush) NIFI-12700: made changes based on PR comments. Simplified statements involving determination of whether or not there are flowfile failures/rowErrors. Separated out getting rowErrors from OperationResponses into its own function Signed-off-by: Matt Burgess This closes #8322 > PutKudu memory optimization for unbatched flush mode (AUTO_FLUSH_SYNC) > -- > > Key: NIFI-12700 > URL: https://issues.apache.org/jira/browse/NIFI-12700 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Emilio Setiadarma >Assignee: Emilio Setiadarma >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > The PutKudu processor's existing implementation uses a Map of KuduOperation > -> FlowFile to keep track of which FlowFile was processing when the > KuduOperation was created. This is mapping is eventually used to associate > FlowFiles with the RowError (if any occurs), a mapping that is necessary for > transferring FlowFiles to success/failure relationships or logging failures > among other things. > For very large inputs, Kudu Operation objects can grow very large. There is > no memory leak, but still could cause OutOfMemory issues in very large input > data. There is a possibility to not require the use of a KuduOperation -> > FlowFile map for unbatched flush modes (e.g. when using the AUTO_FLUSH_SYNC > flush mode, where the KuduSession.apply() would have already flushed the > buffer before returning, > [https://kudu.apache.org/apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html)|https://kudu.apache.org/apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html] > This Jira attempts to capture the efforts for refactoring PutKudu processor > to make it more memory optimized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_F… [nifi]
mattyb149 closed pull request #8322: NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_F… URL: https://github.com/apache/nifi/pull/8322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_F… [nifi]
mattyb149 commented on PR #8501: URL: https://github.com/apache/nifi/pull/8501#issuecomment-143606 Closing as merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_F… [nifi]
mattyb149 closed pull request #8501: NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_F… URL: https://github.com/apache/nifi/pull/8501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_F… [nifi]
mattyb149 commented on PR #8322: URL: https://github.com/apache/nifi/pull/8322#issuecomment-141459 Verified the requested changes were made. +1 LGTM, thanks for the improvement! Merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12700) PutKudu memory optimization for unbatched flush mode (AUTO_FLUSH_SYNC)
[ https://issues.apache.org/jira/browse/NIFI-12700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827537#comment-17827537 ] ASF subversion and git services commented on NIFI-12700: Commit 37eb52d75fdcfe57104b5ec5f5db56ac870c8581 in nifi's branch refs/heads/support/nifi-1.x from emiliosetiadarma [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=37eb52d75f ] NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_FLUSH_SYNC flush mode (unbatched flush) NIFI-12700: made changes based on PR comments. Simplified statements involving determination of whether or not there are flowfile failures/rowErrors. Separated out getting rowErrors from OperationResponses into its own function Signed-off-by: Matt Burgess This closes #8501 > PutKudu memory optimization for unbatched flush mode (AUTO_FLUSH_SYNC) > -- > > Key: NIFI-12700 > URL: https://issues.apache.org/jira/browse/NIFI-12700 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Emilio Setiadarma >Assignee: Emilio Setiadarma >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > The PutKudu processor's existing implementation uses a Map of KuduOperation > -> FlowFile to keep track of which FlowFile was processing when the > KuduOperation was created. This is mapping is eventually used to associate > FlowFiles with the RowError (if any occurs), a mapping that is necessary for > transferring FlowFiles to success/failure relationships or logging failures > among other things. > For very large inputs, Kudu Operation objects can grow very large. There is > no memory leak, but still could cause OutOfMemory issues in very large input > data. There is a possibility to not require the use of a KuduOperation -> > FlowFile map for unbatched flush modes (e.g. when using the AUTO_FLUSH_SYNC > flush mode, where the KuduSession.apply() would have already flushed the > buffer before returning, > [https://kudu.apache.org/apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html)|https://kudu.apache.org/apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html] > This Jira attempts to capture the efforts for refactoring PutKudu processor > to make it more memory optimized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12700: refactored PutKudu to optimize memory handling for AUTO_F… [nifi]
mattyb149 commented on PR #8501: URL: https://github.com/apache/nifi/pull/8501#issuecomment-140400 Verified the requested changes were made. +1 LGTM, thanks for the improvement! Merging to support/nifi-1.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
bobpaulin commented on PR #8510: URL: https://github.com/apache/nifi/pull/8510#issuecomment-125795 Thanks @dan-s1 I've added some additional polish to the tests as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
bobpaulin commented on code in PR #8510:
URL: https://github.com/apache/nifi/pull/8510#discussion_r1526462925
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.CleanupMode;
+import org.junit.jupiter.api.io.TempDir;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+@TempDir(cleanup = CleanupMode.ON_SUCCESS)
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfig;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookup;
+
+@BeforeEach
+public void setUp() {
+this.pythonProcess = new PythonProcess(this.pythonProcessConfig,
this.controllerServiceTypeLookup, virtualEnvHome, "Controller", "Controller");
+}
+@Test
+void testResolvePythonCommandWindows() throws IOException {
+File scriptsDir = new File(virtualEnvHome, "Scripts");
+scriptsDir.mkdir();
+when(pythonProcessConfig.getPythonCommand()).thenReturn("python");
+String result = this.pythonProcess.resolvePythonCommand();
+assertEquals(this.virtualEnvHome.getAbsolutePath() + File.separator +
"Scripts" + File.separator + "python", result);
Review Comment:
Thanks I didn't realized I only applied to one test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] NIFI-12909 - Upgrade Nimbus JOSE+JWT to 9.37.3 - support/1.x [nifi]
pvillard31 opened a new pull request, #8519: URL: https://github.com/apache/nifi/pull/8519 # Summary [NIFI-12909](https://issues.apache.org/jira/browse/NIFI-12909) - Upgrade Nimbus JOSE+JWT to 9.37.3 - support/1.x # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12909 - Upgrade Nimbus JOSE+JWT to 9.37.3 [nifi]
pvillard31 commented on PR #8518: URL: https://github.com/apache/nifi/pull/8518#issuecomment-1999845083 For backport in support/1.x some additional files need to be updated: ./nifi-registry/nifi-registry-extensions/nifi-registry-ranger/pom.xml ./nifi-nar-bundles/nifi-ranger-bundle/pom.xml ./nifi-nar-bundles/nifi-atlas-bundle/pom.xml ./nifi-nar-bundles/nifi-spark-bundle/pom.xml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12909) Upgrade Nimbus JOSE+JWT
[ https://issues.apache.org/jira/browse/NIFI-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12909: -- Labels: backport-needed (was: ) > Upgrade Nimbus JOSE+JWT > --- > > Key: NIFI-12909 > URL: https://issues.apache.org/jira/browse/NIFI-12909 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > Upgrade Nimbus JOSE+JWT to 9.37.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12909) Upgrade Nimbus JOSE+JWT
[ https://issues.apache.org/jira/browse/NIFI-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12909: -- Status: Patch Available (was: In Progress) > Upgrade Nimbus JOSE+JWT > --- > > Key: NIFI-12909 > URL: https://issues.apache.org/jira/browse/NIFI-12909 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Upgrade Nimbus JOSE+JWT to 9.37.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-framework-bundle [nifi]
dependabot[bot] commented on PR #8511: URL: https://github.com/apache/nifi/pull/8511#issuecomment-1999835881 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-framework-bundle [nifi]
pvillard31 closed pull request #8511: Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-framework-bundle URL: https://github.com/apache/nifi/pull/8511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-framework-bundle [nifi]
pvillard31 commented on PR #8511: URL: https://github.com/apache/nifi/pull/8511#issuecomment-1999835784 Covered by #8518. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle [nifi]
dependabot[bot] commented on PR #8512: URL: https://github.com/apache/nifi/pull/8512#issuecomment-1999835569 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle [nifi]
pvillard31 commented on PR #8512: URL: https://github.com/apache/nifi/pull/8512#issuecomment-1999835435 Covered by #8518. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle [nifi]
pvillard31 closed pull request #8512: Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle URL: https://github.com/apache/nifi/pull/8512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-accumulo-bundle [nifi]
dependabot[bot] commented on PR #8513: URL: https://github.com/apache/nifi/pull/8513#issuecomment-1999835203 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-accumulo-bundle [nifi]
pvillard31 commented on PR #8513: URL: https://github.com/apache/nifi/pull/8513#issuecomment-1999835129 Covered by #8518. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-accumulo-bundle [nifi]
pvillard31 closed pull request #8513: Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-accumulo-bundle URL: https://github.com/apache/nifi/pull/8513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-hive-bundle [nifi]
dependabot[bot] commented on PR #8514: URL: https://github.com/apache/nifi/pull/8514#issuecomment-1999834930 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-hive-bundle [nifi]
pvillard31 commented on PR #8514: URL: https://github.com/apache/nifi/pull/8514#issuecomment-1999834852 Covered by #8518. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-hive-bundle [nifi]
pvillard31 closed pull request #8514: Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-hive-bundle URL: https://github.com/apache/nifi/pull/8514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-iceberg-bundle [nifi]
dependabot[bot] commented on PR #8515: URL: https://github.com/apache/nifi/pull/8515#issuecomment-1999834609 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-iceberg-bundle [nifi]
pvillard31 commented on PR #8515: URL: https://github.com/apache/nifi/pull/8515#issuecomment-1999834538 Covered by #8518. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-iceberg-bundle [nifi]
pvillard31 closed pull request #8515: Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-iceberg-bundle URL: https://github.com/apache/nifi/pull/8515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-azure-bundle [nifi]
dependabot[bot] commented on PR #8516: URL: https://github.com/apache/nifi/pull/8516#issuecomment-1999834226 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-azure-bundle [nifi]
pvillard31 commented on PR #8516: URL: https://github.com/apache/nifi/pull/8516#issuecomment-1999834154 Covered by #8518. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-azure-bundle [nifi]
pvillard31 closed pull request #8516: Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-azure-bundle URL: https://github.com/apache/nifi/pull/8516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-hadoop-libraries-bundle [nifi]
dependabot[bot] commented on PR #8517: URL: https://github.com/apache/nifi/pull/8517#issuecomment-1999833736 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-hadoop-libraries-bundle [nifi]
pvillard31 commented on PR #8517: URL: https://github.com/apache/nifi/pull/8517#issuecomment-1999833639 Covered by #8518. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-hadoop-libraries-bundle [nifi]
pvillard31 closed pull request #8517: Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-hadoop-libraries-bundle URL: https://github.com/apache/nifi/pull/8517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12909 - Upgrade Nimbus JOSE+JWT to 9.37.3 [nifi]
pvillard31 opened a new pull request, #8518: URL: https://github.com/apache/nifi/pull/8518 # Summary [NIFI-12909](https://issues.apache.org/jira/browse/NIFI-12909) - Upgrade Nimbus JOSE+JWT to 9.37.3 # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12909) Upgrade Nimbus JOSE+JWT
Pierre Villard created NIFI-12909: - Summary: Upgrade Nimbus JOSE+JWT Key: NIFI-12909 URL: https://issues.apache.org/jira/browse/NIFI-12909 Project: Apache NiFi Issue Type: Improvement Components: Core Framework, Extensions Reporter: Pierre Villard Assignee: Pierre Villard Upgrade Nimbus JOSE+JWT to 9.37.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12888 In AbstractEmailProcessor recreate email receiver when token expires. [nifi]
dan-s1 commented on code in PR #8494:
URL: https://github.com/apache/nifi/pull/8494#discussion_r1526378053
##
nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/AbstractEmailProcessor.java:
##
@@ -324,6 +330,18 @@ private synchronized void
initializeIfNecessary(ProcessContext context, ProcessS
}
}
+private boolean oauth2AccessDetailsRefreshed() {
Review Comment:
The usual convention to name methods that return boolean is to ask a
question in the name usually by using is/has as the prefix.
```suggestion
private boolean isOauth2AccessDetailsRefreshed() {
```
##
nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/AbstractEmailProcessor.java:
##
@@ -324,6 +330,18 @@ private synchronized void
initializeIfNecessary(ProcessContext context, ProcessS
}
}
+private boolean oauth2AccessDetailsRefreshed() {
+boolean oauthDetailsRefreshed =
this.oauth2AccessTokenProviderOptional.isPresent()
+&&
+(
+this.oauth2AccessDetails == null
+||
+
!oauth2AccessDetails.equals(this.oauth2AccessTokenProviderOptional.get().getAccessDetails())
+);
+
+return oauthDetailsRefreshed;
+}
Review Comment:
Couldn't this all be done in a `return` statement
```suggestion
return this.oauth2AccessTokenProviderOptional.isPresent() &&
(this.oauth2AccessDetails == null ||
!oauth2AccessDetails.equals(this.oauth2AccessTokenProviderOptional.get().getAccessDetails())
;
}
```
##
nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/AbstractEmailProcessor.java:
##
@@ -307,7 +309,11 @@ String buildUrl(ProcessContext processContext) {
* and is ready to receive messages.
*/
private synchronized void initializeIfNecessary(ProcessContext context,
ProcessSession processSession) {
-if (this.messageReceiver == null) {
+if (
+this.messageReceiver == null
+||
+oauth2AccessDetailsRefreshed()
+) {
Review Comment:
Per earlier comment and remove unnecessary white space
```suggestion
if (this.messageReceiver == null || isOauth2AccessDetailsRefreshed()
) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-hadoop-libraries-bundle [nifi]
dependabot[bot] opened a new pull request, #8517:
URL: https://github.com/apache/nifi/pull/8517
Bumps
[com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt)
from 9.33 to 9.37.2.
Changelog
Sourced from https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt;>com.nimbusds:nimbus-jose-jwt's
changelog.
version 1.0 (2012-03-01)
First version based on the OpenInfoCard JWT, JWS and JWE code base.
version 1.1 (2012-03-06)
Introduces type-safe enumeration of the JSON Web Algorithms (JWA).
Refactors the JWT class.
version 1.2 (2012-03-08)
Moves JWS and JWE code into separate classes.
version 1.3 (2012-03-09)
Switches to Apache Commons Codec for Base64URL encoding and decoding
Consolidates the crypto utilities within the package.
Introduces a JWT content serialiser class.
version 1.4 (2012-03-09)
Refactoring of JWT class and JUnit tests.
version 1.5 (2012-03-18)
Switches to JSON Smart for JSON serialisation and parsing.
Introduces claims set class with JSON objects, string, Base64URL and
byte array views.
version 1.6 (2012-03-20)
Creates class for representing, serialising and parsing JSON Web Keys
(JWK).
Introduces separate class for representing JWT headers.
version 1.7 (2012-04-01)
Introduces separate classes for plain, JWS and JWE headers.
Introduces separate classes for plain, signed and encrypted JWTs.
Removes the JWTContent class.
Removes password-based (PE820) encryption support.
version 1.8 (2012-04-03)
Adds support for the ZIP JWE header parameter.
Removes unsupported algorithms from the JWA enumeration.
version 1.9 (2012-04-03)
Renames JWEHeader.{get|set}EncryptionAlgorithm() to
JWEHeader.{get|set}EncryptionMethod().
version 1.9.1 (2012-04-03)
Upgrades JSON Smart JAR to 1.1.1.
version 1.10 (2012-04-14)
Introduces serialize() method to base abstract JWT class.
version 1.11 (2012-05-13)
JWT.serialize() throws checked JWTException instead of
... (truncated)
Commits
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/9a277ea957884bbd4388c1611b56ad618c51f976;>9a277ea
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/c695b11a3e3fdaa73058e84cb305595de6720be5;>c695b11
Fixes the MACSigner.sign method for SecretKey instances that don't expose
the...
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/45f15d1e2733502face534f914908c382888bc6b;>45f15d1
Updates the MACVerifier to support SecretKey instances don't expose the key
m...
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/e965e9603d239d037512449bc8ad850cf2fdf6b7;>e965e96
[maven-release-plugin] prepare release 9.34
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/8d67f6c3fdf6af4ed4473b4a81968328bbe08726;>8d67f6c
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/f64e094030ab82659dbfaea8c489cc56291539cf;>f64e094
Makes the abstract class BaseJWEProvider public (iss https://bitbucket.org/connect2id/nimbus-jose-jwt/issues/521;>#521)
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/ad6fed330a6bc5dbcb343aafd085ffd0d15c07d7;>ad6fed3
[maven-release-plugin] prepare release 9.35
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/81c7f24cc8a49f0f87c530e50d750bb1db22b4a8;>81c7f24
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/24aaaf02edf5d1ae4cc449b3d81a9151f26953dc;>24aaaf0
Bumps jacoco-maven-plugin to 0.8.10
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/ff01cd912fe53ee2946170781fe243564920be94;>ff01cd9
Adds new JWKSet.filter method
Additional commits viewable in https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37.2..9.33;>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that
have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
-
[PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-azure-bundle [nifi]
dependabot[bot] opened a new pull request, #8516:
URL: https://github.com/apache/nifi/pull/8516
Bumps
[com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt)
from 9.33 to 9.37.2.
Changelog
Sourced from https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt;>com.nimbusds:nimbus-jose-jwt's
changelog.
version 1.0 (2012-03-01)
First version based on the OpenInfoCard JWT, JWS and JWE code base.
version 1.1 (2012-03-06)
Introduces type-safe enumeration of the JSON Web Algorithms (JWA).
Refactors the JWT class.
version 1.2 (2012-03-08)
Moves JWS and JWE code into separate classes.
version 1.3 (2012-03-09)
Switches to Apache Commons Codec for Base64URL encoding and decoding
Consolidates the crypto utilities within the package.
Introduces a JWT content serialiser class.
version 1.4 (2012-03-09)
Refactoring of JWT class and JUnit tests.
version 1.5 (2012-03-18)
Switches to JSON Smart for JSON serialisation and parsing.
Introduces claims set class with JSON objects, string, Base64URL and
byte array views.
version 1.6 (2012-03-20)
Creates class for representing, serialising and parsing JSON Web Keys
(JWK).
Introduces separate class for representing JWT headers.
version 1.7 (2012-04-01)
Introduces separate classes for plain, JWS and JWE headers.
Introduces separate classes for plain, signed and encrypted JWTs.
Removes the JWTContent class.
Removes password-based (PE820) encryption support.
version 1.8 (2012-04-03)
Adds support for the ZIP JWE header parameter.
Removes unsupported algorithms from the JWA enumeration.
version 1.9 (2012-04-03)
Renames JWEHeader.{get|set}EncryptionAlgorithm() to
JWEHeader.{get|set}EncryptionMethod().
version 1.9.1 (2012-04-03)
Upgrades JSON Smart JAR to 1.1.1.
version 1.10 (2012-04-14)
Introduces serialize() method to base abstract JWT class.
version 1.11 (2012-05-13)
JWT.serialize() throws checked JWTException instead of
... (truncated)
Commits
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/9a277ea957884bbd4388c1611b56ad618c51f976;>9a277ea
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/c695b11a3e3fdaa73058e84cb305595de6720be5;>c695b11
Fixes the MACSigner.sign method for SecretKey instances that don't expose
the...
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/45f15d1e2733502face534f914908c382888bc6b;>45f15d1
Updates the MACVerifier to support SecretKey instances don't expose the key
m...
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/e965e9603d239d037512449bc8ad850cf2fdf6b7;>e965e96
[maven-release-plugin] prepare release 9.34
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/8d67f6c3fdf6af4ed4473b4a81968328bbe08726;>8d67f6c
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/f64e094030ab82659dbfaea8c489cc56291539cf;>f64e094
Makes the abstract class BaseJWEProvider public (iss https://bitbucket.org/connect2id/nimbus-jose-jwt/issues/521;>#521)
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/ad6fed330a6bc5dbcb343aafd085ffd0d15c07d7;>ad6fed3
[maven-release-plugin] prepare release 9.35
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/81c7f24cc8a49f0f87c530e50d750bb1db22b4a8;>81c7f24
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/24aaaf02edf5d1ae4cc449b3d81a9151f26953dc;>24aaaf0
Bumps jacoco-maven-plugin to 0.8.10
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/ff01cd912fe53ee2946170781fe243564920be94;>ff01cd9
Adds new JWKSet.filter method
Additional commits viewable in https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37.2..9.33;>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that
have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
-
[PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-hive-bundle [nifi]
dependabot[bot] opened a new pull request, #8514: URL: https://github.com/apache/nifi/pull/8514 [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/nifi/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-iceberg-bundle [nifi]
dependabot[bot] opened a new pull request, #8515:
URL: https://github.com/apache/nifi/pull/8515
Bumps
[com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt)
from 9.33 to 9.37.2.
Changelog
Sourced from https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt;>com.nimbusds:nimbus-jose-jwt's
changelog.
version 1.0 (2012-03-01)
First version based on the OpenInfoCard JWT, JWS and JWE code base.
version 1.1 (2012-03-06)
Introduces type-safe enumeration of the JSON Web Algorithms (JWA).
Refactors the JWT class.
version 1.2 (2012-03-08)
Moves JWS and JWE code into separate classes.
version 1.3 (2012-03-09)
Switches to Apache Commons Codec for Base64URL encoding and decoding
Consolidates the crypto utilities within the package.
Introduces a JWT content serialiser class.
version 1.4 (2012-03-09)
Refactoring of JWT class and JUnit tests.
version 1.5 (2012-03-18)
Switches to JSON Smart for JSON serialisation and parsing.
Introduces claims set class with JSON objects, string, Base64URL and
byte array views.
version 1.6 (2012-03-20)
Creates class for representing, serialising and parsing JSON Web Keys
(JWK).
Introduces separate class for representing JWT headers.
version 1.7 (2012-04-01)
Introduces separate classes for plain, JWS and JWE headers.
Introduces separate classes for plain, signed and encrypted JWTs.
Removes the JWTContent class.
Removes password-based (PE820) encryption support.
version 1.8 (2012-04-03)
Adds support for the ZIP JWE header parameter.
Removes unsupported algorithms from the JWA enumeration.
version 1.9 (2012-04-03)
Renames JWEHeader.{get|set}EncryptionAlgorithm() to
JWEHeader.{get|set}EncryptionMethod().
version 1.9.1 (2012-04-03)
Upgrades JSON Smart JAR to 1.1.1.
version 1.10 (2012-04-14)
Introduces serialize() method to base abstract JWT class.
version 1.11 (2012-05-13)
JWT.serialize() throws checked JWTException instead of
... (truncated)
Commits
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/9a277ea957884bbd4388c1611b56ad618c51f976;>9a277ea
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/c695b11a3e3fdaa73058e84cb305595de6720be5;>c695b11
Fixes the MACSigner.sign method for SecretKey instances that don't expose
the...
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/45f15d1e2733502face534f914908c382888bc6b;>45f15d1
Updates the MACVerifier to support SecretKey instances don't expose the key
m...
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/e965e9603d239d037512449bc8ad850cf2fdf6b7;>e965e96
[maven-release-plugin] prepare release 9.34
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/8d67f6c3fdf6af4ed4473b4a81968328bbe08726;>8d67f6c
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/f64e094030ab82659dbfaea8c489cc56291539cf;>f64e094
Makes the abstract class BaseJWEProvider public (iss https://bitbucket.org/connect2id/nimbus-jose-jwt/issues/521;>#521)
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/ad6fed330a6bc5dbcb343aafd085ffd0d15c07d7;>ad6fed3
[maven-release-plugin] prepare release 9.35
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/81c7f24cc8a49f0f87c530e50d750bb1db22b4a8;>81c7f24
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/24aaaf02edf5d1ae4cc449b3d81a9151f26953dc;>24aaaf0
Bumps jacoco-maven-plugin to 0.8.10
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/ff01cd912fe53ee2946170781fe243564920be94;>ff01cd9
Adds new JWKSet.filter method
Additional commits viewable in https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37.2..9.33;>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that
have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
-
[PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle [nifi]
dependabot[bot] opened a new pull request, #8512: URL: https://github.com/apache/nifi/pull/8512 [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/nifi/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-accumulo-bundle [nifi]
dependabot[bot] opened a new pull request, #8513:
URL: https://github.com/apache/nifi/pull/8513
Bumps
[com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt)
from 9.33 to 9.37.2.
Changelog
Sourced from https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt;>com.nimbusds:nimbus-jose-jwt's
changelog.
version 1.0 (2012-03-01)
First version based on the OpenInfoCard JWT, JWS and JWE code base.
version 1.1 (2012-03-06)
Introduces type-safe enumeration of the JSON Web Algorithms (JWA).
Refactors the JWT class.
version 1.2 (2012-03-08)
Moves JWS and JWE code into separate classes.
version 1.3 (2012-03-09)
Switches to Apache Commons Codec for Base64URL encoding and decoding
Consolidates the crypto utilities within the package.
Introduces a JWT content serialiser class.
version 1.4 (2012-03-09)
Refactoring of JWT class and JUnit tests.
version 1.5 (2012-03-18)
Switches to JSON Smart for JSON serialisation and parsing.
Introduces claims set class with JSON objects, string, Base64URL and
byte array views.
version 1.6 (2012-03-20)
Creates class for representing, serialising and parsing JSON Web Keys
(JWK).
Introduces separate class for representing JWT headers.
version 1.7 (2012-04-01)
Introduces separate classes for plain, JWS and JWE headers.
Introduces separate classes for plain, signed and encrypted JWTs.
Removes the JWTContent class.
Removes password-based (PE820) encryption support.
version 1.8 (2012-04-03)
Adds support for the ZIP JWE header parameter.
Removes unsupported algorithms from the JWA enumeration.
version 1.9 (2012-04-03)
Renames JWEHeader.{get|set}EncryptionAlgorithm() to
JWEHeader.{get|set}EncryptionMethod().
version 1.9.1 (2012-04-03)
Upgrades JSON Smart JAR to 1.1.1.
version 1.10 (2012-04-14)
Introduces serialize() method to base abstract JWT class.
version 1.11 (2012-05-13)
JWT.serialize() throws checked JWTException instead of
... (truncated)
Commits
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/9a277ea957884bbd4388c1611b56ad618c51f976;>9a277ea
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/c695b11a3e3fdaa73058e84cb305595de6720be5;>c695b11
Fixes the MACSigner.sign method for SecretKey instances that don't expose
the...
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/45f15d1e2733502face534f914908c382888bc6b;>45f15d1
Updates the MACVerifier to support SecretKey instances don't expose the key
m...
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/e965e9603d239d037512449bc8ad850cf2fdf6b7;>e965e96
[maven-release-plugin] prepare release 9.34
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/8d67f6c3fdf6af4ed4473b4a81968328bbe08726;>8d67f6c
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/f64e094030ab82659dbfaea8c489cc56291539cf;>f64e094
Makes the abstract class BaseJWEProvider public (iss https://bitbucket.org/connect2id/nimbus-jose-jwt/issues/521;>#521)
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/ad6fed330a6bc5dbcb343aafd085ffd0d15c07d7;>ad6fed3
[maven-release-plugin] prepare release 9.35
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/81c7f24cc8a49f0f87c530e50d750bb1db22b4a8;>81c7f24
[maven-release-plugin] prepare for next development iteration
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/24aaaf02edf5d1ae4cc449b3d81a9151f26953dc;>24aaaf0
Bumps jacoco-maven-plugin to 0.8.10
https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/ff01cd912fe53ee2946170781fe243564920be94;>ff01cd9
Adds new JWKSet.filter method
Additional commits viewable in https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/9.37.2..9.33;>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that
have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
-
[PR] Bump com.nimbusds:nimbus-jose-jwt from 9.33 to 9.37.2 in /nifi-nar-bundles/nifi-framework-bundle [nifi]
dependabot[bot] opened a new pull request, #8511: URL: https://github.com/apache/nifi/pull/8511 [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/nifi/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12900 Avoid unnecessary file listing in PutSFTP [nifi]
dan-s1 commented on code in PR #8503:
URL: https://github.com/apache/nifi/pull/8503#discussion_r1526344159
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -110,6 +110,14 @@ private static String
convertFactorySetToString(Set factorySetNames) {
.collect(Collectors.joining(", "));
}
+private static String buildFullPath(String path, String filename) {
+return (path == null) ? filename : (path.endsWith("/")) ? path +
filename : path + "/" + filename;
+}
+
+private static boolean identifiesDirectory(FileAttributes attributes) {
Review Comment:
The usual convention to name methods that return boolean is to ask a
question in the name usually by using is/has as the prefix.
```suggestion
private static boolean isDirectory(FileAttributes attributes) {
```
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -110,6 +110,14 @@ private static String
convertFactorySetToString(Set factorySetNames) {
.collect(Collectors.joining(", "));
}
+private static String buildFullPath(String path, String filename) {
+return (path == null) ? filename : (path.endsWith("/")) ? path +
filename : path + "/" + filename;
+}
Review Comment:
Nested ternary operators are hard to read. Write out the logic.
```suggestion
private static String buildFullPath(String path, String filename) {
if (path == null) {
return filename;
} else if (path.endsWith("/")) {
return path + filename
} else {
return path + "/" + filename;
}
}
```
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -694,20 +708,12 @@ public FileInfo getRemoteFileInfo(final FlowFile
flowFile, final String path, St
}
}
-RemoteResourceInfo matchingEntry = null;
-for (final RemoteResourceInfo entry : remoteResources) {
-if (entry.getName().equalsIgnoreCase(filename)) {
-matchingEntry = entry;
-break;
-}
-}
-
// Previously JSCH would perform a listing on the full path (path +
filename) and would get an exception when it wasn't
// a file and then return null, so to preserve that behavior we return
null if the matchingEntry is a directory
-if (matchingEntry != null && matchingEntry.isDirectory()) {
+if (fileAttributes == null || identifiesDirectory(fileAttributes)) {
Review Comment:
Per earlier comment
```suggestion
if (fileAttributes == null || isDirectory(fileAttributes)) {
```
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -443,17 +455,18 @@ private FileInfo newFileInfo(final RemoteResourceInfo
entry, String path) {
appendPermission(permsBuilder, permissions, FilePermission.OTH_X, "x");
final FileInfo.Builder builder = new FileInfo.Builder()
-.filename(entry.getName())
+.filename(filename)
.fullPathFileName(newFullForwardPath)
-.directory(entry.isDirectory())
-.size(entry.getAttributes().getSize())
-.lastModifiedTime(entry.getAttributes().getMtime() * 1000L)
+.directory(identifiesDirectory(attributes))
Review Comment:
Per earlier comment
```suggestion
.directory(isDirectory(attributes))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
exceptionfactory commented on code in PR #8510:
URL: https://github.com/apache/nifi/pull/8510#discussion_r1526303013
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.CleanupMode;
+import org.junit.jupiter.api.io.TempDir;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+@TempDir(cleanup = CleanupMode.ON_SUCCESS)
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfig;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookup;
+
+@BeforeEach
+public void setUp() {
+this.pythonProcess = new PythonProcess(this.pythonProcessConfig,
this.controllerServiceTypeLookup, virtualEnvHome, "Controller", "Controller");
+}
+@Test
+void testResolvePythonCommandWindows() throws IOException {
+File scriptsDir = new File(virtualEnvHome, "Scripts");
+scriptsDir.mkdir();
+when(pythonProcessConfig.getPythonCommand()).thenReturn("python");
+String result = this.pythonProcess.resolvePythonCommand();
+assertEquals(this.virtualEnvHome.getAbsolutePath() + File.separator +
"Scripts" + File.separator + "python", result);
Review Comment:
Yes, this would be helpful, and also declaring `String expectedPath =
getExpectedPath()` before the `assertEquals()` aligns with my previous comment
about separating the variable declaration from the assertion for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
exceptionfactory commented on code in PR #8510:
URL: https://github.com/apache/nifi/pull/8510#discussion_r1526301698
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.CleanupMode;
+import org.junit.jupiter.api.io.TempDir;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+@TempDir(cleanup = CleanupMode.ON_SUCCESS)
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfig;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookup;
+
+@BeforeEach
+public void setUp() {
+this.pythonProcess = new PythonProcess(this.pythonProcessConfig,
this.controllerServiceTypeLookup, virtualEnvHome, "Controller", "Controller");
+}
+@Test
+void testResolvePythonCommandWindows() throws IOException {
+File scriptsDir = new File(virtualEnvHome, "Scripts");
+scriptsDir.mkdir();
+when(pythonProcessConfig.getPythonCommand()).thenReturn("python");
+String result = this.pythonProcess.resolvePythonCommand();
+assertEquals(this.virtualEnvHome.getAbsolutePath() + File.separator +
"Scripts" + File.separator + "python", result);
+}
+
+@Test
+void testResolvePythonCommandUnix() throws IOException {
Review Comment:
No, as mentioned for Windows, the code checks for a directory, it is not
dependent on the runtime platform for that reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
exceptionfactory commented on code in PR #8510:
URL: https://github.com/apache/nifi/pull/8510#discussion_r1526300999
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.CleanupMode;
+import org.junit.jupiter.api.io.TempDir;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+@TempDir(cleanup = CleanupMode.ON_SUCCESS)
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfig;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookup;
+
+@BeforeEach
+public void setUp() {
+this.pythonProcess = new PythonProcess(this.pythonProcessConfig,
this.controllerServiceTypeLookup, virtualEnvHome, "Controller", "Controller");
+}
+@Test
+void testResolvePythonCommandWindows() throws IOException {
Review Comment:
No, the test itself just checks for a particular directory, so it does not
need to be scoped to run only on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
dan-s1 commented on code in PR #8510:
URL: https://github.com/apache/nifi/pull/8510#discussion_r1526257044
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.CleanupMode;
+import org.junit.jupiter.api.io.TempDir;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+@TempDir(cleanup = CleanupMode.ON_SUCCESS)
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfig;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookup;
+
+@BeforeEach
+public void setUp() {
+this.pythonProcess = new PythonProcess(this.pythonProcessConfig,
this.controllerServiceTypeLookup, virtualEnvHome, "Controller", "Controller");
+}
+@Test
+void testResolvePythonCommandWindows() throws IOException {
Review Comment:
@exceptionfactory Shouldn't this test be dependent on running on Windows?
```suggestion
@EnabledOnOs({OS.WINDOWS})
@Test
void testResolvePythonCommandWindows() throws IOException {
```
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.CleanupMode;
+import org.junit.jupiter.api.io.TempDir;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+@TempDir(cleanup = CleanupMode.ON_SUCCESS)
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfig;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookup;
+
+@BeforeEach
+public void setUp() {
+this.pythonProcess = new PythonProcess(this.pythonProcessConfig,
this.controllerServiceTypeLookup, virtualEnvHome, "Controller", "Controller");
+}
+@Test
+void testResolvePythonCommandWindows() throws IOException {
+File scriptsDir = new File(virtualEnvHome, "Scripts");
+scriptsDir.mkdir();
+
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
dan-s1 commented on code in PR #8510:
URL: https://github.com/apache/nifi/pull/8510#discussion_r1526292138
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.CleanupMode;
+import org.junit.jupiter.api.io.TempDir;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+@TempDir(cleanup = CleanupMode.ON_SUCCESS)
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfig;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookup;
+
+@BeforeEach
+public void setUp() {
+this.pythonProcess = new PythonProcess(this.pythonProcessConfig,
this.controllerServiceTypeLookup, virtualEnvHome, "Controller", "Controller");
+}
+@Test
+void testResolvePythonCommandWindows() throws IOException {
+File scriptsDir = new File(virtualEnvHome, "Scripts");
+scriptsDir.mkdir();
+when(pythonProcessConfig.getPythonCommand()).thenReturn("python");
+String result = this.pythonProcess.resolvePythonCommand();
+assertEquals(this.virtualEnvHome.getAbsolutePath() + File.separator +
"Scripts" + File.separator + "python", result);
Review Comment:
I see three tests where the expected path is built. Perhaps make a reusable
method e.g.
```
private String getExpectedPath(String ... elements) {
return String.join(File.separator, elements);
}
```
So the assertion would then look like
```suggestion
assertEquals(getExpectedPath(this.virtualEnvHome.getAbsolutePath(),
"Scripts", "python"), result);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12514: Add windows support for python venv [nifi]
dan-s1 commented on code in PR #8510:
URL: https://github.com/apache/nifi/pull/8510#discussion_r1526252034
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.CleanupMode;
+import org.junit.jupiter.api.io.TempDir;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+@TempDir(cleanup = CleanupMode.ON_SUCCESS)
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfig;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookup;
+
+@BeforeEach
+public void setUp() {
+this.pythonProcess = new PythonProcess(this.pythonProcessConfig,
this.controllerServiceTypeLookup, virtualEnvHome, "Controller", "Controller");
+}
Review Comment:
```suggestion
}
```
##
nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/test/java/org/apache/nifi/py4j/PythonProcessTest.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.py4j;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.when;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.nifi.python.ControllerServiceTypeLookup;
+import org.apache.nifi.python.PythonProcessConfig;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.CleanupMode;
+import org.junit.jupiter.api.io.TempDir;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+class PythonProcessTest {
+
+private PythonProcess pythonProcess;
+
+@TempDir(cleanup = CleanupMode.ON_SUCCESS)
+private File virtualEnvHome;
+
+@Mock
+private PythonProcessConfig pythonProcessConfig;
+
+@Mock
+private ControllerServiceTypeLookup controllerServiceTypeLookup;
+
+@BeforeEach
+public void setUp() {
+this.pythonProcess = new PythonProcess(this.pythonProcessConfig,
this.controllerServiceTypeLookup, virtualEnvHome, "Controller", "Controller");
+}
+@Test
+void testResolvePythonCommandWindows() throws IOException {
+File scriptsDir = new File(virtualEnvHome, "Scripts");
+scriptsDir.mkdir();
+when(pythonProcessConfig.getPythonCommand()).thenReturn("python");
+String result = this.pythonProcess.resolvePythonCommand();
+assertEquals(this.virtualEnvHome.getAbsolutePath() + File.separator +
"Scripts" + File.separator + "python", result);
+}
+
+@Test
+
