Re: [PR] NIFI-12900 Avoid unnecessary directory listing in PutSFTP [nifi]
exceptionfactory commented on code in PR #8503:
URL: https://github.com/apache/nifi/pull/8503#discussion_r1538557100
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -340,7 +356,7 @@ protected void getListing(final String path, final int
depth, final int maxResul
if (isIncludedFile(entry, symlink) && (filteringDisabled ||
pathMatched)) {
if (filteringDisabled || fileFilterPattern == null ||
fileFilterPattern.matcher(entryFilename).matches()) {
-listing.add(newFileInfo(entry, path));
+listing.add(newFileInfo(path, entry.getName(),
entry.getAttributes()));
Review Comment:
This change does not account for the possibility of `entry` being `null` as
implied by the previous behavior.
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##
@@ -340,7 +356,7 @@ protected void getListing(final String path, final int
depth, final int maxResul
if (isIncludedFile(entry, symlink) && (filteringDisabled ||
pathMatched)) {
if (filteringDisabled || fileFilterPattern == null ||
fileFilterPattern.matcher(entryFilename).matches()) {
-listing.add(newFileInfo(entry, path));
+listing.add(newFileInfo(path, entry.getName(),
entry.getAttributes()));
Review Comment:
In this particular context, the `RemoteResourceInfo` may not return
directory status if the path is a symbolic link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12255 refactor PutElasticsearchRecord and PutElasticsearchJson relationships to be more consistent with other processors [nifi]
exceptionfactory commented on code in PR #7940:
URL: https://github.com/apache/nifi/pull/7940#discussion_r1538546543
##
nifi-mock/src/main/java/org/apache/nifi/util/RelationshipMigrationResult.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.util;
+
+import java.util.Map;
+import java.util.Set;
+
+public interface RelationshipMigrationResult {
+
+/**
+ * @return a mapping of previous relationship names to the new names of
those relationships
+ */
+Map> getRelationshipsSplit();
+
+/**
+ * @return a mapping of previous relationship names to the new names of
those relationships
+ */
+Map getRelationshipsRenamed();
Review Comment:
Aligning with the other method, perhaps `getRenamedRelationships()`?
##
nifi-mock/src/main/java/org/apache/nifi/util/RelationshipMigrationResult.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.util;
+
+import java.util.Map;
+import java.util.Set;
+
+public interface RelationshipMigrationResult {
+
+/**
+ * @return a mapping of previous relationship names to the new names of
those relationships
+ */
+Map> getRelationshipsSplit();
Review Comment:
The `Split` naming is not quite clear. Perhaps `getPreviousRelationships()`?
##
nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java:
##
@@ -229,33 +226,32 @@ public void run(final int iterations, final boolean
stopOnFinish, final boolean
executorService.awaitTermination(runWait,
TimeUnit.MILLISECONDS);
} catch (final InterruptedException e1) {
}
+}
-int finishedCount = 0;
-boolean unscheduledRun = false;
-for (final Future future : futures) {
-try {
-final Throwable thrown = future.get(); // wait for the
result
-if (thrown != null) {
-throw new AssertionError(thrown);
-}
+int finishedCount = 0;
+boolean unscheduledRun = false;
+for (final Future future : futures) {
+try {
+final Throwable thrown = future.get(); // wait for the result
+if (thrown != null) {
+throw new AssertionError(thrown);
+}
-if (++finishedCount == 1 && stopOnFinish) {
-unscheduledRun = true;
-unSchedule();
-}
-} catch (final Exception e) {
+if (++finishedCount == 1 && stopOnFinish) {
+unscheduledRun = true;
+unSchedule();
}
+} catch (final Exception e) {
+e.printStackTrace();
Review Comment:
This use of `printStackTrace()` seems problematic, better throw a more
particular type of exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12351 Improve MiNiFi Service Scripts for Windows [nifi]
exceptionfactory commented on PR #8015: URL: https://github.com/apache/nifi/pull/8015#issuecomment-2019318631 @rliszli and @bejancsaba any updates on bringing this pull request to completion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12776: Add UPLOAD provenance event to PutAzureBlobStorage [nifi]
exceptionfactory commented on code in PR #8394:
URL: https://github.com/apache/nifi/pull/8394#discussion_r1538540168
##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage_v12.java:
##
@@ -200,7 +199,13 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
long transferMillis =
TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNanos);
String transitUri = attributes.get(ATTR_NAME_PRIMARY_URI);
-session.getProvenanceReporter().send(flowFile, transitUri,
transferMillis);
+if (fileResourceFound.isPresent()) {
+final FileResource fileResource = fileResourceFound.get();
+session.getProvenanceReporter().fetch(flowFile, transitUri,
transferMillis);
Review Comment:
The `fetch()` method is intended to indicate that the content of the
FlowFile was replaced with an external source, but that is not the case in this
scenario. The output FlowFile remains unchanged, so `FETCH` does not seem to
apply. The `receive()` method seems more appropriate as indicates the
introduction of data, as the content of the FlowFile remains unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12503 Render form-data in swagger.json and RestAPI docs correctly [nifi]
exceptionfactory commented on PR #8485: URL: https://github.com/apache/nifi/pull/8485#issuecomment-2019253765 Merged in https://github.com/apache/nifi/commit/4e1e2612c3379f672cfd8fb9352c6bd230f6789a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12503 Render form-data in swagger.json and RestAPI docs correctly [nifi]
exceptionfactory closed pull request #8485: NIFI-12503 Render form-data in swagger.json and RestAPI docs correctly URL: https://github.com/apache/nifi/pull/8485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12908 provide powershell versions of the nifi-env.cmd and nifi.cmd [nifi]
exceptionfactory closed pull request #8509: NIFI-12908 provide powershell versions of the nifi-env.cmd and nifi.cmd URL: https://github.com/apache/nifi/pull/8509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12908 provide powershell versions of the nifi-env.cmd and nifi.cmd [nifi]
exceptionfactory commented on PR #8509: URL: https://github.com/apache/nifi/pull/8509#issuecomment-2019250167 @phreed I am closing this pull request for now based on the discussion. As mentioned, if you find particular problems with the current `nifi.cmd`, it would be helpful to highlight those in the Jira issue so we can track down the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12925) ListenHTTP should disable unused HTTP methods
[ https://issues.apache.org/jira/browse/NIFI-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830757#comment-17830757 ] ASF subversion and git services commented on NIFI-12925: Commit 6a8cc9720d089821ae2eb8a631f26364f08f5ca0 in nifi's branch refs/heads/support/nifi-1.x from Mark Bean [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6a8cc9720d ] NIFI-12925 Updated ListenHTTP to return 405 for TRACE and OPTIONS This closes #8548 Signed-off-by: David Handermann d (cherry picked from commit 5c150ffd786ec37be4821791654c8a65d4a49f6e) > ListenHTTP should disable unused HTTP methods > - > > Key: NIFI-12925 > URL: https://issues.apache.org/jira/browse/NIFI-12925 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Michael W Moser >Assignee: Mark Bean >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > For [security > reasons|https://owasp.org/www-project-web-security-testing-guide/stable/4-Web_Application_Security_Testing/02-Configuration_and_Deployment_Management_Testing/06-Test_HTTP_Methods], > ListenHTTP should reply with 405 Method Not Allowed for HTTP methods OPTIONS > and TRACE. > PUT already returns 405. > GET, POST, DELETE, HEAD are used by the processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12925) ListenHTTP should return HTTP 405 for TRACE and OPTIONS methods
[ https://issues.apache.org/jira/browse/NIFI-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12925: Summary: ListenHTTP should return HTTP 405 for TRACE and OPTIONS methods (was: ListenHTTP should disable unused HTTP methods) > ListenHTTP should return HTTP 405 for TRACE and OPTIONS methods > --- > > Key: NIFI-12925 > URL: https://issues.apache.org/jira/browse/NIFI-12925 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Michael W Moser >Assignee: Mark Bean >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 1h > Remaining Estimate: 0h > > For [security > reasons|https://owasp.org/www-project-web-security-testing-guide/stable/4-Web_Application_Security_Testing/02-Configuration_and_Deployment_Management_Testing/06-Test_HTTP_Methods], > ListenHTTP should reply with 405 Method Not Allowed for HTTP methods OPTIONS > and TRACE. > PUT already returns 405. > GET, POST, DELETE, HEAD are used by the processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12925) ListenHTTP should disable unused HTTP methods
[ https://issues.apache.org/jira/browse/NIFI-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12925: Fix Version/s: 2.0.0-M3 1.26.0 Resolution: Fixed Status: Resolved (was: Patch Available) > ListenHTTP should disable unused HTTP methods > - > > Key: NIFI-12925 > URL: https://issues.apache.org/jira/browse/NIFI-12925 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Michael W Moser >Assignee: Mark Bean >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 1h > Remaining Estimate: 0h > > For [security > reasons|https://owasp.org/www-project-web-security-testing-guide/stable/4-Web_Application_Security_Testing/02-Configuration_and_Deployment_Management_Testing/06-Test_HTTP_Methods], > ListenHTTP should reply with 405 Method Not Allowed for HTTP methods OPTIONS > and TRACE. > PUT already returns 405. > GET, POST, DELETE, HEAD are used by the processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12925) ListenHTTP should disable unused HTTP methods
[ https://issues.apache.org/jira/browse/NIFI-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830756#comment-17830756 ] ASF subversion and git services commented on NIFI-12925: Commit 5c150ffd786ec37be4821791654c8a65d4a49f6e in nifi's branch refs/heads/main from Mark Bean [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5c150ffd78 ] NIFI-12925 Updated ListenHTTP to return 405 for TRACE and OPTIONS This closes #8548 Signed-off-by: David Handermann d > ListenHTTP should disable unused HTTP methods > - > > Key: NIFI-12925 > URL: https://issues.apache.org/jira/browse/NIFI-12925 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Michael W Moser >Assignee: Mark Bean >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > For [security > reasons|https://owasp.org/www-project-web-security-testing-guide/stable/4-Web_Application_Security_Testing/02-Configuration_and_Deployment_Management_Testing/06-Test_HTTP_Methods], > ListenHTTP should reply with 405 Method Not Allowed for HTTP methods OPTIONS > and TRACE. > PUT already returns 405. > GET, POST, DELETE, HEAD are used by the processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12925 disallow TRACE and OPTIONS methods in ListenHTTP [nifi]
exceptionfactory closed pull request #8548: NIFI-12925 disallow TRACE and OPTIONS methods in ListenHTTP URL: https://github.com/apache/nifi/pull/8548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12930) FetchFile on failure during StandardProcessSession.importFrom should route to failure instead of rollback
[ https://issues.apache.org/jira/browse/NIFI-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12930. - Fix Version/s: 2.0.0-M3 1.26.0 Resolution: Fixed > FetchFile on failure during StandardProcessSession.importFrom should route to > failure instead of rollback > - > > Key: NIFI-12930 > URL: https://issues.apache.org/jira/browse/NIFI-12930 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Consider a scenario involving corrupt files on a disk. > FetchFile during the importFrom call can fail in such cases as would any > process. But the current handling calls rollback instead of routing to > failure. As a result the flow could be stuck in an endless loop trying the > same objects over and over and not giving the flow designer a chance to > reasonably handle such cases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12930) FetchFile on failure during StandardProcessSession.importFrom should route to failure instead of rollback
[ https://issues.apache.org/jira/browse/NIFI-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830755#comment-17830755 ] ASF subversion and git services commented on NIFI-12930: Commit 1e78a66a44135191c73ac726c5e424113d9fbfaa in nifi's branch refs/heads/support/nifi-1.x from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1e78a66a44 ] NIFI-12930 Catch FlowFileAccessException in FetchFile when importing a fetched file we cannot be sure if the problem is reading the source file or writing to the content repository. So we need to route to failure to allow flow designers to choose how to handle this. This closes #8542 Signed-off-by: David Handermann (cherry picked from commit d5ff51b6e4ee6907057b0838f627542f64b9f686) > FetchFile on failure during StandardProcessSession.importFrom should route to > failure instead of rollback > - > > Key: NIFI-12930 > URL: https://issues.apache.org/jira/browse/NIFI-12930 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Consider a scenario involving corrupt files on a disk. > FetchFile during the importFrom call can fail in such cases as would any > process. But the current handling calls rollback instead of routing to > failure. As a result the flow could be stuck in an endless loop trying the > same objects over and over and not giving the flow designer a chance to > reasonably handle such cases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12930) FetchFile on failure during StandardProcessSession.importFrom should route to failure instead of rollback
[ https://issues.apache.org/jira/browse/NIFI-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830754#comment-17830754 ] ASF subversion and git services commented on NIFI-12930: Commit d5ff51b6e4ee6907057b0838f627542f64b9f686 in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d5ff51b6e4 ] NIFI-12930 Catch FlowFileAccessException in FetchFile when importing a fetched file we cannot be sure if the problem is reading the source file or writing to the content repository. So we need to route to failure to allow flow designers to choose how to handle this. This closes #8542 Signed-off-by: David Handermann > FetchFile on failure during StandardProcessSession.importFrom should route to > failure instead of rollback > - > > Key: NIFI-12930 > URL: https://issues.apache.org/jira/browse/NIFI-12930 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Consider a scenario involving corrupt files on a disk. > FetchFile during the importFrom call can fail in such cases as would any > process. But the current handling calls rollback instead of routing to > failure. As a result the flow could be stuck in an endless loop trying the > same objects over and over and not giving the flow designer a chance to > reasonably handle such cases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12930 when importing a fetched file we cannot be sure if the pro… [nifi]
exceptionfactory closed pull request #8542: NIFI-12930 when importing a fetched file we cannot be sure if the pro… URL: https://github.com/apache/nifi/pull/8542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-6379) Add SSL Context Service Property to SQS and PutSNS Processors
[ https://issues.apache.org/jira/browse/NIFI-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830753#comment-17830753 ] ASF subversion and git services commented on NIFI-6379: --- Commit 75cc8c6a3e9e321fd4b8baeb3d69aff2e201e6e4 in nifi's branch refs/heads/support/nifi-1.x from Freedom9339 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=75cc8c6a3e ] NIFI-6379 Added SSL Context to PutSNS, DeleteSQS, GetSQS, and PutSQS This closes #8562 Signed-off-by: David Handermann > Add SSL Context Service Property to SQS and PutSNS Processors > - > > Key: NIFI-6379 > URL: https://issues.apache.org/jira/browse/NIFI-6379 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.7.1, 1.9.2 > Environment: GetSQS Processor >Reporter: John Crooke >Assignee: Reynaldo Rea >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 50m > Remaining Estimate: 0h > > The GetSQS processor does NOT let you choose an SSL Context Service, but > other AWS-related processors such as "FetchS3Object" do have the "SSL Context > Service" property. > > This improvement is to enable the choice of SSL Context Service for the > certificate presented and/or the truststore that will be used to trust the > SQS endpoint's certificate. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-6379) Add SSL Context Service Property to SQS and PutSNS Processors
[ https://issues.apache.org/jira/browse/NIFI-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-6379: --- Fix Version/s: 1.26.0 > Add SSL Context Service Property to SQS and PutSNS Processors > - > > Key: NIFI-6379 > URL: https://issues.apache.org/jira/browse/NIFI-6379 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.7.1, 1.9.2 > Environment: GetSQS Processor >Reporter: John Crooke >Assignee: Reynaldo Rea >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The GetSQS processor does NOT let you choose an SSL Context Service, but > other AWS-related processors such as "FetchS3Object" do have the "SSL Context > Service" property. > > This improvement is to enable the choice of SSL Context Service for the > certificate presented and/or the truststore that will be used to trust the > SQS endpoint's certificate. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-6379 Added SSL context property to PutSNS, DeleteSQS, GetSQS, and PutSQS [nifi]
exceptionfactory commented on PR #8562: URL: https://github.com/apache/nifi/pull/8562#issuecomment-2019237194 Merged in https://github.com/apache/nifi/commit/75cc8c6a3e9e321fd4b8baeb3d69aff2e201e6e4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-6379 Added SSL context property to PutSNS, DeleteSQS, GetSQS, and PutSQS [nifi]
exceptionfactory closed pull request #8562: NIFI-6379 Added SSL context property to PutSNS, DeleteSQS, GetSQS, and PutSQS URL: https://github.com/apache/nifi/pull/8562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12887) Additional ways for handling Strings as binary in PutDatabaseRecord
[ https://issues.apache.org/jira/browse/NIFI-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12887: Fix Version/s: 1.26.0 > Additional ways for handling Strings as binary in PutDatabaseRecord > --- > > Key: NIFI-12887 > URL: https://issues.apache.org/jira/browse/NIFI-12887 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Tamas Palfy >Assignee: Tamas Palfy >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > PutDatabaseRecord expects byte arrays when inserting into a binary type > column (blob, binary etc.) > Or if String is encountered it uses a UTF8 String -> byte conversion. > Using hex-string or base64-encoding to represent binary data as string is > fairly common so this Jira is about adding these capabilities to the > processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12887) Additional ways for handling Strings as binary in PutDatabaseRecord
[ https://issues.apache.org/jira/browse/NIFI-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830751#comment-17830751 ] ASF subversion and git services commented on NIFI-12887: Commit 4009310f0414719cd9c5f922b5b6330b8247aa3d in nifi's branch refs/heads/support/nifi-1.x from Tamas Palfy [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4009310f04 ] NIFI-12887 Added Binary String Format property to PutDatabaseRecord Add option to treat Strings as hexadecimal character sequences or base64-encoded binary data when inserting into a binary type column. This closes #8558 Signed-off-by: David Handermann > Additional ways for handling Strings as binary in PutDatabaseRecord > --- > > Key: NIFI-12887 > URL: https://issues.apache.org/jira/browse/NIFI-12887 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Tamas Palfy >Assignee: Tamas Palfy >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 2.5h > Remaining Estimate: 0h > > PutDatabaseRecord expects byte arrays when inserting into a binary type > column (blob, binary etc.) > Or if String is encountered it uses a UTF8 String -> byte conversion. > Using hex-string or base64-encoding to represent binary data as string is > fairly common so this Jira is about adding these capabilities to the > processor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12887 Add option to treat Strings as hexadecimal character sequences or base64-encoded binary data when inserting into a binary type column. [nifi]
exceptionfactory commented on PR #8558: URL: https://github.com/apache/nifi/pull/8558#issuecomment-2019231237 Merged in https://github.com/apache/nifi/commit/4009310f0414719cd9c5f922b5b6330b8247aa3d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]
exceptionfactory commented on code in PR #8544:
URL: https://github.com/apache/nifi/pull/8544#discussion_r1538408812
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java:
##
@@ -397,10 +432,28 @@ public void process(InputStream in) throws IOException {
fos = codec.createOutputStream(fos);
}
createdFile = actualCopyFile;
-BufferedInputStream bis = new
BufferedInputStream(in);
-StreamUtils.copy(bis, fos);
-bis = null;
-fos.flush();
+
+final String appendMode =
context.getProperty(APPEND_MODE).getValue();
+if (APPEND_RESOLUTION.equals(conflictResponse)
+&& AVRO_APPEND_MODE.equals(appendMode)
+&& destinationExists) {
+getLogger().info("Appending avro record to
existing avro file");
+try (final var reader = new
DataFileStream<>(in, new GenericDatumReader<>());
Review Comment:
One additional note, use of `var` should be avoided in general, even when
supported in the main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12943) Upgrade Hadoop to 3.4.0
[ https://issues.apache.org/jira/browse/NIFI-12943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830739#comment-17830739 ] ASF subversion and git services commented on NIFI-12943: Commit e269304e23abd9710f6a73ea670a318b3e305f73 in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e269304e23 ] NIFI-12943 Upgraded Hadoop from 3.3.6 to 3.4.0 Signed-off-by: Joseph Witt > Upgrade Hadoop to 3.4.0 > --- > > Key: NIFI-12943 > URL: https://issues.apache.org/jira/browse/NIFI-12943 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 20m > Remaining Estimate: 0h > > Apache Hadoop dependencies should be upgraded to > [3.4.0|https://hadoop.apache.org/docs/r3.4.0/index.html] to incorporate bug > fixes and improvements, including a number of transitive dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12943) Upgrade Hadoop to 3.4.0
[ https://issues.apache.org/jira/browse/NIFI-12943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12943: Fix Version/s: 1.26.0 > Upgrade Hadoop to 3.4.0 > --- > > Key: NIFI-12943 > URL: https://issues.apache.org/jira/browse/NIFI-12943 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Apache Hadoop dependencies should be upgraded to > [3.4.0|https://hadoop.apache.org/docs/r3.4.0/index.html] to incorporate bug > fixes and improvements, including a number of transitive dependency upgrades. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12949) Upgrade Box SDK to 4.8.0
[ https://issues.apache.org/jira/browse/NIFI-12949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12949: Status: Patch Available (was: Open) > Upgrade Box SDK to 4.8.0 > > > Key: NIFI-12949 > URL: https://issues.apache.org/jira/browse/NIFI-12949 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: backport-needed > Time Spent: 10m > Remaining Estimate: 0h > > The Box Java SDK should be upgraded to > [4.8.0|https://github.com/box/box-java-sdk/releases/tag/v4.8.0] to > incorporate several transitive dependency upgrades, including more recent > Bouncy Castle dependency coordinates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12949 Upgrade Box SDK from 4.6.1 to 4.8.0 [nifi]
exceptionfactory opened a new pull request, #8567: URL: https://github.com/apache/nifi/pull/8567 # Summary [NIFI-12949](https://issues.apache.org/jira/browse/NIFI-12949) Upgrades the Box SDK from 4.6.1 to [4.8.0](https://github.com/box/box-java-sdk/releases/tag/v4.8.0). The upgrade removes the need for the exclusion of the older Bouncy Castle library versions, since Box SDK 4.8.0 depends on the current Maven coordinates, align with managed project versions. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1538335965
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/enable-controller-service/enable-controller-service.component.html:
##
@@ -21,8 +21,8 @@ Enable Controller Service
@if (enableRequest.currentStep === SetEnableStep.Pending) {
-
-
+
+
Review Comment:
I made this dialog a bit wider so I was playing around with the grid layout
to split the width in half. I will restore this spacing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1538328261
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/state/access-policy/access-policy.effects.ts:
##
@@ -172,7 +173,7 @@ export class AccessPolicyEffects {
concatLatestFrom(() =>
this.store.select(selectAccessPolicy).pipe(isDefinedAndNotNull())),
tap(([, accessPolicy]) => {
const dialogReference =
this.dialog.open(OverridePolicyDialog, {
-panelClass: 'small-dialog'
+...DIALOG_SIZES.LARGE
Review Comment:
We could also remove any dialog size config for this dialog and allow it to
just be as wide as it needs to be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1538325190
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/yes-no-dialog/yes-no-dialog.component.html:
##
@@ -17,7 +17,7 @@
{{ request.title }}
-{{ request.message
}}
Review Comment:
So I think the YesNoDialog, CancelDialog, and OkDialog can all not be
designated as SMALL dialogs and this will help this use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538322756
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/ConsumeKafka.java:
##
@@ -0,0 +1,464 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.kafka.processors;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.ConfigVerificationResult;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.PropertyValue;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.kafka.processors.common.KafkaUtils;
+import org.apache.nifi.kafka.processors.consumer.OffsetTracker;
+import org.apache.nifi.kafka.processors.consumer.ProcessingStrategy;
+import org.apache.nifi.kafka.processors.consumer.bundle.ByteRecordBundler;
+import
org.apache.nifi.kafka.processors.consumer.convert.FlowFileStreamKafkaMessageConverter;
+import org.apache.nifi.kafka.processors.consumer.convert.KafkaMessageConverter;
+import
org.apache.nifi.kafka.processors.consumer.convert.RecordStreamKafkaMessageConverter;
+import
org.apache.nifi.kafka.processors.consumer.convert.WrapperRecordStreamKafkaMessageConverter;
+import org.apache.nifi.kafka.service.api.KafkaConnectionService;
+import org.apache.nifi.kafka.service.api.common.PartitionState;
+import org.apache.nifi.kafka.service.api.consumer.AutoOffsetReset;
+import org.apache.nifi.kafka.service.api.consumer.ConsumerConfiguration;
+import org.apache.nifi.kafka.service.api.consumer.KafkaConsumerService;
+import org.apache.nifi.kafka.service.api.consumer.PollingContext;
+import org.apache.nifi.kafka.service.api.record.ByteRecord;
+import org.apache.nifi.kafka.shared.attribute.KafkaFlowFileAttribute;
+import org.apache.nifi.kafka.shared.property.KeyEncoding;
+import org.apache.nifi.kafka.shared.property.KeyFormat;
+import org.apache.nifi.kafka.shared.property.OutputStrategy;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.VerifiableProcessor;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.serialization.RecordReaderFactory;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+import org.apache.nifi.util.StringUtils;
+
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.regex.Pattern;
+
+import static org.apache.nifi.expression.ExpressionLanguageScope.NONE;
+
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@Tags({"kafka", "consumer", "record"})
+public class ConsumeKafka extends AbstractProcessor implements
VerifiableProcessor {
+
+static final AllowableValue TOPIC_NAME = new AllowableValue("names",
"names", "Topic is a full topic name or comma separated list of names");
+static final AllowableValue TOPIC_PATTERN = new AllowableValue("pattern",
"pattern", "Topic is a regex using the Java Pattern syntax");
+
+static final PropertyDescriptor CONNECTION_SERVICE = new
PropertyDescriptor.Builder()
+.name("Kafka Connection Service")
+.displayName("Kafka Connection Service")
+.description("Provides connections to Kafka Broker for publishing
Kafka Records")
+.identifiesControllerService(KafkaConnectionService.class)
+.expressionLanguageSupported(NONE)
+.required(true)
+.build();
+
+
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538320629
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/producer/txn/KafkaTransactionalProducerWrapper.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.kafka.service.producer.txn;
+
+import org.apache.kafka.clients.producer.Producer;
+
+public class KafkaTransactionalProducerWrapper extends KafkaProducerWrapper {
+
+public KafkaTransactionalProducerWrapper(final Producer
producer) {
+super(producer);
+}
+
+@Override
+public void init() {
+producer.initTransactions();
+producer.beginTransaction();
+}
+
+@Override
+public void commit() {
+try {
+producer.commitTransaction();
+logger.trace("committed");
Review Comment:
Yep; thanks. In general, there will be instances of these that were useful
in the moment, but no longer helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1538319881
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_listing-table.scss:
##
@@ -25,7 +25,6 @@
border-style: solid;
table {
-width: 100%;
Review Comment:
ok I can restore this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538319116
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/producer/txn/KafkaProducerWrapper.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.kafka.service.producer.txn;
+
+import org.apache.kafka.clients.producer.Producer;
+import org.apache.kafka.clients.producer.ProducerRecord;
+import org.apache.kafka.common.header.Header;
+import org.apache.kafka.common.header.internals.RecordHeader;
+import org.apache.nifi.kafka.service.api.producer.PublishContext;
+import org.apache.nifi.kafka.service.api.record.KafkaRecord;
+import org.apache.nifi.kafka.service.producer.ProducerCallback;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Iterator;
+import java.util.List;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+/**
+ * Abstract away the configured transactionality of the PublishKafka producer.
+ */
+public abstract class KafkaProducerWrapper {
+protected final Logger logger = LoggerFactory.getLogger(getClass());
+
+protected final Producer producer;
+
+public KafkaProducerWrapper(final Producer producer) {
+this.producer = producer;
+}
+
+/**
+ * Transaction-enabled publish to Kafka involves the use of special Kafka
client library APIs.
+ */
+public abstract void init();
+
+public void send(final Iterator kafkaRecords, final
PublishContext publishContext, final ProducerCallback callback) {
+while (kafkaRecords.hasNext()) {
+final KafkaRecord kafkaRecord = kafkaRecords.next();
+producer.send(toProducerRecord(kafkaRecord, publishContext),
callback);
+callback.send();
+}
+logger.trace("send():inFlight");
Review Comment:
Maybe not.
Are there reasonable project guidelines for how to log things that should be
disabled by default, but useful in troubleshooting particular scenarios? Not
necessarily suggesting this is one; more of a general question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538315024
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/producer/ProducerCallback.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.kafka.service.producer;
+
+import org.apache.kafka.clients.producer.Callback;
+import org.apache.kafka.clients.producer.RecordMetadata;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.kafka.service.api.producer.FlowFileResult;
+import org.apache.nifi.kafka.service.api.producer.ProducerRecordMetadata;
+import org.apache.nifi.kafka.shared.util.Notifier;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+public class ProducerCallback implements Callback {
+private final Logger logger = LoggerFactory.getLogger(getClass());
+
+private final AtomicLong sentCount;
+private final AtomicLong acknowledgedCount;
+private final AtomicLong failedCount;
+private final FlowFile flowFile;
+private final List metadatas;
+private final List exceptions;
+private final Notifier notifier;
+
+public List getExceptions() {
+return exceptions;
+}
+
+public boolean isFailure() {
+return !exceptions.isEmpty();
+}
+
+public ProducerCallback(final FlowFile flowFile) {
+this.sentCount = new AtomicLong(0L);
+this.acknowledgedCount = new AtomicLong(0L);
+this.failedCount = new AtomicLong(0L);
+this.flowFile = flowFile;
+this.metadatas = new ArrayList<>();
+this.exceptions = new ArrayList<>();
+this.notifier = new Notifier();
+}
+
+public long send() {
+return sentCount.incrementAndGet();
+}
+
+@Override
+public void onCompletion(final RecordMetadata metadata, final Exception
exception) {
+
+// the source `FlowFile` and the associated `RecordMetadata` need to
somehow be associated...
Review Comment:
I was originally hoping that this sort of API would not be needed, but there
were problems when I added transactionality. Maybe a reasonable method-level
comment could be used instead to capture this nuance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1538306100
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/yes-no-dialog/yes-no-dialog.component.html:
##
@@ -17,7 +17,7 @@
{{ request.title }}
-{{ request.message
}}
Review Comment:
Yes, I think I have an idea. We can remove the SMALL dialog size designation
from these types of dialogs. Doing so for Empty All Queues Dialog would look
like:
https://github.com/apache/nifi/assets/6797571/d505de0c-bea0-4021-99ff-44b4f187c32a;>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538306358
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/producer/Kafka3ProducerService.java:
##
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.kafka.service.producer;
+
+import org.apache.kafka.clients.producer.KafkaProducer;
+import org.apache.kafka.clients.producer.Producer;
+import org.apache.kafka.common.PartitionInfo;
+import org.apache.kafka.common.serialization.ByteArraySerializer;
+import org.apache.nifi.kafka.service.api.common.PartitionState;
+import org.apache.nifi.kafka.service.api.common.ServiceConfiguration;
+import org.apache.nifi.kafka.service.api.producer.FlowFileResult;
+import org.apache.nifi.kafka.service.api.producer.KafkaProducerService;
+import org.apache.nifi.kafka.service.api.producer.ProducerConfiguration;
+import org.apache.nifi.kafka.service.api.producer.PublishContext;
+import org.apache.nifi.kafka.service.api.producer.RecordSummary;
+import org.apache.nifi.kafka.service.api.record.KafkaRecord;
+import
org.apache.nifi.kafka.service.producer.txn.KafkaNonTransactionalProducerWrapper;
+import org.apache.nifi.kafka.service.producer.txn.KafkaProducerWrapper;
+import
org.apache.nifi.kafka.service.producer.txn.KafkaTransactionalProducerWrapper;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.UncheckedIOException;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+public class Kafka3ProducerService implements KafkaProducerService {
+private final Logger logger = LoggerFactory.getLogger(getClass());
+
+private final Producer producer;
+private final List callbacks;
+
+private final ServiceConfiguration serviceConfiguration;
+
+private final KafkaProducerWrapper wrapper;
+
+public Kafka3ProducerService(final Properties properties,
+ final ServiceConfiguration
serviceConfiguration,
+ final ProducerConfiguration
producerConfiguration) {
+final ByteArraySerializer serializer = new ByteArraySerializer();
+this.producer = new KafkaProducer<>(properties, serializer,
serializer);
+this.callbacks = new ArrayList<>();
+
+this.serviceConfiguration = serviceConfiguration;
+
+this.wrapper = producerConfiguration.getUseTransactions()
+? new KafkaTransactionalProducerWrapper(producer)
+: new KafkaNonTransactionalProducerWrapper(producer);
+}
+
+@Override
+public void close() {
+producer.close();
+}
+
+@Override
+public void init() {
+wrapper.init();
+logger.trace("init()");
Review Comment:
This particular one helped me work out a problem with controller service
lifecycle, but now uneeded; I will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on code in PR #8463: URL: https://github.com/apache/nifi/pull/8463#discussion_r1538303445 ## nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-integration/src/test/java/org/apache/nifi/kafka/processors/publish/additional/readme.txt: ## @@ -0,0 +1,2 @@ +Integration tests derived from examples provided in: +https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/main/resources/docs/org.apache.nifi.processors.kafka.pubsub.PublishKafkaRecord_2_6/additionalDetails.html Review Comment: I found myself noting things during implementation. Where appropriate, I'll make sure any documentation like this is in Markdown format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on code in PR #8463: URL: https://github.com/apache/nifi/pull/8463#discussion_r1538303639 ## nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/README.md: ## @@ -0,0 +1,14 @@ + + +### Kafka3ProducerService +- As the `send()` API maps cleanly to the context of a single `FlowFile`, additional APIs are useful to handle the ability to publish multiple FlowFiles in the context of a single publish to Kafka. Review Comment: That makes sense; I will make that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12930) FetchFile on failure during StandardProcessSession.importFrom should route to failure instead of rollback
[ https://issues.apache.org/jira/browse/NIFI-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830717#comment-17830717 ] Jim Steinebrey commented on NIFI-12930: --- No problem. Thx > FetchFile on failure during StandardProcessSession.importFrom should route to > failure instead of rollback > - > > Key: NIFI-12930 > URL: https://issues.apache.org/jira/browse/NIFI-12930 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Consider a scenario involving corrupt files on a disk. > FetchFile during the importFrom call can fail in such cases as would any > process. But the current handling calls rollback instead of routing to > failure. As a result the flow could be stuck in an endless loop trying the > same objects over and over and not giving the flow designer a chance to > reasonably handle such cases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538301385
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/Kafka3ConnectionService.java:
##
@@ -0,0 +1,402 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.kafka.service;
+
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.clients.admin.AdminClientConfig;
+import org.apache.kafka.clients.admin.ListTopicsResult;
+import org.apache.kafka.clients.admin.TopicListing;
+import org.apache.kafka.clients.consumer.ConsumerConfig;
+import org.apache.kafka.clients.producer.ProducerConfig;
+import org.apache.kafka.common.KafkaFuture;
+import org.apache.kafka.common.config.SaslConfigs;
+import org.apache.kafka.common.security.auth.SecurityProtocol;
+import org.apache.kafka.common.security.plain.PlainLoginModule;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.ConfigVerificationResult;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.PropertyValue;
+import org.apache.nifi.context.PropertyContext;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.controller.VerifiableControllerService;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.kafka.service.api.KafkaConnectionService;
+import org.apache.nifi.kafka.service.api.common.ServiceConfiguration;
+import org.apache.nifi.kafka.service.api.consumer.ConsumerConfiguration;
+import org.apache.nifi.kafka.service.api.consumer.KafkaConsumerService;
+import org.apache.nifi.kafka.service.api.producer.KafkaProducerService;
+import org.apache.nifi.kafka.service.api.producer.ProducerConfiguration;
+import org.apache.nifi.kafka.service.consumer.Kafka3ConsumerService;
+import org.apache.nifi.kafka.service.producer.Kafka3ProducerService;
+import org.apache.nifi.kafka.shared.property.SaslMechanism;
+import org.apache.nifi.kafka.shared.property.provider.KafkaPropertyProvider;
+import
org.apache.nifi.kafka.shared.property.provider.StandardKafkaPropertyProvider;
+import org.apache.nifi.kafka.shared.transaction.TransactionIdSupplier;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.ssl.SSLContextService;
+
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+import java.util.concurrent.TimeUnit;
+
+import static
org.apache.nifi.components.ConfigVerificationResult.Outcome.FAILED;
+import static
org.apache.nifi.components.ConfigVerificationResult.Outcome.SUCCESSFUL;
+import static
org.apache.nifi.kafka.shared.property.KafkaClientProperty.SSL_KEYSTORE_LOCATION;
+import static
org.apache.nifi.kafka.shared.property.KafkaClientProperty.SSL_KEYSTORE_PASSWORD;
+import static
org.apache.nifi.kafka.shared.property.KafkaClientProperty.SSL_KEYSTORE_TYPE;
+import static
org.apache.nifi.kafka.shared.property.KafkaClientProperty.SSL_KEY_PASSWORD;
+import static
org.apache.nifi.kafka.shared.property.KafkaClientProperty.SSL_TRUSTSTORE_LOCATION;
+import static
org.apache.nifi.kafka.shared.property.KafkaClientProperty.SSL_TRUSTSTORE_PASSWORD;
+import static
org.apache.nifi.kafka.shared.property.KafkaClientProperty.SSL_TRUSTSTORE_TYPE;
+
+public class Kafka3ConnectionService extends AbstractControllerService
implements KafkaConnectionService, VerifiableControllerService {
+
+public static final PropertyDescriptor BOOTSTRAP_SERVERS = new
PropertyDescriptor.Builder()
+.name("bootstrap.servers")
+.displayName("Bootstrap Servers")
+.description("Comma-separated list of Kafka Bootstrap Servers in
the format host:port. Mapped to Kafka bootstrap.servers")
+.required(true)
+.addValidator(StandardValidators.NON_BLANK_VALIDATOR)
+
[jira] [Created] (NIFI-12952) follow up work for Kafka processor refactor
Paul Grey created NIFI-12952: Summary: follow up work for Kafka processor refactor Key: NIFI-12952 URL: https://issues.apache.org/jira/browse/NIFI-12952 Project: Apache NiFi Issue Type: Improvement Reporter: Paul Grey -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12930) FetchFile on failure during StandardProcessSession.importFrom should route to failure instead of rollback
[ https://issues.apache.org/jira/browse/NIFI-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830716#comment-17830716 ] Joe Witt commented on NIFI-12930: - [~jrsteinebrey]I have it assigned to me as there is already a PR that addresses it. Thanks > FetchFile on failure during StandardProcessSession.importFrom should route to > failure instead of rollback > - > > Key: NIFI-12930 > URL: https://issues.apache.org/jira/browse/NIFI-12930 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Consider a scenario involving corrupt files on a disk. > FetchFile during the importFrom call can fail in such cases as would any > process. But the current handling calls rollback instead of routing to > failure. As a result the flow could be stuck in an endless loop trying the > same objects over and over and not giving the flow designer a chance to > reasonably handle such cases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-12930) FetchFile on failure during StandardProcessSession.importFrom should route to failure instead of rollback
[ https://issues.apache.org/jira/browse/NIFI-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt reassigned NIFI-12930: --- Assignee: Joe Witt (was: Jim Steinebrey) > FetchFile on failure during StandardProcessSession.importFrom should route to > failure instead of rollback > - > > Key: NIFI-12930 > URL: https://issues.apache.org/jira/browse/NIFI-12930 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Consider a scenario involving corrupt files on a disk. > FetchFile during the importFrom call can fail in such cases as would any > process. But the current handling calls rollback instead of routing to > failure. As a result the flow could be stuck in an endless loop trying the > same objects over and over and not giving the flow designer a chance to > reasonably handle such cases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535: URL: https://github.com/apache/nifi/pull/8535#discussion_r1538282376 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-table/parameter-table.component.html: ## @@ -15,8 +15,8 @@ ~ limitations under the License. --> - - + + Review Comment: I could have used flex for this element but then I needed to assign a width to at least one of (and likely it should be both) the listing table and the referencing components elements. Instead I opted to use the grid to give 2/3 width to the parameter listing table and leave 1/3 of the space to the referencing components container element. I think either approach is appropriate here but let me know if you think we need to make a change here. Using flex as previous: https://github.com/apache/nifi/assets/6797571/d2d6043f-8f21-4843-bb15-ef644dbc20cd;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-12930) FetchFile on failure during StandardProcessSession.importFrom should route to failure instead of rollback
[ https://issues.apache.org/jira/browse/NIFI-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Steinebrey reassigned NIFI-12930: - Assignee: Jim Steinebrey > FetchFile on failure during StandardProcessSession.importFrom should route to > failure instead of rollback > - > > Key: NIFI-12930 > URL: https://issues.apache.org/jira/browse/NIFI-12930 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Jim Steinebrey >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Consider a scenario involving corrupt files on a disk. > FetchFile during the importFrom call can fail in such cases as would any > process. But the current handling calls rollback instead of routing to > failure. As a result the flow could be stuck in an endless loop trying the > same objects over and over and not giving the flow designer a chance to > reasonably handle such cases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12889: Retry Kerberos login on auth failure in HDFS processors [nifi]
Lehel44 commented on code in PR #8495:
URL: https://github.com/apache/nifi/pull/8495#discussion_r1538284672
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java:
##
@@ -465,10 +465,16 @@ public void process(InputStream in) throws IOException {
} catch (final IOException e) {
Review Comment:
Since we throw the GSSException wrapped in a ProcessException, I think we
have to catch the ProcessException, then check if it's a GSSException. If so
rollback, othwerwise throw it away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535: URL: https://github.com/apache/nifi/pull/8535#discussion_r1538282376 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-table/parameter-table.component.html: ## @@ -15,8 +15,8 @@ ~ limitations under the License. --> - - + + Review Comment: I could have used flex for this element but then I needed to assign a width to at least one of (and likely it should be both) the listing table and the referencing components elements. Instead I opted to use the grid to give 2/3 width to the parameter listing table and leave 1/3 of the space to the referencing components container element. I think either approach is appropriate here but let me know if you think we need to make a change here. Using flex as previous: ![Uploading Screenshot 2024-03-25 at 5.56.32 PM.png…]() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535: URL: https://github.com/apache/nifi/pull/8535#discussion_r1538282376 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-table/parameter-table.component.html: ## @@ -15,8 +15,8 @@ ~ limitations under the License. --> - - + + Review Comment: I could have used flex for this element but then I needed to assign a width to at least one of (and likely it should be both) the listing table and the referencing components elements. Instead I opted to use the grid to give 2/3 width to the parameter listing table and leave 1/3 of the space to the referencing components container element. I think either approach is appropriate here but let me know if you think we need to make a change here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1538278902
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/component-state/component-state.component.scss:
##
@@ -20,8 +20,6 @@
.component-state-dialog {
@include mat.button-density(-1);
-width: 760px;
Review Comment:
It looks like the `.listing-table` class is on the wrong DOM element. I can
update it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535: URL: https://github.com/apache/nifi/pull/8535#discussion_r1538271623 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/tsconfig.json: ## @@ -7,7 +7,7 @@ "forceConsistentCasingInFileNames": true, "strict": true, "noImplicitOverride": true, -"noPropertyAccessFromIndexSignature": true, +"noPropertyAccessFromIndexSignature": false, Review Comment: I was getting an error when trying to access `DIALOG_SIZES.LARGE` or `DIALOG_SIZES.MEDIUM`. I think we want to keep this config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1538270150
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/state/access-policy/access-policy.effects.ts:
##
@@ -172,7 +173,7 @@ export class AccessPolicyEffects {
concatLatestFrom(() =>
this.store.select(selectAccessPolicy).pipe(isDefinedAndNotNull())),
tap(([, accessPolicy]) => {
const dialogReference =
this.dialog.open(OverridePolicyDialog, {
-panelClass: 'small-dialog'
+...DIALOG_SIZES.LARGE
Review Comment:
It was just a personal preference. I thought having the instructions on a
single line was easier to comprehend and it made it more clear to the user that
they need to select either the "Copy" or the "Empty" policy will be the default:
Previously:
https://github.com/apache/nifi/assets/6797571/a535ad0b-9b3c-4ac3-b7e8-7a59d0d4;>
If we make this a large dialog maybe it is more clear to the user what to do:
https://github.com/apache/nifi/assets/6797571/24a2c066-0db8-485f-a03d-ea193e7dec40;>
Please let me know your thoughts here. I can easily restore the small dialog
if you think it is appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-12922] semantic dialog size configurations [nifi]
scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1538266243
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/state/flow-configuration-history-listing/flow-configuration-history-listing.effects.ts:
##
@@ -95,7 +96,7 @@ export class FlowConfigurationHistoryListingEffects {
ofType(HistoryActions.openPurgeHistoryDialog),
tap(() => {
const dialogReference = this.dialog.open(PurgeHistory, {
-panelClass: 'medium-short-dialog'
+...DIALOG_SIZES.LARGE
Review Comment:
This one was a bit special as it was the only 'medium-short-dialog'. I tried
to go with the MEDIUM dialog here but Angular Material puts a `width: 180px` on
the `.mat-mdc-form-field-infix` class. In a MEDIUM dialog like this where these
two input fields are next to each other in the UX then the input field takes up
236px. Two inputs plus padding in between and on either side would be too wide
to fit into a 460px wide MEDIUM dialog:
https://github.com/apache/nifi/assets/6797571/4251e3a7-63c1-4b01-b733-a5d8046ec683;>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modfiy check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering ** Style regressions (NIFI-12946) * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build (NIFI-12941) * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu * Migrate NiFi UI to nx * Migrate
[jira] [Updated] (NIFI-12941) Migrate from Karma to Jest
[ https://issues.apache.org/jira/browse/NIFI-12941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-12941: --- Status: Patch Available (was: In Progress) > Migrate from Karma to Jest > -- > > Key: NIFI-12941 > URL: https://issues.apache.org/jira/browse/NIFI-12941 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12950) Use uiOnly flag
[ https://issues.apache.org/jira/browse/NIFI-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12950: --- Status: Patch Available (was: Open) > Use uiOnly flag > --- > > Key: NIFI-12950 > URL: https://issues.apache.org/jira/browse/NIFI-12950 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The REST API contains a number of endpoints that support a uiOnly flag. This > flag prunes a number of details that are not needed by the UI at that point. > This helps stabilize the usage of the UI when the flow size increases. The > new UI work currently does not leverage this flag. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12950: Updating front end to use the uiOnly flag where possible [nifi]
mcgilman opened a new pull request, #8565: URL: https://github.com/apache/nifi/pull/8565 NIFI-12950: - Updating front end to use the uiOnly flag where possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12935 Bump webpack-dev-middleware and karma-webpack in /nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main [nifi]
scottyaslan merged PR #8547: URL: https://github.com/apache/nifi/pull/8547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12935) Upgrade Karma Webpack to 5.0.1
[ https://issues.apache.org/jira/browse/NIFI-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan resolved NIFI-12935. Resolution: Fixed > Upgrade Karma Webpack to 5.0.1 > -- > > Key: NIFI-12935 > URL: https://issues.apache.org/jira/browse/NIFI-12935 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: Matt Gilman >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > NiFi Registry UI depends on Karma Webpack as part of the build process. Karma > Webpack 5.0.1 depends on Webpack 5, so further evaluation is necessary to > determine the impact of upgrading. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12951) UI - Nifi Registry Frontend unit tests are failing
Scott Aslan created NIFI-12951: -- Summary: UI - Nifi Registry Frontend unit tests are failing Key: NIFI-12951 URL: https://issues.apache.org/jira/browse/NIFI-12951 Project: Apache NiFi Issue Type: Bug Reporter: Scott Aslan There are several unit tests failing. To see the different tests failing run `npm ci` and `npm run test:dev`. It seems as though these unit tests have not been ran in a long time. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12935 Bump webpack-dev-middleware and karma-webpack in /nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main [nifi]
scottyaslan commented on PR #8547: URL: https://github.com/apache/nifi/pull/8547#issuecomment-2018837839 The tests have several failures but those failure are present on the main branch as well. I have filed https://issues.apache.org/jira/browse/NIFI-12951 to address those failures in a separate effort. This PR installs the required node_modules/ to run the unit tests and it updates our dependencies to a better state. I am +1 here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]
mattyb149 commented on code in PR #8544:
URL: https://github.com/apache/nifi/pull/8544#discussion_r1538170755
##
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java:
##
@@ -397,10 +432,28 @@ public void process(InputStream in) throws IOException {
fos = codec.createOutputStream(fos);
}
createdFile = actualCopyFile;
-BufferedInputStream bis = new
BufferedInputStream(in);
-StreamUtils.copy(bis, fos);
-bis = null;
-fos.flush();
+
+final String appendMode =
context.getProperty(APPEND_MODE).getValue();
+if (APPEND_RESOLUTION.equals(conflictResponse)
+&& AVRO_APPEND_MODE.equals(appendMode)
+&& destinationExists) {
+getLogger().info("Appending avro record to
existing avro file");
+try (final var reader = new
DataFileStream<>(in, new GenericDatumReader<>());
Review Comment:
This won't backport to 1.x because `var` wasn't introduced until Java 10 and
we still have to support Java 8 on 1.x for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modfiy check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering ** Style regressions (NIFI-12946) * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag (NIFI-12950) * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu * Migrate NiFi UI to nx * Migrate from Karma
[jira] [Created] (NIFI-12950) Use uiOnly flag
Matt Gilman created NIFI-12950: -- Summary: Use uiOnly flag Key: NIFI-12950 URL: https://issues.apache.org/jira/browse/NIFI-12950 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman The REST API contains a number of endpoints that support a uiOnly flag. This flag prunes a number of details that are not needed by the UI at that point. This helps stabilize the usage of the UI when the flow size increases. The new UI work currently does not leverage this flag. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modfiy check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering ** Style regressions (NIFI-12946) * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Use polling interval from API * Load FlowConfiguration in guard (NIFI-12948) * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu * Migrate NiFi UI to nx * Migrate from Karma tests to Jest
[jira] [Commented] (NIFI-12947) Upgrade MIME4J to 0.8.11
[
https://issues.apache.org/jira/browse/NIFI-12947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830666#comment-17830666
]
ASF subversion and git services commented on NIFI-12947:
Commit 65ac492da077abce1add9639ebc60e203bbd1448 in nifi's branch
refs/heads/support/nifi-1.x from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=65ac492da0 ]
NIFI-12947 Upgraded MIME4J to 0.8.11
Signed-off-by: Pierre Villard
This closes #8561.
> Upgrade MIME4J to 0.8.11
>
>
> Key: NIFI-12947
> URL: https://issues.apache.org/jira/browse/NIFI-12947
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Labels: backport-needed
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Apache MIME4J should be upgraded to 0.8.11 to mitigate CVE-2024-21742 related
> to MIME message parsing. Apache MIME4J is a transitive dependency of the
> Apache Tika Parsers library used in the {{nifi-media-processors}} module.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12947) Upgrade MIME4J to 0.8.11
[
https://issues.apache.org/jira/browse/NIFI-12947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard updated NIFI-12947:
--
Fix Version/s: 2.0.0-M3
1.26.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Upgrade MIME4J to 0.8.11
>
>
> Key: NIFI-12947
> URL: https://issues.apache.org/jira/browse/NIFI-12947
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Labels: backport-needed
> Fix For: 2.0.0-M3, 1.26.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Apache MIME4J should be upgraded to 0.8.11 to mitigate CVE-2024-21742 related
> to MIME message parsing. Apache MIME4J is a transitive dependency of the
> Apache Tika Parsers library used in the {{nifi-media-processors}} module.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12947) Upgrade MIME4J to 0.8.11
[
https://issues.apache.org/jira/browse/NIFI-12947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830662#comment-17830662
]
ASF subversion and git services commented on NIFI-12947:
Commit 407dd4d4bcb0cbf6fec037ebe2ad99551b4ce067 in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=407dd4d4bc ]
NIFI-12947 Upgraded MIME4J to 0.8.11
Signed-off-by: Pierre Villard
This closes #8561.
> Upgrade MIME4J to 0.8.11
>
>
> Key: NIFI-12947
> URL: https://issues.apache.org/jira/browse/NIFI-12947
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Labels: backport-needed
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Apache MIME4J should be upgraded to 0.8.11 to mitigate CVE-2024-21742 related
> to MIME message parsing. Apache MIME4J is a transitive dependency of the
> Apache Tika Parsers library used in the {{nifi-media-processors}} module.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12947 Upgrade MIME4J to 0.8.11 [nifi]
asfgit closed pull request #8561: NIFI-12947 Upgrade MIME4J to 0.8.11 URL: https://github.com/apache/nifi/pull/8561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12939) Retry Kerberos login on authentication failure in Iceberg processors
[ https://issues.apache.org/jira/browse/NIFI-12939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-12939: Status: Patch Available (was: Open) > Retry Kerberos login on authentication failure in Iceberg processors > > > Key: NIFI-12939 > URL: https://issues.apache.org/jira/browse/NIFI-12939 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mark Bathori >Assignee: Mark Bathori >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When multiple processors trying to renew the same expired Kerberos ticket, it > can cause authentication error that will route the current FlowFile into the > processor's failure relation. Since the issue is not permanent the processor > should retry the authentication. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-1931 Add auto commit property to QueryDatabaseTable and QueryDatabaseTable [nifi]
mattyb149 commented on PR #8534: URL: https://github.com/apache/nifi/pull/8534#issuecomment-2018692390 +1 LGTM, merging to main. Thanks for the improvement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-1931 Add auto commit property to QueryDatabaseTable and QueryDatabaseTable [nifi]
mattyb149 closed pull request #8534: NIFI-1931 Add auto commit property to QueryDatabaseTable and QueryDatabaseTable URL: https://github.com/apache/nifi/pull/8534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-1931) QueryDatabaseTable processor; setFetchSize not working for postgres driver causing out of memory
[ https://issues.apache.org/jira/browse/NIFI-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-1931: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > QueryDatabaseTable processor; setFetchSize not working for postgres driver > causing out of memory > > > Key: NIFI-1931 > URL: https://issues.apache.org/jira/browse/NIFI-1931 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Paul Bormans >Assignee: Jim Steinebrey >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > With NIFI-1691 the ability to specify the fetch size is added. However for > postgres driver (or at least for postgresql-9.4.1208.jre6.jar) this seems not > to be working since after some time out of memory is reported in the logs. > See https://jdbc.postgresql.org/documentation/head/query.html also for some > constraints; like auto commit needs to be set to False. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-1931) QueryDatabaseTable processor; setFetchSize not working for postgres driver causing out of memory
[ https://issues.apache.org/jira/browse/NIFI-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830658#comment-17830658 ] ASF subversion and git services commented on NIFI-1931: --- Commit 08ff54f5fb712d01f372fd25a2d904d605e271ba in nifi's branch refs/heads/main from Jim Steinebrey [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=08ff54f5fb ] Add auto commit property to QueryDatabaseTable and QueryDatabaseTable processors to allow disabling auto commit so PostgreSQL Fetch Size will work NIFI-1931 Add proper default value for auto commit (false) to PostgreSQLDatabaseAdapter to allow FETCH_SIZE to be honored on reads. NIFI-1931 Added customValidate code to check the auto commit property setting against the db adapter's required auto commit setting and give validation error message if they do not match. NIFI-1931 Added automated test to check the Auto Commit customValidate error message. NIFI-1931 remove clearDefaultValue() because it is not needed since required = false a;ready defaults it to null. This closes #8534 Signed-off-by: Matt Burgess > QueryDatabaseTable processor; setFetchSize not working for postgres driver > causing out of memory > > > Key: NIFI-1931 > URL: https://issues.apache.org/jira/browse/NIFI-1931 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Paul Bormans >Assignee: Jim Steinebrey >Priority: Major > Fix For: 1.26.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > With NIFI-1691 the ability to specify the fetch size is added. However for > postgres driver (or at least for postgresql-9.4.1208.jre6.jar) this seems not > to be working since after some time out of memory is reported in the logs. > See https://jdbc.postgresql.org/documentation/head/query.html also for some > constraints; like auto commit needs to be set to False. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-1931) QueryDatabaseTable processor; setFetchSize not working for postgres driver causing out of memory
[ https://issues.apache.org/jira/browse/NIFI-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-1931: --- Fix Version/s: 1.26.0 > QueryDatabaseTable processor; setFetchSize not working for postgres driver > causing out of memory > > > Key: NIFI-1931 > URL: https://issues.apache.org/jira/browse/NIFI-1931 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Paul Bormans >Assignee: Jim Steinebrey >Priority: Major > Fix For: 1.26.0 > > Time Spent: 1h > Remaining Estimate: 0h > > With NIFI-1691 the ability to specify the fetch size is added. However for > postgres driver (or at least for postgresql-9.4.1208.jre6.jar) this seems not > to be working since after some time out of memory is reported in the logs. > See https://jdbc.postgresql.org/documentation/head/query.html also for some > constraints; like auto commit needs to be set to False. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-1931) QueryDatabaseTable processor; setFetchSize not working for postgres driver causing out of memory
[ https://issues.apache.org/jira/browse/NIFI-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830657#comment-17830657 ] ASF subversion and git services commented on NIFI-1931: --- Commit 15eeb1d5bc6816a76d27ad023795b5ac5368a55e in nifi's branch refs/heads/support/nifi-1.x from Jim Steinebrey [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=15eeb1d5bc ] NIFI-1931: Add auto commit property to QueryDatabaseTable and QueryDatabaseTable processors to allow disabling auto commit so PostgreSQL Fetch Size will work NIFI-1931 Add proper default value for auto commit (false) to PostgreSQLDatabaseAdapter to allow FETCH_SIZE to be honored on reads. NIFI-1931 Added customValidate code to check the auto commit property setting against the db adapter's required auto commit setting and give validation error message if they do not match. NIFI-1931 Fix for NiFI 1.X NIFI-1931 Added automated test to check the Auto Commit customValidate error message. NIFI-1931 Fix for NiFI 1.X Signed-off-by: Matt Burgess > QueryDatabaseTable processor; setFetchSize not working for postgres driver > causing out of memory > > > Key: NIFI-1931 > URL: https://issues.apache.org/jira/browse/NIFI-1931 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Paul Bormans >Assignee: Jim Steinebrey >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > With NIFI-1691 the ability to specify the fetch size is added. However for > postgres driver (or at least for postgresql-9.4.1208.jre6.jar) this seems not > to be working since after some time out of memory is reported in the logs. > See https://jdbc.postgresql.org/documentation/head/query.html also for some > constraints; like auto commit needs to be set to False. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-1931 Add auto commit property to QueryDatabaseTable and QueryDatabaseTable [nifi]
mattyb149 commented on PR #8549: URL: https://github.com/apache/nifi/pull/8549#issuecomment-2018689133 +1 LGTM, merged to support/nifi-1.x. Thanks for the improvement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-1931 Add auto commit property to QueryDatabaseTable and QueryDatabaseTable [nifi]
mattyb149 closed pull request #8549: NIFI-1931 Add auto commit property to QueryDatabaseTable and QueryDatabaseTable URL: https://github.com/apache/nifi/pull/8549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12948) UI - Address minor bugs discovered during Angular migration
[ https://issues.apache.org/jira/browse/NIFI-12948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12948: --- Assignee: Matt Gilman Status: Patch Available (was: Open) > UI - Address minor bugs discovered during Angular migration > --- > > Key: NIFI-12948 > URL: https://issues.apache.org/jira/browse/NIFI-12948 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > When migrating to Angular 17 and reviewing the control flow changes a handful > a bugs were discovered. This Jira is to address each of them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12948: Various bugs discovered when migrating to Angular 17 [nifi]
mcgilman opened a new pull request, #8564: URL: https://github.com/apache/nifi/pull/8564 NIFI-12948: - Action is optional. - Removing duplicate check in counter table. - Ensure flow configuration is loaded in route guard. - Only show user/group list when there are users or groups. - Default override policy to copy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12936) ListGCSBucket should reset its tracking state after configuration change
[ https://issues.apache.org/jira/browse/NIFI-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12936: -- Fix Version/s: 1.26.0 > ListGCSBucket should reset its tracking state after configuration change > > > Key: NIFI-12936 > URL: https://issues.apache.org/jira/browse/NIFI-12936 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Same as NIFI-12732 but for ListGCSBucket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12936) ListGCSBucket should reset its tracking state after configuration change
[ https://issues.apache.org/jira/browse/NIFI-12936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830650#comment-17830650 ] ASF subversion and git services commented on NIFI-12936: Commit e97431f0604fccad84c79048758eed567db117e1 in nifi's branch refs/heads/support/nifi-1.x from Peter Turcsanyi [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=e97431f060 ] NIFI-12936 ListGCSBucket resets its tracking state after configuration change Signed-off-by: Pierre Villard This closes #8563. > ListGCSBucket should reset its tracking state after configuration change > > > Key: NIFI-12936 > URL: https://issues.apache.org/jira/browse/NIFI-12936 > Project: Apache NiFi > Issue Type: Bug >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Same as NIFI-12732 but for ListGCSBucket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12936 Backport ListGCSBucket resets its tracking state after configuratio… [nifi]
pvillard31 closed pull request #8563: NIFI-12936 Backport ListGCSBucket resets its tracking state after configuratio… URL: https://github.com/apache/nifi/pull/8563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12949) Upgrade Box SDK to 4.8.0
David Handermann created NIFI-12949: --- Summary: Upgrade Box SDK to 4.8.0 Key: NIFI-12949 URL: https://issues.apache.org/jira/browse/NIFI-12949 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: David Handermann Assignee: David Handermann The Box Java SDK should be upgraded to [4.8.0|https://github.com/box/box-java-sdk/releases/tag/v4.8.0] to incorporate several transitive dependency upgrades, including more recent Bouncy Castle dependency coordinates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12944) Add attribute corresponding to peer address of SNMP TRAP PDUs
[ https://issues.apache.org/jira/browse/NIFI-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12944: -- Component/s: Extensions > Add attribute corresponding to peer address of SNMP TRAP PDUs > -- > > Key: NIFI-12944 > URL: https://issues.apache.org/jira/browse/NIFI-12944 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Ricardo Ferreira >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Add attribute corresponding to peer address of SNMP traps that are received. > This is useful to determine where a trap originated from, as not all SNMPv2 > traps include an OID that identifies the sender. > The information is placed in the attribute with name snmp$peerAddress -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-12944) Add attribute corresponding to peer address of SNMP TRAP PDUs
[ https://issues.apache.org/jira/browse/NIFI-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-12944. --- Fix Version/s: 2.0.0-M3 1.26.0 Resolution: Fixed > Add attribute corresponding to peer address of SNMP TRAP PDUs > -- > > Key: NIFI-12944 > URL: https://issues.apache.org/jira/browse/NIFI-12944 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Ricardo Ferreira >Priority: Major > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Add attribute corresponding to peer address of SNMP traps that are received. > This is useful to determine where a trap originated from, as not all SNMPv2 > traps include an OID that identifies the sender. > The information is placed in the attribute with name snmp$peerAddress -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12944) Add attribute corresponding to peer address of SNMP TRAP PDUs
[ https://issues.apache.org/jira/browse/NIFI-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830645#comment-17830645 ] ASF subversion and git services commented on NIFI-12944: Commit 258715539e7cf136152625aeafee5a2f8673eacd in nifi's branch refs/heads/main from Ricardo Ferreira [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=258715539e ] NIFI-12944 - Add PeerAddress as Attribute into the flowfile Signed-off-by: Pierre Villard This closes #8557. > Add attribute corresponding to peer address of SNMP TRAP PDUs > -- > > Key: NIFI-12944 > URL: https://issues.apache.org/jira/browse/NIFI-12944 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Ricardo Ferreira >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Add attribute corresponding to peer address of SNMP traps that are received. > This is useful to determine where a trap originated from, as not all SNMPv2 > traps include an OID that identifies the sender. > The information is placed in the attribute with name snmp$peerAddress -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12944) Add attribute corresponding to peer address of SNMP TRAP PDUs
[ https://issues.apache.org/jira/browse/NIFI-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830646#comment-17830646 ] ASF subversion and git services commented on NIFI-12944: Commit 3ce2deb706247bbc17bc65304f0b41f4c2fabb5c in nifi's branch refs/heads/support/nifi-1.x from Ricardo Ferreira [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3ce2deb706 ] NIFI-12944 - Add PeerAddress as Attribute into the flowfile Signed-off-by: Pierre Villard This closes #8557. > Add attribute corresponding to peer address of SNMP TRAP PDUs > -- > > Key: NIFI-12944 > URL: https://issues.apache.org/jira/browse/NIFI-12944 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Ricardo Ferreira >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Add attribute corresponding to peer address of SNMP traps that are received. > This is useful to determine where a trap originated from, as not all SNMPv2 > traps include an OID that identifies the sender. > The information is placed in the attribute with name snmp$peerAddress -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12944 Add attribute corresponding to peer address of SNMP TRAP PDUs [nifi]
asfgit closed pull request #8557: NIFI-12944 Add attribute corresponding to peer address of SNMP TRAP PDUs URL: https://github.com/apache/nifi/pull/8557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12936 Backport ListGCSBucket resets its tracking state after configuratio… [nifi]
turcsanyip opened a new pull request, #8563: URL: https://github.com/apache/nifi/pull/8563 …n change # Summary [NIFI-12936](https://issues.apache.org/jira/browse/NIFI-12936) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modfiy check (NIFI-12948) * Bulletin Board (NIFI-12560) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering ** Style regressions (NIFI-12946) * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Use polling interval from API * Load FlowConfiguration in guard * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow Analysis report menu * Migrate NiFi UI to nx * Migrate from Karma tests to Jest (NIFI-12941)
[PR] Added SSL context property to PutSNS, DeleteSQS, GetSQS, and PutSQS [nifi]
Freedom9339 opened a new pull request, #8562: URL: https://github.com/apache/nifi/pull/8562 # Summary [NIFI-6379](https://issues.apache.org/jira/browse/NIFI-6379) - Added SSL Context Service to PutSNS, DeleteSQS, GetSQS, and PutSQS. This PR is for 1.x # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12928) Add Simple Write strategy in PutAzureDataLakeStorage
[ https://issues.apache.org/jira/browse/NIFI-12928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12928: -- Fix Version/s: 1.26.0 > Add Simple Write strategy in PutAzureDataLakeStorage > > > Key: NIFI-12928 > URL: https://issues.apache.org/jira/browse/NIFI-12928 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Minor > Fix For: 2.0.0-M3, 1.26.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > NIFI-8248 introduced temporary location for file uploads in > PutAzureDataLakeStorage. The file is uploaded into a temporary directory > first and then moved to the final location. > The motivation behind this was that the file upload with Azure client API is > a 2-step process: first an empty file is created, then the content is > uploaded. The unfinished empty file would be available for listing / > fetching. Also, if the put processor is in 'replace' mode and the uploading > fails, then old content is lost as the file was already cleared. > However, this behaviour is not desired in all cases and writing the file > directly to its final location would be preferred. E.g. when ACL is used for > permission handling and the temporary folder would need extra administration > (and the files are not listed/read in parallel so there is no issue with the > partially written files). > Add 'Writing Strategy' property with 'Write and Rename' (current behaviour, > default) and 'Simple Write' options. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12928) Add Simple Write strategy in PutAzureDataLakeStorage
[ https://issues.apache.org/jira/browse/NIFI-12928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830625#comment-17830625 ] ASF subversion and git services commented on NIFI-12928: Commit 87196e23d651fa6edeae364c2189a7779e39060e in nifi's branch refs/heads/support/nifi-1.x from Peter Turcsanyi [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=87196e23d6 ] NIFI-12928 Added Simple Write strategy in PutAzureDataLakeStorage Signed-off-by: Pierre Villard This closes #8559. > Add Simple Write strategy in PutAzureDataLakeStorage > > > Key: NIFI-12928 > URL: https://issues.apache.org/jira/browse/NIFI-12928 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Minor > Fix For: 2.0.0-M3 > > Time Spent: 1.5h > Remaining Estimate: 0h > > NIFI-8248 introduced temporary location for file uploads in > PutAzureDataLakeStorage. The file is uploaded into a temporary directory > first and then moved to the final location. > The motivation behind this was that the file upload with Azure client API is > a 2-step process: first an empty file is created, then the content is > uploaded. The unfinished empty file would be available for listing / > fetching. Also, if the put processor is in 'replace' mode and the uploading > fails, then old content is lost as the file was already cleared. > However, this behaviour is not desired in all cases and writing the file > directly to its final location would be preferred. E.g. when ACL is used for > permission handling and the temporary folder would need extra administration > (and the files are not listed/read in parallel so there is no issue with the > partially written files). > Add 'Writing Strategy' property with 'Write and Rename' (current behaviour, > default) and 'Simple Write' options. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12928 Backport Added Simple Write strategy in PutAzureDataLakeStorage [nifi]
pvillard31 closed pull request #8559: NIFI-12928 Backport Added Simple Write strategy in PutAzureDataLakeStorage URL: https://github.com/apache/nifi/pull/8559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination (NIFI-12552) * Counters (NIFI-12415) ** Counter table has extra unnecessary can modfiy check (NIFI-12948) * Bulletin Board (NIFI-12560) ** When the bulletin board polls it is missing the offset "after" query parameter (NIFI-12948) * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) ** Clustering (NIFI-12807) * Configure Reporting Task (NIFI-12563) * Flow Analysis Rules (NIFI-12588) * Registry Clients (NIFI-12486) * Import from Registry (NIFI-12734) * Parameter Providers (NIFI-12622) ** Fetch parameters from provider, map to parameter context (dialog) - (NIFI-12665) * Cluster ** Status History - node specific values (NIFI-12848) * Flow Configuration History (NIFI-12754) ** ActionEntity.action should be optional (NIFI-12948) * Node Status History (NIFI-12553) * Status history for components from canvas context menu (NIFI-12553) * Users (NIFI-12543) ** Don't show users or groups in create/edit dialog is there are none (NIFI-12948) * Policies (NIFI-12548) ** Overridden policy Empty or Copy (NIFI-12679) ** Select Empty by default (NIFI-12948) * Help (NIFI-12795) * About * Show Upstream/Downstream * Align * List Queue (NIFI-12589) ** Clustering (NIFI-12807) * Empty [all] Queue (NIFI-12604) * View Content (NIFI-12589 and NIFI-12445) * View State (NIFI-12611) ** Clustering ** Style regressions (NIFI-12946) * Change Component Version * Consider PG permissions in Toolbox (NIFI-12683) * Handle linking to components that are not on the canvas * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs ** Disable and Configure * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) ** Fix issue with Property Editor width (NIFI-12547) ** Stop and Configure ** Open Custom UI ** Property History ** Unable to re-add any removed Property (NIFI-12743) ** Shift-Enter new line when editing Property (NIFI-12743) * Property Verification * More Details (Processor, Controller Service, Reporting Task) * Download Flow * Create RPG (NIFI-12758) * Configure RPG (NIFI-12774) * RPG Remote Ports (NIFI-12778) * RPG Go To (NIFI-12759) * RPG Refresh (NIFI-12761) * Color * Move to Front * Copy/Paste * Add/Update Info Icons in dialogs throughout the application * Set viewport earlier when loading a Process Group (NIFI-12737) * Canvas global menu item should navigate user back to where they were on the canvas (NIFI-12737) * Better theme support (NIFI-12655) * Set up development/production environments files * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Use polling interval from API * Load FlowConfiguration in guard * Routing error handling * General API response error handling ** Management CS (NIFI-12663) ** Canvas CS (NIFI-12684) ** Remainder of Settings (NIFI-12723) ** Counters (NIFI-12723) ** Bulletins (NIFI-12723) ** Flow Designer ** Parameter Contexts (NIFI-12937) ** Provenance (NIFI-12767) ** Queue Listing (NIFI-12742) ** Summary (NIFI-12742) ** Users (NIFI-12742) ** Policies ** Status History * Introduce header in new pages to unify with canvas and offer better navigation. (NIFI-12597) * Theme docs, view flow file, and custom ui's * Prompt user to save Parameter Context when Edit form is dirty * Upgrade to Angular 17 (NIFI-12790) * Start/Stop processors, process groups, ... (NIFI-12568) * Dialog vertical resizing on smaller screens do not allow users to access all fields (NIFI-12603) * Flow
[jira] [Created] (NIFI-12948) UI - Address minor bugs discovered during Angular migration
Matt Gilman created NIFI-12948: -- Summary: UI - Address minor bugs discovered during Angular migration Key: NIFI-12948 URL: https://issues.apache.org/jira/browse/NIFI-12948 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman When migrating to Angular 17 and reviewing the control flow changes a handful a bugs were discovered. This Jira is to address each of them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12947) Upgrade MIME4J to 0.8.11
[
https://issues.apache.org/jira/browse/NIFI-12947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12947:
Status: Patch Available (was: Open)
> Upgrade MIME4J to 0.8.11
>
>
> Key: NIFI-12947
> URL: https://issues.apache.org/jira/browse/NIFI-12947
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Labels: backport-needed
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Apache MIME4J should be upgraded to 0.8.11 to mitigate CVE-2024-21742 related
> to MIME message parsing. Apache MIME4J is a transitive dependency of the
> Apache Tika Parsers library used in the {{nifi-media-processors}} module.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
