[GitHub] [nifi] NissimShiman opened a new pull request, #6873: NIFI-11041 Convert nifi-registry to use JUnit5 - Part 1

2023-01-20 Thread GitBox
NissimShiman opened a new pull request, #6873: URL: https://github.com/apache/nifi/pull/6873 # Summary [NIFI-11041](https://issues.apache.org/jira/browse/NIFI-11041) # Tracking Please complete the following tracking

[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1495: MINIFICPP-2036 Upgrade gcc to version 11

2023-01-20 Thread GitBox
fgerlits opened a new pull request, #1495: URL: https://github.com/apache/nifi-minifi-cpp/pull/1495 - on centos: use devtoolset-11 instead of devtoolset-10 - on alpine: use version 3.16 instead of 3.13 - on both: do not install the boost package, as it is no longer required ---

[GitHub] [nifi] bbende opened a new pull request, #6872: NIFI-11075 Add additional fields to C2 component definition model

2023-01-20 Thread GitBox
bbende opened a new pull request, #6872: URL: https://github.com/apache/nifi/pull/6872 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-01-20 Thread GitBox
szaszm commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1082808190 ## extensions/mqtt/processors/PublishMQTT.h: ## @@ -62,72 +68,116 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi] nandorsoma commented on a diff in pull request #6861: NIFI-11068 Introduce ConflictResolutionStrategy enum

2023-01-20 Thread GitBox
nandorsoma commented on code in PR #6861: URL: https://github.com/apache/nifi/pull/6861#discussion_r1082793187 ## nifi-nar-bundles/nifi-extension-utils/nifi-conflict-resolution/src/main/java/org/apache/nifi/processors/conflictresolution/ConflictResolutionStrategy.java: ## @@

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-01-20 Thread GitBox
fgerlits commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1082700681 ## extensions/mqtt/processors/PublishMQTT.h: ## @@ -62,72 +68,116 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request, #1494: MINIFICPP-2035 - NiFi flow json configuration format support

2023-01-20 Thread GitBox
adamdebreceni opened a new pull request, #1494: URL: https://github.com/apache/nifi-minifi-cpp/pull/1494 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] [nifi] nandorsoma commented on a diff in pull request #6832: NIFI-10965 PutGoogleDrive

2023-01-20 Thread GitBox
nandorsoma commented on code in PR #6832: URL: https://github.com/apache/nifi/pull/6832#discussion_r1082584151 ## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/PutGoogleDrive.java: ## @@ -0,0 +1,495 @@ +/* + * Licensed

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1461: MINIFICPP-1983 Mount files in MiNiFi test containers and additional refactoring

2023-01-20 Thread GitBox
szaszm commented on code in PR #1461: URL: https://github.com/apache/nifi-minifi-cpp/pull/1461#discussion_r1082582759 ## docker/test/integration/cluster/checkers/AzureChecker.py: ## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1461: MINIFICPP-1983 Mount files in MiNiFi test containers and additional refactoring

2023-01-20 Thread GitBox
szaszm commented on code in PR #1461: URL: https://github.com/apache/nifi-minifi-cpp/pull/1461#discussion_r1082555652 ## docker/test/integration/cluster/checkers/AzureChecker.py: ## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [nifi] mr1716 opened a new pull request, #6871: NIFI-11072 Update xz to 1.9

2023-01-20 Thread GitBox
mr1716 opened a new pull request, #6871: URL: https://github.com/apache/nifi/pull/6871 # Summary [NIFI-11072](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1461: MINIFICPP-1983 Mount files in MiNiFi test containers and additional refactoring

2023-01-20 Thread GitBox
lordgamez commented on code in PR #1461: URL: https://github.com/apache/nifi-minifi-cpp/pull/1461#discussion_r1082521737 ## docker/test/integration/cluster/checkers/AzureChecker.py: ## @@ -0,0 +1,70 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [nifi] asfgit closed pull request #6797: NIFI-10992 - Option to build all include-x profiles

2023-01-20 Thread GitBox
asfgit closed pull request #6797: NIFI-10992 - Option to build all include-x profiles URL: https://github.com/apache/nifi/pull/6797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-01-20 Thread GitBox
szaszm commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1082493995 ## extensions/mqtt/processors/PublishMQTT.h: ## @@ -62,72 +68,116 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-01-20 Thread GitBox
fgerlits commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1082481990 ## extensions/mqtt/processors/PublishMQTT.h: ## @@ -62,72 +68,116 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi] mr1716 closed pull request #6866: NIFI-11072 Update xz to 1.9

2023-01-20 Thread GitBox
mr1716 closed pull request #6866: NIFI-11072 Update xz to 1.9 URL: https://github.com/apache/nifi/pull/6866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [nifi] simonbence opened a new pull request, #6870: NIFI-10973 Introduce differention of comparing embedded versioned flows for UI and synchronisation purposes

2023-01-20 Thread GitBox
simonbence opened a new pull request, #6870: URL: https://github.com/apache/nifi/pull/6870 Comparison of the flows is used for multiple purposes, including synchronisation and to inform users. In some cases we want to include actual changes of the embedded versioned flows, in other cases

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-01-20 Thread GitBox
szaszm commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1082401665 ## extensions/mqtt/processors/PublishMQTT.h: ## @@ -62,72 +68,116 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-01-20 Thread GitBox
szaszm commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1082400747 ## extensions/mqtt/processors/PublishMQTT.h: ## @@ -62,72 +68,116 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi] timeabarna commented on pull request #6869: NIFI-11079 Extend QueryNifiReportingTask and ProcessGroup Summary Table

2023-01-19 Thread GitBox
timeabarna commented on PR #6869: URL: https://github.com/apache/nifi/pull/6869#issuecomment-1397996848 Hello @sardell and @mattyb149, Can you please help me reviewing this PR? Thanks in advance for your help. -- This is an automated message from the Apache Git Service. To

[GitHub] [nifi] timeabarna opened a new pull request, #6869: NIFI-11079 Extend QueryNifiReportingTask and ProcessGroup Summary Table

2023-01-19 Thread GitBox
timeabarna opened a new pull request, #6869: URL: https://github.com/apache/nifi/pull/6869 # Summary [NIFI-11079](https://issues.apache.org/jira/browse/NIFI-11079) Add Total Task Duration and Total Active Thread Count to QueryNiFiReportingTask and ProcessGroup Summary Table.

[GitHub] [nifi] gresockj opened a new pull request, #6868: NIFI-11039: Fixing bug when importing parameter providers from nifi-registry

2023-01-19 Thread GitBox
gresockj opened a new pull request, #6868: URL: https://github.com/apache/nifi/pull/6868 # Summary [NIFI-11039](https://issues.apache.org/jira/browse/NIFI-11039) # Tracking Please complete the following tracking steps

[GitHub] [nifi] pvillard31 commented on pull request #6797: NIFI-10992 - Option to build all include-x profiles

2023-01-19 Thread GitBox
pvillard31 commented on PR #6797: URL: https://github.com/apache/nifi/pull/6797#issuecomment-1397578647 Added a couple of lines in the admin guide. Thanks for reviewing @ChrisSamo632 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [nifi] asfgit closed pull request #6863: NIFI-11064 Change TestPutSFTP run iterations based on files queued

2023-01-19 Thread GitBox
asfgit closed pull request #6863: NIFI-11064 Change TestPutSFTP run iterations based on files queued URL: https://github.com/apache/nifi/pull/6863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] exceptionfactory closed pull request #6864: NIFI-11073 Update mysql-connector-java to 8.0.32

2023-01-19 Thread GitBox
exceptionfactory closed pull request #6864: NIFI-11073 Update mysql-connector-java to 8.0.32 URL: https://github.com/apache/nifi/pull/6864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] exceptionfactory closed pull request #6862: NIFI-11074 Update mariadb-java-client to 3.1.1

2023-01-19 Thread GitBox
exceptionfactory closed pull request #6862: NIFI-11074 Update mariadb-java-client to 3.1.1 URL: https://github.com/apache/nifi/pull/6862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] exceptionfactory commented on pull request #6867: NIFI-10580 Upgrade SLF4J from 1.7.36 to 2.0.6

2023-01-19 Thread GitBox
exceptionfactory commented on PR #6867: URL: https://github.com/apache/nifi/pull/6867#issuecomment-1397539787 > very cool. So " so disabling the initialization using a System property resolves startup issues" - with this our logging and such for the registry still works we just bypass

[GitHub] [nifi] joewitt commented on pull request #6867: NIFI-10580 Upgrade SLF4J from 1.7.36 to 2.0.6

2023-01-19 Thread GitBox
joewitt commented on PR #6867: URL: https://github.com/apache/nifi/pull/6867#issuecomment-1397536783 very cool. So " so disabling the initialization using a System property resolves startup issues" - with this our logging and such for the registry still works we just bypass springs

[GitHub] [nifi] exceptionfactory opened a new pull request, #6867: NIFI-10580 Upgrade SLF4J from 1.7.36 to 2.0.6

2023-01-19 Thread GitBox
exceptionfactory opened a new pull request, #6867: URL: https://github.com/apache/nifi/pull/6867 # Summary [NIFI-10580](https://issues.apache.org/jira/browse/NIFI-10580) Upgrades SLF4J from 1.7.36 to 2.0.6 and upgrades Logback from 1.2.11 to 1.3.5. SLF4J 2.0 does not introduce

[GitHub] [nifi] mr1716 opened a new pull request, #6866: NIFI-11072 Update xz to 1.9

2023-01-19 Thread GitBox
mr1716 opened a new pull request, #6866: URL: https://github.com/apache/nifi/pull/6866 # Summary [NIFI-11072](https://issues.apache.org/jira/browse/NIFI-11072) # Tracking Please complete the following tracking steps

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6847: NIFI-11057 - add NAR provider nifi-registry

2023-01-19 Thread GitBox
exceptionfactory commented on code in PR #6847: URL: https://github.com/apache/nifi/pull/6847#discussion_r1081685160 ## nifi-docker/dockerhub/sh/start.sh: ## @@ -97,6 +97,13 @@ prop_replace 'nifi.analytics.connection.model.implementation' "${NIFI_ANALYTIC prop_replace

[GitHub] [nifi] gresockj opened a new pull request, #6865: NIFI-11076: Resolving deadlock issue in StandardParameterContext

2023-01-19 Thread GitBox
gresockj opened a new pull request, #6865: URL: https://github.com/apache/nifi/pull/6865 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps

[GitHub] [nifi] mr1716 opened a new pull request, #6864: NIFI-11073 Update mysql-connector-java to 8.0.32

2023-01-19 Thread GitBox
mr1716 opened a new pull request, #6864: URL: https://github.com/apache/nifi/pull/6864 # Summary [NIFI-11073](https://issues.apache.org/jira/browse/NIFI-11073) # Tracking Please complete the following tracking steps

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-01-19 Thread GitBox
fgerlits commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1081545367 ## extensions/mqtt/processors/PublishMQTT.cpp: ## @@ -29,81 +29,240 @@ namespace org::apache::nifi::minifi::processors { +using SendFinishedTask =

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-01-19 Thread GitBox
fgerlits commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1081544979 ## extensions/mqtt/processors/PublishMQTT.h: ## @@ -62,72 +68,116 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-01-19 Thread GitBox
fgerlits commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1081544538 ## extensions/mqtt/processors/PublishMQTT.h: ## @@ -62,72 +68,116 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi] asfgit closed pull request #6855: NIFI-11069 PutDropbox: remove upload cancellation, unify conflict res…

2023-01-19 Thread GitBox
asfgit closed pull request #6855: NIFI-11069 PutDropbox: remove upload cancellation, unify conflict res… URL: https://github.com/apache/nifi/pull/6855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [nifi] pvillard31 commented on pull request #6794: NIFI-10966: Add option to QuerySalesforceObject to run custom query

2023-01-19 Thread GitBox
pvillard31 commented on PR #6794: URL: https://github.com/apache/nifi/pull/6794#issuecomment-1397265977 Hi - I've been playing with this and it works as expected (except that SOQL is super hard to understand...). One improvement I'd like to see is that the processor should accept input

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-01-19 Thread GitBox
fgerlits commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1081478085 ## extensions/mqtt/processors/PublishMQTT.h: ## @@ -62,72 +68,116 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi] exceptionfactory opened a new pull request, #6863: NIFI-11064 Change TestPutSFTP run iterations based on files queued

2023-01-19 Thread GitBox
exceptionfactory opened a new pull request, #6863: URL: https://github.com/apache/nifi/pull/6863 # Summary [NIFI-11064](https://issues.apache.org/jira/browse/NIFI-11064) Changes `TestPutSFTP.testRunTransitUriDifferentHosts()` to run multiple times for improved test stability. The

[GitHub] [nifi] tpalfy commented on pull request #6762: NIFI-10953: Implement GCP Vision AI processors

2023-01-19 Thread GitBox
tpalfy commented on PR #6762: URL: https://github.com/apache/nifi/pull/6762#issuecomment-1397157447 LGTM Thank you for your work @KalmanJantner ! Merged into main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [nifi] asfgit closed pull request #6762: NIFI-10953: Implement GCP Vision AI processors

2023-01-19 Thread GitBox
asfgit closed pull request #6762: NIFI-10953: Implement GCP Vision AI processors URL: https://github.com/apache/nifi/pull/6762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [nifi] mr1716 opened a new pull request, #6862: NIFI-11074 Update mariadb-java-client to 3.1.1

2023-01-19 Thread GitBox
mr1716 opened a new pull request, #6862: URL: https://github.com/apache/nifi/pull/6862 # Summary [NIFI-11074](https://issues.apache.org/jira/browse/NIFI-11074) # Tracking Please complete the following tracking steps

[GitHub] [nifi] asfgit closed pull request #6845: NIFI-11050 In PutEmail added OAuth authorization option.

2023-01-19 Thread GitBox
asfgit closed pull request #6845: NIFI-11050 In PutEmail added OAuth authorization option. URL: https://github.com/apache/nifi/pull/6845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] djeanprost commented on pull request #6847: NIFI-11057 - add NAR provider nifi-registry

2023-01-19 Thread GitBox
djeanprost commented on PR #6847: URL: https://github.com/apache/nifi/pull/6847#issuecomment-1397074044 hello, is this PR miss something to be accepted, or is it just a question of time for someone to have a look at it ? Thanks  -- This is an automated message from the Apache

[GitHub] [nifi] nandorsoma commented on pull request #6846: NIFI-10991 Add AWS MSK IAM support to Kafka processors

2023-01-19 Thread GitBox
nandorsoma commented on PR #6846: URL: https://github.com/apache/nifi/pull/6846#issuecomment-1397060296 Thanks for noticing it @turcsanyip! I've changed the code, tested it with the 3 different Kerberos config methods. -- This is an automated message from the Apache Git Service. To

[GitHub] [nifi] krisztina-zsihovszki opened a new pull request, #6861: NIFI-11068 Introduce ConflictResolutionStrategy enum

2023-01-19 Thread GitBox
krisztina-zsihovszki opened a new pull request, #6861: URL: https://github.com/apache/nifi/pull/6861 # Summary [NIFI-11068](https://issues.apache.org/jira/browse/NIFI-11068) # Tracking Please complete the following

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1461: MINIFICPP-1983 Mount files in MiNiFi test containers and additional refactoring

2023-01-19 Thread GitBox
szaszm commented on code in PR #1461: URL: https://github.com/apache/nifi-minifi-cpp/pull/1461#discussion_r1081182871 ## docker/test/integration/cluster/checkers/AzureChecker.py: ## @@ -0,0 +1,70 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [nifi] mark-bathori commented on a diff in pull request #6783: NIFI-10974: Incorrect warning message on memory usage from MonitorMemory

2023-01-19 Thread GitBox
mark-bathori commented on code in PR #6783: URL: https://github.com/apache/nifi/pull/6783#discussion_r1081178611 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java: ## @@ -218,7 +218,11 @@ public

[GitHub] [nifi] asfgit closed pull request #6842: NIFI-11051 Corrected handling of empty Registry host property

2023-01-19 Thread GitBox
asfgit closed pull request #6842: NIFI-11051 Corrected handling of empty Registry host property URL: https://github.com/apache/nifi/pull/6842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] asfgit closed pull request #6856: NIFI-11033: Update QueryNiFiReportingTask additionalDetails page to include Flow Config History table

2023-01-19 Thread GitBox
asfgit closed pull request #6856: NIFI-11033: Update QueryNiFiReportingTask additionalDetails page to include Flow Config History table URL: https://github.com/apache/nifi/pull/6856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [nifi] asfgit closed pull request #6860: NIFI-11071 Update json-flattener to 0.16.4

2023-01-19 Thread GitBox
asfgit closed pull request #6860: NIFI-11071 Update json-flattener to 0.16.4 URL: https://github.com/apache/nifi/pull/6860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] asfgit closed pull request #6857: NIFI-11070 Update json-schema-validator to 1.0.76

2023-01-19 Thread GitBox
asfgit closed pull request #6857: NIFI-11070 Update json-schema-validator to 1.0.76 URL: https://github.com/apache/nifi/pull/6857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] asfgit closed pull request #6859: NIFI-11042 Update msal4j to 1.13.3

2023-01-19 Thread GitBox
asfgit closed pull request #6859: NIFI-11042 Update msal4j to 1.13.3 URL: https://github.com/apache/nifi/pull/6859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1461: MINIFICPP-1983 Mount files in MiNiFi test containers and additional refactoring

2023-01-19 Thread GitBox
adamdebreceni commented on code in PR #1461: URL: https://github.com/apache/nifi-minifi-cpp/pull/1461#discussion_r1080974318 ## docker/test/integration/cluster/checkers/PostgresChecker.py: ## @@ -0,0 +1,18 @@ +import time + + +class PostgresChecker: +def __init__(self,

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1461: MINIFICPP-1983 Mount files in MiNiFi test containers and additional refactoring

2023-01-19 Thread GitBox
lordgamez commented on code in PR #1461: URL: https://github.com/apache/nifi-minifi-cpp/pull/1461#discussion_r1080939840 ## docker/test/integration/cluster/checkers/PostgresChecker.py: ## @@ -0,0 +1,18 @@ +import time + + +class PostgresChecker: +def __init__(self,

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1461: MINIFICPP-1983 Mount files in MiNiFi test containers and additional refactoring

2023-01-19 Thread GitBox
lordgamez commented on code in PR #1461: URL: https://github.com/apache/nifi-minifi-cpp/pull/1461#discussion_r1080937969 ## docker/test/integration/cluster/containers/Container.py: ## @@ -63,13 +63,25 @@ def log_source(self): return LogSource.FROM_DOCKER_CONTAINER

[GitHub] [nifi] mr1716 opened a new pull request, #6860: NIFI-11071 Update json-flattener to 0.16.4

2023-01-18 Thread GitBox
mr1716 opened a new pull request, #6860: URL: https://github.com/apache/nifi/pull/6860 # Summary [NIFI-11071](https://issues.apache.org/jira/browse/NIFI-11071) # Tracking Please complete the following tracking steps

[GitHub] [nifi] asfgit closed pull request #6858: NIFI-11048 Add FileNameCompleter to avoid style parsing failures

2023-01-18 Thread GitBox
asfgit closed pull request #6858: NIFI-11048 Add FileNameCompleter to avoid style parsing failures URL: https://github.com/apache/nifi/pull/6858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1432: MINIFICPP-1840 - Add support for MQTT 5

2023-01-18 Thread GitBox
szaszm commented on code in PR #1432: URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1073689675 ## extensions/mqtt/processors/PublishMQTT.h: ## @@ -62,72 +68,116 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi] joewitt commented on pull request #6858: NIFI-11048 Add FileNameCompleter to avoid style parsing failures

2023-01-18 Thread GitBox
joewitt commented on PR #6858: URL: https://github.com/apache/nifi/pull/6858#issuecomment-1387728368 I have confirmed in the original env that started this issue that the build now works. I also verified on local osx. Let's see how the github actions execute. Otherwise this looks good

[GitHub] [nifi] mr1716 opened a new pull request, #6859: NIFI-11042 Update msal4j to 1.13.3

2023-01-18 Thread GitBox
mr1716 opened a new pull request, #6859: URL: https://github.com/apache/nifi/pull/6859 # Summary [NIFI-11042](https://issues.apache.org/jira/browse/NIFI-11042) # Tracking Please complete the following tracking steps

[GitHub] [nifi] exceptionfactory closed pull request #6858: NIFI-11048 Add FileNameCompleter to avoid style parsing failures

2023-01-18 Thread GitBox
exceptionfactory closed pull request #6858: NIFI-11048 Add FileNameCompleter to avoid style parsing failures URL: https://github.com/apache/nifi/pull/6858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1459: MINIFICPP-1987 Configuring processor metrics with regular expressions

2023-01-18 Thread GitBox
fgerlits closed pull request #1459: MINIFICPP-1987 Configuring processor metrics with regular expressions URL: https://github.com/apache/nifi-minifi-cpp/pull/1459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1473: MINIFICPP-1973 Refactor ResourceQueue

2023-01-18 Thread GitBox
fgerlits closed pull request #1473: MINIFICPP-1973 Refactor ResourceQueue URL: https://github.com/apache/nifi-minifi-cpp/pull/1473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] exceptionfactory opened a new pull request, #6858: NIFI-11048 Add FileNameCompleter to avoid style parsing failures

2023-01-18 Thread GitBox
exceptionfactory opened a new pull request, #6858: URL: https://github.com/apache/nifi/pull/6858 # Summary [NIFI-11048](https://issues.apache.org/jira/browse/NIFI-11048) Adds a custom `StandardFileNameCompleter` in `nifi-toolkit-cli` to avoid hanging on regular expression parsing of

[GitHub] [nifi] mr1716 opened a new pull request, #6857: NIFI-11070 Update json-schema-validator to 1.0.76

2023-01-18 Thread GitBox
mr1716 opened a new pull request, #6857: URL: https://github.com/apache/nifi/pull/6857 # Summary [NIFI-11070](https://issues.apache.org/jira/browse/NIFI-11070) # Tracking Please complete the following tracking steps

[GitHub] [nifi] mattyb149 opened a new pull request, #6856: NIFI-11033: Update QueryNiFiReportingTask additionalDetails page to include Flow Config History table

2023-01-18 Thread GitBox
mattyb149 opened a new pull request, #6856: URL: https://github.com/apache/nifi/pull/6856 # Summary [NIFI-11033](https://issues.apache.org/jira/browse/NIFI-11033) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1458: MINIFICPP-1991 - Remove unused ControllerServiceProvider methods

2023-01-18 Thread GitBox
fgerlits closed pull request #1458: MINIFICPP-1991 - Remove unused ControllerServiceProvider methods URL: https://github.com/apache/nifi-minifi-cpp/pull/1458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1486: MINIFICPP-2026 Make isRunning member functions const

2023-01-18 Thread GitBox
fgerlits closed pull request #1486: MINIFICPP-2026 Make isRunning member functions const URL: https://github.com/apache/nifi-minifi-cpp/pull/1486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] turcsanyip commented on pull request #6855: NIFI-11069 PutDropbox: remove upload cancellation, unify conflict res…

2023-01-18 Thread GitBox
turcsanyip commented on PR #6855: URL: https://github.com/apache/nifi/pull/6855#issuecomment-1387391828 @krisztina-zsihovszki Thanks for these enhancements around PutDropbox! The code looks good to me. Will run the ITs and some flows. The removal of the upload cancellation could be

[GitHub] [nifi] KalmanJantner commented on a diff in pull request #6762: NIFI-10953: Implement GCP Vision AI processors

2023-01-18 Thread GitBox
KalmanJantner commented on code in PR #6762: URL: https://github.com/apache/nifi/pull/6762#discussion_r1073769757 ##

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1466: MINIFICPP-1994 - Route flowfiles with invalid SQL to Failure

2023-01-18 Thread GitBox
adamdebreceni commented on code in PR #1466: URL: https://github.com/apache/nifi-minifi-cpp/pull/1466#discussion_r1073766411 ## libminifi/test/TestBase.cpp: ## @@ -234,12 +234,16 @@ std::shared_ptr TestPlan::addProcessor(const std::share

[GitHub] [nifi] krisztina-zsihovszki commented on a diff in pull request #6832: NIFI-10965 PutGoogleDrive

2023-01-18 Thread GitBox
krisztina-zsihovszki commented on code in PR #6832: URL: https://github.com/apache/nifi/pull/6832#discussion_r1073754443 ## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/PutGoogleDrive.java: ## @@ -0,0 +1,495 @@ +/* + *

[GitHub] [nifi] krisztina-zsihovszki commented on a diff in pull request #6832: NIFI-10965 PutGoogleDrive

2023-01-18 Thread GitBox
krisztina-zsihovszki commented on code in PR #6832: URL: https://github.com/apache/nifi/pull/6832#discussion_r1073749574 ## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/PutGoogleDrive.java: ## @@ -0,0 +1,495 @@ +/* + *

[GitHub] [nifi] krisztina-zsihovszki commented on a diff in pull request #6832: NIFI-10965 PutGoogleDrive

2023-01-18 Thread GitBox
krisztina-zsihovszki commented on code in PR #6832: URL: https://github.com/apache/nifi/pull/6832#discussion_r1073746321 ## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/PutGoogleDrive.java: ## @@ -0,0 +1,495 @@ +/* + *

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1466: MINIFICPP-1994 - Route flowfiles with invalid SQL to Failure

2023-01-18 Thread GitBox
szaszm commented on code in PR #1466: URL: https://github.com/apache/nifi-minifi-cpp/pull/1466#discussion_r1073743383 ## libminifi/test/TestBase.cpp: ## @@ -234,12 +234,16 @@ std::shared_ptr TestPlan::addProcessor(const std::share

[GitHub] [nifi] krisztina-zsihovszki commented on a diff in pull request #6832: NIFI-10965 PutGoogleDrive

2023-01-18 Thread GitBox
krisztina-zsihovszki commented on code in PR #6832: URL: https://github.com/apache/nifi/pull/6832#discussion_r1073743255 ## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/PutGoogleDrive.java: ## @@ -0,0 +1,495 @@ +/* + *

[GitHub] [nifi] krisztina-zsihovszki commented on a diff in pull request #6832: NIFI-10965 PutGoogleDrive

2023-01-18 Thread GitBox
krisztina-zsihovszki commented on code in PR #6832: URL: https://github.com/apache/nifi/pull/6832#discussion_r1073739794 ## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/GoogleDriveAttributes.java: ## @@ -0,0 +1,44 @@

[GitHub] [nifi] krisztina-zsihovszki commented on a diff in pull request #6832: NIFI-10965 PutGoogleDrive

2023-01-18 Thread GitBox
krisztina-zsihovszki commented on code in PR #6832: URL: https://github.com/apache/nifi/pull/6832#discussion_r1073738141 ## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/FetchGoogleDrive.java: ## @@ -125,9 +145,17 @@

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1461: MINIFICPP-1983 Mount files in MiNiFi test containers and additional refactoring

2023-01-18 Thread GitBox
adamdebreceni commented on code in PR #1461: URL: https://github.com/apache/nifi-minifi-cpp/pull/1461#discussion_r1073709877 ## docker/test/integration/cluster/containers/Container.py: ## @@ -63,13 +63,25 @@ def log_source(self): return LogSource.FROM_DOCKER_CONTAINER

[GitHub] [nifi] tpalfy commented on a diff in pull request #6762: NIFI-10953: Implement GCP Vision AI processors

2023-01-18 Thread GitBox
tpalfy commented on code in PR #6762: URL: https://github.com/apache/nifi/pull/6762#discussion_r1073600024 ## nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/vision/GetGcpVisionAnnotateImagesOperationStatus.java: ## @@ -0,0

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1461: MINIFICPP-1983 Mount files in MiNiFi test containers and additional refactoring

2023-01-18 Thread GitBox
adamdebreceni commented on code in PR #1461: URL: https://github.com/apache/nifi-minifi-cpp/pull/1461#discussion_r1073705141 ## docker/test/integration/cluster/checkers/PostgresChecker.py: ## @@ -0,0 +1,18 @@ +import time + + +class PostgresChecker: +def __init__(self,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1466: MINIFICPP-1994 - Route flowfiles with invalid SQL to Failure

2023-01-18 Thread GitBox
adamdebreceni commented on code in PR #1466: URL: https://github.com/apache/nifi-minifi-cpp/pull/1466#discussion_r1073681265 ## extensions/sql/processors/PutSQL.h: ## @@ -53,6 +55,9 @@ class PutSQL : public SQLProcessor { void processOnTrigger(core::ProcessContext& context,

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1466: MINIFICPP-1994 - Route flowfiles with invalid SQL to Failure

2023-01-18 Thread GitBox
szaszm commented on code in PR #1466: URL: https://github.com/apache/nifi-minifi-cpp/pull/1466#discussion_r1073643531 ## extensions/sql/processors/PutSQL.h: ## @@ -53,6 +55,9 @@ class PutSQL : public SQLProcessor { void processOnTrigger(core::ProcessContext& context,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1466: MINIFICPP-1994 - Route flowfiles with invalid SQL to Failure

2023-01-18 Thread GitBox
adamdebreceni commented on code in PR #1466: URL: https://github.com/apache/nifi-minifi-cpp/pull/1466#discussion_r1073615926 ## libminifi/test/TestBase.cpp: ## @@ -564,7 +588,7 @@ std::unique_ptr TestPlan::buildFinalConnection(const std::sh std::stringstream

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1466: MINIFICPP-1994 - Route flowfiles with invalid SQL to Failure

2023-01-18 Thread GitBox
adamdebreceni commented on code in PR #1466: URL: https://github.com/apache/nifi-minifi-cpp/pull/1466#discussion_r1073615202 ## extensions/sql/processors/ExecuteSQL.h: ## @@ -58,6 +60,9 @@ class ExecuteSQL : public SQLProcessor, public FlowFileSource { EXTENSIONAPI static

[GitHub] [nifi] turcsanyip commented on pull request #6846: NIFI-10991 Add AWS MSK IAM support to Kafka processors

2023-01-18 Thread GitBox
turcsanyip commented on PR #6846: URL: https://github.com/apache/nifi/pull/6846#issuecomment-1387109383 @nandorsoma There seems to be regression in the kerberos login. I get the error below when trying to connect to a kerberized kafka using SASL_SSL + GSSAPI. I built the processors

[GitHub] [nifi] krisztina-zsihovszki opened a new pull request, #6855: NIFI-11069 PutDropbox: remove upload cancellation, unify conflict res…

2023-01-18 Thread GitBox
krisztina-zsihovszki opened a new pull request, #6855: URL: https://github.com/apache/nifi/pull/6855 …olution naming # Summary [NIFI-11069](https://issues.apache.org/jira/browse/NIFI-11069) # Tracking Please

[GitHub] [nifi] asfgit closed pull request #6851: NIFI-11024: Update iceberg.version to 1.1.0

2023-01-18 Thread GitBox
asfgit closed pull request #6851: NIFI-11024: Update iceberg.version to 1.1.0 URL: https://github.com/apache/nifi/pull/6851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] mark-bathori commented on pull request #6851: NIFI-11024: Update iceberg.version to 1.1.0

2023-01-18 Thread GitBox
mark-bathori commented on PR #6851: URL: https://github.com/apache/nifi/pull/6851#issuecomment-1387046807 @mr1716 Thank you for the iceberg version upgrade change. I did some manual testing with the iceberg processor and everything seems to be working properly. LGTM +1 -- This is an

[GitHub] [nifi] ferencerdei closed pull request #6854: NIFI-11066 Removed unnecessary tag from minifi-c2-docker

2023-01-18 Thread GitBox
ferencerdei closed pull request #6854: NIFI-11066 Removed unnecessary tag from minifi-c2-docker URL: https://github.com/apache/nifi/pull/6854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] ferencerdei commented on pull request #6854: NIFI-11066 Removed unnecessary tag from minifi-c2-docker

2023-01-18 Thread GitBox
ferencerdei commented on PR #6854: URL: https://github.com/apache/nifi/pull/6854#issuecomment-1386896503 looks good +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [nifi] briansolo1985 opened a new pull request, #6854: NIFI-11066 Removed unnecessary tag from minifi-c2-docker

2023-01-18 Thread GitBox
briansolo1985 opened a new pull request, #6854: URL: https://github.com/apache/nifi/pull/6854 # Summary [NIFI-11066](https://issues.apache.org/jira/browse/NIFI-11066) # Tracking Please complete the following tracking

[GitHub] [nifi] shilpaprotiviti commented on pull request #6053: NIFI-4239 - Adding CaptureChangePostgreSQL processor to capture data changes (INSERT/UPDATE/DELETE) from PostgreSQL tables via Logical

2023-01-17 Thread GitBox
shilpaprotiviti commented on PR #6053: URL: https://github.com/apache/nifi/pull/6053#issuecomment-1386586052 We need Nifi CapctureChangePostgreSQL processor for one of our requirement. I have gone by above comments, I understand you are busy in other activities as well. But can you please

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6794: NIFI-10966: Add option to QuerySalesforceObject to run custom query

2023-01-17 Thread GitBox
Lehel44 commented on code in PR #6794: URL: https://github.com/apache/nifi/pull/6794#discussion_r1072982453 ## nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java: ## @@ -261,6 +323,30

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6794: NIFI-10966: Add option to QuerySalesforceObject to run custom query

2023-01-17 Thread GitBox
Lehel44 commented on code in PR #6794: URL: https://github.com/apache/nifi/pull/6794#discussion_r1072970089 ## nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java: ## @@ -106,13

[GitHub] [nifi] markap14 merged pull request #6831: NIFI-11028 Handle controller service 'Scheduled State' after upgrade …

2023-01-17 Thread GitBox
markap14 merged PR #6831: URL: https://github.com/apache/nifi/pull/6831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nifi] markap14 commented on pull request #6831: NIFI-11028 Handle controller service 'Scheduled State' after upgrade …

2023-01-17 Thread GitBox
markap14 commented on PR #6831: URL: https://github.com/apache/nifi/pull/6831#issuecomment-1386244599 Thanks @krisztina-zsihovszki I think this change makes sense. Also ensured that I was able to perform a full build and run all system tests, and all checks out. +1 will merge to main. --

[GitHub] [nifi] taz1988 commented on a diff in pull request #6838: NIFI-11044 Script/commands to migrate Kafka processors

2023-01-17 Thread GitBox
taz1988 commented on code in PR #6838: URL: https://github.com/apache/nifi/pull/6838#discussion_r1072831472 ## nifi-toolkit/nifi-toolkit-kafka-migrator/src/main/java/org/apache/nifi/toolkit/kafkamigrator/KafkaMigratorMain.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the

  1   2   3   4   5   6   7   8   9   10   >