martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044591718
##
libminifi/test/rocksdb-tests/RocksDBTests.cpp:
##
@@ -232,9 +231,9 @@ void
withDefaultEnv(minifi::internal::Writable& db_opts) {
}
TEST_CASE_METHOD(R
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044590030
##
minifi_main/MainHelper.cpp:
##
@@ -133,43 +128,41 @@ std::string determineMinifiHome(const
std::shared_ptr& logger)
return "";
}();
- if (mini
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044589812
##
minifi_main/MainHelper.cpp:
##
@@ -133,43 +128,41 @@ std::string determineMinifiHome(const
std::shared_ptr& logger)
return "";
}();
- if (mini
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044587720
##
libminifi/test/unit/FileStreamTests.cpp:
##
@@ -301,32 +267,25 @@ TEST_CASE("Existing file read/write test") {
stream.seek(0);
}
-#if !defined(WIN32
szaszm opened a new pull request, #1470:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1470
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044576534
##
libminifi/include/core/ConfigurableComponent.h:
##
@@ -59,6 +59,18 @@ class ConfigurableComponent {
template
bool getProperty(const std::string name
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044570304
##
extensions/standard-processors/tests/unit/GenerateFlowFileTests.cpp:
##
@@ -57,9 +57,9 @@ TEST_CASE("GenerateFlowFileTest", "[generateflowfiletest]") {
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044569637
##
extensions/standard-processors/processors/GetFile.cpp:
##
@@ -154,36 +154,32 @@ void GetFile::onTrigger(core::ProcessContext*
/*context*/, core::ProcessS
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044566428
##
extensions/sftp/processors/FetchSFTP.cpp:
##
@@ -87,12 +87,11 @@ void FetchSFTP::onTrigger(const
std::shared_ptr &context,
return;
}
- /* Pars
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044565861
##
extensions/script/tests/TestExecuteScriptProcessorWithPythonScript.cpp:
##
@@ -295,124 +291,119 @@ TEST_CASE("Python: Test Update Attribute",
"[executesc
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044561423
##
extensions/script/tests/TestExecuteScriptProcessorWithLuaScript.cpp:
##
@@ -421,8 +412,10 @@ TEST_CASE("Lua: Test Module Directory property",
"[executesc
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044558281
##
extensions/script/python/PythonCreator.h:
##
@@ -140,26 +136,18 @@ class PythonCreator : public minifi::core::CoreComponent {
return python_package;
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044557769
##
extensions/jni/jvm/JniReferenceObjects.h:
##
@@ -244,23 +228,24 @@ class JniSession : public core::WeakReference {
}
bool prune() {
-global_ff
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044557458
##
extensions/http-curl/tests/C2VerifyServeResults.cpp:
##
@@ -82,8 +82,8 @@ class VerifyC2Server : public HTTPIntegrationBase {
}
protected:
- std::
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044555660
##
extensions/expression-language/tests/ExpressionLanguageTests.cpp:
##
@@ -218,7 +216,7 @@ TEST_CASE("GetFile PutFile dynamic attribute",
"[expressionLangu
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044555022
##
Windows.md:
##
@@ -93,7 +93,7 @@ A basic working CMake configuration can be inferred from the
`win_build_vs.bat`.
```
mkdir build
cd build
-cmake -G "
NissimShiman commented on PR #6750:
URL: https://github.com/apache/nifi/pull/6750#issuecomment-1344334227
reviewing/testing pr...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
exceptionfactory commented on code in PR #6589:
URL: https://github.com/apache/nifi/pull/6589#discussion_r1044467172
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/ml/polly/GetAwsPollyJobStatus.java:
##
@@ -0,0 +1,115 @@
+/*
KalmanJantner commented on code in PR #6589:
URL: https://github.com/apache/nifi/pull/6589#discussion_r1044125278
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/ml/polly/GetAwsPollyJobStatus.java:
##
@@ -0,0 +1,115 @@
+/*
+ *
mattyb149 closed pull request #6773: NIFI-10967 Correct TestWriteJsonResult
mixed arrays
URL: https://github.com/apache/nifi/pull/6773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
mattyb149 commented on PR #6773:
URL: https://github.com/apache/nifi/pull/6773#issuecomment-1343889328
+1 LGTM, all tests (including Windows) passed, thanks for the fix! Merging
to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
mattyb149 commented on code in PR #6756:
URL: https://github.com/apache/nifi/pull/6756#discussion_r1044090927
##
nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/src/main/java/org/apache/nifi/service/PostgreSQLConnectionPool.java:
##
@@ -0,0 +1,150 @@
+/*
+
exceptionfactory commented on code in PR #6756:
URL: https://github.com/apache/nifi/pull/6756#discussion_r1044089839
##
nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/src/main/java/org/apache/nifi/service/PostgreSQLConnectionPool.java:
##
@@ -0,0 +1,150 @@
mattyb149 commented on code in PR #6756:
URL: https://github.com/apache/nifi/pull/6756#discussion_r1044089270
##
nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/src/main/java/org/apache/nifi/service/PostgreSQLConnectionPool.java:
##
@@ -0,0 +1,150 @@
+/*
+
exceptionfactory commented on code in PR #6589:
URL: https://github.com/apache/nifi/pull/6589#discussion_r1044077701
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/ml/AwsMachineLearningJobStarter.java:
##
@@ -0,0 +1,161 @@
+/
exceptionfactory opened a new pull request, #6773:
URL: https://github.com/apache/nifi/pull/6773
# Summary
[NIFI-10967](https://issues.apache.org/jira/browse/NIFI-10967) Corrects
`TestWriteJsonResult.testChoiceArrayOfStringsOrArrayOfRecords` on Windows
platforms. Changes replace the
Lehel44 commented on code in PR #6756:
URL: https://github.com/apache/nifi/pull/6756#discussion_r1043838815
##
nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/src/main/java/org/apache/nifi/service/PostgreSQLConnectionPool.java:
##
@@ -0,0 +1,150 @@
+/*
+ *
Lehel44 commented on code in PR #6756:
URL: https://github.com/apache/nifi/pull/6756#discussion_r1043837059
##
nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/src/main/java/org/apache/nifi/service/PostgreSQLConnectionPool.java:
##
@@ -0,0 +1,150 @@
+/*
+ *
Lehel44 commented on code in PR #6756:
URL: https://github.com/apache/nifi/pull/6756#discussion_r1043837059
##
nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/src/main/java/org/apache/nifi/service/PostgreSQLConnectionPool.java:
##
@@ -0,0 +1,150 @@
+/*
+ *
exceptionfactory commented on code in PR #6756:
URL: https://github.com/apache/nifi/pull/6756#discussion_r1043816820
##
nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/src/main/java/org/apache/nifi/service/PostgreSQLConnectionPool.java:
##
@@ -0,0 +1,150 @@
exceptionfactory commented on code in PR #6756:
URL: https://github.com/apache/nifi/pull/6756#discussion_r1043816292
##
nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/src/main/java/org/apache/nifi/service/PostgreSQLConnectionPool.java:
##
@@ -0,0 +1,150 @@
mattyb149 commented on code in PR #6756:
URL: https://github.com/apache/nifi/pull/6756#discussion_r1043793836
##
nifi-nar-bundles/nifi-dbcp-services-bundle/nifi-postgres-dbcp-service/src/main/java/org/apache/nifi/service/PostgreSQLConnectionPool.java:
##
@@ -0,0 +1,150 @@
+/*
+
tpalfy commented on code in PR #6670:
URL: https://github.com/apache/nifi/pull/6670#discussion_r1043582519
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-nar/src/main/resources/META-INF/NOTICE:
##
@@ -0,0 +1,101 @@
+nifi-salesforce-nar
Review Comment:
There are j
tpalfy commented on code in PR #6670:
URL: https://github.com/apache/nifi/pull/6670#discussion_r1043518617
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/PutSalesforceObject.java:
##
@@ -0,0 +1,207 @@
+/*
mattyb149 closed pull request #6767: NIFI-10915 Add additionalDetails indicator
to runtime manifest
URL: https://github.com/apache/nifi/pull/6767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mattyb149 commented on PR #6767:
URL: https://github.com/apache/nifi/pull/6767#issuecomment-1342948100
+1 LGTM, verified the manifest matches the existence of
additionalDetails.html docs for those processors that have it. Thanks for the
improvement! Merging to main
--
This is an automate
adamdebreceni commented on code in PR #1391:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r1043458866
##
libminifi/include/core/flow/Node.h:
##
@@ -0,0 +1,139 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributo
mattyb149 commented on PR #6767:
URL: https://github.com/apache/nifi/pull/6767#issuecomment-1342834091
Reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
markap14 merged PR #6763:
URL: https://github.com/apache/nifi/pull/6763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.o
markap14 commented on PR #6763:
URL: https://github.com/apache/nifi/pull/6763#issuecomment-1342821391
Thanks @mattyb149 looks like all is working well now. +1 will merge to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lordgamez commented on code in PR #1413:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1413#discussion_r1043359935
##
minifi_main/JsonSchema.h:
##
@@ -0,0 +1,26 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreement
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043354394
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/storage/LocalStorageAdapter.java:
##
@@ -0,0 +1,72 @
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043354212
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/storage/GcpStorageAdapter.java:
##
@@ -0,0 +1,86 @@
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043353231
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/service/DeltaLakeService.java:
##
@@ -0,0 +1,97 @@
+
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043352894
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
lordgamez commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1043352711
##
extensions/mqtt/processors/PublishMQTT.h:
##
@@ -62,72 +68,116 @@ class PublishMQTT : public
processors::AbstractMQTTProcessor {
ADD_COMMON_VIRTUAL_F
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043352690
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043352025
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043351729
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043351131
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
lordgamez commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1043349754
##
extensions/mqtt/processors/AbstractMQTTProcessor.h:
##
@@ -46,150 +44,178 @@ class AbstractMQTTProcessor : public core::Processor {
freeResources();
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043345525
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043344567
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043343436
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043343087
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043342919
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/service/DeltaTableService.java:
##
@@ -0,0 +1,129 @@
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043342185
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043341599
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043341145
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/DeltaLakeMetadataWriter.java:
##
@@ -0,0 +1,264 @@
+
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043340577
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/storage/AzureStorageAdapter.java:
##
@@ -0,0 +1,87 @
rliszli commented on code in PR #6601:
URL: https://github.com/apache/nifi/pull/6601#discussion_r1043340339
##
nifi-nar-bundles/nifi-deltalake-bundle/nifi-deltalake-processors/src/main/java/org/apache/nifi/processors/deltalake/service/DeltaTableService.java:
##
@@ -0,0 +1,129 @@
rliszli commented on PR #6601:
URL: https://github.com/apache/nifi/pull/6601#issuecomment-1342719000
Successfully reduced the size of the processor by using the
nifi-hadoop-libraries-nar, thanks @exceptionfactory, and by splitting up the
aws sdk dependency.
--
This is an automated messag
lordgamez commented on code in PR #1391:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r1043310888
##
libminifi/include/core/flow/Node.h:
##
@@ -0,0 +1,139 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
tanmaya-panda1 closed pull request #6772: Nifi 8294 source
URL: https://github.com/apache/nifi/pull/6772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tanmaya-panda1 opened a new pull request, #6772:
URL: https://github.com/apache/nifi/pull/6772
# Summary
[NIFI-0](https://issues.apache.org/jira/browse/NIFI-0)
# Tracking
Please complete the following tracking st
dependabot[bot] opened a new pull request, #6771:
URL: https://github.com/apache/nifi/pull/6771
Bumps
[decode-uri-component](https://github.com/SamVerschueren/decode-uri-component)
from 0.2.0 to 0.2.2.
Release notes
Sourced from https://github.com/SamVerschueren/decode-uri-compone
NissimShiman opened a new pull request, #6770:
URL: https://github.com/apache/nifi/pull/6770
# Summary
[NIFI-10853](https://issues.apache.org/jira/browse/NIFI-10853)
# Tracking
Please complete the following track
takraj commented on PR #6504:
URL: https://github.com/apache/nifi/pull/6504#issuecomment-1341645043
@turcsanyip I have attempted to address each of the discovered issues.
Please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
takraj commented on code in PR #6504:
URL: https://github.com/apache/nifi/pull/6504#discussion_r1042720308
##
nifi-nar-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/utils/PollableAsanaObjectFetcher.java:
##
@@ -0,0 +1,40 @@
+/*
+
takraj commented on code in PR #6504:
URL: https://github.com/apache/nifi/pull/6504#discussion_r1042720020
##
nifi-nar-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/utils/PollableAsanaObjectFetcher.java:
##
@@ -0,0 +1,40 @@
+/*
+
takraj commented on code in PR #6504:
URL: https://github.com/apache/nifi/pull/6504#discussion_r1042719736
##
nifi-nar-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/GetAsanaObject.java:
##
@@ -0,0 +1,405 @@
+/*
+ * Licensed to the
takraj commented on code in PR #6504:
URL: https://github.com/apache/nifi/pull/6504#discussion_r1042719333
##
nifi-nar-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/GetAsanaObject.java:
##
@@ -0,0 +1,405 @@
+/*
+ * Licensed to the
takraj commented on code in PR #6504:
URL: https://github.com/apache/nifi/pull/6504#discussion_r1042718987
##
nifi-nar-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/resources/docs/org.apache.nifi.processors.asana.GetAsanaObject/additionalDetails.html:
##
@@ -0,0 +1,10
takraj commented on code in PR #6504:
URL: https://github.com/apache/nifi/pull/6504#discussion_r1042718710
##
nifi-nar-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/GetAsanaObject.java:
##
@@ -0,0 +1,405 @@
+/*
+ * Licensed to the
tpalfy opened a new pull request, #6769:
URL: https://github.com/apache/nifi/pull/6769
# Summary
[NIFI-10955](https://issues.apache.org/jira/browse/NIFI-10955)
# Tracking
Please complete the following tracking steps prio
markap14 commented on PR #6763:
URL: https://github.com/apache/nifi/pull/6763#issuecomment-1341266254
@mattyb149 I actually just encountered an issue with another test. I tried
sending in a case where we did have an ARRAY[STRING] and in another record an
ARRAY[RECORD]. In that case, it stil
NissimShiman opened a new pull request, #6768:
URL: https://github.com/apache/nifi/pull/6768
# Summary
[NIFI-10241](https://issues.apache.org/jira/browse/NIFI-10241)
This will alert nifi admins regarding comments entered for the sp
fgerlits commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041264186
##
extensions/mqtt/processors/AbstractMQTTProcessor.cpp:
##
@@ -163,23 +200,259 @@ void AbstractMQTTProcessor::reconnect() {
}
logger_->log_info("Recon
markap14 commented on PR #6763:
URL: https://github.com/apache/nifi/pull/6763#issuecomment-1341077872
Thanks for the fix @mattyb149! Definitely not a simple problem. The code
looks good. The unit tests look good. I also did some manual testing with some
more complex JSON objects.
The
bbende opened a new pull request, #6767:
URL: https://github.com/apache/nifi/pull/6767
- Update manifests assembly to include the additionaDetails.html files
- Update C2 ExtensionDefinition to add a new field for additional details
content
- Update manifest generation to read the addit
adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1042215060
##
extensions/mqtt/processors/AbstractMQTTProcessor.h:
##
@@ -46,150 +44,178 @@ class AbstractMQTTProcessor : public core::Processor {
freeResources
adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1042214797
##
extensions/mqtt/processors/AbstractMQTTProcessor.cpp:
##
@@ -137,19 +148,45 @@ void AbstractMQTTProcessor::onSchedule(const
std::shared_ptrlog_error(
adamdebreceni commented on code in PR #1413:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1413#discussion_r1042191877
##
minifi_main/JsonSchema.h:
##
@@ -0,0 +1,26 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agree
tanmaya-panda1 closed pull request #6766: Nifi 8294 source
URL: https://github.com/apache/nifi/pull/6766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tanmaya-panda1 opened a new pull request, #6766:
URL: https://github.com/apache/nifi/pull/6766
# Summary
[NIFI-0](https://issues.apache.org/jira/browse/NIFI-0)
# Tracking
Please complete the following tracking st
adamdebreceni commented on code in PR #1413:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1413#discussion_r1042158041
##
minifi_main/JsonSchema.cpp:
##
@@ -0,0 +1,436 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license ag
adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1042144555
##
PROCESSORS.md:
##
@@ -337,28 +337,34 @@ This Processor gets the contents of a FlowFile from a
MQTT broker for a specifie
In the list below, the na
adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1042119988
##
extensions/mqtt/processors/PublishMQTT.cpp:
##
@@ -34,76 +34,229 @@ void PublishMQTT::initialize() {
setSupportedRelationships(relationships());
}
fgerlits opened a new pull request, #1469:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1469
https://issues.apache.org/jira/browse/MINIFICPP-1932
Increase the timeout of `TailFileTest` from 2s to the default 10s, to
prevent occasional test failures. The log snippet in the Jira
malthe opened a new pull request, #6765:
URL: https://github.com/apache/nifi/pull/6765
# Summary
[NIFI-9972](https://issues.apache.org/jira/browse/NIFI-9972)
This adds support for the "Put Blob from URL" operation which provide
dependabot[bot] opened a new pull request, #6764:
URL: https://github.com/apache/nifi/pull/6764
Bumps [qs](https://github.com/ljharb/qs),
[body-parser](https://github.com/expressjs/body-parser) and
[express](https://github.com/expressjs/express). These dependencies needed to
be updated tog
mattyb149 opened a new pull request, #6763:
URL: https://github.com/apache/nifi/pull/6763
# Summary
[NIFI-10956](https://issues.apache.org/jira/browse/NIFI-10956)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Trac
dependabot[bot] opened a new pull request, #72:
URL: https://github.com/apache/nifi-fds/pull/72
Bumps [qs](https://github.com/ljharb/qs),
[body-parser](https://github.com/expressjs/body-parser) and
[express](https://github.com/expressjs/express). These dependencies needed to
be updated tog
adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041328112
##
extensions/mqtt/processors/PublishMQTT.cpp:
##
@@ -34,76 +34,229 @@ void PublishMQTT::initialize() {
setSupportedRelationships(relationships());
}
adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041315835
##
extensions/mqtt/processors/PublishMQTT.cpp:
##
@@ -34,76 +34,229 @@ void PublishMQTT::initialize() {
setSupportedRelationships(relationships());
}
adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041313305
##
extensions/mqtt/processors/PublishMQTT.cpp:
##
@@ -34,76 +34,229 @@ void PublishMQTT::initialize() {
setSupportedRelationships(relationships());
}
adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041290532
##
extensions/mqtt/processors/PublishMQTT.cpp:
##
@@ -34,76 +34,229 @@ void PublishMQTT::initialize() {
setSupportedRelationships(relationships());
}
adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041288113
##
extensions/mqtt/processors/PublishMQTT.cpp:
##
@@ -34,76 +34,229 @@ void PublishMQTT::initialize() {
setSupportedRelationships(relationships());
}
adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041281537
##
extensions/mqtt/processors/ConsumeMQTT.cpp:
##
@@ -34,111 +34,333 @@ void ConsumeMQTT::initialize() {
setSupportedRelationships(relationships());
adam-markovics commented on code in PR #1432:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1432#discussion_r1041281303
##
extensions/mqtt/processors/ConsumeMQTT.cpp:
##
@@ -34,111 +34,333 @@ void ConsumeMQTT::initialize() {
setSupportedRelationships(relationships());
801 - 900 of 11909 matches
Mail list logo
