[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-22 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1342 @ijokarumawak yes they were both running on my laptop which is why I was wondering how the pull model ends up with the hostname, and the push model ends up with the ip address. I'll keep digging

[GitHub] nifi issue #1615: NIFI-3639 - Implemented HBase Get functionality for HBaseC...

2017-03-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1615 Hi @baolsen , thanks for contributing! One question, is there any difference between the get method being added, and using the existing scan method with startRow and endRow being the same

[GitHub] nifi issue #1615: NIFI-3639 - Implemented HBase Get functionality for HBaseC...

2017-03-24 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1615 @baolsen Thanks for the info. I believe only you can close the pull request on your end. As far as the automated checks, you can ignore appveryor, but the travis build should be passing

[GitHub] nifi issue #1527: NIFI-3189: ConsumeKafka & Back-pressure. ConsumeKafka_0_10

2017-03-30 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1527 +1 I recreated the scenario with 0.9 and 0.10 by setting back-pressure to 1 on the queues after ConsumeKafka and ConsumeKafka_0_10, and verified that after this patch they have no problem resuming

[GitHub] nifi issue #1585: NIFI-3380 Support Multiple Versions of the Same Component

2017-03-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1585 @markap14 The PR has been updated to address your comments and to fix a couple of other issues that were identified, also rebased against master as of yesterday evening. Here are the changes

[GitHub] nifi pull request #1635: NIFI-3520 Refactoring instance class loading

2017-03-29 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1635 NIFI-3520 Refactoring instance class loading This PR addresses the issue mentioned on NIFI-3520 regarding using the "Additional Resources" property on the HDFS processors. The fix is a f

[GitHub] nifi issue #1626: NIFI-3643: Fixing capitalization in Java Property

2017-03-27 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1626 Looks good, will merge to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1627: NIFI-3380: Fixing paths in generated documentation

2017-03-27 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1627 Looks good, will merge to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1635: NIFI-3520 Refactoring instance class loading

2017-03-31 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1635 @mcgilman Thanks for the review. I definitely agree that the current use of `cloneDuringInstanceClassLoading` allows for some confusing situations to arise and makes it challenging for the framework

[GitHub] nifi issue #1639: NIFI-1939 - Correct issue where ParseSyslog was unable to ...

2017-03-31 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1639 @trixpan I'll take a look when I get some free time, have a few other things going on at the moment. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #1605: NIFI-3626: Add support for DELETE in ConvertJSONToSQL

2017-03-21 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1605 +1 looks good, was able to use ConvertJsonToSQL + PutSQL to delete records from a MySQL table. I'll merge to master. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #1648: NIFI-2940: Accessing history for deleted components

2017-04-04 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1648 +1 verified that the access to the history of deleted components is now controlled by access to the controller, otherwise controlled by policies of the existing component, verified secure and unsecure

[GitHub] nifi pull request #1645: NIFI-3644 - Added HBase_1_1_2_ClientMapCacheService

2017-04-04 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1645#discussion_r109728311 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase

[GitHub] nifi pull request #1645: NIFI-3644 - Added HBase_1_1_2_ClientMapCacheService

2017-04-04 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1645#discussion_r109728428 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase

[GitHub] nifi pull request #1645: NIFI-3644 - Added HBase_1_1_2_ClientMapCacheService

2017-04-04 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1645#discussion_r109727737 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase

[GitHub] nifi pull request #1645: NIFI-3644 - Added HBase_1_1_2_ClientMapCacheService

2017-04-04 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1645#discussion_r109752585 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase

[GitHub] nifi issue #1648: NIFI-2940: Accessing history for deleted components

2017-04-04 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1648 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1635: NIFI-3520 Refactoring instance class loading

2017-04-04 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1635 @mcgilman I rebased and squashed the commits, this PR now reflects all the changes described in the previous discussion/comments above. Let me know of any questions or anything else to update

[GitHub] nifi pull request #1645: NIFI-3644 - Added HBase_1_1_2_ClientMapCacheService

2017-04-06 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1645#discussion_r110264255 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase

[GitHub] nifi issue #1606: NIFI-3528 Added support for keytab/principal to Kafka 0.10...

2017-04-06 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1606 +1 Verified this is working correctly, much nicer than configured the JAAS file in bootstrap.conf, will merge to master! --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #1654: NIFI-3678: Ensure that we catch EOFException when reading ...

2017-04-06 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1654 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1647: NIFI-3664: - UI Timestamp Issue

2017-04-05 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1647 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1647: NIFI-3664: - UI Timestamp Issue

2017-04-05 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1647 +1 Verified that before this change a local cluster was showing the time as EST even though running 'date' on my laptop reported EDT, this was causing the time to be off by an hour in the NiFi UI

[GitHub] nifi issue #1673: NIFI-3706: Removing non-existent resource when converting ...

2017-04-18 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1673 Looks good, will merge to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1581: NIFI-3534 Add support for impersonating a user with HDFS p...

2017-03-13 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1581 Should there be any validation that prevents setting remote user and also providing a kerberos principal/keytab since it the remote user would be ignored in that case? or maybe just document

[GitHub] nifi issue #1539: NIFI-3520 Updates classloading for components annotated wi...

2017-03-13 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1539 +1 going to merge to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #1585: NIFI-3380 Support Multiple Versions of the Same Com...

2017-03-10 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1585 NIFI-3380 Support Multiple Versions of the Same Component This PR introduces support for running multiple versions of the same component. In order to make full use of this capability we

[GitHub] nifi pull request #1581: NIFI-3534 Add support for impersonating a user with...

2017-03-13 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1581#discussion_r105669563 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java --- @@ -292,7

[GitHub] nifi issue #1653: NIFI-2940: Fixing broken integration test following change...

2017-04-07 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1653 +1 looks good, verified the tests pass now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1656: NIFI-3678

2017-04-07 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1656 +1 looks good, will merge to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1987: NIFI-4152 Initial commit of ListenTCPRecord

2017-07-31 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1987 @pvillard31 thanks for reviewing, I just rebased against master and made your suggested changes, let me know of anything else, thanks! --- If your project is set up for it, you can reply

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-31 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r130413186 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,323

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-31 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r130412355 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,323

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-31 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r130415687 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,323

[GitHub] nifi issue #2043: NIFI-4248: Adding Rya processor.

2017-08-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2043 @jzonthemtn sounds good, if you find that InvokeHttp doesn't work for some reason, or if there is some specific logic related to Rya that you need, then by all means re-open --- If your project

[GitHub] nifi issue #2043: NIFI-4248: Adding Rya processor.

2017-08-01 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2043 Hi @jzonthemtn , thanks for contributing... I don't really know much about Apache Rya, other than the high-level description, but I was glancing over this PR... since PutRya is assuming

[GitHub] nifi issue #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecord

2017-08-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1961 Thanks @MikeThomsen , two minor issues while testing this... 1) There is a try-with-resource block that creates the RecordReader, and as part of that line it also creates an InputStream

[GitHub] nifi issue #2046: NIFI-4022 - Enabled SASL auth scheme/ACL support for Curat...

2017-08-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2046 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #2078: NIFI-4286: Fix NPE in GenerateTableFetch when Partition Si...

2017-08-14 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2078 +1 looks good, will merge to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #2070: NIFI-4275 Adding support for specifying the timestamp on P...

2017-08-10 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2070 Thanks @pvillard31 , pushed another commit with the updates --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #2070: NIFI-4275 Adding support for specifying the timesta...

2017-08-09 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2070 NIFI-4275 Adding support for specifying the timestamp on PutHBase pro… …cessors You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi pull request #2076: NIFI-4288 Ignoring tests that intermittently fail i...

2017-08-11 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2076 NIFI-4288 Ignoring tests that intermittently fail in TestPutUDP and T… …estPutTCP Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r126223383 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,309

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r126217156 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,309

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r126218471 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,309

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r126216557 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,309

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r126219285 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,309

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r126231150 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,309

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r126216880 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,309

[GitHub] nifi pull request #1989: NIFI-4157 Improvements to PutTCP

2017-07-06 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1989 NIFI-4157 Improvements to PutTCP - Expose the ChannelSender's OutputStream - Use IOUtils to copy the flow file InputStream to the OutputStream - Make Outgoing Message Delimiter optional

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r126214244 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,309

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-10 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r126431845 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -207,6 +211,7 @@ public

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-10 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r126431547 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -49,10 +51,12

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-10 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r126430219 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -295,13 +302,21

[GitHub] nifi issue #1956: NIFI-4135 - added hadoop-client and enhanced Authorizers e...

2017-07-07 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1956 +1 looks good, thanks for making the update, I'll merge to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecord

2017-07-27 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1961 @MikeThomsen I should be able to take a look early next week --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #1955: NIFI-4136 Add a failure option to unmatch behavior ...

2017-06-29 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1955#discussion_r124821493 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/grok

[GitHub] nifi issue #1956: NIFI-4135 - added hadoop-client and enhanced Authorizers e...

2017-06-30 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1956 This looks good! Made sure existing config can run without the new classpath element, and then verified I could start the Ranger authorizer with it. My only comment, and I know this is super

[GitHub] nifi pull request #1987: NIFI-4152 Initial commit of ListenTCPRecord

2017-07-06 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1987 NIFI-4152 Initial commit of ListenTCPRecord Adds a ListenTCPRecord processor which can read records from the InputStream of a TCP connection. You can merge this pull request into a Git

[GitHub] nifi pull request #1945: NIFI-4124 Added org.apache.nifi.mongo.PutMongoRecor...

2017-06-27 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1945#discussion_r124287931 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/pom.xml --- @@ -48,6 +48,16

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-05 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r125645539 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,316

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-05 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r125640198 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,316

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-05 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r125639967 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/pom.xml --- @@ -82,5 +90,15 @@ test

[GitHub] nifi pull request #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecor...

2017-07-05 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1961#discussion_r125645738 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java --- @@ -0,0 +1,316

[GitHub] nifi issue #1956: NIFI-4135 - added hadoop-client and enhanced Authorizers e...

2017-06-28 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1956 Sure, I'll take a look as soon as I wrap up a couple of things. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1694: NIFI-3738 Fixed NPE when ListenSyslog UDP datagram has zer...

2017-04-25 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1694 +1 looks good and will merge to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #1639: NIFI-1939 - Correct issue where ParseSyslog was una...

2017-04-28 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1639#discussion_r113979520 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseSyslog.java --- @@ -57,13

[GitHub] nifi pull request #1639: NIFI-1939 - Correct issue where ParseSyslog was una...

2017-04-28 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1639#discussion_r113979345 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseSyslog.java --- @@ -57,13

[GitHub] nifi pull request #1660: NIFI-3674: Implementing SiteToSiteStatusReportingTa...

2017-04-28 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1660#discussion_r113976234 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request #1660: NIFI-3674: Implementing SiteToSiteStatusReportingTa...

2017-04-28 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1660#discussion_r113976097 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request #1712: NIFI-3724 - Add Put/Fetch Parquet Processors

2017-04-27 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1712 NIFI-3724 - Add Put/Fetch Parquet Processors This PR adds a new nifi-parquet-bundle with PutParquet and FetchParquet processors. These work similar to PutHDFS and FetchHDFS, but instead read

[GitHub] nifi issue #1711: NIFI-3755 - Restoring Hive exception handling behavior

2017-04-28 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1711 Looks good, tested this out and the error handling appears to work correctly now, will merge to master and include for 1.2, thanks! --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1961: NIFI-4024 Added org.apache.nifi.hbase.PutHBaseRecord

2017-08-04 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1961 Merged to master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi issue #2046: NIFI-4022 - Enabled SASL auth scheme/ACL support for Curat...

2017-08-04 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/2046 +1 Finally got my environment setup correctly and was able to verify the ACLs get created appropriately with this change, will merge to master, thanks! --- If your project is set up for it, you can

[GitHub] nifi-registry issue #4: NIFIREG-8: Registry Web API Stubs

2017-08-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/4 @kevdoran this looks great Running a full build I ran into an error when the swagger plugin was running, I had to change the config in the pom to wrap the locations and schemes

[GitHub] nifi pull request #1987: NIFI-4152 Initial commit of ListenTCPRecord

2017-08-08 Thread bbende
Github user bbende closed the pull request at: https://github.com/apache/nifi/pull/1987 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1987: NIFI-4152 Initial commit of ListenTCPRecord

2017-08-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1987 Thanks! closing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi-registry issue #3: NIFIREG-6 Adding nifi-registry-bootstrap module

2017-08-07 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/3 @mcgilman thanks for reviewing, I made the updates you suggested, let me know if there is anything else. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1987: NIFI-4152 Initial commit of ListenTCPRecord

2017-08-07 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1987 @pvillard31 thanks for trying it out... I made some changes so that it should only produce a bulletin when there is an error other than a read timeout, and on read timeouts I made it leave

[GitHub] nifi-registry pull request #5: NIFIREG-7 Defining Provider API and initial f...

2017-08-18 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi-registry/pull/5 NIFIREG-7 Defining Provider API and initial filesystem providers This is a fairly large PR so let me give an overview of everything introduced here... This PR introduces the concept

[GitHub] nifi-registry pull request #5: NIFIREG-7 Defining Provider API and initial f...

2017-08-22 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/5#discussion_r134566585 --- Diff: nifi-registry-utils/src/main/java/org/apache/nifi/registry/util/StringUtils.java --- @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request #2106: NIFI-4311 Allowing umask to get set properly before...

2017-08-22 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2106 NIFI-4311 Allowing umask to get set properly before initializing the … …FileSystem Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #2096: NIFI-4304 Extracting HWX Schema Registry client ver...

2017-08-17 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/2096 NIFI-4304 Extracting HWX Schema Registry client version to a property… … and bumping to latest 0.3.0 release Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi issue #1740: NIFI-3782: Controller Service duplicated during Copy/Paste

2017-05-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1740 +1 verified copy & paste behavior is working as expected after this patch, will merge to master --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] nifi issue #1742: NIFI-3787: Addressed NPE and ensure that if validation fai...

2017-05-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1742 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1740: NIFI-3782: Controller Service duplicated during Copy/Paste

2017-05-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1740 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor

2017-05-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1716 @jonashartwig have you seen Joe's comment here? https://issues.apache.org/jira/browse/NIFI-3759?focusedCommentId=15988716=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment

[GitHub] nifi pull request #1739: NIFI-3776 Correcting links in documentation for See...

2017-05-03 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1739 NIFI-3776 Correcting links in documentation for SeeAlso and propertie… …s referencing controller services Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi issue #1742: NIFI-3787: Addressed NPE and ensure that if validation fai...

2017-05-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1742 +1 Looks good and will merge to master, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1743: NIFI-3789 Removing unnecessary intermittent test fa...

2017-05-03 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1743 NIFI-3789 Removing unnecessary intermittent test failure as described… … in JIRA Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #1780: NIFI-3865: Fix issues viewing content when clustered

2017-05-10 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1780 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1780: NIFI-3865: Fix issues viewing content when clustered

2017-05-10 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1780 +1 Verified content shows properly in the content viewer after this change, will merge to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #1904: NIFI-4049: Refactor AtomicDistributedMapCacheClient

2017-06-12 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1904 +1 Tested this out and verified Wait/Notify still works as expected with these changes. I agree with the full refactoring... since we have component versioning now someone could also

[GitHub] nifi pull request #1901: NIFI-4043 Initial commit of nifi-redis-bundle

2017-06-08 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1901#discussion_r121037027 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-distributed-cache-client-service-api/src/main/java/org/apache/nifi/distributed/cache/client

[GitHub] nifi pull request #1901: NIFI-4043 Initial commit of nifi-redis-bundle

2017-06-08 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1901#discussion_r121037053 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/WaitNotifyProtocol.java

[GitHub] nifi pull request #1901: NIFI-4043 Initial commit of nifi-redis-bundle

2017-06-08 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1901#discussion_r121039023 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-distributed-cache-client-service-api/src/main/java/org/apache/nifi/distributed/cache/client

[GitHub] nifi pull request #1901: NIFI-4043 Initial commit of nifi-redis-bundle

2017-06-12 Thread bbende
Github user bbende closed the pull request at: https://github.com/apache/nifi/pull/1901 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1901: NIFI-4043 Initial commit of nifi-redis-bundle

2017-06-12 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1901 Going to close this PR and put up a new one based on NIFI-4049. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #1911: NIFI-4043 Initial commit of nifi-redis-bundle

2017-06-12 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1911 NIFI-4043 Initial commit of nifi-redis-bundle Adds RedisConnectionPoolService and RedisDistributedMapCacheClientService You can merge this pull request into a Git repository by running: $ git

[GitHub] nifi issue #1911: NIFI-4043 Initial commit of nifi-redis-bundle

2017-06-12 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1911 @ijokarumawak fyi this is the new PR with RedisDistributedMapCacheClientService based on the AtomicDistributedMapCache refactor --- If your project is set up for it, you can reply to this email

<    1   2   3   4   5   6   7   8   9   >