Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r179833900
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r179831931
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r179829341
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r179820952
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r179835305
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r179824910
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r179829864
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r179822292
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r179834679
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r179834908
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r179833060
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2570
@mattyb149 thanks for the update! Sorry about the delay in getting back to
this. All looks good now from my POV. There was a checkstyle violation (unused
import) but I addressed that and all else
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2607#discussion_r180204274
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2509#discussion_r180211409
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2509#discussion_r180211507
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
---
@@ -215,9 +215,10
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2509#discussion_r180211928
--- Diff: nifi-docs/src/main/asciidoc/developer-guide.adoc ---
@@ -1751,6 +1751,12 @@ will handle your Processor:
will always be set to `1
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2626
@mcgilman thanks, this definitely simplifies the code a lot, too, and makes
it more consistent. Was able to verify starting/stopping process
groups/individual components. Was able to verify changing
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2634#discussion_r181775911
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/tasks/ConnectableTask.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2634#discussion_r181792251
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/tasks/ConnectableTask.java
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2646
NIFI-5096: Periodically poll ZooKeeper to determine the leader for eaâ¦
â¦ch registered role in Leader Election. This avoids a condition whereby a
node may occasionally fail to receive
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2646
@mcgilman we do indeed implement the ConnectionStateListener, but we do so
only to log the fact and then call super.stateChanged(). When we call
super.stateChanged(), that will throw
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2646
@mcgilman I agree. I have pushed a new commit that does just that.
---
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2587#discussion_r183152900
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2587
@JohannesDaniel thanks for the update! I commented above re: the use of
Expression Language in the property descriptor.
I do still feel like the check for 'record tag names' is unnec
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2634
@ijokarumawak that's great. Did you intend to push a new commit? The only
commit that I see is from April 12th.
---
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2640#discussion_r183159695
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2640#discussion_r183161985
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2640#discussion_r183161782
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2640#discussion_r183161097
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2634
@ijokarumawak thanks for the update! I feel the code is far more
understandable now and appears to work great! +1 merged to master
---
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2587
@JohannesDaniel this is great! I've been doing a good bit of testing to
ensure that everything works as expected. I had just a few more comments,
mostly around the descriptions in the pro
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2587
@JohannesDaniel that would be great! I think the Record attribute stuff
will significantly improve how we are able to handle XML-based records. But I
think the approach that you've taken here
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2587
This is now merged to master. Thanks again for the contribution!
---
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2633
@mcgilman many thanks for adding this improvement. Code looks good. Was
able to verify functionality and everything worked exactly as I expected. +1
merged to master.
---
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2653#discussion_r184179013
--- Diff:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/cf/JMSConnectionFactoryProvider.java
---
@@ -97,7 +96,7
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2623
@GreenCee thanks for submitting the JIRA, and the PR! Code looks good. Was
able to verify that it addresses the issue. +1 merged to master! Thanks again.
---
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2607
@mcgilman this is a great feature that I think will make a lot of people's
lives easier. Thanks for updating the UI to support this! Also thanks to
@scottyaslan and @moranr for your feedbac
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2509
@zenfenan I think there's also one other detail that I missed. The intent
here, I believe, is not just to default to Primary Node execution mode when the
@PrimaryNodeOnly annotation is present
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2669
NIFI-5142: Do not allow a connection's destination to be changed to aâ¦
⦠funnel if the source is the same funnel. Also fixed some typos in
StandardFunnel
Thank you for submitt
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2670
NIFI-5138: Bug fix to ensure that when we have a CHOICE between two oâ¦
â¦r more REOCRD types that we choose the appropriate RECORD type when
creating the Record in the JSON Reader
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2676
NIFI-5150: Fixed bug that caused StandardProcessSession.append() to câ¦
â¦opy too much data when called on an incoming flowfile
Thank you for submitting a contribution to Apache NiFi
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2677
NIFI-5153: If a node is disconnected due to failure to complete mutabâ¦
â¦le request, the node should be allowed to rejoin
Thank you for submitting a contribution to Apache NiFi
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2678
NIFI-5154: When Processor or Controller Service is added to a Processâ¦
⦠Group, remove any references from it to any other Controller Service
that is not reachable from the newly assigned
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2679
NIFI-5141: Updated regex for doubles to allow for numbers that have nâ¦
â¦o decimal
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2678
@mcgilman that's a great catch! I did try a scenario similar to what you
outline, but in my scenario I moved that processor back into the original PG
directly - not with the extra Process Gro
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2678
@mcgilman I have pushed another commit, which I believe addresses the issue
that you raised. I also found that if we have Group A that has a processor and
that processor referenced a controller
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2689
NIFI-950: Perform component validation asynchronously, other
cluster-related performance enhancements
This PR addresses NIFI-950 and a handful of other JIRA's. They were all
done in a sing
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2668
@bbende thanks for addressing these issues! I can see that we've tackled a
handful of spots that could be leaking the references, and I've seen the heap
dumps showing that they are
Github user markap14 closed the pull request at:
https://github.com/apache/nifi/pull/2689
---
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2689
@mcgilman I am closing this PR because it needs to be rebased and I ran
into an issue with a unit test during the rebase. Will open a new PR once that
has been addressed.
---
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2693
NIFI-950: Make component validation asynchronous
This PR addresses NIFI-950 as well as a handful of other related JIRAs. I
used a single PR because a lot of the solutions to the issues built upon
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2653#discussion_r187131152
--- Diff:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/cf/JMSConnectionFactoryProvider.java
---
@@ -159,13
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187349263
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187357216
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187353741
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187350490
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187349802
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187354340
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187353262
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187352722
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187351084
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187354930
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/test/resources/classification_test.txt
---
@@ -0,0 +1,100
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187350055
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187355568
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187349196
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187351854
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2686#discussion_r187349520
--- Diff:
nifi-nar-bundles/nifi-deeplearning4j-bundle/nifi-deeplearning4j-processors/src/main/java/org/apache/nifi/processors/deeplearning4j
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2686
@mans2singh the issue that you noted in Travis is unrelated to your PR and
is a problem with an existing using test, unfortunately. So nothing to do
there, really. Hopefully it will be addressed on
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2675#discussion_r187395204
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/pom.xml
---
@@ -86,12 +86,23
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2675#discussion_r187364738
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2675#discussion_r187366185
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2675#discussion_r187361310
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2675#discussion_r187359929
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2675#discussion_r187377388
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/xml
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2675#discussion_r187359257
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2672#discussion_r187425793
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2672#discussion_r187427343
--- Diff:
nifi-mock/src/main/java/org/apache/nifi/util/MockPropertyValue.java ---
@@ -202,6 +203,9 @@ public PropertyValue evaluateAttributeExpressions
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2701
NIFI-5194: Ensure that even if calling KafkaConsumer.resume() throws â¦
â¦an Exception, that we still release the lock that we are holding
Thank you for submitting a contribution to
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2672#discussion_r188124392
--- Diff:
nifi-mock/src/main/java/org/apache/nifi/util/MockPropertyValue.java ---
@@ -202,6 +203,9 @@ public PropertyValue evaluateAttributeExpressions
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2675
Thanks for updating @JohannesDaniel! All looks good to me at this point, so
I've merged to master. Many thanks for this contrib as well as the XML Reader!
---
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2693
@mcgilman I pushed a new commit that i think should address the feedback.
Thanks!
---
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2679
@bdesert good call! I updated the regex so that it allows for expressions
like "13." and added a unit test that tests lots of different possible
combinations. Thanks!
---
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2707
NIFI-5200: Fixed bug that caused the wrong InputStream to be closed bâ¦
â¦y StandardProcessSession if calling Session.read() from the callback of
another Session.read(); also changed default of
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2713
NIFI-5204: If processor joins cluster and inherits 'disabled' state but is
still stopping, ensure that the state becomes disabled when the processor
finishes stopping and that the state can
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2722
@joewitt your observations are very interesting - i am not seeing that at
all. I created a DebugFlow with a validation pause of 10 seconds. Then I
created an update attribute. UpdateAttribute was
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2722
@joewitt re: the unit test failure, I don't believe that it's actually
related to the previous PR necessarily, but is just a timing issue that
happened to trigger here. We could certainly
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2725#discussion_r189647485
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestUnpackContent.java
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2725
I think I'm missing something obvious... but the PR adds a new file,
invalid_data.zip but it doesn't add it to the RAT exclusions in the pom.xml...
yet, it still pass the contrib-check. I&
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2725
Ah, ok, I didn't realize that @joewitt - I thought it had to always be
excluded. There are probably a handful of well-known magic headers or something
then. Good to know!
---
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2722#discussion_r189656654
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/StatusMerger.java
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2722
@joewitt I think I understand now what you were seeing. If I create two
different DebugFlow processors, each with a validation pause of 10 seconds, and
then I create an UpdateAttribute and configure
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2730
NIFI-5186: Prevent validating components multiple times for each update
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2731
NIFI-5222: Prevent validating components multiple times for each update
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
Github user markap14 closed the pull request at:
https://github.com/apache/nifi/pull/2730
---
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2733
NIFI-5228: Allow user to choose whether or not to add File Attributes as
FlowFile Attributes when using FetchFile
Thank you for submitting a contribution to Apache NiFi.
In order to
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2733#discussion_r190229672
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java
---
@@ -255,43
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2733#discussion_r190232336
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java
---
@@ -255,43
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2056
@pvillard31 the code looks good to me, though I'm not in a state to easily
switch over my branch and merge. I'll try to get to it fairly soon but if
anyone else has the review cycles, t
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2732
@FrederikP all looks good here. I have merged the changes to master.
Thanks for the fix!
---
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2653
@zenfenan thanks for the update! The only thing I think that's missing is
that you left in the code to change the ClassLoader, and that can be removed
now because the framework is now managin
101 - 200 of 1392 matches
Mail list logo
