Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/359
@achristianson I feel like there is something I'm missing because there had
to have been a reason c_str() existed. On Friday I took another look and
couldn't statically determine why
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/364#discussion_r197820271
--- Diff: main/MiNiFiMain.cpp ---
@@ -71,7 +71,7 @@ int main(int argc, char **argv) {
std::string nifi_configuration_class_name
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r197824393
--- Diff: extensions/librdkafka/PublishKafka.h ---
@@ -28,6 +28,7 @@
#include "core/Property.h"
#include &qu
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r197826693
--- Diff: extensions/librdkafka/PublishKafka.cpp ---
@@ -262,7 +269,7 @@ void PublishKafka::onTrigger(const
std::shared_ptr
if (flowFile
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/364#discussion_r197815585
--- Diff: main/MiNiFiMain.cpp ---
@@ -71,7 +71,7 @@ int main(int argc, char **argv) {
std::string nifi_configuration_class_name
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r197824984
--- Diff: extensions/librdkafka/PublishKafka.h ---
@@ -115,14 +121,35 @@ class PublishKafka: public core::Processor {
buffer.reserve
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/365
MINIFICPP-543: Implement C2 based update policy enforcement
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/367
Travis failures appear to be unrelated. PythonExcuteScriptTests seem to not
complete.
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/314
Update C2 representations.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/313#discussion_r185256992
--- Diff: libminifi/test/resources/TestHTTPGet.yml ---
@@ -19,6 +19,7 @@
Flow Controller:
name: MiNiFi Flow
id: 2438e3c8
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/319
MINIFICPP-481: Update agent to exit gracefully with an invalid *repo dir
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145688465
--- Diff: libminifi/include/FlowFileRecord.h ---
@@ -164,6 +164,11 @@ class FlowFileRecord : public core::FlowFile, public
io::Serializable
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145688909
--- Diff: libminifi/include/core/ProcessSession.h ---
@@ -151,11 +152,47 @@ class ProcessSession {
bool keepSource
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145692040
--- Diff: libminifi/src/processors/FocusArchiveEntry.cpp ---
@@ -0,0 +1,340 @@
+/**
+ * @file FocusArchiveEntry.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145691644
--- Diff: libminifi/src/processors/FocusArchiveEntry.cpp ---
@@ -0,0 +1,340 @@
+/**
+ * @file FocusArchiveEntry.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145688790
--- Diff: libminifi/include/core/ProcessSession.h ---
@@ -19,6 +19,7 @@
#define __PROCESS_SESSION_H__
#include
+#include
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145687725
--- Diff: CMakeLists.txt ---
@@ -101,6 +101,7 @@ set(CIVETWEB_ENABLE_SSL_DYNAMIC_LOADING OFF CACHE BOOL
"Disable dynamic SSL libr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145690194
--- Diff: libminifi/include/processors/FocusArchiveEntry.h ---
@@ -0,0 +1,115 @@
+/**
+ * @file FocusArchiveEntry.h
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145691328
--- Diff: libminifi/src/core/ProcessSession.cpp ---
@@ -799,6 +799,152 @@ void ProcessSession::import(std::string source,
std::shared_ptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145688553
--- Diff: libminifi/include/core/FlowFile.h ---
@@ -50,6 +50,32 @@ class FlowFile : public core::Connectable {
void clearResourceClaim
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145688253
--- Diff: LICENSE ---
@@ -534,4 +534,68 @@ ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN
CONNECTION WITH THE SOFTWARE
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145689143
--- Diff: libminifi/include/core/ProcessSession.h ---
@@ -151,11 +152,47 @@ class ProcessSession {
bool keepSource
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145690546
--- Diff: libminifi/include/processors/FocusArchiveEntry.h ---
@@ -0,0 +1,115 @@
+/**
+ * @file FocusArchiveEntry.h
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145688494
--- Diff: libminifi/include/core/FlowConfiguration.h ---
@@ -35,6 +35,8 @@
#include "processors/ExecuteProcess.h"
#include &
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145714089
--- Diff: LICENSE ---
@@ -534,4 +534,68 @@ ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN
CONNECTION WITH THE SOFTWARE
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145692128
--- Diff: libminifi/src/processors/FocusArchiveEntry.cpp ---
@@ -0,0 +1,340 @@
+/**
+ * @file FocusArchiveEntry.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145740328
--- Diff: CMakeLists.txt ---
@@ -101,6 +101,7 @@ set(CIVETWEB_ENABLE_SSL_DYNAMIC_LOADING OFF CACHE BOOL
"Disable dynamic SSL libr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145724061
--- Diff: CMakeLists.txt ---
@@ -101,6 +101,7 @@ set(CIVETWEB_ENABLE_SSL_DYNAMIC_LOADING OFF CACHE BOOL
"Disable dynamic SSL libr
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj It's not archive that is the problem. It's the usage of uint64_t
over long. *
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/151
@minifirocks merging now. I'll take care of the conflict when merging since
it's a single line change in the readme.
---
Github user phrocker commented on the pull request:
https://github.com/apache/nifi-minifi-cpp/commit/a0268cf374c3e632fde89352d77dcf1be29d75dc#commitcomment-25236501
In .travis.yml:
In .travis.yml on line 68:
A lot of our tests use sockets and often use the same configuration
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj We also haven't explored disabling optimizations to speed up catch
builds or using CATCH_CONFIG_FAST_COMPILE ( which is supposed to help by 20% )
for travis builds.
On my
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@calebj no worries, I'll get this merged. Thanks
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147542555
--- Diff: extensions/http-curl/client/HTTPClient.cpp ---
@@ -175,19 +201,53 @@ bool HTTPClient::submit() {
curl_easy_setopt
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158
MINIFICPP-60: Add initial implementation of Site to Site changes.
MINIFICPP-60: Update interfaces to allow for seamless extension
MINIFICPP-60: Update functions to accomodate
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/158
I'll be going through this myself over the next few days as well, but I
like to leave the comments for others to see on the PR
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/158#discussion_r147542584
--- Diff: libminifi/test/curl-tests/sitetositehttp/HTTPHandlers.h ---
@@ -0,0 +1,322 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/159#discussion_r147553895
--- Diff: libminifi/include/core/ProcessSession.h ---
@@ -19,7 +19,6 @@
#define __PROCESS_SESSION_H__
#include
-#include
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/155
I'll get this merged ASAP.
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/156#discussion_r147533673
--- Diff: extensions/libarchive/ManipulateArchive.cpp ---
@@ -0,0 +1,309 @@
+/**
+ * @file ManipulateArchive.cpp
+ * ManipulateArchive
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/156#discussion_r147532903
--- Diff: extensions/libarchive/ManipulateArchive.cpp ---
@@ -0,0 +1,309 @@
+/**
+ * @file ManipulateArchive.cpp
+ * ManipulateArchive
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/156#discussion_r147533391
--- Diff: extensions/libarchive/ManipulateArchive.cpp ---
@@ -0,0 +1,309 @@
+/**
+ * @file ManipulateArchive.cpp
+ * ManipulateArchive
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/156#discussion_r147532806
--- Diff: extensions/libarchive/ManipulateArchive.cpp ---
@@ -0,0 +1,309 @@
+/**
+ * @file ManipulateArchive.cpp
+ * ManipulateArchive
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/156#discussion_r147533090
--- Diff: extensions/libarchive/ManipulateArchive.cpp ---
@@ -0,0 +1,309 @@
+/**
+ * @file ManipulateArchive.cpp
+ * ManipulateArchive
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/229
MINIFICPP-361: Add debian bootstrap
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/228#discussion_r159792503
--- Diff: extensions/mqtt/AbstractMQTTProcessor.cpp ---
@@ -0,0 +1,158 @@
+/**
+ * @file AbstractMQTTProcessor.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/228#discussion_r159794850
--- Diff: extensions/mqtt/AbstractMQTTProcessor.cpp ---
@@ -0,0 +1,158 @@
+/**
+ * @file AbstractMQTTProcessor.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/228#discussion_r159794068
--- Diff: extensions/mqtt/ConsumeMQTT.h ---
@@ -0,0 +1,125 @@
+/**
+ * @file ConsumeMQTT.h
+ * ConsumeMQTT class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/228#discussion_r159794354
--- Diff: extensions/mqtt/PublishMQTT.h ---
@@ -0,0 +1,142 @@
+/**
+ * @file PublishMQTT.h
+ * PublishMQTT class declaration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/228#discussion_r159792117
--- Diff: extensions/mqtt/AbstractMQTTProcessor.cpp ---
@@ -0,0 +1,158 @@
+/**
+ * @file AbstractMQTTProcessor.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/228#discussion_r159792523
--- Diff: extensions/mqtt/AbstractMQTTProcessor.cpp ---
@@ -0,0 +1,158 @@
+/**
+ * @file AbstractMQTTProcessor.cpp
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/228#discussion_r159793508
--- Diff: extensions/mqtt/AbstractMQTTProcessor.h ---
@@ -0,0 +1,154 @@
+/**
+ * @file AbstractMQTTProcessor.h
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/228#discussion_r159794693
--- Diff: thirdparty/paho.mqtt.c/CMakeLists.txt ---
@@ -0,0 +1,86
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/228#discussion_r159794541
--- Diff: thirdparty/paho.mqtt.c/.travis.yml ---
@@ -0,0 +1,47 @@
+sudo: true
--- End diff --
this file doesn't seem like it's
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/229#discussion_r159968984
--- Diff: bootstrap.sh ---
@@ -115,10 +115,12 @@ OS_REVISION=`echo $EVR | cut -d. -f3`
--- End diff --
Thanks!
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/227
MINIFICPP-355: Resolve issue with 32-bit systems using strtol convertâ¦
â¦ing to long long.
Change log to INFO by default
Disable C2 services to we don't consume
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/235
MINIFICPP-364: resolve issues with test extension. This will cause isâ¦
â¦sues with bootstrapping. Also resolve linkage between civet and curl
extensions
Thank you
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/230#discussion_r160268671
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -40,13 +40,18 @@ namespace core {
#define CONFIG_YAML_CONNECTIONS_KEY
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/237
MINIFICPP-37: Create an executable to support basic localized devops â¦
â¦operations.
This includes stopping components, clearing queues, getting queue
information
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/233
MINIFICPP-362: Prevent segfault is there is no content for a flow file
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/231#discussion_r160290778
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -245,11 +245,11 @@ class YamlConfiguration : public FlowConfiguration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/231#discussion_r160425167
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -245,11 +245,11 @@ class YamlConfiguration : public FlowConfiguration
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/191
I'm currently not a +1 on this PR.
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/242
MINIFICPP-374: Commit Linux power management service that enables theâ¦
⦠threadpools to reduce the number of threads
and throttle active tasks using linux powr constructs
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/226
@achristianson Seems good. It looks like the failing build succeeded. Thanks
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/242#discussion_r161791698
--- Diff: README.md ---
@@ -609,6 +609,21 @@ Additionally, a unique hexadecimal
uid.minifi.device.segment should be assigned
class
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/243
merging now
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/248
MINIFICPP-377: Resolve log level of GPS Test
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162194578
--- Diff: libminifi/src/sitetosite/RawSocketProtocol.cpp ---
@@ -519,7 +519,7 @@ bool RawSiteToSiteClient::bootstrap() {
tearDown
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196014
--- Diff: libminifi/src/core/ProcessSession.cpp ---
@@ -568,16 +568,16 @@ void ProcessSession::import(std::string source,
std::vector<
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/243#discussion_r162199080
--- Diff: extensions/expression-language/Expression.cpp ---
@@ -146,6 +149,124 @@ std::string expr_replaceEmpty(const
std::vector
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196431
--- Diff: libminifi/src/ThreadedSchedulingAgent.cpp ---
@@ -104,10 +104,10 @@ void ThreadedSchedulingAgent::stop() {
void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196401
--- Diff: libminifi/src/capi/Plan.cpp ---
@@ -115,7 +115,7 @@ bool linkToPrevious) {
bool ExecutionPlan::setProperty(const std
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196333
--- Diff: libminifi/src/controllers/SSLContextService.cpp ---
@@ -134,7 +134,7 @@ void SSLContextService::onEnable() {
certificate
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196896
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -193,17 +193,17 @@ void RemoteProcessorGroupPort::onTrigger(const
std::shared_ptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162197063
--- Diff: libminifi/src/FlowControlProtocol.cpp ---
@@ -216,7 +216,7 @@ void FlowControlProtocol::stop() {
if (!running_)
return
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/242#discussion_r162190115
--- Diff: README.md ---
@@ -609,6 +609,21 @@ Additionally, a unique hexadecimal
uid.minifi.device.segment should be assigned
class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162197151
--- Diff:
libminifi/include/core/controller/StandardControllerServiceProvider.h ---
@@ -111,10 +111,10 @@ class StandardControllerServiceProvider
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162197312
--- Diff: extensions/http-curl/sitetosite/HTTPProtocol.cpp ---
@@ -256,7 +256,7 @@ void HttpSiteToSiteClient::closeTransaction(const
std::string
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162195460
--- Diff: libminifi/src/core/ProcessSessionReadCallback.cpp ---
@@ -64,16 +64,16 @@ int64_t
ProcessSessionReadCallback::process(std::shared_ptr
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162194212
--- Diff: main/MiNiFiMain.cpp ---
@@ -110,7 +110,7 @@ int main(int argc, char **argv) {
}
if (signal(SIGINT, sigHandler
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162194109
--- Diff: libminifi/src/sitetosite/SiteToSiteClient.cpp ---
@@ -467,12 +467,12 @@ int16_t SiteToSiteClient::send(std::string
transactionID
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162195004
--- Diff: libminifi/src/sitetosite/RawSocketProtocol.cpp ---
@@ -112,11 +112,11 @@ bool
RawSiteToSiteClient::initiateResourceNegotiation
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/244#discussion_r162196636
--- Diff: libminifi/src/SchedulingAgent.cpp ---
@@ -40,7 +40,7 @@ bool
SchedulingAgent::hasWorkToDo(std::shared_ptr processor
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/237#discussion_r161255479
--- Diff: controller/MiNiFiController.cpp ---
@@ -0,0 +1,196 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/238
MINIFICPP-336: Use correct path when excluding dot files
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/241
MINIFICPP-372: Fix linter error
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/257
MINIFICPP-383: Implement env variable replacement and set the defaultâ¦
⦠for repos to prefix with MINIFI_HOME
Thank you for submitting a contribution to Apache NiFi - MiNiFi C
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/256
Merging and verifying all docker fixes now.
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/259#discussion_r166013537
--- Diff: extensions/mqtt/AbstractMQTTProcessor.cpp ---
@@ -119,6 +126,38 @@ void
AbstractMQTTProcessor::onSchedule(core::ProcessContext *context
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/259#discussion_r166148325
--- Diff: extensions/mqtt/ConsumeMQTT.cpp ---
@@ -35,7 +35,7 @@ namespace nifi {
namespace minifi {
namespace processors
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/261#discussion_r166711961
--- Diff: libminifi/src/core/ConfigurableComponent.cpp ---
@@ -160,6 +161,78 @@ bool
ConfigurableComponent::setSupportedProperties(std::set
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/260
MINIFICPP-382: Implement SUSE release support for SUSE and SLES12
Signed-off-by: Marc Parisi <phroc...@apache.org>
Thank you for submitting a contribution to Apache NiFi -
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/263
Minificpp 396
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/262
UpdateAttributeTests fails when expression language is not built. May want
to put the expression language specific portion of the test under Expression
language tests and have the no-op
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/191
@calebj I've rebased this PR so that it's up to date with master and have
addressed some issues. I'll try to submit a PR against PR shortly after I
finish some final testing.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/37
@jdye64 feel free to close this. Thanks!
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/191
@calebj I submitted a PR, though it has the full history. Did you ever
create a benchmark. While @achristianson linked the benchmark's on github, I've
seen slowdowns of 1-2% when parsing
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/259#discussion_r166103910
--- Diff: extensions/mqtt/ConsumeMQTT.cpp ---
@@ -35,7 +35,7 @@ namespace nifi {
namespace minifi {
namespace processors
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/260
How fitting, a unit test is seg faultingI'll check and update.
---
601 - 700 of 1063 matches
Mail list logo
