Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/148#discussion_r239583364
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/RemoteProcessGroupSchema.java
---
@@ -151,7 +152,7
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/456
reviewing
---
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/148
MINIFI-482 Provide support for multiple URIs.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/3038
@MikeThomsen We (certain folks on the PMC) have some good flexibility with
performing releases to Docker Hub. I think the Alpine addition is certainly
fine and the tagging makes sense. Likely don&#
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/444
verified build and tests on macos and debian. will merge
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/444
dropped the ball on the review. will verify the build for this revert
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/443
This was merged in
https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;a=commit;h=5dffa37d52d52dd8c6c77829f803c5831b3b644e.
Seems like the mirroring to GitHub is a little sluggish
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/441
reviewing
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/438#discussion_r233613094
--- Diff: extensions/http-curl/client/HTTPClient.h ---
@@ -147,6 +146,24 @@ class HTTPClient : public BaseHTTPClient, public
core::Connectable
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/438#discussion_r233611389
--- Diff: extensions/http-curl/client/HTTPClient.h ---
@@ -147,6 +146,24 @@ class HTTPClient : public BaseHTTPClient, public
core::Connectable
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/438
reviewing
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/434
code changes look good. verified build, tests and expected functionality.
will merge
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/434
reviewing
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/433
great, thanks!
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/430
@phrocker it doesn't seem like I was unable to pull them... unfortunately,
may just have to open up a new PR with that commit
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/430
@phrocker would you mind rebasing this? didn't want to make any bad
assumptions between this and current master, otherwise looks good and build was
fine
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/430
reviewing
---
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/139
MINIFI-477 Upgrade dependencies to 1.8.0
This upgrades dependencies to 1.8.0. This should not be merged in until
NiFi 1.8.0 release voting completes and artifacts are generally available, but
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/3096
code, tests, and build all looked good around the handling of connection
interruptions.
verified both publish/consume functionality with a variety of connection
issues in my docker environment
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/3096
reviewing
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/424#discussion_r226987033
--- Diff: OPS.md ---
@@ -0,0 +1,97 @@
+
+
+# Apache NiFi - MiNiFi - Operations Readme.
+
+
+This readme defines operational
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/424#discussion_r226762123
--- Diff: OPS.md ---
@@ -0,0 +1,95 @@
+
+
+# Apache NiFi - MiNiFi - Operations Readme.
+
+
+This readme defines operational
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/424#discussion_r226762000
--- Diff: OPS.md ---
@@ -0,0 +1,95 @@
+
+
+# Apache NiFi - MiNiFi - Operations Readme.
+
+
+This readme defines operational
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/424#discussion_r226987090
--- Diff: OPS.md ---
@@ -0,0 +1,97 @@
+
+
+# Apache NiFi - MiNiFi - Operations Readme.
+
+
+This readme defines operational
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/424#discussion_r226762332
--- Diff: OPS.md ---
@@ -0,0 +1,95 @@
+
+
+# Apache NiFi - MiNiFi - Operations Readme.
+
+
+This readme defines operational
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/424
great, thanks!
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/424
Haven't really dug in, but I did see that Travis is reporting that the
C2Jstack test is failing. Seems like it might be environmental for Travis but
haven't inspected too much.
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/424
reviewing
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/420
Thanks for updating. Will get this merged in.
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/420#discussion_r226386769
--- Diff: libminifi/src/capi/api.cpp ---
@@ -57,38 +57,28 @@ class DirectoryConfiguration {
}
};
-nifi_port *create_port(const
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/420#discussion_r226382717
--- Diff: libminifi/src/capi/api.cpp ---
@@ -57,38 +57,28 @@ class DirectoryConfiguration {
}
};
-nifi_port *create_port(const
Github user apiri closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/418
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/418
Closing in favor of #419
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/419
reviewing
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418#discussion_r226051353
--- Diff: docker/Dockerfile ---
@@ -67,7 +67,7 @@ ENV MINIFI_HOME
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
RUN cd $MINIFI_BASE_DIR
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418#discussion_r225751738
--- Diff: docker/Dockerfile ---
@@ -67,7 +67,7 @@ ENV MINIFI_HOME
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
RUN cd $MINIFI_BASE_DIR
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418#discussion_r225749065
--- Diff: docker/Dockerfile ---
@@ -67,7 +67,7 @@ ENV MINIFI_HOME
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
RUN cd $MINIFI_BASE_DIR
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-site/pull/31
Add Slack Workspace information and invite link.
Add Slack Workspace information and invite link.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418
MINIFICPP-642 Disable shared libs for Docker image build.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/415
Organization and docs look good, will get this merged in. Thanks!
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/415
I see now that those changes came in just as I posted those comments.
Those updates look good here.
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/415#discussion_r224886539
--- Diff: libminifi/src/c2/C2Agent.cpp ---
@@ -187,6 +209,22 @@ void C2Agent::configure(const
std::shared_ptr &configure, bool re
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/3066
Verified the build and functionality against AWS resources. I did note
that the jackson-dataformat-cbor dependency was outdated and also updated that
to the latest of 2.9.7. All operations worked as
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/415
No worries. Will keep an eye out for it. Thanks!
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/415
there is a compilation error in Travis builds and verified similar a local
build
>
/Users/apiri/Development/code/apache/nifi-minifi-cpp/libminifi/src/Properties.cpp:36:18:
er
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/412
reviewing
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/404#discussion_r224579812
--- Diff: PYTHON.md ---
@@ -0,0 +1,47 @@
+
+
+# Apache NiFi - MiNiFi - C++ Python Access.
+
+
+This readme provides a how-to
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/404#discussion_r224541169
--- Diff: PYTHON.md ---
@@ -0,0 +1,47 @@
+
+
+# Apache NiFi - MiNiFi - C++ Python Access.
+
+
+This readme provides a how-to
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/404
reviewing latest update
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/404#discussion_r224445025
--- Diff: PYTHON.md ---
@@ -0,0 +1,47 @@
+
+
+# Apache NiFi - MiNiFi - C++ Python Access.
+
+
+This readme provides a how-to
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/404
reviewing
---
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/138
MINIFI-470 Updating dependency versions for items inclusive of Springâ¦
â¦, Bouncycastle, Jetty as reported by versions:display-dependency-update.
Thank you for submitting a
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-site/pull/30
Remove licensing comments as it is rendered in markdown.
Remove licensing comments as it is rendered in markdown.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/137
MINIFI-471 Update to a more recent version of Jetty aligned with NiFi.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/409
Changes look good and build was fine. Will merge.
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/409
reviewing
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/409
reviewing
---
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/403
MINIFICPP-616 Run appveyor on all branches
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/402
reviewing
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/399
works as advertised. verified build and functionality after rebasing on
master
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/399
reviewing
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/394
Had some issues on a VM environment with build but seems to be just
something on that system's configuration. A clean Windows 10 VM as well as a
baremetal Win 10 built and worked wi
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/394#discussion_r218533580
--- Diff: LICENSE ---
@@ -1427,3 +1451,183 @@ This product bundles 'bsdiff' which is available
under a "2-clause BSD" lice
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/398
reviewing
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/394#discussion_r217873438
--- Diff: LICENSE ---
@@ -1427,3 +1451,183 @@ This product bundles 'bsdiff' which is available
under a "2-clause BSD" lice
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/394#discussion_r217873295
--- Diff: CMakeSettings.json ---
@@ -0,0 +1,146 @@
+{
+ // See https://go.microsoft.com//fwlink//?linkid=834763 for more
information about
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/394
reviewing
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/395#discussion_r217225824
--- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
@@ -201,10 +216,9 @@ class RemoteProcessorGroupPort : public
core::Processor
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/395#discussion_r217225710
--- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
@@ -137,16 +141,27 @@ class RemoteProcessorGroupPort : public
core::Processor {
std
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/395#discussion_r217225666
--- Diff: libminifi/include/RemoteProcessorGroupPort.h ---
@@ -88,12 +93,11 @@ class RemoteProcessorGroupPort : public core::Processor
{
if
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/396
changes look good. verified build and tests. saw the appropriate format
change in generated output.
will merge
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/396
reviewing
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/393#discussion_r213437908
--- Diff: bootstrap.sh ---
@@ -25,6 +25,7 @@ CORES=1
BUILD="false"
PACKAGE="false"
BUILD_IDENTIFIER=&quo
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/389#discussion_r213437719
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -209,7 +225,8 @@ void RemoteProcessorGroupPort::onTrigger(const
std::shared_ptrlog_trace
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/393
@phrocker would you mind please rebasing this on master? I unfortunately
missed the PR coming when reviewing #392. The merge conflicts look relatively
straightforward but I don't wa
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/392
reviewing
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2914#discussion_r210130185
--- Diff:
nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes/UpdateAttribute.java
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/2940
Performed a build and verified both the Maven and the Hub (using 1.7.0)
variants and worked as anticipated. I think this should make it a bit easier
for folks to migrate between versions
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/381
looks like we have a test failure:
```
---
Test Valid Regex
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/388
As long as we have a ticket for it that works for me. Will review the
updates.
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/388#discussion_r208041393
--- Diff: extensions/pcap/CapturePacket.cpp ---
@@ -54,13 +54,15 @@ namespace processors {
std::shared_ptr CapturePacket::id_generator_ =
utils
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/388#discussion_r207919579
--- Diff: extensions/pcap/CapturePacket.cpp ---
@@ -54,13 +54,15 @@ namespace processors {
std::shared_ptr CapturePacket::id_generator_ =
utils
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/388#discussion_r207762481
--- Diff: extensions/pcap/CapturePacket.cpp ---
@@ -54,13 +54,15 @@ namespace processors {
std::shared_ptr CapturePacket::id_generator_ =
utils
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/387
code changes look good. was able to verify the issue before PR and then
its resolution with the patch applied. will get this merged. thanks!
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/387
reviewing
---
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/383#discussion_r207655014
--- Diff: linux.sh ---
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/383#discussion_r206919848
--- Diff: linux.sh ---
@@ -0,0 +1,40 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/386
@dtrodrigues thanks for finding and correcting. will get this merged in.
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/384
looks good here. will merge.
---
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/2866
hey @SarthakSahu, will put this on my list of things to scope out. sorry
for the delay but really appreciate you taking this task on. Going to list a
couple of other folks that might have knowledge
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/134
MINIFI-468 Updating Docker resources to next release version and adjuâ¦
MINIFI-468 Updating Docker resources to next release version and adjusting
release binary URL.
Thank you for
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/2905
Sounds good. Thanks for confirming.
---
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/2905
hey @MikeThomsen,
Didn't know if you wanted to check this out a bit more. If not, I am happy
to close it out and merge it in.
Thanks!
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
It looks like this went in before we had outstanding items tended to, the
least of which would be an issue which I do not currently see in JIRA. We
should either get those tasks captured
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
@phrocker I missed those when they got folded up by the GitHub view.
Apologies for that.
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/347
@achristianson would you mind rebasing this one last time so we can merge
it in?
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/382
+1
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/378
code changes look good. verified manifest functionality using minifi
controller. will get this merged.
---
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/378
reviewing
---
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi/pull/133
MINIFI-461 Additionally providing controller initialization time in seconds
MINIFI-461 Additionally providing controller initialization time in seconds
Thank you for submitting a
1 - 100 of 886 matches
Mail list logo
