Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/3009
@SarthakSahu Recommend sticking with /bin/sh, as Alpine base images don't
usually contain /bin/bash.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/3031
Reviewed, looks great, +1.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2951
Well since I was the judge on the original NIFI-4272 case and didn't catch
the side effects, perhaps I shouldn't be the one to hear the appeal.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2949
Added a commit to include some documentation
---
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2949
NIFI-3672 Add support for strongly typed message properties in PublishJMS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mosermw/nifi NIFI-3672
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2936
+1 from me, though I didn't test this against a real RabbitMQ server.
@zenfenan did you want to take another look?
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2936
Please do add Port to your PR, if you can, then I think this will also
cover NIFI-4723. It looks like PORT_VALIDATOR already supports expression
language, so you are good there.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2936
If you are using VARIABLE_REGISTRY to dynamically evaluate the Host,
shouldn't you also allow it for Port?
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2823
Seems like this could be useful, and certainly doesn't hurt. +1 from me.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2931
The JIRA ticket mentioned a dev list conversation where Oleg said it was to
limit the possibility of message loss in the event of a processor and/or NiFi
crash. However, it has proven to cause
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2931
NIFI-3531 Moved session.recover in JMSConsumer to exceptional situations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mosermw/nifi nifi-3531
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2916
Reviewed and the issue is resolved, +1 will merge.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2904
Thank you @pvillard31, I appreciate your time to merge this.
---
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2904
NIFI-5196 Fixed JMS connection leak when uncaught exceptions happen
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mosermw/nifi NIFI-5196
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2796
NIFI-5275 PostHTTP SocketConfig setup, fixed connection pool when ...
using HTTPS, setup idle connection checker, setup request retry handler,
improved some exception handling
Thank you
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2767
@mattyb149 I think the issue is whether there is a reasonable expectation
that a user would loop back a 'failure' relationship, and precedent set in
other similar processors. For example, I
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2767
Yeah, but there's only 1 other processor in the codebase that does data
transformation and does penalize on failure. By far most processors that
penalize on failure are ingress/egress processors
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2767
One never knows how a dataflow manager will design their flow, so I was
just trying to cover all bases. I don't think a downstream consumer would
notice that the failure files were penalized
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2767
@ottobackwards This post is old but I think still applies. In general,
most regular expression engines use recursion for some things.
https://stackoverflow.com/questions/7509905/java-lang
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2767
The situation I'm trying to catch uses a regular expression that looks
legitimate, so can't be caught while validating configuration, but then blows
up when the input flowfile causes the Pattern
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2767
I'm not sure I understand what your suggestion is @joewitt. Would you
clarify for me? Should I code it to catch StackOverflowError, which is the use
case that I need to handle cleanly?
The code
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2767
NIFI-5274 avoid rollback on uncaught errors in ReplaceText
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2748
+1 this looks good to me. I will squash and merge. Thanks @ottobackwards!
---
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2748#discussion_r193232920
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2748#discussion_r193223710
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java
---
@@ -79,7
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2748#discussion_r193230207
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2497
Hi @mcgilman I made the suggested changes, rebased from master, and force
pushed to this branch. What do you think?
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2559
I see the latest update, and +1 it looks good.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2559
Hi @markobean, I reviewed this and I have a couple of questions. I'm not
sure I understand why the `throw e;` statements were removed from MergeContent.
Can you explain or put them back in? Also
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2557
Reviewed and tested; behavior in the presence of a duplicate fragment is
fixed; duplicate is sent to failure. I fixed a typo and used
FragmentAttributes.FRAGMENT_INDEX enum in place
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2497
@mcgilma @markap14 I'm not sure I was able to fully grok "add a ConfigDTO
which is set on the AboutDTO" but I gave it a shot. Rebased from master and
pushed a new commit. Let me know what
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2487
@mattyb149 and @markap14 with the 1.6.0 release approaching, do you think
we've allowed enough time for review and testing? Is this good to go? Thanks.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1240
I tested this a lot, and based on the conversation in the JIRA ticket, I
adjusted the purge low water mark to 88%. This allows the prov_repo to purge
old events quicker after a large spike in events
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2487
I tested this and I was able to switch back and forth between
MinimalLockingWriteAheadLog and SequentialAccessWriteAheadLog. +1 from me.
It's best to make this switch while there are 0 flowfiles
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2497
@markap14 and @mcgilman I did consider that backpressure settings didn't
really belong in AboutDTO. The BannerDTO also pulls information from
nifi.properties, but I didn't think backpressure fit
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2458
@markap14 I added a commit to do character set validation in a property
validator instead of OnScheduled.
---
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2458#discussion_r171354166
--- Diff:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java
---
@@ -136,9 +155,16
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2458#discussion_r171296519
--- Diff:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java
---
@@ -136,9 +155,16
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2497
NIFI-3599 Allowed back pressure object count and data size to be
configurable
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution
Github user mosermw closed the pull request at:
https://github.com/apache/nifi/pull/2496
---
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2496
NIFIDEV-3599 Allowed back pressure object count and data size to be
configurable
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2458
Added a third commit to improve documentation.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2469
Hi @alopresto, should we update the copyright year to 2018 in the
applicable NOTICE files?
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2458
I added a second commit, to make the character set encoding configurable
for JMS TextMessages, in both PublishJMS and ConsumeJMS. Thanks @markap14 for
pointing this out, because this is a good
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2458#discussion_r167258538
--- Diff:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/PublishJMS.java
---
@@ -131,4 +143,10
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2458#discussion_r167255119
--- Diff:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/PublishJMS.java
---
@@ -131,4 +143,10
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2458#discussion_r167244022
--- Diff:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/PublishJMS.java
---
@@ -131,4 +143,10
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1240
I think this PR is still valid, though perhaps with some tweaks to
PURGE_OLD_EVENTS_HIGH_WATER, PURGE_OLD_EVENTS_LOW_WATER and ROLLOVER_HIGH_WATER
as discussed in the JIRA.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1241
@jskora I think you are the only one who can close this PR. Would you
mind? Thanks!
---
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2458
NIFI-2630 Allow PublishJMS to send TextMessages
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2456
Nevermind my last comment. It looks like this is going to resolve both
unit test failures.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2456
@markap14 I tried your change locally and it does fix one of the two test
failures. The validateConsumeWithCustomHeadersAndProperties() is fixed but
validateFailOnUnsupportedMessageType() still
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2445
I get the exact same unit test failures on Ubuntu 16.04. I was working on
NIFI-2630, so I thought it was my code changes, but the test failure happens
when I build master without any changes
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2434
Hi @m-hogue I got an error when trying to test PostHTTP sending to a
ListenHTTP with this PR.
2018-02-02 22:15:43,007 ERROR [Timer-Driven Process Thread-7
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2412
NIFI-4699 Use a filter in PostHTTP to pull flowfiles from queue whoseâ¦
⦠URL is the same
Thank you for submitting a contribution to Apache NiFi.
In order to streamline
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2381
NIFI-4697 clarified some PostHTTP documentation
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2284
I rebased and force pushed the discussed changes. It appears that the
Travis failure is unrelated?
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2284
Thank you Joe and Koji for taking a look at this. I struggled with
deciding whether to provide a default UnsupportedOperationException or to
provide the new methods in the various
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1637
Bump. I had forgotten about this, but it looks like it can still merge
cleanly.
---
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/222
Since TIBCO libraries don't fall under a license that is compatible with
the Apache License 2.0, Apache NiFi cannot distribute a solution that is
specific to TIBCO. But you should be able to build
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2284
NIFI-4504, NIFI-4505 added methods to MapCache API â¦
⦠including keySet, removeAndGet, removeByPatternAndGet
cleaned up some warnings on deprecated nifi.stream.io classes
I
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2260
Code looks good, full build with contrib-check passes, and I tested a small
flow with success & failure results as expected. +1 merged.
There is a comment in the ProtocolHandshake c
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/2260
Reviewing. I will have a PR soon against this same code, so I would rather
get this one committed and rebase before I submit my PR.
---
Github user mosermw closed the pull request at:
https://github.com/apache/nifi/pull/2041
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/2041
NIFI-3736 modify default nifi.content.claim.max.appendable.size
in nifi.properties to 1 MB
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2010#discussion_r128633148
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/FileSystemRepository.java
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1832
NIFI-1452 on timer-driven yield, use the greater of yield duration or run
schedule
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1732
+1 contrib-check, verified unit tests before and after the fix, ran a
simple flow, and looks like it matches master branch. Thanks @jskora will
merge to 0.x branch.
---
If your project is set up
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1732
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mosermw closed the pull request at:
https://github.com/apache/nifi/pull/1723
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1723
Thanks @trkurc, with your +1 I'll go ahead and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1723
NIFI-3223 added support for expression language to PublishAMQP
properties supporting EL are EXCHANGE and ROUTING_KEY. This is a PR for
the 0.x branch, using changes from #1449.
Thank you
Github user mosermw closed the pull request at:
https://github.com/apache/nifi/pull/1699
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mosermw closed the pull request at:
https://github.com/apache/nifi/pull/1688
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mosermw closed the pull request at:
https://github.com/apache/nifi/pull/1667
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mosermw closed the pull request at:
https://github.com/apache/nifi/pull/1666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1699
NIFI-3725 - validate processors only when they are in STOPPED state
- report validation errors via REST API on processors/services/tasks/ports
only when they are in the STOPPED state
Thank
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1688
NIFI-3553 FetchFileTransfer fix
This is a port from master to the 0.x branch. Reviewer can squash to
remove my commit for Java 7 compatibility.
Thank you for submitting a contribution
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1680
Builds and executes as expected, and resolves the issue. Thanks @jvwing.
+1 will merge to 0.x
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1680
reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1670
Would you close this PR @jvwing? Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1670
+1 will merge. Thanks @jvwing.
It looks like I should also migrate the changes from NIFI-2763 and
NIFI-2902 (V4 Signer support) over to the 0.x branch as well, to avoid breaking
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1670
Thanks for this @jvwing. Would you mind updating the
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-nar/src/main/resources/META-INF/NOTICE
and nifi-assembly/NOTICE files to remove the 1 line from each
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1667
NIFI-3019 cherry-picked from NIFI-3692 into 0.x branch
NIFI-3692 Use hbc-core instead of hbc-twitter4j in social-media bundle to
resolve org.json cat-x
Thank you for submitting
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1666
NIFI-3018 removed flume-twitter-source due to usage of org.json cat-x lib
This change is essentially copied from master to 0.x branch
Thank you for submitting a contribution to Apache NiFi
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1637#discussion_r109018746
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/impl
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1637
NIFI-3648 removed cluster message copying when not in debug mode
I expect NIFI-3648 could have several PRs, and that they will not be
included in 1.2.0 release, so review of this can be delayed
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1621
NIFI-3304 removed unneeded Java 8 codecache info from Admin Guide
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1603
NIFI-2481 improved content repo archive description in Admin Guide
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1580#discussion_r106473572
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/FileSystemRepository.java
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1580#discussion_r106435047
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/FileSystemRepository.java
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1580
+1 looks good, passes checkstyle, runs in NiFi on Windows when creating
content_repository on startup and when it already exists. I will squash and
merge to master. Thanks @PuspenduBanerjee
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1580#discussion_r105747874
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/FileSystemRepository.java
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1548
@ShellyLC If you wouldn't mind opening a NIFI JIRA ticket for this bug, we
would really appreciate it!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mosermw commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1214#discussion_r102828860
--- Diff:
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/AbstractDemarcator.java
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user mosermw closed the pull request at:
https://github.com/apache/nifi/pull/1509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user mosermw opened a pull request:
https://github.com/apache/nifi/pull/1509
NIFI-3362 update FlowConfiguration.xsd to allow all current time period
units
@apiri I pulled out the new unit test that was in master from this 0.x PR.
I would have needed a new flow.xml
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1481
@trixpan the "This closes" commit hook doesn't work on the 0.x branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1481
Reviewed, along with #1475. Licensing concern about the code looks to be
resolved. +1 will merge
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1494
Reviewed, verified the new unit test describes the scenario in NIFI-3403,
that it fails before the fix and succeeds after the fix. Also verified in a
full running NiFi. +1 will merge, thanks
1 - 100 of 149 matches
Mail list logo
