dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1372398279
@exceptionfactory Is there anything else that needs to be done for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1370134527
@exceptionfactory I noticed the build ci-workflow / Ubuntu Zulu JDK 11 HI
failed but it failed on a unit test unrelated to my changes. Also the
ci-workflow / Ubuntu Zulu JDK 17 EN timed out.
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1366789116
@exceptionfactory I added the null literal as you requested and modified the
documentation to reflect this. Please let me know if my changes are what you
were intending. Thanks!
--
This
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364270877
@exceptionfactory I am fine with only implementing the the seven argument
constructor. What did you have in mind for implementing a literal null as a
function argument? I only question if it
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1364180293
> Thanks for clarifying the intent @dan-s1, constructing the complete URI in
a single function makes sense.
>
> With that background, do you need all of the possible constructor
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1363956081
> Thanks for working on this new feature @dan-s1. Although most of the
implementation makes sense, it raises some questions about treating blanks
strings as nulls. Although the
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1363125181
@exceptionfactory Wondering if this could be revisited. It is functionality
my team could use. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1330825220
@exceptionfactory Now that 1.19.0 has been released, when you have some time
can you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the
dan-s1 commented on PR #6689:
URL: https://github.com/apache/nifi/pull/6689#issuecomment-1322669243
@exceptionfactory If you have time, can you please review this in order for
this to get into 1.19?
--
This is an automated message from the Apache Git Service.
To respond to the message,
