[GitHub] daisy-ycguo commented on issue #716: Some source files are missing Apache license headers

daisy-ycguo commented on issue #716: Some source files are missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716#issuecomment-364309959 @mrutkows As mentioned in the section "WHAT FILES IN AN APACHE RELEASE DO NOT REQUIRE A LICENSE

[GitHub] daisy-ycguo commented on issue #716: Some source files are missing Apache license headers

daisy-ycguo commented on issue #716: Some source files are missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716#issuecomment-364309959 @mrutkows As said in [Apache release policy

[GitHub] csantanapr commented on issue #681: proper handling of 'default' package name

csantanapr commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-364311287 I like the solution ?default? is already reserved package name because of web actions uri +1

[GitHub] daisy-ycguo commented on issue #716: Some source files are missing Apache license headers

daisy-ycguo commented on issue #716: Some source files are missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716#issuecomment-364310279 @mrutkows Thank you for merging PR #709. This issue has been fixed. Now wskdeploy can pass the license

[GitHub] daisy-ycguo commented on issue #716: Some source files are missing Apache license headers

daisy-ycguo commented on issue #716: Some source files are missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716#issuecomment-364309959 @mrutkows Please refer to

[GitHub] ScottChapman commented on issue #681: proper handling of 'default' package name

ScottChapman commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-364303316 I can live with that. This is an automated

[GitHub] mrutkows commented on issue #709: Add Apache License

mrutkows commented on issue #709: Add Apache License URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/709#issuecomment-364294635 @daisy-ycguo next time please label the issue "review" and add me as reviewer (or who you feel is appropriate) or I do not know it is "ready"

[GitHub] mrutkows commented on issue #709: Add Apache License

mrutkows commented on issue #709: Add Apache License URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/709#issuecomment-364294439 @daisy-ycguo well done! This is an automated message from the Apache Git

[GitHub] pritidesai commented on issue #681: proper handling of 'default' package name

pritidesai commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-364292402 After talking to Matt and scoping this feature of creating OW entities under `namespace/` rather than `namespace/`,

[GitHub] pritidesai commented on issue #681: proper handling of 'default' package name

pritidesai commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-364292402 After talking to Matt and scoping this feature of creating OW entities under `namespace/` rather than `namespace/`,

[GitHub] csantanapr closed issue #15: This is a test issue "ET Phone HOME !!"

csantanapr closed issue #15: This is a test issue "ET Phone HOME !!" URL: https://github.com/apache/incubator-openwhisk-runtime-docker/issues/15 This is an automated message from the Apache Git Service. To respond to the

[GitHub] csantanapr commented on issue #15: This is a test issue "ET Phone HOME !!"

csantanapr commented on issue #15: This is a test issue "ET Phone HOME !!" URL: https://github.com/apache/incubator-openwhisk-runtime-docker/issues/15#issuecomment-364282792 problem fixed and INFRA ticket closed https://issues.apache.org/jira/browse/INFRA-15998

[GitHub] csantanapr opened a new issue #15: This is a test issue "ET Phone HOME !!"

csantanapr opened a new issue #15: This is a test issue "ET Phone HOME !!" URL: https://github.com/apache/incubator-openwhisk-runtime-docker/issues/15 This is a test issue to see if the email notifications are going to issues@ and not dev@ for the Apache OpenWhisk mailing lists.

[GitHub] houshengbo closed pull request #61: Adding placeholder for apigw access token

houshengbo closed pull request #61: Adding placeholder for apigw access token URL: https://github.com/apache/incubator-openwhisk-client-go/pull/61 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] houshengbo commented on issue #173: Added test cases for quoted strings.

houshengbo commented on issue #173: Added test cases for quoted strings. URL: https://github.com/apache/incubator-openwhisk-cli/pull/173#issuecomment-364265724 @jessealva please take a look at the issue: https://github.com/apache/incubator-openwhisk-cli/issues/221 Travis build is not

[GitHub] mrutkows closed pull request #719: Adding examples of web action annotations

mrutkows closed pull request #719: Adding examples of web action annotations URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/719 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] mrutkows closed issue #712: Action: Web (action): Support the require-whisk-auth annotation

mrutkows closed issue #712: Action: Web (action): Support the require-whisk-auth annotation URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/712 This is an automated message from the Apache Git Service.

[GitHub] mrutkows closed issue #710: Actions: Web (export): Support "final" annotation

mrutkows closed issue #710: Actions: Web (export): Support "final" annotation URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/710 This is an automated message from the Apache Git Service. To respond to

[GitHub] mrutkows closed issue #711: Action: Web (export): Support web-custom-options annotation

mrutkows closed issue #711: Action: Web (export): Support web-custom-options annotation URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/711 This is an automated message from the Apache Git Service. To

[GitHub] markusthoemmes commented on a change in pull request #3256: Refactor some bits of the triggers API.

markusthoemmes commented on a change in pull request #3256: Refactor some bits of the triggers API. URL: https://github.com/apache/incubator-openwhisk/pull/3256#discussion_r167069427 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@

[GitHub] mdeuser commented on a change in pull request #3256: Refactor some bits of the triggers API.

mdeuser commented on a change in pull request #3256: Refactor some bits of the triggers API. URL: https://github.com/apache/incubator-openwhisk/pull/3256#discussion_r167068356 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -372,58

[GitHub] rabbah commented on issue #3262: Handle trigger activations with inactive rules

rabbah commented on issue #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#issuecomment-364245062 @mdeuser can you take a look at #3256 I think we should get that one in first as it will benefit the enhancement in this PR.

[GitHub] mrutkows closed pull request #723: Add the integration test back to the Travis build

mrutkows closed pull request #723: Add the integration test back to the Travis build URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/723 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rabbah commented on a change in pull request #3256: Refactor some bits of the triggers API.

rabbah commented on a change in pull request #3256: Refactor some bits of the triggers API. URL: https://github.com/apache/incubator-openwhisk/pull/3256#discussion_r167062871 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -305,59

[GitHub] rabbah commented on a change in pull request #3256: Refactor some bits of the triggers API.

rabbah commented on a change in pull request #3256: Refactor some bits of the triggers API. URL: https://github.com/apache/incubator-openwhisk/pull/3256#discussion_r167063189 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -305,59

[GitHub] markusthoemmes commented on a change in pull request #3256: Refactor some bits of the triggers API.

markusthoemmes commented on a change in pull request #3256: Refactor some bits of the triggers API. URL: https://github.com/apache/incubator-openwhisk/pull/3256#discussion_r167062270 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@

[GitHub] sciabarracom commented on issue #19: support go actions

sciabarracom commented on issue #19: support go actions URL: https://github.com/apache/incubator-openwhisk/issues/19#issuecomment-364242226 I am looking to the implementation of the nodejs runner. I wonder if the right implementation of a go action should not be instead of requiring an

[GitHub] sciabarracom commented on issue #19: support go actions

sciabarracom commented on issue #19: support go actions URL: https://github.com/apache/incubator-openwhisk/issues/19#issuecomment-364242226 I am looking to the implementation of the nodejs runner. I wonder if the right implementation of a go action should not be instead of requiring an

[GitHub] houshengbo opened a new pull request #723: Add the integration test back to the Travis build

houshengbo opened a new pull request #723: Add the integration test back to the Travis build URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/723 This is an automated message from the Apache Git Service. To

[GitHub] pritidesai commented on a change in pull request #715: Adding support for export managed project back to manifest

pritidesai commented on a change in pull request #715: Adding support for export managed project back to manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/715#discussion_r167048358 ## File path: cmd/export.go ## @@ -0,0 +1,266 @@ +/* + * Licensed

[GitHub] pritidesai commented on a change in pull request #715: Adding support for export managed project back to manifest

pritidesai commented on a change in pull request #715: Adding support for export managed project back to manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/715#discussion_r167052402 ## File path: cmd/export.go ## @@ -0,0 +1,266 @@ +/* + * Licensed

[GitHub] mrutkows closed pull request #722: Add the correct api key

mrutkows closed pull request #722: Add the correct api key URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/722 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] mrutkows opened a new issue #27: Please list Stage 1 release plan includes "source TAR only" and list included repos.

mrutkows opened a new issue #27: Please list Stage 1 release plan includes "source TAR only" and list included repos. URL: https://github.com/apache/incubator-openwhisk-release/issues/27 On the main README.md, we need to clearly say what is in Stage 1 release. That is, it includes

[GitHub] mrutkows closed pull request #721: Comment out the integration tests

mrutkows closed pull request #721: Comment out the integration tests URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/721 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] houshengbo opened a new pull request #721: Comment out the integration tests

houshengbo opened a new pull request #721: Comment out the integration tests URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/721 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rabbah closed pull request #3261: Pin docker engine version on ubuntu

rabbah closed pull request #3261: Pin docker engine version on ubuntu URL: https://github.com/apache/incubator-openwhisk/pull/3261 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] rabbah commented on a change in pull request #3262: Handle trigger activations with inactive rules

rabbah commented on a change in pull request #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#discussion_r167034972 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@

[GitHub] rabbah commented on a change in pull request #3256: Refactor some bits of the triggers API.

rabbah commented on a change in pull request #3256: Refactor some bits of the triggers API. URL: https://github.com/apache/incubator-openwhisk/pull/3256#discussion_r167033685 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -305,59

[GitHub] rabbah commented on a change in pull request #3256: Refactor some bits of the triggers API.

rabbah commented on a change in pull request #3256: Refactor some bits of the triggers API. URL: https://github.com/apache/incubator-openwhisk/pull/3256#discussion_r167034113 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -305,59

[GitHub] mdeuser commented on a change in pull request #3262: Handle trigger activations with inactive rules

mdeuser commented on a change in pull request #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#discussion_r167031517 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@

[GitHub] ScottChapman commented on issue #705: Unable to use ENV VARS in input JSON

ScottChapman commented on issue #705: Unable to use ENV VARS in input JSON URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/705#issuecomment-364207364 I think the issue isn't what syntax is used for injecting env vars, the issue is that right now the text associated

[GitHub] rabbah commented on a change in pull request #3262: Handle trigger activations with inactive rules

rabbah commented on a change in pull request #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#discussion_r167026849 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@

[GitHub] rabbah commented on a change in pull request #3262: Handle trigger activations with inactive rules

rabbah commented on a change in pull request #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#discussion_r167027116 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@

[GitHub] rabbah commented on a change in pull request #3262: Handle trigger activations with inactive rules

rabbah commented on a change in pull request #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262#discussion_r167026849 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@

[GitHub] lionelvillard commented on issue #705: Unable to use ENV VARS in input JSON

lionelvillard commented on issue #705: Unable to use ENV VARS in input JSON URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/705#issuecomment-364205529 Looking at k8s and helm, templating is based on go templates (`{{ .username }}`). Maybe we could have the same for

[GitHub] csantanapr commented on issue #84: make travis more efficient

csantanapr commented on issue #84: make travis more efficient URL: https://github.com/apache/incubator-openwhisk-package-pushnotifications/pull/84#issuecomment-364203880 @drcariel abandoned PR? Can I close it? This is an

[GitHub] csantanapr closed pull request #86: Do not hard code API host of push notification service

csantanapr closed pull request #86: Do not hard code API host of push notification service URL: https://github.com/apache/incubator-openwhisk-package-pushnotifications/pull/86 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] mdeuser opened a new pull request #3262: Handle trigger activations with inactive rules

mdeuser opened a new pull request #3262: Handle trigger activations with inactive rules URL: https://github.com/apache/incubator-openwhisk/pull/3262 - log trigger activation entry for disabled rules (but at least one active rule is needed to create a trigger activation record) - if

[GitHub] mrutkows opened a new pull request #23: WIP: Add support for a minified ASF license that uses # hash prefix.

mrutkows opened a new pull request #23: WIP: Add support for a minified ASF license that uses # hash prefix. URL: https://github.com/apache/incubator-openwhisk-utilities/pull/23 This is an automated message from the Apache

[GitHub] csantanapr closed pull request #720: Add the support to generate the "latest" tag automatically

csantanapr closed pull request #720: Add the support to generate the "latest" tag automatically URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/720 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] jasonpet opened a new pull request #126: optionally limit cron fields to 5 instead of 6

jasonpet opened a new pull request #126: optionally limit cron fields to 5 instead of 6 URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/126 This allows vendors to limit the finest granularity to 1 minute instead of 1 second.

[GitHub] houshengbo opened a new pull request #720: Add the support to generate the "latest" tag automatically

houshengbo opened a new pull request #720: Add the support to generate the "latest" tag automatically URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/720 This is an automated message from the Apache Git

[GitHub] michaelmarth commented on issue #716: Some source files are missing Apache license headers

michaelmarth commented on issue #716: Some source files are missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716#issuecomment-364165889 @bdelacretaz do you happen to have input on the above?

[GitHub] jasonpet commented on a change in pull request #86: Do not hard code API host of push notification service

jasonpet commented on a change in pull request #86: Do not hard code API host of push notification service URL: https://github.com/apache/incubator-openwhisk-package-pushnotifications/pull/86#discussion_r166982594 ## File path: packages/actions/sendMessage.js ## @@

[GitHub] mrutkows commented on issue #716: Some source files are missing Apache license headers

mrutkows commented on issue #716: Some source files are missing Apache license headers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716#issuecomment-364156898 @daisy-ycguo So other Apache projects have ASF headers for: - .md - .yaml (config files)

[GitHub] tardieu opened a new pull request #3261: Pin docker engine version on ubuntu

tardieu opened a new pull request #3261: Pin docker engine version on ubuntu URL: https://github.com/apache/incubator-openwhisk/pull/3261 We require a specific docker engine version on ubuntu. We should pin the package so that it does not get automatically updated when running system-wide

[GitHub] markusthoemmes commented on a change in pull request #3240: Add a loadbalancer with local state and horizontal invoker sharding.

markusthoemmes commented on a change in pull request #3240: Add a loadbalancer with local state and horizontal invoker sharding. URL: https://github.com/apache/incubator-openwhisk/pull/3240#discussion_r166954536 ## File path:

[GitHub] dubeejw commented on a change in pull request #3254: Do not disable rule when it is updated

dubeejw commented on a change in pull request #3254: Do not disable rule when it is updated URL: https://github.com/apache/incubator-openwhisk/pull/3254#discussion_r166935522 ## File path: core/controller/src/main/scala/whisk/core/controller/Rules.scala ## @@ -313,7

[GitHub] rabbah commented on issue #3241: Impossible the see usage of a shared package

rabbah commented on issue #3241: Impossible the see usage of a shared package URL: https://github.com/apache/incubator-openwhisk/issues/3241#issuecomment-364100745 A related thought - today when you invoke an action through a binding, the resolution to the package happens fairly early on.

[GitHub] rabbah commented on issue #3241: Impossible the see usage of a shared package

rabbah commented on issue #3241: Impossible the see usage of a shared package URL: https://github.com/apache/incubator-openwhisk/issues/3241#issuecomment-364100745 A related thought - today when you invoke an action through a binding, the resolution to the package happens fairly early on.

[GitHub] rabbah commented on issue #3241: Impossible the see usage of a shared package

rabbah commented on issue #3241: Impossible the see usage of a shared package URL: https://github.com/apache/incubator-openwhisk/issues/3241#issuecomment-364100745 A related thought - today when you invoke an action through a binding, the resolution to the package happens fairly early on.

[GitHub] rabbah commented on issue #3241: Impossible the see usage of a shared package

rabbah commented on issue #3241: Impossible the see usage of a shared package URL: https://github.com/apache/incubator-openwhisk/issues/3241#issuecomment-364100745 A related thought - today when you invoke an action through a binding, the resolution to the package happens fairly early on.

[GitHub] rabbah commented on issue #3241: Impossible the see usage of a shared package

rabbah commented on issue #3241: Impossible the see usage of a shared package URL: https://github.com/apache/incubator-openwhisk/issues/3241#issuecomment-364099128 If the goal is to prevent breaking changes, then versioning is the preferred route. We could provide a count of

[GitHub] mhaack commented on issue #3241: Impossible the see usage of a shared package

mhaack commented on issue #3241: Impossible the see usage of a shared package URL: https://github.com/apache/incubator-openwhisk/issues/3241#issuecomment-364093548 I agree on the package versioning, that is and idea we are currently looking into. Copying is out of scope, if some copies an

[GitHub] daisy-ycguo commented on issue #709: Add Apache License

daisy-ycguo commented on issue #709: Add Apache License URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/709#issuecomment-364091569 I added more Apache license before those source files which are missing headers. Below files are exceptions which are tracked by

[GitHub] rabbah commented on issue #3241: Impossible the see usage of a shared package

rabbah commented on issue #3241: Impossible the see usage of a shared package URL: https://github.com/apache/incubator-openwhisk/issues/3241#issuecomment-364082032 For this kind of thing why not use versioning; it would be a better approach. You could add a version to the package name

[GitHub] rabbah commented on a change in pull request #3240: Add a loadbalancer with local state and horizontal invoker sharding.

rabbah commented on a change in pull request #3240: Add a loadbalancer with local state and horizontal invoker sharding. URL: https://github.com/apache/incubator-openwhisk/pull/3240#discussion_r166900059 ## File path:

[GitHub] rabbah commented on a change in pull request #3240: Add a loadbalancer with local state and horizontal invoker sharding.

rabbah commented on a change in pull request #3240: Add a loadbalancer with local state and horizontal invoker sharding. URL: https://github.com/apache/incubator-openwhisk/pull/3240#discussion_r166899101 ## File path:

[GitHub] rabbah commented on a change in pull request #3240: Add a loadbalancer with local state and horizontal invoker sharding.

rabbah commented on a change in pull request #3240: Add a loadbalancer with local state and horizontal invoker sharding. URL: https://github.com/apache/incubator-openwhisk/pull/3240#discussion_r166897507 ## File path:

[GitHub] rabbah commented on a change in pull request #3240: Add a loadbalancer with local state and horizontal invoker sharding.

rabbah commented on a change in pull request #3240: Add a loadbalancer with local state and horizontal invoker sharding. URL: https://github.com/apache/incubator-openwhisk/pull/3240#discussion_r166901098 ## File path:

[GitHub] mhaack commented on issue #3241: Impossible the see usage of a shared package

mhaack commented on issue #3241: Impossible the see usage of a shared package URL: https://github.com/apache/incubator-openwhisk/issues/3241#issuecomment-364059971 I think that's a list of namespaces that have bindings to my public packages. The intention is to get at least a list of

[GitHub] mhaack commented on issue #3241: Impossible the see usage of a shared package

mhaack commented on issue #3241: Impossible the see usage of a shared package URL: https://github.com/apache/incubator-openwhisk/issues/3241#issuecomment-364059971 I think of a list of namespaces that have bindings to my public packages. The intention is to get at least a list of

[GitHub] markusthoemmes commented on a change in pull request #3260: Enhance the RestResult with more information to debug failing tests e?

markusthoemmes commented on a change in pull request #3260: Enhance the RestResult with more information to debug failing tests e? URL: https://github.com/apache/incubator-openwhisk/pull/3260#discussion_r166878476 ## File path: tests/src/test/scala/common/rest/WskRest.scala

[GitHub] cbickel opened a new pull request #3260: Enhance the RestResult with more information to debug failing tests e?

cbickel opened a new pull request #3260: Enhance the RestResult with more information to debug failing tests e? URL: https://github.com/apache/incubator-openwhisk/pull/3260 ?asier. I had to debug a failing test case. But most information from the RestResult was hidden. Only the