[GitHub] rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig

2018-02-02 Thread GitBox
rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215#discussion_r165653638 ## File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala ## @@ -130,8

[GitHub] jthomas opened a new pull request #11: Pass arguments using stdin rather than env param.

2018-02-02 Thread GitBox
jthomas opened a new pull request #11: Pass arguments using stdin rather than env param. URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/11 Replicates fix in https://github.com/apache/incubator-openwhisk-runtime-docker/pull/3

[GitHub] dgrove-oss commented on issue #3215: adding namePrefix config to ContainerArgsConfig

2018-02-02 Thread GitBox
dgrove-oss commented on issue #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215#issuecomment-362588131 fine with me. This is an automated message from the

[GitHub] dgrove-oss commented on issue #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-02 Thread GitBox
dgrove-oss commented on issue #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#issuecomment-362595461 PG2 / 2742 ? This is an automated message from the

[GitHub] rabbah commented on issue #3215: adding namePrefix config to ContainerArgsConfig

2018-02-02 Thread GitBox
rabbah commented on issue #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215#issuecomment-362592827 PG4/1299 ? This is an automated message from the Apache

[GitHub] dgrove-oss commented on issue #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-02 Thread GitBox
dgrove-oss commented on issue #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#issuecomment-362595461 PG1 / 2574 ? This is an automated message from the

[GitHub] rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig

2018-02-02 Thread GitBox
rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215#discussion_r163699681 ## File path: common/scala/src/main/scala/whisk/core/containerpool/ContainerFactory.scala

[GitHub] dgrove-oss commented on issue #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-02 Thread GitBox
dgrove-oss commented on issue #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#issuecomment-362595461 PG1 / 2575 ? This is an automated message from the

[GitHub] rabbah commented on issue #3215: adding namePrefix config to ContainerArgsConfig

2018-02-02 Thread GitBox
rabbah commented on issue #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215#issuecomment-362587276 @dgrove-oss are you ok with these changes? This is an

[GitHub] rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig

2018-02-02 Thread GitBox
rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215#discussion_r163698889 ## File path: common/scala/src/main/scala/whisk/core/containerpool/ContainerFactory.scala

[GitHub] rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig

2018-02-02 Thread GitBox
rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215#discussion_r165655708 ## File path: common/scala/src/main/scala/whisk/core/containerpool/ContainerFactory.scala

[GitHub] rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig

2018-02-02 Thread GitBox
rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215#discussion_r165653638 ## File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala ## @@ -130,8

[GitHub] dottorsaimon commented on issue #2586: issue about deploy openwhisk with ansible

2018-02-02 Thread GitBox
dottorsaimon commented on issue #2586: issue about deploy openwhisk with ansible URL: https://github.com/apache/incubator-openwhisk/issues/2586#issuecomment-362616341 Same problem on Ubuntu 14.04, i tried a lot of times but i arrived alwais at the same error: Fatal: [172.17.0.1]:

[GitHub] markusthoemmes commented on issue #3213: Fixes #3212 - WhiskConfig should close the property file source

2018-02-02 Thread GitBox
markusthoemmes commented on issue #3213: Fixes #3212 - WhiskConfig should close the property file source URL: https://github.com/apache/incubator-openwhisk/pull/3213#issuecomment-362573951 Thanks for the fix. I feel a bit uneasy about the testcase though. Seems rather low-level. In this

[GitHub] rabbah commented on issue #3213: Fixes #3212 - WhiskConfig should close the property file source

2018-02-02 Thread GitBox
rabbah commented on issue #3213: Fixes #3212 - WhiskConfig should close the property file source URL: https://github.com/apache/incubator-openwhisk/pull/3213#issuecomment-362586808 +1, can live without a test for this - since we're not checking that we're leaking a file resource anywhere

[GitHub] rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig

2018-02-02 Thread GitBox
rabbah commented on a change in pull request #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215#discussion_r165655708 ## File path: common/scala/src/main/scala/whisk/core/containerpool/ContainerFactory.scala

[GitHub] jberstler commented on issue #234: requeue messages to kafka if subject is throttled

2018-02-02 Thread GitBox
jberstler commented on issue #234: requeue messages to kafka if subject is throttled URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/234#issuecomment-362605056 Like @csantanapr, I find it a little hard to believe we should expect customers to set up a separate

[GitHub] jthomas opened a new issue #12: Swift SDK does not support self-signed server certificates.

2018-02-02 Thread GitBox
jthomas opened a new issue #12: Swift SDK does not support self-signed server certificates. URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/12 Local instances of the platform use a self-signed SSL certificate. The Swift SDK (`_Whisk.swift`) fails when invoked

[GitHub] rabbah opened a new issue #3245: bypassPullForLocalImages setting no longer overridable

2018-02-02 Thread GitBox
rabbah opened a new issue #3245: bypassPullForLocalImages setting no longer overridable URL: https://github.com/apache/incubator-openwhisk/issues/3245 As noted on this PR, https://github.com/apache/incubator-openwhisk/pull/3142#pullrequestreview-93706400 factoring out the runtime

[GitHub] ScottChapman opened a new issue #705: Unable to use ENV VARS in input JSON

2018-02-02 Thread GitBox
ScottChapman opened a new issue #705: Unable to use ENV VARS in input JSON URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/705 I tried the following without success: ``` inputs: type: json MyKey: { username: ${username}, password:

[GitHub] ScottChapman opened a new issue #704: Unable to specify Raw HTTP

2018-02-02 Thread GitBox
ScottChapman opened a new issue #704: Unable to specify Raw HTTP URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/704 I have an Web Action `web-export: true` but cannot set it to use Raw HTTP. Looking through the code thought `raw-http: true` would do the trick but it

[GitHub] lornajane opened a new pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-02 Thread GitBox
lornajane opened a new pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244 (original ticket against IBM Cloud Functions docs: https://github.com/IBM-Bluemix-Docs/openwhisk/issues/19) The

[GitHub] dgrove-oss commented on issue #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-02 Thread GitBox
dgrove-oss commented on issue #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#issuecomment-362595461 PG2 / 2742 -- failed with what looks like a PG infrastructure problem. I'll try again later.

[GitHub] ScottChapman closed issue #702: How do I create package parameters?

2018-02-02 Thread GitBox
ScottChapman closed issue #702: How do I create package parameters? URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/702 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ScottChapman commented on issue #705: Unable to use ENV VARS in input JSON

2018-02-02 Thread GitBox
ScottChapman commented on issue #705: Unable to use ENV VARS in input JSON URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/705#issuecomment-362647898 We would likely need this for implementing a IBM Cloud Functions Template for Watson Workspace. [Watson

[GitHub] ScottChapman commented on issue #705: Unable to use ENV VARS in input JSON

2018-02-02 Thread GitBox
ScottChapman commented on issue #705: Unable to use ENV VARS in input JSON URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/705#issuecomment-362654880 I think that seems reasonable. Make it so. This is an

[GitHub] jthomas commented on issue #88: [Feature] Create a "pull" target to let someone update their containers from upstream

2018-02-02 Thread GitBox
jthomas commented on issue #88: [Feature] Create a "pull" target to let someone update their containers from upstream URL: https://github.com/apache/incubator-openwhisk-devtools/issues/88#issuecomment-362657654 Great idea - I had this exact issue today where the images were out of date

[GitHub] rabbah commented on a change in pull request #3142: externalize runtimesManifestDefault to runtimes.json

2018-02-02 Thread GitBox
rabbah commented on a change in pull request #3142: externalize runtimesManifestDefault to runtimes.json URL: https://github.com/apache/incubator-openwhisk/pull/3142#discussion_r165717568 ## File path: ansible/group_vars/all ## @@ -30,77 +30,9 @@ whisk: # runtimes:

[GitHub] jthomas commented on issue #93: Unable to start controller

2018-02-02 Thread GitBox
jthomas commented on issue #93: Unable to start controller URL: https://github.com/apache/incubator-openwhisk-devtools/issues/93#issuecomment-362658830 Can you paste the full log file from `controller/logs/controller-local_logs.log`?

[GitHub] mrutkows commented on issue #705: Unable to use ENV VARS in input JSON

2018-02-02 Thread GitBox
mrutkows commented on issue #705: Unable to use ENV VARS in input JSON URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/705#issuecomment-362648448 @ScottChapman this would be a new feature we would to design... to capture some thoughts... we could take the

[GitHub] jthomas commented on issue #86: Make run deleted old ~/.wskprops file

2018-02-02 Thread GitBox
jthomas commented on issue #86: Make run deleted old ~/.wskprops file URL: https://github.com/apache/incubator-openwhisk-devtools/issues/86#issuecomment-362660042 This is a good suggestion. If the file exists, credentials could be written to a different file. The CLI can pick them up by

[GitHub] csantanapr opened a new issue #13: Update tests cases to allow to take gradle to override the use of https for Swift 4

2018-02-02 Thread GitBox
csantanapr opened a new issue #13: Update tests cases to allow to take gradle to override the use of https for Swift 4 URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/13 The tests currently use `http` and pass in Travis. The same tests can be use in

[GitHub] houshengbo opened a new pull request #706: Add the support to package the source code

2018-02-02 Thread GitBox
houshengbo opened a new pull request #706: Add the support to package the source code URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/706 This is an automated message from the Apache Git Service. To

[GitHub] pritidesai closed pull request #699: WIP: adding API Gateway functionality

2018-02-02 Thread GitBox
pritidesai closed pull request #699: WIP: adding API Gateway functionality URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/699 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-02 Thread GitBox
jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r165733535 ## File path: docs/parameters.md ## @@ -0,0 +1,180 @@ +# Working with

[GitHub] csantanapr commented on issue #12: Swift SDK does not support self-signed server certificates.

2018-02-02 Thread GitBox
csantanapr commented on issue #12: Swift SDK does not support self-signed server certificates. URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/12#issuecomment-362692149 Thanks for opening this. I thought I already opened an issue to document my findings.

[GitHub] csantanapr opened a new issue #14: Update swift4 to allow more than 128KB of input parameters

2018-02-02 Thread GitBox
csantanapr opened a new issue #14: Update swift4 to allow more than 128KB of input parameters URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/14 The epilogue uses environment variable to take the input JSON ```swift let inputStr: String = env["WHISK_INPUT"]

[GitHub] dgrove-oss commented on a change in pull request #3142: externalize runtimesManifestDefault to runtimes.json

2018-02-02 Thread GitBox
dgrove-oss commented on a change in pull request #3142: externalize runtimesManifestDefault to runtimes.json URL: https://github.com/apache/incubator-openwhisk/pull/3142#discussion_r165728901 ## File path: ansible/group_vars/all ## @@ -30,77 +30,9 @@ whisk: #

[GitHub] jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-02 Thread GitBox
jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r165734322 ## File path: docs/parameters.md ## @@ -0,0 +1,180 @@ +# Working with

[GitHub] rabbah commented on a change in pull request #3142: externalize runtimesManifestDefault to runtimes.json

2018-02-02 Thread GitBox
rabbah commented on a change in pull request #3142: externalize runtimesManifestDefault to runtimes.json URL: https://github.com/apache/incubator-openwhisk/pull/3142#discussion_r165738754 ## File path: ansible/group_vars/all ## @@ -30,77 +30,9 @@ whisk: # runtimes:

[GitHub] csantanapr commented on issue #12: Swift SDK does not support self-signed server certificates.

2018-02-02 Thread GitBox
csantanapr commented on issue #12: Swift SDK does not support self-signed server certificates. URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/12#issuecomment-362692149 Thanks for opening this. I thought I already opened an issue to document my findings.

[GitHub] jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-02 Thread GitBox
jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r165734934 ## File path: docs/parameters.md ## @@ -0,0 +1,180 @@ +# Working with

[GitHub] jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-02 Thread GitBox
jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r165734863 ## File path: docs/parameters.md ## @@ -0,0 +1,180 @@ +# Working with

[GitHub] jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-02 Thread GitBox
jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r165734800 ## File path: docs/parameters.md ## @@ -0,0 +1,180 @@ +# Working with

[GitHub] pritidesai commented on issue #699: WIP: adding API Gateway functionality

2018-02-02 Thread GitBox
pritidesai commented on issue #699: WIP: adding API Gateway functionality URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/699#issuecomment-362670631 no longer applicable, closing it. This is an automated

[GitHub] jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-02 Thread GitBox
jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r165734507 ## File path: docs/parameters.md ## @@ -0,0 +1,180 @@ +# Working with

[GitHub] jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-02 Thread GitBox
jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r165734678 ## File path: docs/parameters.md ## @@ -0,0 +1,180 @@ +# Working with

[GitHub] jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-02 Thread GitBox
jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r165734620 ## File path: docs/parameters.md ## @@ -0,0 +1,180 @@ +# Working with

[GitHub] jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-02 Thread GitBox
jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r165732819 ## File path: docs/parameters.md ## @@ -0,0 +1,180 @@ +# Working with

[GitHub] jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-02 Thread GitBox
jpkessle commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r165733097 ## File path: docs/parameters.md ## @@ -0,0 +1,180 @@ +# Working with

[GitHub] csantanapr commented on issue #12: Swift SDK does not support self-signed server certificates.

2018-02-02 Thread GitBox
csantanapr commented on issue #12: Swift SDK does not support self-signed server certificates. URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/12#issuecomment-362692817 Here is an example ```swift //Overriding WHISK API HOST using baseUrl, only applicable in

[GitHub] pritidesai commented on issue #704: Unable to specify Raw HTTP

2018-02-02 Thread GitBox
pritidesai commented on issue #704: Unable to specify Raw HTTP URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/704#issuecomment-362695144 Hi @ScottChapman we have an enhancement opened here #615 sometime back, `wskdeploy` does not yet support explicit setting

[GitHub] pritidesai commented on issue #704: Unable to specify Raw HTTP

2018-02-02 Thread GitBox
pritidesai commented on issue #704: Unable to specify Raw HTTP URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/704#issuecomment-362695144 Hi @ScottChapman we have an enhancement opened here #615 sometime back, `wskdeploy` does not yet support explicit setting

[GitHub] houshengbo closed pull request #698: Remove verifier.go to confirm no test impact.

2018-02-02 Thread GitBox
houshengbo closed pull request #698: Remove verifier.go to confirm no test impact. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/698 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] eweiter opened a new issue #3246: ActionLimitsTests memory test failing

2018-02-02 Thread GitBox
eweiter opened a new issue #3246: ActionLimitsTests memory test failing URL: https://github.com/apache/incubator-openwhisk/issues/3246 The mainOpenwhisk build has been breaking for the past >10 builds. The reason for the failure was "limits should be aborted when exceeding its memory

[GitHub] pritidesai opened a new pull request #707: Adding support for raw HTTP web actions

2018-02-02 Thread GitBox
pritidesai opened a new pull request #707: Adding support for raw HTTP web actions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/707 Closes #704 This is how you can set an action to be raw http web action: ``` packages: IntegrationTestWebAction:

[GitHub] jonpspri opened a new pull request #218: Update README to include i18n step.

2018-02-02 Thread GitBox
jonpspri opened a new pull request #218: Update README to include i18n step. URL: https://github.com/apache/incubator-openwhisk-cli/pull/218 Quick fix to add instructions to the README on how to generate the i18n files for those still compiling by hand.

[GitHub] ScottChapman commented on issue #681: proper handling of 'default' package name

2018-02-02 Thread GitBox
ScottChapman commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-362756934 I @lionelvillard proposal makes sense. Seems to fit with the OW model (root of the namespace).

[GitHub] rabbah commented on issue #2586: issue about deploy openwhisk with ansible

2018-02-02 Thread GitBox
rabbah commented on issue #2586: issue about deploy openwhisk with ansible URL: https://github.com/apache/incubator-openwhisk/issues/2586#issuecomment-362733151 Check your controllers logs for an exception. wskadmin syslog get controller0

[GitHub] csantanapr closed pull request #218: Update README to include i18n step.

2018-02-02 Thread GitBox
csantanapr closed pull request #218: Update README to include i18n step. URL: https://github.com/apache/incubator-openwhisk-cli/pull/218 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] csantanapr commented on issue #3243: Collect test code coverage data

2018-02-02 Thread GitBox
csantanapr commented on issue #3243: Collect test code coverage data URL: https://github.com/apache/incubator-openwhisk/issues/3243#issuecomment-362561501 Yeah I agree with @michaelmarth let?s integrate with codeconv.io we already have a repo that leverages their free service for open

[GitHub] chetanmeh opened a new issue #3243: Collect test code coverage data

2018-02-02 Thread GitBox
chetanmeh opened a new issue #3243: Collect test code coverage data URL: https://github.com/apache/incubator-openwhisk/issues/3243 We should collect test code coverage data for common, controller and invoker module. For Scala code we would need to use [scoverage][1] which has a

[GitHub] ddragosd closed pull request #83: Add support for installing optional packages.

2018-02-02 Thread GitBox
ddragosd closed pull request #83: Add support for installing optional packages. URL: https://github.com/apache/incubator-openwhisk-devtools/pull/83 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] ddragosd commented on issue #83: Add support for installing optional packages.

2018-02-02 Thread GitBox
ddragosd commented on issue #83: Add support for installing optional packages. URL: https://github.com/apache/incubator-openwhisk-devtools/pull/83#issuecomment-362513544 @jthomas ? This is an automated message from the