[GitHub] tysonnorris commented on issue #3504: use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre)
tysonnorris commented on issue #3504: use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre) URL: https://github.com/apache/incubator-openwhisk/pull/3504#issuecomment-382957703 @markusthoemmes I'm not sure if you have a specific load test in mind beyond performance/wrk_tests, but last build for `adoptopenjdk/openjdk8:jdk8u152-b16-alpine` got 4 rps faster than master for latency.sh and 5 rps faster than master for throughtput.sh If you want to run a PG, please go ahead This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #3541: Point Getting Started to docker-compose
ddragosd commented on issue #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#issuecomment-382931206 Is there a pending action item here or we can merge this ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd closed pull request #3559: add support for mesos attribute constraints
ddragosd closed pull request #3559: add support for mesos attribute constraints
URL: https://github.com/apache/incubator-openwhisk/pull/3559
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/common/scala/build.gradle b/common/scala/build.gradle
index 6c856c22c1..4a7a82e7fa 100644
--- a/common/scala/build.gradle
+++ b/common/scala/build.gradle
@@ -45,7 +45,7 @@ dependencies {
compile 'io.kamon:kamon-core_2.11:0.6.7'
compile 'io.kamon:kamon-statsd_2.11:0.6.7'
//for mesos
-compile 'com.adobe.api.platform.runtime:mesos-actor:0.0.4'
+compile 'com.adobe.api.platform.runtime:mesos-actor:0.0.7'
}
tasks.withType(ScalaCompile) {
diff --git a/common/scala/src/main/resources/application.conf
b/common/scala/src/main/resources/application.conf
index 4c36319523..e3fadaf939 100644
--- a/common/scala/src/main/resources/application.conf
+++ b/common/scala/src/main/resources/application.conf
@@ -162,5 +162,9 @@ whisk {
role = "*" //see
http://mesos.apache.org/documentation/latest/roles/#associating-frameworks-with-roles
failover-timeout = 0 seconds //Timeout allowed for framework to
reconnect after disconnection.
mesos-link-log-message = true //If true, display a link to mesos in
the static log message, otherwise do not include a link to mesos.
+constraints = [] //placement constraint strings to use for managed
containers e.g. ["att1 LIKE v1", "att2 UNLIKE v2"]
+blackbox-constraints = [] //placement constraints to use for blackbox
containers
+constraint-delimiter = " "//used to parse constraint strings
+teardown-on-exit = true //set to true to disable the mesos framework
on system exit; set for false for HA deployments
}
}
diff --git
a/common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala
b/common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala
index c9e634e7de..b0d47a90a1 100644
--- a/common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala
+++ b/common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala
@@ -20,10 +20,14 @@ package whisk.core.mesos
import akka.actor.ActorRef
import akka.actor.ActorSystem
import akka.pattern.ask
+import com.adobe.api.platform.runtime.mesos.Constraint
+import com.adobe.api.platform.runtime.mesos.LIKE
+import com.adobe.api.platform.runtime.mesos.LocalTaskStore
import com.adobe.api.platform.runtime.mesos.MesosClient
import com.adobe.api.platform.runtime.mesos.Subscribe
import com.adobe.api.platform.runtime.mesos.SubscribeComplete
import com.adobe.api.platform.runtime.mesos.Teardown
+import com.adobe.api.platform.runtime.mesos.UNLIKE
import java.time.Instant
import pureconfig.loadConfigOrThrow
import scala.concurrent.Await
@@ -58,7 +62,11 @@ case class MesosConfig(masterUrl: String,
masterPublicUrl: Option[String],
role: String,
failoverTimeout: FiniteDuration,
- mesosLinkLogMessage: Boolean)
+ mesosLinkLogMessage: Boolean,
+ constraints: Seq[String],
+ constraintDelimiter: String,
+ blackboxConstraints: Seq[String],
+ teardownOnExit: Boolean) {}
class MesosContainerFactory(config: WhiskConfig,
actorSystem: ActorSystem,
@@ -108,6 +116,11 @@ class MesosContainerFactory(config: WhiskConfig,
} else {
actionImage.localImageName(config.dockerRegistry,
config.dockerImagePrefix, Some(config.dockerImageTag))
}
+val constraintStrings = if (userProvidedImage) {
+ mesosConfig.blackboxConstraints
+} else {
+ mesosConfig.constraints
+}
logging.info(this, s"using Mesos to create a container with image
$image...")
MesosTask.create(
@@ -126,9 +139,28 @@ class MesosContainerFactory(config: WhiskConfig,
//strip any "--" prefixes on parameters (should make this consistent
everywhere else)
parameters
.map({ case (k, v) => if (k.startsWith("--")) (k.replaceFirst("--",
""), v) else (k, v) })
-++ containerArgs.extraArgs)
+++ containerArgs.extraArgs,
+ parseConstraints(constraintStrings))
}
+ /**
+ * Validate that constraint strings are well formed, and ignore constraints
with unknown operators
+ * @param constraintStrings
+ * @param logging
+ * @return
+ */
+ def parseConstraints(constraintStrings: Seq[String])(implicit logging:
Logging): Seq[Constraint] =
+constraintStrings.flatMap(cs => {
+ val parts = cs.split(mesosConfig.constraintDelimiter)
+ require(parts.length == 3, "constraint must be in the form
")
+ Seq(LIKE,
[GitHub] rabbah commented on a change in pull request #3199: One tid for the whole system.
rabbah commented on a change in pull request #3199: One tid for the whole
system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182921267
##
File path: common/scala/src/main/scala/whisk/common/TransactionId.scala
##
@@ -200,58 +196,42 @@ object TransactionId {
val metricsKamonTags: Boolean =
sys.env.get("METRICS_KAMON_TAGS").getOrElse("False").toBoolean
val metricsLog: Boolean =
sys.env.get("METRICS_LOG").getOrElse("True").toBoolean
- val unknown = TransactionId(0)
- val testing = TransactionId(-1) // Common id for for unit testing
- val invoker = TransactionId(-100) // Invoker startup/shutdown or GC activity
- val invokerWarmup = TransactionId(-101) // Invoker warmup thread that makes
stem-cell containers
- val invokerNanny = TransactionId(-102) // Invoker nanny thread
- val dispatcher = TransactionId(-110) // Kafka message dispatcher
- val loadbalancer = TransactionId(-120) // Loadbalancer thread
- val invokerHealth = TransactionId(-121) // Invoker supervision
- val controller = TransactionId(-130) // Controller startup
- val dbBatcher = TransactionId(-140) // Database batcher
-
- def apply(tid: BigDecimal, extraLogging: Boolean = false): TransactionId = {
-Try {
- val now = Instant.now(Clock.systemUTC())
- TransactionId(TransactionMetadata(tid.toLong, now, extraLogging))
-} getOrElse unknown
+ val generatorConfig =
loadConfigOrThrow[TransactionGeneratorConfig](ConfigKeys.transactions)
+
+ val unknown = TransactionId("sid_unknown")
Review comment:
Is there a mechanism that prevents a user specified sid?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3199: One tid for the whole system.
rabbah commented on a change in pull request #3199: One tid for the whole
system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182921525
##
File path: tests/src/test/scala/whisk/common/SchedulerTests.scala
##
@@ -127,7 +127,7 @@ class SchedulerTests extends FlatSpec with Matchers with
WskActorSystem with Str
waitForCalls()
stream.toString.split(" ").drop(1).mkString(" ") shouldBe {
- s"[ERROR] [#sid_1] [Scheduler] halted because $msg\n"
+ s"[ERROR] [${transid.toString}] [Scheduler] halted because $msg\n"
}
Review comment:
Don’t need toString.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3199: One tid for the whole system.
rabbah commented on a change in pull request #3199: One tid for the whole
system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182921119
##
File path: ansible/roles/nginx/templates/nginx.conf.j2
##
@@ -12,10 +12,17 @@ http {
{# allow large uploads, need to thread proper limit into here #}
client_max_body_size 50M;
+map $http_{{ transaction.header | lower | replace('-', '_') }} $ow_tid {
+# request_id: unique request identifier generated from 16 random
bytes, in hexadecimal
+default $request_id;
+# If the caller has already set a tid into the header in the correct
format, this one will be taken.
+"~^(?{{ transaction.regex }})$" $tid;
Review comment:
The tid is used in the cache logic - if the id isn’t unique (specified by a
user, it will affect the cache behavior).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3199: One tid for the whole system.
rabbah commented on a change in pull request #3199: One tid for the whole
system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182920863
##
File path: ansible/group_vars/all
##
@@ -96,8 +96,10 @@ jmx:
jvmCommonArgs: "-Dcom.sun.management.jmxremote
-Dcom.sun.management.jmxremote.ssl=false
-Dcom.sun.management.jmxremote.local.only=false
-Dcom.sun.management.jmxremote.authenticate=true
-Dcom.sun.management.jmxremote.password.file=/root/jmxremote.password
-Dcom.sun.management.jmxremote.access.file=/root/jmxremote.access"
enabled: "{{ jmxremote_enabled | default('true') }}"
-transactions:
- stride: "{{ groups['controllers'] | length }}"
+transaction:
+ header: "{{ transaction_header | default('X-Request-ID') }}"
+ # The tid can be any String between 1 and 64 characters.
+ regex: "{{ whisk_tid_regex | default('[a-zA-Z0-9_-]{1,64}') }}"
Review comment:
excluding - would make it easier to copy/paste a code (the dash breaks
double click to highlight a string).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3199: One tid for the whole system.
rabbah commented on a change in pull request #3199: One tid for the whole
system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182920953
##
File path: ansible/roles/nginx/templates/nginx.conf.j2
##
@@ -12,10 +12,17 @@ http {
{# allow large uploads, need to thread proper limit into here #}
client_max_body_size 50M;
+map $http_{{ transaction.header | lower | replace('-', '_') }} $ow_tid {
Review comment:
Nice.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3199: One tid for the whole system.
rabbah commented on a change in pull request #3199: One tid for the whole
system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182921359
##
File path: common/scala/src/main/scala/whisk/common/TransactionId.scala
##
@@ -200,58 +196,42 @@ object TransactionId {
val metricsKamonTags: Boolean =
sys.env.get("METRICS_KAMON_TAGS").getOrElse("False").toBoolean
val metricsLog: Boolean =
sys.env.get("METRICS_LOG").getOrElse("True").toBoolean
- val unknown = TransactionId(0)
- val testing = TransactionId(-1) // Common id for for unit testing
- val invoker = TransactionId(-100) // Invoker startup/shutdown or GC activity
- val invokerWarmup = TransactionId(-101) // Invoker warmup thread that makes
stem-cell containers
- val invokerNanny = TransactionId(-102) // Invoker nanny thread
- val dispatcher = TransactionId(-110) // Kafka message dispatcher
- val loadbalancer = TransactionId(-120) // Loadbalancer thread
- val invokerHealth = TransactionId(-121) // Invoker supervision
- val controller = TransactionId(-130) // Controller startup
- val dbBatcher = TransactionId(-140) // Database batcher
-
- def apply(tid: BigDecimal, extraLogging: Boolean = false): TransactionId = {
-Try {
- val now = Instant.now(Clock.systemUTC())
- TransactionId(TransactionMetadata(tid.toLong, now, extraLogging))
-} getOrElse unknown
+ val generatorConfig =
loadConfigOrThrow[TransactionGeneratorConfig](ConfigKeys.transactions)
+
+ val unknown = TransactionId("sid_unknown")
+ val testing = TransactionId("sid_testing") // Common id for for unit testing
+ val invoker = TransactionId("sid_invoker") // Invoker startup/shutdown or GC
activity
+ val invokerWarmup = TransactionId("sid_invokerWarmup") // Invoker warmup
thread that makes stem-cell containers
+ val invokerNanny = TransactionId("sid_invokerNanny") // Invoker nanny thread
+ val dispatcher = TransactionId("sid_dispatcher") // Kafka message dispatcher
+ val loadbalancer = TransactionId("sid_loadbalancer") // Loadbalancer thread
+ val invokerHealth = TransactionId("sid_invokerHealth") // Invoker supervision
+ val controller = TransactionId("sid_controller") // Controller startup
+ val dbBatcher = TransactionId("sid_dbBatcher") // Database batcher
+
+ def apply(tid: String, extraLogging: Boolean = false): TransactionId = {
+val now = Instant.now(Clock.systemUTC())
+TransactionId(TransactionMetadata(tid, now, extraLogging))
}
implicit val serdes = new RootJsonFormat[TransactionId] {
def write(t: TransactionId) = {
if (t.meta.extraLogging)
-JsArray(JsNumber(t.meta.id), JsNumber(t.meta.start.toEpochMilli),
JsBoolean(t.meta.extraLogging))
+JsArray(JsString(t.meta.id), JsNumber(t.meta.start.toEpochMilli),
JsBoolean(t.meta.extraLogging))
else
-JsArray(JsNumber(t.meta.id), JsNumber(t.meta.start.toEpochMilli))
+JsArray(JsString(t.meta.id), JsNumber(t.meta.start.toEpochMilli))
}
def read(value: JsValue) =
Try {
value match {
- case JsArray(Vector(JsNumber(id), JsNumber(start))) =>
-TransactionId(TransactionMetadata(id.longValue,
Instant.ofEpochMilli(start.longValue), false))
- case JsArray(Vector(JsNumber(id), JsNumber(start),
JsBoolean(extraLogging))) =>
-TransactionId(TransactionMetadata(id.longValue,
Instant.ofEpochMilli(start.longValue), extraLogging))
+ case JsArray(Vector(JsString(id), JsNumber(start))) =>
+TransactionId(TransactionMetadata(id,
Instant.ofEpochMilli(start.longValue), false))
+ case JsArray(Vector(JsString(id), JsNumber(start),
JsBoolean(extraLogging))) =>
+TransactionId(TransactionMetadata(id,
Instant.ofEpochMilli(start.longValue), extraLogging))
}
} getOrElse unknown
}
}
-/**
- * A thread-safe transaction counter.
- */
-trait TransactionCounter {
- case class TransactionCounterConfig(stride: Int)
-
- val transCounterConfig =
loadConfigOrThrow[TransactionCounterConfig](ConfigKeys.transactions)
- val stride = transCounterConfig.stride
- val instanceOrdinal: Int
-
- // seed the counter so transids do not overlap: instanceOrdinal + n *
stride, start at n = 1
- private lazy val cnt = new AtomicInteger(instanceOrdinal + stride)
-
- def transid(extraLogging: Boolean = false): TransactionId = {
-TransactionId(cnt.addAndGet(stride), extraLogging)
- }
-}
+case class TransactionGeneratorConfig(header: String)
Review comment:
I think for local testing it might still be nice to have a counter based id
instead. Thoughts?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
[GitHub] rabbah commented on a change in pull request #3199: One tid for the whole system.
rabbah commented on a change in pull request #3199: One tid for the whole
system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182921693
##
File path: tests/src/test/scala/whisk/core/database/test/DbUtils.scala
##
@@ -45,13 +44,14 @@ import whisk.core.entity.types.EntityStore
* operations with those that flow through the cache. To mitigate this, use
unique asset
* names in tests, and defer all cleanup to the end of a test suite.
*/
-trait DbUtils extends TransactionCounter {
+trait DbUtils {
implicit val dbOpTimeout = 15 seconds
- override val instanceOrdinal = 0
- val instance = InstanceId(instanceOrdinal)
+ val instance = InstanceId(0)
val docsToDelete = ListBuffer[(ArtifactStore[_], DocInfo)]()
case class RetryOp() extends Throwable
+ def transid() = TransactionId.testing
Review comment:
As noted earlier a sequential counter here would be useful when looking at a
test log.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3199: One tid for the whole system.
rabbah commented on a change in pull request #3199: One tid for the whole
system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182921617
##
File path:
tests/src/test/scala/whisk/core/controller/test/PackagesApiTests.scala
##
@@ -750,7 +750,6 @@ class PackagesApiTests extends ControllerTestCommon with
WhiskPackagesApi {
status should be(Conflict)
val response = responseAs[ErrorResponse]
response.error should include("Package not empty (contains 1 entity)")
- response.code.id should be >= 1L
Review comment:
Can you change this check to assert the id is not empty? This weakens the
test to where a missing id is accepted.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on issue #3199: One tid for the whole system.
rabbah commented on issue #3199: One tid for the whole system. URL: https://github.com/apache/incubator-openwhisk/pull/3199#issuecomment-382924718 Another case of https://github.com/apache/incubator-openwhisk-cli/issues/148? The cli shouldn’t really care what the type of the code is. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser commented on issue #3199: One tid for the whole system.
mdeuser commented on issue #3199: One tid for the whole system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#issuecomment-382922406
here's an example json that's returned in an error condition. the tid is
returned in the `code` field.
```
{"error":"The requested resource does not exist.","code":168671}
```
@cbickel - with this change what will the `code` value be? the cli expects
an integer
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mdeuser commented on issue #3199: One tid for the whole system.
mdeuser commented on issue #3199: One tid for the whole system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#issuecomment-382922406
currently, the json returned in an error condition looks like. the tid is
returned in the `code` field.
```
{"error":"The requested resource does not exist.","code":168671}
```
@cbickel - with this change what will the `code` value be? the cli expects
an integer
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] davidbreitgand commented on issue #862: Documentation for the export feature
davidbreitgand commented on issue #862: Documentation for the export feature URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/862#issuecomment-382919039 Tx, Priti. I'll open a new PR to fix it this week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davidbreitgand commented on issue #862: Documentation for the export feature
davidbreitgand commented on issue #862: Documentation for the export feature URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/862#issuecomment-382919039 @pritidesai Tx, Priti. I'll open a new PR to fix it this week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houshengbo opened a new pull request #279: WIP: Check dependencies
houshengbo opened a new pull request #279: WIP: Check dependencies URL: https://github.com/apache/incubator-openwhisk-cli/pull/279 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss opened a new pull request #186: quick first pass through charts
dgrove-oss opened a new pull request #186: quick first pass through charts URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/186 1. enable affinities & synch up with classic kube files. 2. invoker needs to be demonset (need stable invoker names) 3. updates for README 4. make controller wait for couchdb to be initialized 5. start factoring out wait-for-FOO containers into a template file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3199: One tid for the whole system.
csantanapr commented on issue #3199: One tid for the whole system. URL: https://github.com/apache/incubator-openwhisk/pull/3199#issuecomment-382888017 @tysonnorris it was @starpit who brought up the TypeScript spec. But I would not make that spec a blocker on this. What I worry a CLI (wskdeploy and wsk) breakage if CLI is not broken because of the change on type or field name change for “code” then I’m good @mdeuser could you test if CLI is ok? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #3507: allow use of string for controller id
tysonnorris commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-382887111 once #3199 is done, will update this accordingly This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #3199: One tid for the whole system.
tysonnorris commented on issue #3199: One tid for the whole system. URL: https://github.com/apache/incubator-openwhisk/pull/3199#issuecomment-382885904 @csantanapr I'm not sure what typescript spec may be referenced in the email thread. Can you point it out? Or is this OK to merge now? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #3504: use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre)
tysonnorris commented on issue #3504: use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre) URL: https://github.com/apache/incubator-openwhisk/pull/3504#issuecomment-382883652 OK, back to openjdk for now - not sure the best image, so I picked this one `adoptopenjdk/openjdk8:jdk8u152-b16-alpine` Any comment on a better openjdk + alpine image to use? (the tags for adoptopenjdk/openjdk8 are a bit of a mess) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed issue #839: Document export functionality
pritidesai closed issue #839: Document export functionality URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/839 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed pull request #862: Documentation for the export feature
pritidesai closed pull request #862: Documentation for the export feature URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/862 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index f4c81020..3879fa9a 100644 --- a/README.md +++ b/README.md @@ -23,6 +23,8 @@ `wskdeploy` is a utility to help you describe and deploy any part of the OpenWhisk programming model using a Manifest file written in YAML. Use it to deploy all your OpenWhisk [Packages](https://github.com/apache/incubator-openwhisk/blob/master/docs/packages.md), [Actions](https://github.com/apache/incubator-openwhisk/blob/master/docs/actions.md), [Triggers, and Rules](https://github.com/apache/incubator-openwhisk/blob/master/docs/triggers_rules.md) using a single command! +`wskdeploy export --projectname managed_project_name` allows to "export" a specified managed project into a local file system. Namely, a `managed_project_name.yml` Manifest file will be created automatically. This Manifest file can be used with `wskdeploy` to redeploy the managed project at a different OpenWhisk instance. If the managed project contains dependencies on other managed projects, then these projects will be exported automatically into their respective manifests. + You can use this in addition to the OpenWhisk CLI. In fact, this utility uses the [OpenWhisk "Go" Client](https://github.com/apache/incubator-openwhisk-client-go) to create its HTTP REST calls for deploying and undeploying your packages. ## Here are some quick links for: @@ -30,6 +32,7 @@ You can use this in addition to the OpenWhisk CLI. In fact, this utility uses t - [Downloading wskdeploy](#downloading-released-binaries) - released binaries for Linux, Mac OS and Windows - [Running wskdeploy](#running-wskdeploy) - run wskdeploy as a binary or Go program - :eight_spoked_asterisk: [Writing Package Manifests](docs/programming_guide.md#wskdeploy-utility-by-example) - a step-by-step guide on writing Package Manifest files for ```wskdeploy``` +- :eight_spoked_asterisk: [Exporting OpenWhisk assets](docs/export.md) - how to use `export` feature - [Building the project](#building-the-project) - download and build the GoLang source code - [Contributing to the project](#contributing-to-the-project) - join us! - [Debugging wskdeploy](docs/wskdeploy_debugging.md) - helpful tips for debugging the code and your manifest files diff --git a/docs/export.md b/docs/export.md new file mode 100644 index ..4bc55406 --- /dev/null +++ b/docs/export.md @@ -0,0 +1,300 @@ +# Using `wskdeploy` for exporting `OpenWhisk` assets + +`wskdeploy export` can be used to export `OpenWhisk` assets previously deployed as a *managed project* via `wskdeploy sync -m manifest.yaml`. `wskdeploy export` will create a manifest for the managed project assets and separate manifests for each managed project that this managed project depends upon, if such dependencies exist and have been described in `manifest.yml` when the managed project has been initially deployed. +The manifest(s) resulting from executing `wskdeploy export` can be later used for deploying at a different `OpenWhisk` instance. The code of actions, which are defined in the packages of the exported project will be saved into folders with the names being the names of the package, the actions belong to. + +## Use Cases + +### Copy `OpenWhisk` Assets + +One common scenario, in which the export feature is useful, is populating a newly installed `OpenWhisk` instance with assets from +another `OpenWhisk` instance. One might consider a scenario, in which an `OpenWhisk` instance is installed on premises with another `OpenWhisk` instance residing in the cloud. Consider, for example using one `OpenWhisk` instance on premises and another one in the cloud (e.g., the second `OpenWhisk` instance can be [IBM Cloud Functions](https://console.bluemix.net/openwhisk/)). A fairly common scenario is that a developer +will need to deploy assets from the cloud `OpenWhisk` instance on the on premises one and vice-versa. + +### `OpenWhisk` at the Edge + +In a variety of IoT and other edge computing scenarios, such as running Virtual Network Functions (VNF) as `OpenWhisk` actions in "edge Data Centers" +embedded with 5G-MEDIA infrastructure (as pioneered in [5G-MEDIA EU H2020 project](http://www.5gmedia.eu/)), there is a need to distribute `OpenWhisk` assets developed centrally in the cloud (e.g., [IBM Cloud Functions](https://console.bluemix.net/openwhisk/)) to multiple `OpenWhisk` instances running at the edge Data Centers. Again, `wskdeploy export` is handy as a basic tool that allows to automate this management task. + +## Basic Usage by Example + +Consider a
[GitHub] rabbah commented on issue #3559: add support for mesos attribute constraints
rabbah commented on issue #3559: add support for mesos attribute constraints URL: https://github.com/apache/incubator-openwhisk/pull/3559#issuecomment-382867185 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #3559: add support for mesos attribute constraints
dgrove-oss commented on issue #3559: add support for mesos attribute constraints URL: https://github.com/apache/incubator-openwhisk/pull/3559#issuecomment-382866973 I kicked off PG2/3043 for you (might be faster than getting an answer) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #3559: add support for mesos attribute constraints
ddragosd commented on issue #3559: add support for mesos attribute constraints URL: https://github.com/apache/incubator-openwhisk/pull/3559#issuecomment-382856111 Precisely for this uncertainty of whether the blackbox ratio matters or not I was coming from with the thought that maybe we don't need to differentiate between blackbox vs non-blackbox right now. Intuitively I'm thinking that this would change once we introduce semantics for actions that require GPU resources, being blackbox or non-blackbox. If you feel strongly about keeping the separation as-is in this PR, I would , waiting to solve the GPU part to get to the actual solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3416: Unit test PoolingRestClient
dubee commented on issue #3416: Unit test PoolingRestClient URL: https://github.com/apache/incubator-openwhisk/pull/3416#issuecomment-382850046 @markusthoemmes, anything else on this one? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new pull request #278: Update Travis to use Scandcode with the ASF Release configuration.
mrutkows opened a new pull request #278: Update Travis to use Scandcode with the ASF Release configuration. URL: https://github.com/apache/incubator-openwhisk-cli/pull/278 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #2855: Cache database attachments
dubee commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-382812283 PG4 1600 ⏳ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3416: Unit test PoolingRestClient
dubee commented on issue #3416: Unit test PoolingRestClient URL: https://github.com/apache/incubator-openwhisk/pull/3416#issuecomment-382812005 PG3 2154 ⏳ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3416: Unit test PoolingRestClient
dubee commented on issue #3416: Unit test PoolingRestClient URL: https://github.com/apache/incubator-openwhisk/pull/3416#issuecomment-382812005 PG1 2154 ⏳ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #2041: HTTP Fails to connect on Vagrant install
csantanapr closed issue #2041: HTTP Fails to connect on Vagrant install URL: https://github.com/apache/incubator-openwhisk/issues/2041 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #2041: HTTP Fails to connect on Vagrant install
csantanapr commented on issue #2041: HTTP Fails to connect on Vagrant install
URL:
https://github.com/apache/incubator-openwhisk/issues/2041#issuecomment-382808693
Works for me with recent vagrant changes
```
vagrant@ubuntu-xenial:~/openwhisk$ ifconfig | grep 192
inet addr:192.168.33.16 Bcast:192.168.33.255 Mask:255.255.255.0
vagrant@ubuntu-xenial:~/openwhisk$ exit
logout
Shared connection to 127.0.0.1 closed.
⛄ $ ../../bin/openwhisk-cli/build/darwin-amd64/wsk property set --apihost
192.168.33.16 --auth `vagrant ssh -- cat openwhisk/ansible/files/auth.guest`
ok: whisk auth set. Run 'wsk property get --auth' to see the new value.
ok: whisk API host set to 192.168.33.16
⛄ $ ../../bin/openwhisk-cli/build/darwin-amd64/wsk -i action invoke
/whisk.system/utils/echo -p message hello --blocking --result
{
"message": "hello"
}
⛄ $ date
Thu Apr 19 13:00:11 EDT 2018
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr closed issue #2125: OpenWhisk hello.bat in tools/vagrant failing on Windows 7
csantanapr closed issue #2125: OpenWhisk hello.bat in tools/vagrant failing on Windows 7 URL: https://github.com/apache/incubator-openwhisk/issues/2125 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #2125: OpenWhisk hello.bat in tools/vagrant failing on Windows 7
csantanapr commented on issue #2125: OpenWhisk hello.bat in tools/vagrant failing on Windows 7 URL: https://github.com/apache/incubator-openwhisk/issues/2125#issuecomment-382807257 Vagrant is working, and many updates since the last update on this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #2539: vagrant redeploy instructions fail
csantanapr commented on issue #2539: vagrant redeploy instructions fail URL: https://github.com/apache/incubator-openwhisk/issues/2539#issuecomment-382806832 This is already fixed, try again Also instructions updated to use `wskdev` tool This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #2539: vagrant redeploy instructions fail
csantanapr closed issue #2539: vagrant redeploy instructions fail URL: https://github.com/apache/incubator-openwhisk/issues/2539 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #1614: Bring Vagrant box on par wrt kernel and security requirements
csantanapr closed issue #1614: Bring Vagrant box on par wrt kernel and security requirements URL: https://github.com/apache/incubator-openwhisk/issues/1614 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #1614: Bring Vagrant box on par wrt kernel and security requirements
csantanapr commented on issue #1614: Bring Vagrant box on par wrt kernel and security requirements URL: https://github.com/apache/incubator-openwhisk/issues/1614#issuecomment-382806282 vagrant these days use ubuntu 16 and uses new kernel ``` vagrant@ubuntu-xenial:~/openwhisk$ uname -a Linux ubuntu-xenial 4.4.0-119-generic #143-Ubuntu SMP Mon Apr 2 16:08:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #1719: Vagrant doc may need update for cloudant setup
csantanapr closed issue #1719: Vagrant doc may need update for cloudant setup URL: https://github.com/apache/incubator-openwhisk/issues/1719 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #1719: Vagrant doc may need update for cloudant setup
csantanapr commented on issue #1719: Vagrant doc may need update for cloudant
setup
URL:
https://github.com/apache/incubator-openwhisk/issues/1719#issuecomment-382805622
There was something weird with how to read env variables in Vagrant that I
had to use lower case `cloudant` and then exported as upper case `Cloudant` in
Vagrant script
```
if [[ $OW_DB == "cloudant" ]]; then
export OW_DB="Cloudant"
export OW_DB_PROTOCOL="https"
export OW_DB_HOST="$OW_DB_USERNAME.cloudant.com"
export OW_DB_PORT="443"
else
export OW_DB="CouchDB"
export OW_DB_PROTOCOL=#{ENV['OW_DB_PROTOCOL']}
export OW_DB_HOST=#{ENV['OW_DB_HOST']}
export OW_DB_PORT=#{ENV['OW_DB_PORT']}
fi
```
The docs are correct.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #3448: Vagrant Dev environment
csantanapr commented on issue #3448: Vagrant Dev environment URL: https://github.com/apache/incubator-openwhisk/issues/3448#issuecomment-382804499 Yeah you can vagrant ssh and deploy your actions, create trigger and rules use the wsk inside the Vagrant VM. Another alternative is to use the wsk CLI from outside and configure the CLI to use the Vagrant IP address, the doc has more details https://github.com/apache/incubator-openwhisk/blob/master/tools/vagrant/Vagrantfile But I would recommend to use the wsk and test inside the Vagrant VM, edit your files outside and share the files into the VM with a share folder, This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #3448: Vagrant Dev environment
csantanapr closed issue #3448: Vagrant Dev environment URL: https://github.com/apache/incubator-openwhisk/issues/3448 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #3540: Vagrant Hello Not Starting on Mac
csantanapr closed issue #3540: Vagrant Hello Not Starting on Mac URL: https://github.com/apache/incubator-openwhisk/issues/3540 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #3533: Vagrant box goes out of disk quickly
csantanapr closed issue #3533: Vagrant box goes out of disk quickly URL: https://github.com/apache/incubator-openwhisk/issues/3533 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3533: Vagrant box goes out of disk quickly
csantanapr commented on issue #3533: Vagrant box goes out of disk quickly URL: https://github.com/apache/incubator-openwhisk/issues/3533#issuecomment-382803362 This is fixed now https://github.com/apache/incubator-openwhisk/pull/3561 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3540: Vagrant Hello Not Starting on Mac
csantanapr commented on issue #3540: Vagrant Hello Not Starting on Mac URL: https://github.com/apache/incubator-openwhisk/issues/3540#issuecomment-382803104 I think this is fixed now with the recent updates, please try again This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tysonnorris commented on issue #3559: add support for mesos attribute constraints
tysonnorris commented on issue #3559: add support for mesos attribute constraints URL: https://github.com/apache/incubator-openwhisk/pull/3559#issuecomment-382796067 How would you update the blackbox ratio? That ratio only applies to invokers, not the agents running action containers (which may or may not overlap with invokers at all). The contstraints would enable you to either: - run actions only on invokers, then yes the constraints should ideally match the blackbox ratio - run actions on invokers, on other non-invoker agents, or a mix, then constraints has no relation to blackbox ratio This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #3529: Authentication issues when installing openwhisk
csantanapr commented on issue #3529: Authentication issues when installing openwhisk URL: https://github.com/apache/incubator-openwhisk/issues/3529#issuecomment-382795033 This is fixed now https://github.com/apache/incubator-openwhisk/pull/3546 https://github.com/apache/incubator-openwhisk/pull/3561 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed issue #3529: Authentication issues when installing openwhisk
csantanapr closed issue #3529: Authentication issues when installing openwhisk URL: https://github.com/apache/incubator-openwhisk/issues/3529 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser closed pull request #3561: increase vagrant disksize using plugin vagrant-disksize
mdeuser closed pull request #3561: increase vagrant disksize using plugin
vagrant-disksize
URL: https://github.com/apache/incubator-openwhisk/pull/3561
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tools/vagrant/README.md b/tools/vagrant/README.md
index 18a216bb21..66d7bdbdcc 100644
--- a/tools/vagrant/README.md
+++ b/tools/vagrant/README.md
@@ -158,14 +158,6 @@ vagrant ssh
wsk action invoke /whisk.system/utils/echo -p message hello --result
```
-## Other Runntimes
-The default vagrant deploy only deploys nodejs:6 runtime kind, because the
image runs out of space if all runtimes are built.
-To add a runtime, you need to build the runtime image for example
-```
-wskdev python3action
-```
-To get a list of other available runtimes use `wskdev -c`
-
## Running OpenWhisk tests
```
vagrant ssh
diff --git a/tools/vagrant/Vagrantfile b/tools/vagrant/Vagrantfile
index 2689ec8cd6..7d8f2444e9 100644
--- a/tools/vagrant/Vagrantfile
+++ b/tools/vagrant/Vagrantfile
@@ -16,6 +16,7 @@ OW_DB = if ENV['OW_DB'] =~ (/^(cloudant|couchdb)$/i) then
true else false end
Vagrant.configure('2') do |config|
config.vm.box = BOX
+ config.disksize.size = '50GB'
config.vm.network :private_network, ip: MACHINE_IP
# If true, then any SSH connections made will enable agent forwarding.
@@ -125,7 +126,7 @@ Vagrant.configure('2') do |config|
# Build OpenWhisk using gradle
echo "`date`: build-core-start" >> /tmp/vagrant-times.txt
cd ${OPENWHISK_HOME}
-su vagrant -c './gradlew :core:controller:distDocker
:core:invoker:distDocker :actionRuntimes:nodejs6Action:distDocker'
+su vagrant -c './gradlew distDocker'
echo "`date`: build-core-end" >> /tmp/vagrant-times.txt
# Clone and Build CLI
diff --git a/tools/vagrant/hello b/tools/vagrant/hello
index d44bd174c5..a776663051 100755
--- a/tools/vagrant/hello
+++ b/tools/vagrant/hello
@@ -5,5 +5,6 @@ if [ -d ".vagrant" ]; then
vagrant destroy
fi
+vagrant plugin install vagrant-disksize
vagrant up
diff --git a/tools/vagrant/hello.cmd b/tools/vagrant/hello.cmd
index 16c535a909..9f60aef8c3 100644
--- a/tools/vagrant/hello.cmd
+++ b/tools/vagrant/hello.cmd
@@ -3,4 +3,5 @@ IF NOT EXIST .vagrant\ GOTO SKIPDESTROY
vagrant destroy
:SKIPDESTROY
+vagrant plugin install vagrant-disksize
vagrant up
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] csantanapr commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix
csantanapr commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/185#issuecomment-382762395 @dgrove-oss Do you know what `minikube update-context` do? I saw a travis script using this https://github.com/ocadotechnology/aimmo/blob/master/.travis.yml#L26 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix
csantanapr commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/185#issuecomment-382760228 @dgrove-oss you submitted a commit to my branch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ScottChapman commented on issue #110: Add support for __OW_IGNORE_CERT env var
ScottChapman commented on issue #110: Add support for __OW_IGNORE_CERT env var URL: https://github.com/apache/incubator-openwhisk-client-js/pull/110#issuecomment-382757782 bump This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr closed pull request #184: helm: get runtimes from runtimes.json
csantanapr closed pull request #184: helm: get runtimes from runtimes.json
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/184
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/helm/runtimes-minimal-travis.json
b/helm/runtimes-minimal-travis.json
new file mode 100644
index 000..98ec32b
--- /dev/null
+++ b/helm/runtimes-minimal-travis.json
@@ -0,0 +1,28 @@
+{
+"runtimes": {
+"nodejs": [
+{
+"kind": "nodejs:6",
+"default": true,
+"image": {
+"name": "nodejs6action"
+},
+"deprecated": false
+}
+],
+"python": [
+{
+"kind": "python:3",
+"image": {
+"name": "python3action"
+},
+"deprecated": false
+}
+]
+},
+"blackboxes": [
+{
+"name": "dockerskeleton"
+}
+]
+}
diff --git a/helm/runtimes.json b/helm/runtimes.json
new file mode 100644
index 000..5a81001
--- /dev/null
+++ b/helm/runtimes.json
@@ -0,0 +1,101 @@
+{
+"runtimes": {
+"nodejs": [
+{
+"kind": "nodejs",
+"image": {
+"name": "nodejsaction"
+},
+"deprecated": true
+},
+{
+"kind": "nodejs:6",
+"default": true,
+"image": {
+"name": "nodejs6action"
+},
+"deprecated": false
+},
+{
+"kind": "nodejs:8",
+"default": false,
+"image": {
+"name": "action-nodejs-v8"
+},
+"deprecated": false
+}
+],
+"python": [
+{
+"kind": "python",
+"image": {
+"name": "python2action"
+},
+"deprecated": false
+},
+{
+"kind": "python:2",
+"default": true,
+"image": {
+"name": "python2action"
+},
+"deprecated": false
+},
+{
+"kind": "python:3",
+"image": {
+"name": "python3action"
+},
+"deprecated": false
+}
+],
+"swift": [
+{
+"kind": "swift:3.1.1",
+"image": {
+"name": "action-swift-v3.1.1"
+},
+"deprecated": false
+},
+{
+"kind": "swift:4.1",
+"default": true,
+"image": {
+"name": "action-swift-v4.1"
+},
+"deprecated": false
+}
+],
+"java": [
+{
+"kind": "java",
+"default": true,
+"image": {
+"name": "java8action"
+},
+"deprecated": false,
+"attached": {
+"attachmentName": "jarfile",
+"attachmentType": "application/java-archive"
+},
+"sentinelledLogs": false,
+"requireMain": true
+}
+],
+"php": [
+{
+"kind": "php:7.1",
+"default": true,
+"deprecated": false,
+"image": {
+"name": "action-php-v7.1"
+}
+}
+]
+},
+"blackboxes": [
+{
+"name": "dockerskeleton"
+}
+]
+}
diff --git a/helm/templates/_helpers.tpl b/helm/templates/_helpers.tpl
index cfd4446..0a74efa 100644
--- a/helm/templates/_helpers.tpl
+++ b/helm/templates/_helpers.tpl
@@ -82,4 +82,13 @@
{{/* Generate redis service url */}}
{{- define "redis_url" -}}
{{ .Values.global.redisServiceName | default "redis" }}.{{ .Release.Namespace
}}
+{{- end -}}
+
+{{/* Runtimes manifest */}}
+{{- define "runtimes_manifest" -}}
+{{- if .Values.global.travis -}}
+{{ .Files.Get "runtimes-minimal-travis.json" | quote }}
+{{- else -}}
+{{ .Files.Get "runtimes.json" | quote }}
+{{- end -}}
{{- end -}}
\ No newline at end of file
diff --git a/helm/templates/controller_statefulset.yml
b/helm/templates/controller_statefulset.yml
index ed47c8e..c0d7898 100644
--- a/helm/templates/controller_statefulset.yml
+++ b/helm/templates/controller_statefulset.yml
@@ -83,9 +83,9 @@ spec:
- name:
[GitHub] csantanapr closed pull request #183: update for INVOKER_USE_RUNC being moved to PureConfig.
csantanapr closed pull request #183: update for INVOKER_USE_RUNC being moved to PureConfig. URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/183 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/helm/templates/invoker_deployment.yml b/helm/templates/invoker_deployment.yml index d749bc1..9816bc7 100644 --- a/helm/templates/invoker_deployment.yml +++ b/helm/templates/invoker_deployment.yml @@ -75,7 +75,7 @@ spec: value: "nginx.openwhisk" - name: "INVOKER_CONTAINER_NETWORK" value: "bridge" - - name: "INVOKER_USE_RUNC" + - name: "CONFIG_whisk_docker_containerFactory_useRunc" value: "false" # Properties for invoker image diff --git a/kubernetes/invoker/invoker-dcf.yml b/kubernetes/invoker/invoker-dcf.yml index 3f91786..4314ee8 100644 --- a/kubernetes/invoker/invoker-dcf.yml +++ b/kubernetes/invoker/invoker-dcf.yml @@ -98,7 +98,7 @@ spec: configMapKeyRef: name: invoker.config key: invoker_container_dns - - name: "INVOKER_USE_RUNC" + - name: "CONFIG_whisk_docker_containerFactory_useRunc" valueFrom: configMapKeyRef: name: invoker.config diff --git a/kubernetes/invoker/invoker-k8scf.yml b/kubernetes/invoker/invoker-k8scf.yml index a83a293..d5abcc5 100644 --- a/kubernetes/invoker/invoker-k8scf.yml +++ b/kubernetes/invoker/invoker-k8scf.yml @@ -106,7 +106,7 @@ spec: value: "TRUE" # Docker-related options - - name: "INVOKER_USE_RUNC" + - name: "CONFIG_whisk_docker_containerFactory_useRunc" value: "FALSE" - name: "DOCKER_IMAGE_PREFIX" valueFrom: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix
dgrove-oss commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/185#issuecomment-382731496 Already an issue...got to love open source :) https://github.com/kubernetes/minikube/issues/2704 there's a suggested workaround, add `--bootstrapper=localkube` to the minikube start command. Do you want to try it (change to about line 26 of tools/travis/setup.sh). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #3561: increase vagrant disksize using plugin vagrant-disksize
csantanapr opened a new pull request #3561: increase vagrant disksize using plugin vagrant-disksize URL: https://github.com/apache/incubator-openwhisk/pull/3561 - increase disk size for vagrant to be able to do full build This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix
csantanapr commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/185#issuecomment-382721857 Maybe we can open an issue on the minikube issue they might be able to help. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix
dgrove-oss commented on issue #185: add kube 1.10.1 and minikube 0.26 to test matrix URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/185#issuecomment-382712024 vm-driver=none tells minikube to use the host's docker instead of adding a layer of virtualization. it's the recommended way to run minikube on travisci to avoid docker-in-docker. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser closed pull request #3546: Fix vagrant not use runc
mdeuser closed pull request #3546: Fix vagrant not use runc
URL: https://github.com/apache/incubator-openwhisk/pull/3546
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitattributes b/.gitattributes
index b19d1c0901..71665f0d14 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -29,3 +29,7 @@ gradlew text eol=lf
core/javaAction/proxy/gradlew text eol=lf
tools/vagrant/hello text eol=lf
sdk/docker/client/actiontext eol=lf
+
+# auth files with default api keys
+ansible/files/auth.guest text eol=lf
+ansible/files/auth.whisk.system text eol=lf
diff --git a/.gitignore b/.gitignore
index aab3af088b..5ba08fc8cb 100644
--- a/.gitignore
+++ b/.gitignore
@@ -17,6 +17,7 @@ results
!/ansible/environments/docker-machine
!/ansible/environments/local
!/ansible/environments/mac
+!/ansible/environments/vagrant
# Eclipse
bin/
diff --git a/ansible/environments/vagrant/group_vars/all
b/ansible/environments/vagrant/group_vars/all
new file mode 100755
index 00..2015f0fb75
--- /dev/null
+++ b/ansible/environments/vagrant/group_vars/all
@@ -0,0 +1,42 @@
+whisk_version_name: local
+openwhisk_tmp_dir: "{{ lookup('env', 'OPENWHISK_TMP_DIR')|default('/tmp',
true) }}"
+config_root_dir: "{{ openwhisk_tmp_dir }}/wskconf"
+whisk_logs_dir: "{{ openwhisk_tmp_dir }}/wsklogs"
+docker_registry: ""
+docker_dns: ""
+runtimes_bypass_pull_for_local_images: true
+invoker_use_runc: "{{ ansible_distribution != 'MacOSX' }}"
+
+db_prefix: whisk_local_
+
+# Auto lookup to find the db credentials
+db_provider: "{{ lookup('ini', 'db_provider section=db_creds file={{
playbook_dir }}/db_local.ini') }}"
+db_username: "{{ lookup('ini', 'db_username section=db_creds file={{
playbook_dir }}/db_local.ini') }}"
+db_password: "{{ lookup('ini', 'db_password section=db_creds file={{
playbook_dir }}/db_local.ini') }}"
+db_protocol: "{{ lookup('ini', 'db_protocol section=db_creds file={{
playbook_dir }}/db_local.ini') }}"
+db_host: "{{ lookup('ini', 'db_host section=db_creds file={{ playbook_dir
}}/db_local.ini') }}"
+db_port: "{{ lookup('ini', 'db_port section=db_creds file={{ playbook_dir
}}/db_local.ini') }}"
+
+# API GW connection configuration
+apigw_auth_user: ""
+apigw_auth_pwd: ""
+apigw_host_v2: "http://{{ groups['apigateway']|first
}}:{{apigateway.port.api}}/v2"
+
+invoker_allow_multiple_instances: true
+
+# Set kafka configuration
+kafka_heap: '512m'
+kafka_topics_completed_retentionBytes: 104857600
+kafka_topics_completed_retentionMS: 30
+kafka_topics_health_retentionBytes: 104857600
+kafka_topics_health_retentionMS: 30
+kafka_topics_invoker_retentionBytes: 104857600
+kafka_topics_invoker_retentionMS: 30
+
+env_hosts_dir: "{{ playbook_dir }}/environments/local"
+
+controller_protocol: "http"
+
+cli_installation_mode: "local"
+
+invoker_use_runc: false
diff --git a/ansible/environments/vagrant/hosts
b/ansible/environments/vagrant/hosts
new file mode 100644
index 00..b6308123e7
--- /dev/null
+++ b/ansible/environments/vagrant/hosts
@@ -0,0 +1,29 @@
+; the first parameter in a host is the inventory_hostname
+
+; used for local actions only
+ansible ansible_connection=local
+
+[edge]
+172.17.0.1 ansible_host=172.17.0.1 ansible_connection=local
+
+[controllers]
+controller0 ansible_host=172.17.0.1 ansible_connection=local
+;
+[kafkas]
+kafka0 ansible_host=172.17.0.1 ansible_connection=local
+
+[zookeepers:children]
+kafkas
+
+[invokers]
+invoker0ansible_host=172.17.0.1 ansible_connection=local
+
+; db group is only used if db_provider is CouchDB
+[db]
+172.17.0.1 ansible_host=172.17.0.1 ansible_connection=local
+
+[redis]
+172.17.0.1 ansible_host=172.17.0.1 ansible_connection=local
+
+[apigateway]
+172.17.0.1 ansible_host=172.17.0.1 ansible_connection=local
diff --git a/ansible/files/auth.guest b/ansible/files/auth.guest
index 315627438d..39eda06b74 100644
--- a/ansible/files/auth.guest
+++ b/ansible/files/auth.guest
@@ -1 +1 @@
-23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP
+23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP
\ No newline at end of file
diff --git a/ansible/files/auth.whisk.system b/ansible/files/auth.whisk.system
index e44545b61f..dbcd2792ce 100644
--- a/ansible/files/auth.whisk.system
+++ b/ansible/files/auth.whisk.system
@@ -1 +1 @@
-789c46b1-71f6-4ed5-8c54-816aa4f8c502:abczO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP
+789c46b1-71f6-4ed5-8c54-816aa4f8c502:abczO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP
\ No newline at end of file
diff --git a/tools/ubuntu-setup/docker-xenial.sh
[GitHub] markusthoemmes commented on a change in pull request #3199: One tid for the whole system.
markusthoemmes commented on a change in pull request #3199: One tid for the
whole system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182674169
##
File path: ansible/roles/nginx/templates/nginx.conf.j2
##
@@ -12,10 +12,16 @@ http {
{# allow large uploads, need to thread proper limit into here #}
client_max_body_size 50M;
+map $http_ow_tid $ow_tid {
Review comment:
Agreed on the variable length. It shouldn't care at all (so nobody is forced
to use this specific config as their front-door). Will be changed!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3199: One tid for the whole system.
markusthoemmes commented on a change in pull request #3199: One tid for the
whole system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182674663
##
File path: ansible/roles/nginx/templates/nginx.conf.j2
##
@@ -59,6 +66,12 @@ http {
}
proxy_set_header X-OW-EXTRA-LOGGING $extra_logging;
+# Set the request id generated by nginx as tid-header to the upstream.
+# This tid is either the request-id generated by ngix or a tid, sent by
the caller.
+proxy_set_header OW-TID $ow_tid;
+
+# Send the tid always back as header.
+add_header OW-TID $ow_tid always;
Review comment:
As @ddragosd mentioned this will be changed to `X-Request-Id` (per
https://en.wikipedia.org/wiki/List_of_HTTP_header_fields#Common_non-standard_request_fields
it's a quasi standard).
The header that's picked in the controller will be configurable, so you can
use whatever front-door generates these ids for you without relying on this too
much.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3199: One tid for the whole system.
markusthoemmes commented on a change in pull request #3199: One tid for the
whole system.
URL:
https://github.com/apache/incubator-openwhisk/pull/3199#discussion_r182674169
##
File path: ansible/roles/nginx/templates/nginx.conf.j2
##
@@ -12,10 +12,16 @@ http {
{# allow large uploads, need to thread proper limit into here #}
client_max_body_size 50M;
+map $http_ow_tid $ow_tid {
Review comment:
Agreed on the variable length. It shouldn't care at all (so nobody is forced
to use this specific config as their front-door). Will be changed!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ddragosd opened a new pull request #290: Sync the Gateway configuration with a remote location
ddragosd opened a new pull request #290: Sync the Gateway configuration with a remote location URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/290 This PR introduces the capability for the Gateway to sync its configuration with a remote folder in the cloud such as Amazon S3, Google Cloud Storage, IBM Cloud Object Storage, Dropbox, and [many others](https://rclone.org/). The configuration is monitored for changes, and when a file is changed, the Gateway is reloaded automatically. This is very useful to gracefully update the Gateway on the fly, without impacting the active traffic; if the new configuration is invalid, the Gateway doesn't break, running with the last known valid configuration. See the updated README for more details. TODO: - [ ] Add a new location block in NGINX to report the Gateway configuration status such as: when it was last synced, or when was the Gateway last reloaded. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
