wgtmac commented on code in PR #1855:
URL: https://github.com/apache/orc/pull/1855#discussion_r1540485071
##
run_clang_tidy.py:
##
@@ -0,0 +1,343 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# d
wgtmac commented on code in PR #1855:
URL: https://github.com/apache/orc/pull/1855#discussion_r1540342423
##
c++/include/orc/Exceptions.hh:
##
@@ -28,8 +28,8 @@ namespace orc {
class NotImplementedYet : public std::logic_error {
public:
-explicit NotImplementedYet(c
[
https://issues.apache.org/jira/browse/ORC-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun resolved ORC-1665.
Fix Version/s: 2.1.0
Resolution: Fixed
Issue resolved by pull request 1860
[https://github.com
[
https://issues.apache.org/jira/browse/ORC-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun reassigned ORC-1665:
--
Assignee: dzcxzl
> Enable the `importOrder` function in `spotless-maven-plugin`
> --
dongjoon-hyun closed pull request #1860: ORC-1665: Migrate to `importOrder` of
`spotless-maven-plugin`
URL: https://github.com/apache/orc/pull/1860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dongjoon-hyun commented on PR #1860:
URL: https://github.com/apache/orc/pull/1860#issuecomment-2020851178
Could you resolve the conflicts, @cxzl25 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
[
https://issues.apache.org/jira/browse/ORC-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun resolved ORC-1666.
Fix Version/s: 2.1.0
Resolution: Fixed
Issue resolved by pull request 1861
[https://github.com
[
https://issues.apache.org/jira/browse/ORC-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun reassigned ORC-1666:
--
Assignee: dzcxzl
> Remove extra newlines at the end of Java files
>
dongjoon-hyun closed pull request #1861: ORC-1666: Remove extra newlines at the
end of Java files
URL: https://github.com/apache/orc/pull/1861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
[
https://issues.apache.org/jira/browse/ORC-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun reassigned ORC-1664:
--
Assignee: dzcxzl
> Enable the removeUnusedImports function in spotless-maven-plugin
> --
[
https://issues.apache.org/jira/browse/ORC-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjoon Hyun resolved ORC-1664.
Fix Version/s: 2.1.0
Resolution: Fixed
Issue resolved by pull request 1859
[https://github.com
dongjoon-hyun closed pull request #1859: ORC-1664: Migrate to
`removeUnusedImports` of `spotless-maven-plugin`
URL: https://github.com/apache/orc/pull/1859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cxzl25 opened a new pull request, #1861:
URL: https://github.com/apache/orc/pull/1861
### What changes were proposed in this pull request?
This PR aims to remove extra newlines at the end of Java files.
### Why are the changes needed?
https://github.com/apache/orc/pull/1860#discu
[
https://issues.apache.org/jira/browse/ORC-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dzcxzl updated ORC-1666:
Component/s: Java
> Remove extra newlines at the end of Java files
> --
>
cxzl25 commented on code in PR #1860:
URL: https://github.com/apache/orc/pull/1860#discussion_r1539541439
##
java/core/src/java/org/apache/orc/InMemoryKeystore.java:
##
@@ -330,4 +330,3 @@ private byte[] getMaterial() {
}
}
-
Review Comment:
> Please make a new PR for
dongjoon-hyun commented on code in PR #1860:
URL: https://github.com/apache/orc/pull/1860#discussion_r1539526592
##
java/core/src/java/org/apache/orc/InMemoryKeystore.java:
##
@@ -330,4 +330,3 @@ private byte[] getMaterial() {
}
}
-
Review Comment:
> Because these file
dongjoon-hyun commented on code in PR #1860:
URL: https://github.com/apache/orc/pull/1860#discussion_r1539527394
##
java/core/src/java/org/apache/orc/InMemoryKeystore.java:
##
@@ -330,4 +330,3 @@ private byte[] getMaterial() {
}
}
-
Review Comment:
Also, we need a way
dongjoon-hyun commented on code in PR #1860:
URL: https://github.com/apache/orc/pull/1860#discussion_r1539523446
##
java/bench/core/src/java/org/apache/orc/bench/core/RecordCounters.java:
##
@@ -49,4 +49,3 @@ public void print() {
System.out.println("Invocations: " + invoca
cxzl25 commented on code in PR #1860:
URL: https://github.com/apache/orc/pull/1860#discussion_r1539357531
##
java/core/src/java/org/apache/orc/InMemoryKeystore.java:
##
@@ -330,4 +330,3 @@ private byte[] getMaterial() {
}
}
-
Review Comment:
Because these files have tw
ffacs commented on code in PR #1855:
URL: https://github.com/apache/orc/pull/1855#discussion_r1538936858
##
c++/include/orc/Exceptions.hh:
##
@@ -28,8 +28,8 @@ namespace orc {
class NotImplementedYet : public std::logic_error {
public:
-explicit NotImplementedYet(co
stiga-huang commented on code in PR #1855:
URL: https://github.com/apache/orc/pull/1855#discussion_r1538730140
##
c++/include/orc/Exceptions.hh:
##
@@ -28,8 +28,8 @@ namespace orc {
class NotImplementedYet : public std::logic_error {
public:
-explicit NotImplemented
21 matches
Mail list logo
