[GitHub] [phoenix] kadirozde opened a new pull request #813: PHOENIX-5979 Miscellaneous read repair performance improvements
kadirozde opened a new pull request #813: URL: https://github.com/apache/phoenix/pull/813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-5980) MUTATION_BATCH_FAILED_SIZE metric is incorrectly updated for failing delete mutations
[ https://issues.apache.org/jira/browse/PHOENIX-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148249#comment-17148249 ] Chinmay Kulkarni commented on PHOENIX-5980: --- Creating this Jira as per my observations I discussed offline with you guys yesterday [~vmeka] [~sukumaddineni]. FYI [~gjacoby][~jisaac] > MUTATION_BATCH_FAILED_SIZE metric is incorrectly updated for failing delete > mutations > - > > Key: PHOENIX-5980 > URL: https://issues.apache.org/jira/browse/PHOENIX-5980 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0 >Reporter: Chinmay Kulkarni >Priority: Major > Labels: metrics, phoenix-hardening, quality-improvement > Fix For: 4.16.0 > > > In the conn.commit() path, we get the number of mutations that failed to be > committed in the catch block of MutationState.sendMutations() (see > [here|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java#L1195-L1198]). > > In case of delete mutations, the uncommittedStatementIndexes.length always > resolves to 1 and we always update the metric value by 1 in this case, even > though the actual mutation list corresponds to multiple DELETE mutations > which failed. In case of upserts, using unCommittedStatementIndexes.length is > fine since each upsert query corresponds to 1 Put. We should fix the logic > for deletes/mixed delete + upsert mutation batch failures. > This wrong value is propagated to global client metrics as well as > MutationMetricQueue metrics. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5210) NullPointerException when alter options of a table that is appendOnlySchema
[
https://issues.apache.org/jira/browse/PHOENIX-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148276#comment-17148276
]
Hadoop QA commented on PHOENIX-5210:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13006698/PHOENIX-5210.master.v3.patch
against master branch at commit 0bbe2faddce0b9b550a8efd558536bb03cfb133f.
ATTACHMENT ID: 13006698
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForNonTxGlobalIndexIT
{color:red}-1 core zombie tests{color}. There are 7 zombie test(s):
at
org.apache.phoenix.end2end.UpsertSelectIT.testUpsertSelectWithSequence(UpsertSelectIT.java:832)
at
org.apache.phoenix.end2end.RowValueConstructorOffsetIT.testRVCOffsetMoreThanKey(RowValueConstructorOffsetIT.java:272)
at
org.apache.phoenix.end2end.index.BaseIndexIT.testInFilterOnIndexedTable(BaseIndexIT.java:1040)
at
org.apache.phoenix.end2end.index.MutableIndexSplitIT.testSplitDuringIndexScan(MutableIndexSplitIT.java:83)
at
org.apache.phoenix.end2end.index.MutableIndexSplitForwardScanIT.testSplitDuringIndexScan(MutableIndexSplitForwardScanIT.java:30)
at
org.apache.phoenix.end2end.index.BaseIndexIT.testSelectDistinctOnTableWithSecondaryImmutableIndex(BaseIndexIT.java:443)
at
org.apache.phoenix.end2end.index.BaseIndexIT.testSelectAllAndAliasWithIndex(BaseIndexIT.java:596)
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4006//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4006//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4006//console
This message is automatically generated.
> NullPointerException when alter options of a table that is appendOnlySchema
> ---
>
> Key: PHOENIX-5210
> URL: https://issues.apache.org/jira/browse/PHOENIX-5210
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.15.0, 4.14.3
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5210.master.v3.patch
>
>
> I'm facing the following NullPointerException when alter options of a table
> that is appendOnlySchema.
> {code}
> java.lang.NullPointerException
> at
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3545)
> at
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3517)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableAddColumnStatement$1.execute(PhoenixStatement.java:1440)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:408)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:391)
> at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:390)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:378)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1833)
> at
> org.apache.phoenix.end2end.AppendOnlySchemaIT.testAlterTableOptions(AppendOnlySchemaIT.java:368)
> {code}
> Steps to reproduce is as follows:
> 1. Create a table that is appendOnlySchema:
> {code}
> CREATE TABLE tbl (id INTEGER PRIMARY KEY, col INTEGER) APPEND_ONLY_SCHEMA =
> true, UPDATE_CACHE_FREQUENCY = 1;
> {code}
> 2. Alter a option of the table:
> {code}
> ALTER TABLE tbl SET STORE_NULLS = true;
> {code}
> After step 2, we will face the NullPointerException.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5210) NullPointerException when alter options of a table that is appendOnlySchema
[
https://issues.apache.org/jira/browse/PHOENIX-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148222#comment-17148222
]
Chinmay Kulkarni commented on PHOENIX-5210:
---
[~0x62ash] [~brfrn169] Lost track of this sorry. Looks like the build was still
not triggered. I have re-attached the patch with a different name so Hadoop QA
should pick it up the next time around.
> NullPointerException when alter options of a table that is appendOnlySchema
> ---
>
> Key: PHOENIX-5210
> URL: https://issues.apache.org/jira/browse/PHOENIX-5210
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.15.0, 4.14.3
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5210.master.v3.patch
>
>
> I'm facing the following NullPointerException when alter options of a table
> that is appendOnlySchema.
> {code}
> java.lang.NullPointerException
> at
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3545)
> at
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3517)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableAddColumnStatement$1.execute(PhoenixStatement.java:1440)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:408)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:391)
> at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:390)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:378)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1833)
> at
> org.apache.phoenix.end2end.AppendOnlySchemaIT.testAlterTableOptions(AppendOnlySchemaIT.java:368)
> {code}
> Steps to reproduce is as follows:
> 1. Create a table that is appendOnlySchema:
> {code}
> CREATE TABLE tbl (id INTEGER PRIMARY KEY, col INTEGER) APPEND_ONLY_SCHEMA =
> true, UPDATE_CACHE_FREQUENCY = 1;
> {code}
> 2. Alter a option of the table:
> {code}
> ALTER TABLE tbl SET STORE_NULLS = true;
> {code}
> After step 2, we will face the NullPointerException.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5507) Local Index Rebuild Issues
[ https://issues.apache.org/jira/browse/PHOENIX-5507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148251#comment-17148251 ] Chao Wang commented on PHOENIX-5507: hello, I find this issues in my production environment, which the index data will be hidden behind the deletes. only we can drop index ,and recreate index table. Is there a better way? > Local Index Rebuild Issues > -- > > Key: PHOENIX-5507 > URL: https://issues.apache.org/jira/browse/PHOENIX-5507 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0, 5.1.0, 4.14.2, 4.14.3 >Reporter: Geoffrey Jacoby >Priority: Major > > An umbrella for dealing with issues around rebuilding local indexes. > While investigating PHOENIX-5502, a problem with synchronously rebuilding > global indexes, I realized that the rebuild functionality for local indexes > seems to have several problems. > # Same as PHOENIX-5502, synchronous local index rebuilds will run a delete > against the old index data, then rebuild. But the deletes will have server > time of the rebuild, and the rebuilt index rows should have the same > timestamp as their original data, so the index data will be hidden behind the > deletes. > # The IndexTool theoretically allows for doing rebuilds on local indexes, > but it has a worrisome check that prints a warning message if any split has > taken place during the rebuild, saying the rebuild has to be redone. We > should probably disable splitting during the rebuild, but then how to > guarantee it gets re-enabled if the rebuilding client goes away? > So at the very least, a solution to the above two issues would have to be > found to make local index rebuild work. But it also suggests a larger > question – given that local indexes have stronger consistency guarantees than > global, is "local index rebuild" actually a necessary feature (vs a drop and > rebuild if you somehow messed up a local index out-of-band.)? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5976) Cannot drop a column when the index view is involved
[
https://issues.apache.org/jira/browse/PHOENIX-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148265#comment-17148265
]
Chao Wang commented on PHOENIX-5976:
hello, I try to reproduct in my environment, but there is not this issues in
4.13.1 and 5.0.0.
> Cannot drop a column when the index view is involved
> -
>
> Key: PHOENIX-5976
> URL: https://issues.apache.org/jira/browse/PHOENIX-5976
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.15.0, 4.16.0
>Reporter: Xinyi Yan
>Priority: Blocker
> Fix For: 4.16.0
>
>
> This is how to reproduce it on the 4.x branch:
> {code:java}
> // create table
> stmt.execute("CREATE TABLE IF NOT EXISTS DUMMY (ID CHAR(10) NOT
> NULL,KEY_PREFIX CHAR(3) NOT NULL," +
> " CONSTRAINT PK PRIMARY KEY (ID,KEY_PREFIX))");
> // create view
> stmt.execute(
> "CREATE VIEW IF NOT EXISTS DUMMY_VIEW (PK1 DATE NOT NULL,PK2
> CHAR(15) NOT NULL," +
> "NON_PK1 CHAR(15),NON_PK2 CHAR(15) CONSTRAINT PKVIEW PRIMARY
> KEY (PK1,PK2)) " +
> "AS SELECT * FROM DUMMY WHERE KEY_PREFIX = '123'");
> // create index
> stmt.execute("CREATE INDEX DUMMY_INDEX ON DUMMY_VIEW (PK2, PK1) INCLUDE
> (NON_PK1, NON_PK2)");
> // drop column
> stmt.execute("ALTER VIEW DUMMY_VIEW DROP COLUMN IF EXISTS NON_PK1");
> {code}
> {code:java}
> org.apache.hadoop.hbase.DoNotRetryIOException: ERROR 504 (42703): ERROR 504
> (42703): Undefined column. columnName=0:NON_PK2
> DUMMY_VIEWorg.apache.hadoop.hbase.DoNotRetryIOException: ERROR 504 (42703):
> ERROR 504 (42703): Undefined column. columnName=0:NON_PK2 DUMMY_VIEW at
> org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:114) at
> org.apache.phoenix.util.ServerUtil.throwIOException(ServerUtil.java:88) at
> org.apache.phoenix.coprocessor.MetaDataEndpointImpl.mutateColumn(MetaDataEndpointImpl.java:2823)
> at
> org.apache.phoenix.coprocessor.MetaDataEndpointImpl.dropColumn(MetaDataEndpointImpl.java:3026)
> at
> org.apache.phoenix.coprocessor.generated.MetaDataProtos$MetaDataService.callMethod(MetaDataProtos.java:17253)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:8523)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:2282)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:2264)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36808)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2399) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:311) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:291)Caused
> by: org.apache.phoenix.schema.ColumnNotFoundException: ERROR 504 (42703):
> Undefined column. columnName=0:NON_PK2 at
> org.apache.phoenix.schema.PColumnFamilyImpl.getPColumnForColumnNameBytes(PColumnFamilyImpl.java:86)
> at org.apache.phoenix.util.MetaDataUtil.getColumn(MetaDataUtil.java:982) at
> org.apache.phoenix.coprocessor.DropColumnMutator.validateAndAddMetadata(DropColumnMutator.java:184)
> at
> org.apache.phoenix.coprocessor.MetaDataEndpointImpl.mutateColumn(MetaDataEndpointImpl.java:2719)
> ... 10 more
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5975) Index rebuild/verification page size should be configurable from IndexTool
[
https://issues.apache.org/jira/browse/PHOENIX-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148298#comment-17148298
]
Hadoop QA commented on PHOENIX-5975:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13006696/PHOENIX-5975-master.patch
against master branch at commit 0bbe2faddce0b9b550a8efd558536bb03cfb133f.
ATTACHMENT ID: 13006696
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+"CREATE INDEX %s ON %s (NAME) INCLUDE (ZIP)
ASYNC ", indexTableName, dataTableFullName);
+IndexTool indexTool = IndexToolIT.runIndexTool(conf, directApi,
useSnapshot, schemaName, dataTableName, indexTableName, null, 0,
IndexTool.IndexVerifyType.BEFORE, new String[0]);
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(INPUT_RECORDS).getValue());
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(SCANNED_DATA_ROW_COUNT).getValue());
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(REBUILT_INDEX_ROW_COUNT).getValue());
+assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_VALID_INDEX_ROW_COUNT).getValue());
+assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_EXPIRED_INDEX_ROW_COUNT).getValue());
+assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_INVALID_INDEX_ROW_COUNT).getValue());
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_MISSING_INDEX_ROW_COUNT).getValue());
+public static IndexTool runIndexTool(Configuration conf, boolean
directApi, boolean useSnapshot, String schemaName,
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UnionAllIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForNonTxGlobalIndexIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4005//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4005//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4005//console
This message is automatically generated.
> Index rebuild/verification page size should be configurable from IndexTool
> --
>
> Key: PHOENIX-5975
> URL: https://issues.apache.org/jira/browse/PHOENIX-5975
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5975-4.x.001.patch, PHOENIX-5975-4.x.002.patch,
> PHOENIX-5975-4.x.patch, PHOENIX-5975-master.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5975) Index rebuild/verification page size should be configurable from IndexTool
[ https://issues.apache.org/jira/browse/PHOENIX-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148302#comment-17148302 ] Abhishek Singh Chouhan commented on PHOENIX-5975: - Test errors are unrelated and pass locally. Committing shortly. > Index rebuild/verification page size should be configurable from IndexTool > -- > > Key: PHOENIX-5975 > URL: https://issues.apache.org/jira/browse/PHOENIX-5975 > Project: Phoenix > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5975-4.x.001.patch, PHOENIX-5975-4.x.002.patch, > PHOENIX-5975-4.x.patch, PHOENIX-5975-master.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5975) Index rebuild/verification page size should be configurable from IndexTool
[
https://issues.apache.org/jira/browse/PHOENIX-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148221#comment-17148221
]
Hadoop QA commented on PHOENIX-5975:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13006684/PHOENIX-5975-4.x.002.patch
against 4.x branch at commit 0bbe2faddce0b9b550a8efd558536bb03cfb133f.
ATTACHMENT ID: 13006684
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+"CREATE INDEX %s ON %s (NAME) INCLUDE (ZIP)
ASYNC ", indexTableName, dataTableFullName);
+IndexTool indexTool = IndexToolIT.runIndexTool(conf, directApi,
useSnapshot, schemaName, dataTableName, indexTableName, null, 0,
IndexTool.IndexVerifyType.BEFORE, new String[0]);
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(INPUT_RECORDS).getValue());
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(SCANNED_DATA_ROW_COUNT).getValue());
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(REBUILT_INDEX_ROW_COUNT).getValue());
+assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_VALID_INDEX_ROW_COUNT).getValue());
+assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_EXPIRED_INDEX_ROW_COUNT).getValue());
+assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_INVALID_INDEX_ROW_COUNT).getValue());
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_MISSING_INDEX_ROW_COUNT).getValue());
+assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_BEYOND_MAXLOOKBACK_MISSING_INDEX_ROW_COUNT).getValue());
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4004//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4004//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4004//console
This message is automatically generated.
> Index rebuild/verification page size should be configurable from IndexTool
> --
>
> Key: PHOENIX-5975
> URL: https://issues.apache.org/jira/browse/PHOENIX-5975
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5975-4.x.001.patch, PHOENIX-5975-4.x.002.patch,
> PHOENIX-5975-4.x.patch, PHOENIX-5975-master.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5981) Wrong multiple counting of resultSetTimeMs and wallclockTimeMs in OverallQueryMetrics
[ https://issues.apache.org/jira/browse/PHOENIX-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148255#comment-17148255 ] Chinmay Kulkarni commented on PHOENIX-5981: --- FYI [~sukumaddineni] [~jisaac] [~dbwong] [~gjacoby] > Wrong multiple counting of resultSetTimeMs and wallclockTimeMs in > OverallQueryMetrics > - > > Key: PHOENIX-5981 > URL: https://issues.apache.org/jira/browse/PHOENIX-5981 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0 >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Labels: metrics, phoenix-hardening, quality-improvement > Fix For: 4.16.0 > > > We update wallClockTimeMS and resultSetTimeMS when we reach the last row in > our ResultSet iterations (see > [this|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixResultSet.java#L878-L881]). > However, this is also called inside PhoenixResultSet.close(), see > [this|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixResultSet.java#L214-L215]. > The problem is, these calls in-turn add elapsedTime again > ([endQuery|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/monitoring/OverAllQueryMetrics.java#L86] > and > [stopResultsetWatch|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/monitoring/OverAllQueryMetrics.java#L95]) > and so these metrics get 2X the value they should. Ideally we should change > the metrics only if the stopWatch was running before calling stopWatch.stop > or else we will count it multiple times. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5975) Index rebuild/verification page size should be configurable from IndexTool
[
https://issues.apache.org/jira/browse/PHOENIX-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148188#comment-17148188
]
Hadoop QA commented on PHOENIX-5975:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13006682/PHOENIX-5975-4.x.001.patch
against 4.x branch at commit 0bbe2faddce0b9b550a8efd558536bb03cfb133f.
ATTACHMENT ID: 13006682
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+"CREATE INDEX %s ON %s (NAME) INCLUDE (ZIP)
ASYNC ", indexTableName, dataTableFullName);
+IndexTool indexTool = IndexToolIT.runIndexTool(conf, directApi,
useSnapshot, schemaName, dataTableName, indexTableName, null, 0,
IndexTool.IndexVerifyType.BEFORE, new String[0]);
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(INPUT_RECORDS).getValue());
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(SCANNED_DATA_ROW_COUNT).getValue());
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(REBUILT_INDEX_ROW_COUNT).getValue());
+assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_VALID_INDEX_ROW_COUNT).getValue());
+assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_EXPIRED_INDEX_ROW_COUNT).getValue());
+assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_INVALID_INDEX_ROW_COUNT).getValue());
+assertEquals(NROWS,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_MISSING_INDEX_ROW_COUNT).getValue());
+assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_BEYOND_MAXLOOKBACK_MISSING_INDEX_ROW_COUNT).getValue());
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4003//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4003//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4003//console
This message is automatically generated.
> Index rebuild/verification page size should be configurable from IndexTool
> --
>
> Key: PHOENIX-5975
> URL: https://issues.apache.org/jira/browse/PHOENIX-5975
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5975-4.x.001.patch, PHOENIX-5975-4.x.002.patch,
> PHOENIX-5975-4.x.patch, PHOENIX-5975-master.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix-queryserver] joshelser commented on pull request #39: PHOENIX-5901 Fix licensing in preparation for first python release
joshelser commented on pull request #39: URL: https://github.com/apache/phoenix-queryserver/pull/39#issuecomment-651390414 I had the code changes staged here and (I think) got distracted waiting for a test result and then just never pushed. If this is holding you up, please feel free to rebase it and go ahead with it tmrw. Otherwise, I'll try to do the rebase myself first thing :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-5716) Remove or update HBase 2.0 support
[ https://issues.apache.org/jira/browse/PHOENIX-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147647#comment-17147647 ] Istvan Toth commented on PHOENIX-5716: -- As per feedback on the dev list by [~elserj] I've decided to remove 2.0 support. GH PR submission seems to be down right now, please review the attached patch. > Remove or update HBase 2.0 support > -- > > Key: PHOENIX-5716 > URL: https://issues.apache.org/jira/browse/PHOENIX-5716 > Project: Phoenix > Issue Type: Task >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Attachments: PHOENIX-5716.master.v1.patch > > > Since HBase 2.0 is EOM, we could remove support for it from master. > If we are not ready to do that, we could update it to work with 2.0.6 release. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5783) Implement starttime in IndexTool for rebuild and verification
[ https://issues.apache.org/jira/browse/PHOENIX-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147616#comment-17147616 ] Richard Antal commented on PHOENIX-5783: [~swaroopa] are you working on the fix for master? If not please let me know and I am going to take a look at it. > Implement starttime in IndexTool for rebuild and verification > - > > Key: PHOENIX-5783 > URL: https://issues.apache.org/jira/browse/PHOENIX-5783 > Project: Phoenix > Issue Type: Bug >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Major > Attachments: PHOENIX-5783.4.x.001.patch, PHOENIX-5783.4.x.010.patch, > PHOENIX-5783.4.x.011.patch, PHOENIX-5783.4.x.100.patch, > PHOENIX-5783.4.x.v1.patch, PHOENIX-5783.4.x.v2.patch, > PHOENIX-5783.4.x.v3.patch, PHOENIX-5783.v1.patch > > Time Spent: 2h > Remaining Estimate: 0h > > IndexTool's inline verification and rebuild should be able to perform the > logic for a specified time range given by starttime parameters. > > This feature is only for indexes on non-transactional tables > . -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5929) IndexToolForNonTxGlobalIndexIT.testDisableOutputLogging is flapping
[ https://issues.apache.org/jira/browse/PHOENIX-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147623#comment-17147623 ] Richard Antal commented on PHOENIX-5929: Hey [~gjacoby] This issue seems to happen on the master as well, look at these builds: [103|https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/103/], [100,|https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/100/] [102|https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.0/102/#showFailuresLink] Should PHOENIX-5785 be forward ported to master? > IndexToolForNonTxGlobalIndexIT.testDisableOutputLogging is flapping > --- > > Key: PHOENIX-5929 > URL: https://issues.apache.org/jira/browse/PHOENIX-5929 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.16.0 >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 4.16.0 > > Attachments: PHOENIX-5929-4.x.v1.patch, PHOENIX-5929-4.x.v2.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > IndexToolForNonTxGlobalIndexIT.testDisableOutputLogging occasionally fails > because only 1 output row is found rather than 2. This test was introduced in > PHOENIX-5785. I haven't been able to reproduce locally, but it's happened on > the Apache Jenkins pre-commit build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5951) IndexTool output logging for past-max-lookback rows should be configurable
[
https://issues.apache.org/jira/browse/PHOENIX-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147607#comment-17147607
]
Hadoop QA commented on PHOENIX-5951:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13006637/PHOENIX-5951-4.x.v5.patch
against 4.x branch at commit e6fc80cf706518214c36a92189ab1c5dbb24a9ba.
ATTACHMENT ID: 13006637
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+serverProps.put(ScanInfoUtil.PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY,
Long.toString(MAX_LOOKBACK_AGE));
+deleteAllRows(conn,
TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME));
+
set(IndexRebuildRegionScanner.PHOENIX_INDEX_MR_LOG_BEYOND_MAX_LOOKBACK_ERRORS,
"true");
+TestUtil.dumpTable(conn,
TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME));
+
counters.findCounter(BEFORE_REBUILD_BEYOND_MAXLOOKBACK_MISSING_INDEX_ROW_COUNT).getValue());
+
getUtility().getHBaseAdmin().disableTable(TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME));
+
getUtility().getHBaseAdmin().truncateTable(TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME),
true);
+IndexTool.IndexDisableLoggingType disableLoggingVerifyType =
IndexTool.IndexDisableLoggingType.NONE;
+ IndexVerificationErrorType errorType)
throws SQLException, IOException {
+
scan.getAttribute(BaseScannerRegionObserver.INDEX_REBUILD_DISABLE_LOGGING_BEYOND_MAXLOOKBACK_AGE);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ParameterizedIndexUpgradeToolIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3998//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3998//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3998//console
This message is automatically generated.
> IndexTool output logging for past-max-lookback rows should be configurable
> --
>
> Key: PHOENIX-5951
> URL: https://issues.apache.org/jira/browse/PHOENIX-5951
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Geoffrey Jacoby
>Assignee: Geoffrey Jacoby
>Priority: Major
> Attachments: PHOENIX-5951-4.x.v1.patch, PHOENIX-5951-4.x.v2.patch,
> PHOENIX-5951-4.x.v3.patch, PHOENIX-5951-4.x.v4.patch,
> PHOENIX-5951-4.x.v5.patch
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> On a global mutable table with lots of writes, it can be possible for there
> to be many rows flagged by index verification as invalid that are older than
> the max lookback age. These are likely due to race conditions between
> compaction in the base table and index table, but they can possibly show real
> issues.
> Since heavy output logging to PHOENIX_INDEX_TOOL can cause hotspotting, some
> operators may want to turn it off for this class of failures, while still
> wanting output logging for other kinds of invalid rows.
> As part of this change, we should start including in the output row a column
> with a code identifying the type of error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5937) Order by on nullable column sometimes filters rows
[ https://issues.apache.org/jira/browse/PHOENIX-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147687#comment-17147687 ] Istvan Toth commented on PHOENIX-5937: -- Thank you for digging into this, and the fix. 1. Nit: The indentation seems to be off 2. Not using Java 8 features would make backporting to 4.x easier, and the code more consistent 3. You have dug into the code deeply, and you added the specific circumstances that triggered the bug for me as a new else if branch. I do not understand the whole context of this change. Could you explain how did you come to the conclusion that this is indeed the only case where this bug triggers ? > Order by on nullable column sometimes filters rows > -- > > Key: PHOENIX-5937 > URL: https://issues.apache.org/jira/browse/PHOENIX-5937 > Project: Phoenix > Issue Type: Bug > Components: core >Affects Versions: 4.x, master >Reporter: Istvan Toth >Assignee: Richard Antal >Priority: Major > Attachments: PHOENIX-5937.master.v1.patch, > PHOENIX-5937.master.v2.patch, PHOENIX-5937.master.v3.patch > > > When selecting using order by on a nullable column, the rows where the order > column is null are sometimes not returned. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5937) Order by on nullable column sometimes filters rows
[ https://issues.apache.org/jira/browse/PHOENIX-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147723#comment-17147723 ] Istvan Toth commented on PHOENIX-5937: -- +1 LGTM > Order by on nullable column sometimes filters rows > -- > > Key: PHOENIX-5937 > URL: https://issues.apache.org/jira/browse/PHOENIX-5937 > Project: Phoenix > Issue Type: Bug > Components: core >Affects Versions: 4.x, master >Reporter: Istvan Toth >Assignee: Richard Antal >Priority: Major > Attachments: PHOENIX-5937.master.v1.patch, > PHOENIX-5937.master.v2.patch, PHOENIX-5937.master.v3.patch, > PHOENIX-5937.master.v4.patch > > > When selecting using order by on a nullable column, the rows where the order > column is null are sometimes not returned. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5977) Fix BasePermissionsIT#testReadPermsOnTableIndexAndView with HBase 2.0 profile
[ https://issues.apache.org/jira/browse/PHOENIX-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147725#comment-17147725 ] Rajeshbabu Chintaguntla commented on PHOENIX-5977: -- [~stoty]then we can close it. > Fix BasePermissionsIT#testReadPermsOnTableIndexAndView with HBase 2.0 profile > - > > Key: PHOENIX-5977 > URL: https://issues.apache.org/jira/browse/PHOENIX-5977 > Project: Phoenix > Issue Type: Test >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 5.1.0 > > Attachments: testfailure.txt > > > With HBase profile 2.0 BasePermissionsIT#testReadPermsOnTableIndexAndView is > failing. > https://builds.apache.org/view/All/job/Phoenix-master-matrix/lastCompletedBuild/HBASE_PROFILE=2.0/testReport/org.apache.phoenix.end2end/PermissionNSDisabledIT/testReadPermsOnTableIndexAndView/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5937) Order by on nullable column sometimes filters rows
[
https://issues.apache.org/jira/browse/PHOENIX-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147724#comment-17147724
]
Richard Antal commented on PHOENIX-5937:
Thank you [~stoty] for for checking the patch. I have uploaded v4 right now, it
fixes 1. 2.
I compared the following queries,
{code:java}
select * from SYSTEM.CATALOG where TABLE_NAME = 'US_POPULATION' order by
ORDINAL_POSITION;
select COLUMN_NAME from SYSTEM.CATALOG where TABLE_NAME = 'US_POPULATION' order
by ORDINAL_POSITION;{code}
And I found some difference in scan plan, debugged where the source of this
difference is.
In the BaseResultIterators line number 246-251 we add these empty key values to
the scan, but it only happened in case of !projector.projectEverything() was
true. (so the 2nd line)
Basically I just added an extra if statement for the given circumstances and
copied the lines which modified the scan plan.
> Order by on nullable column sometimes filters rows
> --
>
> Key: PHOENIX-5937
> URL: https://issues.apache.org/jira/browse/PHOENIX-5937
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Affects Versions: 4.x, master
>Reporter: Istvan Toth
>Assignee: Richard Antal
>Priority: Major
> Attachments: PHOENIX-5937.master.v1.patch,
> PHOENIX-5937.master.v2.patch, PHOENIX-5937.master.v3.patch,
> PHOENIX-5937.master.v4.patch
>
>
> When selecting using order by on a nullable column, the rows where the order
> column is null are sometimes not returned.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix-queryserver] stoty opened a new pull request #40: PHOENIX-5964 Rename queryserver subprojects
stoty opened a new pull request #40: URL: https://github.com/apache/phoenix-queryserver/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-5977) Fix BasePermissionsIT#testReadPermsOnTableIndexAndView with HBase 2.0 profile
[ https://issues.apache.org/jira/browse/PHOENIX-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147695#comment-17147695 ] Istvan Toth commented on PHOENIX-5977: -- We're planning to remove HBase 2.0 support soon, so fixing it may not be worth the effort. > Fix BasePermissionsIT#testReadPermsOnTableIndexAndView with HBase 2.0 profile > - > > Key: PHOENIX-5977 > URL: https://issues.apache.org/jira/browse/PHOENIX-5977 > Project: Phoenix > Issue Type: Test >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 5.1.0 > > Attachments: testfailure.txt > > > With HBase profile 2.0 BasePermissionsIT#testReadPermsOnTableIndexAndView is > failing. > https://builds.apache.org/view/All/job/Phoenix-master-matrix/lastCompletedBuild/HBASE_PROFILE=2.0/testReport/org.apache.phoenix.end2end/PermissionNSDisabledIT/testReadPermsOnTableIndexAndView/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix] stoty opened a new pull request #811: PHOENIX-5716 Remove HBase 2.0 support
stoty opened a new pull request #811: URL: https://github.com/apache/phoenix/pull/811 also update default Hbase 2.2 and 2.1 versions to latest and greatest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-5964) Rename queryserver subprojects
[ https://issues.apache.org/jira/browse/PHOENIX-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147810#comment-17147810 ] Istvan Toth commented on PHOENIX-5964: -- I went with the longer form, based on the input of [~tamaas] and [~elserj] (on the dev list) > Rename queryserver subprojects > -- > > Key: PHOENIX-5964 > URL: https://issues.apache.org/jira/browse/PHOENIX-5964 > Project: Phoenix > Issue Type: Improvement > Components: queryserver >Affects Versions: queryserver-1.0.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > The current phoenix-queryserver maven subproject/artifact names are quite > arbitrary and inconsistent. > The current structure: > phoenix-queryserver > assembly > load-balancer > queryserver > queryserver-client > queryerrver-it > queryserver-orchestrator > I propose that we change this to either: > phoenix-queryserver > queryserver-assembly > queryserver-load-balancer > queryserver > queryserver-client > queryerrver-it > queryserver-orchestrator > or > phoenix-queryserver-parent > phoenix-queryserver-assembly > phoenix-queryserver-load-balancer > phoenix-queryserver > phoenix-queryserver-client > phoenix-queryerrver-it > phoenix-queryserver-orchestrator > The latter is more consistent with hadoop conventions, and the pre-split > artifact names, and matches the pre-unbundling artifact names better, but is > also quite long. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5210) NullPointerException when alter options of a table that is appendOnlySchema
[
https://issues.apache.org/jira/browse/PHOENIX-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147802#comment-17147802
]
Alex Batyrshin commented on PHOENIX-5210:
-
Ping
> NullPointerException when alter options of a table that is appendOnlySchema
> ---
>
> Key: PHOENIX-5210
> URL: https://issues.apache.org/jira/browse/PHOENIX-5210
> Project: Phoenix
> Issue Type: Bug
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Attachments: PHOENIX-5210.master.v1.patch,
> PHOENIX-5210.master.v2.patch
>
>
> I'm facing the following NullPointerException when alter options of a table
> that is appendOnlySchema.
> {code}
> java.lang.NullPointerException
> at
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3545)
> at
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3517)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableAddColumnStatement$1.execute(PhoenixStatement.java:1440)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:408)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:391)
> at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:390)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:378)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1833)
> at
> org.apache.phoenix.end2end.AppendOnlySchemaIT.testAlterTableOptions(AppendOnlySchemaIT.java:368)
> {code}
> Steps to reproduce is as follows:
> 1. Create a table that is appendOnlySchema:
> {code}
> CREATE TABLE tbl (id INTEGER PRIMARY KEY, col INTEGER) APPEND_ONLY_SCHEMA =
> true, UPDATE_CACHE_FREQUENCY = 1;
> {code}
> 2. Alter a option of the table:
> {code}
> ALTER TABLE tbl SET STORE_NULLS = true;
> {code}
> After step 2, we will face the NullPointerException.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5937) Order by on nullable column sometimes filters rows
[ https://issues.apache.org/jira/browse/PHOENIX-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147820#comment-17147820 ] Hudson commented on PHOENIX-5937: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4002 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4002/]) PHOENIX-5937 Order by on nullable column sometimes filters rows (stoty: rev 0bbe2faddce0b9b550a8efd558536bb03cfb133f) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseOrderByIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java > Order by on nullable column sometimes filters rows > -- > > Key: PHOENIX-5937 > URL: https://issues.apache.org/jira/browse/PHOENIX-5937 > Project: Phoenix > Issue Type: Bug > Components: core >Affects Versions: 4.x, master >Reporter: Istvan Toth >Assignee: Richard Antal >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5937.master.v1.patch, > PHOENIX-5937.master.v2.patch, PHOENIX-5937.master.v3.patch, > PHOENIX-5937.master.v4.patch > > > When selecting using order by on a nullable column, the rows where the order > column is null are sometimes not returned. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5716) Remove or update HBase 2.0 support
[
https://issues.apache.org/jira/browse/PHOENIX-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147848#comment-17147848
]
Hadoop QA commented on PHOENIX-5716:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13006654/PHOENIX-5716.master.v1.patch
against master branch at commit e6fc80cf706518214c36a92189ab1c5dbb24a9ba.
ATTACHMENT ID: 13006654
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 0 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificViewIndexSaltedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SkipScanQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForNonTxGlobalIndexIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4000//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4000//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4000//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4000//console
This message is automatically generated.
> Remove or update HBase 2.0 support
> --
>
> Key: PHOENIX-5716
> URL: https://issues.apache.org/jira/browse/PHOENIX-5716
> Project: Phoenix
> Issue Type: Task
>Affects Versions: 5.1.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Attachments: PHOENIX-5716.master.v1.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Since HBase 2.0 is EOM, we could remove support for it from master.
> If we are not ready to do that, we could update it to work with 2.0.6 release.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #801: PHOENIX-5951 - Index rebuild output logging for past-max-lookback row…
gjacoby126 commented on a change in pull request #801: URL: https://github.com/apache/phoenix/pull/801#discussion_r447110046 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ## @@ -96,6 +102,11 @@ private static final Logger LOGGER = LoggerFactory.getLogger(IndexRebuildRegionScanner.class); +public static final String PHOENIX_INDEX_MR_LOG_BEYOND_MAX_LOOKBACK_ERRORS = +"phoenix.index.mr.log.beyond.max.lookback.errors"; +public static final boolean DEFAULT_PHOENIX_INDEX_MR_LOG_BEYOND_MAX_LOOKBACK_ERRORS = false; +private boolean useProto = true; +private byte[] indexRowKey; Review comment: Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on pull request #801: PHOENIX-5951 - Index rebuild output logging for past-max-lookback row…
gjacoby126 commented on pull request #801: URL: https://github.com/apache/phoenix/pull/801#issuecomment-651237031 @kadirozde - I believe I have addressed all your comments. (Thanks for pointing out the auto-complete errors where the wrong conf key was being used.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-queryserver] asfgit closed pull request #40: PHOENIX-5964 Rename queryserver subprojects
asfgit closed pull request #40: URL: https://github.com/apache/phoenix-queryserver/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-5937) Order by on nullable column sometimes filters rows
[
https://issues.apache.org/jira/browse/PHOENIX-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148014#comment-17148014
]
Hadoop QA commented on PHOENIX-5937:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13006661/PHOENIX-5937.master.v4.patch
against master branch at commit e6fc80cf706518214c36a92189ab1c5dbb24a9ba.
ATTACHMENT ID: 13006661
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalImmutableTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForNonTxGlobalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterMultiTenantTableWithViewsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4001//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4001//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4001//console
This message is automatically generated.
> Order by on nullable column sometimes filters rows
> --
>
> Key: PHOENIX-5937
> URL: https://issues.apache.org/jira/browse/PHOENIX-5937
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Affects Versions: 4.x, master
>Reporter: Istvan Toth
>Assignee: Richard Antal
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5937.master.v1.patch,
> PHOENIX-5937.master.v2.patch, PHOENIX-5937.master.v3.patch,
> PHOENIX-5937.master.v4.patch
>
>
> When selecting using order by on a nullable column, the rows where the order
> column is null are sometimes not returned.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [phoenix-queryserver] stoty commented on pull request #39: PHOENIX-5901 Fix licensing in preparation for first python release
stoty commented on pull request #39: URL: https://github.com/apache/phoenix-queryserver/pull/39#issuecomment-651278245 This will need a rebase because of PHOENIX-5964. Would you like me to do the rebase and the agreed remaining changes ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] kadirozde closed pull request #805: PHOENIX-5957 Index rebuild should remove old index rows with higher t…
kadirozde closed pull request #805: URL: https://github.com/apache/phoenix/pull/805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-5975) Index rebuild/verification page size should be configurable from IndexTool
[ https://issues.apache.org/jira/browse/PHOENIX-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148031#comment-17148031 ] Kadir OZDEMIR commented on PHOENIX-5975: +1, Thanks. > Index rebuild/verification page size should be configurable from IndexTool > -- > > Key: PHOENIX-5975 > URL: https://issues.apache.org/jira/browse/PHOENIX-5975 > Project: Phoenix > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5975-4.x.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [phoenix-queryserver] stoty commented on pull request #40: PHOENIX-5964 Rename queryserver subprojects
stoty commented on pull request #40: URL: https://github.com/apache/phoenix-queryserver/pull/40#issuecomment-651283694 Thanks for the review @joshelser This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] abhishek-chouhan opened a new pull request #812: PHOENIX-5975 Index rebuild/verification page size should be configura…
abhishek-chouhan opened a new pull request #812: URL: https://github.com/apache/phoenix/pull/812 …ble from IndexTool This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] abhishek-chouhan commented on a change in pull request #812: PHOENIX-5975 Index rebuild/verification page size should be configura…
abhishek-chouhan commented on a change in pull request #812: URL: https://github.com/apache/phoenix/pull/812#discussion_r447241574 ## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixServerBuildIndexMapper.java ## @@ -25,22 +25,39 @@ import org.apache.hadoop.io.NullWritable; import org.apache.hadoop.mapreduce.Mapper; import org.apache.phoenix.mapreduce.PhoenixJobCounters; +import org.apache.phoenix.query.QueryServices; +import org.omg.CORBA.REBIND; Review comment: oops, ide goof up. Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] gjacoby126 merged pull request #801: PHOENIX-5951 - Index rebuild output logging for past-max-lookback row…
gjacoby126 merged pull request #801: URL: https://github.com/apache/phoenix/pull/801 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] kadirozde commented on a change in pull request #812: PHOENIX-5975 Index rebuild/verification page size should be configura…
kadirozde commented on a change in pull request #812: URL: https://github.com/apache/phoenix/pull/812#discussion_r447237319 ## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixServerBuildIndexMapper.java ## @@ -25,22 +25,39 @@ import org.apache.hadoop.io.NullWritable; import org.apache.hadoop.mapreduce.Mapper; import org.apache.phoenix.mapreduce.PhoenixJobCounters; +import org.apache.phoenix.query.QueryServices; +import org.omg.CORBA.REBIND; Review comment: Is this used? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
