[PR] fix(deps): update dependency com.gradleup.shadow:shadow-gradle-plugin to v9.0.2 [polaris]

2025-08-14 Thread via GitHub
renovate-bot opened a new pull request, #2358: URL: https://github.com/apache/polaris/pull/2358 This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [com.gradleup.shadow:shadow-gradle-plugin](https://redirect.github.com/GradleUp/sha

[I] Broken links https://polaris.apache.org/releases/1.0.0/entities [polaris]

2025-08-14 Thread via GitHub
bacek opened a new issue, #2357: URL: https://github.com/apache/polaris/issues/2357 This PR broke links from the main site. E.g. from https://polaris.apache.org/releases/1.0.0/entities/#privilege -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Cleanup unnecessary files in client/python [polaris]

2025-08-14 Thread via GitHub
bacek commented on PR #1878: URL: https://github.com/apache/polaris/pull/1878#issuecomment-3190550321 This PR broke links from the main site. E.g. from https://polaris.apache.org/releases/1.0.0/entities/#privilege -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Remove PolarisCallContext.getMetaStore [polaris]

2025-08-14 Thread via GitHub
dennishuo commented on code in PR #2229: URL: https://github.com/apache/polaris/pull/2229#discussion_r2278089134 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/BaseMetaStoreManager.java: ## @@ -53,6 +56,16 @@ public static PolarisStorageConfigurationInfo extr

Re: [PR] Spanner Persistence Backend for Polaris [polaris]

2025-08-14 Thread via GitHub
byronellis commented on code in PR #2328: URL: https://github.com/apache/polaris/pull/2328#discussion_r2278043544 ## persistence/google-cloud-spanner/src/main/java/org/apache/polaris/persistence/relational/spanner/GoogleCloudSpannerDatabaseClientLifecycleManager.java: ## @@ -0,0

Re: [PR] Spanner Persistence Backend for Polaris [polaris]

2025-08-14 Thread via GitHub
byronellis commented on code in PR #2328: URL: https://github.com/apache/polaris/pull/2328#discussion_r2278042476 ## persistence/google-cloud-spanner/src/main/java/org/apache/polaris/persistence/relational/spanner/GoogleCloudSpannerDatabaseClientLifecycleManager.java: ## @@ -0,0

Re: [PR] Spanner Persistence Backend for Polaris [polaris]

2025-08-14 Thread via GitHub
byronellis commented on code in PR #2328: URL: https://github.com/apache/polaris/pull/2328#discussion_r2278042135 ## persistence/google-cloud-spanner/src/main/java/org/apache/polaris/persistence/relational/spanner/DatabaseAdminClientSupplier.java: ## Review Comment: eh, cha

Re: [PR] Spanner Persistence Backend for Polaris [polaris]

2025-08-14 Thread via GitHub
byronellis commented on code in PR #2328: URL: https://github.com/apache/polaris/pull/2328#discussion_r2278041539 ## persistence/google-cloud-spanner/src/main/java/org/apache/polaris/persistence/relational/spanner/util/SpannerUtil.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to t

Re: [PR] Expose resetCredentials via api to allow root user to reset credentials for an existing principal with custom values [polaris]

2025-08-14 Thread via GitHub
fivetran-arunsuri commented on PR #2197: URL: https://github.com/apache/polaris/pull/2197#issuecomment-3190334816 @dimas-b Sorry for the delay, I was tied up with some high-priority incidents. Could you please take a look? I’m planning to merge this week -- This is an automated message fr

Re: [PR] Expose resetCredentials via api to allow root user to reset credentials for an existing principal with custom values [polaris]

2025-08-14 Thread via GitHub
fivetran-arunsuri commented on code in PR #2197: URL: https://github.com/apache/polaris/pull/2197#discussion_r2278035402 ## polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java: ## @@ -599,6 +604,16 @@ public void authorizeOrThrow( authen

Re: [PR] Expose resetCredentials via api to allow root user to reset credentials for an existing principal with custom values [polaris]

2025-08-14 Thread via GitHub
fivetran-arunsuri commented on code in PR #2197: URL: https://github.com/apache/polaris/pull/2197#discussion_r2278034225 ## polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrincipalSecrets.java: ## @@ -147,6 +147,19 @@ public void rotateSecrets(String newSeconda

Re: [PR] Expose resetCredentials via api to allow root user to reset credentials for an existing principal with custom values [polaris]

2025-08-14 Thread via GitHub
fivetran-arunsuri commented on code in PR #2197: URL: https://github.com/apache/polaris/pull/2197#discussion_r2278029881 ## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -774,6 +774,69 @@ public Polar

Re: [PR] Expose resetCredentials via api to allow root user to reset credentials for an existing principal with custom values [polaris]

2025-08-14 Thread via GitHub
fivetran-arunsuri commented on code in PR #2197: URL: https://github.com/apache/polaris/pull/2197#discussion_r2278029488 ## spec/polaris-management-service.yml: ## @@ -1227,6 +1263,22 @@ components: - currentEntityVersion - properties +ResetPrincipalReque

Re: [PR] Support HMS Federation [polaris]

2025-08-14 Thread via GitHub
poojanilangekar commented on PR #2355: URL: https://github.com/apache/polaris/pull/2355#issuecomment-3190285064 Here is a [jupyter notebook](https://github.com/poojanilangekar/polaris/blob/hive-demo/regtests/hive_federation_demo.ipynb) I've used in the past to demo the feature. (in lieu of

Re: [PR] Expose resetCredentials via api to allow root user to reset credentials for an existing principal with custom values [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2197: URL: https://github.com/apache/polaris/pull/2197#discussion_r2277962489 ## polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java: ## @@ -599,6 +604,16 @@ public void authorizeOrThrow( authenticatedPri

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277950629 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277950121 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
XJDKC commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277949804 ## polaris-core/src/main/java/org/apache/polaris/core/identity/ServiceIdentityType.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] Support HMS Federation [polaris]

2025-08-14 Thread via GitHub
poojanilangekar commented on PR #2355: URL: https://github.com/apache/polaris/pull/2355#issuecomment-3190201980 Yes, I have a test that I used locally. Unfortunately, I just can't add it to the test until we get this PR baked into the Docker image. :( -- This is an automated message from

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277947921 ## polaris-core/src/main/java/org/apache/polaris/core/identity/ServiceIdentityType.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[I] StorageConfigInfo should be optional for EXTERNAL catalogs [polaris]

2025-08-14 Thread via GitHub
poojanilangekar opened a new issue, #2356: URL: https://github.com/apache/polaris/issues/2356 ### Describe the bug Currently, StorageConfigInfo is required for both INTERNAL and EXTERNAL catalogs. However for federated catalogs, Polaris does not need this information since it

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
poojanilangekar commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277947866 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
XJDKC commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277946286 ## polaris-core/src/main/java/org/apache/polaris/core/identity/ServiceIdentityType.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277944480 ## polaris-core/src/main/java/org/apache/polaris/core/identity/ServiceIdentityType.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277944480 ## polaris-core/src/main/java/org/apache/polaris/core/identity/ServiceIdentityType.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277941838 ## polaris-core/src/main/java/org/apache/polaris/core/identity/ServiceIdentityType.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
XJDKC commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277936516 ## polaris-core/src/main/java/org/apache/polaris/core/identity/ServiceIdentityType.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277941838 ## polaris-core/src/main/java/org/apache/polaris/core/identity/ServiceIdentityType.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
XJDKC commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277936516 ## polaris-core/src/main/java/org/apache/polaris/core/identity/ServiceIdentityType.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on PR #2190: URL: https://github.com/apache/polaris/pull/2190#issuecomment-3190179777 @XJDKC : looks like my previous comments are totally optional... Please fix conflicts, though. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277934046 ## polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java: ## @@ -338,6 +338,14 @@ public Builder setConnectionConfigInfoDpoWithSecrets( re

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277933579 ## polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java: ## @@ -173,6 +194,15 @@ public static ConnectionConfigInfoDpo fromConnec

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277932374 ## polaris-core/src/main/java/org/apache/polaris/core/secrets/SecretReference.java: ## @@ -51,7 +51,7 @@ * the stored "secret material" as well as the referencePayloa

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
XJDKC commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277931470 ## polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java: ## @@ -173,6 +194,15 @@ public static ConnectionConfigInfoDpo fromConnecti

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277930846 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
XJDKC commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277930371 ## polaris-core/src/main/java/org/apache/polaris/core/secrets/SecretReference.java: ## @@ -51,7 +51,7 @@ * the stored "secret material" as well as the referencePayload

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
XJDKC commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277931023 ## polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java: ## @@ -338,6 +338,14 @@ public Builder setConnectionConfigInfoDpoWithSecrets( retu

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
poojanilangekar commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277927125 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Support HMS Federation [polaris]

2025-08-14 Thread via GitHub
poojanilangekar commented on PR #2355: URL: https://github.com/apache/polaris/pull/2355#issuecomment-3190140284 CC: @dennishuo @eric-maynard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[PR] Support HMS Federation [polaris]

2025-08-14 Thread via GitHub
poojanilangekar opened a new pull request, #2355: URL: https://github.com/apache/polaris/pull/2355 Supports federating to HiveCatalog using the Iceberg REST library. All hive dependencies are added in an independent module, i.e., `polaris-extensions-federation-hive` and can be removed/co

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277873436 ## polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java: ## @@ -338,6 +338,14 @@ public Builder setConnectionConfigInfoDpoWithSecrets( re

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277893892 ## polaris-core/src/main/java/org/apache/polaris/core/identity/ServiceIdentityType.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277855485 ## polaris-core/src/main/java/org/apache/polaris/core/secrets/SecretReference.java: ## @@ -51,7 +51,7 @@ * the stored "secret material" as well as the referencePayloa

Re: [PR] Replace CallContext with RealmConfig in CatalogEntity [polaris]

2025-08-14 Thread via GitHub
flyrain merged PR #2336: URL: https://github.com/apache/polaris/pull/2336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Replace CallContext with RealmConfig in enforceFeatureEnabledOrThrow [polaris]

2025-08-14 Thread via GitHub
flyrain merged PR #2348: URL: https://github.com/apache/polaris/pull/2348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277848441 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Modularize calls to federated catalogs [polaris]

2025-08-14 Thread via GitHub
poojanilangekar closed pull request #2301: Modularize calls to federated catalogs URL: https://github.com/apache/polaris/pull/2301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
poojanilangekar commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277798619 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Add KMS support for S3 [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #1424: URL: https://github.com/apache/polaris/pull/1424#discussion_r2277790140 ## polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java: ## @@ -239,4 +291,11 @@ private String getArnPrefixFor(String r

Re: [PR] feat(docs): Add Getting Stated guide for MinIO [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2227: URL: https://github.com/apache/polaris/pull/2227#discussion_r2277782671 ## getting-started/assets/polaris/obtain-token.sh: ## @@ -0,0 +1,37 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] feat(docs): Add Getting Stated guide for MinIO [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2227: URL: https://github.com/apache/polaris/pull/2227#discussion_r2277782349 ## site/content/in-dev/unreleased/getting-started/minio.md: ## @@ -0,0 +1,115 @@ +--- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
eric-maynard commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277765262 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Refactor Authenticator and PolarisPrincipal [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on PR #2307: URL: https://github.com/apache/polaris/pull/2307#issuecomment-3189928304 Shall we mark it as "draft" until @collado-mike reviews? (just to avoid the impression that it's mergeable) -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Add integration tests with Keycloak [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2343: URL: https://github.com/apache/polaris/pull/2343#discussion_r2277757685 ## runtime/service/src/intTest/java/org/apache/polaris/service/it/RestCatalogKeycloakFileIT.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
poojanilangekar commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277755384 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Add integration tests with Keycloak [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2343: URL: https://github.com/apache/polaris/pull/2343#discussion_r2277754221 ## runtime/test-common/build.gradle.kts: ## @@ -32,10 +32,21 @@ configurations.all { } dependencies { + implementation(project(":polaris-core")) + implementation(

[PR] chore(deps): update postgres docker tag to v17.6 [polaris]

2025-08-14 Thread via GitHub
renovate-bot opened a new pull request, #2354: URL: https://github.com/apache/polaris/pull/2354 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | postgres | final | minor | `17.5-alpine` -> `17.6-alpine` | | postgres | | minor |

Re: [PR] Add integration tests with Keycloak [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2343: URL: https://github.com/apache/polaris/pull/2343#discussion_r2277755783 ## runtime/service/src/intTest/java/org/apache/polaris/service/it/RestCatalogKeycloakFileIT.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Modularize federation (Option 2) [polaris]

2025-08-14 Thread via GitHub
dennishuo merged PR #2332: URL: https://github.com/apache/polaris/pull/2332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.a

Re: [PR] Add integration tests with Keycloak [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2343: URL: https://github.com/apache/polaris/pull/2343#discussion_r2277754221 ## runtime/test-common/build.gradle.kts: ## @@ -32,10 +32,21 @@ configurations.all { } dependencies { + implementation(project(":polaris-core")) + implementation(

Re: [PR] Modularize federation (Option 2) [polaris]

2025-08-14 Thread via GitHub
dennishuo commented on PR #2332: URL: https://github.com/apache/polaris/pull/2332#issuecomment-3189915081 Looks like other comments have also been addressed, merging now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277739584 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Add support for S3 request signing [polaris]

2025-08-14 Thread via GitHub
singhpk234 commented on code in PR #2280: URL: https://github.com/apache/polaris/pull/2280#discussion_r2276774113 ## api/iceberg-aws-sign-service/src/main/java/org/apache/polaris/service/aws/sign/model/PolarisS3SignRequest.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
poojanilangekar commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277491276 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Add a regression test for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
dennishuo merged PR #2286: URL: https://github.com/apache/polaris/pull/2286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.a

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
eric-maynard commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277469212 ## integration-tests/src/main/java/org/apache/polaris/service/it/test/CatalogFederationIntegrationTest.java: ## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache So

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
eric-maynard commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277467426 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Add a regression test for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
dennishuo commented on PR #2286: URL: https://github.com/apache/polaris/pull/2286#issuecomment-3189494302 Yeah, I agree the "Docker" discussion is worth expanding in another thread, even though it's orthogonal to this PR. I'm definitely also in favor of supporting the non-Docker scenarios l

[PR] chore(deps): update registry.access.redhat.com/ubi9/openjdk-21-runtime docker tag to v1.23-6 [polaris]

2025-08-14 Thread via GitHub
renovate-bot opened a new pull request, #2353: URL: https://github.com/apache/polaris/pull/2353 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [registry.access.redhat.com/ubi9/openjdk-21-runtime](https://redirect.github.com/rh-op

Re: [PR] SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence [polaris]

2025-08-14 Thread via GitHub
dennishuo commented on code in PR #2190: URL: https://github.com/apache/polaris/pull/2190#discussion_r2277253883 ## polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpo.java: ## @@ -64,22 +66,29 @@ public abstract class ConnectionConfigInfoDpo im

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
poojanilangekar commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277248022 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Modularize federation (Option 2) [polaris]

2025-08-14 Thread via GitHub
poojanilangekar commented on code in PR #2332: URL: https://github.com/apache/polaris/pull/2332#discussion_r2277236823 ## polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionType.java: ## @@ -77,4 +80,22 @@ public enum ConnectionType { public int getCode()

Re: [PR] Modularize federation (Option 2) [polaris]

2025-08-14 Thread via GitHub
poojanilangekar commented on code in PR #2332: URL: https://github.com/apache/polaris/pull/2332#discussion_r2277178712 ## polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionType.java: ## @@ -35,6 +35,9 @@ public enum ConnectionType { HADOOP(2), ; +

Re: [PR] Modularize federation (Option 2) [polaris]

2025-08-14 Thread via GitHub
sfc-gh-pnilangekar commented on code in PR #2332: URL: https://github.com/apache/polaris/pull/2332#discussion_r2277166313 ## polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionType.java: ## @@ -35,6 +35,9 @@ public enum ConnectionType { HADOOP(2), ;

Re: [PR] Modularize federation (Option 2) [polaris]

2025-08-14 Thread via GitHub
sfc-gh-pnilangekar commented on code in PR #2332: URL: https://github.com/apache/polaris/pull/2332#discussion_r2277166313 ## polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionType.java: ## @@ -35,6 +35,9 @@ public enum ConnectionType { HADOOP(2), ;

Re: [PR] Integration tests for Catalog Federation [polaris]

2025-08-14 Thread via GitHub
adutra commented on code in PR #2344: URL: https://github.com/apache/polaris/pull/2344#discussion_r2277098353 ## runtime/spark-tests/src/intTest/java/org/apache/polaris/service/spark/it/CatalogFederationIT.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Automate the release guide [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2156: URL: https://github.com/apache/polaris/pull/2156#discussion_r2276970064 ## releasey/02-create-release-branch.sh: ## @@ -0,0 +1,201 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

Re: [PR] Automate the release guide [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on code in PR #2156: URL: https://github.com/apache/polaris/pull/2156#discussion_r2276970064 ## releasey/02-create-release-branch.sh: ## @@ -0,0 +1,201 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

Re: [PR] Add support for S3 request signing [polaris]

2025-08-14 Thread via GitHub
singhpk234 commented on PR #2280: URL: https://github.com/apache/polaris/pull/2280#issuecomment-3188856023 Hey @adutra thank you the change, i was reading the description and it turns out we are introducing new priviledges, IMHO this requires broader set of eyes and feedbacks as its just no

Re: [PR] add refresh credentials property to loadTableResult [polaris]

2025-08-14 Thread via GitHub
smaheshwar-pltr commented on code in PR #2341: URL: https://github.com/apache/polaris/pull/2341#discussion_r2276887979 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java: ## @@ -420,16 +423,45 @@ public Response loadTable(

Re: [PR] add refresh credentials property to loadTableResult [polaris]

2025-08-14 Thread via GitHub
smaheshwar-pltr commented on code in PR #2341: URL: https://github.com/apache/polaris/pull/2341#discussion_r2276878241 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java: ## @@ -420,16 +423,45 @@ public Response loadTable(

Re: [PR] add refresh credentials property to loadTableResult [polaris]

2025-08-14 Thread via GitHub
singhpk234 commented on code in PR #2341: URL: https://github.com/apache/polaris/pull/2341#discussion_r2273916299 ## runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java: ## @@ -420,16 +423,45 @@ public Response loadTable(

Re: [PR] Add integration tests with Keycloak [polaris]

2025-08-14 Thread via GitHub
snazy commented on code in PR #2343: URL: https://github.com/apache/polaris/pull/2343#discussion_r2276844226 ## runtime/test-common/build.gradle.kts: ## @@ -32,10 +32,21 @@ configurations.all { } dependencies { + implementation(project(":polaris-core")) + implementation(li

Re: [PR] Prefer PolarisTaskConstants over literals [polaris]

2025-08-14 Thread via GitHub
singhpk234 merged PR #2346: URL: https://github.com/apache/polaris/pull/2346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.

Re: [PR] Add support for S3 request signing [polaris]

2025-08-14 Thread via GitHub
snazy commented on code in PR #2280: URL: https://github.com/apache/polaris/pull/2280#discussion_r2276822566 ## runtime/service/src/main/java/org/apache/polaris/service/storage/aws/signer/S3RemoteSigningCatalogHandler.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Part 1 : Adds RLS and CLS control Policies [polaris]

2025-08-14 Thread via GitHub
singhpk234 commented on PR #2048: URL: https://github.com/apache/polaris/pull/2048#issuecomment-3188672347 Again, Could you clarify which of the points above are directly related to this pr? this pr just defines policies and is not related how protection instructions are exposed (via view t

Re: [PR] Add support for S3 request signing [polaris]

2025-08-14 Thread via GitHub
snazy commented on code in PR #2280: URL: https://github.com/apache/polaris/pull/2280#discussion_r2276793008 ## polaris-core/src/main/java/org/apache/polaris/core/storage/StorageAccessProperty.java: ## @@ -39,6 +42,21 @@ public enum StorageAccessProperty { Boolean.class,

Re: [PR] Add entitySubType param to BasePersistence.listEntities [polaris]

2025-08-14 Thread via GitHub
XN137 commented on code in PR #2317: URL: https://github.com/apache/polaris/pull/2317#discussion_r2276778985 ## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -427,43 +428,28 @@ public Page listEntitie

[I] Optimize JdbcBasePersistenceImpl.listEntities [polaris]

2025-08-14 Thread via GitHub
XN137 opened a new issue, #2352: URL: https://github.com/apache/polaris/issues/2352 ### Is your feature request related to a problem? Please describe. in https://github.com/apache/polaris/pull/2317 a TODO got added to the jdbc persistence implementation: https://github.com/apache/

Re: [PR] Add support for S3 request signing [polaris]

2025-08-14 Thread via GitHub
adutra commented on code in PR #2280: URL: https://github.com/apache/polaris/pull/2280#discussion_r2276745804 ## runtime/service/src/main/java/org/apache/polaris/service/storage/aws/signer/S3RemoteSigningCatalogHandler.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache So

Re: [PR] Modularize federation (Option 2) [polaris]

2025-08-14 Thread via GitHub
adutra commented on code in PR #2332: URL: https://github.com/apache/polaris/pull/2332#discussion_r2276734351 ## polaris-core/src/main/java/org/apache/polaris/core/connection/ConnectionType.java: ## @@ -77,4 +80,22 @@ public enum ConnectionType { public int getCode() { r

Re: [PR] feat(docs): Add Getting Stated guide for MinIO [polaris]

2025-08-14 Thread via GitHub
adutra commented on code in PR #2227: URL: https://github.com/apache/polaris/pull/2227#discussion_r2276066211 ## getting-started/assets/polaris/obtain-token.sh: ## @@ -0,0 +1,37 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

Re: [I] Incorrect documentation in rsa-key-pair for production. [polaris]

2025-08-14 Thread via GitHub
snazy commented on issue #2334: URL: https://github.com/apache/polaris/issues/2334#issuecomment-3188567468 @bacek thanks for bringing this up! Do you have bandwidth to fix the docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Malformed subscoped credentials error with external s3 [polaris]

2025-08-14 Thread via GitHub
dimas-b commented on issue #2207: URL: https://github.com/apache/polaris/issues/2207#issuecomment-3188540838 As discussed above, this is not really a bug :) Keeping it open but removing the bug label. Also, #2280 should help here too. -- This is an automated message from the Apache

Re: [PR] Add PolarisMetaStoreManager.loadEntities [polaris]

2025-08-14 Thread via GitHub
adutra commented on code in PR #2290: URL: https://github.com/apache/polaris/pull/2290#discussion_r2276703908 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java: ## @@ -129,6 +132,59 @@ ListEntitiesResult listEntities( @Nonnull

Re: [PR] fix(deps): update dependency com.nimbusds:nimbus-jose-jwt to v10.4.2 [polaris]

2025-08-14 Thread via GitHub
snazy merged PR #2350: URL: https://github.com/apache/polaris/pull/2350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apach

Re: [PR] Add support for S3 request signing [polaris]

2025-08-14 Thread via GitHub
adutra commented on code in PR #2280: URL: https://github.com/apache/polaris/pull/2280#discussion_r2276668383 ## runtime/service/src/main/java/org/apache/polaris/service/context/catalog/PolarisCallContextCatalogFactory.java: ## @@ -92,7 +104,10 @@ public Catalog createCallContex

Re: [PR] Add PolarisMetaStoreManager.loadEntities [polaris]

2025-08-14 Thread via GitHub
XN137 commented on code in PR #2290: URL: https://github.com/apache/polaris/pull/2290#discussion_r2276642647 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java: ## @@ -129,6 +132,59 @@ ListEntitiesResult listEntities( @Nonnull P

Re: [PR] Add support for S3 request signing [polaris]

2025-08-14 Thread via GitHub
adutra commented on code in PR #2280: URL: https://github.com/apache/polaris/pull/2280#discussion_r2276616845 ## polaris-core/src/main/java/org/apache/polaris/core/storage/StorageAccessProperty.java: ## @@ -39,6 +42,21 @@ public enum StorageAccessProperty { Boolean.class,

Re: [PR] Add support for S3 request signing [polaris]

2025-08-14 Thread via GitHub
adutra commented on code in PR #2280: URL: https://github.com/apache/polaris/pull/2280#discussion_r2276583859 ## integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisS3RemoteSigningIntegrationTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Sof

  1   2   >