Harbs commented on pull request #1101:
URL: https://github.com/apache/royale-asjs/pull/1101#issuecomment-819025172
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Harbs merged pull request #1101:
URL: https://github.com/apache/royale-asjs/pull/1101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
mjesteve commented on pull request #1101:
URL: https://github.com/apache/royale-asjs/pull/1101#issuecomment-818940013
Don't apologise Harbs, I appreciate your efforts to assist me.
I have already done the PR.
--
This is an automated message from the Apache Git Service.
To respond to
mjesteve opened a new pull request #1101:
URL: https://github.com/apache/royale-asjs/pull/1101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
mjesteve edited a comment on pull request #1101:
URL: https://github.com/apache/royale-asjs/pull/1101#issuecomment-818940013
Don't apologise Harbs, I appreciate your efforts to assist me.
I have already done the PR. #1101
--
This is an automated message from the Apache Git Service.
Harbs commented on issue #1100:
URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818923555
I'm sorry. My bad. Your solution seems to be the way to go. Please create a
PR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mjesteve commented on issue #1100:
URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818820782
Harb, sortNames contains the "name" of the field(s) to sort by, we cannot
pass it to Number. At the same point in the sortOn() function we cannot convert
the values of arr
mjesteve commented on issue #1100:
URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818598917
Ok, I'll do it like this.
I will test it and if it works as expected I will create the PR.
Thx Harbs.
--
This is an automated message from the Apache Git Service.
To
Harbs commented on issue #1100:
URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818596440
The reason I'm suggesting the change in `sortOn` rather than `compareNumber`
is that results in many fewer coercions.
--
This is an automated message from the Apache Git
Harbs commented on issue #1100:
URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818594746
If that works, please create a PR...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Harbs commented on issue #1100:
URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818594564
Don't have time to test right now, but I'd probably fix it by modifying
`sortOn` like so:
if (opt2 & Array.NUMERIC)
{
mjesteve commented on issue #1100:
URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818517998
Hi Harbs,
this is the code before the modification:
```
org.apache.royale.utils.Language.sortOn = function(arr, names, opt) {
opt = typeof opt !== 'undefined'
Harbs commented on issue #1100:
URL: https://github.com/apache/royale-asjs/issues/1100#issuecomment-818491957
What does `sortOn` cross-compile to? (I don't have the time right now to
check.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please
13 matches
Mail list logo
