[GitHub] [royale-asjs] yishayw commented on issue #937: Skin Not Being Sized Correctly

2021-10-18 Thread GitBox
yishayw commented on issue #937: URL: https://github.com/apache/royale-asjs/issues/937#issuecomment-945699121 Works in ChildResize -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [royale-asjs] yishayw commented on issue #994: Height 100% - Child Resize Inconsistent Behavior

2021-10-18 Thread GitBox
yishayw commented on issue #994: URL: https://github.com/apache/royale-asjs/issues/994#issuecomment-945691673 I can confirm it works in ChildResize as well. Will ChildResize or PR #1135 is merged. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [royale-asjs] yishayw commented on issue #1019: Spark - padding causes an offset in SkinnableContainer (Group is OK)

2021-10-18 Thread GitBox
yishayw commented on issue #1019: URL: https://github.com/apache/royale-asjs/issues/1019#issuecomment-945687216 It's fixed in both ChildResize and in PR #1135. Once we merge either of these two I'll close it. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [royale-asjs] greg-dove commented on pull request #1156: Update MXRoyaleBase build.xml to match the one in MXRoyale.

2021-10-13 Thread GitBox
greg-dove commented on pull request #1156: URL: https://github.com/apache/royale-asjs/pull/1156#issuecomment-942891772 Thanks @estanglerbm, very much appreciated. I actually started work on the MXRoyale split over a year ago, and had copied that ant file as it was at the time I started. I

[GitHub] [royale-asjs] greg-dove merged pull request #1156: Update MXRoyaleBase build.xml to match the one in MXRoyale.

2021-10-13 Thread GitBox
greg-dove merged pull request #1156: URL: https://github.com/apache/royale-asjs/pull/1156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] greg-dove commented on pull request #1156: Update MXRoyaleBase build.xml to match the one in MXRoyale.

2021-10-13 Thread GitBox
greg-dove commented on pull request #1156: URL: https://github.com/apache/royale-asjs/pull/1156#issuecomment-942888172 Thanks @estanglerbm I will check this and merge asap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [royale-asjs] greg-dove edited a comment on issue #1151: model binding on the views does not work on royale 0.9.8

2021-10-09 Thread GitBox
greg-dove edited a comment on issue #1151: URL: https://github.com/apache/royale-asjs/issues/1151#issuecomment-939365497 Can I ask you to do 2 things please; 1. Make sure it is not css-related - because you are using Jewel, you don't want the MXRoyale css. So you need to make sure you

[GitHub] [royale-asjs] greg-dove commented on issue #1151: model binding on the views does not work on royale 0.9.8

2021-10-09 Thread GitBox
greg-dove commented on issue #1151: URL: https://github.com/apache/royale-asjs/issues/1151#issuecomment-939365497 Can I ask you to do 2 things please; 1. Make sure it is not css-related - because you are using Jewel, you don't want the MXRoyale css. So you need to make sure you have the

[GitHub] [royale-asjs] mjesteve opened a new pull request #1155: jewel ThreeCheckBox - first commit

2021-10-08 Thread GitBox
mjesteve opened a new pull request #1155: URL: https://github.com/apache/royale-asjs/pull/1155 In this first proposal I have included in the _checkbox.sass files this new control (like the Switch component) but as we said, maybe it is better to create your own. I have managed to

[GitHub] [royale-asjs] mjesteve edited a comment on pull request #1154: Jewel VirtualComboBoxPupUp custom item renderer 2

2021-10-05 Thread GitBox
mjesteve edited a comment on pull request #1154: URL: https://github.com/apache/royale-asjs/pull/1154#issuecomment-934157141 Correct. It worked with the itemRenderer recognition in the CSS (j|VirtualComboBox) but not with the direct mapping. I have explained it in the PR

[GitHub] [royale-asjs] mjesteve commented on pull request #1154: Jewel VirtualComboBoxPupUp custom item renderer 2

2021-10-05 Thread GitBox
mjesteve commented on pull request #1154: URL: https://github.com/apache/royale-asjs/pull/1154#issuecomment-934157141 Correct. It worked with the itemRenderer recognition in the CSS (j|VirtualComboBox) but not with the direct mapping. -- This is an automated message from the Apache

[GitHub] [royale-asjs] piotrzarzycki21 merged pull request #1154: Jewel VirtualComboBoxPupUp custom item renderer 2

2021-10-05 Thread GitBox
piotrzarzycki21 merged pull request #1154: URL: https://github.com/apache/royale-asjs/pull/1154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] piotrzarzycki21 commented on pull request #1154: Jewel VirtualComboBoxPupUp custom item renderer 2

2021-10-05 Thread GitBox
piotrzarzycki21 commented on pull request #1154: URL: https://github.com/apache/royale-asjs/pull/1154#issuecomment-934156424 Let's merge this one - I believe if we are doing similar things in other places, let's proceed. -- This is an automated message from the Apache Git Service. To

[GitHub] [royale-asjs] piotrzarzycki21 commented on pull request #1154: Jewel VirtualComboBoxPupUp custom item renderer 2

2021-10-05 Thread GitBox
piotrzarzycki21 commented on pull request #1154: URL: https://github.com/apache/royale-asjs/pull/1154#issuecomment-934155171 It looks like previous attempt is not the right way and it didn't work ? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [royale-asjs] mjesteve commented on pull request #1153: Jewel VirtualComboBox only recognises itemRenderers assigned via className

2021-10-05 Thread GitBox
mjesteve commented on pull request #1153: URL: https://github.com/apache/royale-asjs/pull/1153#issuecomment-934154178 I have added the proposed modifications in the PR #1154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [royale-asjs] mjesteve opened a new pull request #1154: Jewel VirtualComboBoxPupUp custom item renderer 2

2021-10-05 Thread GitBox
mjesteve opened a new pull request #1154: URL: https://github.com/apache/royale-asjs/pull/1154 Fixed previous PR #1153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [royale-asjs] mjesteve commented on pull request #1153: Jewel VirtualComboBox only recognises itemRenderers assigned via className

2021-10-04 Thread GitBox
mjesteve commented on pull request #1153: URL: https://github.com/apache/royale-asjs/pull/1153#issuecomment-933974256 Hi, After further debugging the code, I believe that the patched code should be moved to "get list()", as it is in the ComboBoxPopUpView.as In the "set strand", it

[GitHub] [royale-asjs] piotrzarzycki21 merged pull request #1153: Jewel VirtualComboBox only recognises itemRenderers assigned via className

2021-10-04 Thread GitBox
piotrzarzycki21 merged pull request #1153: URL: https://github.com/apache/royale-asjs/pull/1153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] mjesteve commented on a change in pull request #1153: Jewel VirtualComboBox only recognises itemRenderers assigned via className

2021-10-01 Thread GitBox
mjesteve commented on a change in pull request #1153: URL: https://github.com/apache/royale-asjs/pull/1153#discussion_r720316259 ## File path: frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/VirtualComboBoxPopUpView.as ## @@ -58,6 +59,11 @@

[GitHub] [royale-asjs] piotrzarzycki21 commented on a change in pull request #1153: Jewel VirtualComboBox only recognises itemRenderers assigned via className

2021-10-01 Thread GitBox
piotrzarzycki21 commented on a change in pull request #1153: URL: https://github.com/apache/royale-asjs/pull/1153#discussion_r720024842 ## File path: frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/VirtualComboBoxPopUpView.as ## @@ -58,6 +59,11

[GitHub] [royale-asjs] mjesteve opened a new pull request #1153: Jewel VirtualComboBox only recognises itemRenderers assigned via className

2021-09-27 Thread GitBox
mjesteve opened a new pull request #1153: URL: https://github.com/apache/royale-asjs/pull/1153 Those set through property "itemRenderer" in the mxml tag are not recognised. It can be checked in the TDJ. If we change the mapping of the ItemRenderer in the VirtualComboBox of the

[GitHub] [royale-compiler] greg-dove commented on issue #189: ASDoc comments should be ignored (as if they were regular comments) when they appear in unexpected places

2021-09-23 Thread GitBox
greg-dove commented on issue #189: URL: https://github.com/apache/royale-compiler/issues/189#issuecomment-926222052 I think this is related: I have seen similar issues with ASDoc comments before an else statement It will give a Syntax Error saying expected SCOPE_CLOSE but got 'else'

[GitHub] [royale-asjs] cottage14 commented on issue #1152: ApacheCon

2021-09-20 Thread GitBox
cottage14 commented on issue #1152: URL: https://github.com/apache/royale-asjs/issues/1152#issuecomment-923063766 There are no Royale talks this year, alas. A On Mon., Sep. 20, 2021, 12:15 p.m. Bilbosax, ***@***.***> wrote: > Sorry to post this in the "Issues"

[GitHub] [royale-asjs] Bilbosax opened a new issue #1152: ApacheCon

2021-09-20 Thread GitBox
Bilbosax opened a new issue #1152: URL: https://github.com/apache/royale-asjs/issues/1152 Sorry to post this in the "Issues" section, but I can't find anywhere else to discuss this. I was looking forward to hearing about Royale at ApacheCon which starts tomorrow. But I went to the

[GitHub] [royale-asjs] nyemiks opened a new issue #1151: model binding on the views does not work on royale 0.9.8

2021-09-20 Thread GitBox
nyemiks opened a new issue #1151: URL: https://github.com/apache/royale-asjs/issues/1151 I created a new royale project that uses crux. After declaring the first ui control. (A jewel drop down). I tried populating a jewel drop down with data from the server. I have configured the

[GitHub] [royale-asjs] Harbs commented on pull request #1150: Moved some (non-MX) changes from PR #1127. Add support for XML data …

2021-09-20 Thread GitBox
Harbs commented on pull request #1150: URL: https://github.com/apache/royale-asjs/pull/1150#issuecomment-922671418 Thanks. I'm not going to be available to continue this discussion for the next week plus. I'll try to come up with some suggestions then. -- This is an automated message

[GitHub] [royale-asjs] Harbs merged pull request #1127: Various small fixes and changes

2021-09-20 Thread GitBox
Harbs merged pull request #1127: URL: https://github.com/apache/royale-asjs/pull/1127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] Harbs commented on pull request #1127: Various small fixes and changes

2021-09-20 Thread GitBox
Harbs commented on pull request #1127: URL: https://github.com/apache/royale-asjs/pull/1127#issuecomment-922670570 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [royale-asjs] estanglerbm commented on pull request #1127: Various small fixes and changes

2021-09-19 Thread GitBox
estanglerbm commented on pull request #1127: URL: https://github.com/apache/royale-asjs/pull/1127#issuecomment-922548768 Moved some (non-MX) changes to PR #1150. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [royale-asjs] estanglerbm opened a new pull request #1150: Moved some (non-MX) changes from PR #1127. Add support for XML data …

2021-09-19 Thread GitBox
estanglerbm opened a new pull request #1150: URL: https://github.com/apache/royale-asjs/pull/1150 …in several areas, especially around sorting and grids. Based on feedback from @harbs. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [royale-asjs] estanglerbm opened a new pull request #1149: Fix preserving spaces in MX System.setClipboard().

2021-09-15 Thread GitBox
estanglerbm opened a new pull request #1149: URL: https://github.com/apache/royale-asjs/pull/1149 Just changed use of "span" to "pre", to preserve spaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [royale-asjs] estanglerbm opened a new pull request #1148: Uncomment skin states in Spark SkinnableContainerBase.

2021-09-15 Thread GitBox
estanglerbm opened a new pull request #1148: URL: https://github.com/apache/royale-asjs/pull/1148 Closes #1131. Thanks to @joshtynjala. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [royale-asjs] estanglerbm commented on pull request #1127: Various small fixes and changes

2021-09-15 Thread GitBox
estanglerbm commented on pull request #1127: URL: https://github.com/apache/royale-asjs/pull/1127#issuecomment-920434990 Don't forget about these fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [royale-asjs] joshtynjala commented on issue #1131: Compile not catching missing states in skin MXML

2021-09-10 Thread GitBox
joshtynjala commented on issue #1131: URL: https://github.com/apache/royale-asjs/issues/1131#issuecomment-917007492 @estanglerbm Go for it! I generally try to stick to the compiler only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [royale-asjs] estanglerbm commented on issue #1131: Compile not catching missing states in skin MXML

2021-09-09 Thread GitBox
estanglerbm commented on issue #1131: URL: https://github.com/apache/royale-asjs/issues/1131#issuecomment-916440239 Doh. I missed that. Thanks; sorry for the bother. Do you want to check in the change, or should I? -- This is an automated message from the Apache Git Service. To

[GitHub] [royale-asjs] joshtynjala commented on issue #1131: Compile not catching missing states in skin MXML

2021-09-09 Thread GitBox
joshtynjala commented on issue #1131: URL: https://github.com/apache/royale-asjs/issues/1131#issuecomment-916416419 It looks like the compiler is working correctly. It's just that the `[SkinState]` metadata in `SkinnableContainerBase` is commented out:

[GitHub] [royale-asjs] estanglerbm commented on issue #1131: Compile not catching missing states in skin MXML

2021-09-08 Thread GitBox
estanglerbm commented on issue #1131: URL: https://github.com/apache/royale-asjs/issues/1131#issuecomment-915636254 The test case is from issue #995. It has `[HostComponent("spark.components.SkinnableContainer")]`. I don't know if the issue is specific to that component. -- This is

[GitHub] [royale-asjs] joshtynjala commented on issue #1131: Compile not catching missing states in skin MXML

2021-09-08 Thread GitBox
joshtynjala commented on issue #1131: URL: https://github.com/apache/royale-asjs/issues/1131#issuecomment-915403087 @estanglerbm I cannot reproduce this issue. I tried the following code, and the compiler correctly reported that the two skin states were missing: ```actionscript

[GitHub] [royale-compiler] joshtynjala commented on issue #191: Internal Error NPE thrown for try-catch declaration in mxml

2021-09-08 Thread GitBox
joshtynjala commented on issue #191: URL: https://github.com/apache/royale-compiler/issues/191#issuecomment-915387444 I can reproduce this issue. It seems to happen when a variable is declared in the `catch` block. As best I can tell, it reproduces with any type (for instance, I changed

[GitHub] [royale-asjs] brianraymes commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons

2021-09-03 Thread GitBox
brianraymes commented on pull request #1147: URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-912713695 That's a great question. Primarily, because mouseleave was not modeled in MouseEvents, and I'm more familiar with Flex's older model. I'll take a look at mouseleave and

[GitHub] [royale-asjs] Harbs commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons

2021-09-01 Thread GitBox
Harbs commented on pull request #1147: URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-910153041 Looks good! Is there a reason you used `mouseout` instead of `mouseleave`? I don't use Jewel, and I'm not sure what the structure is. Is there any chance of `mouseout`

[GitHub] [royale-asjs] brianraymes opened a new pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons

2021-08-31 Thread GitBox
brianraymes opened a new pull request #1147: URL: https://github.com/apache/royale-asjs/pull/1147 Jewel SpinnerMouseController has two bugs where auto increment/decrement timers become unstoppable if one click drags off of the buttons (click and hold, drag off button, then let go). This

[GitHub] [royale-asjs] yishayw commented on issue #1137: DataGrid is not resizable

2021-08-16 Thread GitBox
yishayw commented on issue #1137: URL: https://github.com/apache/royale-asjs/issues/1137#issuecomment-899538089 I imagine these 2 implementations will probably suffice for many real use cases. I also created a ‘divided’ branch that has an implementation borrowed from Flex, which should

[GitHub] [royale-asjs] Harbs commented on issue #1137: DataGrid is not resizable

2021-08-16 Thread GitBox
Harbs commented on issue #1137: URL: https://github.com/apache/royale-asjs/issues/1137#issuecomment-899441146 FWIW, here's an implementation in Spectrum: https://unhurdle.github.io/spectrum-royale/#!splitview

[GitHub] [royale-asjs] aharui commented on issue #1137: DataGrid is not resizable

2021-08-15 Thread GitBox
aharui commented on issue #1137: URL: https://github.com/apache/royale-asjs/issues/1137#issuecomment-899201559 Here's a rudimentary prototype: I modified DividedBox.as to override addElement so it will insert a divider element after the first child. ```

[GitHub] [royale-asjs] yishayw merged pull request #1146: Fix exception in SWF target with recent changes in ContentView.

2021-08-14 Thread GitBox
yishayw merged pull request #1146: URL: https://github.com/apache/royale-asjs/pull/1146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] estanglerbm opened a new pull request #1146: Fix exception in SWF target with recent changes in ContentView.

2021-08-13 Thread GitBox
estanglerbm opened a new pull request #1146: URL: https://github.com/apache/royale-asjs/pull/1146 Fix of PR #1134 for MX ListBase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [royale-asjs] yishayw merged pull request #1037: Initial version of Spark formatters and mx.globalization.

2021-08-08 Thread GitBox
yishayw merged pull request #1037: URL: https://github.com/apache/royale-asjs/pull/1037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] pashminakazi closed issue #1145: Chart should be resizable as in Flex

2021-08-08 Thread GitBox
pashminakazi closed issue #1145: URL: https://github.com/apache/royale-asjs/issues/1145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] pashminakazi commented on issue #1143: DataGrid have an extra space for scroller

2021-08-08 Thread GitBox
pashminakazi commented on issue #1143: URL: https://github.com/apache/royale-asjs/issues/1143#issuecomment-894763129 If DataGrid has scrollbar then it should be placed at separate column not with the last column,there should be one more column after last column where scrollbar should be

[GitHub] [royale-asjs] yishayw commented on issue #1143: DataGrid have an extra space for scroller

2021-08-08 Thread GitBox
yishayw commented on issue #1143: URL: https://github.com/apache/royale-asjs/issues/1143#issuecomment-894759846 @pashminakazi , can u please create a short test case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [royale-asjs] pashminakazi commented on issue #1143: DataGrid have an extra space for scroller

2021-08-02 Thread GitBox
pashminakazi commented on issue #1143: URL: https://github.com/apache/royale-asjs/issues/1143#issuecomment-890757518 mx:DataGrid -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [royale-asjs] estanglerbm commented on issue #1143: DataGrid have an extra space for scroller

2021-08-01 Thread GitBox
estanglerbm commented on issue #1143: URL: https://github.com/apache/royale-asjs/issues/1143#issuecomment-890729340 Is that for MX or Spark grid in Flex? I remember the Spark one not having that, but maybe I remember wrong. -- This is an automated message from the Apache Git Service.

[GitHub] [royale-asjs] yishayw commented on issue #1138: Selected Tab is not highlighted

2021-07-29 Thread GitBox
yishayw commented on issue #1138: URL: https://github.com/apache/royale-asjs/issues/1138#issuecomment-889432061 @pashminakazi , good catch. I don't know how that got there... Should be fixed now. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [royale-asjs] javeiga-iest closed issue #1132: SizeChanged Event of an element

2021-07-29 Thread GitBox
javeiga-iest closed issue #1132: URL: https://github.com/apache/royale-asjs/issues/1132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] javeiga-iest commented on issue #1132: SizeChanged Event of an element

2021-07-29 Thread GitBox
javeiga-iest commented on issue #1132: URL: https://github.com/apache/royale-asjs/issues/1132#issuecomment-889431657 Thx, worked for me @mjesteve -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [royale-asjs] yishayw closed issue #1138: Selected Tab is not highlighted

2021-07-29 Thread GitBox
yishayw closed issue #1138: URL: https://github.com/apache/royale-asjs/issues/1138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] pashminakazi commented on issue #1138: Selected Tab is not highlighted

2021-07-29 Thread GitBox
pashminakazi commented on issue #1138: URL: https://github.com/apache/royale-asjs/issues/1138#issuecomment-889420202 @yishayw I got this Error after this commit : ![image](https://user-images.githubusercontent.com/42200979/127558083-aa31de27-c9d0-4577-959a-3a3819de119b.png)

[GitHub] [royale-asjs] yishayw closed issue #1138: Selected Tab is not highlighted

2021-07-29 Thread GitBox
yishayw closed issue #1138: URL: https://github.com/apache/royale-asjs/issues/1138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] yishayw closed issue #1144: mx:NumericStepper should take negative value by typing as in Flex

2021-07-29 Thread GitBox
yishayw closed issue #1144: URL: https://github.com/apache/royale-asjs/issues/1144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] yishayw closed issue #1139: PopupWindow should be movable

2021-07-29 Thread GitBox
yishayw closed issue #1139: URL: https://github.com/apache/royale-asjs/issues/1139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] pashminakazi commented on issue #1138: Selected Tab is not highlighted

2021-07-29 Thread GitBox
pashminakazi commented on issue #1138: URL: https://github.com/apache/royale-asjs/issues/1138#issuecomment-888964998 @yishayw by default first tab is selected in TabNavigator but the color or background-color isn't changed for the first selected tab -- This is an automated message from

[GitHub] [royale-asjs] pashminakazi commented on issue #1137: DataGrid is not resizable

2021-07-29 Thread GitBox
pashminakazi commented on issue #1137: URL: https://github.com/apache/royale-asjs/issues/1137#issuecomment-888935860 @yishayw Please see video and File for better understanding File : https://paste.apache.org/uw31b Comparison between Flex and Royale :

[GitHub] [royale-asjs] pashminakazi opened a new issue #1145: Chart should be resizable as in Flex

2021-07-29 Thread GitBox
pashminakazi opened a new issue #1145: URL: https://github.com/apache/royale-asjs/issues/1145 In Flex : ![image](https://user-images.githubusercontent.com/42200979/127459541-8c97feb5-fc26-4549-a42b-2895f6f61ec6.png)

[GitHub] [royale-asjs] pashminakazi opened a new issue #1144: mx:NumericStepper should take negative value by typing as in Flex

2021-07-29 Thread GitBox
pashminakazi opened a new issue #1144: URL: https://github.com/apache/royale-asjs/issues/1144 I am unable to write negative value in mx:NumericStepper,If I write minus sign (-) in numericStepper it shows Zero, In flex we can write negative value in mx:numericStepper later it will be

[GitHub] [royale-asjs] pashminakazi opened a new issue #1143: DataGrid have an extra space for scroller

2021-07-29 Thread GitBox
pashminakazi opened a new issue #1143: URL: https://github.com/apache/royale-asjs/issues/1143 If DataGrid have scroller then that scroller should be placed after lastColumn of DataGrid not with lastColumn like in flex. there should be extra space specified for scroller In Flex :

[GitHub] [royale-asjs] mjesteve commented on issue #1132: SizeChanged Event of an element

2021-07-28 Thread GitBox
mjesteve commented on issue #1132: URL: https://github.com/apache/royale-asjs/issues/1132#issuecomment-888737944 Here is a small demo ![GIF 29-07-2021 3-53-05](https://user-images.githubusercontent.com/55754195/127419403-9855af16-fb6d-4c89-a156-41ba4a30a4b1.gif) The code here

[GitHub] [royale-asjs] mjesteve commented on issue #1132: SizeChanged Event of an element

2021-07-28 Thread GitBox
mjesteve commented on issue #1132: URL: https://github.com/apache/royale-asjs/issues/1132#issuecomment-888685178 I got it!!! : ) In the end, before getting back to debugging I thought I'd read about the resize event and I found the ResizeObserver API. The best thing is that when I

[GitHub] [royale-asjs] mjesteve commented on issue #1132: SizeChanged Event of an element

2021-07-28 Thread GitBox
mjesteve commented on issue #1132: URL: https://github.com/apache/royale-asjs/issues/1132#issuecomment-888662047 Yishayw, estanglerbm, I don't get it... neither listening to the three container events, nor with the layoutNeeded, I have put debug points in the sdk but it DOES NOT

[GitHub] [royale-asjs] yishayw closed issue #1138: Selected Tab is not highlighted

2021-07-27 Thread GitBox
yishayw closed issue #1138: URL: https://github.com/apache/royale-asjs/issues/1138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] blackjyn commented on issue #107: cess of possibly undefined property i sAttribute through a reference with static type QName.

2021-07-27 Thread GitBox
blackjyn commented on issue #107: URL: https://github.com/apache/royale-asjs/issues/107#issuecomment-887997373 I'm no longer updated my local repo since then and prefer the binary dist instead. I assume you already build latest version and the problem has gone so I'm gonna close it

[GitHub] [royale-asjs] blackjyn closed issue #107: cess of possibly undefined property i sAttribute through a reference with static type QName.

2021-07-27 Thread GitBox
blackjyn closed issue #107: URL: https://github.com/apache/royale-asjs/issues/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] yishayw closed issue #1133: ComboBoxList is moving up and down if i scroll,It should be closed if i scroll

2021-07-27 Thread GitBox
yishayw closed issue #1133: URL: https://github.com/apache/royale-asjs/issues/1133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] yishayw commented on issue #1138: Selected Tab is not highlighted

2021-07-27 Thread GitBox
yishayw commented on issue #1138: URL: https://github.com/apache/royale-asjs/issues/1138#issuecomment-887347394 Strange, I'm not seeing it. I'll look at it later today. Feel free to revert the whole commit if it's wasting your time. -- This is an automated message from the Apache Git

[GitHub] [royale-asjs] pashminakazi commented on issue #1138: Selected Tab is not highlighted

2021-07-27 Thread GitBox
pashminakazi commented on issue #1138: URL: https://github.com/apache/royale-asjs/issues/1138#issuecomment-887346037 When I revert these 3 lines from MXRoyale's default.css IItemRendererClassFactory: ClassReference("org.apache.royale.core.OverridableSelectableItemRendererClassFactory");

[GitHub] [royale-asjs] pashminakazi commented on issue #1138: Selected Tab is not highlighted

2021-07-27 Thread GitBox
pashminakazi commented on issue #1138: URL: https://github.com/apache/royale-asjs/issues/1138#issuecomment-887345229 Yes,Basic Core and MXRoyale -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [royale-asjs] yishayw commented on issue #1138: Selected Tab is not highlighted

2021-07-27 Thread GitBox
yishayw commented on issue #1138: URL: https://github.com/apache/royale-asjs/issues/1138#issuecomment-887341077 Did you build basic as well as MX? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [royale-asjs] pashminakazi commented on issue #1138: Selected Tab is not highlighted

2021-07-27 Thread GitBox
pashminakazi commented on issue #1138: URL: https://github.com/apache/royale-asjs/issues/1138#issuecomment-887332010 After this change my application doesn't work when i launch application this exception occurs :

[GitHub] [royale-asjs] estanglerbm commented on issue #107: cess of possibly undefined property i sAttribute through a reference with static type QName.

2021-07-27 Thread GitBox
estanglerbm commented on issue #107: URL: https://github.com/apache/royale-asjs/issues/107#issuecomment-887244074 @blackjyn Well, if you build ``develop`` right now, there are no compile errors in XML. Doesn't that prove it? -- This is an automated message from the Apache Git Service.

[GitHub] [royale-asjs] blackjyn commented on issue #107: cess of possibly undefined property i sAttribute through a reference with static type QName.

2021-07-26 Thread GitBox
blackjyn commented on issue #107: URL: https://github.com/apache/royale-asjs/issues/107#issuecomment-886719315 @estanglerbm this is very old thread , I don't even remember the specific version I cloned. Did you have valid proof that this is no longer happening? If so, just mention

[GitHub] [royale-asjs] yishayw commented on issue #1137: DataGrid is not resizable

2021-07-26 Thread GitBox
yishayw commented on issue #1137: URL: https://github.com/apache/royale-asjs/issues/1137#issuecomment-886599587 @pashminakazi I'm not sure what the issue is here. Do you need DividedBox to be implemented? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [royale-asjs] yishayw commented on issue #1141: spark Panel not being recognized as an ILayoutParent

2021-07-26 Thread GitBox
yishayw commented on issue #1141: URL: https://github.com/apache/royale-asjs/issues/1141#issuecomment-886453644 This was an issue in my local environment. Sorry for the noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [royale-asjs] yishayw closed issue #1141: spark Panel not being recognized as an ILayoutParent

2021-07-26 Thread GitBox
yishayw closed issue #1141: URL: https://github.com/apache/royale-asjs/issues/1141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] yishayw commented on issue #1141: spark Panel not being recognized as an ILayoutParent

2021-07-26 Thread GitBox
yishayw commented on issue #1141: URL: https://github.com/apache/royale-asjs/issues/1141#issuecomment-886407065 @estanglerbm PR #1135 looks great, but I don't have time to review it right now. The host is a spark panel. For now (as I need to move on to other bugs) I think I'll explicitly

[GitHub] [royale-asjs] estanglerbm opened a new issue #1142: Exception in PanelSkin on SWF target

2021-07-25 Thread GitBox
estanglerbm opened a new issue #1142: URL: https://github.com/apache/royale-asjs/issues/1142 In a test case like #1140, run in fdb on SWF target, you get this exception when instantiating PanelSkin (on the way out of the constructor): ``` [Fault] exception,

[GitHub] [royale-asjs] estanglerbm commented on issue #1140: Background should be blur when popup window opens

2021-07-25 Thread GitBox
estanglerbm commented on issue #1140: URL: https://github.com/apache/royale-asjs/issues/1140#issuecomment-886292845 I'm not getting any exception with ``develop`` + PR #1135 when I click on the button. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [royale-asjs] estanglerbm commented on issue #1141: spark Panel not being recognized as an ILayoutParent

2021-07-25 Thread GitBox
estanglerbm commented on issue #1141: URL: https://github.com/apache/royale-asjs/issues/1141#issuecomment-886292814 The exception (assuming all source is up-to-date) was caught by my change in PR #1129 that was done to catch things like this on purpose. The question is, what is the

[GitHub] [royale-asjs] pashminakazi commented on issue #1141: spark Panel not being recognized as an ILayoutParent

2021-07-25 Thread GitBox
pashminakazi commented on issue #1141: URL: https://github.com/apache/royale-asjs/issues/1141#issuecomment-886247392 That's another issue I only need blur background nothing else -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [royale-asjs] yishayw commented on issue #1141: spark Panel not being recognized as an ILayoutParent

2021-07-25 Thread GitBox
yishayw commented on issue #1141: URL: https://github.com/apache/royale-asjs/issues/1141#issuecomment-886245009 That's surprising because Panel.as extends SkinnableContainer and public class SkinnableContainer extends SkinnableContainerBase implements IContainer,

[GitHub] [royale-asjs] yishayw opened a new issue #1141: spark Panel not being recognized as an ILayoutParent

2021-07-25 Thread GitBox
yishayw opened a new issue #1141: URL: https://github.com/apache/royale-asjs/issues/1141 I'm seeing this stack trace when clicking on the OpenButton. LayoutBase.js:241 Uncaught TypeError: Cannot read property 'getLayoutHost' of null at

[GitHub] [royale-asjs] yishayw commented on issue #1140: Background should be blur when popup window opens

2021-07-25 Thread GitBox
yishayw commented on issue #1140: URL: https://github.com/apache/royale-asjs/issues/1140#issuecomment-886236424 I'm seeing this stack trace when clicking on the OpenButton. LayoutBase.js:241 Uncaught TypeError: Cannot read property 'getLayoutHost' of null at

[GitHub] [royale-asjs] yishayw closed issue #1140: Background should be blur when popup window opens

2021-07-25 Thread GitBox
yishayw closed issue #1140: URL: https://github.com/apache/royale-asjs/issues/1140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] estanglerbm commented on issue #107: cess of possibly undefined property i sAttribute through a reference with static type QName.

2021-07-25 Thread GitBox
estanglerbm commented on issue #107: URL: https://github.com/apache/royale-asjs/issues/107#issuecomment-886190887 No error like this when building XML, now. Maybe this can be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [royale-asjs] pashminakazi commented on issue #1133: ComboBoxList is moving up and down if i scroll,It should be closed if i scroll

2021-07-25 Thread GitBox
pashminakazi commented on issue #1133: URL: https://github.com/apache/royale-asjs/issues/1133#issuecomment-886189551 @yishayw Thank u so much after fixing this issue another issue occurs, If we scroll any other scroller with touchpad then the comboBoxList should be closed,not when

[GitHub] [royale-asjs] estanglerbm commented on issue #937: Skin Not Being Sized Correctly

2021-07-25 Thread GitBox
estanglerbm commented on issue #937: URL: https://github.com/apache/royale-asjs/issues/937#issuecomment-886187243 This seems to be fixed, at least with PR #1135 and other previous PRs (don't know which one fixed it; probably commit d195814211ad3ada0f00be42cce0491419f8d032). PR #1135 is

[GitHub] [royale-asjs] estanglerbm commented on issue #994: Height 100% - Child Resize Inconsistent Behavior

2021-07-25 Thread GitBox
estanglerbm commented on issue #994: URL: https://github.com/apache/royale-asjs/issues/994#issuecomment-886186323 This seems to be fixed, at least with PR #1135 and other previous PRs (don't know which one fixed it; I guess ChildResize branch did). This shows a blue square 200x200, and

[GitHub] [royale-asjs] estanglerbm commented on issue #1001: Problem using element.addEventListener

2021-07-25 Thread GitBox
estanglerbm commented on issue #1001: URL: https://github.com/apache/royale-asjs/issues/1001#issuecomment-886185430 @raudjcholo Can this be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [royale-asjs] estanglerbm commented on issue #1019: Spark - padding causes an offset in SkinnableContainer (Group is OK)

2021-07-25 Thread GitBox
estanglerbm commented on issue #1019: URL: https://github.com/apache/royale-asjs/issues/1019#issuecomment-886185137 This seems to be fixed, at least with PR #1135 and other previous PRs (don't know which one fixed it). It shows a green border (20px) and an eye-destroying filled bright

[GitHub] [royale-asjs] estanglerbm commented on issue #1021: Emulation - Setting percentHeight prevents layout from happening on resize

2021-07-25 Thread GitBox
estanglerbm commented on issue #1021: URL: https://github.com/apache/royale-asjs/issues/1021#issuecomment-886183387 Should this issue be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [royale-asjs] estanglerbm edited a comment on pull request #1037: Initial version of Spark formatters and mx.globalization.

2021-07-25 Thread GitBox
estanglerbm edited a comment on pull request #1037: URL: https://github.com/apache/royale-asjs/pull/1037#issuecomment-886181711 Tested by running (and reviewing output of): ``` cd royale-asjs\frameworks\projects\MXRoyale\src\main\royale asdoc -source-path .

<    1   2   3   4   5   6   7   8   9   10   >