Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/944#issuecomment-199620219
@eminency Hi! Thanks for your comment. I apply your comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r56449935
--- Diff:
tajo-core-tests/src/test/java/org/apache/tajo/client/TestTajoClient.java ---
@@ -175,10 +176,8 @@ public final void testSessionVariables() throws
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r56449210
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java
---
@@ -644,30 +631,22 @@ protected void
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r56448985
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java
---
@@ -602,18 +597,10 @@ protected void
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r56448401
--- Diff:
tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java ---
@@ -471,10 +469,7 @@ public Object clone() throws
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r56449510
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/XMLCatalogSchemaManager.java
---
@@ -675,40 +654,38 @@ protected void
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r56448372
--- Diff:
tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java ---
@@ -418,10 +419,7 @@ public Object clone() throws
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r56452167
--- Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Query.java ---
@@ -303,12 +304,7 @@ public QueryHistory getQueryHistory() {
}
Github user eminency commented on the pull request:
https://github.com/apache/tajo/pull/944#issuecomment-197701836
Even though they may not exact, I left some comments.
Please check them out.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r56451584
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/query/TaskRequestImpl.java ---
@@ -216,49 +217,42 @@ public Enforcer getEnforcer() {
return
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/944#issuecomment-194617140
@eminency Thanks for your comment. Unfortunately, I face with some
unsuspected error while travis test. I'm in investigation about it's cause.
---
If your project is
Github user eminency commented on the pull request:
https://github.com/apache/tajo/pull/944#issuecomment-194070707
Time to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dkhwangbo commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r50226906
--- Diff:
tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java ---
@@ -419,9 +420,7 @@ public Object clone() throws CloneNotSupportedException
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r50217032
--- Diff:
tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java ---
@@ -419,9 +420,7 @@ public Object clone() throws CloneNotSupportedException
GitHub user dkhwangbo opened a pull request:
https://github.com/apache/tajo/pull/944
TAJO-2058: foreach loop can be collapsed with stream api
I replace many foreach loop with stream api.
You can merge this pull request into a Git repository by running:
$ git pull
15 matches
Mail list logo
