abstractdog merged PR #341:
URL: https://github.com/apache/tez/pull/341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
abstractdog commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2032248345
tests passed green
considering @ayushtkn 's LGTM an approval, will merge this soon in case of
no further objections
--
This is an automated message from the Apache Git Service.
To
tez-yetus commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2032236638
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 26m 35s | Docker mode
tez-yetus commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2032069693
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 9s | Docker mode
tez-yetus commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2032062863
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 10s | Docker mode
abstractdog commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2032030599
> > I cannot address [HiddenField], I consider it as noise now
>
> @abstractdog that HiddenField should be fixable, it is telling you have
localFs already defined above & you are
abstractdog commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2032027449
> **+1 overall**
>
> Vote Subsystem Runtime Comment
> +0 reexec 0m 9s Docker mode activated.
> _ Prechecks _
> +1 dupname 0m 0s No
ayushtkn commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2031990575
> I cannot address [HiddenField], I consider it as noise now
@abstractdog that HiddenField should be fixable, it is telling you have
localFs already defined above & you are redefining
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547310433
##
tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRInputHelpers.java:
##
@@ -889,4 +895,29 @@ public static int getDagAttemptNumber(Configuration conf) {
abstractdog commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2031972279
> Thanx @abstractdog for the update. There are some checkstyle warnings can
you take care of them, rest things LGTM
thanks!
I addressed what I could have (renaming some fields), I
tez-yetus commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2031463310
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 9s | Docker mode
abstractdog commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2031381165
thanks for the comments @ayushtkn, addressed them in
https://github.com/apache/tez/pull/341/commits/564949466ddbd95b00f4314e373ebcf4277ae9e2
--
This is an automated message from the
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547385546
##
tez-runtime-internals/src/main/java/org/apache/tez/common/ProtoConverters.java:
##
@@ -135,15 +138,22 @@ public static VertexManagerEvent
ayushtkn commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547372195
##
tez-runtime-internals/src/main/java/org/apache/tez/common/ProtoConverters.java:
##
@@ -135,15 +138,22 @@ public static VertexManagerEvent
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547357268
##
tez-mapreduce/src/test/java/org/apache/tez/mapreduce/hadoop/TestMRInputHelpers.java:
##
@@ -56,9 +62,12 @@ public class TestMRInputHelpers {
private static Path
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547349710
##
tez-runtime-internals/src/main/java/org/apache/tez/common/ProtoConverters.java:
##
@@ -135,15 +138,22 @@ public static VertexManagerEvent
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547346163
##
tez-mapreduce/src/test/java/org/apache/tez/mapreduce/hadoop/TestMRInputHelpers.java:
##
@@ -232,30 +278,32 @@ private DataSourceDescriptor
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547322934
##
tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRInputHelpers.java:
##
@@ -889,4 +895,29 @@ public static int getDagAttemptNumber(Configuration conf) {
aturoczy commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547311523
##
tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRInputHelpers.java:
##
@@ -889,4 +895,29 @@ public static int getDagAttemptNumber(Configuration conf) {
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547310433
##
tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRInputHelpers.java:
##
@@ -889,4 +895,29 @@ public static int getDagAttemptNumber(Configuration conf) {
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547308955
##
tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRInputHelpers.java:
##
@@ -889,4 +895,29 @@ public static int getDagAttemptNumber(Configuration conf) {
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547308574
##
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##
@@ -103,6 +113,7 @@ public Object getDeserializedUserPayload() {
public
ayushtkn commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547274765
##
tez-mapreduce/src/test/java/org/apache/tez/mapreduce/hadoop/TestMRInputHelpers.java:
##
@@ -56,9 +62,12 @@ public class TestMRInputHelpers {
private static Path
aturoczy commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547289396
##
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##
@@ -79,6 +79,12 @@ public static InputDataInformationEvent
tez-yetus commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2031214469
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s | Docker mode
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1546922261
##
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##
@@ -79,6 +79,12 @@ public static InputDataInformationEvent
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1547193756
##
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##
@@ -103,6 +113,7 @@ public Object getDeserializedUserPayload() {
public
tez-yetus commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2030729876
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 9s | Docker mode
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1546922261
##
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##
@@ -79,6 +79,12 @@ public static InputDataInformationEvent
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1546922261
##
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##
@@ -79,6 +79,12 @@ public static InputDataInformationEvent
aturoczy commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1546922508
##
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##
@@ -103,6 +113,7 @@ public Object getDeserializedUserPayload() {
public
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1546922261
##
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##
@@ -79,6 +79,12 @@ public static InputDataInformationEvent
abstractdog commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1546918816
##
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##
@@ -103,6 +113,7 @@ public Object getDeserializedUserPayload() {
public
aturoczy commented on code in PR #341:
URL: https://github.com/apache/tez/pull/341#discussion_r1546906996
##
tez-api/src/main/java/org/apache/tez/runtime/api/events/InputDataInformationEvent.java:
##
@@ -103,6 +113,7 @@ public Object getDeserializedUserPayload() {
public
tez-yetus commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-202531
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 9s | Docker mode
tez-yetus commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2028212983
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 9s | Docker mode
abstractdog commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2028036146
@ayushtkn : can you please take a look at this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
tez-yetus commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2028026524
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 8s | Docker mode
tez-yetus commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2028026525
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 9s | Docker mode
tez-yetus commented on PR #341:
URL: https://github.com/apache/tez/pull/341#issuecomment-2027990447
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 12m 14s | Docker mode
abstractdog opened a new pull request, #341:
URL: https://github.com/apache/tez/pull/341
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
41 matches
Mail list logo
