[GitHub] [trafficcontrol] ocket8888 commented on pull request #7099: Delivery Service Active Flag Rework
ocket commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1291257249 This PR depends on #7156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005068529 ## traffic_ops/app/db/migrations/2022092107561215_ds_explicit_mso.down.sql: ## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ + +ALTER TABLE public.deliveryservice Review Comment: Those changes don't need to be reverted. Before the change, `multiSiteOrigin` can be one of three values: `true`, `false`, or `null`. The `up` file changes all `null` values to `false` (because `null` and `false` are treated exactly the same, so there was no reason to allow both). The `up` file needed to do that because after it runs, `null` will no longer be allowed. But after `down` runs, `false` is still allowed - and also it's treated the same as `null` so there's no behavioral impact, and finally you also can't know which `false`s used to be `null`s and which were `false` in the first place, so the information needed to restore that state doesn't exist anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework
ocket commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005066584
##
traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go:
##
@@ -1023,6 +1027,7 @@ func scanDSInfoRow(row *sql.Row) (DSInfo, bool, error) {
}
return DSInfo{}, false, fmt.Errorf("querying delivery service
server ds info: %v", err)
}
+ di.Active = active == tc.DSActiveStateActive
Review Comment:
A boolean is not being assigned to a string. A boolean is being assigned to
the outcome of comparing two strings. A Delivery Service where `"active": true`
in the old data model is equivalent to `"active": "ACTIVE"` in the new data
model. So if `active` is exactly `tc.DSActiveStateActive`, then `di.Active`
should be `true`. If it's anything else, `di.Active` should be false. Which is
what this line does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005065463 ## traffic_ops/testing/api/v4/tc-fixtures.json: ## @@ -907,7 +907,7 @@ "regexRemap": null, "regionalGeoBlocking": false, "remapText": null, -"routingName": "cdn", +"routingName": "ccr-ds1", Review Comment: That value is not invalid, what it was set to *before* was actually hiding an error. Changing this was part of the fix for #7094. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework
ocket commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005063876
##
traffic_ops/testing/api/v5/deliveryservice_request_comments_test.go:
##
@@ -178,7 +178,9 @@ func CreateTestDeliveryServiceRequestComments(t *testing.T)
{
opts.QueryParameters.Set("xmlId", comment.XMLID)
resp, _, err := TOSession.GetDeliveryServiceRequests(opts)
assert.NoError(t, err, "Cannot get Delivery Service Request by
XMLID '%s': %v - alerts: %+v", comment.XMLID, err, resp.Alerts)
- assert.Equal(t, len(resp.Response), 1, "Found %d Delivery
Service request by XMLID '%s, expected exactly one", len(resp.Response),
comment.XMLID)
+ if !assert.Equal(t, len(resp.Response), 1, "Found %d Delivery
Service request by XMLID '%s, expected exactly one", len(resp.Response),
comment.XMLID) {
Review Comment:
Because although creation of the currently processed comment has failed (or
at best succeeded wrongly), other comments can still be created, which can help
narrow down what the problem was and/or find other problems by continuing to
run other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework
ocket commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005062709
##
traffic_ops/v5-client/deliveryservice_requests.go:
##
@@ -58,31 +58,31 @@ func (to *Session) CreateDeliveryServiceRequest(dsr
tc.DeliveryServiceRequestV4,
dsr.AuthorID = res.Response[0].ID
}
- var ds *tc.DeliveryServiceV4
+ var ds *tc.DeliveryServiceV5
if dsr.ChangeType == tc.DSRChangeTypeDelete {
ds = dsr.Original
} else {
ds = dsr.Requested
}
- if ds.TypeID == nil && ds.Type.String() != "" {
+ if ds.TypeID <= 0 && ds.Type != nil && *ds.Type != "" {
Review Comment:
The Type is known to humans by its name, so this block was meant to populate
the ID if it wasn't given by using the Type's Name (if that *is* given,
otherwise it's an error). Because `ds.Type` is a pointer, it can be `nil`, so
its value must not be accessed in that case, or a bad error response will be
returned to the user. You also can't look up a Type with a blank Name, because
Type Names can't be blank. The old code called `.String()`, which would
segfault if the `ds.Type` reference was `nil`, so I added the `nil` check to
avoid that. `TypeID` is no longer a pointer, so instead of `nil` I checked for
the "zero" value of the property's datatype (and also invalid values i.e.
negative ones).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework
ocket commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005059975
##
traffic_ops/testing/api/v5/deliveryservices_keys_test.go:
##
@@ -67,30 +67,29 @@ func createBlankCDN(cdnName string, t *testing.T) tc.CDN {
return cdns.Response[0]
}
-func cleanUp(t *testing.T, ds tc.DeliveryServiceV4, oldCDNID int, newCDNID
int, sslKeyVersions []string) {
- if ds.ID == nil || ds.XMLID == nil {
Review Comment:
Because XMLID can no longer be `nil`. If that check was still there, the
tests wouldn't compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework
ocket commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005057765
##
traffic_ops/traffic_ops_golang/deliveryservice/safe.go:
##
@@ -144,19 +141,28 @@ func UpdateSafe(w http.ResponseWriter, r *http.Request) {
switch inf.Version.Major {
default:
fallthrough
+ case 5:
+ api.WriteRespAlertObj(w, r, tc.SuccessLevel, alertMsg,
ds)
case 4:
- api.WriteRespAlertObj(w, r, tc.SuccessLevel, alertMsg,
dses)
+ api.WriteRespAlertObj(w, r, tc.SuccessLevel, alertMsg,
[]tc.DeliveryServiceV4{ds.Downgrade()})
case 3:
+ legacyDS := ds.Downgrade()
+ legacyDS.LongDesc1 = dses[0].LongDesc1
+ legacyDS.LongDesc2 = dses[0].LongDesc2
+ ret := legacyDS.DowngradeToV31()
if inf.Version.Minor >= 1 {
- api.WriteRespAlertObj(w, r, tc.SuccessLevel,
alertMsg, []tc.DeliveryServiceV31{tc.DeliveryServiceV31(ds.DowngradeToV31())})
+ api.WriteRespAlertObj(w, r, tc.SuccessLevel,
alertMsg, []tc.DeliveryServiceV31{tc.DeliveryServiceV31(ret)})
}
- api.WriteRespAlertObj(w, r, tc.SuccessLevel, alertMsg,
[]tc.DeliveryServiceV30{ds.DowngradeToV31().DeliveryServiceV30})
+ api.WriteRespAlertObj(w, r, tc.SuccessLevel, alertMsg,
[]tc.DeliveryServiceV30{ret.DeliveryServiceV30})
case 2:
Review Comment:
Yes, though when I first made these changes we had not, yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework
ocket commented on code in PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1005057324
##
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go:
##
@@ -138,7 +162,7 @@ func CreateV30(w http.ResponseWriter, r *http.Request) {
ds := tc.DeliveryServiceV30{}
if err := json.NewDecoder(r.Body).Decode(); err != nil {
- api.HandleErr(w, r, inf.Tx.Tx, http.StatusBadRequest,
errors.New("decoding: "+err.Error()), nil)
+ api.HandleErr(w, r, inf.Tx.Tx, http.StatusBadRequest,
fmt.Errorf("decoding: %w", err), nil)
Review Comment:
> Why the change?
Because it preserves the identity of the underlying error that way. Here's
[a playground link to an example program that shows what that
means](https://go.dev/play/p/GOkCOgci1lh). It accomplishes the same thing as
`errors.New(someString+err.Error())` but without destroying any information.
> ...shouldn't we refactor others in the code base too?
In my opinion, yes, and I always request people do it this way in my
reviews. I only changed it in the files I was already editing, though, because
this is done untold thousands of times throughout ATC. Nobody would ever review
that PR. So I just make smaller changes to files as I work on them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7156: Fix APIv4.0 returning APIv4.1 DS structures
ocket commented on code in PR #7156:
URL: https://github.com/apache/trafficcontrol/pull/7156#discussion_r1005050496
##
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go:
##
@@ -614,7 +614,7 @@ func (ds *TODeliveryService) Read(h http.Header, useIMS
bool) ([]interface{}, er
for _, ds := range dses {
switch {
// NOTE: it's required to handle minor version cases in a
descending >= manner
- case version.Major >= 4 && version.Minor >= 1:
+ case version.Major > 4 || (version.Major == 4 && version.Minor
>= 1):
Review Comment:
Noted; though I don't want to mess with that any more; I need to rebase the
DS Active flag changes every time it changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 closed issue #7158: Traffic Vault: Reencrypt utility wipes different SSL Keys during update
ocket closed issue #7158: Traffic Vault: Reencrypt utility wipes different SSL Keys during update URL: https://github.com/apache/trafficcontrol/issues/7158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #7159: Traffic Vault: Fix `reencrypt` utility to uniquely reencrypt ssl keys
ocket merged PR #7159: URL: https://github.com/apache/trafficcontrol/pull/7159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #7152: Use Generics in TO API v3 Integration Tests
zrhoffman merged PR #7152: URL: https://github.com/apache/trafficcontrol/pull/7152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7156: Fix APIv4.0 returning APIv4.1 DS structures
zrhoffman commented on code in PR #7156:
URL: https://github.com/apache/trafficcontrol/pull/7156#discussion_r1004982343
##
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go:
##
@@ -614,7 +614,7 @@ func (ds *TODeliveryService) Read(h http.Header, useIMS
bool) ([]interface{}, er
for _, ds := range dses {
switch {
// NOTE: it's required to handle minor version cases in a
descending >= manner
- case version.Major >= 4 && version.Minor >= 1:
+ case version.Major > 4 || (version.Major == 4 && version.Minor
>= 1):
Review Comment:
This is fine, though `Version.GreaterThanOrEqualTo()` can be used now, too
https://github.com/apache/trafficcontrol/blob/6c532922e706481cb944820b8fa6af20cc3d11ee/traffic_ops/traffic_ops_golang/cdn/cdns.go#L67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [trafficcontrol] TaylorCFrey opened a new pull request, #7159: Traffic Vault: Fix `reencrypt` utility to uniquely reencrypt ssl keys
TaylorCFrey opened a new pull request, #7159: URL: https://github.com/apache/trafficcontrol/pull/7159 Closes: #7158 A Traffic Vault utility called `reencrypt` allows for the ability to take previously encrypted values in the Traffic Vault DB and apply a new AES key for encryption. However, there was a bug that resulted in the "last" ssl key (misnomer) pulled from the DB during encryption would overwrite and wipe all other versions of ssl keys. This PR addresses said bug. ## Which Traffic Control components are affected by this PR? - Traffic Vault (techinically a support utility call `reencrypt`) ## What is the best way to verify this PR? Previously existing "tests" should continue to work. Manually verify: Obtain a dump of an existing DB with the AES key that was initially used to encrypt the data. Create a new AES key. Restore the DB into a test/verification DB location. Run the `reencrypt` utility with the necessary connection info specified in the `reencrypt.conf` file, along with passing in the file path locations for the previous AES key as well as the new AES key. Observe that the _data_ column in the _sslkey_ table has been reencrypted AND unique values exist for each version under a particular Delivery Service. ## If this is a bugfix, which Traffic Control versions contained the bug? ## PR submission checklist - [ ] This PR has tests - [ ] This PR has documentation - [x] This PR has a CHANGELOG.md entry - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] TaylorCFrey opened a new issue, #7158: Traffic Vault: Reencrypt utility wipes different SSL Keys during update
TaylorCFrey opened a new issue, #7158: URL: https://github.com/apache/trafficcontrol/issues/7158 ## This Bug Report affects these Traffic Control components: - Traffic Vault ## Current behavior: When running the `reencrypt` utility located at `trafficcontrol/traffic_ops/app/db/reencrypt/reencrypt.go` for SSL Keys (misnomer) all versions of the SSL Keys entries are replaced by a single entry multiple times. As an example, if a delivery service has multiple "versions" of SSL Key data information, all of them are reencrypted into a single data blob for every version. Before running `reencrypt`: DeliveryServiceXMLId | Version | Data ---|---|--- sampleDS1 | latest | \xa0f3d800... sampleDS1 | 2| \x93c7b213... sampleDS1 | 1| \x7418e801... sampleDS2 | latest | \x48b1c9ff... sampleDS2 | 3 | \x88b7a3dd... sampleDS2 | 2 | \x1967c3b9... sampleDS2 | 1 | \x19f3a2bb... After running `reencrypt` (notice the data columns have the same value for each DS, regardless of the version): DeliveryServiceXMLId | Version | Data ---|---|--- sampleDS1 | latest | \xc4f1a823... sampleDS1 | 2| \xc4f1a823... sampleDS1 | 1| \xc4f1a823... sampleDS2 | latest | \xaa45b8f1... sampleDS2 | 3 | \xaa45b8f1... sampleDS2 | 2 | \xaa45b8f1... sampleDS2 | 1 | \xaa45b8f1... ## Expected behavior: Each row should be uniquely decrypted and reencrypted resulting in a different correctly encrypted _data_ for each delivery service ssl key version. ## Steps to reproduce: Execute the `reencrypt` utility on a Traffic Vault dump with a delivery service that has 3 or more entries (2 or more versions plus 'latest') for SSL Keys. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #7155: t3c: initial mustache for remap.config templating
ocket commented on PR #7155: URL: https://github.com/apache/trafficcontrol/pull/7155#issuecomment-1291092430 Why did you decide on this library? The one linked to on [the mustache website](https://mustache.github.io) is [cbroclie/mustache](https://github.com/cbroglie/mustache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #7157: Fix TP DSR edit page not rendering
zrhoffman merged PR #7157: URL: https://github.com/apache/trafficcontrol/pull/7157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7156: Fix APIv4.0 returning APIv4.1 DS structures
zrhoffman commented on code in PR #7156:
URL: https://github.com/apache/trafficcontrol/pull/7156#discussion_r1004876267
##
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go:
##
@@ -572,8 +614,10 @@ func (ds *TODeliveryService) Read(h http.Header, useIMS
bool) ([]interface{}, er
for _, ds := range dses {
switch {
// NOTE: it's required to handle minor version cases in a
descending >= manner
- case version.Major > 3:
+ case version.Major >= 4 && version.Minor >= 1:
returnable = append(returnable, ds.RemoveLD1AndLD2())
+ case version.Major >= 4:
+ returnable = append(returnable,
ds.DeliveryServiceV40.RemoveLD1AndLD2())
Review Comment:
The API 4.0 case matched for API 5.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7157: Fix TP DSR edit page not rendering
ocket opened a new pull request, #7157: URL: https://github.com/apache/trafficcontrol/pull/7157 Fixes a bug introduced in #7075 that prevented Delivery Service Request edit pages from rendering. ## Which Traffic Control components are affected by this PR? - Traffic Portal ## What is the best way to verify this PR? Make sure the page renders. ## If this is a bugfix, which Traffic Control versions contained the bug? - master ## PR submission checklist - [x] This PR uses existing tests - [x] This PR needs no documentation - [x] This PR needs no CHANGELOG.md entry - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7156: Fix APIv4.0 returning APIv4.1 DS structures
ocket opened a new pull request, #7156: URL: https://github.com/apache/trafficcontrol/pull/7156 This PR fixes a bug introduced by #7111 where APIv4.0 responses containing representations of Delivery Services used the representation from APIv4.1. ## Which Traffic Control components are affected by this PR? - Traffic Ops ## What is the best way to verify this PR? Make sure all the tests still pass, request Delivery Services at APIv4.0 and observe no `regional` property, then again at APIv4.1 and observe that it now *does* have the v4.1 `regional` property. ## If this is a bugfix, which Traffic Control versions contained the bug? - master ## PR submission checklist - [x] This PR utilizes existing tests - [x] This PR needs no documentation because the bug was never released and documentation matches the intended behavior, not the bugged behavior - [x] This PR needs no CHANGELOG.md entry because the bug was never released - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] smalenfant commented on issue #7081: Traffic Router logs `SocketTimeoutException` for port 53 TCP health checks
smalenfant commented on issue #7081: URL: https://github.com/apache/trafficcontrol/issues/7081#issuecomment-1290868215 I used to turn those messages off in the past when that was a problem. I'm glad there is some resolution to this. ``` log4j.logger.com.comcast.cdn.traffic_control.traffic_router.core.dns.protocol.TCP=off ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [trafficcontrol] traeak opened a new pull request, #7155: t3c: initial mustache for remap.config templating
traeak opened a new pull request, #7155:
URL: https://github.com/apache/trafficcontrol/pull/7155
This allows remap.config to be modified by specifying a DS parameter with a
different template.
Template uses a golang mustache library.
const DefaultEdgeRemapConfigTemplate = `map {{source}} {{destination}}
{{strategy}} {{dscp}} {{header_rewrite}} {{drop_qstring}} {{signing}}
{{regex_remap}} {{cachekey}} {{range_requests}} {{maxmind}} {{pacing}}
{{raw_text}}`
## Which Traffic Control components are affected by this PR?
- Documentation
- Traffic Control Cache Config (`t3c`, formerly ORT)
- Traffic Control Health Client (tc-health-client)
- Traffic Control Client
- Traffic Monitor
- Traffic Ops
- Traffic Portal
- Traffic Router
- Traffic Stats
- Grove
- CDN in a Box
- Automation
- unknown
## What is the best way to verify this PR?
## If this is a bugfix, which Traffic Control versions contained the bug?
## PR submission checklist
- [x] This PR has tests
- [x] This PR has documentation
- [x] This PR has a CHANGELOG.md entry
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the
Apache Software Foundation's security guidelines](https://apache.org/security)
for details)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
