rawlinp opened a new pull request, #7124:
URL: https://github.com/apache/trafficcontrol/pull/7124
Instead of querying all profile parameters with the config file
"CRConfig.json" for any servers of any type that belong to a given CDN, query
only profile params assigned to profiles of
rawlinp opened a new pull request, #7123:
URL: https://github.com/apache/trafficcontrol/pull/7123
Fixes #6670.
## Which Traffic Control components are affected by this PR?
- Documentation
## What is the best way to verify this PR?
Build and
rawlinp opened a new pull request, #7122:
URL: https://github.com/apache/trafficcontrol/pull/7122
This does not actually change the behavior in any way -- it just simplifies
the logic by removing a hard-coded boolean parameter.
## Which Traffic Control components
ocket commented on code in PR #7079:
URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r992828648
##
traffic_ops/traffic_ops_golang/server/servers_server_capability.go:
##
@@ -453,77 +443,178 @@ func AssignMultipleServerCapabilities(w
http.ResponseWriter,
ocket closed issue #6021: TP: click on change log entry to view in its
entirety
URL: https://github.com/apache/trafficcontrol/issues/6021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ocket merged PR #7087:
URL: https://github.com/apache/trafficcontrol/pull/7087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ocket merged PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ocket merged PR #7104:
URL: https://github.com/apache/trafficcontrol/pull/7104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ocket commented on code in PR #7104:
URL: https://github.com/apache/trafficcontrol/pull/7104#discussion_r992811269
##
traffic_portal/app/src/common/modules/table/serviceCategoryDeliveryServices/table.serviceCategoryDeliveryServices.tpl.html:
##
@@ -26,7 +26,6 @@
ocket commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r992808824
##
traffic_portal/test/integration/CommonUtils/API.ts:
##
@@ -296,7 +296,7 @@ export class API {
const rand = () =>
ocket opened a new pull request, #7121:
URL: https://github.com/apache/trafficcontrol/pull/7121
Implements changes to TP tables to hide potentially sensitive fields behind
a checkbox setting. To make things easier, I also eliminated a few tables that
could be reproduced as filters on
zrhoffman commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r992745127
##
traffic_portal/test/integration/CommonUtils/API.ts:
##
@@ -296,7 +296,7 @@ export class API {
const rand = () =>
ocket commented on code in PR #7068:
URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r992738599
##
traffic_ops/app/db/migrations/2022100610190300_update_rascal_to_traffic_monitor.up.sql:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software
ocket commented on code in PR #7045:
URL: https://github.com/apache/trafficcontrol/pull/7045#discussion_r992733727
##
.github/actions/repo-info/action.yml:
##
@@ -25,7 +25,7 @@ inputs:
description: 'The owners github repository ie, "trafficcontrol"'
required: true
ocket merged PR #7115:
URL: https://github.com/apache/trafficcontrol/pull/7115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ocket commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r992729491
##
traffic_portal/test/integration/CommonUtils/API.ts:
##
@@ -296,7 +296,7 @@ export class API {
const rand = () =>
rimashah25 commented on code in PR #7068:
URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r992730551
##
traffic_ops/app/db/migrations/2022100610190300_update_rascal_to_traffic_monitor.up.sql:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software
ocket commented on code in PR #7050:
URL: https://github.com/apache/trafficcontrol/pull/7050#discussion_r992726936
##
infrastructure/ansible/roles/traffic_stats/templates/traffic_stats.cfg.j2:
##
@@ -15,6 +15,7 @@
"toUser": "{{ ts_toUser }}",
"toPasswd":
ocket commented on code in PR #7118:
URL: https://github.com/apache/trafficcontrol/pull/7118#discussion_r992723542
##
traffic_ops/traffic_ops_golang/deliveryservice/keys_test.go:
##
@@ -2260,6 +2261,7 @@ func TestVerifyAndEncodeCertificateSelfSignedX509v1(t
*testing.T) {
ocket commented on code in PR #7079:
URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r987141091
##
docs/source/glossary.rst:
##
@@ -414,6 +414,10 @@ Glossary
.. seealso:: For a more complete description of Roles, see the
:ref:`roles`
ocket commented on code in PR #7068:
URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r992701613
##
traffic_ops/app/db/migrations/2022100610190300_update_rascal_to_traffic_monitor.up.sql:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software
ocket commented on code in PR #7068:
URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r992700325
##
traffic_ops/traffic_ops_golang/server/servers.go:
##
@@ -856,6 +856,12 @@ func getServers(h http.Header, params map[string]string,
tx *sqlx.Tx, user *auth
github-code-scanning[bot] commented on code in PR #7079:
URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r992589196
##
traffic_ops/traffic_ops_golang/server/servers_server_capability.go:
##
@@ -453,77 +443,178 @@
}
defer inf.Close()
-
traeak closed pull request #7090: t3c/parentdotconfig: enforce mso.parent_retry
ds parameter
URL: https://github.com/apache/trafficcontrol/pull/7090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
traeak commented on PR #7090:
URL: https://github.com/apache/trafficcontrol/pull/7090#issuecomment-1274942317
opted to just document the peculiarities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
traeak opened a new pull request, #7120:
URL: https://github.com/apache/trafficcontrol/pull/7120
The t3c logic currently ignores the `parent_retry` ds parameter and instead
examines the use of parameters
- max_simple_retries
- simple_server_retry_responses
-
Xuanteo opened a new issue, #7119:
URL: https://github.com/apache/trafficcontrol/issues/7119
## This Bug Report affects these Traffic Control components:
- Traffic Control Cache Config (`t3c`, formerly ORT)
- Traffic Control Health Client (t3c-health-client)
-
srijeet0406 opened a new pull request, #7118:
URL: https://github.com/apache/trafficcontrol/pull/7118
This PR is not related to any issue. It removes the previously added (in
https://github.com/apache/trafficcontrol/pull/7023) `asns` field from the
`server` struct.
##
TaylorCFrey commented on code in PR #7050:
URL: https://github.com/apache/trafficcontrol/pull/7050#discussion_r991675941
##
infrastructure/ansible/roles/traffic_stats/templates/traffic_stats.cfg.j2:
##
@@ -15,6 +15,7 @@
"toUser": "{{ ts_toUser }}",
"toPasswd":
zrhoffman merged PR #7117:
URL: https://github.com/apache/trafficcontrol/pull/7117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rawlinp opened a new pull request, #7117:
URL: https://github.com/apache/trafficcontrol/pull/7117
These "TR profile parameters" do not actually exist.
## Which Traffic Control components are affected by this PR?
- Documentation
## What is the best way to
rimashah25 commented on PR #7079:
URL: https://github.com/apache/trafficcontrol/pull/7079#issuecomment-1273536182
> Sorry just seeing this, where are those checks? I usually do a POST
followed by a GET to make sure whether or not the operation actually went
through to the database or
srijeet0406 commented on code in PR #7079:
URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r991409061
##
traffic_ops/traffic_ops_golang/server/servers_server_capability.go:
##
@@ -453,77 +454,166 @@ func AssignMultipleServerCapabilities(w
rimashah25 commented on code in PR #7079:
URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r991381409
##
traffic_ops/traffic_ops_golang/server/servers_server_capability.go:
##
@@ -453,77 +454,166 @@ func AssignMultipleServerCapabilities(w
http.ResponseWriter,
rimashah25 commented on code in PR #7079:
URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r991379510
##
docs/source/api/v4/multiple_servers_capabilities.rst:
##
@@ -0,0 +1,190 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+..
rimashah25 commented on code in PR #7079:
URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r991379034
##
traffic_ops/traffic_ops_golang/server/servers_server_capability.go:
##
@@ -443,8 +444,8 @@ func getDSTenantIDsByIDs(tx *sqlx.Tx, dsIDs []int64)
jhg03a commented on issue #2388:
URL:
https://github.com/apache/trafficcontrol/issues/2388#issuecomment-1272605234
It probably wouldn't need to touch the actual ds, but rather just interpose
itself as a higher priority value.
--
This is an automated message from the Apache Git Service.
mitchell852 commented on issue #2388:
URL:
https://github.com/apache/trafficcontrol/issues/2388#issuecomment-1272604428
@jhg03a - what exactly does this sql query look like? update the ttl on all
delivery services to X? if that was performed how would you revert that?
--
This is an
villajo closed pull request #6803: Documentation fixes
URL: https://github.com/apache/trafficcontrol/pull/6803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
zrhoffman merged PR #7106:
URL: https://github.com/apache/trafficcontrol/pull/7106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zrhoffman merged PR #7109:
URL: https://github.com/apache/trafficcontrol/pull/7109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
srijeet0406 merged PR #7116:
URL: https://github.com/apache/trafficcontrol/pull/7116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zrhoffman commented on code in PR #7116:
URL: https://github.com/apache/trafficcontrol/pull/7116#discussion_r990491005
##
traffic_ops/testing/api/utils/utils.go:
##
@@ -134,10 +144,31 @@ type V5TestData struct {
Expectations []CkReqFunc
}
+type clientSession
ericholguin commented on code in PR #7116:
URL: https://github.com/apache/trafficcontrol/pull/7116#discussion_r990485503
##
traffic_ops/testing/api/utils/utils.go:
##
@@ -134,10 +144,31 @@ type V5TestData struct {
Expectations []CkReqFunc
}
+type clientSession
zrhoffman opened a new pull request, #7116:
URL: https://github.com/apache/trafficcontrol/pull/7116
This PR uses type parameters to introduce struct type safety into the API
test cases where, before Go 1.18, interfaces would need to be used.
## Which Traffic Control
zrhoffman opened a new pull request, #7115:
URL: https://github.com/apache/trafficcontrol/pull/7115
The `TestAPIBase` constant in the Traffic Ops v5 API tests references TO API
v4:
srijeet0406 commented on code in PR #7079:
URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r990344181
##
docs/source/api/v4/multiple_servers_capabilities.rst:
##
@@ -0,0 +1,190 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+..
ericholguin opened a new pull request, #7114:
URL: https://github.com/apache/trafficcontrol/pull/7114
This PR refactors **v5/snapshot_test.go**, **v4/snapshot_test.go**,
**v3/snapshot_test.go**, in order to make tests more granular, providing
transparency on what is being tested
zrhoffman opened a new issue, #7113:
URL: https://github.com/apache/trafficcontrol/issues/7113
## This Improvement request (usability, performance, tech debt, etc.)
affects these Traffic Control components:
- Traffic Ops
- Traffic Portal
## Steps taken
1.
zrhoffman commented on PR #7045:
URL: https://github.com/apache/trafficcontrol/pull/7045#issuecomment-127178
Rebased to fix a changelog merge conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ocket closed issue #6947: Documentation for cdns/{{name}}/federations is
missing a property
URL: https://github.com/apache/trafficcontrol/issues/6947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ocket merged PR #7112:
URL: https://github.com/apache/trafficcontrol/pull/7112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
everly-gif commented on issue #6947:
URL:
https://github.com/apache/trafficcontrol/issues/6947#issuecomment-1271599467
Made PR #7112 please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
everly-gif opened a new pull request, #7112:
URL: https://github.com/apache/trafficcontrol/pull/7112
### Closes: #6947
## Which Traffic Control components are affected by this PR?
- Documentation
## What is the best way to verify this PR?
everly-gif commented on issue #6947:
URL:
https://github.com/apache/trafficcontrol/issues/6947#issuecomment-1271511447
Hi, I would like to work on this issue, please assign it to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rimashah25 commented on PR #7099:
URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1270847030
Tested the API tests locally, all work (v3/v4/v5) fine. Yet to test DS DSRs
creation with API v5 curl cmds.
--
This is an automated message from the Apache Git Service.
To
shamrickus commented on code in PR #7104:
URL: https://github.com/apache/trafficcontrol/pull/7104#discussion_r989386984
##
traffic_portal/app/src/common/modules/table/serviceCategoryDeliveryServices/table.serviceCategoryDeliveryServices.tpl.html:
##
@@ -26,7 +26,6 @@
zrhoffman commented on code in PR #7109:
URL: https://github.com/apache/trafficcontrol/pull/7109#discussion_r989385185
##
traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/dns/ZoneManager.java:
##
@@ -527,7 +527,7 @@ private static void
shamrickus merged PR #7102:
URL: https://github.com/apache/trafficcontrol/pull/7102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shamrickus commented on PR #7102:
URL: https://github.com/apache/trafficcontrol/pull/7102#issuecomment-1270546381
In that case we should make it do something other than `npm ci` (which also
blows away node_modules on the host system I might add), but that's not
relevant to this PR.
--
rimashah25 commented on code in PR #7068:
URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r989378882
##
traffic_ops/traffic_ops_golang/deliveryservice/capacity.go:
##
@@ -249,7 +249,7 @@ JOIN server as s ON s.profile = pr.id
JOIN cdn as c ON c.id = s.cdn_id
rimashah25 commented on code in PR #7068:
URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r989371625
##
traffic_ops/traffic_ops_golang/server/servers.go:
##
@@ -856,6 +856,12 @@ func getServers(h http.Header, params map[string]string,
tx *sqlx.Tx, user *auth
rimashah25 closed issue #5782: There is a vulnerability in log4j 1.2.17
,upgrade recommended
URL: https://github.com/apache/trafficcontrol/issues/5782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rimashah25 commented on issue #5782:
URL:
https://github.com/apache/trafficcontrol/issues/5782#issuecomment-1270503537
We have updated log4j to 2.17.1 (PR: #6390, #6438, #6445)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
zrhoffman commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989325834
##
CHANGELOG.md:
##
@@ -12,6 +12,7 @@ The format is based on [Keep a
Changelog](http://keepachangelog.com/en/1.0.0/).
-
zrhoffman commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989324166
##
traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html:
##
@@ -475,6 +475,26 @@ Previous Value
zrhoffman commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989319187
##
traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
ocket commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989294749
##
CHANGELOG.md:
##
@@ -12,6 +12,7 @@ The format is based on [Keep a
Changelog](http://keepachangelog.com/en/1.0.0/).
-
ocket commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989293452
##
traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
ocket commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989293452
##
traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
zrhoffman commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989277863
##
docs/source/overview/delivery_services.rst:
##
@@ -505,6 +505,9 @@ Max Origin Connections
--
The maximum number of TCP connections
zrhoffman commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989260025
##
traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
zrhoffman commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989252029
##
CHANGELOG.md:
##
@@ -12,6 +12,7 @@ The format is based on [Keep a
Changelog](http://keepachangelog.com/en/1.0.0/).
-
ocket commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989135302
##
CHANGELOG.md:
##
@@ -12,6 +12,7 @@ The format is based on [Keep a
Changelog](http://keepachangelog.com/en/1.0.0/).
-
zrhoffman commented on PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#issuecomment-1270196692
Added the Regional field to Traffic Portal v1 in 9b4c1f3f2e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ocket commented on PR #7102:
URL: https://github.com/apache/trafficcontrol/pull/7102#issuecomment-1270168821
no, the developer environment is for development, so using the development
angular server seems more appropriate to me.
--
This is an automated message from the Apache Git
zrhoffman commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r988438970
##
traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql:
##
@@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
zrhoffman commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r988438970
##
traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql:
##
@@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
zrhoffman commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r988409168
##
traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql:
##
@@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
zrhoffman commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r988402881
##
traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql:
##
@@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
github-code-scanning[bot] commented on code in PR #7079:
URL: https://github.com/apache/trafficcontrol/pull/7079#discussion_r988365003
##
traffic_ops/traffic_ops_golang/server/servers_server_capability.go:
##
@@ -453,77 +454,167 @@
}
defer inf.Close()
-
ocket commented on code in PR #7104:
URL: https://github.com/apache/trafficcontrol/pull/7104#discussion_r988359735
##
traffic_portal/app/src/common/modules/table/topologyDeliveryServices/table.topologyDeliveryServices.tpl.html:
##
@@ -26,7 +26,6 @@
ocket commented on code in PR #7111:
URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r988299783
##
traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql:
##
@@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
ocket merged PR #7075:
URL: https://github.com/apache/trafficcontrol/pull/7075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ericholguin commented on issue #6801:
URL:
https://github.com/apache/trafficcontrol/issues/6801#issuecomment-1265761357
I think this should be reopened it is a separate issue from #6691
error.log shows:
```
ERROR: api.go:263: 2022-10-03T16:55:00.5425Z: [::1]:54360 querying CDN
ocket merged PR #7103:
URL: https://github.com/apache/trafficcontrol/pull/7103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
asf-ci opened a new pull request, #7103:
URL: https://github.com/apache/trafficcontrol/pull/7103
This PR uses [`.asf.yaml`](https://s.apache.org/asfyamltriage) to assign the
GitHub [Triage
zrhoffman commented on PR #7100:
URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263985694
Switched back to the old annotations we were using that echoes annotations
instead of using the API (I wish more of them did that) in 7483eaa032
--
This is an automated
github-code-scanning[bot] commented on code in PR #7102:
URL: https://github.com/apache/trafficcontrol/pull/7102#discussion_r984908529
##
experimental/traffic-portal/server.ts:
##
@@ -198,10 +196,18 @@
return;
ocket opened a new pull request, #7102:
URL: https://github.com/apache/trafficcontrol/pull/7102
Fixed the TPv2 server not running as intended.
It also now handles more gracefully the common case of bind permissions
being denied on port 80 when running in SSL mode. Instead of the
ocket commented on PR #7100:
URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263932500
So you're saying that once this is merged it'll add annotations?
Lemme check that out. Or, well, at least check if the warning and error go
away.
--
This is an
zrhoffman commented on PR #7100:
URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263910426
But we can get annotations on PRs. See the annotations generated from the PR
I linked above: https://github.com/apache/unomi/actions/runs/3129456290
--
This is an automated
ocket commented on PR #7100:
URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263905693
Well if we can't get annotations on PRs, why have the step for converting
JUnit to annotations?
--
This is an automated message from the Apache Git Service.
To respond to the
zrhoffman commented on PR #7100:
URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263899975
> Also it's not caching Maven dependencies because it can't find the
directory at the end of the run:
>
> > Warning: Path Validation Error: Path(s) specified in the action
zrhoffman commented on PR #7100:
URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263896968
> I'm still seeing the same annotations in the latest run on that
JUnit-to-annotation conversion.
I think that that is because the *mikepenz/action-junit-report* action is
ocket commented on PR #7100:
URL: https://github.com/apache/trafficcontrol/pull/7100#issuecomment-1263853338
I'm still seeing the same annotations in the latest run on that
JUnit-to-annotation conversion.
Also it's not caching Maven dependencies because it can't find the
jhg03a opened a new issue, #7101:
URL: https://github.com/apache/trafficcontrol/issues/7101
## This Improvement request (usability, performance, tech debt, etc.)
affects these Traffic Control components:
- Traffic Portal
## Current behavior:
Right now when
rimashah25 commented on PR #7075:
URL: https://github.com/apache/trafficcontrol/pull/7075#issuecomment-1263765624
I see the `Last Updated` field in the form correctly
but in
ocket merged PR #7084:
URL: https://github.com/apache/trafficcontrol/pull/7084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zrhoffman opened a new pull request, #7100:
URL: https://github.com/apache/trafficcontrol/pull/7100
This Pull Request
* renames the [*Traffic Router Unit
Tests*](https://github.com/apache/trafficcontrol/actions/workflows/tr.unit.tests.yaml)
workflow to [*Traffic Router
901 - 1000 of 33413 matches
Mail list logo
