Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/425#discussion_r111807542
--- Diff: traffic_monitor_golang/traffic_monitor/datareq/datareq.go ---
@@ -157,16 +159,34 @@ func WrapErrCode(errorCount threadsafe.Uint
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/425#discussion_r111807495
--- Diff: traffic_monitor_golang/traffic_monitor/datareq/datareq.go ---
@@ -235,3 +276,39 @@ func addTrailingSlashEndpoints(dispatchMap
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/475
This also fixed Traffic Ops' `rascalstatus`, which pulls from CacheStates
without regard for CrStates, and hence will get duplicate, old data for any
caches moved from one CDN
Github user rob05c closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/443
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rob05c closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/428
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/443
Remove TO client ResumeSession, remove juju dep
Removes traffic_ops/client.ResumeSession().
This allows us to remove the juju persistent cookie dependency, which
has
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/425
This also makes the GUI faster and more resilient with poor connectivity,
because browsers transparently accept and decode gzip in the AJAX requests.
---
If your project is set up
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/428
Deprecate TO client ResumeSession, remove juju dependency
Changes the TO client ResumeSession to always return nil and an error
as if the persisted cookie had expired, and adds
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/425
Add TM2 HTTP gzip support
Because text compresses well, and most Traffic Monitor endpoints are large
amounts of repetitive text, this makes most endpoints go from tens of megabytes
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/352
This looks like a lot of code, but it's really just fixing the status text
in the GUI endpoint.
---
If your project is set up for it, you can reply to this email and have your
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/415
Add Traffic Monitor 2.0 Hot Log Location Reloading
Adds TM2 reloading log locations when they change in the config file. This
allows e.g. changing the debug log location from "
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/414
Intentionally doesn't update `version.go` to match, so we can verify it
works.
Tested with an RPM built in Jenkins with this branch, installed on a QA
monitor
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/414
Fix Traffic Monitor 2.0 RPM build to set the binary Version to Traffic
Control Version
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/408
Fix Traffic Monitor 2.0 fetcher UserAgent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator-trafficcontrol
tm2
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/406
Fix TM2 to refresh DsStats maps on CRConfig poll
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/325
@nir-sopher Sorry about the slow response, we've been crazy busy here, with
two big releases in the last three weeks. FYI I'm not a Committer, so I can't
merge your PR, but we can
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107812849
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107812127
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107813158
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107810958
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107813615
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107812486
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107808481
--- Diff: traffic_ops/experimental/go-api/api.go ---
@@ -0,0 +1,112 @@
+package main
+
+/*
+ Licensed under the Apache
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107809703
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107813099
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107810203
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107814559
--- Diff: traffic_ops/experimental/go-api/api.go ---
@@ -0,0 +1,112 @@
+package main
+
+/*
+ Licensed under the Apache
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107813482
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107811076
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107814537
--- Diff: traffic_ops/experimental/go-api/api.go ---
@@ -0,0 +1,112 @@
+package main
+
+/*
+ Licensed under the Apache
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107810020
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107810629
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/325#discussion_r107812722
--- Diff: traffic_ops/experimental/go-api/tenant/EndPointSeeder.go ---
@@ -0,0 +1,202 @@
+package tenant
+
+/*
+ Licensed
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/405
Add experimental TO monitoring.json microservice
Perl DBIx takes 8s to return monitoring.json. Perl DBI raw SQL takes 1s.
This Go microservice takes 50ms.
You can merge this pull
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/392
@PSUdaemon Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/392
Change TO monitoring.json to raw SQL
This is 3-10x faster, and this endpoint is one of the slowest.
You can merge this pull request into a Git repository by running:
$ git
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/383
Add Traffic Ops Server Detail CDN field, add client Server()
This is needed by Traffic Monitor, to get its own CDN efficiently, instead
of having to query all servers.
You can
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/382
Fix TM2 to not be build with all build.sh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator-trafficcontrol
tm2
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/372
Add Traffic Monitor 2.0 getting its CDN from Traffic Ops
Adds Traffic Monitor 2.0 getting the name of the CDN to monitor from
Traffic Ops. The CDN is the CDN that this Traffic
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/366
Add Traffic Monitor 2.0 documentation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator-trafficcontrol tm2-docs
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/355
Change TM2 to not 503 for new unpolled caches
Changes Traffic Monitor 2.0 to not return 503 when a new CRConfig with
new, unpolled caches is received, after startup. Now
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/353
Fix Traffic Monitor 2.0 to mark System.NotAvailable caches polled
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/151
@knutsel Added.
I'd still like to see it merged, yes. Separating ATS configuration into its
own app is both a step toward microservices and away from monoliths, and a step
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/339
Reduce Traffic Monitor 2.0 Logging
Lowers several logs to Info. Fixes a log issue, of logging an error value
after changing it.
You can merge this pull request into a Git
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/332
Fix TM2 to remove OFFLINEd peers, timeout peers
Fixes Traffic Monitor 2.0 to remove peers which have been marked
OFFLINE in Traffic Ops from its endpoints. OFFLINEd peers
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/330
Add Traffic Monitor offline validator library, service, nagios app
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
@dangogh @alficles Yes, traffic_monitor and traffic_monitor_golang should
never both be built. One is replacing the other. The plan is to rename the
`traffic_monitor_golang
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/323
@dneuman64 Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/328
Add TM2 offline validator utility pkg and service
This is dependent on changesets in PR #323, don't merge before it.
You can merge this pull request into a Git repository
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/320
Add Traffic Monitor 2.0 /publish/Stats 95th percentile cache poll time
Also changes polling to be slightly under the target time, and fixes a
global variable potential threadsafety
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/283
Fix TO client Login, add stats UserAgent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator-trafficcontrol tm2
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/270
Fix Traffic Monitor 2.0 Duplicate Events
Fixes duplicate events from the Peer and Stat manager both calling
CombineCrStates with their own maps of whether the event had been
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/261
Cleanup Traffic Monitor 2.0 TODOs, improve request time accuracy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/251
Add TM2 error logs for bad start state params
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator-trafficcontrol
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/250#discussion_r99379507
--- Diff: traffic_monitor_golang/traffic_monitor/deliveryservice/stat.go ---
@@ -241,8 +241,12 @@ func addDSPerSecStats(dsName
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/250#discussion_r99379255
--- Diff: traffic_monitor_golang/traffic_monitor/deliveryservice/stat.go ---
@@ -241,8 +241,12 @@ func addDSPerSecStats(dsName
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/250#discussion_r99372539
--- Diff: traffic_monitor_golang/traffic_monitor/health/cache.go ---
@@ -201,7 +201,7 @@ func CalcAvailability(results []cache.Result
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/248
Add TM2 host header to cache requests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator-trafficcontrol tm2
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/242
Fix TM2 PerSec stats to only compute new results
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/212
Other than those 2 little things, looks great. Not enough to -1, if they
take more than 5mins.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/212#discussion_r97406714
--- Diff: traffic_monitor/experimental/traffic_monitor/static/index.html ---
@@ -382,7 +386,7
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/212#discussion_r97405960
--- Diff:
traffic_monitor/experimental/traffic_monitor/deliveryservice/stat.go ---
@@ -72,7 +74,7 @@ func setStaticData(dsStats Stats
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/204
Traffic Monitor 2.0 Dynamic Threshold Addition and Refactor
This required a big refactor. Don't merge this until Jeff's upcoming Events
PR is merged. There will be conflicts, I'll
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/194
Traffic Monitor 2.0 poll fixes, move static files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/193#discussion_r96502701
--- Diff: traffic_monitor/experimental/traffic_monitor/index.html ---
@@ -504,18 +536,13 @@
Type
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/193#discussion_r96501891
--- Diff: traffic_monitor/experimental/traffic_monitor/index.html ---
@@ -141,6 +132,7 @@
setInterval
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/180
Traffic Monitor 2.0 fix readme run instructions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/178
Add Traffic Monitor 2.0 Stat Spans
Adds TM2 stat spans, to reduce memory by de-duplicating stats that haven't
changed.
Adds a func to add trailing slashed to all HTTP
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/173#discussion_r95421273
--- Diff: traffic_monitor/experimental/traffic_monitor/srvhttp/srvhttp.go
---
@@ -134,22 +136,29 @@ func ParametersStr(params url.Values
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/173#discussion_r95421340
--- Diff: traffic_monitor/experimental/traffic_monitor/srvhttp/srvhttp.go
---
@@ -134,22 +136,29 @@ func ParametersStr(params url.Values
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/172#discussion_r95404995
--- Diff:
traffic_monitor/experimental/traffic_monitor/manager/datarequest.go ---
@@ -198,6 +204,16 @@ func NewCacheStatFilter(params
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
+1 on built-in vendoring, -1 on godep unless there's a compelling reason.
I'd also be +1 on Makefiles iff there's a compelling reason for them. Go
build tools are minimal
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/171
Traffic Monitor 2.0 fixes
Fixes for various uncommon Traffic Control scenarios.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/99#discussion_r91558538
--- Diff: traffic_monitor/experimental/common/poller/poller.go ---
@@ -157,68 +187,151 @@ func (p HttpPoller) Poll
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/99#discussion_r91558204
--- Diff: traffic_monitor/experimental/traffic_monitor/cache/data.go ---
@@ -1,4 +1,8 @@
-package manager
+package cache
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/99#discussion_r91555159
--- Diff: traffic_monitor/experimental/common/poller/heap.go ---
@@ -0,0 +1,112 @@
+package poller
+
+import (
+ &quo
Github user rob05c commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/99#discussion_r91555135
--- Diff: traffic_monitor/experimental/common/poller/heap.go ---
@@ -0,0 +1,112 @@
+package poller
+
+import (
+ &quo
101 - 177 of 177 matches
Mail list logo
