[GitHub] incubator-trafficcontrol pull request #862: [BACKPORT][TC-549] adds perl-Cry...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/862


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #866: [TC-540] fix ldap.conf key

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/866

[TC-540] fix ldap.conf key



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol ldap-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/866.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #866






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #859: [BACKPORT][TC-540] fix postinstall ldap...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/859
  
@hbeatty hold off on this one -- found a glitch



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #862: [BACKPORT][TC-549] adds perl-Cry...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/862

[BACKPORT][TC-549] adds perl-Crypt-ScryptKDF to traffic_ops rpm deps

 so postinstall wil run

(cherry picked from commit 3737bb1429cfadea51ef6f28a6098eb08c29a8df)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
cryptlib-dep-2.1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/862.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #862


commit 867d6f997ee694a84774bd3002228b38894fc8f1
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-23T18:14:35Z

adds perl-Crypt-ScryptKDF to traffic_ops rpm deps so postinstall will run

(cherry picked from commit 3737bb1429cfadea51ef6f28a6098eb08c29a8df)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #861: [TC-549] adds missing perl-Crypt...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/861

[TC-549] adds missing perl-Crypt-ScryptKDF dependency to TO rpm



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
missing-crypt-lib

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/861.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #861






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #853: [TC-443] - add the ability to manage ss...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #853: [TC-443] - add the ability to manage ss...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #859: [BACKPORT][TC-540] fix postinsta...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/859

[BACKPORT][TC-540] fix postinstall ldap.conf keys; prompt for base_url



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 2.1-ldapfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/859.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #859


commit d8c0d89e2d6f86b37bff528bb0a789ca9c55ae1f
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-18T18:44:33Z

required keys in ldap.conf; check host form; add base_url to defaults and 
q's

(cherry picked from commit df979b164af2575159cd339036200a72215c63c2)

commit d1075d7d938925c5df164bb45ed91f99b12f0d13
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-22T20:57:22Z

updates base_url

(cherry picked from commit 35abdcc64d9dbe70a1fd118bc51538d6fa10be66)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #853: WIP [TC-443] - add the ability to manag...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/853
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #854: [TC-540] postinstall ldap.conf k...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/854

[TC-540] postinstall ldap.conf keys fixed; cdn.conf base_url added

keys for ldap.conf were incorrect and caused traffic_ops not to connect to 
ldap.   cdn.conf base_url question was missed causing base_url in existing 
cdn.conf to be unchanged.

Both of these were fixed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol ldap-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/854.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #854


commit 1d80843aabeaebbb7f2581d7772dd74b4fe57c0f
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-18T18:44:33Z

required keys in ldap.conf; check host form; add base_url to defaults and 
q's

commit 9419bb8e52b6c0423e69fc2492537dd97354acbf
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-22T20:57:22Z

updates base_url




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #837: [BACKPORT] [TC-374] eliminate TO...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/837


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #837: [BACKPORT] [TC-374] eliminate TO...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/837

[BACKPORT] [TC-374] eliminate TO orphan processes

(cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
orphan-procs-2.1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/837.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #837


commit 2970c85d0b0f6ff6c7d0836e8ff4fa54029501b8
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-16T18:31:28Z

handle orphan processes in TO

(cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #836: [BACKPORT] [TC-374] eliminate TO...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/836


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #836: [BACKPORT] [TC-374] eliminate TO orphan...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/836
  
opened against master -- closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #836: [BACKPORT] [TC-374] eliminate TO...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/836

[BACKPORT] [TC-374] eliminate TO orphan processes



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
orphan-procs-2.1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #836


commit a376bc0670ea137ceef7da7a6e26394600fc77b3
Author: Jeremy Mitchell <mitchell...@gmail.com>
Date:   2017-08-09T14:58:10Z

fixes number validation on global max settings

(cherry picked from commit 8603bc83dfe9b667af54f9101028740940bac86f)

commit 66fa1115f3d27b83fc4cbf9f91878b46e86680b1
Author: hbeatty <hbea...@users.noreply.github.com>
Date:   2017-08-10T13:08:04Z

closes #792

commit aecd573437e6d765ee315e29bb4a98f51f348e19
Author: Steve Malenfant <steve.malenf...@cox.com>
Date:   2017-08-11T18:52:32Z

Remove reference to table "public" and match description

commit 7058a550ded22a5f94370ac9a5c1fd8b89707362
Author: Steve Malenfant <steve.malenf...@cox.com>
Date:   2017-08-11T19:13:13Z

Removed ".go" typo

commit 6aae6f47ff60b8723a54ccf7370e6b684aed3c36
Author: hbeatty <hbea...@users.noreply.github.com>
Date:   2017-08-15T16:56:53Z

This closes #797

commit fa18c96ed18d4caabf743cd1ee2a02e008a7
Author: Jeremy Mitchell <mitchell...@gmail.com>
Date:   2017-08-15T16:44:56Z

accounts for missing dependency that centos 7.3 doesn't provide. when 
centos 7.4 is available this dependency will be provided with the distro.

(cherry picked from commit 15901255c1847800bbd871e33c757017ec23f74f)

commit 53345aa1bf09fa90938c04c2134b543cd0aff434
Author: Steve Malenfant <steve.malenf...@cox.com>
Date:   2017-08-17T14:14:39Z

This closes #821

commit 1c9ce9eb9ce167d50d945aad085231f68f112bcf
Author: Jeremy Mitchell <mitchell...@gmail.com>
Date:   2017-08-15T02:13:51Z

adds back missing tenants menu item

(cherry picked from commit a049589041ece51d6069cae09e2fdf23440d4a91)

commit a581e82a6eeb15a30b12b8a17dd2eb78cfca6bf7
Author: hbeatty <hbea...@users.noreply.github.com>
Date:   2017-08-17T17:02:53Z

This closes #814
This closes #TC-519

commit 4350faf99e5df17bc29ec3807885f3ec02ffbe48
Author: nir-sopher <n...@qwilt.com>
Date:   2017-08-13T16:01:38Z

ssl_keys - tenancy checks

(cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6)

commit bad7062d2b8444e67da7d37dc373ee43cb7f1f0a
Author: hbeatty <hbea...@users.noreply.github.com>
Date:   2017-08-18T18:35:01Z

This closes #835
TC-533 #close fixed by GH PR #835

commit 2970c85d0b0f6ff6c7d0836e8ff4fa54029501b8
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-16T18:31:28Z

handle orphan processes in TO

(cherry picked from commit 52e50b98523902dab422117ca958655457f3de5f)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #823: [TC-374] handle orphan processes...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/823

[TC-374] handle orphan processes in TO init.d

allows stop and/or restart of TO in case of orphaned workers.

To test,  find a worker process (`ps -ef | grep 
/opt/traffic_ops/app/scripts/cdn`) and kill with a HUP signal:   `kill -HUP 
5432`

You should see a new process with a parent of 1:

```
$ ps -ef | awk '/^trafops/&&/\/script\/cdn/ { if ($3 == 1) {print} }'
trafops  29881 1  0 18:05 ?00:00:00 
/opt/traffic_ops/app/script/cdn```
```

Restart:
```sudo systemctl restart traffic_ops```

The only `/script/cdn` process with a parent of 1 should be owned by `root` 
and should be the one in the `/var/run/traffic_ops.pid` file.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol TC-374

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/823.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #823


commit c65c2e7d0125e14917341bd8ac05edcb559b5599
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-16T18:31:28Z

handle orphan processes in TO




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #812: [TC-517] TP - displays users filtered b...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/812
  
@mitchell852 reviewing this now..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #793: [TC-505] - throws 403 (rather th...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/793#discussion_r132557250
  
--- Diff: traffic_ops/app/conf/cdn.conf ---
@@ -13,8 +13,9 @@
access_control_allow_origin => '*'
},
to => {
-   base_url   => 'http://localhost:3000',# 
this is where traffic ops app resides
-   email_from => 'no-re...@traffic-ops-domain.com'   # 
traffic ops email address
+   base_url=> 
'http://localhost:3000',

 # this is where traffic ops app resides
+   email_from  => 
'no-re...@traffic-ops-domain.com',  

 # traffic ops email address
+   no_account_found_msg=> 'A Traffic Ops user account is 
required for access. Please contact your Traffic Ops user administrator.' # 
message to display if no TO account is found in tm_user
},
--- End diff --

TABs added in there?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #795: exclude traffic_ops_golang vendor depen...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/795
  
test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #795: exclude traffic_ops_golang vendo...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/795

exclude traffic_ops_golang vendor dependency in rat report

rat report shows go-sqlmock is not properly licensed,  but it is documented 
in the LICENSE file.  Adds to .rat-excludes so rat won't report it.

@rob05c -- your first merge?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol rat-exclude

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/795.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #795


commit 8c1153abddff1fedf8f9cd79cdb824bd4ed5f06d
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-10T17:32:45Z

exclude traffic_ops_golang vendor dependency in rat report




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #789: adds docs/ prefix to hrefs on ve...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/789

adds docs/ prefix to hrefs on versions; use master for latest

previous PR got the links wrong..   This fixes that issue and uses the 
"master" dir for "latest"

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
updated-doc-links

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/789.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #789


commit 9233f2c49b6dbee5e4e2ace5a12d988763a77a92
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-08T22:51:21Z

adds docs/ prefix to hrefs on versions; use master for latest




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #788: WIP - adds versions dropdown to ...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/788

WIP - adds versions dropdown to documentation

still testing..   This adds version selection to documentation web pages

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol docs-versions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/788.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #788


commit 70ac7a181f28b6eb4960a070236fd17709d437b7
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-08T21:28:01Z

adds versions dropdown to documentation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #785: [TC-502] ORT now skips file chec...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/785#discussion_r131972340
  
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1266,15 +1266,19 @@ sub check_plugins {
( my @parts ) = split( /\@plugin\=/, $liner );
foreach my $i ( 1..$#parts ) {
( my $plugin_name, my $plugin_config_file ) = 
split( /\@pparam\=/, $parts[$i] );
-   if (defined( $plugin_config_file ) ) {
+   if (defined( $plugin_config_file ) ) {{
--- End diff --

looking again -- that block isn't necessary -- the `last` will exit the 
nearest enclosing loop,  which is the `foreach ... $#parts)`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #785: [TC-502] ORT now skips file chec...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/785#discussion_r131967719
  
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1266,15 +1266,19 @@ sub check_plugins {
( my @parts ) = split( /\@plugin\=/, $liner );
foreach my $i ( 1..$#parts ) {
( my $plugin_name, my $plugin_config_file ) = 
split( /\@pparam\=/, $parts[$i] );
-   if (defined( $plugin_config_file ) ) {
+   if (defined( $plugin_config_file ) ) {{
--- End diff --

then please reformat that section and indent appropriately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #785: [TC-502] ORT now skips file chec...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/785#discussion_r131959659
  
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1266,15 +1266,19 @@ sub check_plugins {
( my @parts ) = split( /\@plugin\=/, $liner );
foreach my $i ( 1..$#parts ) {
( my $plugin_name, my $plugin_config_file ) = 
split( /\@pparam\=/, $parts[$i] );
-   if (defined( $plugin_config_file ) ) {
+   if (defined( $plugin_config_file ) ) {{
--- End diff --

`{{` ???



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #781: WIP - Adding contact information to Ten...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/781
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #783: [TC-437] - adds the ability to generate...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/783
  
retest this please




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #783: [TC-437] - adds the ability to generate...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/783
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #781: WIP - Adding contact information to Ten...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/781
  
retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #781: WIP

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/781
  
Please change the PR title to be descriptive of the change.   WIP is an 
appropriate label to show it's not complete,  but still must describe the 
purpose of the change.

Also,  individual commit messages should be descriptive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #778: [TC-475] defaults ats_ver to 5 t...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/778

[TC-475] defaults ats_ver to 5 to eliminate  undef warnings.

also warns user of missing parameter

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
ats-ver-warning

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #778


commit 615943c0345f49e55f4a98416f36aac05f366892
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-04T20:05:24Z

defaults ats_ver to 5.  This eliminates warnings during integration test 
and warns user of missing parameter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #756: allow unit/integration tests to ...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/756

allow unit/integration tests to continue if cleanup in docker fails

cleanup of /root/.cpan* fails sometimes, but should not keep process from 
continuing.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
ignore-rm-fails

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/756.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #756


commit 592b457012e884157690d0ca0f232ab37823663d
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-07-26T23:02:46Z

sometimes docker build fails on rm -- ignore if that happens




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #732: adds integration tests to docker...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/732

adds integration tests to docker setup for traffic_ops



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
integration-tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #732


commit 3f4c70166b507f1884c326ea90bfa569bb5fc95b
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-07-13T22:17:46Z

adds integration tests to docker setup for traffic_ops




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #705: [TC-402] - ds xml_id is not editable

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/705
  
isn't this to make xml_id read-only?  title confused me..

and there are conflicts now..



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #716: [TC-414] docker-compose to run u...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/716

[TC-414] docker-compose to run unit tests

also removed restriction on Perl module Google::ProtocolBuffers in 
cpanfile.  The version restriction was for Centos 6.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
to-unit-docker2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #716


commit 0a4a25e2a1e802dbec0d462a80f596116882e1c9
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-07-07T21:09:44Z

docker-compose to run unit tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #710: fix portal build script

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/710

fix portal build script



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol portal-build

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/710.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #710


commit 7f59626e6a83482f616a9fac272b002d9560c503
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-07-03T16:23:01Z

fix portal build script




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #699: Fix licenses

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/699

Fix licenses

- add missing license to migration sql
- re-add scss file previously removed and add to .rat-excludes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol fix-licenses

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/699.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #699


commit 944c5b222489c542bf9a20df870f80a55e6eafb9
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-26T15:20:37Z

re-add scss file -- license covered

commit 0787bab3b7226d0183fc6150073763379ca7736b
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-26T15:20:52Z

add exclusion to rat

commit 68343c1ea4ddcc23a80688fa456f06b15008cb22
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-26T15:21:11Z

add missing license




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #697: Adds triggers missed by mysql->p...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/697

Adds triggers missed by mysql->postgres migration



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
missing-triggers

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/697.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #697


commit 27dd3cee9c4d047091a5ba64a09fdca5b3400ed0
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-23T16:14:15Z

fix missing triggers -- lost in mysql to psql transition

commit 470c86600d97ccdfd7144bcdcce2dd85a9f4c331
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-23T21:52:10Z

add copyright header




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #690: [Backport TC-395] remove ref to ...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/690

[Backport TC-395] remove ref to apache build rpm; fix script name in 
_postinstall



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 2.0-docfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/690.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #690


commit 70af53225c382cd8bb03494a01ce6c6e2a9f0ab1
Author: David Neuman <neu...@apache.org>
Date:   2017-06-07T20:14:55Z

Update _postinstall
(cherry picked from commit c26d0489cb115d108a25f880e0d5874cbff2243c)

commit 40a9894e9e6fde88e584baee6c49d58f0c97ed99
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-15T22:18:02Z

remove ref to rpms on apache build

(cherry picked from commit 1dfacaf500ece5ec2d5fe59dfccf64e527fd2b6b)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #689: [TC-395] remove doc ref to rpms ...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/689

[TC-395] remove doc ref to rpms on apache build



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
to-install-doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/689.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #689


commit f8d14c8248855fc9a4ebde6b70ab27b20b7855ee
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-15T22:18:02Z

remove ref to rpms on apache build




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #686: [Backport TC-370] Address IPMC C...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/686


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #687: [Backport TC-370] fix more missing lice...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/687
  
merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #687: [Backport TC-370] fix more missi...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/687


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #687: [Backport TC-370] fix more missi...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/687

[Backport TC-370] fix more missing license headers



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
2.0-more-license

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/687.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #687


commit 1c896002d6e6e486f5ecc2a51e4872923bd3f91c
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-19T23:33:26Z

add missing license statements

(cherry picked from commit 36d3ada221f20bae12b2cbcd10fb7a0c40411341)

commit 2ec5aa1c4af976cbb2574d417a4df2e4d98dacc5
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-19T22:54:39Z

license fixes to be backported to 2.0.x

(cherry picked from commit 1ddcd73418bf17450a194cd767370c09763ed1fa)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #686: [Backport TC-370] Address IPMC C...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/686

[Backport TC-370] Address IPMC Comments



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 2.0-ipmc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #686


commit e816d03770f37c645ee649b70721db0499fb3e8f
Author: Eric Friedrich <fri...@apache.org>
Date:   2017-06-15T14:54:50Z

[TC-370] Address IPMC Comments

(cherry picked from commit 0787ef4a70307afd527d7667405aa2a393930e5d)

commit 3af483c171c49154da88f695044d4197c28fa6ba
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-15T16:34:14Z

make dir in tarball match tarball name

(cherry picked from commit d388a139662bc84d3585bee9ab5201a5a72ac2bf)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #685: for IPMC: make dir in tarball ma...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/685

for IPMC:  make dir in tarball match tarball name



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
tarball-dirname

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/685.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #685


commit 8943a5dde74b8f56ce05260385b67f96f9a637fe
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-15T16:34:14Z

make dir in tarball match tarball name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #677: [BACKPORT] updated the documentation fo...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/677
  
This was included in #674 .  This can be closed without merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #681: [TC-370] Address IPMC Comments

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/681
  
#682 cherry-picks this from master.  This one should be closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #683: [Backport TC-370] Address IPMC C...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/683

[Backport TC-370] Address IPMC Comments



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 2.0.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/683.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #683


commit cd34be20236a8730fc34435c749fcb2b39e05ab4
Author: Eric Friedrich <fri...@apache.org>
Date:   2017-06-15T14:54:50Z

[TC-370] Address IPMC Comments

(cherry picked from commit 0787ef4a70307afd527d7667405aa2a393930e5d)

commit 6da8ad4c9874b5105cb37d6767c2b2f51742f1b2
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-15T15:40:45Z

This closes #682.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #679: [Backport] updates TO install do...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/679


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #679: [Backport] updates TO install do...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/679

[Backport] updates TO install docs; adds build instructions to docs

@limited :TO install instructions from @knutsel,  build instructions 
from @dangogh

Also removes experimental files with potential license issues.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 2.0-docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #679


commit 5f87aba03188dfe241cb6d979eb0f8e4f0416236
Author: Jan van Doorn <jan_vando...@cable.comcast.com>
Date:   2017-06-11T16:04:21Z

Updated TO install docs, works with master 6/11/2017

(cherry picked from commit 2545a06a519c518df7c52aee8c70825272be5c55)

commit 921a2c7c631ec949029192098b96fde9fb65a83f
Author: Jan van Doorn <jan_vando...@cable.comcast.com>
Date:   2017-06-11T20:58:30Z

Change doc version to 2.0.0

commit 3ba99039fdc934572a4e1c2ba6cf946384f4af29
Author: Jan van Doorn <jan_vando...@cable.comcast.com>
Date:   2017-06-11T21:00:34Z

Change pngmath to imgmath to clear warning.

(cherry picked from commit b56846ea54df6cf4c6e3be249a2fb5869674cf7b)

commit cc294ec85092034db5b34f6532b46e4bd70b1a70
Author: Jan van Doorn <jan_vando...@cable.comcast.com>
Date:   2017-06-12T18:45:34Z

enable pg autostart

(cherry picked from commit 3bc4b79685e6acbca0bac55901a02fdafdb654f1)

commit 68dd88e31ea3dd285d6d81c67c37ed12b8576df4
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-13T19:38:39Z

add building doc to development page

(cherry picked from commit 1c84235d94831b215e94c32bffebd7189ea2c285)

commit d4ea50156e40b9de1c7a54565b015e4ccf70a6c9
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-13T21:58:09Z

more explicit instructions + alternate instructions using docker-compose

(cherry picked from commit 3b93cb610dde5519268bec84afeab46fb0ac25c6)

commit ae49ea39e3592a97db5ba9881032ce329a4f6c40
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-13T21:59:34Z

fix a few nits; point to building page for rpm

(cherry picked from commit fd44a78835df48bbe51442f0d3d5e0b2a28a1279)

commit a7f689e4924140596d5e1eb35c7cb39d7516f8d6
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-13T22:02:21Z

build instructions moved to doc

(cherry picked from commit a431b5d88950f6f9b85f0dd70516ac92f1d9fe6e)

commit 82d3da64ef2b5be24f5adfa40e25a1a783e753e7
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-14T18:36:21Z

add missing copyright

(cherry picked from commit 272abdce1424d1991395307a845195ab4a5bf78a)

commit f6c8d6f462de6c2f094d1d6409ba9ae2338b982b
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-14T18:40:47Z

remove files with unknown licenses -- if these are needed, need to resolve 
license issue before re-adding

(cherry picked from commit f243c67d0f60b69ad58707cfae4b11ad3e3ee624)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #678: resolve final license issues

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/678

resolve final license issues

Added license to new `building.rst` file.

Removed files in "experimental" that still don't have license resolution in 
place to finally get the rat tool to pass.

If they are needed,  the license issue needs to be resolved prior to 
merging in.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
remove-licenses

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #678


commit 294fb2b80e625d16fd1b694a89e9f7d70ed664d0
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-14T18:36:21Z

add missing copyright

commit 7ec6a78f9f2fc4744e2189f7f52529a2455d1385
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-14T18:40:47Z

remove files with unknown licenses -- if these are needed, need to resolve 
license issue before re-adding




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #673: add building doc to development ...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/673

add building doc to development page



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol docs-building

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #673


commit 07033d6dc7b93d8aa45b602cd941fbaab491a226
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-13T19:38:39Z

add building doc to development page




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #671: [Backport TC-356] update .rat-ex...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/671


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #671: [Backport TC-356] update .rat-ex...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/671

[Backport TC-356] update .rat-excludes with dirs already vetted for license

(cherry picked from commit b0e72d1807a883524ded209b505761e788652770)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 2.0-rat

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #671


commit 5e9c396325f83f62e7d3d5650bef50f7cc9ba3ec
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-08T23:01:47Z

update .rat-excludes with dirs already vetted for license

(cherry picked from commit b0e72d1807a883524ded209b505761e788652770)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #666: reference github.com/apache in s...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/666

reference github.com/apache in spec files



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol apache-spec

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #666


commit 0ef3b28a20da1a4c030c582e355fbc74a712cd63
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-09T21:40:56Z

reference github.com/apache in spec files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #659: [TC-356] vetted more licenses in...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/659

[TC-356] vetted more licenses in vendored dirs

update .rat-excludes with dirs already vetted for license

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
license-exclude

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #659


commit bc1b2a427bacf2e89c32f6afc898ec6c9546c074
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-06-08T23:01:47Z

update .rat-excludes with dirs already vetted for license




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #602: Change Traffic Ops password hash...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/602#discussion_r120945531
  
--- Diff: traffic_ops/install/bin/_postinstall ---
@@ -28,7 +28,7 @@ use DBI;
 use POSIX;
 use File::Basename qw{dirname};
 use File::Path qw{make_path};
-use Digest::SHA1 qw(sha1_hex);
+use Crypt::ScryptKDF qw(scrypt_hash);
--- End diff --

not sure how I missed that.. thanks..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #602: Change Traffic Ops password hash...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/602#discussion_r120941858
  
--- Diff: traffic_ops/install/bin/_postinstall ---
@@ -28,7 +28,7 @@ use DBI;
 use POSIX;
 use File::Basename qw{dirname};
 use File::Path qw{make_path};
-use Digest::SHA1 qw(sha1_hex);
+use Crypt::ScryptKDF qw(scrypt_hash);
--- End diff --

doesn't appear to be in there..   please add to that module to 
`traffic_ops/app/cpanfile`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #627: Change Traffic Ops to hide sensitive da...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/627
  
conflicts with master -- please resolve these...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #602: Change Traffic Ops password hash...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/602#discussion_r120910642
  
--- Diff: traffic_ops/install/bin/_postinstall ---
@@ -28,7 +28,7 @@ use DBI;
 use POSIX;
 use File::Basename qw{dirname};
 use File::Path qw{make_path};
-use Digest::SHA1 qw(sha1_hex);
+use Crypt::ScryptKDF qw(scrypt_hash);
--- End diff --

was this added to the `cpanfile`?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #602: Change Traffic Ops password hash...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/602#discussion_r120910425
  
--- Diff: traffic_ops/app/lib/Utils/Helper.pm ---
@@ -132,4 +134,18 @@ sub error {
);
 }
 
+sub hash_pass {
+   my $pass = shift;
+   return scrypt_hash($pass, \64, 16384, 8, 1, 64);
+}
+
+sub verify_pass {
--- End diff --

how about a comment here describing what's going on?  I assume it's for a 
gradual upgrade -- trying both crypt and sha1 for passwords that haven't been 
upgraded yet..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #626: [Backport TC-228] postinstall im...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/626


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #624: [TC-359] - fixes bug where updat...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/624#discussion_r119262039
  
--- Diff: traffic_ops/app/lib/API/User.pm ---
@@ -579,7 +573,7 @@ sub is_good_password {
return "Your password cannot be the same as your username.";
}
 
-   if ( ( $value ne '' ) && $value !~ qr/^.{8,100}$/ ) {
+   if ( ( $value ne '' ) && ( length($value) < 8 ) ) {
--- End diff --

first part is not necessary..   length('') is zero


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #626: [Backport TC-228] postinstall im...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/626

[Backport TC-228] postinstall improvements



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
2.0-postinstall-cherry-pick

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/626.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #626


commit 1622a6fc4fc16b655d7f76f1d963babdd897ab0d
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-02T16:58:58Z

made changes to support seeds cleanup

(cherry picked from commit d3bbaec410536737ab7d3e6d3ed6bfa09444806a)

commit 371cdd8a8ee6341b10c008fbdeef1d910dd78538
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-02T17:01:42Z

added Postgres Bootstrap script for streamlining setup

(cherry picked from commit 775078cb15c645a73945aa9a61c6764afb3c0a50)

commit 54248b40730a7f830dc627adf69a54668b055890
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-02T17:07:41Z

added a comment

(cherry picked from commit a8aedf6c2a2b5e95dd53d11bdd79b66203d9dfc3)

commit 917cdf1199f58fc1431f84372b9bd03de1611d20
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-02T17:10:15Z

moved the gopath to /opt/traffic_ops/go

(cherry picked from commit 16b300c9d57998502fcd35a7ca6b0dd37e743765)

commit e9f988751172c5a8bbfe4e3d1d095e79c65ccfe8
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-03T16:47:54Z

updated to fix the insert admin sequence

(cherry picked from commit a021bcd5136479bd41413fb3f5a96348493f8270)

commit 63076f5c4df416aebbe1e3ecdecaa56870ead555
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-03T16:48:30Z

added description

(cherry picked from commit 3336900eba560a3ee45f042c91004ec5795de3d3)

commit 4b241d001a7eda7367627e7bb5c05011aa3645c7
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-08T23:23:12Z

bypass preprocessing for postinstall if -h or -defaults flags passed

(cherry picked from commit 88323e2f9bf71f91d82cb32a988e0dd06f953bb0)

commit 2df75f0f7a720c6a12a68d0e87678259611bf934
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-12T14:53:30Z

fixed issue where the wrong conf file was being read

(cherry picked from commit 5ef3d40f2edf01b0345f0e7e31e7627b7f8278f9)

commit 6d910212cef69d51587b7ce5213e03e7c2c4f505
Author: Chris Lemmons <alfic...@gmail.com>
Date:   2017-03-10T20:20:51Z

Updated default build instructions to refer to the build script.

(cherry picked from commit 3bf7ab8fcd94419c3e7c1bed73051cd83477f05c)

commit 0983a95687004628fbddaa2e7f01b128a714c748
Author: Chris Lemmons <alfic...@gmail.com>
Date:   2017-03-15T19:33:08Z

Update pkg script to pull docker-compose into a local container if it is 
unavailable in the path.

(cherry picked from commit 4b4be596d0bbaae7f67622062d32a9097dd64438)

commit 0cff28a44c1d4842add1f8c4013f435f79247837
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-12T14:55:17Z

fixed formatting

(cherry picked from commit 33df0cac9ea0d98f2d3acaf5d540d6b7c4d4f9a7)

commit 22f110f4177144eaf3a213b81d9fbb2e3ff27f0a
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-12T14:55:49Z

removed debug

(cherry picked from commit 852ce2d96478ca39465dc5464a284451e7753a4a)

commit 11eef7a7622de38918db7101fab955f35ed9c583
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-16T18:08:26Z

remove Snapshots from tar backup when upgrading

(cherry picked from commit 50d2c3fe5f29bb7aa2ba1235ab24fa64e3539bd0)

commit 09f5ecb7d6a7e0a8d9d3853f4e75b47f42930a87
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-16T21:00:15Z

app/db/reset.sh was removed -- remove from spec

(cherry picked from commit 91685068ecc63b9a3f22692e35534d797cbbcc7e)

commit af799a41e559297c9ceee21105b97f72211f0549
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-22T13:34:38Z

Fixed the Use of uninitialized value in concatenation (.) or string at

(cherry picked from commit 610c6c22f44a221206e4e53b69e0c0c806c32793)

commit a7e1dcb2e14c6f841ff30fa629330d96237fe860
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-22T19:56:54Z

moved the toolname and instance name back into seeds for postinstall 
simplicity

(cherry picked from commit f868cae629d9513db66713ad3d89d443bd1c927a)

commit 96769555f41e85c16c2c703fa6fc045bf282929f
Author: Dewayne Richardson <dewr...@apache.org>
Date:   2017-05-22T20:07:31Z

added to make postgresql96 

[GitHub] incubator-trafficcontrol issue #609: TC-225: TO Html fix

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/609
  
This should be cherry-picked into 2.0.x.  Ping me if you need help with 
that...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #618: clean_build.sh no longer tromps ...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/618

clean_build.sh no longer tromps parallel builds



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
fix/cleanbuild

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/618.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #618


commit ab4f1f489d01d3d6a3bad04c715d5797c1fc7edb
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-25T15:30:10Z

clean_build.sh no longer tromps parallel builds




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #613: [Backport TC-228] postinstall im...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/613


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #612: [TC-228] postinstall updates

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/612

[TC-228] postinstall updates

fixes check for db connection -- sensible error.
fixes traffic_ops build issue

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
fix/goose-postinstall

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #612


commit b66bc44028eea220d180da433f34e00c60832700
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-24T14:59:51Z

clean up handling of dist dir during build

commit 349c4af05a7ec631d00804dd497db1ff7798462a
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-24T15:00:07Z

move goose install

commit 539cae4344101b9727e300740b4fb738b771d200
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-24T15:14:50Z

update install instructions

commit 8fe27979b0f4bce6afbd773be1fd55b582044b37
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-24T20:20:55Z

sensible error message when db connect fails

commit 03550d7d6faab8e1407a351215bed536bc6503cc
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-24T21:10:12Z

fix dist dir creation in docker build




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #603: [Backport TC-352] updates jdk ve...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/603

[Backport TC-352] updates jdk version for traffic_monitor and 
traffic_router build

(cherry picked from commit 3c79673851a1c3a7e8349b49673184ba853f1dcb)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol tc-352-2.0

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/603.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #603


commit a1bf6534af960601bb8c2cbcad21c6ac80603950
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-23T16:03:52Z

upgrade jdk download for tm/tr build

(cherry picked from commit 3c79673851a1c3a7e8349b49673184ba853f1dcb)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #601: [TC-352] upgrade jdk download fo...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/601

[TC-352] upgrade jdk download for tm/tr build

previous version disappeared from oracle web site.  Updated to a newer 
version,  but we need to find a better solution.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol tc-352

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/601.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #601


commit 3c79673851a1c3a7e8349b49673184ba853f1dcb
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-23T16:03:52Z

upgrade jdk download for tm/tr build




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #594: [Backport TC-345] source tarball...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/594


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #600: [Backport TC-349] update 2.0.x b...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/600


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #600: [Backport TC-349] update 2.0.x b...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/600

[Backport TC-349] update 2.0.x build scripts

updates build scripts to work more cleanly with Jenkins

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
fix/2.0.x-cleanbuild

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/600.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #600


commit eeaadb23b686e32331788a3759a85cb1d125f05f
Author: Chris Lemmons <alfic...@gmail.com>
Date:   2017-03-10T18:18:57Z

Add global build script.

This splits out the somewhat messy docker build command into its own script 
and adds a global build script.
There’s still work to be done to clean up docker build scripts, but this 
provides a basic way to build top to bottom
In a single, simple command.

This is a step toward addressing TC-180, but falls short of cleaning up 
everything that requires cleaning up.

(cherry picked from commit 63c019e9a2372d704ec68b6c9956d8a9ffed552b)

commit 3c6ecfe157d473c0b27d48b168a7dabce785c2fa
Author: Chris Lemmons <alfic...@gmail.com>
Date:   2017-05-15T20:56:15Z

Fixing licensing issues for bash build scripts.

(cherry picked from commit db88e83124eed190662336ef45e5f497ff5a77e1)

commit 66844a5611d7a650feb66f9f85c784ac24ccddfa
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-22T19:25:42Z

change ownership of build artifacts in dist/. when build complete

(cherry picked from commit 5c8d1e4546cca4c5c2a8de20d78966c418637837)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #599: [Backport] license fixes to be b...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/599

[Backport] license fixes to be backported to 2.0.x

(cherry picked from commit 1ddcd73418bf17450a194cd767370c09763ed1fa)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
fix/2.0.x-license

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/599.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #599


commit 5e41aa60be8aab3a86715f81bbc10e377f34edb5
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-19T22:54:39Z

license fixes to be backported to 2.0.x

(cherry picked from commit 1ddcd73418bf17450a194cd767370c09763ed1fa)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #596: [TC-349] change ownership of bui...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/596

[TC-349] change ownership of build artifacts in dist/. when build complete



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
fix/dist-perms

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/596.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #596


commit 3f4a7083f9c52910e11b828a32f267a8f6581d5e
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-22T19:25:42Z

change ownership of build artifacts in dist/. when build complete




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #595: add missing Apache licenses

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/595

add missing Apache licenses



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol fix/license

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #595


commit 882fc986b76ee90c3a201d5a325c19eca33dc210
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-19T22:54:39Z

license fixes to be backported to 2.0.x

commit f7619d8ed4750e729bcc17628c34e09cbf2e6e7a
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-19T23:33:26Z

add missing license statements

commit 0df9bb8e2cbfa935c816907bc98389aa19e9d564
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-20T01:07:58Z

add license to Dockerfiles

commit 0a21bb6d160aee98292be318a237261258a9c4d1
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-20T03:42:59Z

add license to sql file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #594: [Backport TC-345] source tarball...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/594

[Backport TC-345] source tarball has invalid link

(cherry picked from commit ebfae5038a66a3124a329c9f11c51c705b083dd0)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
fix/2.0-tarball

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/594.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #594


commit 83c3fbb7aff62b15eb356b06db0843c0a32c0807
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-19T19:54:33Z

redo --transform on tar to fix symlink issue

(cherry picked from commit ebfae5038a66a3124a329c9f11c51c705b083dd0)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #593: [TC-345] fix tarball constructio...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/593

[TC-345] fix tarball construction issue with symlinks



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
fix/tarball-link

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/593.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #593


commit 2a8f3b2d7b9074c3fdad2c020ed62c4ceb7e8f74
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-19T19:54:33Z

redo --transform on tar to fix symlink issue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #530: [Backport TC-150] 2.0 document c...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/530


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #531: [Backport] remove KEYS -- stored...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/531


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #532: [Backport TC-167] 2.0.x fix cach...

[dangogh]

Github user dangogh closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/532


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #591: [TC-345] when creating tarball, do not ...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/591
  
to test,  build the tarball:
```
   $ docker-compose -f infrastructure/docker/build/docker-compose.yml run 
source
```
and extract the contents.  There is one symbolic link -- this is prior to 
the fix:
```
   $ tar xf dist/trafficcontrol-2.1.tar.gz -C /tmp
   $ find /tmp/trafficcontrol-incubating-2.1.0 -type l -ls
... 
/tmp/trafficcontrol-incubating-2.1.0/traffic_stats/vendor/github.com/apache/incubator-trafficcontrol/traffic_ops/client
 -> trafficcontrol-incubating-2.1.0/../../../../../../traffic_ops/client
```
After applying the fix,   build the tarball again and extract contents 
again.   The link content 
(`trafficcontrol-incubating-2.1.0/../../../../../../traffic_ops/client`) should 
not have that leading directory name (should be 
`../../../../../../traffic_ops/client`)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #561: Adds documentation for configfil...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/561#discussion_r116837026
  
--- Diff: docs/source/admin/traffic_ops_using.rst ---
@@ -591,6 +592,20 @@ Parameters in the Mid (parent) profile that influence 
this feature:
 | use_ip_address | parent.config | 0   | 1 means use IP(v4) address of 
this parent in the parent.config, 0 means use the host_name.domain_name 
concatenation.  |
 
++---+-+---+
 
+.. _rl-qstring-handling:
+
+Qstring Handling
+
+
+Delivery services have a Query String Handling option that, when set to 
ignore, will automatically add a regex remap to that delivery service's config. 
 There may be times this is not preferred, or there may be requirements for one 
delivery service or server(s) to behave differently.  When this is required, 
the psel.qstring_handling parameter can be set in either the delivery service 
profile or the server profile, but it is important to note that the server 
profile will override ALL delivery services assigned to servers with this 
profile parameter.  If the parameter is not set for the server profile but is 
present for the Delivery Service profile, this will override the setting in the 
delivery service.  A value of "ignore" will not result in the addition of regex 
remap configuration.
+
--- End diff --

can you wrap this at a reasonable width?  A single space change would show 
the whole line as different..



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #577: [TC-281] don't try to backup Sna...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/577

[TC-281]  don't try to backup Snapshots dir when upgrading



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol nomosnapshot

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/577.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #577


commit 0ba02978ab82040bffe2721aaf65f38ce896c769
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-16T18:08:26Z

remove Snapshots from tar backup when upgrading




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #553: prevents DB update error when using old...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/553
  
is this addressing this error? ```[2017-05-08 23:31:17,160] [ERROR] 
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute 
failed: ERROR:  null value in column "reval_pending" violates not-null 
constraint```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #347: Add global build script.

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/347
  
+1 -- add the license headers,  and I also think it should be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #486: [TC-82] - removes duplicate apis

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/486
  
do we know if anyone might be using these?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #539: [TC-260] stash cdn and profile l...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/539

[TC-260] stash cdn and profile lists for DeliveryService#create

`cdns` and `profiles` were missing from the stash -- that's what caused the 
crash

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol tc-260

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/539.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #539


commit bcc65d5fdb03963ce1e1072d47b37601112edf05
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-02T20:28:26Z

stash cdn and profile lists for DeliveryService#create




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #535: adds secondary psel qstring handling at...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/535
  
where's the Jira issue for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #535: adds secondary psel qstring hand...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/535#discussion_r114337134
  
--- Diff: traffic_ops/app/lib/UI/ConfigFiles.pm ---
@@ -852,18 +852,47 @@ sub hosting_dot_config {
return $text;
 }
 
-sub storage_dot_config_volume_text {
+sub storage_dot_config_letter_to_id_mapping($$@) {
+   my $letters  = shift;
+   my $hash_key_ids = shift;
+   my @postfix  = @_;
+   my %mapping;
+
+   if (defined($hash_key_ids)) {   
+   my @tmp_list = split( /,/, $hash_key_ids);  
+
+   # find the minimum of the two list sizes
--- End diff --

I can see that's what you're trying to do -- but why?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #535: adds secondary psel qstring hand...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/535#discussion_r114338121
  
--- Diff: traffic_ops/app/lib/UI/ConfigFiles.pm ---
@@ -852,18 +852,47 @@ sub hosting_dot_config {
return $text;
 }
 
-sub storage_dot_config_volume_text {
+sub storage_dot_config_letter_to_id_mapping($$@) {
+   my $letters  = shift;
+   my $hash_key_ids = shift;
+   my @postfix  = @_;
+   my %mapping;
+
+   if (defined($hash_key_ids)) {   
+   my @tmp_list = split( /,/, $hash_key_ids);  
+
+   # find the minimum of the two list sizes
--- End diff --

just spent 5 minutes figuring out what this method is doing.   Figured that 
out,  but I still don't know why -- comments needed,  please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #532: [Backport TC-167] 2.0.x fix cach...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/532

[Backport TC-167] 2.0.x fix cachegroupparameter.t



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
2.0-fix-old-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/532.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #532


commit 628dc8ee612fad550966676376416ed15e2b3deb
Author: Jan van Doorn <j...@apache.org>
Date:   2017-02-25T22:16:42Z

[TC-167] fix old test; not sure how it ever worked.

(cherry picked from commit aa01b7c0f5563164e0f864a5e3009db42d3ca425)

commit 30e2f807b6db464bf43a86eec2797384637c6b63
Author: Jan van Doorn <j...@apache.org>
Date:   2017-02-27T14:52:01Z

Order of second thing is still arbitrary

(cherry picked from commit 89e64ecb1bcc1dfc7df08162088394b73e6766b3)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #531: remove KEYS -- stored in dist.ap...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/531

remove KEYS -- stored in dist.apache.org svn repo



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
2.0-remove-KEYS

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/531.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #531


commit 3329cb0bdc656ef7973f00aeac273e3dbbb71a99
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-05-01T16:00:10Z

remove KEYS -- stored in dist.apache.org svn repo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #530: [Backport TC-150] 2.0 document c...

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/530

[Backport TC-150] 2.0 document cert generation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
2.0-document-cert

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/530.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #530


commit 788bb7cba492bcf1f207438dad358c54097183a0
Author: Robert Scrimo <robert_scr...@comcast.com>
Date:   2017-03-27T22:28:08Z

Added manual procedure for generating dev and prod certs in traffic ops 
install wiki.

(cherry picked from commit 16fa0ea8835adabd64a9fe4e378762bee86af35b)

commit fb89ebddccdebedb876dab3ea5885bb1384f9434
Author: Robert Scrimo <robert_scr...@comcast.com>
Date:   2017-03-28T00:52:14Z

Minor change to a note.

(cherry picked from commit 49177a734e24cad85e772255fb3195c68b6a7ba1)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #526: [TC-64] - TO exp - fixes respons...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/526#discussion_r113956455
  
--- Diff: traffic_ops/experimental/ui/app/src/styles/main.scss ---
@@ -140,3 +139,10 @@ body.nav-sm .container.body .main-content {
   }
 
 }
+
+@media(min-width:992px) {
--- End diff --

is that @ sign supposed to be there?   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #528: [TC-258] Kabletown fixes

[dangogh]

GitHub user dangogh opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/528

[TC-258] Kabletown fixes



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dangogh/incubator-trafficcontrol 
kabletown-fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #528


commit 5b0a3c5d74b3dfaf1182abe673fe8c9293dd6645
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-04-27T21:56:22Z

removes unused schema files

commit 2564ccd05c229944ea8c1c7852211ef2880599b2
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-04-27T22:15:25Z

make params unique in fixtures by modifying values

commit 9678f801b1e7dec1f64623cd1486bd56bc09e39e
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-04-27T22:16:11Z

use DBIx methods to get list of tables to delete; use truncate instead of 
delete_all




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #506: removed questions from postinsta...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/506#discussion_r113808973
  
--- Diff: traffic_ops/install/bin/migratedb ---
@@ -30,3 +30,12 @@ if ($result != 0) {
 else {
print "Successfully migrated the database.\n";
 }
+
+$result = InstallUtils::execCommand ("export 
PATH=/opt/traffic_ops/install/bin:/usr/bin/; export 
PERL5LIB=/opt/traffic_ops/install/lib:/opt/traffic_ops/app/local/lib/perl5:/opt/traffic_ops/app/lib;
 cd /opt/traffic_ops/app; /usr/bin/perl db/admin.pl --env=production 
seed_demo");
+
--- End diff --

`seed_demo`?  in `migratedb`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/522
  
and for the DS without a profile,  I failed to put in a regex and got a 
crash rather than an error popup:

```Traffic Ops fatal error occurred while processing your request. 
Error at line 28 ($morbo->run($app);) 

Please supply a host regular expression at 
.../incubator-trafficcontrol/traffic_ops/app/lib/MojoPlugins/DeliveryService.pm 
line 178. 

 called at 
.../incubator-trafficcontrol/traffic_ops/app/lib/UI/DeliveryService.pm line 385
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...

[dangogh]

Github user dangogh commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/522
  
not certain I'm doing it right, but trying to test the manage ssl certs,  I 
hit this error: ```Traffic Ops fatal error occurred while processing your 
request. 
Error at line 242 ( my $profile = $self->db->resultset('Profile')->search( 
{ id => $profile_id }, { prefetch => ['cdn'] } )->single();) 
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st 
execute failed: ERROR: column reference "id" is ambiguous LINE 1: ...e me LEFT 
JOIN cdn cdn ON cdn.id = me.cdn WHERE ( id IS NULL... ^ [for Statement "SELECT 
me.id, me.name, me.description, me.last_updated, me.type, me.cdn, cdn.id, 
cdn.name, cdn.last_updated, cdn.dnssec_enabled, cdn.domain_name FROM profile me 
LEFT JOIN cdn cdn ON cdn.id = me.cdn WHERE ( id IS NULL )"] at 
/home/dkirkw202/incubator-trafficcontrol/traffic_ops/app/lib/UI/DnssecKeys.pm 
line 242```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---