[GitHub] trafficserver issue #1492: Fix for ignored return value in Ubuntu builds.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1492 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/181/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1492: Fix for ignored return value in Ubuntu builds.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1492 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1511/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1492: Fix for ignored return value in Ubuntu builds.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1492 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1616/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1492: Fix for ignored return value in Ubuntu builds.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1492 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/49/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1471: is_transparent_passthrough_allowed always returns...

Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1471 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver pull request #1492: Fix for ignored return value in Ubuntu bui...

GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/1492 Fix for ignored return value in Ubuntu builds. I think this is the problem with the Ubuntu builds. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...

Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1479 Gah, what a tarpit. The conflict resolution collided with another override update and that caused the regression test failure. Should be fixed now. --- If your project is set up for

[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/180/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1510/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1615/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/48/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...

Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1479 I guess. I don't really think this is all that much better than the template logic, except that it's easier to understand for non template people. --- If your project is set up for

[GitHub] trafficserver issue #1491: MemView: Fix strlen issue for OmniOS.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1491 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/179/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1491: MemView: Fix strlen issue for OmniOS.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1491 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/47/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1491: MemView: Fix strlen issue for OmniOS.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1491 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1509/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1491: MemView: Fix strlen issue for OmniOS.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1491 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1614/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #1491: MemView: Fix strlen issue for OmniOS.

GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/1491 MemView: Fix strlen issue for OmniOS. Rather than put `ink_platform.h` in the header file, the construct using `strlen` was moved to the implementation file and `ink_platform.h`

[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory

Github user dragon512 commented on the issue: https://github.com/apache/trafficserver/pull/1465 I am not sure why it should be under "ci" tree. That is stuff for the open source CI system. Why would tests for ATS go under the ci data file? Tests are for developer, not the ci system.

[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1465 Should this be in the "ci" tree rather that its own top-level tree? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1479 @SolidWallOfCode If you fix the merge conflicts now, I'll +1 this against my better judgement :-). --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1490: Inconsistent "exit" strategy on remap.config (and...

GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1490 Inconsistent "exit" strategy on remap.config (and possibly other configurations) It seems, remap.config will allow some bad configurations to still startup, but not others. This seems

[GitHub] trafficserver pull request #1488: This allows old ssl_multicert.config to st...

Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1488 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1489: Change default for proxy.config.ssl.server.multic...

GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1489 Change default for proxy.config.ssl.server.multicert.exit_on_load_fail to "1" The default behavior is inconsistent with how the rest of ATS works, so I think we should change this to "1".

[GitHub] trafficserver issue #1488: This allows old ssl_multicert.config to still fun...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1488 I'm gonna close this PR for now, I think this code could be cleaned up, but setting proxy.config.ssl.server.multicert.exit_on_load_fail=1 seems to behave more reasonable than the defaults.

[GitHub] trafficserver issue #1427: Crash in ATSConsistentHash::lookup_by_hashval

Github user randall commented on the issue: https://github.com/apache/trafficserver/issues/1427 @jrushford This is with OEL 6.5 and gcc 4.9.3. The environment and compiler for us is still the same between running 6.1.x and 7.0.0. I can't attach the full parent config, but

[GitHub] trafficserver issue #1488: This allows old ssl_multicert.config to still fun...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1488 I see now, there's a new configuration, proxy.config.ssl.server.multicert.exit_on_load_fail, which would exit on load errors. Surprised that this is not the default to "1" though.

[GitHub] trafficserver pull request #1488: This allows old ssl_multicert.config to st...

Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1488#discussion_r103039976 --- Diff: iocore/net/SSLUtils.cc --- @@ -2007,7 +2007,10 @@ SSLParseCertificateConfiguration(const SSLConfigParams *params, SSLCertLookup *l

[GitHub] trafficserver pull request #1488: This allows old ssl_multicert.config to st...

Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1488#discussion_r103039820 --- Diff: iocore/net/SSLUtils.cc --- @@ -2007,7 +2007,10 @@ SSLParseCertificateConfiguration(const SSLConfigParams *params, SSLCertLookup *l

[GitHub] trafficserver issue #1488: This allows old ssl_multicert.config to still fun...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1488 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/178/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #1488: This allows old ssl_multicert.config to st...

Github user shinrich commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1488#discussion_r103023456 --- Diff: iocore/net/SSLUtils.cc --- @@ -2007,7 +2007,10 @@ SSLParseCertificateConfiguration(const SSLConfigParams *params, SSLCertLookup *l

[GitHub] trafficserver issue #1488: This allows old ssl_multicert.config to still fun...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1488 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1508/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1488: This allows old ssl_multicert.config to still fun...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1488 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/46/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory

Github user dragon512 commented on the issue: https://github.com/apache/trafficserver/pull/1465 I just pushed a fix for CentOs and RHEL system to bootstrap better. I believe this should take care of the issue @jpeach reported given was running on one of those systems --- If your

[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory

Github user dragon512 commented on the issue: https://github.com/apache/trafficserver/pull/1465 @bryancall So from what I can see at the moment. master is broken. 7.1 is working fine minus the custom logfile test. The remap_http and header-rewrite fail with - <

[GitHub] trafficserver issue #1488: This allows old ssl_multicert.config to still fun...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1488 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1613/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #1488: This allows old ssl_multicert.config to st...

GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1488 This allows old ssl_multicert.config to still function on reload The problem is that if a certificate fails to load, for whatever reason that might be, ATS still switches the configuration,

[GitHub] trafficserver issue #1209: Remove unused and never to be used classes from M...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1209 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/177/ for details. --- If your project is set up for it, you can reply to this email

Build failed in Jenkins: ubuntu_16_10-master » gcc,ubuntu_16_10,release #144

See -- [...truncated 228.96 KB...] depbase=`echo Diags.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/bash ../../libtool

[GitHub] trafficserver issue #1264: TS-3692: Remove code associated with proxy.config...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1264 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/176/ for details. --- If your project is set up for it, you can reply to this email

Build failed in Jenkins: ubuntu_14_04-master » gcc,ubuntu_14_04,release #2460

See -- [...truncated 224.27 KB...] /bin/bash ../../libtool --tag=CXX --mode=compile ccache c++ -DHAVE_CONFIG_H -I.

[GitHub] trafficserver issue #1209: Remove unused and never to be used classes from M...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1209 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1612/ for details. --- If your project is set up for it, you can reply to this email and have your

Build failed in Jenkins: ubuntu_16_04-master » gcc,ubuntu_16_04,release #593

See -- [...truncated 227.54 KB...] depbase=`echo ContFlags.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/bash ../../libtool

Build failed in Jenkins: ubuntu_12_04-master » gcc,ubuntu_12_04,release #2232

See -- [...truncated 230.02 KB...] libtool: compile: ccache /usr/bin/g++-4.9 -DHAVE_CONFIG_H -I. -I../../../lib/ts

[GitHub] trafficserver issue #1209: Remove unused and never to be used classes from M...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1209 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1507/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1267 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1610/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1264: TS-3692: Remove code associated with proxy.config...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1264 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1611/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #1482: MemView: Change typed array access method ...

Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/1482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver issue #1264: TS-3692: Remove code associated with proxy.config...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1264 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1506/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1267 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1505/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1209: Remove unused and never to be used classes from M...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1209 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/45/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1264: TS-3692: Remove code associated with proxy.config...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1264 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/44/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1267 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/43/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1264: TS-3692: Remove code associated with proxy.config...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1264 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1267 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] trafficserver issue #1209: Remove unused and never to be used classes from M...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1209 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] trafficserver issue #1158: TS-5015: Convert storage configuration file to Lu...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1158 I still think we need to have a discussion on what these new "Lua" style configs should be named, such that we don't have to come up with contrived renaming. I'm ok with a prefix of any of

[GitHub] trafficserver issue #1114: TS-4976: Remove useless casts from plugins.

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1114 This needs rebasing and then I'll +1 it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #1483: HTTP Request Debugging Feature

Github user chenglongwei commented on the issue: https://github.com/apache/trafficserver/issues/1483 Hi @zwoop @jpeach @SolidWallOfCode , could you give some feedbacks. This debug feature is very useful when dealing with plugin-related bugs and help us make sense of various changes

[GitHub] trafficserver issue #1487: esi/combo_handler plugin doesn't register

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1487 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/173/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1487: esi/combo_handler plugin doesn't register

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1487 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/174/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1487: esi/combo_handler plugin doesn't register

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1487 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/41/ for details. --- If your project is set up for it, you can reply to this email and have your

Build failed in Jenkins: ubuntu_16_10-master » gcc,ubuntu_16_10,release #143

See -- [...truncated 227.57 KB...] depbase=`echo ContFlags.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/bash ../../libtool

Build failed in Jenkins: ubuntu_14_04-master » gcc,ubuntu_14_04,release #2459

See -- [...truncated 225.10 KB...] mv -f $depbase.Tpo $depbase.Plo depbase=`echo ConsistentHash.lo | sed

[GitHub] trafficserver issue #1487: esi/combo_handler plugin doesn't register

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1487 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1503/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1487: esi/combo_handler plugin doesn't register

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1487 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1504/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1487: esi/combo_handler plugin doesn't register

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1487 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/42/ for details. --- If your project is set up for it, you can reply to this email and have your

Build failed in Jenkins: ubuntu_12_04-master » gcc,ubuntu_12_04,release #2231

See -- [...truncated 230.02 KB...] libtool: compile: ccache /usr/bin/g++-4.9 -DHAVE_CONFIG_H -I. -I../../../lib/ts

Build failed in Jenkins: ubuntu_16_04-master » gcc,ubuntu_16_04,release #592

See -- [...truncated 227.53 KB...] depbase=`echo ContFlags.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/bash ../../libtool

[GitHub] trafficserver issue #1487: esi/combo_handler plugin doesn't register

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1487 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1609/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1486: esi/combo_handler plugin doesn't call TSPluginReg...

Github user danobi closed the issue at: https://github.com/apache/trafficserver/issues/1486 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver pull request #1487: esi/combo_handler plugin doesn't register

Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/1487 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver issue #1487: esi/combo_handler plugin doesn't register

Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1487 Apparently no one uses ComboHandler, if this wasn't noticed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1487: esi/combo_handler plugin doesn't register

GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/1487 esi/combo_handler plugin doesn't register The plugin doesn't call TSPluginRegister. The causes ATS to crash upon startup if combo_handler is enabled. See issue #1486. You can

[GitHub] trafficserver issue #1486: esi/combo_handler plugin doesn't call TSPluginReg...

GitHub user danobi opened an issue: https://github.com/apache/trafficserver/issues/1486 esi/combo_handler plugin doesn't call TSPluginRegister This causes ATS to crash if ATS is run with combo_handler. --- If your project is set up for it, you can reply to this email