[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1589/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1692/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 RAT check *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/11/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 RAT check *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/10/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1546 Should this go into 7.1.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1471: is_transparent_passthrough_allowed always returns...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1471 Linux build *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/9/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1473: Avoid forcing "proxied URL" in case of transparen...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1473 Linux build *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/8/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 Linux build *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/7/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Linux build *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/6/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1517 Linux build *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/5/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1521 Linux build *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/3/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1520: Report protocol in request via header

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1520 Linux build *failed*! See https://ci.trafficserver.apache.org/job/RAT-github/4/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 Linux build *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/2/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1534 Linux build *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/1/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-07 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r104771989 --- Diff: plugins/esi/combo_handler.cc --- @@ -187,6 +207,94 @@ InterceptData::~InterceptData() } } +void

[GitHub] trafficserver issue #1485: back port "fix TS-4195: double free when stop tra...

2017-03-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1485 So, my bad, but we reverted this on master, because of issues raised on the use of _exit(). Also, not sure I agree that the ICC changes should be rolled into this (if we were to back port

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1548 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/255/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1548 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1587/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1548 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/123/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1548 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1691/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1547 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/254/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #1548: Insure that parent health stats are update...

2017-03-07 Thread jrushford
GitHub user jrushford opened a pull request: https://github.com/apache/trafficserver/pull/1548 Insure that parent health stats are updated properly on a markdown Parents may be marked down prematurely because the health stats are not reset when the retry window has elapsed. This

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1547 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1690/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1547 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/122/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1547 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1586/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1547: Fix ssl hook state logic.

2017-03-07 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/1547 Fix ssl hook state logic. Was not correctly resetting the ssl hook state after the servername hooks. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] trafficserver pull request #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

2017-03-07 Thread shinrich
Github user shinrich commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1446#discussion_r104750433 --- Diff: iocore/net/SSLNetVConnection.cc --- @@ -1438,17 +1438,22 @@ bool SSLNetVConnection::callHooks(TSEvent eventId) { // Only

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-03-07 Thread jaaju
Github user jaaju commented on the issue: https://github.com/apache/trafficserver/pull/1457 @zizhong you need to call `exit` for normal process termination in case of SIGTERM so ASAN leak detection report is available. But since you can not call `exit` from the signal handler, what

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

2017-03-07 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1522 I ran my production box overnight with the latest work around. I think this change is a step in the right direction and we should merge it and bring it back to 7.1. --- If your project

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

2017-03-07 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1522 I think the issue raised by @scw00 is different. It looks like what @zwoop identified in issue #1531. In that case the write vio errored, so the write vio is being sent up as data to a

[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-07 Thread mlibbey
Github user mlibbey commented on the issue: https://github.com/apache/trafficserver/pull/1534 I'm terrible at reading RFC docs, so, fwiw, the Via header structure is described here: https://tools.ietf.org/html/rfc7230#section-5.7.1 --- If your project is set up for it, you can

[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

2017-03-07 Thread maskit
Github user maskit commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1534#discussion_r104723567 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -685,6 +687,23 @@ HttpTransactHeaders::insert_server_header_in_response(const char *server_tag, in

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

2017-03-07 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1537 Allright. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

2017-03-07 Thread maskit
Github user maskit commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1534#discussion_r104721541 --- Diff: proxy/http/HttpSM.cc --- @@ -8057,14 +8059,13 @@ HttpSM::is_redirect_required() // Fill in the client protocols used. Return the

[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1534 It even works: ``` odin (08:54) 283/0 $ curl -D - -o /dev/null -s https://www.ogre.com/ | grep Via: Via: http/1.1 tls/1.2 tcp ipv4 Cosmo (ApacheTrafficServer/7.2.0 [cRs f ])

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

2017-03-07 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/1537 Could you also update the documentation? ``` $ git grep basic-auth.c doc doc/developer-guide/plugins/example-plugins/basic-authorization/index.en.rst:The sample basic

[GitHub] trafficserver issue #1544: AddressSanitizer failed to deallocate

2017-03-07 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1544 What version are you running? I am seeing the same errors with 7.1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...

2017-03-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1521 ping @bryancall @SolidWallOfCode ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/253/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/252/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/121/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1585/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1689/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1546 /cc @lstipakov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1546 This is update for TS-3456: SSL blind tunnel sometime not created (57a53649acfbc7b1cb3d828f47457aad335936bd) --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/120/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1688/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1584/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/251/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1583/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/119/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-07 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1546 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1687/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #1546: NetVC maybe lost from read_ready_list if P...

2017-03-07 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/1546 NetVC maybe lost from read_ready_list if Plugin call TSVConnReenable() You can merge this pull request into a Git repository by running: $ git pull

[GitHub] trafficserver pull request #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

2017-03-07 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1446#discussion_r104651844 --- Diff: iocore/net/SSLNetVConnection.cc --- @@ -1438,17 +1438,22 @@ bool SSLNetVConnection::callHooks(TSEvent eventId) { // Only

[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

2017-03-07 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1446 @shinrich Maybe the SSL_CTX_set_early_cb() is better than SSL_CTX_set_tlsext_servername_callback() ? Only one plugin could hook on the TS_SSL_SERVERNAME_HOOK since the

<    1   2