[GitHub] trafficserver issue #1304: ATS 6.1.1 -- Found some orphaned connections afte...

2017-01-06 Thread pbchou
GitHub user pbchou opened an issue: https://github.com/apache/trafficserver/issues/1304 ATS 6.1.1 -- Found some orphaned connections after sending 403-response to the client. We have ATS 6.1.1 (running under Linux RH72) configured as a reverse proxy. If the client requests a URL

[GitHub] trafficserver pull request #1213: TS-4728 Null pointer error in LogHost.cc (...

2016-11-08 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/1213 TS-4728 Null pointer error in LogHost.cc (backport 6.2.x) @PSUdaemon -- As requested, this is a PR to backport the commits for this issue to 6.2.x. However, I'm not sure that I can fully

[GitHub] trafficserver issue #1044: TS-4888: Modified collapsed_forwarding plugin to ...

2016-11-01 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/1044 @brkishore -- I did the following on my back-port PRs -- - git checkout \<feature-branch-under-6.2.x-branch\> - git log (to identify SHA1 of the last commit before my commits)

[GitHub] trafficserver issue #845: TS-3245: Allow multiple plugins to safely use geto...

2016-11-01 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/845 @PSUdaemon - Resubmitted this PR branch as requested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1027: TS-4498 Remap plugin initialization failure error...

2016-11-01 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/1027 Confirmed no conflict on the cherry-picked commit. The second commit was due to clang-format differences between 7.0.x and 6.2.x. --- If your project is set up for it, you can reply

[GitHub] trafficserver issue #1026: TS-4475 Fix Log Collation Crash (back-port).

2016-11-01 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/1026 Confirmed no conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1041: TS-4887 : Clean up Parent Selection URL feature

2016-09-22 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/1041 @jrushford -- Please indicate whether you want to retain the cache_lookup URL pointer to be passed along with the parent selection URL pointer in the HTTP request data. I added this since you

[GitHub] trafficserver pull request #1041: TS-4887 : Clean up Parent Selection URL fe...

2016-09-22 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/1041 TS-4887 : Clean up Parent Selection URL feature * Updated TS API manual page. * Renamed 'tmp' variable in ParentConsistentHash::getPathHash(). * Clean up debug messages (some

[GitHub] trafficserver issue #1009: TS-4853 : Parent Consistent Hash Selection - add ...

2016-09-16 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/1009 @jrushford -- Please pardon me for asking, but I am curious. Is there a reason we can't use "squash and merge" [https://help.github.com/articles/about-pull-request-merges/](ur

[GitHub] trafficserver pull request #1027: TS-4498 Remap plugin initialization failur...

2016-09-15 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/1027 TS-4498 Remap plugin initialization failure error messages (back-port). @jpeach -- James, we would like to request a back-port of this commit to 6.2.x. Thanks. You can merge this pull

[GitHub] trafficserver pull request #1026: TS-4475 Fix Log Collation Crash (back-port...

2016-09-15 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/1026 TS-4475 Fix Log Collation Crash (back-port). @shinrich @oknet -- Susan, this PR is just a back-port to 6.2.x of the Log Collation crash fix. I believe Oknet already +1 the back-port as part

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-09-14 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/834 @jrushford -- I see they branched 7.0.x already. Would this PR get merged into both master and 7.0.x or did we miss the boat? Also, please see the regression test cases that I added at your

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-09-12 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/834 @jrushford -- Added regression test cases for "-R3 -r PARENTSELECTION". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] trafficserver pull request #1009: TS-4853 : Parent Consistent Hash Selection...

2016-09-12 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/1009 TS-4853 : Parent Consistent Hash Selection - add parent selection URL and API. Adds a parent selection URL to be used in generating the hash in the Parent Consistent Hash Selection feature

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-09-12 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/834 @jrushford -- The API enhancements have been removed (moved into TS-4853). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #834: TS-4707 : Parent Consistent Hash Selection ...

2016-09-12 Thread pbchou
Github user pbchou commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/834#discussion_r78413984 --- Diff: proxy/ParentConsistentHash.cc --- @@ -63,21 +66,104 @@ ParentConsistentHash::getPathHash(HttpRequestData *hrdata, ATSHash64 *h

[GitHub] trafficserver pull request #834: TS-4707 : Parent Consistent Hash Selection ...

2016-09-12 Thread pbchou
Github user pbchou commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/834#discussion_r78412433 --- Diff: proxy/ParentConsistentHash.cc --- @@ -63,21 +66,104 @@ ParentConsistentHash::getPathHash(HttpRequestData *hrdata, ATSHash64 *h

[GitHub] trafficserver pull request #834: TS-4707 : Parent Consistent Hash Selection ...

2016-09-12 Thread pbchou
Github user pbchou commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/834#discussion_r78411346 --- Diff: doc/admin-guide/files/parent.config.en.rst --- @@ -225,6 +225,60 @@ The following list shows the possible actions and their allowed values

[GitHub] trafficserver pull request #834: TS-4707 : Parent Consistent Hash Selection ...

2016-09-12 Thread pbchou
Github user pbchou commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/834#discussion_r78410695 --- Diff: proxy/ControlMatcher.h --- @@ -136,7 +137,16 @@ class HttpRequestData : public RequestData inkcoreapi sockaddr const *get_ip

[GitHub] trafficserver issue #831: TS-4475: Log Collation Client SM, added VC_EVENT_I...

2016-09-09 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/831 @shinrich @oknet @zwoop -- Susan, are you the one assigned to do the merge? I think Oknet is okay with this, but I don't think we have your final thumbs up yet. --- If your project is set up

[GitHub] trafficserver pull request #834: TS-4707 : Parent Consistent Hash Selection ...

2016-09-09 Thread pbchou
Github user pbchou commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/834#discussion_r78266512 --- Diff: proxy/ParentConsistentHash.cc --- @@ -64,23 +67,127 @@ ParentConsistentHash::getPathHash(HttpRequestData *hrdata, ATSHash64 *h) const

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-09-09 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/834 @PSUdaemon @jpeach @zwoop @jrushford -- Phil, please see the changes that you recommended. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-09-09 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/834 @PSUdaemon @jpeach @zwoop @jrushford -- Phil, please see the changes that you recommended. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-09-08 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/834 @jpeach @zwoop @jrushford -- James, please see the changes that you requested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-09-07 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/834 @jrushford -- I pushed a new commit with your recommended changes. I didn't squash it yet so you can see just the diff from what you reviewed earlier. I also updated the API and Lua API

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-09-07 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/834 @jrushford -- Thanks for taking a look, but can we hold off on squashing commits until the branch is finalized (or alternatively just squash as part of the merge with "git merge --squash

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-09-01 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/834 @zwoop @jrushford -- I pushed another commit which removes the use of the MIME header. It adds pointers to the HttpTransact::State's cache_info.lookup_url and cache_info.parent_selection_url

[GitHub] trafficserver issue #831: TS-4475: Log Collation Client SM, added VC_EVENT_I...

2016-09-01 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/831 @zwoop @oknet @shinrich -- I updated the documentation per Oknet's request. If everyone is good with this, then just a reminder that we also request that this should be back-ported 6.2.x

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-08-31 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/834 @jrushford -- I did consider something similar before going with the MIME header approach. I also considered extending the HttpRequestHeader with additional data elements. It seems

[GitHub] trafficserver issue #831: TS-4475: Log Collation Client SM, added VC_EVENT_I...

2016-08-31 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/831 @shinrich @oknet -- Hi. Did you get a chance to look at the latest changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #945: TS-4799: Allow minimum log rolling period t...

2016-08-30 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/945 TS-4799: Allow minimum log rolling period to be as low as 30s. Change the minimum allowed log rolling period from 60s to 30s. You can merge this pull request into a Git repository by running

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-08-24 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/834 @jrushford @zwoop Hi has anyone had a chance to review this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #831: TS-4475: Log Collation Client SM, added VC_EVENT_I...

2016-08-22 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/831 @shinrich @oknet -- Please see the updated PR. I added the same event handling to the host side. I also added two records.config options to make the time-out configurable on the host

[GitHub] trafficserver issue #831: TS-4475: Log Collation Client SM, added VC_EVENT_I...

2016-08-09 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/831 Hi all. I updated the PR. The fix now does (1) handles both active time-out and inactivity time-out, (2) treats time-outs the same as EOS or ERROR events to handle any clean-ups, and (3

[GitHub] trafficserver pull request #845: TS-3245: Allow multiple plugins to safely u...

2016-08-08 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/845 TS-3245: Allow multiple plugins to safely use getopt(3). Request back-port to 6.2.x branch. This was cherry-picked from "master", and it was clean except for some spacing issues

[GitHub] trafficserver issue #844: TS-4411 : Added an error message if an unrecognize...

2016-08-08 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/844 I see this is marked incompatible so I guess no back-port... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver pull request #844: TS-4411 : Added an error message if an unre...

2016-08-08 Thread pbchou
Github user pbchou closed the pull request at: https://github.com/apache/trafficserver/pull/844 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #844: TS-4411 : Added an error message if an unre...

2016-08-08 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/844 TS-4411 : Added an error message if an unrecognized '@...' remap Request back-port to 6.2.x branch. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] trafficserver issue #831: TS-4475: Log Collation Client SM, added VC_EVENT_I...

2016-08-05 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/831 @shinrich Thanks for your comments. I have been working with Oknet Xu on the Jira thread regarding this. I will combine the recommendations. Oknet also recommended to set a custom inactivity

[GitHub] trafficserver pull request #834: TS-4707 : Parent Consistent Hash Selection ...

2016-08-01 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/834 TS-4707 : Parent Consistent Hash Selection - add fname and maxdirs This enhancement adds two options, "fname" and "maxdirs", which can be used to exclude th

[GitHub] trafficserver pull request #831: TS-4475: Log Collation Client SM, added VC_...

2016-07-28 Thread pbchou
GitHub user pbchou opened a pull request: https://github.com/apache/trafficserver/pull/831 TS-4475: Log Collation Client SM, added VC_EVENT_INACTIVITY_TIMEOUT event handling. Previously, this event was un-handled and would cause a core dump when it happened. This event is now