Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1624
Yes, I'm very much -1 on adding new plugin APIs and specially the loading
of a .so via records.config.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1629
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1620
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1531
I got this again on Docs.
```
(gdb) bt full
#0 0x2b5b8bd881d7 in __GI_raise (sig=sig@entry=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:56
resultvar = 0
GitHub user zwoop reopened an issue:
https://github.com/apache/trafficserver/issues/1531
Assertion in state_read_server_response_header (v7.1.0)
Seeing this on docs (infrequently):
```
(gdb) bt full
#0 0x757b21d7 in __GI_raise (sig=sig@entry=6) at
../nptl
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1623
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1623#discussion_r109090078
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -112,14 +112,6 @@ LogBufferHeader::log_filename()
return addr
Github user zwoop closed the issue at:
https://github.com/apache/trafficserver/issues/1622
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1622
Dupe of #1623. Please don't file a PR and Issue at the same time. You only
need an issue if you don't have code.
---
If your project is set up for it, you can reply to this email and have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1612
Cherry picked to 7.1.x
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1583
I've been running with this on docs for a few days, with no problem. It
does not seem to address the threads running at 100% CPU at times though. But
assuming this fixes another problem
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1619
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1620
Adds a new condition, %{IP:}
This replaces the old %{CLIENT-IP}, and generalizes the access to
all four IP addresses. E.g.
cond %{SEND_RESPONSE_HDR_HOOK}
set-header X
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1608#discussion_r108463799
--- Diff: ci/tsqa/tests/test_forward_proxy.py ---
@@ -0,0 +1,123 @@
+'''
--- End diff --
If at all possible, can you convert
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1608#discussion_r108462625
--- Diff: proxy/http/HttpConfig.cc ---
@@ -1129,6 +1129,8 @@ HttpConfig::startup()
// Local Manager
HttpEstablishStaticConfigLongLong
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1608#discussion_r108462430
--- Diff: proxy/http/HttpConfig.h ---
@@ -824,6 +824,8 @@ struct HttpConfigParams : public ConfigInfo {
MgmtInt
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1612
Moved to 7.1.0, I think this is a good patch + good fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1610
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1540
@jablko Can you review this please? And also, I think your MATT connection
needs to be redone, since we got moved to gitbox for the internal ASF sync
service).
---
If your project is set up
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1547
@persiaAziz This does not cherry-pick cleanly to 7.1.0, so if we want this
for 7.1.x branch, can you please make another PR, against the 7.1.x branch?
---
If your project is set up
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1546
Is there a reason why this hasn't landed? if not, land it :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1568
@bryancall Ping?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1604
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1600
Cherry-picked to 7.1.x, seems safe, and very reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1606
Why was this merged without setting appropriate labels / versions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1602
Not reloadable. The setting restores the old/expected behavior, meaning
1. It will not let you start traffic_server with a bad ssl_multicert.config
2. It will not replace
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1593
Thread "hangs" on Docs
Running latest 7.1.x branch on Docs with #1583 as well, I started seeing a
thread consuming a *lot* of CPU. In the order of 1000x more than the other
thread
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1592
Why did the AU check fail? Did you forget to rebase? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1497
Yeh, that's fine, I upgraded Sphinx long ago on the Docs build box.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1589
@PSUdaemon You were mucking around in this mess a while back (even though I
tried to keep you out of the rat hole ... ;). Can you take a look at this? It
sounds similar to the issues you had
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1548
@jrushford I assume we don't want this for 7.1.0 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1548
I'm fine with this. However, seeing that the two policy implementations has
virtually identical implementations here, it begs the question as to why this
is not in a base class? It seems
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1588
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1587
Intermittent regression test failures (debug build)
Seeing this on some VMs:
```
REGRESSION TEST SDK_API_HttpTxnTransform started
[SDK_API_HttpTxnTransform] TSTransformCreate
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1586
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1583
This is running on Docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1583
This sounds like a 7.1.0 candidate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1502
Please rebase with current master, and also run "make clang-format" on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1502#discussion_r106057816
--- Diff: proxy/ControlMatcher.cc ---
@@ -220,6 +220,7 @@ HostMatcher<Data, MatchResult>::NewEntry(matcher_line
*line_info)
if (error.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1502
This sounds like a potential candidate for 7.1.0 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1502
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1558
You should upgrade to 6.2.x, if that doesn't have this fix, you can request
this to be back ported to 6.2.2, since 6.2 is an LTS version.
---
If your project is set up for it, you can reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1568
Once landed, I think we should contemplate this for a 7.1.0 cherry-pick.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1565
Merged to 7.1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1565
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1209
Time to land this yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1557
See also ##776.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1371
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1503
What's the word on this PR? 1) Should we land it? 2) Do we still want this
to 7.1.x? Note sure why it's been sitting for so long.
---
If your project is set up for it, you can reply
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1497
@SolidWallOfCode Why is this not merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1517
Note that it has to succeed on CentOS6, which is indeed running
```
[root@centos6 ~]# bison --version
bison (GNU Bison) 2.4.1
```
---
If your project is set up
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1548
@jrushford Do you want this in 7.1.0? If not, move it out to 7.2.0 please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1552
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1552
@shukitchan You ok with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1550
[approve ci] to see if the FreeBSD builds succeed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1582
Make regex_revalidate.c use ref-counted config data
Instead of scheduling a "delete" of the data sometime in the future, a more
reliable pattern is to ref-count the configurations, a
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1565#discussion_r106033633
--- Diff: plugins/regex_revalidate/regex_revalidate.c ---
@@ -362,7 +362,7 @@ config_handler(TSCont cont, TSEvent event ATS_UNUSED,
void *edata
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1576
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1580
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1576#discussion_r106004593
--- Diff: tests/tools/microServer/uWServer.py ---
@@ -17,6 +17,7 @@
# See the License for the specific language governing permissions
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1577
I think we need to make the AU check succeed, right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1578
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1568
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1577
Please file an Issue on the cleanup task, so we know about it, and it gets
assigned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1577
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1578
Add missing include, which otherwise breaks on OSX
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver CMATH
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1574
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1574
Yeh, we want to remove the check for math.h, and the patch does. No?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1574
Explicit std:: name space, seems to make compiler happy
This hopefully fixes the build errors on isnan() usage on the
Ubuntu 16 platform, and also makes it clear which isnan() we use
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1573
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1573#discussion_r105749469
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
m_proxy_resp_content_type_str(nullptr
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1573#discussion_r105746991
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
m_proxy_resp_content_type_str(nullptr
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1412
I'll see if I can get a core out of this again, for some reason, the box
isn't producing core files :/
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1412
We're still seeing this on Docs, with the current 7.1.x and all the
backports.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1573
#1481 Makes % work consistently, and at all
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver CLUC
Alternatively you
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1535
This is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the issue at:
https://github.com/apache/trafficserver/issues/1535
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1426
This is now back ported to 7.1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1561
Yeh, I think you have to create the mutex. Before all these changes, the
core would create one for you if it needed it, but that had a massive single
mutex around that. So instead, we now
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1544
Duplicate of #1498.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop closed the issue at:
https://github.com/apache/trafficserver/issues/1544
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1558
What version is this? I could have sworn we fixed this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1560
Replace all usage (and implementation) of Vec<> with std::vector
@SolidWallOfCode says that it's better, and I like consistency, so we
should unify the code around using one vector implemen
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1335
@jacksontj @vmamidi is working on this, and has a fix (hopefully).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1412
@oknet Did any of your commits address this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1527
On our boxes, it was very noticeable. I can try again, but the net result
was roughly 2-3x the number of active connections, and each transaction was 1/2
- 1/3 the speed (throughput in Mbps
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1446
@shinrich @oknet Is this still a 7.1.0 candidate? Or do we move out to
7.2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1426
@maskit should we backport this to 7.1.0 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1526
I'd like to put this in for 7.1.0 I think. Any objections?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop closed the issue at:
https://github.com/apache/trafficserver/issues/1531
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1559
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1481
Yeh, I suck. Patch coming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1559#discussion_r105187896
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -271,9 +271,22 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc,
EThread *thread
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1559
Nice! Testing this PR on docs.trafficserver now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1559
@oknet Yes, ignore AU tests for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1557
I need to read this some more, but it feels like we need a configuration
option here as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1554
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1267
@jrushford Question: do we want this into 7.1.x ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1554
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
1 - 100 of 896 matches
Mail list logo
