[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1662/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x

Github user scw00 commented on the issue: https://github.com/apache/trafficserver/issues/1401 epoll_wait triggered EVENTIO_ERROR after accept(do_blocking_accept) will cause coredump, because we do not call any do_io_xx. In 6.x.x we do not handle EVENTIO_ERROR event，it may cause vc

[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x

Github user scw00 commented on the issue: https://github.com/apache/trafficserver/issues/1401 epoll_wait trigger EVENTIO_ERROR(in read or write) would case segfault, because we do not set any state in vc(by calling do_io_xxx). we just recevie sockets and register in epoll_wait.

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/94/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1558/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/226/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1427: Crash in ATSConsistentHash::lookup_by_hashval

Github user jrushford commented on the issue: https://github.com/apache/trafficserver/issues/1427 Are there any changes being made to parent.config with traffic_ctl when the crash happens? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1522 Testing this on docs, it's similar to #1444 which did not solve the problems for us there (completely at least), hopefully the additions to the read case helps. --- If your project is set up

[GitHub] trafficserver pull request #1520: Report protocol in request via header

Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1520#discussion_r103819181 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -741,26 +741,14 @@ HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s, HTTPHd

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1517 I'm not sure we can do without this. I know I had problems which lead me to do this which may be related to older versions of Bison. Note that it works for 3.0.4 compared to 2.7. My

[GitHub] trafficserver issue #1503: client cert should be added to netvcoptions only ...

Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1503 It should be merged with master, as well as backported to 7.1.x. Client cert is being checked every time a remap is performed rather it should be checked before making an actual ssl

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1658/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1510: Crash at HttpSM::state_request_wait_for_transform...

Github user oknet commented on the issue: https://github.com/apache/trafficserver/pull/1510 @bryancall @zwoop Could you please assign someone to review this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/222/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

Github user shinrich closed the pull request at: https://github.com/apache/trafficserver/pull/1446 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...

Github user persiaAziz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1299#discussion_r103736131 --- Diff: proxy/http/HttpTransact.cc --- @@ -3571,11 +3571,7 @@ HttpTransact::handle_response_from_parent(State *s)

[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/92/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1556/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...

Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1299#discussion_r103734216 --- Diff: proxy/http/HttpTransact.cc --- @@ -8299,10 +8291,9 @@ HttpTransact::build_redirect_response(State *s)

[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...

Github user jrushford commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1299#discussion_r103735621 --- Diff: proxy/http/HttpTransact.cc --- @@ -3571,11 +3571,7 @@ HttpTransact::handle_response_from_parent(State *s)

[GitHub] trafficserver pull request #1522: Ingore read and write errors if vio has be...

GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/1522 Ingore read and write errors if vio has been cleared You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver

[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...

Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1299#discussion_r103733855 --- Diff: proxy/http/HttpTransact.cc --- @@ -3571,11 +3571,7 @@ HttpTransact::handle_response_from_parent(State *s)

[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...

Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1522 Here is a workaround for issue #1401. I ran into issues with the read also coring. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1555/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/91/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1299 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1554/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1659/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

Github user jablko commented on the issue: https://github.com/apache/trafficserver/pull/1517 > I'm not sure we can do without this. I know I had problems which lead me to do this which may be related to older versions of Bison. Note that it works for 3.0.4 compared to 2.7. My

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1332 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/223/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1660/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1523: ASAN segv when ramping up traffic to a production...

GitHub user bryancall opened an issue: https://github.com/apache/trafficserver/issues/1523 ASAN segv when ramping up traffic to a production host ``` ASAN:SIGSEGV = ==38732==ERROR: AddressSanitizer: SEGV on

[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1522 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/224/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1520: Report protocol in request via header

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1520 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1656/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1520: Report protocol in request via header

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1520 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/88/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103611267 --- Diff: plugins/esi/combo_handler.cc --- @@ -187,6 +207,94 @@ InterceptData::~InterceptData() } } +void

[GitHub] trafficserver issue #1519: Update metrics.config and logging.config to new n...

Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1519 For the duration of 7.x, we have to support both the old and the new naming convention. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

Github user persiaAziz commented on the issue: https://github.com/apache/trafficserver/pull/1446 Looks good to me.. I tested with a plugin that requires this hook --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1521: Changes default RAM cache to the LRU + see...

GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1521 Changes default RAM cache to the LRU + seen-filter It turns out, the CLFUS is either having a bug/issue, or doesn't work well with some content. But several of our users have reported

[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1521 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1553/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1521 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/89/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1521 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1657/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1521: Changes default RAM cache to the LRU + seen-filte...

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1521 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/221/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1524: Seeing a lot of CPU being used on atomics

Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1524 I believe this is not really an issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #1525: Should allow control on whether default cert path...

GitHub user shinrich opened an issue: https://github.com/apache/trafficserver/issues/1525 Should allow control on whether default cert paths/files are included for verification When creating the SSL_CTX for ATS initiating connections to origin, we always call

[GitHub] trafficserver issue #1524: Seeing a lot of CPU being used on atomics

GitHub user bryancall opened an issue: https://github.com/apache/trafficserver/issues/1524 Seeing a lot of CPU being used on atomics ``` - 22.49%22.20% traffic_server [.] ink_atomic_increment

[GitHub] trafficserver issue #1524: Seeing a lot of CPU being used on atomics

Github user bryancall closed the issue at: https://github.com/apache/trafficserver/issues/1524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...

Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1522 Looks reasonable to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1526: When SSL connect fails, we return 502 succ...

GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/1526 When SSL connect fails, we return 502 success While debugging a failure in origin cert verification, we saw that the response header included ``` HTTP/1.1 502 Success

[GitHub] trafficserver pull request #1444: issue #1401: Potential fix to the write_to...

Github user shinrich closed the pull request at: https://github.com/apache/trafficserver/pull/1444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1444: issue #1401: Potential fix to the write_to_io_net...

Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1444 Closing in deference to the more complete solution in PR #1522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1465: Add new testing system to the test subdire...

Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1465#discussion_r103799188 --- Diff: tests/getting_started.md --- @@ -0,0 +1,197 @@ + +# Getting Started + +This directory contains different tests for

[GitHub] trafficserver issue #1526: When SSL connect fails, we return 502 success

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1526 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/93/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1526: When SSL connect fails, we return 502 success

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1526 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1557/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1526: When SSL connect fails, we return 502 success

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1526 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1661/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1526: When SSL connect fails, we return 502 success

Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1526 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/225/ for details. --- If your project is set up for it, you can reply to this email