[GitHub] trafficserver issue #916: TS-4336: Rename MIMEParseResult values for better ...

2016-08-25 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/916 @bryancall Renamed to ``ParseResult``. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver pull request #925: TS-4788: Add state machine ID to HttpTransa...

2016-08-25 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/925 TS-4788: Add state machine ID to HttpTransact debug logs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/4788

[GitHub] trafficserver pull request #927: TS-4785: Stale while revalidate plugin memo...

2016-08-25 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/927 TS-4785: Stale while revalidate plugin memory corruption. This fixes a couple of memory corruption bugs in the stale_while_revalidate plugin. First, when copying the client

[GitHub] trafficserver issue #927: TS-4785: Stale while revalidate plugin memory corr...

2016-08-25 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/927 /cc @PSUdaemon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #925: TS-4788: Add state machine ID to HttpTransa...

2016-08-25 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/925 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #920: TS-4268: Verbose OCSP notes in syslog

2016-08-25 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/920 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #928: Ts 4423

2016-08-25 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/928 Please rebase to remove the merge commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver pull request #928: Ts 4423

2016-08-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/928#discussion_r76329976 --- Diff: cmd/traffic_ctl/traffic_ctl.cc --- @@ -240,7 +240,7 @@ main(int argc, const char **argv) if (debug) { diags->activate_tagl

[GitHub] trafficserver issue #924: TS-4786: Rename activity and inactivity timeout ar...

2016-08-25 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/924 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #916: TS-4336: Rename MIMEParseResult values for ...

2016-08-25 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/916 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #918: TS-4725: Remove proxy.config.http.enable_url_expan...

2016-08-25 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/918 It looks like we can go futher and remove ``HttpTransact::try_to_expand_host_name``. Maybe an extra commit or follow-on Jira? --- If your project is set up for it, you can reply to this

[GitHub] trafficserver issue #922: TS-4376: Support variable extension in set-header

2016-08-25 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/922 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #929: TS-4789: Remove READ_WHILE_WRITER build condition.

2016-08-25 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/929 /cc @SolidWallOfCode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver pull request #929: TS-4789: Remove READ_WHILE_WRITER build con...

2016-08-25 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/929 TS-4789: Remove READ_WHILE_WRITER build condition. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/4789

[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...

2016-08-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/909#discussion_r76361930 --- Diff: iocore/eventsystem/P_UnixSocketManager.h --- @@ -55,21 +55,52 @@ transient_error() return transient; } +#if

[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...

2016-08-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/909#discussion_r76361941 --- Diff: iocore/eventsystem/I_SocketManager.h --- @@ -102,7 +110,7 @@ struct SocketManager { int dup(int s); // result is the fd or

[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...

2016-08-25 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/909#discussion_r76362179 --- Diff: iocore/eventsystem/I_SocketManager.h --- @@ -37,6 +37,14 @@ #include "I_EventSystem.h" #include "I_Thread.h"

[GitHub] trafficserver pull request #909: TS-3508: Use accept4() on systems where it ...

2016-08-26 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/909#discussion_r76437047 --- Diff: iocore/eventsystem/I_SocketManager.h --- @@ -37,6 +37,14 @@ #include "I_EventSystem.h" #include "I_Thread.h"

[GitHub] trafficserver pull request #929: TS-4789: Remove READ_WHILE_WRITER build con...

2016-08-26 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/929 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #931: TS-4791: Move stale_while_revalidate back i...

2016-08-26 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/931 TS-4791: Move stale_while_revalidate back into the build. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/4791

[GitHub] trafficserver issue #931: TS-4791: Move stale_while_revalidate back into the...

2016-08-26 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/931 /cc @PSUdaemon @bryancall @zwoop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #930: Add test and doc for proxy config cache select alt...

2016-08-26 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/930 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #931: TS-4791: Move stale_while_revalidate back into the...

2016-08-26 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/931 @PSUdaemon didn't NACK this on IRC, so moving forward. If anyone else wants to NACK this we can discuss :) --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver pull request #931: TS-4791: Move stale_while_revalidate back i...

2016-08-26 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/931 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #927: TS-4785: Stale while revalidate plugin memo...

2016-08-26 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/927 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #933: TS-4790: Fix stale_while_revalidate to issu...

2016-08-26 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/933 TS-4790: Fix stale_while_revalidate to issue requests on net threads. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach

[GitHub] trafficserver issue #932: TS-4263: Global key block configurable via Records...

2016-08-26 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/932 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #922: TS-4376: Support variable extension in set-header

2016-08-26 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/922 This looks very reasonable to me. Since @zwoop is the ``header_rewrite`` guru I'd like him to ack as well. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #865: TS-2987: Add new TS API TSHttpTxnPluginTagGet

2016-08-26 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/865 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver issue #934: TS-4779: Remove SET_CLOSE_ON_EXEC #ifdef's from so...

2016-08-26 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/934 Should extend ``SocketManager::socket`` to handle non-block and cloexec like accept does? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #918: TS-4725: Remove proxy.config.http.enable_url_expan...

2016-08-26 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/918 OK I filed [TS-4792](https://issues.apache.org/jira/browse/TS-4792). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #933: TS-4790: Fix stale_while_revalidate to issu...

2016-08-26 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/933 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #928: Ts 4423

2016-08-26 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/928 The preferred commit message is: ``` TS-1234: less than 80 chars. ``` Feel free to add an extended explanation into the body of the commit message. It makes it easier than

[GitHub] trafficserver issue #935: TS-4784: CID 1022032 - Check return value on TSTex...

2016-08-26 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/935 👍 (assuming CI likes it) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #934: TS-4779: Remove SET_CLOSE_ON_EXEC #ifdef's from so...

2016-08-26 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/934 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #936: TS-4793: Make the C++ API reattach to exist...

2016-08-26 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/936 TS-4793: Make the C++ API reattach to existing stats. Sometimes you want multiple plugins to increment the same stats, or you create transient objects that emit stats. In these cases

[GitHub] trafficserver pull request #936: TS-4793: Make the C++ API reattach to exist...

2016-08-26 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/936 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

2016-08-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/937 @oknet FWIW if you need to assert unconditionally, you can use ``ink_abort``, which just aborts with a message. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

2016-08-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/937 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #941: TS-3577: Remove the --enable-static-proxy b...

2016-08-29 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/941 TS-3577: Remove the --enable-static-proxy build option. The --enable-static-proxy build option was theorized to help performance on register-starved 32bit architectures. We don't su

[GitHub] trafficserver issue #937: TS-2482: Should use target_addr instead of server_...

2016-08-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/937 @oknet the code is fine, it was just a FYI :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #940: [TS-4530] Enable hostdb.host_file.path by default

2016-08-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/940 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #940: [TS-4530] Enable hostdb.host_file.path by default

2016-08-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/940 I'm +1 on this. @jacksontj ? @SolidWallOfCode ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver issue #938: TS-4263: Global key block configurable via Records...

2016-08-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/938 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #941: TS-3577: Remove the --enable-static-proxy b...

2016-08-29 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/941#discussion_r76725945 --- Diff: configure.ac --- @@ -231,33 +231,6 @@ TS_ARG_ENABLE_VAR([has], [tests]) AM_CONDITIONAL([BUILD_TESTS], [test 0 -ne $has_tests

[GitHub] trafficserver issue #941: TS-3577: Remove the --enable-static-proxy build op...

2016-08-29 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/941 @zwoop AFAICT ``--enable-remote-cov-commit`` does nothing. I can nuke it too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #937: TS-2482: Should use target_addr instead of ...

2016-08-30 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/937 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #941: TS-3577: Remove the --enable-static-proxy b...

2016-08-30 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/941 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #942: TS 4263: Global key block configurable via ...

2016-08-30 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/942#discussion_r76876497 --- Diff: mgmt/RecordsConfig.cc --- @@ -1245,7 +1245,7 @@ static const RecordElement RecordsConfig[] = , {RECT_CONFIG

[GitHub] trafficserver issue #944: TS-4676: Remove TS_HTTP_READ_REQUEST_PRE_REMAP_HOO...

2016-08-30 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/944 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #918: TS-4725: Remove proxy.config.http.enable_ur...

2016-08-30 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/918 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option

2016-08-30 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/946 I think the message would be more legible with ``AC_MSG_WARN``. For example: ``` AS_IF([test "x$enable_linux_native_aio" = "xyes"], [ AC_MSG_WARN([Linux AIO

[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option

2016-08-31 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/946 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #945: TS-4799: Allow minimum log rolling period t...

2016-08-31 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/945 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #753: TS-4705: Proposal: NetVC Context

2016-08-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r77096002 --- Diff: iocore/net/I_NetVConnection.h --- @@ -566,6 +573,21 @@ class NetVConnection : public VConnection is_transparent = state

[GitHub] trafficserver pull request #753: TS-4705: Proposal: NetVC Context

2016-08-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r77095956 --- Diff: iocore/net/I_NetVConnection.h --- @@ -566,6 +573,21 @@ class NetVConnection : public VConnection is_transparent = state

[GitHub] trafficserver pull request #753: TS-4705: Proposal: NetVC Context

2016-08-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r77096388 --- Diff: iocore/net/I_NetVConnection.h --- @@ -566,6 +573,21 @@ class NetVConnection : public VConnection is_transparent = state

[GitHub] trafficserver pull request #753: TS-4705: Proposal: NetVC Context

2016-08-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/753#discussion_r77096654 --- Diff: iocore/net/P_SSLNetVConnection.h --- @@ -101,26 +101,13 @@ class SSLNetVConnection : public UnixNetVConnection

[GitHub] trafficserver issue #872: TS-4735: Fix race condition in traffic_server star...

2016-08-31 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/872 As mentioned on TS-4646, this is not very reproducible. Although the patch here makes the symptom go away, I'm not comfortable that we really understand why the initial message exchange

[GitHub] trafficserver issue #954: [TS-4457] Via header always reports http1

2016-09-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/954 Why can't you just slam in the result of ``get_protocol_string()`` in all cases? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver issue #948: TS-3407 Removes the legacy h2-14 identifiers

2016-09-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/948 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #955: TS-4805: CID 1021743: Uninitialized scalar ...

2016-09-01 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/955#discussion_r77249346 --- Diff: iocore/net/UnixNet.cc --- @@ -289,7 +289,20 @@ initialize_thread_for_net(EThread *thread) // NetHandler method definitions

[GitHub] trafficserver pull request #951: TS-4797: Allow backslash-escape in header_r...

2016-09-01 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/951#discussion_r77249993 --- Diff: plugins/header_rewrite/parser.cc --- @@ -50,6 +52,12 @@ Parser::Parser(const std::string &line) : _cond(false), _empty(f

[GitHub] trafficserver pull request #950: TS-4803 Removes the config/support for prox...

2016-09-01 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/950#discussion_r77250346 --- Diff: proxy/http/HttpTransact.cc --- @@ -1692,16 +1692,15 @@ HttpTransact::ReDNSRoundRobin(State *s) void HttpTransact::OSDNSLookup(State

[GitHub] trafficserver issue #947: TS-4796 Change UnixNetHandler to always bubble up ...

2016-09-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/947 /cc @oknet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] trafficserver issue #947: TS-4796 Change UnixNetHandler to always bubble up ...

2016-09-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/947 I don't think this is the right approach. First, ``read_signal_error`` and ``write_signal_error`` don't need to be made non-static since you already have ``UnixNetV

[GitHub] trafficserver pull request #940: [TS-4530] Enable hostdb.host_file.path by d...

2016-09-01 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/940 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #940: [TS-4530] Enable hostdb.host_file.path by default

2016-09-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/940 Thanks @ericcarlschwartz, but there was consensus to leave the current defaults. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #953: TS-4402: Fixes some config "Int" types to "Byte" t...

2016-09-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/953 This looks OK to me. Consider your commit subjects read ```TS-4402: ...```. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #953: TS-4402 Fixes some config "Int" types to "Byte" ty...

2016-09-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/953 Yep the ```:```. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #872: TS-4735: Fix race condition in traffic_server star...

2016-09-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/872 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #872: TS-4735: Fix race condition in traffic_server star...

2016-09-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/872 @kshri23 I dig into the startup sequence a bit more and I'm now convinced that this is a reasonable approach. What do you think about just changing ``MAX_MSGS_IN_A_ROW`` to something s

[GitHub] trafficserver pull request #959: TS-4808: General diagnostics cleanup.

2016-09-01 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/959 TS-4808: General diagnostics cleanup. - Clean up the Diags class to remove code duplication. - Switch all the diagnostic formatters over to using SourceLocation. - Remove useless

[GitHub] trafficserver issue #872: TS-4735: Fix race condition in traffic_server star...

2016-09-01 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/872 The 10k is an arbitrary number chosen in [TS-4161](https://issues.apache.org/jira/browse/TS-4161). --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #850: TS-4728: Remove invalid LogHost assertion.

2016-09-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/850 > On Sep 2, 2016, at 6:45 AM, Oknet wrote: > > Should we define LogFile::free() first ? > The Ptr::clear() need free() to dealloc the LogFile. LogF

[GitHub] trafficserver issue #872: TS-4735: Fix race condition in traffic_server star...

2016-09-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/872 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #959: TS-4808: General diagnostics cleanup.

2016-09-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/959 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #961: TS-4810: Use the correct LuaJIT LDFLAGS

2016-09-02 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/961#discussion_r77404086 --- Diff: configure.ac --- @@ -1808,15 +1806,15 @@ iocore_include_dirs="\ # of the generic flags, plus any Lua-specific flags so that we

[GitHub] trafficserver pull request #855: TS-4794 fix the memory leaks

2016-09-02 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/855#discussion_r77410114 --- Diff: iocore/net/test_P_Net.cc --- @@ -68,6 +68,7 @@ struct NetTesterSM : public Continuation { default: ink_release_assert

[GitHub] trafficserver pull request #855: TS-4794 fix the memory leaks

2016-09-02 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/855#discussion_r77410158 --- Diff: iocore/dns/test_P_DNS.cc --- @@ -70,6 +70,7 @@ struct NetTesterSM : public Continuation { default: ink_release_assert

[GitHub] trafficserver pull request #958: TS-4449 Better errors and debug output

2016-09-02 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/958#discussion_r77410848 --- Diff: plugins/header_rewrite/ruleset.cc --- @@ -40,15 +40,16 @@ RuleSet::append(RuleSet *rule) } void -RuleSet::add_condition

[GitHub] trafficserver pull request #958: TS-4449 Better errors and debug output

2016-09-02 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/958#discussion_r77410889 --- Diff: plugins/header_rewrite/ruleset.cc --- @@ -73,7 +74,8 @@ RuleSet::add_operator(Parser &p) TSDebug(PLUGIN_NAME, " Adding ope

[GitHub] trafficserver issue #961: TS-4810: Use the correct LuaJIT LDFLAGS

2016-09-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/961 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #956: TS-4806: Fix up event processor thread stac...

2016-09-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/956#discussion_r77443664 --- Diff: iocore/eventsystem/UnixEventProcessor.cc --- @@ -152,6 +155,59 @@ EventProcessor::start(int n_event_threads, size_t stacksize) #else

[GitHub] trafficserver pull request #956: TS-4806: Fix up event processor thread stac...

2016-09-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/956#discussion_r77443720 --- Diff: iocore/eventsystem/UnixEventProcessor.cc --- @@ -152,6 +155,59 @@ EventProcessor::start(int n_event_threads, size_t stacksize) #else

[GitHub] trafficserver pull request #956: TS-4806: Fix up event processor thread stac...

2016-09-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/956#discussion_r77443787 --- Diff: iocore/eventsystem/UnixEventProcessor.cc --- @@ -152,6 +155,59 @@ EventProcessor::start(int n_event_threads, size_t stacksize) #else

[GitHub] trafficserver pull request #956: TS-4806: Fix up event processor thread stac...

2016-09-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/956#discussion_r77443795 --- Diff: iocore/eventsystem/UnixEventProcessor.cc --- @@ -152,6 +155,59 @@ EventProcessor::start(int n_event_threads, size_t stacksize) #else

[GitHub] trafficserver pull request #956: TS-4806: Fix up event processor thread stac...

2016-09-03 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/956#discussion_r77443808 --- Diff: iocore/eventsystem/UnixEventProcessor.cc --- @@ -152,6 +155,59 @@ EventProcessor::start(int n_event_threads, size_t stacksize) #else

[GitHub] trafficserver issue #887: TS-2258: Mark whether configs are reloadable (part...

2016-09-03 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/887 @zwoop I would like to double-check these with you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver pull request #967: TS-4555: Make CPP API use a reserved transa...

2016-09-06 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/967#discussion_r77654030 --- Diff: lib/atscppapi/src/utils_internal.cc --- @@ -99,6 +97,8 @@ handleTransactionEvents(TSCont cont, TSEvent event, void *edata) void

[GitHub] trafficserver pull request #967: TS-4555: Make CPP API use a reserved transa...

2016-09-06 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/967#discussion_r77655023 --- Diff: lib/atscppapi/src/utils_internal.cc --- @@ -99,6 +97,8 @@ handleTransactionEvents(TSCont cont, TSEvent event, void *edata) void

[GitHub] trafficserver issue #956: TS-4806: Fix up event processor thread stacks

2016-09-06 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/956 @PSUdaemon this is much cleaner 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #956: TS-4806: Fix up event processor thread stacks

2016-09-06 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/956 @SolidWallOfCode for a condition variable approach, there is the ``EventNotify`` class. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver pull request #969: TS-4800: Fix logging.config reloading.

2016-09-06 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/969 TS-4800: Fix logging.config reloading. We were still listening for reconfiguration events on the old XML log file record. Fix logging.config reload by listening on the correct record

[GitHub] trafficserver pull request #969: TS-4800: Fix logging.config reloading.

2016-09-06 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/969 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #970: TS-4818: Ensure the plugin tag is set on th...

2016-09-06 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/970 TS-4818: Ensure the plugin tag is set on the HttpSM. Unless we copy the plugin information when creating the proxy transaction, the % logging field always emits "*". You can

[GitHub] trafficserver issue #970: TS-4818: Ensure the plugin tag is set on the HttpS...

2016-09-06 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/970 Verified that the background requests from the ``stale_while_revalidate`` plugin now get a legitimate entry when using the ``%`` log field. --- If your project is set up for it, you can reply

[GitHub] trafficserver pull request #970: TS-4818: Ensure the plugin tag is set on th...

2016-09-06 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/970 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #971: TS-1882: Check for unrecognized configurati...

2016-09-06 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/971#discussion_r77714260 --- Diff: proxy/Main.cc --- @@ -476,6 +476,18 @@ check_config_directories(void) } } +namespace { + // Values with names that

[GitHub] trafficserver issue #974: TS-3785 List --command options in traffic_server u...

2016-09-07 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/974 @alyssaq Since you are documenting these, can you please update the ``traffic_server`` man page as well? --- If your project is set up for it, you can reply to this email and have your reply

<    1   2   3   4   5   6   7   8   >