[GitHub] trafficserver issue #1624: Http transaction debugging feature
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1624 Yes, I'm very much -1 on adding new plugin APIs and specially the loading of a .so via records.config. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1629: Assertion in state_read_server_response_header (v...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1629 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1620: Adds a new condition, %{IP:}
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1620 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1531: Assertion in state_read_server_response_header (v...
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1531
I got this again on Docs.
```
(gdb) bt full
#0 0x2b5b8bd881d7 in __GI_raise (sig=sig@entry=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:56
resultvar = 0
pid = 24448
selftid = 24454
#1 0x2b5b8bd89a08 in __GI_abort () at abort.c:119
act = {__sigaction_handler = {sa_handler = 0x0, sa_sigaction =
0x0}, sa_mask = {__val = {18446744073709551615 }}, sa_flags =
0, sa_restorer = 0x0}
sigs = {__val = {32, 0 }}
#2 0x2b5b89af48fe in ink_abort (message_format=0x2b5b89b0b160 "%s:%d:
failed assertion `%s`") at ink_error.cc:99
ap = {{gp_offset = 32, fp_offset = 48, overflow_arg_area =
0x2b5fe960, reg_save_area = 0x2b5fe8a0}}
#3 0x2b5b89af1fbf in _ink_assert (expression=0x902748
"server_entry->read_vio == (VIO *)data", file=0x901a0c "HttpSM.cc", line=1811)
at ink_assert.cc:37
No locals.
#4 0x0064dcc8 in HttpSM::state_read_server_response_header
(this=0x2aaab14ee380, event=3, data=0x2aaaeea0a910) at HttpSM.cc:1811
__FUNCTION__ = "state_read_server_response_header"
bytes_used = -1419774208
vio = 0x0
state = 10922
#5 0x00650fe6 in HttpSM::main_handler (this=0x2aaab14ee380,
event=3, data=0x2aaaeea0a910) at HttpSM.cc:2663
jump_point = (int (HttpSM::*)(HttpSM * const, int, void *))
0x64db74 <HttpSM::state_read_server_response_header(int, void*)>
__FUNCTION__ = "main_handler"
vc_entry = 0x2aaab14efb88
#6 0x00574752 in Continuation::handleEvent (this=0x2aaab14ee380,
event=3, data=0x2aaaeea0a910) at
/usr/local/src/trafficserver/iocore/eventsystem/I_Continuation.h:153
No locals.
#7 0x00807027 in write_signal_and_update (event=3,
vc=0x2aaaeea0a770) at UnixNetVConnection.cc:176
__FUNCTION__ = "write_signal_and_update"
#8 0x0080725e in write_signal_done (event=3, nh=0x2b5b8e409e50,
vc=0x2aaaeea0a770) at UnixNetVConnection.cc:218
No locals.
#9 0x008072ee in write_signal_error (nh=0x2b5b8e409e50,
vc=0x2aaaeea0a770, lerrno=32) at UnixNetVConnection.cc:237
No locals.
#10 0x008081de in write_to_net_io (nh=0x2b5b8e409e50,
vc=0x2aaaeea0a770, thread=0x2b5b8e406000) at UnixNetVConnection.cc:468
err = 32
errlen = 4
s = 0x2aaaeea0a908
mutex = 0x2b5b8d914c60
lock = {m = {m_ptr = 0x2aaac4e02ed0}, lock_acquired = true}
__FUNCTION__ = "write_to_net_io"
ntodo = 959
buf =
towrite = 46913636312944
signalled = 0
needs = 32
total_written = 4
r = 47672214753344
#11 0x00808023 in write_to_net (nh=0x2b5b8e409e50,
vc=0x2aaaeea0a770, thread=0x2b5b8e406000) at UnixNetVConnection.cc:443
mutex = 0x2b5b8d914c60
#12 0x007ff412 in NetHandler::mainNetEvent (this=0x2b5b8e409e50,
event=5, e=0x2bc05a60) at UnixNet.cc:526
epd = 0x2aaaeea0ca18
poll_timeout = 0
pd = 0x2b5b8ea99000
vc = 0x2aaaeea0a770
__FUNCTION__ = "mainNetEvent"
#13 0x00574752 in Continuation::handleEvent (this=0x2b5b8e409e50,
event=5, data=0x2bc05a60) at
/usr/local/src/trafficserver/iocore/eventsystem/I_Continuation.h:153
No locals.
#14 0x0082b640 in EThread::process_event (this=0x2b5b8e406000,
e=0x2bc05a60, calling_code=5) at UnixEThread.cc:143
c_temp = 0x2b5b8e409e50
lock = {m = {m_ptr = 0x2b5b8d9141e0}, lock_acquired = true}
__FUNCTION__ = "process_event"
#15 0x0082bc1f in EThread::execute (this=0x2b5b8e406000) at
UnixEThread.cc:270
done_one = false
e = 0x2bc05a60
NegativeQueue = {<DLL<Event, Event::Link_link>> = {head =
0x2bc04c80}, tail = 0x2bc04080}
next_time = 1490586447220437269
__FUNCTION__ = "execute"
#16 0x0082ac5a in spawn_thread_internal (a=0x2b5b8d6aea90) at
Thread.cc:84
p = 0x2b5b8d6aea90
#17 0x2b5b8b638dc5 in start_thread (arg=0x2b5ff700) at
pthread_create.c:308
__res =
pd = 0x2b5ff700
now =
unwind_buf = {cancel_jmp_buf = {{jmp_buf = {4691250800,
-4231554947831992312, 0, 140736391318576, 4691250800, 0,
-8065056817632415736, -7786325772008460280}, mask_was_saved = 0}}, priv = {pad
= {0x0, 0x0, 0x0, 0x0}, data = {prev = 0x0, cleanup = 0x0, canceltype = 0}}}
not_first_call =
pagesize_m1 =
sp =
freesize =
#18 0x2b5b8be4a73d in clone () at
../sysdeps/unix
[GitHub] trafficserver issue #1531: Assertion in state_read_server_response_header (v...
GitHub user zwoop reopened an issue:
https://github.com/apache/trafficserver/issues/1531
Assertion in state_read_server_response_header (v7.1.0)
Seeing this on docs (infrequently):
```
(gdb) bt full
#0 0x757b21d7 in __GI_raise (sig=sig@entry=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:56
resultvar = 0
pid = 5856
selftid = 5862
#1 0x757b38c8 in __GI_abort () at abort.c:90
save_stage = 2
act = {__sigaction_handler = {sa_handler = 0x0, sa_sigaction =
0x0}, sa_mask = {__val = {0 }}, sa_flags = 0, sa_restorer =
0x300a00440}
sigs = {__val = {32, 0 }}
#2 0x77bb28fe in ink_abort (message_format=0x77bc9160 "%s:%d:
failed assertion `%s`") at ink_error.cc:99
ap = {{gp_offset = 32, fp_offset = 48, overflow_arg_area =
0x2affe960, reg_save_area = 0x2affe8a0}}
#3 0x77baffbf in _ink_assert (expression=0x902628
"server_entry->read_vio == (VIO *)data", file=0x9018ec "HttpSM.cc", line=1811)
at ink_assert.cc:37
No locals.
#4 0x0064dbac in HttpSM::state_read_server_response_header
(this=0x2aaab2ecc300, event=3, data=0x2aaadfe10fe0) at HttpSM.cc:1811
__FUNCTION__ = "state_read_server_response_header"
bytes_used = -1426065664
vio = 0x0
state = 10922
#5 0x00650eca in HttpSM::main_handler (this=0x2aaab2ecc300,
event=3, data=0x2aaadfe10fe0) at HttpSM.cc:2663
jump_point = (int (HttpSM::*)(HttpSM * const, int, void *))
0x64da58 <HttpSM::state_read_server_response_header(int, void*)>
__FUNCTION__ = "main_handler"
vc_entry = 0x2aaab2ecdb08
#6 0x0057472a in Continuation::handleEvent (this=0x2aaab2ecc300,
event=3, data=0x2aaadfe10fe0) at
/usr/local/src/trafficserver/iocore/eventsystem/I_Continuation.h:153
No locals.
#7 0x00806eed in write_signal_and_update (event=3,
vc=0x2aaadfe10e40) at UnixNetVConnection.cc:176
__FUNCTION__ = "write_signal_and_update"
#8 0x00807124 in write_signal_done (event=3, nh=0x73009e50,
vc=0x2aaadfe10e40) at UnixNetVConnection.cc:218
No locals.
#9 0x008071b4 in write_signal_error (nh=0x73009e50,
vc=0x2aaadfe10e40, lerrno=32) at UnixNetVConnection.cc:237
No locals.
#10 0x008080d0 in write_to_net_io (nh=0x73009e50,
vc=0x2aaadfe10e40, thread=0x73006000) at UnixNetVConnection.cc:463
err = 32
errlen = 4
s = 0x2aaadfe10fd8
mutex = 0x73512db0
lock = {m = {m_ptr = 0x2aaab0402ca0}, lock_acquired = true}
__FUNCTION__ = "write_to_net_io"
ntodo = 910
buf =
towrite = 46913388875328
signalled = 0
needs = 32
total_written = 4
r = 140737294027776
#11 0x00807ead in write_to_net (nh=0x73009e50,
vc=0x2aaadfe10e40, thread=0x73006000) at UnixNetVConnection.cc:435
mutex = 0x73512db0
#12 0x007ff2d8 in NetHandler::mainNetEvent (this=0x73009e50,
event=5, e=0x2bc05ca0) at UnixNet.cc:526
epd = 0x2aaadfe10da8
poll_timeout = 0
pd = 0x72f1d000
vc = 0x2aaadfe10e40
__FUNCTION__ = "mainNetEvent"
#13 0x0057472a in Continuation::handleEvent (this=0x73009e50,
event=5, data=0x2bc05ca0) at
/usr/local/src/trafficserver/iocore/eventsystem/I_Continuation.h:153
No locals.
#14 0x0082b522 in EThread::process_event (this=0x73006000,
e=0x2bc05ca0, calling_code=5) at UnixEThread.cc:143
c_temp = 0x73009e50
lock = {m = {m_ptr = 0x73512480}, lock_acquired = true}
__FUNCTION__ = "process_event"
#15 0x0082bb01 in EThread::execute (this=0x73006000) at
UnixEThread.cc:270
done_one = false
e = 0x2bc05ca0
NegativeQueue = {<DLL<Event, Event::Link_link>> = {head =
0x2bc04f80}, tail = 0x2bc041a0}
next_time = 1488388269045403248
__FUNCTION__ = "execute"
#16 0x0082ab3c in spawn_thread_internal (a=0x74539fa0) at
Thread.cc:84
p = 0x74539fa0
#17 0x7604bdc5 in start_thread (arg=0x2afff700) at
pthread_create.c:308
__res =
pd = 0x2afff700
now =
unwind_buf = {cancel_jmp_buf = {{jmp_buf = {46912501708544,
8358616470746199031, 0, 140737488348672, 46912501708544, 0,
2786198315644908535, -8358635357929704457}, mask_was_saved = 0}}, priv = {pad =
{0x0, 0x0, 0x0, 0x0}, data = {prev = 0x0, cleanup = 0x0, canceltype = 0}}}
not_first_call =
pagesize_m1 =
sp =
[GitHub] trafficserver pull request #1623: Delete dead code
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1623 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1623: Delete dead code
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1623#discussion_r109090078 --- Diff: proxy/logging/LogBuffer.cc --- @@ -112,14 +112,6 @@ LogBufferHeader::log_filename() return addr; } -/*- - LogBuffer::LogBuffer --- End diff -- I don't think you should nuke the entire comment, just clean it up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1622: Delete proxy/AbstractBuffer.{cc,h}
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1622 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1622: Delete proxy/AbstractBuffer.{cc,h}
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1622 Dupe of #1623. Please don't file a PR and Issue at the same time. You only need an issue if you don't have code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1612 Cherry picked to 7.1.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1583 I've been running with this on docs for a few days, with no problem. It does not seem to address the threads running at 100% CPU at times though. But assuming this fixes another problem, it seems safe and fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1619: Perform the config reload on ET_TASK threa...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1619 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1620: Adds a new condition, %{IP:}
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1620
Adds a new condition, %{IP:}
This replaces the old %{CLIENT-IP}, and generalizes the access to
all four IP addresses. E.g.
cond %{SEND_RESPONSE_HDR_HOOK}
set-header X-Client-IP %{IP:CLIENT}
set-header X-Inbound-IP %{IP:INBOUND}
set-header X-Server-IP %{IP:SERVER}
set-header X-Outbound-IP %{IP:OUTBOUND}
In the case of a sockaddr not being populated, e.g. IP:SERVER on
a cache hit, the string is "" (empty).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver ConditionIp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1620.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1620
commit 2e8f6eb86a4554e0eea64d8ff64f9725907d8e1f
Author: Leif Hedstrom <zw...@apache.org>
Date: 2017-03-29T22:23:15Z
Adds a new condition, %{IP:}
This replaces the old %{CLIENT-IP}, and generalizes the access to
all four IP addresses. E.g.
cond %{SEND_RESPONSE_HDR_HOOK}
set-header X-Client-IP %{IP:CLIENT}
set-header X-Inbound-IP %{IP:INBOUND}
set-header X-Server-IP %{IP:SERVER}
set-header X-Outbound-IP %{IP:OUTBOUND}
In the case of a sockaddr not being populated, e.g. IP:SERVER on
a cache hit, the string is "" (empty).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1608: FTP Support
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108463799 --- Diff: ci/tsqa/tests/test_forward_proxy.py --- @@ -0,0 +1,123 @@ +''' --- End diff -- If at all possible, can you convert this to the new AU test system? @dragon512 can perhaps assist as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1608: FTP Support
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108462625 --- Diff: proxy/http/HttpConfig.cc --- @@ -1129,6 +1129,8 @@ HttpConfig::startup() // Local Manager HttpEstablishStaticConfigLongLong(c.synthetic_port, "proxy.config.admin.synthetic_port"); + // FTP protocol enabled + HttpEstablishStaticConfigByte(c.forward_proxy_ftp_enabled, "proxy.config.ftp_enabled"); --- End diff -- Can we make this overridable as well? That would allow you to turn on /off this feature per remap rule (or via a plugin). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1608: FTP Support
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1608#discussion_r108462430
--- Diff: proxy/http/HttpConfig.h ---
@@ -824,6 +824,8 @@ struct HttpConfigParams : public ConfigInfo {
MgmtInt body_factory_response_max_size;
+ MgmtByte forward_proxy_ftp_enabled;
--- End diff --
Can you move this up where other MgmtByte's are? That avoids unnecessary
padding of the bytes (as it is above, you would waste at least 3 bytes in the
struct).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1612 Moved to 7.1.0, I think this is a good patch + good fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1610: backport c4144 and 74fc4 to 7.1.x
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1610 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1540 @jablko Can you review this please? And also, I think your MATT connection needs to be redone, since we got moved to gitbox for the internal ASF sync service). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1547: Fix ssl hook state logic.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1547 @persiaAziz This does not cherry-pick cleanly to 7.1.0, so if we want this for 7.1.x branch, can you please make another PR, against the 7.1.x branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1546 Is there a reason why this hasn't landed? if not, land it :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1568: TS-4195: double free on exit
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1568 @bryancall Ping? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1604: TS-4976: Regularize plugins - protocol_stack
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1604 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1600: fix , remove not used array buf in rcv_data_frame...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1600 Cherry-picked to 7.1.x, seems safe, and very reasonable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1606: require sphinx version 1.5.1
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1606 Why was this merged without setting appropriate labels / versions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1602: proxy.config.ssl.server.multicert.exit_on_load_fa...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1602 Not reloadable. The setting restores the old/expected behavior, meaning 1. It will not let you start traffic_server with a bad ssl_multicert.config 2. It will not replace a running, functional configuration with a broken ssl_multicert.config I honestly don't know how we made this "off" by default, but I've filed an issue already to make the default for this to be "1" for v8.0.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1593: Thread "hangs" on Docs
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1593 Thread "hangs" on Docs Running latest 7.1.x branch on Docs with #1583 as well, I started seeing a thread consuming a *lot* of CPU. In the order of 1000x more than the other threads (3-5 CPU hours instead of CPU minutes). Oddly enough, the problem clears itself on its own, in one case, it cleared just as I attached gdb to it. This has happened twice so far; once it ran for 3 CPU hours, and once for 5 CPU hours, until they cleared. I got a stack trace from the wedged threads, and I examined it at least 10 times, and each time, I saw exactly the same stack thread. I did unfortunately not get a chance to perf test it, and no gdb session (before it cleared). The trace is ``` root@qa1 377/0 # pstack 17665 Thread 1 (Thread 0x2b7ff700 (LWP 17665)): #0 0x0073045a in MIMEFieldBlockImpl::contains (this=0x2b068ea9c158, field=0x2b0695cc3158) at MIME.cc:3717 #1 0x0072a97d in mime_hdr_field_slotnum (mh=0x2c81c088, field=0x2b0695cc3158) at MIME.cc:1670 #2 0x00727a5f in mime_hdr_sanity_check (mh=0x2c81c088) at MIME.cc:581 #3 0x0072a91e in mime_hdr_field_delete (heap=0x2c81c000, mh=0x2c81c088, field=0x2b0695cc2cd8, delete_all_dups=false) at MIME.cc:1655 #4 0x005c8be0 in MIMEHdr::field_delete (this=0x2b068e865050, field=0x2b0695cc2cd8, delete_all_dups=false) at /usr/local/src/trafficserver/proxy/hdrs/MIME.h:1169 #5 0x006b77f6 in HpackDynamicTable::add_header_field (this=0x2b068e81a150, field=0x2aaad602c128) at HPACK.cc:343 #6 0x006b763c in HpackIndexingTable::add_header_field (this=0x2b068e8193d0, field=0x2aaad602c128) at HPACK.cc:295 #7 0x006b7d96 in encode_literal_header_field_with_indexed_name (buf_start=0x2b068e825c01 "\276\344\325\364\360\363\356\355\064\016\305\004", buf_end=0x2b068e825e82 "\177", header=..., index=33, indexing_table=..., type=HPACK_FIELD_INDEXED_LITERAL) at HPACK.cc:520 #8 0x006b8ea9 in hpack_encode_header_block (indexing_table=..., out_buf=0x2b068e825c00 "\210\276\344\325\364\360\363\356\355\064\016\305\004", out_buf_len=642, hdr=0x2b7fa340) at HPACK.cc:963 #9 0x006af1d6 in http2_encode_header_blocks (in=0x2b7fa340, out=0x2b068e825c00 "\210\276\344\325\364\360\363\356\355\064\016\305\004", out_len=642, len_written=0x2b7fa298, handle=...) at HTTP2.cc:603 #10 0x006c2552 in Http2ConnectionState::send_headers_frame (this=0x2aaab201ddf8, stream=0x2aaad0c0c780) at Http2ConnectionState.cc:1271 #11 0x006b28bd in Http2Stream::update_write_request (this=0x2aaad0c0c780, buf_reader=0x2aaab0606940, write_len=322, call_update=false) at Http2Stream.cc:561 #12 0x006b15d7 in Http2Stream::do_io_write (this=0x2aaad0c0c780, c=0x2aaab1cb8988, nbytes=322, abuffer=0x2aaab0606940, owner=false) at Http2Stream.cc:314 #13 0x006a867a in HttpTunnel::producer_run (this=0x2aaab1cb8988, p=0x2aaab1cb8b90) at HttpTunnel.cc:980 #14 0x006a7dfd in HttpTunnel::tunnel_run (this=0x2aaab1cb8988, p_arg=0x2aaab1cb8b90) at HttpTunnel.cc:797 #15 0x0064d140 in HttpSM::handle_api_return (this=0x2aaab1cb7640) at HttpSM.cc:1663 #16 0x0064ca83 in HttpSM::state_api_callout (this=0x2aaab1cb7640, event=0, data=0x0) at HttpSM.cc:1545 #17 0x0065b70c in HttpSM::do_api_callout_internal (this=0x2aaab1cb7640) at HttpSM.cc:5173 #18 0x00663f4a in HttpSM::set_next_state (this=0x2aaab1cb7640) at HttpSM.cc:7430 #19 0x00662ee5 in HttpSM::call_transact_and_set_next_state (this=0x2aaab1cb7640, f=0x0) at HttpSM.cc:7206 #20 0x0064cc96 in HttpSM::handle_api_return (this=0x2aaab1cb7640) at HttpSM.cc:1607 #21 0x0064ca83 in HttpSM::state_api_callout (this=0x2aaab1cb7640, event=0, data=0x0) at HttpSM.cc:1545 #22 0x0065b70c in HttpSM::do_api_callout_internal (this=0x2aaab1cb7640) at HttpSM.cc:5173 #23 0x0066a85d in HttpSM::do_api_callout (this=0x2aaab1cb7640) at HttpSM.cc:439 #24 0x0064e201 in HttpSM::state_read_server_response_header (this=0x2aaab1cb7640, event=100, data=0x2aaab2a09700) at HttpSM.cc:1963 #25 0x00650ef6 in HttpSM::main_handler (this=0x2aaab1cb7640, event=100, data=0x2aaab2a09700) at HttpSM.cc:2663 #26 0x0057472a in Continuation::handleEvent (this=0x2aaab1cb7640, event=100, data=0x2aaab2a09700) at /usr/local/src/trafficserver/iocore/eventsystem/I_Continuation.h:153 #27 0x00806e72 in read_signal_and_update (event=100, vc=0x2aaab2a095d0) at UnixNetVConnection.cc:145 #28 0x00807ea6 in read_from_net (nh=0x2b068cd0ae50, vc=0x2aaab2a095d0, thread=0x2b068cd07000) at UnixNetVConnection.cc:411 #29 0x00809f95 in UnixNetVConnection::net_read_io
[GitHub] trafficserver issue #1592: TS-4976: Regularize plugins - hello
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1592 Why did the AU check fail? Did you forget to rebase? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1497: Doc: change .svg to .png.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1497 Yeh, that's fine, I upgraded Sphinx long ago on the Docs build box. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1589: glibc 2.25 will cause compile errors
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1589 @PSUdaemon You were mucking around in this mess a while back (even though I tried to keep you out of the rat hole ... ;). Can you take a look at this? It sounds similar to the issues you had, where we are using old, obsolete symbols and definitions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1548 @jrushford I assume we don't want this for 7.1.0 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1548 I'm fine with this. However, seeing that the two policy implementations has virtually identical implementations here, it begs the question as to why this is not in a base class? It seems fragile to have two (or more) places implementation the same thing. Maybe file a new Issue on refactoring some of this into the base class? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1588: Make clear the implicit relationship betwe...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1588 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1587: Intermittent regression test failures (debug buil...
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1587
Intermittent regression test failures (debug build)
Seeing this on some VMs:
```
REGRESSION TEST SDK_API_HttpTxnTransform started
[SDK_API_HttpTxnTransform] TSTransformCreate : [TestCase1] <> { ok }
[SDK_API_HttpTxnTransform] TSHttpTxnTransformRespGet : [TestCase] <>
{ ok }
Fatal: ../../proxy/InkIOCoreAPI.cc:545: failed assertion
`sdk_sanity_check_iocore_structure(bufp) == TS_SUCCESS`
blah5
X-7: blah7
X-9: blah9
```
This is on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1586: Update the list of overridable configs
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1586 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1583 This is running on Docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1583 This sounds like a 7.1.0 candidate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1502 Please rebase with current master, and also run "make clang-format" on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1502: issue #1501: reconstruct to load the defau...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1502#discussion_r106057816
--- Diff: proxy/ControlMatcher.cc ---
@@ -220,6 +220,7 @@ HostMatcher<Data, MatchResult>::NewEntry(matcher_line
*line_info)
if (error.failed()) {
// There was a problem so undo the effects this function
memset(cur_d, 0, sizeof(Data));
+new(cur_d) Data(); //reconstruct
--- End diff --
This makes sense to me, but do we still need the memset()? It's obviously
harmless if not necessary, mostly curious.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1502 This sounds like a potential candidate for 7.1.0 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1502 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1558: redundant url encoding for logging field "cquuc"
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1558 You should upgrade to 6.2.x, if that doesn't have this fix, you can request this to be back ported to 6.2.2, since 6.2 is an LTS version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1568: TS-4195: double free on exit
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1568 Once landed, I think we should contemplate this for a 7.1.0 cherry-pick. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1565: Fix Assertion failure in the regex_revalidate plu...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1565 Merged to 7.1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1565: Fix Assertion failure in the regex_revalid...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1209: Remove unused and never to be used classes from M...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1209 Time to land this yet? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1557 See also ##776. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1371: Calling setrlimit() twice is redundant
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1371 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1503: client cert should be added to netvcoptions only ...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1503 What's the word on this PR? 1) Should we land it? 2) Do we still want this to 7.1.x? Note sure why it's been sitting for so long. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1580: change command to use python3
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1497: Doc: change .svg to .png.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1497 @SolidWallOfCode Why is this not merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1517 Note that it has to succeed on CentOS6, which is indeed running ``` [root@centos6 ~]# bison --version bison (GNU Bison) 2.4.1 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1548 @jrushford Do you want this in 7.1.0? If not, move it out to 7.2.0 please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1552: rectify a minor error in file test_intercept.lua
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1552 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1552: rectify a minor error in file test_intercept.lua
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1552 @shukitchan You ok with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1550: rectify a minor error in healthchecks.c
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1550 [approve ci] to see if the FreeBSD builds succeed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1582: Make regex_revalidate.c use ref-counted config da...
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1582 Make regex_revalidate.c use ref-counted config data Instead of scheduling a "delete" of the data sometime in the future, a more reliable pattern is to ref-count the configurations, and acquire / release as necessary through the life cycle of the TXN. This would eliminate the **free_cont**, and make things more inline with how we normally do things. Now, I haven't analyzed the code thoroughly; maybe there is a reason to use the delayed deletes. If so, just close this Issue with a "Won't Fix". @jrushford You want to take a quick look on this, and see if this is viable at least? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1565: Fix Assertion failure in the regex_revalid...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1565#discussion_r106033633
--- Diff: plugins/regex_revalidate/regex_revalidate.c ---
@@ -362,7 +362,7 @@ config_handler(TSCont cont, TSEvent event ATS_UNUSED,
void *edata ATS_UNUSED)
iptr = __sync_val_compare_and_swap(&(pstate->invalidate_list),
pstate->invalidate_list, i);
if (iptr) {
- free_cont = TSContCreate(free_handler, NULL);
+ free_cont = TSContCreate(free_handler, TSMutexCreate());
--- End diff --
I'm ok with this (assuming this solves the problem, it's not immediately
clear as to why it needs the mutex). However, this approach of a schedule
"delete" seems bad, we should change this (later) to use ref-counted data
instead. That would eliminate the entire free_cont, and is a better / more
reliable pattern.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1576: Add option to choose interface
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1576 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1580: change command to use python3
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1580 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1576: Add option to choose interface
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1576#discussion_r106004593 --- Diff: tests/tools/microServer/uWServer.py --- @@ -17,6 +17,7 @@ # See the License for the specific language governing permissions and # limitations under the License. +#!/bin/env python3 --- End diff -- Actually, this looks wrong, why is this repeated here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1577: Update http2.test.py
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1577 I think we need to make the AU check succeed, right ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1578: Add missing include, which otherwise break...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1578 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1568: TS-4195: double free on exit
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1568 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1577: Update http2.test.py
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1577 Please file an Issue on the cleanup task, so we know about it, and it gets assigned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1577: Update http2.test.py
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1577 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1578: Add missing include, which otherwise break...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1578 Add missing include, which otherwise breaks on OSX You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver CMATH Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1578.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1578 commit 196bbe81d3d1d9ece66c5bd36992eb88350eea1a Author: Leif Hedstrom <zw...@apache.org> Date: 2017-03-14T18:22:13Z Add missing include, which otherwise breaks on OSX --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1574: Explicit std:: name space, seems to make c...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1574 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1574: Explicit std:: name space, seems to make compiler...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1574 Yeh, we want to remove the check for math.h, and the patch does. No? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1574: Explicit std:: name space, seems to make c...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1574 Explicit std:: name space, seems to make compiler happy This hopefully fixes the build errors on isnan() usage on the Ubuntu 16 platform, and also makes it clear which isnan() we use here. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver ISNAN Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1574.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1574 commit 1076ec8532cee6cb8bf6dcbdd580f574c5b490ae Author: Leif Hedstrom <zw...@apache.org> Date: 2017-03-13T23:06:31Z Explicit std:: name space, seems to make compiler happy This hopefully fixes the build errors on isnan() usage on the Ubuntu 16 platform, and also makes it clear which isnan() we use here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1573#discussion_r105749469
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
m_proxy_resp_content_type_str(nullptr),
m_proxy_resp_content_type_len(0),
m_cache_lookup_url_canon_str(nullptr),
-m_cache_lookup_url_canon_len(0)
+m_cache_lookup_url_canon_len(-1)
--- End diff --
```
diff --git a/proxy/logging/LogAccessHttp.cc b/proxy/logging/LogAccessHttp.cc
index 95a620e..b3b7490 100644
--- a/proxy/logging/LogAccessHttp.cc
+++ b/proxy/logging/LogAccessHttp.cc
@@ -57,9 +57,9 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
m_server_response(nullptr),
m_cache_response(nullptr),
m_client_req_url_str(nullptr),
-m_client_req_url_len(0),
+m_client_req_url_len(-1),
m_client_req_url_canon_str(nullptr),
-m_client_req_url_canon_len(0),
+m_client_req_url_canon_len(-1),
m_client_req_unmapped_url_canon_str(nullptr),
m_client_req_unmapped_url_canon_len(-1),
m_client_req_unmapped_url_path_str(nullptr),
@@ -67,9 +67,9 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
m_client_req_unmapped_url_host_str(nullptr),
m_client_req_unmapped_url_host_len(-1),
m_client_req_url_path_str(nullptr),
-m_client_req_url_path_len(0),
+m_client_req_url_path_len(-1),
m_proxy_resp_content_type_str(nullptr),
-m_proxy_resp_content_type_len(0),
+m_proxy_resp_content_type_len(-1),
m_cache_lookup_url_canon_str(nullptr),
m_cache_lookup_url_canon_len(-1)
{
```
But, I think I'd prefer to defer this until after we land this, to minimize
last minute breakage of 7.1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1573#discussion_r105746991 --- Diff: proxy/logging/LogAccessHttp.cc --- @@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm) m_proxy_resp_content_type_str(nullptr), m_proxy_resp_content_type_len(0), m_cache_lookup_url_canon_str(nullptr), -m_cache_lookup_url_canon_len(0) +m_cache_lookup_url_canon_len(-1) --- End diff -- Maybe, not sure which (if any) should stay zero though. But it seems the URL ones ought to be consistently -1. Let me check that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1412: Assertion in HttpSM::tunnel_handler_post
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1412 I'll see if I can get a core out of this again, for some reason, the box isn't producing core files :/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1412: Assertion in HttpSM::tunnel_handler_post
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1412 We're still seeing this on Docs, with the current 7.1.x and all the backports. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1573 #1481 Makes % work consistently, and at all You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver CLUC Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1573.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1573 commit 76fe1c6a4158e6ffaedd3c8d78c94a4edb81fce7 Author: Leif Hedstrom <zw...@apache.org> Date: 2017-03-13T17:14:24Z #1481 Makes % work consistently, and at all --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1535: Cleanup new tests/ tree with RAT exclusions / lic...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1535 This is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1535: Cleanup new tests/ tree with RAT exclusions / lic...
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1426: issue #1399 add code of tcp_congestion_control er...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1426 This is now back ported to 7.1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1561: A new 7.1 Crash with regex_revalidate config upda...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1561 Yeh, I think you have to create the mutex. Before all these changes, the core would create one for you if it needed it, but that had a massive single mutex around that. So instead, we now assert, and the plugins must be updated, because they are using APIs that requires the mutex. It is possible there's a bug somewhere, but odds are that the plugin is using an API that needs a cont mutex. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1544: AddressSanitizer failed to deallocate
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1544 Duplicate of #1498. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1544: AddressSanitizer failed to deallocate
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1544 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1558: redundant url encoding for logging field "cquuc"
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1558 What version is this? I could have sworn we fixed this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1560: Replace all usage (and implementation) of Vec<> w...
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1560 Replace all usage (and implementation) of Vec<> with std::vector @SolidWallOfCode says that it's better, and I like consistency, so we should unify the code around using one vector implementation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1335: Deadlock in HostDB
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1335 @jacksontj @vmamidi is working on this, and has a fix (hopefully). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1412: Assertion in HttpSM::tunnel_handler_post
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1412 @oknet Did any of your commits address this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1527: More and slower active connections in 7.1.x
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1527 On our boxes, it was very noticeable. I can try again, but the net result was roughly 2-3x the number of active connections, and each transaction was 1/2 - 1/3 the speed (throughput in Mbps). This was measured for large downloads, greater than 1MB in object size. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1446 @shinrich @oknet Is this still a 7.1.0 candidate? Or do we move out to 7.2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1426: issue #1399 add code of tcp_congestion_control er...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1426 @maskit should we backport this to 7.1.0 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1526: When SSL connect fails, we return 502 success
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1526 I'd like to put this in for 7.1.0 I think. Any objections? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1531: Assertion in state_read_server_response_header (v...
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1559: Do not callback one SM EVENT_ERROR twice.
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1481: Log Field % always outputs "-"
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1481 Yeh, I suck. Patch coming. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1559: Do not callback one SM EVENT_ERROR twice.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1559#discussion_r105187896
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -271,9 +271,22 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc,
EThread *thread)
// if it is a non-temporary error, we should die appropriately
if (err && err != EAGAIN && err != EINTR) {
- read_signal_error(nh, vc, err);
+ Continuation *reader_cont = vc->read.vio._cont;
+
+ if (read_signal_error(nh, vc, err) == EVENT_DONE) {
+return;
+ }
+ // If vc is closed or shutdown(WRITE) in last read_signal_error
callback,
+ // or reader_cont is same as write.vio._cont.
--- End diff --
Great comment, this really helps explaining the issue / solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1559 Nice! Testing this PR on docs.trafficserver now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1559 @oknet Yes, ignore AU tests for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1557: brotli support in gzip plugin
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1557 I need to read this some more, but it feels like we need a configuration option here as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1554 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1267 @jrushford Question: do we want this into 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1554 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
