[GitHub] trafficserver pull request #1150: TS-5007: 1356983 initialize test value pro...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1151: TS-5010: Initialize the regex pointer prop...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1154: TS-5011: Fixes memory leak in CLFUS compre...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1154 TS-5011: Fixes memory leak in CLFUS compression You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-5011 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1154.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1154 commit 8208a38d65ccf5afe3adce87667aff3804592759 Author: John Plevyak <jplev...@apache.org> Date: 2016-10-26T23:47:02Z TS-5011: Fixes memory leak in CLFUS compression --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1154: TS-5011: Fixes memory leak in CLFUS compression
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1154 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1151: TS-5010: Initialize the regex pointer prop...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1151 TS-5010: Initialize the regex pointer properly You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-5010 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1151 commit 5897ae4b9b1d41f95282283d433ca406c5814501 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-26T23:19:27Z TS-5010: Initialize the regex pointer properly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1149: TS-5008 CID 1022007 Logically dead code
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1149 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1146: TS-5005: CID 1364117: Explicit null derefe...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1148: Make master work on OmniOS.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1148 Does this need to go into 7.0.0 as well? @bryancall --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1140: TS-5006: Fix CID 1356975
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1140#discussion_r85228363
--- Diff: proxy/http/HttpSM.cc ---
@@ -3309,7 +3309,7 @@ HttpSM::tunnel_handler_ua(int event,
HttpTunnelConsumer *c)
// only external POSTs should be subject to this logic; ruling out
internal POSTs here
bool is_eligible_post_request = (t_state.method == HTTP_WKSIDX_POST);
-if (is_eligible_post_request) {
+if (is_eligible_post_request && ua_session) {
--- End diff --
I don't know this code much, but seeing that we don't crash here,
presumably ua_session generally is not NULL here. So maybe a better thing is a
release assert?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1140: Fix CID 1356975
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1140 This needs a Jira number. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1146: TS-5005: CID 1364117: Explicit null derefe...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1146 TS-5005: CID 1364117: Explicit null dereferenced in HttpSM.cc Probably benign, since the vc shouldn't be NULL, but coverity is ruling with an iron fist. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-5005 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1146.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1146 commit b5fe8371a22ab812eecf4366ac451a2563c29ad4 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-26T21:39:16Z TS-5005: CID 1364117: Explicit null dereferenced in HttpSM.cc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1143: TS-4582: Do not allow multiple --policy ar...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1142: Fix CID 1306780
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1142 You should use the Jira number. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1143: TS-4582: Do not allow multiple --policy ar...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1143 TS-4582: Do not allow multiple --policy arguments You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4582 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1143.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1143 commit d34aa7f1b02f42f487116dfe0bddbc17276f9841 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-26T18:22:53Z TS-4582: Do not allow multiple --policy arguments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1137: TS-5000: Move sslheaders into the non-recu...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1136: TS-5000: Moves experimental plugins to the...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1136 TS-5000: Moves experimental plugins to the new include mechanism You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-5000 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1136.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1136 commit e77ea8ee6228df3925f40ff160f56055a00697a3 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-26T04:22:27Z TS-5000: Moves experimental plugins to the new include mechanism --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1133: TS-4993: Disables escaping and quotes inside rege...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1133 Randall and I ran into another issue with this patch, so doing some more debugging :-/. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1133#discussion_r84770706
--- Diff: plugins/header_rewrite/parser.cc ---
@@ -133,14 +152,15 @@ Parser::preprocess(std::vector tokens)
std::string s = tokens[0].substr(2, tokens[0].size() - 3);
_op = s;
- if (tokens.size() > 2 && (tokens[1][0] == '=' || tokens[1][0] == '>'
|| tokens[1][0] == '<')) { // cond + (=/) + argument
+ if (tokens.size() > 2 && (tokens[1][0] == '=' || tokens[1][0] == '>'
|| tokens[1][0] == '<')) {
+// cond + [=<>] + argument
_arg = tokens[1] + tokens[2];
} else if (tokens.size() > 1) {
+// This is for the regular expression, which for some reason has
its own handling?? ToDo: Why ?
--- End diff --
The comment? It's what it says, that case is for the regular expression
case, I kinda wish we had treated / as the other operators (=, < and >), but we
do not. And I don't think this is the time to change that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1133#discussion_r84729282
--- Diff: plugins/header_rewrite/header_rewrite_test.cc ---
@@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] =
"TEST_dbg_header_rewrite";
extern "C" void
TSError(const char *fmt, ...)
{
- char buf[2048];
- int bytes = 0;
- va_list args;
- va_start(args, fmt);
- if ((bytes = vsnprintf(buf, sizeof(buf), fmt, args)) > 0) {
-fprintf(stderr, "TSError: %s: %.*s\n", PLUGIN_NAME, bytes, buf);
- }
- va_end(args);
}
-extern "C" void
-TSDebug(const char *tag, const char *fmt, ...)
-{
- char buf[2048];
- int bytes = 0;
- va_list args;
- va_start(args, fmt);
- if ((bytes = vsnprintf(buf, sizeof(buf), fmt, args)) > 0) {
-fprintf(stdout, "TSDebug: %s: %.*s\n", PLUGIN_NAME, bytes, buf);
- }
- va_end(args);
-}
-
-#define CHECK_EQ(x, y) \
- do { \
-if ((x) != (y)) {\
- fprintf(stderr, "CHECK FAILED\n"); \
- return 1; \
-}\
- } while (false);
-
class ParserTest : public Parser
{
public:
- ParserTest(std::string line) : Parser(line) {}
+ ParserTest(std::string line) : Parser(line), res(true) { std::cout <<
"Starting parser test: " << line << std::endl; }
std::vector
getTokens()
{
return _tokens;
}
+
+ template
+ void
+ do_parser_check(T x, U y, int line = 0)
+ {
+if (x != y) {
+ std::cerr << "CHECK FAILED on line " << line << ": " << x << " != "
<< y << std::endl;
+ res = false;
+}
+ }
+
+ bool res;
--- End diff --
That's the check :). This is what DO_CHECK() used to do as a macro, but I
turned it into a templetized function so that DO_CHECK can produce output about
the check for the various types of input parameters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1133#discussion_r84723539
--- Diff: plugins/header_rewrite/header_rewrite_test.cc ---
@@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] =
"TEST_dbg_header_rewrite";
extern "C" void
TSError(const char *fmt, ...)
{
- char buf[2048];
- int bytes = 0;
- va_list args;
- va_start(args, fmt);
- if ((bytes = vsnprintf(buf, sizeof(buf), fmt, args)) > 0) {
-fprintf(stderr, "TSError: %s: %.*s\n", PLUGIN_NAME, bytes, buf);
- }
- va_end(args);
--- End diff --
So, the issue was that there are two test cases that are intended to fail.
When running this from command line (to verify / analyze tests), it would
therefore always produce two errors on the output. I found this confusing as
hell, thinking that the parser was actually failing (which it was not). So, I
removed this, so it produces no output, and instead the test now properly
detect the errors, and produce more useful information when they do fail
unexpectedly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1133#discussion_r84770538
--- Diff: plugins/header_rewrite/parser.cc ---
@@ -133,14 +152,15 @@ Parser::preprocess(std::vector tokens)
std::string s = tokens[0].substr(2, tokens[0].size() - 3);
_op = s;
- if (tokens.size() > 2 && (tokens[1][0] == '=' || tokens[1][0] == '>'
|| tokens[1][0] == '<')) { // cond + (=/) + argument
+ if (tokens.size() > 2 && (tokens[1][0] == '=' || tokens[1][0] == '>'
|| tokens[1][0] == '<')) {
+// cond + [=<>] + argument
--- End diff --
Remove what?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1133#discussion_r84770458
--- Diff: plugins/header_rewrite/header_rewrite_test.cc ---
@@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] =
"TEST_dbg_header_rewrite";
extern "C" void
TSError(const char *fmt, ...)
{
- char buf[2048];
- int bytes = 0;
- va_list args;
- va_start(args, fmt);
- if ((bytes = vsnprintf(buf, sizeof(buf), fmt, args)) > 0) {
-fprintf(stderr, "TSError: %s: %.*s\n", PLUGIN_NAME, bytes, buf);
- }
- va_end(args);
}
-extern "C" void
-TSDebug(const char *tag, const char *fmt, ...)
-{
- char buf[2048];
- int bytes = 0;
- va_list args;
- va_start(args, fmt);
- if ((bytes = vsnprintf(buf, sizeof(buf), fmt, args)) > 0) {
-fprintf(stdout, "TSDebug: %s: %.*s\n", PLUGIN_NAME, bytes, buf);
- }
- va_end(args);
-}
-
-#define CHECK_EQ(x, y) \
- do { \
-if ((x) != (y)) {\
- fprintf(stderr, "CHECK FAILED\n"); \
- return 1; \
-}\
- } while (false);
-
class ParserTest : public Parser
{
public:
- ParserTest(std::string line) : Parser(line) {}
+ ParserTest(std::string line) : Parser(line), res(true) { std::cout <<
"Starting parser test: " << line << std::endl; }
std::vector
getTokens()
{
return _tokens;
}
+
+ template
+ void
+ do_parser_check(T x, U y, int line = 0)
+ {
+if (x != y) {
+ std::cerr << "CHECK FAILED on line " << line << ": " << x << " != "
<< y << std::endl;
+ res = false;
+}
+ }
+
+ bool res;
};
+#define CHECK_EQ(x, y) \
+ do { \
+p.do_parser_check((x), (y), __LINE__); \
+ } while (false);
+
+#define END_TEST(s) \
+ do { \
+if (!p.res) { \
+ ++errors; \
+} \
+ } while (false);
+
int
test_parsing()
{
+ int errors = 0;
+
{
ParserTest p("cond %{READ_REQUEST_HDR_HOOK}");
-CHECK_EQ(p.getTokens().size(), 2);
+
+CHECK_EQ(p.getTokens().size(), 2U);
CHECK_EQ(p.getTokens()[0], "cond");
CHECK_EQ(p.getTokens()[1], "%{READ_REQUEST_HDR_HOOK}");
+
+END_TEST();
}
{
ParserTest p("cond %{CLIENT-HEADER:Host}=a");
-CHECK_EQ(p.getTokens().size(), 4);
+
+CHECK_EQ(p.getTokens().size(), 4UL);
CHECK_EQ(p.getTokens()[0], "cond");
CHECK_EQ(p.getTokens()[1], "%{CLIENT-HEADER:Host}");
CHECK_EQ(p.getTokens()[2], "=");
CHECK_EQ(p.getTokens()[3], "a");
+
+END_TEST();
}
{
ParserTest p(" # COMMENT!");
-CHECK_EQ(p.getTokens().size(), 0);
+
+CHECK_EQ(p.getTokens().size(), 0UL);
CHECK_EQ(p.empty(), true);
+
+END_TEST();
}
{
ParserTest p("# COMMENT");
-CHECK_EQ(p.getTokens().size(), 0);
+
+CHECK_EQ(p.getTokens().size(), 0UL);
CHECK_EQ(p.empty(), true);
+
+END_TEST();
}
{
ParserTest p("cond %{Client-HEADER:Foo} =b");
-CHECK_EQ(p.getTokens().size(), 4);
+
+CHECK_EQ(p.getTokens().size(), 4UL);
CHECK_EQ(p.getTokens()[0], "cond");
CHECK_EQ(p.getTokens()[1], "%{Client-HEADER:Foo}");
CHECK_EQ(p.getTokens()[2], "=");
CHECK_EQ(p.getTokens()[3], "b");
+
+END_TEST();
}
{
ParserTest p("cond %{Client-HEADER:Blah} =x");
-CHECK_EQ(p.getTokens().size(), 4);
+
+CHECK_EQ(p.getTokens().size(), 4UL);
CHECK_EQ(p.getTokens()[0], "cond");
CHECK_EQ(p.getTokens()[1], "%{Client-HEADER:Blah}");
CHECK_EQ(p.getTokens()[2], "=");
CHECK_EQ(p.getTokens()[3], "x");
+
+END_TEST();
}
{
ParserTest p("cond %{CLIENT-HEADER:non_existent_header} = \"shouldnt_
exist_anyway\" [AND]");
-CHECK_EQ(p.getTokens().size(), 5);
+
+CHECK_EQ(p.getTokens().size(), 5UL);
CHECK_EQ(p.getTokens()[0], "cond");
CHECK_EQ(p.getTokens()[1], "%{CL
[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1134 Hmmm, are we sure this makes sense? The CPP APIs aren't plugins, and we certainly don't put the TS API's into plugins. I could perhaps see this go into proxy somewhere. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1133 TS-4993: Disables escaping and quotes inside regexes In addition, this cleans up the unit tests a bit, to make it more useful from the command line when testing/debugging. New tests are also added for regular expression parse testing. Note: This restores 6.1.x functionality in 7.x, however, it's not compatible with 5.3.x. I do feel that this is the right approach, because it retains PCRE compatibility within the // that indicates a regex. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4993 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1133.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1133 commit 75757f3eb4a50d1c80997356e6df2d001e32d360 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-22T01:18:43Z TS-4993: Disables escaping and quotes inside regexes In addition, this cleans up the unit tests a bit, to make it more useful from the command line when testing/debugging. New tests are also added for regular expression parse testing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1128 @jsime Can you review please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1129: TS-4992: Do not build the static libraries
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1129 TS-4992: Do not build the static libraries You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4992 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1129 commit 152c3ef9b74e7fe94106c6b7579dc469620ed226 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-20T18:43:49Z TS-4992: Do not build the static libraries --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1125: TS-4987: Don't prefer loopback over API set origi...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1125 I see. The first portion of this patch is important, whereas the second portion is done (better?) in #1079. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1115: RFC: Build with non-recursive make.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1115 Besides the failures ( ;-) ) I think this is something we should do. It's a fairly simple change (hopefully), retains the modularity (by retaining the Makefile.inc's and then include them), and allow for much more parallelized builds. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1125: TS-4987: Don't prefer loopback over API set origi...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1125 Looking back, it seems this is basically handled (but better) with #1079 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1117: TS-4916 Add safety net to avoid H2-infinit...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1117: TS-4916 Add safety net to avoid H2-infinite-loop ...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1117 Sigh, it failed again on the bison generated files :-/. [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1117: TS-4916 Add safety net to avoid H2-infinit...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1117#discussion_r83908521
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -675,6 +675,17 @@ Http2Stream::destroy()
}
chunked_handler.clear();
super::destroy();
+
+ // Current Http2ConnectionState implementation uses a memory pool for
instantiating streams and DLL<> stream_list for storing
+ // active streams. Destroying a stream before deleting it from
stream_list and then creating a new one + reusing the same chunk
+ // from the memory pool right away always leads to destroying the DLL
structure (deadlocks, inconsistencies).
+ // The following is meant as a safety net since the consequences are
disastrous. Until the design/implementation changes it seems
+ // less error prone to (double) delete before destroying (noop if
already deleted).
+ if (parent) {
+static_cast(parent)->connection_state.delete_stream(this);
+Warning("Http2Stream was about to be deallocated without removing it
from the active stream list");
--- End diff --
We are sure this is not going to produce a lot of warnings, right ? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1116: TS-4979: Fix clang-analyzer complaint abou...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1116#discussion_r83893797
--- Diff: proxy/http/HttpTransact.cc ---
@@ -1075,6 +1073,8 @@ HttpTransact::ModifyRequest(State *s)
if (!request.is_target_in_url()) {
s->hdr_info.client_req_is_server_style = true;
}
+ // Make Coverity happy. hostname is non-null iff
request.is_target_in_url().
--- End diff --
Since we're bike shedding, this probably should have said "clang-analyzer".
;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1078: TS-4930: Unfolds request headers that are ...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1078 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1109 Is this a duplicate PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1114: TS-4976: Remove useless casts from plugins.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1114 Clang format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1090: TS-4949: Disables the fuzzy revalidation l...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1090 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1101: TS-4959: Remove remnants of old UA configu...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1101: TS-4959: Remove remnants of old UA configurations...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1101 Rebuilding again, because I think the trees on the buildbots was busted [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1100: TS-4916: Fix for an H2-infinite-loop deadlock
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1100 Try again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1100: TS-4916: Fix for an H2-infinite-loop deadlock
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1100 Try again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1101: TS-4959: Remove remnants of old UA configu...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1101 TS-4959: Remove remnants of old UA configurations and handling I made this as two commits: 1) Remove some definitely strange code around MSIE. 2) Remove all the code around the accept_encoding_filter_enabled. For #2, this configuration doesn't actually exist in RecordsConfig.cc, and it's also missing all possible ways of configuring the regular expressions that it needs. So I figured, we can just nuke it :). You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4959 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1101.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1101 commit 2e2fad5dc67999f0831f8481b61e04408844228c Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-12T19:51:08Z TS-4959: Remove remnants of an old browser commit 25b7900a4574edf9b11bcb02307e02a310e80c41 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-12T21:18:24Z TS-4959: Remove remnants of an configuration / UA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1100: TS-4916: Fix for an H2-infinite-loop deadlock
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1100 Just a heads up, but this PR is against 6.2.x branch, the code has diverged, so will need one PR for 6.2.x and one for master. @gtenev Please make a PR for master at your earliest convenience as well, but sounds like they will be so different that we need two reviews. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1099: TS-4916: Fix for an H2-infinite-loop deadlock
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1099 @gtenev This looks very strange, did you pull/rebase your tree first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1081: TS-3204: Crash when body_factory file is e...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1081 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1097: Make the use of madvise() with MADV_DONTDU...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1097#discussion_r82917530
--- Diff: mgmt/RecordsConfig.cc ---
@@ -1449,6 +1449,8 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.allocator.hugepages", RECD_INT, "0",
RECU_RESTART_TS, RR_NULL, RECC_NULL, "[0-1]", RECA_NULL}
,
+ {RECT_CONFIG, "proxy.config.allocator.dontdump_iobuffers", RECD_INT,
"0", RECU_RESTART_TS, RR_NULL, RECC_NULL, "[0-1]", RECA_NULL}
--- End diff --
I'm ok with that, but that means this also should be back ported to 7.0.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1088: TS-4915: Crash from hostdb in PriorityQueueLess
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1088 Clang-format ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1090: TS-4949: Disables the fuzzy revalidation logic by...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1090 I'll leave this sitting for another day or so, we had already (in April I think) marked these as deprecated for 6.2.0, and no one objected then either. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1089 Maybe you have to rebase this from master, to get the clang-format fixes that were done yesterday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1090: TS-4949: Disables the fuzzy revalidation l...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1090 TS-4949: Disables the fuzzy revalidation logic by default You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4949 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1090.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1090 commit b118eeea8974e8d77b09bca9f1acc9443f8faf2c Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-11T16:18:07Z TS-4949: Disables the fuzzy revalidation logic by default --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1087: TS-4945: Remove unused member variable, ep...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1087 TS-4945: Remove unused member variable, epoll_vc CID 1364096 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4945 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1087.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1087 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1076: TS-4929: No loading of HostDB disk file if...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1076 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1076: TS-4929: No loading of HostDB disk file if sync_f...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1076 Yes, they would have TTLs, but if I turned off syncing, I certainly wouldn't expect it to load something old. What if I had bad entries? What if I had a corruption of some sort? Since it will never update it, you are stuck with loading old (possibly stale or more likely expired) entries for the remaining of life? That just makes no sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1078: TS-4930: Unfolds request headers that are using o...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1078 Try build on freebsd again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1074: TS-4925: Manager pollMgmtProcessServer stuck with...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1074 I'd imagine this is a backport candidate for at least 7.0.0, maybe 6.2.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1074: TS-4925: Manager pollMgmtProcessServer stuck with...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1074 @gtenev Can you review this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1078: TS-4930: Unfolds request headers that are ...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1078 TS-4930: Unfolds request headers that are using obs continuations I also removed a file that is basically a duplication of another file, and this duplicated file is not used at all. This confused me as I was testing and updating the regression tests. Basically, that old test app is already incorporated into the regression tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4930 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1078.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1078 commit d01e11b908b9368bf2e741d46626d989d9e76531 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-04T17:22:05Z TS-4930: Unfolds request headers that are using obs continuations commit 544b343a37bda25a36ecb28f36a614b558ff43ab Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-04T20:48:01Z TS-4930: Removes an old test file, it duplicates HdrTest.cc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1076: TS-4929: No loading of HostDB disk file if...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1076 TS-4929: No loading of HostDB disk file if sync_frequency=0 This has two benefit (2) is most important I think: 1) We avoid warnings on startup about not being able to load the HostDB. 2) Since in 7.0.0, turning off syncing (sync_frequency=0) completely disables writing to HostDB, it's now possible to end up loading a potentially stale HostDB from a previous upgrade. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4929 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1076.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1076 commit b89513b698ea72a09cb700a83ee4102413a708e8 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-10-04T16:54:31Z TS-4929: No loading of HostDB disk file if sync_frequency=0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1071: Support new 'Forwarded' standard (RFC7239)
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1071 Right, but your comments say "replaces". I think we should keep both, indefinitely. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1071: Support new 'Forwarded' standard (RFC7239)
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1071 We should make the old behavior optional to enable as well, there's a significant number of backends (origins) that do not support RFC7239 yet but need the old semantics. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1067: TS-4914: Fix response headers on 304 response
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1067 Mostly out of curiosity, is there a particular header here in the (limited) set of headers that is likely to have multi-values? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1066 I'm generally ok with this, up to you if you wish to clean anything up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1066: [TS-4457] Via header always reports http1
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1066#discussion_r81416662
--- Diff: proxy/http/HttpTransactHeaders.cc ---
@@ -812,26 +813,16 @@
HttpTransactHeaders::insert_via_header_in_response(HttpTransact::State *s, HTTPH
}
char *incoming_via = s->via_string;
- int scheme = s->next_hop_scheme;
+ ink_assert(s->state_machine);
- ink_assert(scheme >= 0);
- int scheme_len = hdrtoken_index_to_length(scheme);
- int32_t hversion = header->version_get().m_version;
-
- memcpy(via_string, hdrtoken_index_to_wks(scheme), scheme_len);
- via_string += scheme_len;
-
- // Common case (I hope?)
- if ((HTTP_MAJOR(hversion) == 1) && HTTP_MINOR(hversion) == 1) {
-memcpy(via_string, "/1.1 ", 5);
-via_string += 5;
- } else {
-*via_string++ = '/';
-*via_string++ = '0' + HTTP_MAJOR(hversion);
-*via_string++ = '.';
-*via_string++ = '0' + HTTP_MINOR(hversion);
+ char const *proto_buf[10]; // 10 seems like a reasonable number of
protos to print
+ int retval = s->state_machine->populate_client_protocol(proto_buf, 10);
--- End diff --
I believe we generally use countof() in C++ code to avoid future messes :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1066: [TS-4457] Via header always reports http1
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1066#discussion_r81413339 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -812,26 +813,16 @@ HttpTransactHeaders::insert_via_header_in_response(HttpTransact::State *s, HTTPH } char *incoming_via = s->via_string; - int scheme = s->next_hop_scheme; + ink_assert(s->state_machine); --- End diff -- Looking at the code, it seems it's setup in the ::init(), and then never unset / cleared? If so, do we even need this assert? I guess it doesn't hurt, but I don't see us do this anywhere else. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1066: [TS-4457] Via header always reports http1
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1066#discussion_r81411258
--- Diff: proxy/http/HttpTransactHeaders.cc ---
@@ -812,26 +813,16 @@
HttpTransactHeaders::insert_via_header_in_response(HttpTransact::State *s, HTTPH
}
char *incoming_via = s->via_string;
- int scheme = s->next_hop_scheme;
+ ink_assert(s->state_machine);
- ink_assert(scheme >= 0);
- int scheme_len = hdrtoken_index_to_length(scheme);
- int32_t hversion = header->version_get().m_version;
-
- memcpy(via_string, hdrtoken_index_to_wks(scheme), scheme_len);
- via_string += scheme_len;
-
- // Common case (I hope?)
- if ((HTTP_MAJOR(hversion) == 1) && HTTP_MINOR(hversion) == 1) {
-memcpy(via_string, "/1.1 ", 5);
-via_string += 5;
- } else {
-*via_string++ = '/';
-*via_string++ = '0' + HTTP_MAJOR(hversion);
-*via_string++ = '.';
-*via_string++ = '0' + HTTP_MINOR(hversion);
+ char const *proto_buf[10]; // 10 seems like a reasonable number of
protos to print
+ int retval = s->state_machine->populate_client_protocol(proto_buf, 10);
--- End diff --
Nit pick, but shouldn't this be something like countof(proto_buf) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1066: [TS-4457] Via header always reports http1
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1066#discussion_r81415497
--- Diff: proxy/http/HttpTransactHeaders.cc ---
@@ -812,26 +813,16 @@
HttpTransactHeaders::insert_via_header_in_response(HttpTransact::State *s, HTTPH
}
char *incoming_via = s->via_string;
- int scheme = s->next_hop_scheme;
+ ink_assert(s->state_machine);
- ink_assert(scheme >= 0);
- int scheme_len = hdrtoken_index_to_length(scheme);
- int32_t hversion = header->version_get().m_version;
-
- memcpy(via_string, hdrtoken_index_to_wks(scheme), scheme_len);
- via_string += scheme_len;
-
- // Common case (I hope?)
- if ((HTTP_MAJOR(hversion) == 1) && HTTP_MINOR(hversion) == 1) {
-memcpy(via_string, "/1.1 ", 5);
-via_string += 5;
- } else {
-*via_string++ = '/';
-*via_string++ = '0' + HTTP_MAJOR(hversion);
-*via_string++ = '.';
-*via_string++ = '0' + HTTP_MINOR(hversion);
+ char const *proto_buf[10]; // 10 seems like a reasonable number of
protos to print
+ int retval = s->state_machine->populate_client_protocol(proto_buf, 10);
+ for (int i = 0; i < retval; i++) {
+memcpy(via_string, proto_buf[i], strlen(proto_buf[i]));
--- End diff --
Is there any risk that we'll end up consuming too much of the Via: string
now? Or is the 1024 bytes still sufficient for all foreseeable protocol
additions? (It'd be a crazy long header if it was anyways :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #502: AARCH64 fixes tested on Cavium ThunderX
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/502 Ping on this? Do we still want to move along with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1055: TS-4899: Http2ClientSession object leaks.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1055 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1025: TS-4872: Fix clang-analyzer leak error on LogObje...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1025 Should we land this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1052: TS-4813: Fix lingering stream.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1052 I tried this on docs, and it fails fast: ``` (gdb) bt #0 0x740305f7 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x74031ce8 in __GI_abort () at abort.c:90 #2 0x76c1d01d in ink_abort (message_format=0x76c48920 "%s:%d: failed assertion `%s`") at ink_error.cc:79 #3 0x76c16bf7 in _ink_assert (expression=0xb834a0 "client_streams_in_count > 0", file=0xb82840 "Http2ConnectionState.cc", line=1001) at ink_assert.cc:37 #4 0x007b0b81 in Http2ConnectionState::delete_stream (this=0x2aaab121de90, stream=0x2aaab1624840) at Http2ConnectionState.cc:1001 #5 0x007b2edb in Http2ConnectionState::send_data_frames (this=0x2aaab121de90, stream=0x2aaab1624840) at Http2ConnectionState.cc:1185 #6 0x0078eeb1 in Http2Stream::do_io_close (this=0x2aaab1624840) at Http2Stream.cc:330 #7 0x006aa3d9 in HttpSM::tunnel_handler_ua (this=0x2aaab1ae6a00, event=103, c=0x2aaab1ae7d50) at HttpSM.cc:3320 #8 0x0077d5f6 in HttpTunnel::consumer_handler (this=0x2aaab1ae7d08, event=103, c=0x2aaab1ae7d50) at HttpTunnel.cc:1394 #9 0x0077f018 in HttpTunnel::main_handler (this=0x2aaab1ae7d08, event=103, data=0x2aaab1624bd0) at HttpTunnel.cc:1649 #10 0x0053b8af in Continuation::handleEvent (this=0x2aaab1ae7d08, event=103, data=0x2aaab1624bd0) at ../iocore/eventsystem/I_Continuation.h:153 #11 0x0078d25c in Http2Stream::main_event_handler (this=0x2aaab1624840, event=103, edata=0x2be03d20) at Http2Stream.cc:88 #12 0x0053b8af in Continuation::handleEvent (this=0x2aaab1624840, event=103, data=0x2be03d20) at ../iocore/eventsystem/I_Continuation.h:153 #13 0x00ab82a1 in EThread::process_event (this=0x7fffefbe7800, e=0x2be03d20, calling_code=103) at UnixEThread.cc:146 #14 0x00ab8903 in EThread::execute (this=0x7fffefbe7800) at UnixEThread.cc:200 #15 0x00ab6b4b in spawn_thread_internal (a=0x60419110) at Thread.cc:84 #16 0x74ae1dc5 in start_thread (arg=0x7fffef3d2700) at pthread_create.c:308 #17 0x740f1ced in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:113 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1035: TS-4866: Makes traffic_cop killing optiona...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1035 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #963: TS-4815 - CID 1267839 dead code in /mgmt/api/CfgCo...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/963 @ngara Maybe I'm reading this wrong, but it looks like we still have 3 commits in this PR. If that's the case, can you please squash that down into a single commit? No reason to have the 2 previous versions in the git commit history. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1028: TS-4870 Avoid marking storage offline multiple ti...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1028 @jpeach we ok to land this now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1035: TS-4866: Makes traffic_cop killing optiona...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1035 TS-4866: Makes traffic_cop killing optional This adds a new configuration option, proxy.config.cop.active_health_checks: 0 - traffic_cop is not allowed to kill any processes 1 - Only traffic_manager can be killed on failed health checks 2 - Only traffic_server can be killed on failed health checks 3 - traffic_server and traffic_manager can be killed on failure (default) You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4866 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1035.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1035 commit 6c609d4acbf9de7524527f720b68dcd62c982812 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-09-19T22:19:25Z TS-4866: Makes traffic_cop killing optional This adds a new configuration option, proxy.config.cop.active_health_checks: 0 - traffic_cop is not allowed to kill any processes 1 - Only traffic_manager can be killed on failed health checks 2 - Only traffic_server can be killed on failed health checks 3 - traffic_server and traffic_manager can be killed on failure (default) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #749: TS-4506 Don't remove Expires/Last-Modifed o...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/749 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1024 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #993: TS-4068: Changes default for server_ports t...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/993 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #993: TS-4068: Changes default for server_ports to inclu...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/993 Alan, no, it'll work afaik. It'll only fail if you go out of the way and remove the IPv6 kernel module. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1014: TS-4861: Turn ECONNRESET into an end-of-file.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1014 Please test on docs, cursory code review looks good. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #995: TS-4731: Changes return codes for IsInterna...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/995 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1010: Fix remap filtering for nonstandard methods
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1010
Clang-forma, trailing white spaces here:
```C++
-} else {
+} else {
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1010: Fix remap filtering for nonstandard methods
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1010 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1009: TS-4853 : Parent Consistent Hash Selection - add ...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1009 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1007: TS-4703: Add API to retrieve client protocols
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1007 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1006: TS-3743: Avoid crash due to accessing dead sessio...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1006 Clang format i think --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/834 IMO, the proposal of fname and maxdirs is a bit of a hack, solving a subset of all possible use cases. Allowing for a "parent selection URL" that can be the same, or different, than the pristine / cachekey URL would be generic. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #834: TS-4707 : Parent Consistent Hash Selection ...
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/834#discussion_r78286562 --- Diff: proxy/api/ts/ts.h --- @@ -1481,6 +1481,9 @@ tsapi TSReturnCode TSHttpTxnParentProxyGet(TSHttpTxn txnp, const char **hostname */ tsapi void TSHttpTxnParentProxySet(TSHttpTxn txnp, const char *hostname, int port); +tsapi TSReturnCode TSHttpTxnParentSelectionUrlGet(TSHttpTxn txnp, TSMBuffer bufp, TSMLoc obj); +tsapi TSReturnCode TSHttpTxnParentSelectionUrlSet(TSHttpTxn txnp, TSMBuffer bufp, TSMLoc obj); --- End diff -- There's definitely a real use case where you want to do parent selection on a different (normalized) URL that e.g. the pristine URL or cache key URL. Doing parent selection on the cache key URL would be a benefit (think of e.g. URLs with signatures, where you don't want the parent selection to include that signature). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1004: TS-4641 Changes default for proxy.config.c...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1004 TS-4641 Changes default for proxy.config.cache.hostdb.sync_frequency ⦠â¦to 0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4641 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1004.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1004 commit 6f2890776b220faced5b0cd69acbd545b0345b96 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-09-09T23:42:04Z TS-4641 Changes default for proxy.config.cache.hostdb.sync_frequency to 0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1003: TS-4752 Changes CFLAGS from -std=gnu99 to ...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1003 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1003: TS-4752 Changes CFLAGS from -std=gnu99 to -std=c1...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1003 It's a bummer, but seems devtoolset-3 on CentOS6 does not agree with -std=c11. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1003: TS-4752 Changes CFLAGS from -std=gnu99 to ...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1003 TS-4752 Changes CFLAGS from -std=gnu99 to -std=c11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4752 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1003.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1003 commit 779eda387a2d13ad69fff95a21c2d7107de14dcd Author: Leif Hedstrom <zw...@apache.org> Date: 2016-09-09T22:56:17Z TS-4752 Changes CFLAGS from -std=gnu99 to -std=c11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #977: TS-4657: SNI hook sends hook ID for events
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/977 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #995: TS-4731: Changes return codes for IsInterna...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/995 TS-4731: Changes return codes for IsInternal APIs This changes the following APIs: tsapi int TSHttpTxnIsInternal(TSHttpTxn txnp); tsapi int TSHttpSsnIsInternal(TSHttpSsn ssnp); In addition, this also removes the following APIs, that were previously deprecated: tsapi TS_DEPRECATED TSReturnCode TSHttpIsInternalRequest(TSHttpTxn txnp); tsapi TS_DEPRECATED TSReturnCode TSHttpIsInternalSession(TSHttpSsn ssnp); You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4731 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/995.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #995 commit 205beb1f19818ec9e603b409ad332f31866e2703 Author: Leif Hedstrom <zw...@apache.org> Date: 2016-09-08T20:56:16Z TS-4731: Changes return codes for IsInternal APIs This changes the following APIs: tsapi int TSHttpTxnIsInternal(TSHttpTxn txnp); tsapi int TSHttpSsnIsInternal(TSHttpSsn ssnp); In addition, this also removes the following APIs, that were previously deprecated: tsapi TS_DEPRECATED TSReturnCode TSHttpIsInternalRequest(TSHttpTxn txnp); tsapi TS_DEPRECATED TSReturnCode TSHttpIsInternalSession(TSHttpSsn ssnp); --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #995: TS-4731: Changes return codes for IsInternal APIs
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/995 Whomever is reviewing: Please make sure I got all the conditionals right, with the correct boolean logic. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #991: TS-4503: Remove the class ErrorClass and all its c...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/991 ``` ../../proxy/http/remap/UrlMapping.h:30:19: fatal error: Error.h: No such file or directory #include "Error.h" ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #993: TS-4068: Changes default for server_ports t...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/993 TS-4068: Changes default for server_ports to include IPv6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4068 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/993.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #993 commit 4d00e91d9d4c4240957791b657678d77f12c Author: Leif Hedstrom <zw...@apache.org> Date: 2016-09-08T19:44:41Z TS-4068: Changes default for server_ports to include IPv6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #984: TS-4747: if the connection of parent is not alive,...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/984 Looks reasonable to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #701: TS-4522: Should signal SM with EVENT_ERROR on erro...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/701 Status on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #989: TS-4828: gcc warning comparison between signed and...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/989 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #977: TS-4657: SNI hook sends hook ID for events
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/977
Looks good, but fails on FreeBSD for some reason:
{code}
../../../iocore/net/SSLUtils.cc:384:27: error: use of undeclared identifier
'TS_SSL_CERT_EVENT'; did you mean 'TS_SSL_CERT_HOOK'?
if (!netvc->calledHooks(TS_SSL_CERT_EVENT)) {
^
TS_SSL_CERT_HOOK
../../lib/ts/apidefs.h:290:3: note: 'TS_SSL_CERT_HOOK' declared here
TS_SSL_CERT_HOOK = TS_SSL_SNI_HOOK,
^
../../../iocore/net/SSLUtils.cc:384:27: error: cannot initialize a
parameter of type 'TSEvent' with an rvalue of type 'TSHttpHookID'
if (!netvc->calledHooks(TS_SSL_CERT_EVENT)) {
^
../../../iocore/net/P_SSLNetVConnection.h:221:41: note: passing argument to
parameter here
bool calledHooks(TSEvent /* eventId */) const { return
(this->sslHandshakeHookState != HANDSHAKE_HOOKS_PRE); }
^
{code}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
