[GitHub] trafficserver pull request #1150: TS-5007: 1356983 initialize test value pro...

2016-10-26 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1151: TS-5010: Initialize the regex pointer prop...

2016-10-26 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1154: TS-5011: Fixes memory leak in CLFUS compre...

2016-10-26 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1154 TS-5011: Fixes memory leak in CLFUS compression You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-5011

[GitHub] trafficserver issue #1154: TS-5011: Fixes memory leak in CLFUS compression

2016-10-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1154 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1151: TS-5010: Initialize the regex pointer prop...

2016-10-26 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1151 TS-5010: Initialize the regex pointer properly You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-5010 Alternatively

[GitHub] trafficserver issue #1149: TS-5008 CID 1022007 Logically dead code

2016-10-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1149 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1146: TS-5005: CID 1364117: Explicit null derefe...

2016-10-26 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1148: Make master work on OmniOS.

2016-10-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1148 Does this need to go into 7.0.0 as well? @bryancall --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver pull request #1140: TS-5006: Fix CID 1356975

2016-10-26 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1140#discussion_r85228363 --- Diff: proxy/http/HttpSM.cc --- @@ -3309,7 +3309,7 @@ HttpSM::tunnel_handler_ua(int event, HttpTunnelConsumer *c) // only external

[GitHub] trafficserver issue #1140: Fix CID 1356975

2016-10-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1140 This needs a Jira number. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1146: TS-5005: CID 1364117: Explicit null derefe...

2016-10-26 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1146 TS-5005: CID 1364117: Explicit null dereferenced in HttpSM.cc Probably benign, since the vc shouldn't be NULL, but coverity is ruling with an iron fist. You can merge this pull request

[GitHub] trafficserver pull request #1143: TS-4582: Do not allow multiple --policy ar...

2016-10-26 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1142: Fix CID 1306780

2016-10-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1142 You should use the Jira number. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1143: TS-4582: Do not allow multiple --policy ar...

2016-10-26 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1143 TS-4582: Do not allow multiple --policy arguments You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4582

[GitHub] trafficserver pull request #1137: TS-5000: Move sslheaders into the non-recu...

2016-10-26 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1136: TS-5000: Moves experimental plugins to the...

2016-10-26 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1136 TS-5000: Moves experimental plugins to the new include mechanism You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS

[GitHub] trafficserver issue #1133: TS-4993: Disables escaping and quotes inside rege...

2016-10-24 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1133 Randall and I ran into another issue with this patch, so doing some more debugging :-/. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-24 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1133#discussion_r84770706 --- Diff: plugins/header_rewrite/parser.cc --- @@ -133,14 +152,15 @@ Parser::preprocess(std::vector tokens) std::string s = tokens[0].substr

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-24 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1133#discussion_r84729282 --- Diff: plugins/header_rewrite/header_rewrite_test.cc --- @@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] = "TEST_dbg_header_rewrite";

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-24 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1133#discussion_r84723539 --- Diff: plugins/header_rewrite/header_rewrite_test.cc --- @@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] = "TEST_dbg_header_rewrite";

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-24 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1133#discussion_r84770538 --- Diff: plugins/header_rewrite/parser.cc --- @@ -133,14 +152,15 @@ Parser::preprocess(std::vector tokens) std::string s = tokens[0].substr

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-24 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1133#discussion_r84770458 --- Diff: plugins/header_rewrite/header_rewrite_test.cc --- @@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] = "TEST_dbg_header_rewrite";

[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.

2016-10-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1134 Hmmm, are we sure this makes sense? The CPP APIs aren't plugins, and we certainly don't put the TS API's into plugins. I could perhaps see this go into proxy somewhere. --- If your project

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

2016-10-23 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1133 TS-4993: Disables escaping and quotes inside regexes In addition, this cleans up the unit tests a bit, to make it more useful from the command line when testing/debugging. New tests

[GitHub] trafficserver issue #1128: Doc: tweaks and cleanup

2016-10-20 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1128 @jsime Can you review please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1129: TS-4992: Do not build the static libraries

2016-10-20 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1129 TS-4992: Do not build the static libraries You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4992 Alternatively you

[GitHub] trafficserver issue #1125: TS-4987: Don't prefer loopback over API set origi...

2016-10-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1125 I see. The first portion of this patch is important, whereas the second portion is done (better?) in #1079. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1115: RFC: Build with non-recursive make.

2016-10-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1115 Besides the failures ( ;-) ) I think this is something we should do. It's a fairly simple change (hopefully), retains the modularity (by retaining the Makefile.inc's and then include them

[GitHub] trafficserver issue #1125: TS-4987: Don't prefer loopback over API set origi...

2016-10-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1125 Looking back, it seems this is basically handled (but better) with #1079 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #1117: TS-4916 Add safety net to avoid H2-infinit...

2016-10-19 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1117: TS-4916 Add safety net to avoid H2-infinite-loop ...

2016-10-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1117 Sigh, it failed again on the bison generated files :-/. [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1117: TS-4916 Add safety net to avoid H2-infinit...

2016-10-18 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1117#discussion_r83908521 --- Diff: proxy/http2/Http2Stream.cc --- @@ -675,6 +675,17 @@ Http2Stream::destroy() } chunked_handler.clear(); super::destroy

[GitHub] trafficserver pull request #1116: TS-4979: Fix clang-analyzer complaint abou...

2016-10-18 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1116#discussion_r83893797 --- Diff: proxy/http/HttpTransact.cc --- @@ -1075,6 +1073,8 @@ HttpTransact::ModifyRequest(State *s) if (!request.is_target_in_url

[GitHub] trafficserver pull request #1078: TS-4930: Unfolds request headers that are ...

2016-10-18 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1078 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1109: TS-4970: Crash in INKVConnInternal when handle_ev...

2016-10-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1109 Is this a duplicate PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1114: TS-4976: Remove useless casts from plugins.

2016-10-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1114 Clang format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1090: TS-4949: Disables the fuzzy revalidation l...

2016-10-12 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1090 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1101: TS-4959: Remove remnants of old UA configu...

2016-10-12 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1101: TS-4959: Remove remnants of old UA configurations...

2016-10-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1101 Rebuilding again, because I think the trees on the buildbots was busted [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1100: TS-4916: Fix for an H2-infinite-loop deadlock

2016-10-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1100 Try again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1100: TS-4916: Fix for an H2-infinite-loop deadlock

2016-10-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1100 Try again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1101: TS-4959: Remove remnants of old UA configu...

2016-10-12 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1101 TS-4959: Remove remnants of old UA configurations and handling I made this as two commits: 1) Remove some definitely strange code around MSIE. 2) Remove all the code around

[GitHub] trafficserver issue #1100: TS-4916: Fix for an H2-infinite-loop deadlock

2016-10-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1100 Just a heads up, but this PR is against 6.2.x branch, the code has diverged, so will need one PR for 6.2.x and one for master. @gtenev Please make a PR for master at your earliest convenience

[GitHub] trafficserver issue #1099: TS-4916: Fix for an H2-infinite-loop deadlock

2016-10-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1099 @gtenev This looks very strange, did you pull/rebase your tree first? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1081: TS-3204: Crash when body_factory file is e...

2016-10-12 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1081 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1097: Make the use of madvise() with MADV_DONTDU...

2016-10-11 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1097#discussion_r82917530 --- Diff: mgmt/RecordsConfig.cc --- @@ -1449,6 +1449,8 @@ static const RecordElement RecordsConfig[] = , {RECT_CONFIG

[GitHub] trafficserver issue #1088: TS-4915: Crash from hostdb in PriorityQueueLess

2016-10-11 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1088 Clang-format ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1090: TS-4949: Disables the fuzzy revalidation logic by...

2016-10-11 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1090 I'll leave this sitting for another day or so, we had already (in April I think) marked these as deprecated for 6.2.0, and no one objected then either. --- If your project is set up

[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...

2016-10-11 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1089 Maybe you have to rebase this from master, to get the clang-format fixes that were done yesterday. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request #1090: TS-4949: Disables the fuzzy revalidation l...

2016-10-11 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1090 TS-4949: Disables the fuzzy revalidation logic by default You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4949

[GitHub] trafficserver pull request #1087: TS-4945: Remove unused member variable, ep...

2016-10-10 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1087 TS-4945: Remove unused member variable, epoll_vc CID 1364096 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4945

[GitHub] trafficserver pull request #1076: TS-4929: No loading of HostDB disk file if...

2016-10-06 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1076 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1076: TS-4929: No loading of HostDB disk file if sync_f...

2016-10-05 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1076 Yes, they would have TTLs, but if I turned off syncing, I certainly wouldn't expect it to load something old. What if I had bad entries? What if I had a corruption of some sort? Since

[GitHub] trafficserver issue #1078: TS-4930: Unfolds request headers that are using o...

2016-10-04 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1078 Try build on freebsd again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1074: TS-4925: Manager pollMgmtProcessServer stuck with...

2016-10-04 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1074 I'd imagine this is a backport candidate for at least 7.0.0, maybe 6.2.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #1074: TS-4925: Manager pollMgmtProcessServer stuck with...

2016-10-04 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1074 @gtenev Can you review this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1078: TS-4930: Unfolds request headers that are ...

2016-10-04 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1078 TS-4930: Unfolds request headers that are using obs continuations I also removed a file that is basically a duplication of another file, and this duplicated file is not used at all

[GitHub] trafficserver pull request #1076: TS-4929: No loading of HostDB disk file if...

2016-10-04 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1076 TS-4929: No loading of HostDB disk file if sync_frequency=0 This has two benefit (2) is most important I think: 1) We avoid warnings on startup about not being able to load the HostDB

[GitHub] trafficserver issue #1071: Support new 'Forwarded' standard (RFC7239)

2016-10-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1071 Right, but your comments say "replaces". I think we should keep both, indefinitely. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1071: Support new 'Forwarded' standard (RFC7239)

2016-10-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1071 We should make the old behavior optional to enable as well, there's a significant number of backends (origins) that do not support RFC7239 yet but need the old semantics. --- If your

[GitHub] trafficserver issue #1067: TS-4914: Fix response headers on 304 response

2016-09-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1067 Mostly out of curiosity, is there a particular header here in the (limited) set of headers that is likely to have multi-values? --- If your project is set up for it, you can reply

[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1

2016-09-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1066 I'm generally ok with this, up to you if you wish to clean anything up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1066: [TS-4457] Via header always reports http1

2016-09-30 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1066#discussion_r81416662 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -812,26 +813,16 @@ HttpTransactHeaders::insert_via_header_in_response(HttpTransact::State *s, HTTPH

[GitHub] trafficserver pull request #1066: [TS-4457] Via header always reports http1

2016-09-30 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1066#discussion_r81413339 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -812,26 +813,16 @@ HttpTransactHeaders::insert_via_header_in_response(HttpTransact::State *s, HTTPH

[GitHub] trafficserver pull request #1066: [TS-4457] Via header always reports http1

2016-09-30 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1066#discussion_r81411258 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -812,26 +813,16 @@ HttpTransactHeaders::insert_via_header_in_response(HttpTransact::State *s, HTTPH

[GitHub] trafficserver pull request #1066: [TS-4457] Via header always reports http1

2016-09-30 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1066#discussion_r81415497 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -812,26 +813,16 @@ HttpTransactHeaders::insert_via_header_in_response(HttpTransact::State *s, HTTPH

[GitHub] trafficserver issue #502: AARCH64 fixes tested on Cavium ThunderX

2016-09-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/502 Ping on this? Do we still want to move along with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1055: TS-4899: Http2ClientSession object leaks.

2016-09-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1055 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1025: TS-4872: Fix clang-analyzer leak error on LogObje...

2016-09-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1025 Should we land this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1052: TS-4813: Fix lingering stream.

2016-09-28 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1052 I tried this on docs, and it fails fast: ``` (gdb) bt #0 0x740305f7 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1

[GitHub] trafficserver pull request #1035: TS-4866: Makes traffic_cop killing optiona...

2016-09-22 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1035 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #963: TS-4815 - CID 1267839 dead code in /mgmt/api/CfgCo...

2016-09-21 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/963 @ngara Maybe I'm reading this wrong, but it looks like we still have 3 commits in this PR. If that's the case, can you please squash that down into a single commit? No reason to have the 2

[GitHub] trafficserver issue #1028: TS-4870 Avoid marking storage offline multiple ti...

2016-09-20 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1028 @jpeach we ok to land this now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1035: TS-4866: Makes traffic_cop killing optiona...

2016-09-20 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1035 TS-4866: Makes traffic_cop killing optional This adds a new configuration option, proxy.config.cop.active_health_checks: 0 - traffic_cop is not allowed to kill any processes 1

[GitHub] trafficserver pull request #749: TS-4506 Don't remove Expires/Last-Modifed o...

2016-09-15 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/749 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1024: TS-4858: fix memory leak of global_default_keyblo...

2016-09-15 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1024 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #993: TS-4068: Changes default for server_ports t...

2016-09-14 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/993 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #993: TS-4068: Changes default for server_ports to inclu...

2016-09-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/993 Alan, no, it'll work afaik. It'll only fail if you go out of the way and remove the IPv6 kernel module. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1014: TS-4861: Turn ECONNRESET into an end-of-file.

2016-09-13 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1014 Please test on docs, cursory code review looks good. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #995: TS-4731: Changes return codes for IsInterna...

2016-09-13 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/995 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1010: Fix remap filtering for nonstandard methods

2016-09-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1010 Clang-forma, trailing white spaces here: ```C++ -} else { +} else { ``` --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1010: Fix remap filtering for nonstandard methods

2016-09-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1010 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1009: TS-4853 : Parent Consistent Hash Selection - add ...

2016-09-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1009 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1007: TS-4703: Add API to retrieve client protocols

2016-09-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1007 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1006: TS-3743: Avoid crash due to accessing dead sessio...

2016-09-11 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1006 Clang format i think --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #834: TS-4707 : Parent Consistent Hash Selection - add f...

2016-09-10 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/834 IMO, the proposal of fname and maxdirs is a bit of a hack, solving a subset of all possible use cases. Allowing for a "parent selection URL" that can be the same, or diffe

[GitHub] trafficserver pull request #834: TS-4707 : Parent Consistent Hash Selection ...

2016-09-10 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/834#discussion_r78286562 --- Diff: proxy/api/ts/ts.h --- @@ -1481,6 +1481,9 @@ tsapi TSReturnCode TSHttpTxnParentProxyGet(TSHttpTxn txnp, const char **hostname

[GitHub] trafficserver pull request #1004: TS-4641 Changes default for proxy.config.c...

2016-09-09 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1004 TS-4641 Changes default for proxy.config.cache.hostdb.sync_frequency … …to 0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop

[GitHub] trafficserver pull request #1003: TS-4752 Changes CFLAGS from -std=gnu99 to ...

2016-09-09 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1003 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1003: TS-4752 Changes CFLAGS from -std=gnu99 to -std=c1...

2016-09-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1003 It's a bummer, but seems devtoolset-3 on CentOS6 does not agree with -std=c11. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #1003: TS-4752 Changes CFLAGS from -std=gnu99 to ...

2016-09-09 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1003 TS-4752 Changes CFLAGS from -std=gnu99 to -std=c11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4752

[GitHub] trafficserver issue #977: TS-4657: SNI hook sends hook ID for events

2016-09-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/977 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #995: TS-4731: Changes return codes for IsInterna...

2016-09-08 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/995 TS-4731: Changes return codes for IsInternal APIs This changes the following APIs: tsapi int TSHttpTxnIsInternal(TSHttpTxn txnp); tsapi int TSHttpSsnIsInternal(TSHttpSsn ssnp

[GitHub] trafficserver issue #995: TS-4731: Changes return codes for IsInternal APIs

2016-09-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/995 Whomever is reviewing: Please make sure I got all the conditionals right, with the correct boolean logic. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #991: TS-4503: Remove the class ErrorClass and all its c...

2016-09-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/991 ``` ../../proxy/http/remap/UrlMapping.h:30:19: fatal error: Error.h: No such file or directory #include "Error.h" ``` --- If your project is set up for it, you

[GitHub] trafficserver pull request #993: TS-4068: Changes default for server_ports t...

2016-09-08 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/993 TS-4068: Changes default for server_ports to include IPv6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-4068

[GitHub] trafficserver issue #984: TS-4747: if the connection of parent is not alive,...

2016-09-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/984 Looks reasonable to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #701: TS-4522: Should signal SM with EVENT_ERROR on erro...

2016-09-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/701 Status on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #989: TS-4828: gcc warning comparison between signed and...

2016-09-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/989 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #977: TS-4657: SNI hook sends hook ID for events

2016-09-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/977 Looks good, but fails on FreeBSD for some reason: {code} ../../../iocore/net/SSLUtils.cc:384:27: error: use of undeclared identifier 'TS_SSL_CERT_EVENT'; did you mean

<    1   2   3   4   5   6   7   8   9   >